Patch 17/17 of v4 failed to arrive in my inbox for some reason, so
I'll just reply to v3 since there's another error I noticed which is
still present in v4, plus a comment specific to v4 (see below).
On Mon, Jan 27, 2014 at 3:33 PM, Christian Couder
wrote:
> From: Eric Sunshine
>> On Sun, Jan 26
Christian Couder writes:
>> I find it a bad taste to allow unbound set of on the LHS of
>> '=' on the command line, but that is a separate issue in the design,
>> not in the documentation of the design.
>
> I don't understand this sentence, sorry.
It is a bad design taste to structure the comma
From: Junio C Hamano
Subject: Re: [PATCH v3 17/17] Documentation: add documentation for 'git
interpret-trailers'
Date: Mon, 27 Jan 2014 13:20:18 -0800
> Christian Couder writes:
>
>>>> +'git interpret-trailers' [--trim-empty] [--infile=file]
>>&
Christian Couder writes:
>>> +'git interpret-trailers' [--trim-empty] [--infile=file]
>>> [...]
>>
>> Would it be more consistent with existing documentation to format this as so?
>>
>> [--infile=] [[=]]...
>
> No, it would be very inconsistent:
>
> $ grep '\.\.\.\]' *.txt | wc -l
> 103
> $
From: Eric Sunshine
>
> On Sun, Jan 26, 2014 at 12:00 PM, Christian Couder
> wrote:
>> Signed-off-by: Christian Couder
>> ---
>> diff --git a/Documentation/git-interpret-trailers.txt
>> b/Documentation/git-interpret-trailers.txt
>> new file mode 100644
>> index 000..f74843e
>> --- /dev/null
On Sun, Jan 26, 2014 at 12:00 PM, Christian Couder
wrote:
> Signed-off-by: Christian Couder
> ---
> diff --git a/Documentation/git-interpret-trailers.txt
> b/Documentation/git-interpret-trailers.txt
> new file mode 100644
> index 000..f74843e
> --- /dev/null
> +++ b/Documentation/git-interpr
6 matches
Mail list logo