Re: [RFC WIP PATCH 2/3] tag: factor out prepare tag template code

2019-10-09 Thread Junio C Hamano
Junio C Hamano writes: > Lucas Oshiro writes: > >> Improve code readability by moving tag body reading to a new function called >> get_tag_body. > > Quite honestly, I think the result of this splitting is harder to > follow than the original. > > For example, the value of opt->message_given and

Re: [RFC WIP PATCH 2/3] tag: factor out prepare tag template code

2019-10-09 Thread Junio C Hamano
Lucas Oshiro writes: > Improve code readability by moving tag body reading to a new function called > get_tag_body. Quite honestly, I think the result of this splitting is harder to follow than the original. For example, the value of opt->message_given and the validity of given_msg is very clos

Re: [RFC WIP PATCH 2/3] tag: factor out prepare tag template code

2019-10-08 Thread Matheus Tavares Bernardino
On Tue, Oct 8, 2019 at 3:47 PM Lucas Oshiro wrote: > > Improve code readability by moving tag body reading to a new function called > get_tag_body. This function will be used in the following patches to fix the > --no-edit flag. This seems to be accidentally duplicated from patch 1/3. > Enhance