On Sun, Nov 11, 2012 at 09:02:48AM +0200, Kalle Olavi Niemitalo wrote:
> If git did the same thing as cvs here, i.e. ignore the signals in
> the parent process only and check the exit status of the editor,
> I think that would be OK.
Silly me. When I thought through the impact of Paul's patch, I
Kalle Olavi Niemitalo writes:
> and neither process blocked any signals (not even SIGCHLD as system(3)
> would).
If you don't have a SIGCHLD handler it won't matter anyway.
Andreas.
--
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4E
Paul Fox writes:
> you're sending SIGINT to the cvs commit command, and that causes the
> editor to die right away?
That's right. It is not a quirk of shell-mode in Emacs, because
I get the same result with ^C in xterm too.
% EDITOR="$HOME/prefix/x86_64-unknown-linux-gnu/bin/emacsclient --curr
kalle olavi niemitalo wrote:
> Paul Fox writes:
>
> > when i implemented the change, i wondered if some twisted emacs
> > workflow would be an issue. ;-) and i almost blocked SIGQUIT as
> > well -- the two programs i looked at for precedent (CVS and MH) both
> > block both SIGQUIT and SIGI
Kalle Olavi Niemitalo writes:
> With strace, it looks like CVS sets SIG_IGN as the handler of
> SIGINT and SIGQUIT only in the parent process after forking, not
> in the child process that executes the editor.
>
> CVS also temporarily blocks signals by calling sigprocmask, but
> it undoes that be
SZEDER Gábor writes:
>> I think it is better to keep the tests simple and maintainable.
>
> Maintainable? There is nothing to maintain here
> ...
> OTOH, this series has some serious drawbacks.
>
> It makes debugging more difficult
Are these referring to the same aspect of the series?
Paul Fox writes:
> when i implemented the change, i wondered if some twisted emacs
> workflow would be an issue. ;-) and i almost blocked SIGQUIT as
> well -- the two programs i looked at for precedent (CVS and MH) both
> block both SIGQUIT and SIGINT when spawning an editor.
>
> but since emacs
On Sat, Nov 10, 2012 at 1:32 PM, SZEDER Gábor wrote:
> Hi,
>
> On Fri, Nov 09, 2012 at 07:33:31PM -0500, Jeff King wrote:
>> On Sat, Nov 10, 2012 at 12:21:48AM +0100, Felipe Contreras wrote:
>> > > * fc/completion-test-simplification (2012-10-29) 2 commits
>> > > - completion: simplify __gitcomp
Jeff King writes:
> On Fri, Nov 09, 2012 at 12:27:35PM -0800, Junio C Hamano wrote:
>
>> What we should have arranged was to have https://github.com/git/git
>> (which is not even owned by me, but I asked somebody at GitHub to
>> assign me a write privilege) writable by the interim maintainer, so
kalle olavi niemitalo wrote:
> Jeff King writes:
>
> > Comments welcome from people using unusual editors (e.g., a script that
> > starts an editor in another window then blocks, waiting for the user to
> > finish).
>
> I often run a shell in Emacs in X, then start git commit in that
Hi,
On Fri, Nov 09, 2012 at 07:33:31PM -0500, Jeff King wrote:
> On Sat, Nov 10, 2012 at 12:21:48AM +0100, Felipe Contreras wrote:
> > > * fc/completion-test-simplification (2012-10-29) 2 commits
> > > - completion: simplify __gitcomp test helper
> > > - completion: refactor __gitcomp related te
On Sat, Nov 10, 2012 at 1:33 AM, Jeff King wrote:
> On Sat, Nov 10, 2012 at 12:21:48AM +0100, Felipe Contreras wrote:
>
>> > * fc/fast-export-fixes (2012-11-08) 14 commits
>> > - fast-export: don't handle uninteresting refs
>> > - fast-export: make sure updated refs get updated
>> > - fast-expo
On Fri, Nov 09, 2012 at 12:27:35PM -0800, Junio C Hamano wrote:
> Jeff King writes:
>
> > I have not been pushing the individual topic branches to make life
> > easier for people who usually just track Junio's kernel.org repository,
> > and would not welcome suddenly getting a hundred extra remo
On Sat, Nov 10, 2012 at 12:21:48AM +0100, Felipe Contreras wrote:
> > * fc/fast-export-fixes (2012-11-08) 14 commits
> > - fast-export: don't handle uninteresting refs
> > - fast-export: make sure updated refs get updated
> > - fast-export: fix comparison in tests
> > - fast-export: trivial cl
Hi,
On Fri, Nov 9, 2012 at 8:23 PM, Jeff King wrote:
> * fc/fast-export-fixes (2012-11-08) 14 commits
> - fast-export: don't handle uninteresting refs
> - fast-export: make sure updated refs get updated
> - fast-export: fix comparison in tests
> - fast-export: trivial cleanup
> - remote-tes
Jeff King writes:
> Comments welcome from people using unusual editors (e.g., a script that
> starts an editor in another window then blocks, waiting for the user to
> finish).
I often run a shell in Emacs in X, then start git commit in that
shell. $EDITOR is emacsclient --current-frame, whi
Jeff King writes:
> I have not been pushing the individual topic branches to make life
> easier for people who usually just track Junio's kernel.org repository,
> and would not welcome suddenly getting a hundred extra remote branches.
> I can make them public if it makes life easier for people, b
On Fri, Nov 09, 2012 at 09:06:47PM +0100, Ralf Thielow wrote:
> > It seems that the repo doesn't contain the integration branches?!?
> >
> > $ git remote add peff git://github.com/peff/git.git
> > $ git fetch -v peff
> > From git://github.com/peff/git
> > * [new branch] maint -> peff/ma
On Fri, Nov 9, 2012 at 9:01 PM, Ralf Thielow wrote:
> On Fri, Nov 9, 2012 at 8:23 PM, Jeff King wrote:
>>
>> You can find the changes described here in the integration branches of
>> my repository at:
>>
>> git://github.com/peff/git.git
>
> It seems that the repo doesn't contain the integration
On Fri, Nov 9, 2012 at 8:23 PM, Jeff King wrote:
>
> You can find the changes described here in the integration branches of
> my repository at:
>
> git://github.com/peff/git.git
It seems that the repo doesn't contain the integration branches?!?
$ git remote add peff git://github.com/peff/git.g
What's cooking in git.git (Nov 2012, #02; Fri, 9)
--
Here are the topics that have been cooking. Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next
21 matches
Mail list logo
