[Github-comments] Re: [geany/geany] Add support for platform-specific keybindings (#1395)

2024-09-24 Thread Jiří Techet via Github-comments
I don't think this is about adding some specific keybindings to Geany itself but rather that GTK (the UI library that Geany uses) swallows key events and doesn't pass them to the system. One would probably have to study GTK code to see what's going on there. -- Reply to this email directly or

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-09-21 Thread Jiří Techet via Github-comments
> I will not do a code review but I intend to use the plugin with my work > project which has a huge Python code base and I'm very curious how it will > work and maybe I'm going to switch to the LSP approach completely but no > promises yet :). I'm _really_ interested in your feedback - some th

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-09-17 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 55232c5c44a2a5d1e43b82eb0ee1a9fe8467aa0b Backport fixes from the geany-lsp project -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/831c3ac506888d2ff7485bd3eae4022f622b901f..55232c5c44a2a5d1e43b82eb0ee1a9fe8467aa0b You are receiving this bec

[Github-comments] Re: [geany/geany] WIP: Nix lexer (PR #3954)

2024-09-16 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 8d8692b2eadc199a90c86fd0ec82f5b8230c661b WIP: Nix lexer -- View it on GitHub: https://github.com/geany/geany/pull/3954/files/6f0bd1d6a78fdf1ae909dd4c3ff4ace1da4505d9..8d8692b2eadc199a90c86fd0ec82f5b8230c661b You are receiving this because you are subscribed to this thre

[Github-comments] [geany/geany] WIP: Nix lexer (PR #3954)

2024-09-16 Thread Jiří Techet via Github-comments
@frlan Christmas ;-) This is a work-in-progress Nix lexer I plan to submit to Lexilla but I'd like some feedback from @frlan as he's the most proficient Nix user around. Things should mostly work, I'm just aware of a problem regarding folding when a block ends and is followed by a multiline str

[Github-comments] Re: [geany/geany] Modify utils_write_file() to always use g_file_replace_contents() (PR #3950)

2024-09-16 Thread Jiří Techet via Github-comments
For completeness, I went through other uses of `fwrite()` and `g_file_set_contents()`: - `fwrite()` is used in tag manager to write some auxiliary file when generating tag files - pretty much OK since this is just a temporary file (TM doesn't have access to the rest of Geany ATM so it cannot use

[Github-comments] Re: [geany/geany] Also use GIO when using utils_write_file() (PR #3947)

2024-09-16 Thread Jiří Techet via Github-comments
> Saving document files still needs the options for the reasons explained in my > file saving > [thesis](https://wiki.geany.org/config/all_you_never_wanted_to_know_about_file_saving) > but thats not so relevant to keyfiles. By the way, one thing the "thesis" doesn't mention is the use of `fsync

[Github-comments] Re: [geany/geany] Default configuration restored, presumably upon system shutdown, randomly (Issue #3946)

2024-09-14 Thread Jiří Techet via Github-comments
The idea with (1) was to get some baseline regarding how often it happens. Is it every restart, every 5 restarts, every 10 restarts? Then, when you know that it e.g. happened every 3 restarts in (1) and you restarted the computer 10 times with (2) without any problem, we can be pretty sure thi

[Github-comments] Re: [geany/geany] Default configuration restored, presumably upon system shutdown, randomly (Issue #3946)

2024-09-13 Thread Jiří Techet via Github-comments
> I'm not sure I'm following you there. Like I said in > https://github.com/geany/geany/issues/3946#issuecomment-2345794726 the option > is already unchecked. I don't really understand what you want me to do > exactly... In (1) above to verify you are still able to reproduce the issue (by havin

[Github-comments] Re: [geany/geany] Also use GIO when using utils_write_file() (PR #3947)

2024-09-13 Thread Jiří Techet via Github-comments
> Thats why I keep plugging it, it would be a tiny @techee change (<3 lines > ;-) to save buffers and their associated document settings in the config > directory, it could even be in save actions plugin. Futile ;-). No more heroic projects for the near future. > My suggestion is that all k

[Github-comments] Re: [geany/geany] Also use GIO when using utils_write_file() (PR #3947)

2024-09-13 Thread Jiří Techet via Github-comments
Closed #3947. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3947#event-14247982876 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Modify utils_write_file() to always use g_file_replace_contents() (PR #3950)

2024-09-13 Thread Jiří Techet via Github-comments
>From having a look at where this function is used, by Geany it's used only >to store configuration files in the .config directory and some auxiliary >functions like writing the export file by the exporter plugin. In the >geany-plugins project this function is used only for saving configuration

[Github-comments] Re: [geany/geany] Fix indentation to suppress clangd warnings (PR #3948)

2024-09-13 Thread Jiří Techet via Github-comments
Merged #3948 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3948#event-14244901311 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add the .cache directory to .gitignore (PR #3949)

2024-09-13 Thread Jiří Techet via Github-comments
> LGBI but a question, if clangd needs a meson build to get the > compile_commands.json why doesn't it use the build/.cache/clangd directory? No idea but my guess is to preserve the cached files also when you wipe the build directory - e.g. you add a a new file to the build system. I would guess

[Github-comments] Re: [geany/geany] Add the .cache directory to .gitignore (PR #3949)

2024-09-13 Thread Jiří Techet via Github-comments
Merged #3949 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3949#event-14244873985 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add the .cache directory to .gitignore (PR #3949)

2024-09-12 Thread Jiří Techet via Github-comments
I unintentionally pushed the same commit directly to geany-plugins without making a pull request, sorry for that. If it's a problem, it can be reverted. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3949#issuecomment-2346476471 You are receiving this b

[Github-comments] [geany/geany] Add the .cache directory to .gitignore (PR #3949)

2024-09-12 Thread Jiří Techet via Github-comments
This is where clangd stores its precompiled files. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3949 -- Commit Summary -- * Add the .cache directory to .gitignore -- File Changes -- M .gitignore (1) -- Patch Links -- https://gith

[Github-comments] [geany/geany] Fix indentation to suppress clangd warnings (PR #3948)

2024-09-12 Thread Jiří Techet via Github-comments
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3948 -- Commit Summary -- * Fix indentation to suppress clangd warnings -- File Changes -- M src/editor.c (3) M src/libmain.c (3) M src/ui_utils.c (6) -- Patch Links -- https:

[Github-comments] Re: [geany/geany] Also use GIO when using utils_write_file() (PR #3947)

2024-09-12 Thread Jiří Techet via Github-comments
As you mentioned in https://github.com/geany/geany/issues/3946, using the GIO method only might be best for config files indeed and I can modify the patch if this is the preferred way. With this patch I just wanted to make sure that `fwrite()` isn't used as the default method for saving config f

[Github-comments] Re: [geany/geany] Default configuration restored, presumably upon system shutdown, randomly (Issue #3946)

2024-09-12 Thread Jiří Techet via Github-comments
It would be best if you could verify that that enabling `files.use_atomic_file_saving` fixes your problem - then we'd be sure the problem is the file saving method and not something else. That would however require something like this: 1. Disable `files.use_atomic_file_saving` and keep restartin

[Github-comments] Re: [geany/geany] Also use GIO when using utils_write_file() (PR #3947)

2024-09-12 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 12fdaaf91ffb69d19077f5d0482174145e393b28 Also use GIO when using utils_write_file() -- View it on GitHub: https://github.com/geany/geany/pull/3947/files/5271cbdc1ea5168ed5a52ad11844e1b87aa48cf6..12fdaaf91ffb69d19077f5d0482174145e393b28 You are receiving this because yo

[Github-comments] [geany/geany] Also use GIO when using utils_write_file() (PR #3947)

2024-09-12 Thread Jiří Techet via Github-comments
This patch unifies the behavior of utils_write_file() with write_data_to_disk() so all 3 methods of file saving are supported. >From having a look at where this function is used, by Geany it's used only >to store configuration files in the .config directory and some auxiliary >functions like wr

[Github-comments] Re: [geany/geany] Default configuration restored, presumably upon system shutdown, randomly (Issue #3946)

2024-09-12 Thread Jiří Techet via Github-comments
> The default setting is use_gio_unsafe_file_saving which does the same as > use_atomic_file_saving Sadly, this is only true for saving documents which use https://github.com/geany/geany/blob/eea0a25d5de5914f6dfef99776c7a73e29dc6b5f/src/document.c#L1927 and not for anything else like config fil

[Github-comments] Re: [geany/geany] Default configuration restored, presumably upon system shutdown, randomly (Issue #3946)

2024-09-11 Thread Jiří Techet via Github-comments
@3-14152898 Do you have `files.use_atomic_file_saving` enabled under Preferences->Various? If I'm not mistaken, it's not enabled by default and with the normal `fwrite()` method that Geany uses otherwise it might happen that when you shutdown your system, the written data won't get flushed to th

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-09-11 Thread Jiří Techet via Github-comments
Alright, I've pushed the latest version here with squashed commits. Apart from bugfixes (if some bugs appear), I don't plan anything more for this release. Please let me know what needs to be done to get the plugin merged to geany-plugins. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-09-11 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 831c3ac506888d2ff7485bd3eae4022f622b901f Add LSP plugin -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/5fba42b151a2385651095887864cb18176fa406f..831c3ac506888d2ff7485bd3eae4022f622b901f You are receiving this because you are subscribed to t

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-09-10 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 5fba42b151a2385651095887864cb18176fa406f Add LSP plugin -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/ad82d3c9c3a0604082cf208379b53c620791127c..5fba42b151a2385651095887864cb18176fa406f You are receiving this because you are subscribed to t

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-09-10 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. ad82d3c9c3a0604082cf208379b53c620791127c Add LSP plugin -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/78a2cd6b62643d53deb876b1e8bf6a9d60128d30..ad82d3c9c3a0604082cf208379b53c620791127c You are receiving this because you are subscribed to t

[Github-comments] Re: [geany/geany] Don't call plugin extension functions when opening session files (PR #3945)

2024-09-10 Thread Jiří Techet via Github-comments
Merged #3945 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3945#event-14199661175 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Don't call plugin extension functions when opening session files (PR #3945)

2024-09-10 Thread Jiří Techet via Github-comments
Pretty much the same as https://github.com/geany/geany/pull/3943 so merging right away. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3945#issuecomment-2340921005 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Don't call plugin extension functions when opening session files (PR #3945)

2024-09-10 Thread Jiří Techet via Github-comments
Without this, the symbol_highlight_provided() function is called for all the session files which starts LSP servers for all filetypes of the open files instead of lazily as the file tabs of individual files get selected. You can view, comment on, or merge this pull request online at: https://

[Github-comments] Re: [geany/geany] Don't call plugin extension functions when quitting or closing all files (PR #3943)

2024-09-10 Thread Jiří Techet via Github-comments
Merged #3943 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3943#event-14198582245 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Don't call plugin extension functions when quitting or closing all files (PR #3943)

2024-09-06 Thread Jiří Techet via Github-comments
Plugins may need to call the _provided() function e.g. inside Scintilla event handler which can get called for every file when batch-closing a session. For the LSP plugin, the _provided() call then keeps starting the server even though it should be terminated when closing project or quitting Gea

[Github-comments] Re: [geany/geany] Thumbs up hunt (Issue #3938)

2024-08-29 Thread Jiří Techet via Github-comments
> I don't understand what you have against having nominated supporters of > languages? Does the world fall down if we have someone to ping when an issue > about filetype X is raised? OMG, this is getting absurd. Don't you see the reality? Geany is a really niche editor which man-power-wise can

[Github-comments] Re: [geany/geany] Thumbs up hunt (Issue #3938)

2024-08-27 Thread Jiří Techet via Github-comments
> Geany devs can create any filetype, but supporting it well is different. > There have been some atrocious highlighting mappings when the person who made > them didn't understand the language, similarly there have been some poor > categorisation of symbols (usually to C categories, not all lang

[Github-comments] Re: [geany/geany] Thumbs up hunt (Issue #3938)

2024-08-27 Thread Jiří Techet via Github-comments
> Edit: to be clear binary size == memory to load it into, plus there is heap > memory used as well as a filetype and lexer and parser is created, but really > all that needs actual benchmarking. To be clear, not ;-). See above. > And of course the UI is cluttered by all filetypes ATM, and ther

[Github-comments] Re: [geany/geany] Thumbs up hunt (Issue #3938)

2024-08-27 Thread Jiří Techet via Github-comments
> Oh, and "proper" VCS-ing does not mean committing intermediate changes for > backups, unlike Geany's git a "proper" VCS is buildable at every commit and > preferably even runnable, that way git blame will work. So saving backups is > back in Geany's court. I didn't mean to use it for back up

[Github-comments] Re: [geany/geany] Thumbs up hunt (Issue #3938)

2024-08-23 Thread Jiří Techet via Github-comments
> Don't worry, just sit quietly in a dark room and the feeling will soon pass 😜 I feel I need to lock myself in the cellar for one year to achieve this :-) > The "persistent temp files" (PTF) is rather disappointing to me having been > saved by nice vscode when there was a power cut. What vscode

[Github-comments] [geany/geany] Thumbs up hunt (Issue #3938)

2024-08-23 Thread Jiří Techet via Github-comments
After spending a lot of time on things like tag manager where nobody sees any difference, I got quite a radical idea that it would be nice to start working on things that somebody wants ;-). Assuming that "thumbs up" is a good proxy to "I want this", this translates to: https://github.com/user-

[Github-comments] Re: [geany/geany] [Enhancement] Lexer-integration for the Nim/Nimrod-language (Issue #3520)

2024-08-18 Thread Jiří Techet via Github-comments
Done by https://github.com/geany/geany/pull/3648. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3520#issuecomment-2295250251 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] [Enhancement] Lexer-integration for the Nim/Nimrod-language (Issue #3520)

2024-08-18 Thread Jiří Techet via Github-comments
Closed #3520 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3520#event-13921992919 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add TOML support (PR #3934)

2024-08-18 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. 704c6c232fe278a1f7782a272c5de3bc85337db2 Add TOML support 9eacd84381c1e8efcf4b3bb4a67b1c44c77d4818 Modify iniconv parser to allow . and - in keys -- View it on GitHub: https://github.com/geany/geany/pull/3934/files/cb86e33b60c38cd3a6301f27b34278ad8d623471..9eacd84381

[Github-comments] Re: [geany/geany] Convert Nim to builtin filetype and use Scintilla Nim lexer for it (PR #3648)

2024-08-18 Thread Jiří Techet via Github-comments
Merged #3648 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3648#event-13921906911 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add TOML support (PR #3934)

2024-08-16 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. cb86e33b60c38cd3a6301f27b34278ad8d623471 Fix spaces between dots incorrectly marked as errors -- View it on GitHub: https://github.com/geany/geany/pull/3934/files/39a9f53314d628eeab413b1fd5d6c8a96d86e030..cb86e33b60c38cd3a6301f27b34278ad8d623471 You are receiving this

[Github-comments] Re: [geany/geany] Convert Nim to builtin filetype and use Scintilla Nim lexer for it (PR #3648)

2024-08-16 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 3c6021ee6614d987b7b6bfcb4eab1c049b067732 Convert Nim to builtin filetype and use Scintilla Nim lexer for it -- View it on GitHub: https://github.com/geany/geany/pull/3648/files/32798fd1996116487b7c8b7e463ceae035bd8e52..3c6021ee6614d987b7b6bfcb4eab1c049b067732 You are r

[Github-comments] Re: [geany/geany] Add Prolog filetype support (PR #3171)

2024-08-16 Thread Jiří Techet via Github-comments
Merged #3171 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3171#event-13915100390 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Prolog highlight for .pl files (Issue #3086)

2024-08-16 Thread Jiří Techet via Github-comments
Closed #3086 as completed via #3171. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3086#event-13915100690 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add TOML support (PR #3934)

2024-08-16 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 39a9f53314d628eeab413b1fd5d6c8a96d86e030 Modify iniconv parser to allow . and - in keys -- View it on GitHub: https://github.com/geany/geany/pull/3934/files/78ebd326c5f93e47bec8ac96d8da51ad1e7ceffe..39a9f53314d628eeab413b1fd5d6c8a96d86e030 You are receiving this becaus

[Github-comments] Re: [geany/geany-osx] Build failure on macOS: `error: conflicting types for 'scandir'; have 'int(const char *, struct dirent ***, int (*)(const struct dirent *), int (*)(const struct

2024-08-16 Thread Jiří Techet via Github-comments
> Geany itself from the MacPorts portfile. OK, no idea, I think nobody uses MacPorts here. Better to report the problem there. I'd suggest using the official macOS Geany binary from https://www.geany.org/download/releases/ -- Reply to this email directly or view it on GitHub: https://github.c

[Github-comments] Re: [geany/geany] Add TOML support (PR #3934)

2024-08-16 Thread Jiří Techet via Github-comments
> Probably good idea nearing a release, import the ctags parser (and peg > infrastructure) with the next ctags update after release. I think there's no peg infrastructure - the peg parser generator generates a completely self-contained and standard ctags parser. Maybe it's completely irrational

[Github-comments] Re: [geany/geany] Add TOML support (PR #3934)

2024-08-16 Thread Jiří Techet via Github-comments
@dolik-rce Thanks for the info. For now at least I think we'll stick with the ini parser - see my reply in https://github.com/universal-ctags/ctags/pull/4052 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3934#issuecomment-2293307986 You are receiving t

[Github-comments] Re: [geany/geany-osx] Build failure on macOS: `error: conflicting types for 'scandir'; have 'int(const char *, struct dirent ***, int (*)(const struct dirent *), int (*)(const struct

2024-08-16 Thread Jiří Techet via Github-comments
@barracuda156 What exactly are you doing - are you trying to build Geany itself or something within Geany? The official instructions for building Geany are here: https://github.com/geany/geany-osx/blob/master/README.md -- Reply to this email directly or view it on GitHub: https://github.com/ge

[Github-comments] Re: [geany/geany] TOML configuration language support (#1268)

2024-08-15 Thread Jiří Techet via Github-comments
> What you mean is that "somebody" would have to implement and submit the lexer > to lexilla so others can share it. "Somebody" did: https://github.com/ScintillaOrg/lexilla/pull/261 See #3934. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1268#issu

[Github-comments] [geany/geany] Add TOML support (PR #3934)

2024-08-15 Thread Jiří Techet via Github-comments
This commit adds TOML configuration language support to Geany. It uses the recently merged Scintilla TOML lexer; for ctags parsing it uses the conf file parser which works reasonably well for TOML as well. See https://github.com/ScintillaOrg/lexilla/pull/261 Fixes #1268 You can view, comment on

[Github-comments] Re: [geany/geany-plugins] [WishList] projectorganizer commander like interface (#599)

2024-08-15 Thread Jiří Techet via Github-comments
Closed #599 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/599#event-13893222640 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] [WishList] projectorganizer commander like interface (#599)

2024-08-15 Thread Jiří Techet via Github-comments
Implemented in https://github.com/geany/geany-plugins/pull/1341. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/599#issuecomment-2290879946 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Convert Nim to builtin filetype and use Scintilla Nim lexer for it (PR #3648)

2024-08-13 Thread Jiří Techet via Github-comments
> https://github.com/nim-lang/langserver By the way I tried that one but it kept crashing for me and I didn't spend much time investigating what went wrong. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3648#issuecomment-2285640771 You are receiving t

[Github-comments] Re: [geany/geany] Autocompletion plugins support (#1854)

2024-08-12 Thread Jiří Techet via Github-comments
Closed #1854 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1854#event-13847753970 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Go to a Symbol by typing name (#497)

2024-08-12 Thread Jiří Techet via Github-comments
Closed #497 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/497#event-13847723363 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Go to a Symbol by typing name (#497)

2024-08-12 Thread Jiří Techet via Github-comments
This was implemented by https://github.com/geany/geany-plugins/pull/1341 in the ProjectOrganizer plugin and is also present in the LSP plugin. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/497#issuecomment-2283826354 You are receiving this because yo

[Github-comments] Re: [geany/geany] [Feature Request] Provide auto completion for Swift Language. (#1078)

2024-08-12 Thread Jiří Techet via Github-comments
https://github.com/techee/geany-lsp together with https://github.com/swiftlang/sourcekit-lsp work based on my testing. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1078#issuecomment-2283701983 You are receiving this because you are subscribed to thi

[Github-comments] Re: [geany/geany] Convert Nim to builtin filetype and use Scintilla Nim lexer for it (PR #3648)

2024-08-12 Thread Jiří Techet via Github-comments
> Conflicts need resolving. I'm aware of that. But because I'll introduce other conflicts by merging https://github.com/geany/geany/pull/3171, I'll wait until that one is merged. > Its meant to be long lazy summer days 😛 Yeah, just merging stuff is lazy :-) -- Reply to this email directly or

[Github-comments] Re: [geany/geany] Convert Nim to builtin filetype and use Scintilla Nim lexer for it (PR #3648)

2024-08-11 Thread Jiří Techet via Github-comments
In addition to https://github.com/geany/geany/pull/3171 I'd like to merge this PR too so there's a proper lexer for the Nim language. I just went through the PR and tested it a bit and all seems to work well. Again, I'll wait for about a week for complaints and merge this afterwards. (Misusing

[Github-comments] Re: [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)

2024-08-11 Thread Jiří Techet via Github-comments
Merged #1341 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1341#event-13836577291 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Hide autocompletion and calltip popups when code scrolled (PR #3560)

2024-08-09 Thread Jiří Techet via Github-comments
Merged #3560 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3560#event-13826157875 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Hide autocompletion and calltip popups when code scrolled (PR #3560)

2024-08-09 Thread Jiří Techet via Github-comments
I didn't merge this PR last year because it was just before the release but I think the patch is safe and shouldn't cause any harm (I'm doing the same with the LSP plugin without any problems) so I'm merging it now. -- Reply to this email directly or view it on GitHub: https://github.com/geany/

[Github-comments] Re: [geany/geany] Hide autocompletion and calltip popups when code scrolled (PR #3560)

2024-08-09 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 12f56701eff1a8ac504fff7d0cfc4998811c05f7 Hide autocompletion and calltip popups when code scrolled -- View it on GitHub: https://github.com/geany/geany/pull/3560/files/d9feb87b0576ada78e366bf2edc6eff1bb3dd3e2..12f56701eff1a8ac504fff7d0cfc4998811c05f7 You are receiving

[Github-comments] Re: [geany/geany] Add Prolog filetype support (PR #3171)

2024-08-09 Thread Jiří Techet via Github-comments
I've rebased this poor PR stuck in limbo for two years on top of current master - I'll do some more self-review and testing and if there are no objections, I'd merge it it about a week. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3171#issuecomment-2

[Github-comments] Re: [geany/geany] Add Prolog filetype support (PR #3171)

2024-08-09 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. b804e83c5314bdea602f2cf3a329d35351163e05 Add Prolog filetype support 63f074a9074995c98dbeefe971ec5e2f4aca8f6e Update to the latest Prolog lexer -- View it on GitHub: https://github.com/geany/geany/pull/3171/files/fbba022836b92d3d7f2a841551996a4b7b87ac84..63f074a907499

[Github-comments] Re: [geany/geany] Add CIL lexer/filetype (PR #3480)

2024-08-09 Thread Jiří Techet via Github-comments
Merged. @killerbees19 Thanks for your contribution! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3480#issuecomment-2278774636 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add CIL lexer/filetype (PR #3480)

2024-08-09 Thread Jiří Techet via Github-comments
Merged #3480 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3480#event-13825737000 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Integrate lexer for CIL (Common Intermediate Language) (Issue #3305)

2024-08-09 Thread Jiří Techet via Github-comments
Closed #3305 as completed via #3480. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3305#event-13825737133 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Language server protocol support? (#2184)

2024-08-09 Thread Jiří Techet via Github-comments
If anyone is interested, I've created the LSP plugin here (eventually I'd like this plugin to become part of geany-plugins): https://github.com/techee/geany-lsp It requires the latest Geany from git master as some things had to be modified in Geany itself to support this kind of plugins. As far

[Github-comments] Re: [geany/geany-plugins] Plugin Request: Language server protocol (#1012)

2024-08-09 Thread Jiří Techet via Github-comments
If anyone is interested, I've created the LSP plugin here (eventually I'd like this plugin to become part of geany-plugins): https://github.com/techee/geany-lsp It requires the latest Geany from git master as some things had to be modified in Geany itself to support this kind of plugins. As far

[Github-comments] Re: [geany/geany] "persistent temp files" feature for saveactions plugin (sqashed PR) (PR #3911)

2024-08-07 Thread Jiří Techet via Github-comments
@techee requested changes on this pull request. Looks good and works well, again just some minor comments. I also noticed that I get ``` (geany:47456): Geany-CRITICAL **: 22:18:37.629: document_open_file_full: assertion 'filename' failed ``` when starting Geany with `geany some_nonexistent_file.

[Github-comments] Re: [geany/geany] "persistent temp files" feature for saveactions plugin (sqashed PR) (PR #3911)

2024-08-07 Thread Jiří Techet via Github-comments
@techee requested changes on this pull request. Looks good and works well (apart from the two nitpicky style comments). > the core issue with keeping right tab active after opening non-existent file > from console is related to fact that we cannot manually activate tab that > does not yet have

[Github-comments] Re: [geany/geany] Feature: Filter on file names the open file pane (Issue #3078)

2024-08-06 Thread Jiří Techet via Github-comments
Maybe not exactly this feature but I just added something similar to the ProjectOrganizer plugin in https://github.com/geany/geany-plugins/pull/1341: https://github.com/user-attachments/assets/7522f0a1-26d9-4976-9409-da933b0407b9";> It works similarly to vscode - when there's no prefix, it searc

[Github-comments] Re: [geany/geany] "persistent temp files" feature for saveactions plugin (sqashed PR) (PR #3911)

2024-08-05 Thread Jiří Techet via Github-comments
One more problem - when you launch Geany from the command-line by ``` geany some_file.txt ``` where `some_file.txt` doesn't exist yet, the file gets opened in a new tab but the "persistent temp file" becomes the active tab instead. I haven't checked the code what Geany does exactly but the file a

[Github-comments] Re: [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)

2024-08-05 Thread Jiří Techet via Github-comments
> What's still missing is updating the required Geany API once we bump it in > Geany. Done now. This PR is complete from my point of view. Unless there are any objections, I'll squash all the commits into one and merge this PR in about a week. -- Reply to this email directly or view it on Git

[Github-comments] Re: [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)

2024-08-05 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. c00e96f3cffae558ea43d2bb5dd4a0434dbcd1b8 Mention that search is performed both in open and project files in README -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1341/files/481f688f3b911ef000e859b02f51305ea5f3ec83..c00e96f3cffae558ea43d2bb5dd4a0434db

[Github-comments] Re: [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)

2024-08-05 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 481f688f3b911ef000e859b02f51305ea5f3ec83 Update required Geany API level -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1341/files/52ad718c2a847c145781d8b0750984e4f713364e..481f688f3b911ef000e859b02f51305ea5f3ec83 You are receiving this because you ar

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-08-03 Thread Jiří Techet via Github-comments
Merged #3849 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3849#event-13750265059 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-08-03 Thread Jiří Techet via Github-comments
The day has come, merging. 🎉 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3849#issuecomment-2266740331 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] "persistent temp files" feature for saveactions plugin (sqashed PR) (PR #3911)

2024-08-02 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + { + /* we have to store old filename inside document data to be able to somehow + pass it to document-save callback that is called directly after this one */ + plugin_set_d

[Github-comments] Re: [geany/geany] Add CIL lexer/filetype (PR #3480)

2024-08-02 Thread Jiří Techet via Github-comments
Looks good to me as well - I'll wait for about one week and if nobody has any objections, I'll merge this PR. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3480#issuecomment-2264931742 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-08-01 Thread Jiří Techet via Github-comments
> IIUC there was no code changes since my review, so looks good. And history > looks OK as well 👍 OK, if there are no objections, I'll merge this PR during the weekend and will start working on the final version of the plugin for geany-plugins so it can get merged too. I'll then announce the n

[Github-comments] Re: [geany/geany] Add CIL lexer/filetype (PR #3480)

2024-08-01 Thread Jiří Techet via Github-comments
@techee approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3480#pullrequestreview-2213409611 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add CIL lexer/filetype (PR #3480)

2024-08-01 Thread Jiří Techet via Github-comments
>> I've been thinking about it and maybe "persistent untitled documents" ... > @techee I think your comment should go to PR > https://github.com/geany/geany/pull/3911? 😄 > Because it's all Greek to me. 🙂 Good analysis :-). > This is already included in this PR since last year. ^^ Right, I mis

[Github-comments] Re: [geany/geany] "persistent temp files" feature for saveactions plugin (sqashed PR) (PR #3911)

2024-08-01 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > so i think this feature is complete, if we are considering merging it - Agree, I think it's mostly ready. I just had a look at the code once more and found some minor issues but nothing big. > we should settle on config UI (either keep as is or change

[Github-comments] Re: [geany/geany] Add CIL lexer/filetype (PR #3480)

2024-08-01 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > so i think this feature is complete, if we are considering merging it - Agree, I think it's mostly ready. I just had a look at the code once more and found some minor issues but nothing big. > we should settle on config UI (either keep as is or change

[Github-comments] Re: [geany/geany] Add CIL lexer/filetype (PR #3480)

2024-07-31 Thread Jiří Techet via Github-comments
>> This pull request is missing the meson build system support - in the >> meantime we updated HACKING so you should see which of the meson files you >> should modify. > LexCIL.cxx is already defined in this file? I'm not sure if I understand what you mean but you have to add the lexer into ht

[Github-comments] Re: [geany/geany] Add CIL lexer/filetype (PR #3480)

2024-07-31 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -15,6 +15,7 @@ BibTeX=*.bib; CAML=*.ml;*.mli; C=*.c;*.xpm; C++=*.cpp;*.cxx;*.c++;*.cc;*.h;*.hpp;*.hxx;*.h++;*.hh;*.C;*.H; +CIL=*.il OK, if there are bigger differences between the languages, it's really better to use CIL just for `*.il` files. -

[Github-comments] Re: [geany/geany] Add CIL lexer/filetype (PR #3480)

2024-07-31 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > +stringliteral=string +keyword=type +keyword2=keyword_2 +keyword3=keyword_1 +label=preprocessor +operator=operator +stringeol=string_eol +identifier=identifier_1 + +[keywords] +# Credits: Jad Altahan (github.com/xv) - https://sourceforge.net/p/scintilla

[Github-comments] Re: [geany/geany] Caret holding shift too long, or holding shift then typing a character after a space crashes Geany sometimes (race condition) (Issue #3927)

2024-07-21 Thread Jiří Techet via Github-comments
> Also, the Pascal ctags parser used to crash (in 1.38 which you are using) > because of https://github.com/geany/geany/issues/3127 which is fixed now. > Since in this case you are setting Pascal filetype for a Basic file, the > Pascal ctags parser will be very confused by the input (still, it s

[Github-comments] Re: [geany/geany] Caret holding shift too long, or holding shift then typing a character after a space crashes Geany sometimes (race condition) (Issue #3927)

2024-07-21 Thread Jiří Techet via Github-comments
Also, the Pascal ctags parser used to crash (in 1.38 which you are using) because of https://github.com/geany/geany/issues/3127 which is fixed now. Since in this case you are setting Pascal filetype for a Basic file, the Pascal ctags parser will be very confused by the input (still, it shouldn't

[Github-comments] Re: [geany/geany] "persistent temp files" feature for saveactions plugin (sqashed PR) (PR #3911)

2024-07-15 Thread Jiří Techet via Github-comments
> At any session change, including initial startup - we first load session and > then call load_all_temp_files_idle() which (re)loads all temp files and > changes active tab to last loaded temp file. I added a workaround to > re-activate originally active tab by re-opening it (i guess no other w

[Github-comments] Re: [geany/geany] "persistent temp files" feature for saveactions plugin (sqashed PR) (PR #3911)

2024-07-14 Thread Jiří Techet via Github-comments
> Added workaround to prevent temp files hijacking active tab on session change. What is this and where is the commit? >> when closing a temp file and choosing "Save", I'd suggest using some other >> default directory than the one where temp files are stored so users aren't >> tempted to store

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-07-10 Thread Jiří Techet via Github-comments
> Then, I would probably try to implement a python-lsp plugin in python, or do > you have a better idea? I'd suggest having a look at `plugins/demopluginext.c` that this PR adds and reimplementing it in Python. Then you can add the additional functions from this interface (for @elextr - pointer

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-07-10 Thread Jiří Techet via Github-comments
> FWIW, I would like to ensure peasy plugins can use this APIs. I'm going to try @kugel- Any progress here? I think this is the only thing that prevents this PR from being merged, right? There's still quite a lot things to do when this gets merged like finalizing the geany-plugins PR, updating d

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-07-10 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + gboolean (*goto_perform)(GeanyDocument *doc, gint pos, gboolean > definition, gpointer data); + + /** +* Pointer to function called by Geany to check whether the plugin implements +* additional symbol (e.g. type) highlightin

  1   2   3   4   5   6   7   8   9   10   >