Re: [PHP-DEV] Re: Git Migration: Status Update

2012-03-04 Thread Kris Craig
I was about to respond to Lester's comments but it looks like Jeremiah beat me to it (again). Yeah he's correct in that "bad habits" refers to using Git the same way you would use Subversion. It was not mean to refer to how you've used Subversion itself. @David Generally, I would resolve this by

[PHP-DEV] Re: Git Migration: Status Update

2012-03-04 Thread David Soria Parra
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/04/2012 10:32 AM, Jaroslav Hanslik wrote: >> >> (3) Karma system fixes. Already done by me. People who have >> access to the root of a repository are able to do forced pushes. >> > > > Do you think it's good idea not to forbid forced pushes a

Re: [PHP-DEV] Git Migration: Status Update

2012-03-04 Thread David Soria Parra
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/04/2012 02:09 PM, Stefan Marr wrote: > Hi David: > > On 03 Mar 2012, at 22:58, David Soria Parra wrote: > >> (1) Pull requests on github.com go to the git-pull mailinglist. >> Make sure you subscribe to it. (2) Johannes is working on an >> int

Re: [PHP-DEV] [RFC - Discussion] Parameter Type Casting Hints

2012-03-04 Thread Anthony Ferrara
On Mar 4, 2012 11:47 AM, "Lazare Inepologlou" wrote: > > > Anthony, just a tiny detail in your RCF: > >> So (int) $foo = null and (int) $foo = 1 are both supported, but (int) $foo = “1” will generate an E_COMPILE_ERROR. > > > If null is going to be cast, (int)null is 0. So I don't think it should

Re: [PHP-DEV] [RFC - Discussion] Parameter Type Casting Hints

2012-03-04 Thread Paul Dragoonis
It would make sense that the default value you're setting matches the zval.type of the casted value. You always want it to be an int, if you're doing (int) so setting it to a string or array would not make sense. - Paul. On Sun, Mar 4, 2012 at 4:46 PM, Lazare Inepologlou wrote: > Anthony, just

Re: [PHP-DEV] [RFC - Discussion] Parameter Type Casting Hints

2012-03-04 Thread Lazare Inepologlou
Anthony, just a tiny detail in your RCF: So (int) $foo = null and (int) $foo = 1 are both supported, but (int) $foo > = “1” will generate an E_COMPILE_ERROR. > If null is going to be cast, (int)null is 0. So I don't think it should be a valid default value. Lazare INEPOLOGLOU Ingénieur Logiciel

Re: [PHP-DEV] Git Migration: Status Update

2012-03-04 Thread Lester Caine
jeremiah.do...@gmail.com wrote: I hope that clarifies things a bit. It definitely doesn't make grokking things a whole lot easier, and it is certainly *possible* to follow a very svnish workflow using git (and may sometimes make sense to, although I am struggling to thing of such a time). I've

Re: [PHP-DEV] [RFC - Discussion] Parameter Type Casting Hints

2012-03-04 Thread Paul Dragoonis
Is (DateInterval) a valid cast currently in PHP ? If not, then we're not looking to add new fancy casting options, just give casting options on the simple existing ones. - Paul. On Sun, Mar 4, 2012 at 4:26 PM, Lazare Inepologlou wrote: >> I wouldn't want people to put class typehints in there s

Re: [PHP-DEV] [RFC - Discussion] Parameter Type Casting Hints

2012-03-04 Thread Lazare Inepologlou
> > I wouldn't want people to put class typehints in there such as > function foo( (SomeClass) $foo) > Why not? I would definitely like something like that, in the future. Here is an example: class DateTime { ... public function add( (DateInterval) $interval ) { ... } ... } $date = new Date

[PHP-DEV] Could somebody apply a patch for bug #61273

2012-03-04 Thread Nikita Popov
Hi! Could somebody with Zend karma please apply the patch attached to https://bugs.php.net/bug.php?id=61273 ? Thanks, Nikita -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Patches for Review

2012-03-04 Thread Gustavo Lopes
On Sun, 04 Mar 2012 15:02:23 +0100, Anthony Ferrara wrote: In sum, I think the rule that if a mathematical operation involves a float, the result should be a float ought to be kept. Yes, it is a must. Well, I'm not so sure about that. If you look at the docs of pow(), it describes the r

Re: [PHP-DEV] Git Migration: Status Update

2012-03-04 Thread jeremiah . dodds
Stefan Marr writes: > Hi David: > > On 03 Mar 2012, at 22:58, David Soria Parra wrote: > >> (1) Pull requests on github.com go to the git-pull mailinglist. >> Make sure you subscribe to it. >> (2) Johannes is working on an interface that allows people with >> valid PHP user accounts to cl

Re: [PHP-DEV] Git Migration: Status Update

2012-03-04 Thread jeremiah . dodds
Lester Caine writes: > Kris Craig wrote: >> I count myself lucky in that I started using Git before Subversion. People >> with that background often have an easier time at first because they aren't >> burdened with having to un-learn a bunch of "bad habits." > > I feel I HAVE to comment on that

Re: [PHP-DEV] [RFC - Discussion] Parameter Type Casting Hints

2012-03-04 Thread Paul Dragoonis
Good. On Sun, Mar 4, 2012 at 2:03 PM, Anthony Ferrara wrote: >> Can you make sure that only scalar or array casts can be done? >> >> I wouldn't want people to put class typehints in there such as >> function foo( (SomeClass) $foo) > > That's how it is implemented now.  That'll generate a parse er

Re: [PHP-DEV] [RFC - Discussion] Parameter Type Casting Hints

2012-03-04 Thread Anthony Ferrara
> Can you make sure that only scalar or array casts can be done? > > I wouldn't want people to put class typehints in there such as > function foo( (SomeClass) $foo) That's how it is implemented now. That'll generate a parse error... -- PHP Internals - PHP Runtime Development Mailing List To un

Re: [PHP-DEV] Patches for Review

2012-03-04 Thread Anthony Ferrara
>> In sum, I think the rule that if a mathematical operation involves a float, >> the result should be a float ought to be kept. > > Yes, it is a must. Well, I'm not so sure about that. If you look at the docs of pow(), it describes the return type as "base raised to the power of exp. If the resu

Re: [PHP-DEV] [RFC - Discussion] Parameter Type Casting Hints

2012-03-04 Thread Paul Dragoonis
Can you make sure that only scalar or array casts can be done? I wouldn't want people to put class typehints in there such as function foo( (SomeClass) $foo) - Paul. On Sun, Mar 4, 2012 at 1:28 AM, Anthony Ferrara wrote: > Hey all, > > I've drafted an RFC for the Parameter type casting hint pro

Re: [PHP-DEV] Patches for Review

2012-03-04 Thread Nikita Popov
On Sun, Mar 4, 2012 at 2:29 PM, Anthony Ferrara wrote: > Hey all, > [snip] > https://bugs.php.net/bug.php?id=60596 > A little code-cleanup to remove a superfluous if statement in a switch > in the spl_offset_convert_to_long function... Applied in http://svn.php.net/viewvc/?view=revision&revision=3

Re: [PHP-DEV] Patches for Review

2012-03-04 Thread Pierre Joye
On Sun, Mar 4, 2012 at 2:52 PM, Gustavo Lopes wrote: > In sum, I think the rule that if a mathematical operation involves a float, > the result should be a float ought to be kept. Yes, it is a must. -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PH

Re: [PHP-DEV] Patches for Review

2012-03-04 Thread Gustavo Lopes
On Sun, 04 Mar 2012 14:29:49 +0100, Anthony Ferrara wrote: I had messaged about these patches before, but with the 5.4 release process happening I think it slipped through the cracks. I have 3 patches that are ready for inclusion... [...] https://bugs.php.net/bug.php?id=60789 Bringing pow

[PHP-DEV] Re: [VOTE] Deprecate and remove /e modifier from preg_replace

2012-03-04 Thread Nikita Popov
The vote ended with 23 pro / 4 con. The /e modifier is now deprecated in trunk: http://svn.php.net/viewvc?view=revision&revision=323862 Nikita On Sun, Feb 12, 2012 at 7:34 PM, Nikita Popov wrote: > As there doesn't seem to be any further discussion regarding this > issue I have opened the vote:

[PHP-DEV] Patches for Review

2012-03-04 Thread Anthony Ferrara
Hey all, I had messaged about these patches before, but with the 5.4 release process happening I think it slipped through the cracks. I have 3 patches that are ready for inclusion... https://bugs.php.net/bug.php?id=60813 Adding a new hash_pbkdf2() function to allow for a C level implementation o

Re: [PHP-DEV] Git Migration: Status Update

2012-03-04 Thread Stefan Marr
Hi David: On 03 Mar 2012, at 22:58, David Soria Parra wrote: > (1) Pull requests on github.com go to the git-pull mailinglist. > Make sure you subscribe to it. > (2) Johannes is working on an interface that allows people with > valid PHP user accounts to close pull requests. > (2) Fix the

Re: [PHP-DEV] Git Migration: Status Update

2012-03-04 Thread Lester Caine
Kris Craig wrote: I count myself lucky in that I started using Git before Subversion. People with that background often have an easier time at first because they aren't burdened with having to un-learn a bunch of "bad habits." I feel I HAVE to comment on that statement. A 'different way of wor

Re: [PHP-DEV] Git Migration: Status Update

2012-03-04 Thread Kris Craig
+1 what Jeremiah said! I've noticed that people who are accustomed to Subversion tend to go into Git using the SVN branching mindset. While that does technically work in Git, it essentially misses the point. To illustrate, let's say a person from the 16th century travelled forward through time t

[PHP-DEV] Re: Git Migration: Status Update

2012-03-04 Thread Jaroslav Hanslik
(3) Karma system fixes. Already done by me. People who have access to the root of a repository are able to do forced pushes. Do you think it's good idea not to forbid forced pushes at all? Cheers Jaroslav -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: