[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-02-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/319 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-02-05 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/319#issuecomment-73031242 Rebased on Stephan's latest master branch containing the subslot release fix and reduced memory footprint of archived ExecutionGraphs. --- If your project is set up

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-26 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/319#issuecomment-71504706 To be honest, I have not seen this error before. But I doubt that this is a subslot release issue. If this error appears more often, then we could try to increa

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/319#issuecomment-71501654 Do you think this change is also addressing this error? https://travis-ci.org/rmetzger/flink/jobs/48365538 --- If your project is set up for it, you can reply to this

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-26 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/319#discussion_r23537642 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/SlotSharingGroupAssignment.java --- @@ -42,86 +44,82 @@ public c

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-26 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/319#discussion_r23537586 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/SlotAvailabilityListener.java --- @@ -21,7 +21,7 @@ import org.a

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-26 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/319#issuecomment-71477890 I think so too. The changes of the scheduler are only included because otherwise the test cases wouldn't pass. The scheduler relevant PR is #317. --- If your project

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-26 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/319#issuecomment-71458216 I think @StephanEwen is reviewing the critical part. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/319#issuecomment-71455790 This is a huge change. I took a look over the code, but I don't have enough experience with the scheduler to understand these changes. I would suggest to merge th

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-26 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/319#discussion_r23526978 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -329,6 +330,15 @@ public void unregisterMemoryManager(MemoryManage

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-26 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/319#discussion_r23526836 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/SlotSharingGroupAssignment.java --- @@ -42,86 +44,82 @@ public class

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-26 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/319#discussion_r23526787 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/SlotAvailabilityListener.java --- @@ -21,7 +21,7 @@ import org.apach

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-18 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/319 [FLINK-1415] Akka cleanups This PR removes the akka.jobmanager.url config parameter to override the jobmanager address and port set in the configuration. Adds timeout heuristics to dedu