[GitHub] flink pull request: [FLINK-1753] Extend KafkaITCase, reworked Pers...

2015-04-16 Thread mbalassi
Github user mbalassi commented on a diff in the pull request: https://github.com/apache/flink/pull/603#discussion_r28488904 --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaITCase.java --- @@ -709,4 +

[GitHub] flink pull request: [FLINK-1753] Extend KafkaITCase, reworked Pers...

2015-04-16 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/603#issuecomment-93665013 LGTM besides that one question. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[jira] [Commented] (FLINK-1753) Add more tests for Kafka Connectors

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497668#comment-14497668 ] ASF GitHub Bot commented on FLINK-1753: --- Github user mbalassi commented on the pull

[jira] [Commented] (FLINK-1753) Add more tests for Kafka Connectors

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497667#comment-14497667 ] ASF GitHub Bot commented on FLINK-1753: --- Github user mbalassi commented on a diff in

[GitHub] flink pull request: [FLINK-1753] Extend KafkaITCase, reworked Pers...

2015-04-16 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/603#discussion_r28489103 --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaITCase.java --- @@ -709,4 +

[jira] [Commented] (FLINK-1753) Add more tests for Kafka Connectors

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497671#comment-14497671 ] ASF GitHub Bot commented on FLINK-1753: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request: [FLINK-1875] Add figure explaining slots and p...

2015-04-16 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/604 [FLINK-1875] Add figure explaining slots and parallelism You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink flink1875 Alternatively

[jira] [Commented] (FLINK-1875) Add figure to documentation describing slots and parallelism

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497674#comment-14497674 ] ASF GitHub Bot commented on FLINK-1875: --- GitHub user rmetzger opened a pull request:

[jira] [Assigned] (FLINK-1875) Add figure to documentation describing slots and parallelism

2015-04-16 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-1875: - Assignee: Robert Metzger > Add figure to documentation describing slots and parallelism >

[GitHub] flink pull request: [FLINK-1753] Extend KafkaITCase, reworked Pers...

2015-04-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/603 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (FLINK-1753) Add more tests for Kafka Connectors

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497687#comment-14497687 ] ASF GitHub Bot commented on FLINK-1753: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-1753) Add more tests for Kafka Connectors

2015-04-16 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497691#comment-14497691 ] Robert Metzger commented on FLINK-1753: --- Added large record test in http://git-wip-

[jira] [Updated] (FLINK-1753) Add more tests for Kafka Connectors

2015-04-16 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-1753: -- Description: The current {{KafkaITCase}} is only doing a single test. We need to refactor that

[GitHub] flink pull request: [FLINK-1523][gelly] Vertex centric iteration e...

2015-04-16 Thread andralungu
Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/537#issuecomment-93696531 Hi @vasia , The PR was updated to include your suggestions. Last test fails for some reason, but that shouldn't get in the way of reviewers :) As you c

[jira] [Commented] (FLINK-1523) Vertex-centric iteration extensions

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497855#comment-14497855 ] ASF GitHub Bot commented on FLINK-1523: --- Github user andralungu commented on the pul

[jira] [Created] (FLINK-1892) Local job execution does not exit.

2015-04-16 Thread Kostas Tzoumas (JIRA)
Kostas Tzoumas created FLINK-1892: - Summary: Local job execution does not exit. Key: FLINK-1892 URL: https://issues.apache.org/jira/browse/FLINK-1892 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-1893) Add Scala support for Flink on Tez

2015-04-16 Thread Kostas Tzoumas (JIRA)
Kostas Tzoumas created FLINK-1893: - Summary: Add Scala support for Flink on Tez Key: FLINK-1893 URL: https://issues.apache.org/jira/browse/FLINK-1893 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-1894) Add Tez execution mode to Flink command-line tools

2015-04-16 Thread Kostas Tzoumas (JIRA)
Kostas Tzoumas created FLINK-1894: - Summary: Add Tez execution mode to Flink command-line tools Key: FLINK-1894 URL: https://issues.apache.org/jira/browse/FLINK-1894 Project: Flink Issue Type

[jira] [Created] (FLINK-1895) Add task chaining to Flink on Tez

2015-04-16 Thread Kostas Tzoumas (JIRA)
Kostas Tzoumas created FLINK-1895: - Summary: Add task chaining to Flink on Tez Key: FLINK-1895 URL: https://issues.apache.org/jira/browse/FLINK-1895 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-1896) Add broadcast variables feature to Flink on Tez

2015-04-16 Thread Kostas Tzoumas (JIRA)
Kostas Tzoumas created FLINK-1896: - Summary: Add broadcast variables feature to Flink on Tez Key: FLINK-1896 URL: https://issues.apache.org/jira/browse/FLINK-1896 Project: Flink Issue Type: I

[jira] [Created] (FLINK-1897) Add accummulators and counters feature to Flink on Tez

2015-04-16 Thread Kostas Tzoumas (JIRA)
Kostas Tzoumas created FLINK-1897: - Summary: Add accummulators and counters feature to Flink on Tez Key: FLINK-1897 URL: https://issues.apache.org/jira/browse/FLINK-1897 Project: Flink Issue

[jira] [Created] (FLINK-1898) Add support for self-joins to Flink on Tez

2015-04-16 Thread Kostas Tzoumas (JIRA)
Kostas Tzoumas created FLINK-1898: - Summary: Add support for self-joins to Flink on Tez Key: FLINK-1898 URL: https://issues.apache.org/jira/browse/FLINK-1898 Project: Flink Issue Type: Bug

[GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...

2015-04-16 Thread tammymendt
GitHub user tammymendt opened a pull request: https://github.com/apache/flink/pull/605 [FLINK-1297] Added OperatorStatsAccumulator for tracking operator related stats The accumulator tracks min and max values, and estimates for count distinct and heavy hitters. The count d

[jira] [Commented] (FLINK-1297) Add support for tracking statistics of intermediate results

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497903#comment-14497903 ] ASF GitHub Bot commented on FLINK-1297: --- GitHub user tammymendt opened a pull reques

[jira] [Created] (FLINK-1899) Table API Bug

2015-04-16 Thread Felix Neutatz (JIRA)
Felix Neutatz created FLINK-1899: Summary: Table API Bug Key: FLINK-1899 URL: https://issues.apache.org/jira/browse/FLINK-1899 Project: Flink Issue Type: Bug Components: Expression

[jira] [Commented] (FLINK-1899) Table API Bug

2015-04-16 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497972#comment-14497972 ] Timo Walther commented on FLINK-1899: - You need to define a new name for your aggregat

[jira] [Commented] (FLINK-1899) Table API Bug

2015-04-16 Thread Felix Neutatz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497977#comment-14497977 ] Felix Neutatz commented on FLINK-1899: -- Thanks Timo. That worked :) > Table API Bug

[jira] [Resolved] (FLINK-1899) Table API Bug

2015-04-16 Thread Felix Neutatz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Neutatz resolved FLINK-1899. -- Resolution: Fixed > Table API Bug > - > > Key: FLINK-1899 >

[jira] [Created] (FLINK-1900) Table API documentation example does not work

2015-04-16 Thread Timo Walther (JIRA)
Timo Walther created FLINK-1900: --- Summary: Table API documentation example does not work Key: FLINK-1900 URL: https://issues.apache.org/jira/browse/FLINK-1900 Project: Flink Issue Type: Bug

[GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...

2015-04-16 Thread aalexandrov
Github user aalexandrov commented on the pull request: https://github.com/apache/flink/pull/605#issuecomment-93719337 :+1: thanks for the great work! I'll review that (probably over the weekend) and will appreciate if some of the core Flink committers (@sewen, @rmetzger, @fhueske) can

[jira] [Commented] (FLINK-1297) Add support for tracking statistics of intermediate results

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497982#comment-14497982 ] ASF GitHub Bot commented on FLINK-1297: --- Github user aalexandrov commented on the pu

[GitHub] flink pull request: Fix issue where Windows paths were not recogni...

2015-04-16 Thread balidani
Github user balidani commented on the pull request: https://github.com/apache/flink/pull/491#issuecomment-93723421 Hi! This PR was closed, but the commit right after mine removes the part that fixed the windows issue. https://github.com/apache/flink/commit/23fe00629e4b36e

[GitHub] flink pull request: Fix issue where Windows paths were not recogni...

2015-04-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/491#issuecomment-93728544 This issue is discussed in FLINK-1848. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (FLINK-1848) Paths containing a Windows drive letter cannot be used in FileOutputFormats

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498021#comment-14498021 ] ASF GitHub Bot commented on FLINK-1848: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: Fix issue where Windows paths were not recogni...

2015-04-16 Thread balidani
Github user balidani commented on the pull request: https://github.com/apache/flink/pull/491#issuecomment-93728981 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...

2015-04-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/605#issuecomment-93730879 Nice, statistics collection :-) I'll have a look at this PR. It might take a few days as I am traveling. --- If your project is set up for it, you can reply

[jira] [Commented] (FLINK-1297) Add support for tracking statistics of intermediate results

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498034#comment-14498034 ] ASF GitHub Bot commented on FLINK-1297: --- Github user fhueske commented on the pull r

[jira] [Updated] (FLINK-1753) Add more tests for Kafka Connectors

2015-04-16 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-1753: -- Description: The current {{KafkaITCase}} is only doing a single test. We need to refactor that

[GitHub] flink pull request: [FLINK-1891]Add the input storageDirectory emp...

2015-04-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/601#discussion_r28508734 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java --- @@ -64,15 +64,19 @@ * @return the storage directory used by a B

[jira] [Commented] (FLINK-1891) Add isEmpty check when the input dir

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498044#comment-14498044 ] ASF GitHub Bot commented on FLINK-1891: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-1891]Add the input storageDirectory emp...

2015-04-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/601#issuecomment-93734377 Thanks for the PR. Looks good to me, except for a possible minor improvement. --- If your project is set up for it, you can reply to this email and have your reply ap

[jira] [Commented] (FLINK-1891) Add isEmpty check when the input dir

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498045#comment-14498045 ] ASF GitHub Bot commented on FLINK-1891: --- Github user fhueske commented on the pull r

[jira] [Commented] (FLINK-1807) Stochastic gradient descent optimizer for ML library

2015-04-16 Thread Theodore Vasiloudis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498055#comment-14498055 ] Theodore Vasiloudis commented on FLINK-1807: We need to be able to sample from

[jira] [Created] (FLINK-1901) Create sample operator for Dataset

2015-04-16 Thread Theodore Vasiloudis (JIRA)
Theodore Vasiloudis created FLINK-1901: -- Summary: Create sample operator for Dataset Key: FLINK-1901 URL: https://issues.apache.org/jira/browse/FLINK-1901 Project: Flink Issue Type: Impr

[jira] [Closed] (FLINK-1901) Create sample operator for Dataset

2015-04-16 Thread Theodore Vasiloudis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Theodore Vasiloudis closed FLINK-1901. -- Resolution: Fixed > Create sample operator for Dataset > ---

[jira] [Reopened] (FLINK-1901) Create sample operator for Dataset

2015-04-16 Thread Theodore Vasiloudis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Theodore Vasiloudis reopened FLINK-1901: > Create sample operator for Dataset > -- > >

[jira] [Commented] (FLINK-1742) Sample data points for MultipleLinearRegression to support proper SGD

2015-04-16 Thread Theodore Vasiloudis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498115#comment-14498115 ] Theodore Vasiloudis commented on FLINK-1742: The sample operator on Dataset co

[GitHub] flink pull request: Flink Storm compatibility

2015-04-16 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/573#discussion_r28517070 --- Diff: flink-staging/flink-streaming/flink-storm-compatibility/src/main/java/org/apache/flink/stormcompatibility/api/FlinkClient.java --- @@ -0,0 +1,362 @@

[GitHub] flink pull request: [docs] Change doc layout

2015-04-16 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/606 [docs] Change doc layout This is not completely done yet, but should suffice to give a feeling of the new layout. I think this is a good improvement over our current state. - Changed layout (sim

[GitHub] flink pull request: [docs] Change doc layout

2015-04-16 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/606#issuecomment-93763019 :+1: Looks much much better. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: Make PersistentKafkaSource more configurable

2015-04-16 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/607 Make PersistentKafkaSource more configurable The `PersistentKafkaSource` contained some hardcoded configuration values. With this change I'm using more config values from the `ConsumerConfig` Yo

[jira] [Commented] (FLINK-1297) Add support for tracking statistics of intermediate results

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498283#comment-14498283 ] ASF GitHub Bot commented on FLINK-1297: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...

2015-04-16 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/605#discussion_r28528023 --- Diff: flink-core/pom.xml --- @@ -63,6 +63,19 @@ under the License. guava ${guava.version}

[GitHub] flink pull request: [FLINK-1297] Added OperatorStatsAccumulator fo...

2015-04-16 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/605#discussion_r28528360 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/accumulators/OperatorStatsAccumulator.java --- @@ -0,0 +1,98 @@ +/* + * Licensed to th

[jira] [Commented] (FLINK-1297) Add support for tracking statistics of intermediate results

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498302#comment-14498302 ] ASF GitHub Bot commented on FLINK-1297: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request: [scheduling] implement backtracking with inter...

2015-04-16 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/595#issuecomment-93798071 Thanks @mxm, appreciate the additional information about the PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [docs] Change doc layout

2015-04-16 Thread ktzoumas
Github user ktzoumas commented on the pull request: https://github.com/apache/flink/pull/606#issuecomment-93837926 This is one of the best project documentations that I have seen. Thanks a lot Ufuk for doing this! I would merge this as is. Few minor thoughts I had when skimmin