Uwe Schindler wrote:
EG I haven't yet tested for JAR drop-in compatibility, eg if in 3.1
we
wanted to swap in more generics, would a 3.0 app be able to drop in
the 3.1 Lucene jar w/o problems?
It should, because in the compiled JVM code, generics do simply not
appear.
A, right. So
I'd also personally like to see 2.9 released sooner rather than later,
maybe earliesh next year?
I don't think we should hold up 2.9 for some of the big items below
(eg Fieldable/AbstractField/Field cleanup), especially if they have
not even been started yet.
One question: I'm assuming after 2.9
A good idea would be to do the transformation to generics like the
following:
- write a patch that replaces all *public* API declarations with generics
(especially Document, Fieldable and so on where a lot of List/Sets occur).
The Lucene code behind these declarations will compile without any prob
[
https://issues.apache.org/jira/browse/LUCENE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656377#action_12656377
]
Michael McCandless commented on LUCENE-1484:
Jason I'm seeing multiple test ca
[
https://issues.apache.org/jira/browse/LUCENE-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656382#action_12656382
]
Shai Erera commented on LUCENE-1482:
Is there anything else I can do in order to help
Two points here:
1. "It should, because in the compiled JVM code, generics do simply
not appear." is not completely true. Types that have their type
parameters lower-bound, erase said parameters to this low bound and
not to Object. Google Guice uses this as a base to trick allowing
runtime generics
Hi Earwin,
> Two points here:
> 1. "It should, because in the compiled JVM code, generics do simply
> not appear." is not completely true. Types that have their type
> parameters lower-bound, erase said parameters to this low bound and
> not to Object. Google Guice uses this as a base to trick all
I like that approach. So we just need a volunteer to do at least step
1, for 3.0, which should be reasonably straightforward.
Another big effort for 3.0 will be fixing all places internal to
Lucene (including contrib, tests) that still use deprecated APIs.
Mike
Uwe Schindler wrote:
A
On Dec 14, 2008, at 6:54 AM, Michael McCandless wrote:
I'd also personally like to see 2.9 released sooner rather than later,
maybe earliesh next year?
I don't think we should hold up 2.9 for some of the big items below
(eg Fieldable/AbstractField/Field cleanup), especially if they have
not ev
>> 2. Generics' utility is not limited to collections, we use it for
>> type-safe index fields storage/querying for example.
>> Define field:
>> FieldInfo EMPLOYER_CATEGORY =
>> field(ENUM(EmployerCategory.class), INDEX);
>> Store it:
>> add(vacancy.getEmployerCategory(), EMPLOYER_CATEGORY);
>> Que
> >> 2. Generics' utility is not limited to collections, we use it for
> >> type-safe index fields storage/querying for example.
> >> Define field:
> >> FieldInfo EMPLOYER_CATEGORY =
> >> field(ENUM(EmployerCategory.class), INDEX);
> >> Store it:
> >> add(vacancy.getEmployerCategory(), EMPLOYER_CAT
[
https://issues.apache.org/jira/browse/LUCENE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-1484:
---
Attachment: LUCENE-1484.patch
OK I've fixed a few issues with the patch. All tests
[
https://issues.apache.org/jira/browse/LUCENE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless reassigned LUCENE-1484:
--
Assignee: Michael McCandless
> Remove SegmentReader.document synchronization
>
Grant Ingersoll wrote:
On Dec 14, 2008, at 6:54 AM, Michael McCandless wrote:
I'd also personally like to see 2.9 released sooner rather than
later,
maybe earliesh next year?
I don't think we should hold up 2.9 for some of the big items below
(eg Fieldable/AbstractField/Field cleanup), es
[
https://issues.apache.org/jira/browse/LUCENE-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656397#action_12656397
]
Michael McCandless commented on LUCENE-1487:
Yonik do you have any suggestions
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656398#action_12656398
]
Mark Miller commented on LUCENE-1483:
-
Fantastic Mike! I've started working through th
On Sun, Dec 14, 2008, Uwe Schindler wrote about "RE: 2.9/3.0 plan & Java 1.5":
> A side note: there are some parts in Lucene's API that are not so good: very
> old constructors of Analyzer use e.g. Hashtable/HashMap/ArrayList/Vector/...
> as parameter etc. For clean code, it should be replaced by M
[
https://issues.apache.org/jira/browse/LUCENE-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656406#action_12656406
]
Yonik Seeley commented on LUCENE-1487:
--
FieldCacheStringFilter?
FieldCacheValueFilter
> > A side note: there are some parts in Lucene's API that are not so good:
> very
> > old constructors of Analyzer use e.g.
> Hashtable/HashMap/ArrayList/Vector/...
> > as parameter etc. For clean code, it should be replaced by Map/Set/List
> > interfaces. But this would not be backwards compati
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656417#action_12656417
]
Mark Miller commented on LUCENE-1483:
-
It seems there are a few hoops to jump through
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656430#action_12656430
]
Mark Miller commented on LUCENE-1483:
-
I was off on the fillFields stuff, I forgot we
> For return parameters, I think you should return the most specific interface
> you can give to the user (without fixing to something you may change in
> future versions). Maybe a user wants to use the return value of getFields()
> as List? If it's only Iterable, he cannot e.g. access the list dir
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656430#action_12656430
]
markrmil...@gmail.com edited comment on LUCENE-1483 at 12/14/08 10:25 AM:
--
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656431#action_12656431
]
Michael McCandless commented on LUCENE-1483:
{quote}
> I've started working t
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656436#action_12656436
]
Uwe Schindler commented on LUCENE-1483:
---
You do not need to map to long, if you woul
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656439#action_12656439
]
Uwe Schindler commented on LUCENE-1483:
---
Sorry that does not work because of compari
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656440#action_12656440
]
Mark Miller commented on LUCENE-1483:
-
bq. How about something like this:
Okay, I act
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656453#action_12656453
]
Mark Miller commented on LUCENE-1483:
-
What do we do about the old SortComparatorSourc
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656454#action_12656454
]
Mark Miller commented on LUCENE-1483:
-
bq. You compare with ords, never with values.
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656454#action_12656454
]
markrmil...@gmail.com edited comment on LUCENE-1483 at 12/14/08 12:56 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656458#action_12656458
]
Michael McCandless commented on LUCENE-1483:
{quote}
> You do not need to map
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656459#action_12656459
]
Michael McCandless commented on LUCENE-1483:
{quote}
> What do we do about the
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656460#action_12656460
]
Michael McCandless commented on LUCENE-1483:
{quote}
> Sorry that does not wor
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656466#action_12656466
]
Mark Miller commented on LUCENE-1483:
-
Does this have to wait for 3 then? How can we b
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656472#action_12656472
]
Michael McCandless commented on LUCENE-1483:
{quote}
> Does this have to wait
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656473#action_12656473
]
Mark Miller commented on LUCENE-1483:
-
But if you are using the old one it wont work w
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656486#action_12656486
]
Michael McCandless commented on LUCENE-1483:
{quote}
> But if you are using th
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656487#action_12656487
]
Yonik Seeley commented on LUCENE-1483:
--
bq. If it's not present, it must fall between
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656488#action_12656488
]
Mark Miller commented on LUCENE-1483:
-
bq. One problem is that putting an ord "inbetwe
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656489#action_12656489
]
Mark Miller commented on LUCENE-1483:
-
> But if you are using the old one it wont work
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656490#action_12656490
]
Michael McCandless commented on LUCENE-1483:
{quote}
> Not rare right? Let say
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656507#action_12656507
]
Michael McCandless commented on LUCENE-1483:
{quote}
> At that point, one star
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656508#action_12656508
]
Mark Miller commented on LUCENE-1483:
-
bq. Or, better, we could add a "subord" to brea
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656508#action_12656508
]
markrmil...@gmail.com edited comment on LUCENE-1483 at 12/14/08 3:43 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656508#action_12656508
]
markrmil...@gmail.com edited comment on LUCENE-1483 at 12/14/08 4:20 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656512#action_12656512
]
Mark Miller commented on LUCENE-1483:
-
Quick question: what should I use for the value
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller updated LUCENE-1483:
Attachment: LUCENE-1483.patch
Here you go. I'm sorry I've made everything so messy :) I'll clean l
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656519#action_12656519
]
Mark Miller commented on LUCENE-1483:
-
One small error:
+public int sortType() {
[
https://issues.apache.org/jira/browse/LUCENE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656539#action_12656539
]
Jason Rutherglen commented on LUCENE-1484:
--
It's in the ant script? I'll do this
49 matches
Mail list logo
