[PR] MINOR: Clean up TestUtils.scala [kafka]

2024-04-25 Thread via GitHub
m1a2st opened a new pull request, #15808: URL: https://github.com/apache/kafka/pull/15808 Because TestUtils.scala has some unused method, and some methods only use in one class, so I delete unused methods and move methods to individual class which only one class used -- This is an automa

[PR] MINOR: Various cleanups in generator [kafka]

2024-04-25 Thread via GitHub
mimaison opened a new pull request, #15807: URL: https://github.com/apache/kafka/pull/15807 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

[PR] MINOR: Various cleanups in metadata [kafka]

2024-04-25 Thread via GitHub
mimaison opened a new pull request, #15806: URL: https://github.com/apache/kafka/pull/15806 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-04-25 Thread via GitHub
kirktrue commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1579760563 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1338,7 +1339,14 @@ private CompletableFuture enqueueConsumerRe

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-04-25 Thread via GitHub
kirktrue commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1579756071 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -144,6 +166,12 @@ void runOnce() { .map(Optiona

Re: [PR] KAFKA-16557: Fix toString of OffsetFetchRequestState [kafka]

2024-04-25 Thread via GitHub
kirktrue commented on PR #15750: URL: https://github.com/apache/kafka/pull/15750#issuecomment-2077634416 Thanks for the work on this @phooq! > I plan to, on top the current changes I have, rename the `toStringBase` method as `getDetails` Renaming `toStringBase()` to `getDetails

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-04-25 Thread via GitHub
kirktrue commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1579735209 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1270,6 +1230,20 @@ private void close(Duration timeout, boolean s

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-04-25 Thread via GitHub
kirktrue commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1579733831 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -769,7 +730,8 @@ public void commitAsync(OffsetCommitCallback callb

Re: [PR] KAFKA-16555: Consumer's RequestState has incorrect logic to determine if inflight [kafka]

2024-04-25 Thread via GitHub
kirktrue commented on code in PR #15723: URL: https://github.com/apache/kafka/pull/15723#discussion_r1579725251 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -98,12 +93,11 @@ public boolean canSendRequest(final long currentTimeMs)

Re: [PR] KAFKA-16565: IncrementalAssignmentConsumerEventHandler throws error when attempting to remove a partition that isn't assigned [kafka]

2024-04-25 Thread via GitHub
kirktrue commented on code in PR #15737: URL: https://github.com/apache/kafka/pull/15737#discussion_r1579722758 ## tests/kafkatest/services/verifiable_consumer.py: ## @@ -140,22 +150,31 @@ class IncrementalAssignmentConsumerEventHandler(ConsumerEventHandler): def __init__(

Re: [PR] KAFKA-16557: Fix toString of OffsetFetchRequestState [kafka]

2024-04-25 Thread via GitHub
phooq commented on PR #15750: URL: https://github.com/apache/kafka/pull/15750#issuecomment-2077592945 Thanks so @lianetm ! Hey @kirktrue , I plan to, on top the current changes I have, rename the `toStringBase` method as `getDetails` for `RequestState`, does this look okay to you? T

Re: [PR] MINOR: refine DeleteOffsetsConsumerGroupCommandIntegrationTest#produceRecord [kafka]

2024-04-25 Thread via GitHub
chia7712 commented on code in PR #15802: URL: https://github.com/apache/kafka/pull/15802#discussion_r1579708062 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java: ## @@ -169,20 +201,22 @@ private static ConsumerGro

[jira] [Created] (KAFKA-16622) Mirromaker2 first Checkpoint not emitted until consumer group fully catches up once

2024-04-25 Thread Edoardo Comar (Jira)
Edoardo Comar created KAFKA-16622: - Summary: Mirromaker2 first Checkpoint not emitted until consumer group fully catches up once Key: KAFKA-16622 URL: https://issues.apache.org/jira/browse/KAFKA-16622

Re: [PR] MINOR: refine DeleteOffsetsConsumerGroupCommandIntegrationTest#produceRecord [kafka]

2024-04-25 Thread via GitHub
chia7712 commented on code in PR #15802: URL: https://github.com/apache/kafka/pull/15802#discussion_r1579702459 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java: ## @@ -91,65 +91,97 @@ public void testDeleteOffset

[PR] MINOR: Various cleanups in raft [kafka]

2024-04-25 Thread via GitHub
mimaison opened a new pull request, #15805: URL: https://github.com/apache/kafka/pull/15805 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

Re: [PR] MINOR: Remove unused parameters in KafkaConfig [kafka]

2024-04-25 Thread via GitHub
OmniaGM commented on PR #15788: URL: https://github.com/apache/kafka/pull/15788#issuecomment-2077482581 Just rebase to fix the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] MINOR: Remove unused parameters in KafkaConfig [kafka]

2024-04-25 Thread via GitHub
johnnychhsu commented on PR #15788: URL: https://github.com/apache/kafka/pull/15788#issuecomment-2077461634 > @johnnychhsu Instead of removing them, could you make `MetadataLogConfig` use those help methods? > The reason these aren't used is because `MetadataLogConfig` signature uses `Ab

[jira] [Resolved] (KAFKA-16568) Add JMH Benchmarks for assignor performance testing

2024-04-25 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-16568. - Fix Version/s: 3.8.0 Resolution: Fixed > Add JMH Benchmarks for assignor performance test

Re: [PR] KAFKA-16568: JMH Benchmarks for Server Side Rebalances [kafka]

2024-04-25 Thread via GitHub
dajac merged PR #15717: URL: https://github.com/apache/kafka/pull/15717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Various cleanups in core [kafka]

2024-04-25 Thread via GitHub
mimaison merged PR #15786: URL: https://github.com/apache/kafka/pull/15786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Various cleanups in core [kafka]

2024-04-25 Thread via GitHub
mimaison commented on PR #15786: URL: https://github.com/apache/kafka/pull/15786#issuecomment-2077391342 Quite a few failures in the last CI run but it seems to be flaky tests as none of the failures happened on all platforms. Merging to trunk -- This is an automated message from the Apac

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-25 Thread via GitHub
lianetm commented on PR #15698: URL: https://github.com/apache/kafka/pull/15698#issuecomment-2077313831 Thanks for the helpful comments @cadonna , all addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-25 Thread via GitHub
lianetm commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1579555839 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -469,19 +469,33 @@ public void resetTimer() { this

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-25 Thread via GitHub
lianetm commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1579555219 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -164,6 +165,23 @@ public void testHeartbeatOnStartup() {

Re: [PR] MINOR: skip 'zinc' phase from gradle dependency-check plugin [kafka]

2024-04-25 Thread via GitHub
jlprat merged PR #15054: URL: https://github.com/apache/kafka/pull/15054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] MINOR: skip 'zinc' phase from gradle dependency-check plugin [kafka]

2024-04-25 Thread via GitHub
raboof commented on PR #15054: URL: https://github.com/apache/kafka/pull/15054#issuecomment-2077285239 > please ask a committer for review Perhaps @jlprat? :innocent: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-9800: Exponential backoff for Kafka clients - KIP-580 [kafka]

2024-04-25 Thread via GitHub
AndrewJSchofield commented on code in PR #14111: URL: https://github.com/apache/kafka/pull/14111#discussion_r1579542525 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java: ## @@ -384,6 +389,32 @@ int attempts() { return attempts.get(

[jira] [Updated] (KAFKA-16621) Alter MirrorSourceConnector offsets dont work

2024-04-25 Thread yuzhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzhou updated KAFKA-16621: --- Description: In connect-offsets topic: the offsets wrote by connector, key is  `\{"cluster":"A","partition"

[jira] [Updated] (KAFKA-16621) Alter MirrorSourceConnector offsets dont work

2024-04-25 Thread yuzhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzhou updated KAFKA-16621: --- Description: In connect-offsets topic: the offsets wrote by connector, key is  `\{"cluster":"A","partition"

[jira] [Updated] (KAFKA-16621) Alter MirrorSourceConnector offsets dont work

2024-04-25 Thread yuzhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzhou updated KAFKA-16621: --- Description: In connect-offsets topic: the offsets wrote by connector, key is  `\{"cluster":"A","partition"

[jira] [Updated] (KAFKA-16621) Alter MirrorSourceConnector offsets dont work

2024-04-25 Thread yuzhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzhou updated KAFKA-16621: --- Description: In connect-offsets topic: the offsets wrote by connector, key is  `\{"cluster":"A","partition"

[jira] [Updated] (KAFKA-16621) Alter MirrorSourceConnector offsets dont work

2024-04-25 Thread yuzhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzhou updated KAFKA-16621: --- Description: In connect-offsets topic: the offsets wrote by connector, key is  `\{"cluster":"A","partition"

[jira] [Updated] (KAFKA-16621) Alter MirrorSourceConnector offsets dont work

2024-04-25 Thread yuzhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzhou updated KAFKA-16621: --- Description: In connect-offsets topic: the offsets wrote by connector, key is  `\{"cluster":"A","partition"

[jira] [Updated] (KAFKA-16621) Alter MirrorSourceConnector offsets dont work

2024-04-25 Thread yuzhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzhou updated KAFKA-16621: --- Description: In connect-offsets topic: the offsets wrote by connector, key is  `\{"cluster":"A","partition"

[jira] [Updated] (KAFKA-16621) Alter MirrorSourceConnector offsets dont work

2024-04-25 Thread yuzhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzhou updated KAFKA-16621: --- Description: In connect-offsets topic: the offsets wrote by connector, key is  `\{"cluster":"A","partition"

[jira] [Updated] (KAFKA-16621) Alter MirrorSourceConnector offsets dont work

2024-04-25 Thread yuzhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzhou updated KAFKA-16621: --- Description: In connect-offsets topic: the offsets wrote by connector, key is  `\{"cluster":"A","partition"

[jira] [Updated] (KAFKA-16621) Alter MirrorSourceConnector offsets dont work

2024-04-25 Thread yuzhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzhou updated KAFKA-16621: --- Description: In connect-offsets topic: the offsets wrote by connector, key is  `\{"cluster":"A","partition"

[jira] [Updated] (KAFKA-16621) Alter MirrorSourceConnector offsets dont work

2024-04-25 Thread yuzhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzhou updated KAFKA-16621: --- Description: In connect-offsets topic: the offsets wrote by connector, key is  `\{"cluster":"A","partition"

[jira] [Updated] (KAFKA-16621) Alter MirrorSourceConnector offsets dont work

2024-04-25 Thread yuzhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzhou updated KAFKA-16621: --- Description: In connect-offsets topic: the offsets wrote by connector, key is  `\{"cluster":"A","partition"

[jira] [Updated] (KAFKA-16621) Alter MirrorSourceConnector offsets dont work

2024-04-25 Thread yuzhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzhou updated KAFKA-16621: --- Description: In connect-offsets topic: the offsets wrote by connector, key is  `\{"cluster":"A","partition"

[jira] [Updated] (KAFKA-16621) Alter MirrorSourceConnector offsets dont work

2024-04-25 Thread yuzhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzhou updated KAFKA-16621: --- Description: In connect-offsets topic: the offsets wrote by connector, key is  `\{"cluster":"A","partition"

[jira] [Updated] (KAFKA-16621) Alter MirrorSourceConnector offsets dont work

2024-04-25 Thread yuzhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzhou updated KAFKA-16621: --- Description: In connect-offsets topic: the offsets wrote by connector, key is  `\{"cluster":"A","partition"

[jira] [Updated] (KAFKA-16621) Alter MirrorSourceConnector offsets dont work

2024-04-25 Thread yuzhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzhou updated KAFKA-16621: --- Description: In connect-offsets topic: the offsets wrote by connector, key is  `\{"cluster":"A","partition"

[jira] [Created] (KAFKA-16621) Alter MirrorSourceConnector offsets dont work

2024-04-25 Thread yuzhou (Jira)
yuzhou created KAFKA-16621: -- Summary: Alter MirrorSourceConnector offsets dont work Key: KAFKA-16621 URL: https://issues.apache.org/jira/browse/KAFKA-16621 Project: Kafka Issue Type: Bug C

Re: [PR] KAFKA-16573: Specify node and store where serdes are needed [kafka]

2024-04-25 Thread via GitHub
AyoubOm commented on PR #15790: URL: https://github.com/apache/kafka/pull/15790#issuecomment-2077173169 ping @mjsax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] KAFKA-16557: Fix toString of OffsetFetchRequestState [kafka]

2024-04-25 Thread via GitHub
lianetm commented on PR #15750: URL: https://github.com/apache/kafka/pull/15750#issuecomment-2077166262 Hey @phooq, having a `getDetails` that the inheritors override does achieve the clarity I was looking for, sounds good. -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (KAFKA-16620) KRaft quorum cannot be formed if all controllers are restarted at the same time

2024-04-25 Thread Gantigmaa Selenge (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge updated KAFKA-16620: -- Summary: KRaft quorum cannot be formed if all controllers are restarted at the same ti

[jira] [Updated] (KAFKA-16620) Kraft quorum cannot be formed if all controllers are restarted at the same time

2024-04-25 Thread Gantigmaa Selenge (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge updated KAFKA-16620: -- Description: Controller quorum cannot seem to form at all after accidentally restartin

[jira] [Assigned] (KAFKA-16620) Kraft quorum cannot be formed if all controllers are restarted at the same time

2024-04-25 Thread Gantigmaa Selenge (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge reassigned KAFKA-16620: - Assignee: Luke Chen (was: Gantigmaa Selenge) > Kraft quorum cannot be formed i

[jira] [Assigned] (KAFKA-16620) Kraft quorum cannot be formed if all controllers are restarted at the same time

2024-04-25 Thread Gantigmaa Selenge (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge reassigned KAFKA-16620: - Assignee: Gantigmaa Selenge > Kraft quorum cannot be formed if all controllers

[jira] [Updated] (KAFKA-16620) Kraft quorum cannot be formed if all controllers are restarted at the same time

2024-04-25 Thread Gantigmaa Selenge (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge updated KAFKA-16620: -- Description: Controller quorum cannot seem to form at all after accidentally restartin

[jira] [Created] (KAFKA-16620) Kraft quorum cannot be formed if all controllers are restarted at the same time

2024-04-25 Thread Gantigmaa Selenge (Jira)
Gantigmaa Selenge created KAFKA-16620: - Summary: Kraft quorum cannot be formed if all controllers are restarted at the same time Key: KAFKA-16620 URL: https://issues.apache.org/jira/browse/KAFKA-16620

[jira] [Created] (KAFKA-16619) Unnecessary warning : "Loaded ZK migration state of NONE"

2024-04-25 Thread Jira
F Méthot created KAFKA-16619: Summary: Unnecessary warning : "Loaded ZK migration state of NONE" Key: KAFKA-16619 URL: https://issues.apache.org/jira/browse/KAFKA-16619 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-16619) Unnecessary controller warning : "Loaded ZK migration state of NONE"

2024-04-25 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] F Méthot updated KAFKA-16619: - Summary: Unnecessary controller warning : "Loaded ZK migration state of NONE" (was: Unnecessary warning

[jira] [Updated] (KAFKA-16619) Unnecessary controller warning : "Loaded ZK migration state of NONE"

2024-04-25 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] F Méthot updated KAFKA-16619: - Description: When we launch a fresh cluster of Kafka and Kraft Controller, no zookeeper involved. We g

[PR] MINOR: Remove unnecessary version from excluded dependencies of clients [kafka]

2024-04-25 Thread via GitHub
tinaselenge opened a new pull request, #15804: URL: https://github.com/apache/kafka/pull/15804 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of tes

Re: [PR] KAFKA-16615: JoinGroup API for upgrading ConsumerGroup [kafka]

2024-04-25 Thread via GitHub
dajac commented on code in PR #15798: URL: https://github.com/apache/kafka/pull/15798#discussion_r1579345622 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1336,6 +1422,233 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-7632: Support Compression Levels (KIP-390) [kafka]

2024-04-25 Thread via GitHub
showuon commented on code in PR #15516: URL: https://github.com/apache/kafka/pull/15516#discussion_r1579334152 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -189,7 +189,7 @@ public RecordAccumulator(LogContext logContext,

[PR] KAFKA-16608: Honour interrupted thread state on KafkaConsumer.poll [kafka]

2024-04-25 Thread via GitHub
AndrewJSchofield opened a new pull request, #15803: URL: https://github.com/apache/kafka/pull/15803 The contract of KafkaConsumer.poll(Duration) says that it throws InterruptException "if the calling thread is interrupted before or while this function is called". The new KafkaConsumer imple

Re: [PR] KAFKA-16565: IncrementalAssignmentConsumerEventHandler throws error when attempting to remove a partition that isn't assigned [kafka]

2024-04-25 Thread via GitHub
lucasbru commented on PR #15737: URL: https://github.com/apache/kafka/pull/15737#issuecomment-2077011152 Do I understand it correctly that there is no functional change here, just logging? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] KAFKA-16465: Fix consumer sys test revocation validation [kafka]

2024-04-25 Thread via GitHub
lucasbru commented on code in PR #15778: URL: https://github.com/apache/kafka/pull/15778#discussion_r1579343899 ## tests/kafkatest/tests/client/consumer_test.py: ## @@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown, static_membership, bounce_

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-04-25 Thread via GitHub
cadonna commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1579221285 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -769,7 +730,8 @@ public void commitAsync(OffsetCommitCallback callba

Re: [PR] KAFKA-10733: Clean up producer exceptions [kafka]

2024-04-25 Thread via GitHub
lucasbru closed pull request #13876: KAFKA-10733: Clean up producer exceptions URL: https://github.com/apache/kafka/pull/13876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] KAFKA:-16399: Add JBOD support in tiered storage [kafka]

2024-04-25 Thread via GitHub
showuon commented on PR #15690: URL: https://github.com/apache/kafka/pull/15690#issuecomment-2076987711 @mimaison @soarez , PR updated. Please take a look when available. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA:-16399: Add JBOD support in tiered storage [kafka]

2024-04-25 Thread via GitHub
showuon commented on code in PR #15690: URL: https://github.com/apache/kafka/pull/15690#discussion_r1579328510 ## storage/src/test/java/org/apache/kafka/tiered/storage/actions/AlterLogDirAction.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] KAFKA:-16399: Add JBOD support in tiered storage [kafka]

2024-04-25 Thread via GitHub
showuon commented on code in PR #15690: URL: https://github.com/apache/kafka/pull/15690#discussion_r1579328199 ## core/src/main/java/kafka/server/TierStateMachine.java: ## @@ -40,7 +92,72 @@ public interface TierStateMachine { */ PartitionFetchState start(TopicPartiti

Re: [PR] KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records [kafka]

2024-04-25 Thread via GitHub
vamossagar12 commented on PR #13801: URL: https://github.com/apache/kafka/pull/13801#issuecomment-2076983151 Thanks Chris! I ran through the scenarios in the test and I can see that it handles the cases correctly. Regarding, `cancel` I don't see the future returned from `set` being cancelle

Re: [PR] KAFKA:-16399: Add JBOD support in tiered storage [kafka]

2024-04-25 Thread via GitHub
showuon commented on code in PR #15690: URL: https://github.com/apache/kafka/pull/15690#discussion_r1579325677 ## core/src/test/scala/unit/kafka/server/TierStateMachineTest.scala: ## @@ -153,12 +157,13 @@ class ReplicaFetcherTierStateMachineTest { assertEquals(11L, replicaS

Re: [PR] enable test, check if continues failing in CI [kafka]

2024-04-25 Thread via GitHub
TaiJuWu commented on PR #13953: URL: https://github.com/apache/kafka/pull/13953#issuecomment-2076900770 Hello @Kiriakos1998 , Do you still work on it? If not, I want to take it over. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] MINOR: Modified System.getProperty("line.separator") to java.lang.System.lineSeparator() [kafka]

2024-04-25 Thread via GitHub
TaiJuWu commented on PR #15782: URL: https://github.com/apache/kafka/pull/15782#issuecomment-2076894379 > @TaiJuWu could you please rebase code to include #15801 Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-25 Thread via GitHub
chia7712 commented on code in PR #15645: URL: https://github.com/apache/kafka/pull/15645#discussion_r1579206989 ## core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java: ## @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA:-16399: Add JBOD support in tiered storage [kafka]

2024-04-25 Thread via GitHub
showuon commented on code in PR #15690: URL: https://github.com/apache/kafka/pull/15690#discussion_r1579212500 ## storage/src/test/java/org/apache/kafka/tiered/storage/actions/AlterLogDirAction.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-25 Thread via GitHub
cadonna commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1579191646 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -164,6 +165,23 @@ public void testHeartbeatOnStartup() {

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-25 Thread via GitHub
cadonna commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1579191646 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -164,6 +165,23 @@ public void testHeartbeatOnStartup() {

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-25 Thread via GitHub
cadonna commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1579191646 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -164,6 +165,23 @@ public void testHeartbeatOnStartup() {

Re: [PR] KAFKA-16528: Client HB timing fix [kafka]

2024-04-25 Thread via GitHub
cadonna commented on code in PR #15698: URL: https://github.com/apache/kafka/pull/15698#discussion_r1579187392 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -164,6 +165,23 @@ public void testHeartbeatOnStartup() {

Re: [PR] MINOR: Modified System.getProperty("line.separator") to java.lang.System.lineSeparator() [kafka]

2024-04-25 Thread via GitHub
chia7712 commented on PR #15782: URL: https://github.com/apache/kafka/pull/15782#issuecomment-2076761562 @TaiJuWu could you please rebase code to include https://github.com/apache/kafka/pull/15801 -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] MINOR: refine DeleteOffsetsConsumerGroupCommandIntegrationTest#produceRecord [kafka]

2024-04-25 Thread via GitHub
chia7712 commented on PR #15802: URL: https://github.com/apache/kafka/pull/15802#issuecomment-2076758475 @FrankYang0529 We reuse the TOPIC and GROUP in the for-loop, and that could be a issue if the cleanup of topic/group is not finished before running next loop. Could you please use differ

[jira] [Commented] (KAFKA-16563) migration to KRaft hanging after MigrationClientException

2024-04-25 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840723#comment-17840723 ] Luke Chen commented on KAFKA-16563: --- [~davidarthur] [~akhileshchg] , could you take a

Re: [PR] KAFKA-16563: retry pollEvent in KRaftMigrationDriver for retriable errors [kafka]

2024-04-25 Thread via GitHub
showuon commented on PR #15732: URL: https://github.com/apache/kafka/pull/15732#issuecomment-2076748016 @akhileshchg @mumrah @cmccabe , we need your comment on this. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] MINOR: Rename RaftConfig to QuorumConfigs [kafka]

2024-04-25 Thread via GitHub
OmniaGM commented on PR #15797: URL: https://github.com/apache/kafka/pull/15797#issuecomment-2076745737 > @OmniaGM Could you please rebase code to include fix (#15801)? done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-25 Thread via GitHub
chia7712 commented on PR #15645: URL: https://github.com/apache/kafka/pull/15645#issuecomment-2076742667 > Can you, please, take a look? sure! will take a look later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] MINOR: Rename RaftConfig to QuorumConfigs [kafka]

2024-04-25 Thread via GitHub
chia7712 commented on PR #15797: URL: https://github.com/apache/kafka/pull/15797#issuecomment-2076741501 @OmniaGM Could you please rebase code to include fix (https://github.com/apache/kafka/pull/15801)? -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-25 Thread via GitHub
nizhikov commented on PR #15645: URL: https://github.com/apache/kafka/pull/15645#issuecomment-2076735612 Hello @chia7712 1. Reworked test to use ClusterTestExtensions 2. Extend `testExitWithNonZeroStatusOnUpdatingUnallowedConfig` to check in kraft mode. 3. Other two test zk spe

Re: [PR] KAFKA-16555: Consumer's RequestState has incorrect logic to determine if inflight [kafka]

2024-04-25 Thread via GitHub
lucasbru commented on PR #15723: URL: https://github.com/apache/kafka/pull/15723#issuecomment-2076731964 Still looking good to me. I was waiting for the comments from philipp to be commented on / addressed. Do you want to skip ahead an merge? -- This is an automated message from the Apach

Re: [PR] KAFKA-16609: Update parse_describe_topic to support new topic describe output [kafka]

2024-04-25 Thread via GitHub
lucasbru merged PR #15799: URL: https://github.com/apache/kafka/pull/15799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-16212) Cache partitions by TopicIdPartition instead of TopicPartition

2024-04-25 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840715#comment-17840715 ] Omnia Ibrahim commented on KAFKA-16212: --- I believe that https://issues.apache.org/

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

2024-04-25 Thread via GitHub
dajac commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1579102085 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ConsumerGroupSubscriptionModel.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Sof

Re: [PR] MINOR: Various cleanups in core [kafka]

2024-04-25 Thread via GitHub
mimaison commented on PR #15786: URL: https://github.com/apache/kafka/pull/15786#issuecomment-2076660780 Just rebased, let's run another build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

2024-04-25 Thread via GitHub
vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1579057875 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +536,57 @@ public void testSkippingAssignmen

[jira] [Assigned] (KAFKA-16584) Make log processing summary configurable or debug

2024-04-25 Thread dujian (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dujian reassigned KAFKA-16584: -- Assignee: dujian > Make log processing summary configurable or debug > --

[jira] [Commented] (KAFKA-16582) Feature Request: Introduce max.record.size Configuration Parameter for Producers

2024-04-25 Thread dujian (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840684#comment-17840684 ] dujian commented on KAFKA-16582: hello [~ramiz.mehran]  I have reproduced this problem

[jira] [Created] (KAFKA-16618) Update the RPC for ConsumerGroupHeartbeatRequest and ConsumerGroupHeartbeatResponse

2024-04-25 Thread Phuc Hong Tran (Jira)
Phuc Hong Tran created KAFKA-16618: -- Summary: Update the RPC for ConsumerGroupHeartbeatRequest and ConsumerGroupHeartbeatResponse Key: KAFKA-16618 URL: https://issues.apache.org/jira/browse/KAFKA-16618

[PR] MINOR: refine DeleteOffsetsConsumerGroupCommandIntegrationTest#produceRecord [kafka]

2024-04-25 Thread via GitHub
FrankYang0529 opened a new pull request, #15802: URL: https://github.com/apache/kafka/pull/15802 Use try-with-resource to create producer and make sure the producer send record without error. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementat

<    1   2