[jira] [Updated] (KAFKA-10199) Separate state restoration into separate threads

2024-03-11 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10199: -- Fix Version/s: 3.8.0 (was: 3.7.0) > Separate state restoration into sep

[jira] [Reopened] (KAFKA-10199) Separate state restoration into separate threads

2024-03-11 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reopened KAFKA-10199: --- > Separate state restoration into separate threads > ---

[jira] [Closed] (KAFKA-16285) Make group metadata available when a new assignment is set in async Kafka consumer

2024-03-11 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna closed KAFKA-16285. - > Make group metadata available when a new assignment is set in async Kafka > consumer > --

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-11 Thread via GitHub
sjhajharia commented on code in PR #15486: URL: https://github.com/apache/kafka/pull/15486#discussion_r1519322254 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -3151,6 +3152,45 @@ public void testInvalidTxnStateIsAnAbortableError()

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-11 Thread via GitHub
sjhajharia commented on code in PR #15486: URL: https://github.com/apache/kafka/pull/15486#discussion_r1519327877 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -228,11 +232,17 @@ class AddPartitionsToTxnManager( val tp = new TopicPar

Re: [PR] KAFKA-10892: Shared Readonly State Stores ( revisited ) [kafka]

2024-03-11 Thread via GitHub
calmera commented on PR #12742: URL: https://github.com/apache/kafka/pull/12742#issuecomment-1987893614 Nice job @mjsax @wcarlson5! Sorry I couldn't spend more time on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-11 Thread via GitHub
sjhajharia commented on code in PR #15486: URL: https://github.com/apache/kafka/pull/15486#discussion_r1519333893 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1007,7 +1010,8 @@ class ReplicaManager(val config: KafkaConfig, transactionalId, produ

[jira] [Assigned] (KAFKA-15649) Handle directory failure timeout

2024-03-11 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass reassigned KAFKA-15649: --- Assignee: Viktor Somogyi-Vass > Handle directory failure timeout > ---

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-11 Thread via GitHub
sjhajharia commented on PR #15486: URL: https://github.com/apache/kafka/pull/15486#issuecomment-1987900169 > I took a quick skim of the tests -- just wanted to confirm we have a test for the old produce request + invalid txn state returned? @jolshan , if you have a look at `core/src/

Re: [PR] KAFKA-16146: Checkpoint log-start-offset for remote log enabled topics [kafka]

2024-03-11 Thread via GitHub
satishd commented on code in PR #15201: URL: https://github.com/apache/kafka/pull/15201#discussion_r1519366268 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -865,7 +865,8 @@ class LogManager(logDirs: Seq[File], try { logStartOffsetCheckpoints.get(logDir).f

Re: [PR] KAFKA-16146: Checkpoint log-start-offset for remote log enabled topics [kafka]

2024-03-11 Thread via GitHub
satishd commented on PR #15201: URL: https://github.com/apache/kafka/pull/15201#issuecomment-1987943134 Merging the changes as the test failures are unrelated to this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-16146: Checkpoint log-start-offset for remote log enabled topics [kafka]

2024-03-11 Thread via GitHub
satishd merged PR #15201: URL: https://github.com/apache/kafka/pull/15201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[PR] KAFKA-15417 Sloppy bug: moved the outerJounBreak-flags out of the loop [kafka]

2024-03-11 Thread via GitHub
VictorvandenHoven opened a new pull request, #15510: URL: https://github.com/apache/kafka/pull/15510 Sloppy bug: moved the outerJounBreak-flags out of the loop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] MINOR: Remove deprecation and exception throw in ProcessorRecordContext#hashcode [kafka]

2024-03-11 Thread via GitHub
cadonna commented on PR #15508: URL: https://github.com/apache/kafka/pull/15508#issuecomment-1988235647 @ableegoldman I had a quick look at the code and theoretically `ProcessorRecordContext` is mutable because `headers()` returns a reference to the object of `Headers` stored internally. Wi

Re: [PR] KAFKA-14133: Move consumer mock in TaskManagerTest to Mockito - part 3 [kafka]

2024-03-11 Thread via GitHub
cadonna commented on PR #15497: URL: https://github.com/apache/kafka/pull/15497#issuecomment-1988260873 Test failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] KAFKA-14133: Move consumer mock in TaskManagerTest to Mockito - part 3 [kafka]

2024-03-11 Thread via GitHub
cadonna merged PR #15497: URL: https://github.com/apache/kafka/pull/15497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Commented] (KAFKA-16350) StateUpdater does not init transaction after canceling task close action

2024-03-11 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825278#comment-17825278 ] Bruno Cadonna commented on KAFKA-16350: --- Thanks for the report [~mjsax]! I think

[jira] [Assigned] (KAFKA-16350) StateUpdater does not init transaction after canceling task close action

2024-03-11 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reassigned KAFKA-16350: - Assignee: Bruno Cadonna > StateUpdater does not init transaction after canceling task c

[jira] [Created] (KAFKA-16359) kafka-clients-3.7.0.jar published to Maven Central is defective

2024-03-11 Thread Jeremy Norris (Jira)
Jeremy Norris created KAFKA-16359: - Summary: kafka-clients-3.7.0.jar published to Maven Central is defective Key: KAFKA-16359 URL: https://issues.apache.org/jira/browse/KAFKA-16359 Project: Kafka

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-11 Thread via GitHub
showuon commented on code in PR #15474: URL: https://github.com/apache/kafka/pull/15474#discussion_r1519662867 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java: ## @@ -417,8 +422,14 @@ public ValidationResult validateMessagesAndAssignOffsetsComp

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-11 Thread via GitHub
showuon commented on PR #15474: URL: https://github.com/apache/kafka/pull/15474#issuecomment-1988370290 > Also, [#15476 (comment)](https://github.com/apache/kafka/pull/15476#discussion_r1518413083) applies here too. We just need to fix it in one of the PRs. Let's fix it in #15476. Th

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-11 Thread via GitHub
showuon commented on code in PR #15474: URL: https://github.com/apache/kafka/pull/15474#discussion_r1519665612 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -52,20 +55,30 @@ public class GetOffsetShellTest { private final int topicCount = 4;

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-11 Thread via GitHub
showuon commented on code in PR #15474: URL: https://github.com/apache/kafka/pull/15474#discussion_r1519669214 ## core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala: ## @@ -36,65 +37,149 @@ class ListOffsetsIntegrationTest extends KafkaServerTestHarnes

Re: [PR] KAFKA-15561: Client support for new SubscriptionPattern based subscription [kafka]

2024-03-11 Thread via GitHub
Phuc-Hong-Tran commented on code in PR #15188: URL: https://github.com/apache/kafka/pull/15188#discussion_r1519707860 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1730,6 +1744,21 @@ private void subscribeInternal(Pattern pa

[jira] [Commented] (KAFKA-16359) kafka-clients-3.7.0.jar published to Maven Central is defective

2024-03-11 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825313#comment-17825313 ] Gaurav Narula commented on KAFKA-16359: --- This is likely because of the shadow jar

[jira] [Commented] (KAFKA-16359) kafka-clients-3.7.0.jar published to Maven Central is defective

2024-03-11 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825333#comment-17825333 ] Apoorv Mittal commented on KAFKA-16359: --- Hi [~norrisjeremy] , thanks for reporting

[jira] [Assigned] (KAFKA-16359) kafka-clients-3.7.0.jar published to Maven Central is defective

2024-03-11 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal reassigned KAFKA-16359: - Assignee: Apoorv Mittal > kafka-clients-3.7.0.jar published to Maven Central is defecti

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

2024-03-11 Thread via GitHub
mumrah commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1519830343 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -2240,6 +2283,25 @@ private void updatePartitionDirectories( }

Re: [PR] KAFKA-16227: Avoid IllegalStateException during fetch initialization [kafka]

2024-03-11 Thread via GitHub
lucasbru commented on code in PR #15491: URL: https://github.com/apache/kafka/pull/15491#discussion_r1519911603 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java: ## @@ -278,32 +278,48 @@ private CompletedFetch handleInitializeSuccess(final

[PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-11 Thread via GitHub
lucasbru opened a new pull request, #15511: URL: https://github.com/apache/kafka/pull/15511 The goal of this PR is to change the following internals of the reconciliation: - Introduce a "local epoch" to the local target assignment. When a new target is received by the server, we com

[jira] [Commented] (KAFKA-16114) Fix partiton not retention after cancel alter intra broker log dir task

2024-03-11 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825363#comment-17825363 ] Divij Vaidya commented on KAFKA-16114: -- Sorry [~albedooo] , I won't have bandwi

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-11 Thread via GitHub
lucasbru commented on PR #15511: URL: https://github.com/apache/kafka/pull/15511#issuecomment-1988762078 @lianetm @dajac Could you please have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] KAFKA-12187: replace assertTrue(obj instanceof X) with assertInstanceOf [kafka]

2024-03-11 Thread via GitHub
brandboat opened a new pull request, #15512: URL: https://github.com/apache/kafka/pull/15512 as title, replace - `assertTrue(obj instanceof X)` with `assertInstanceOf(X.class, obj)` - `assertTrue(obj instanceof X, errormessge)` with `assertInstanceOf(X.class, obj, errormessage)`

[jira] [Commented] (KAFKA-16354) FinalizedFeatureChangeListenerTest should use mocked latches

2024-03-11 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825365#comment-17825365 ] PoAn Yang commented on KAFKA-16354: --- Hi [~gharris1727], I am interested in this. May I

Re: [PR] KAFKA-16227: Avoid IllegalStateException during fetch initialization [kafka]

2024-03-11 Thread via GitHub
cadonna commented on PR #15491: URL: https://github.com/apache/kafka/pull/15491#issuecomment-1988816400 > LGTM! I think it's a good solution in the current architecture, though arguably a bit smelly. Agree on the arguable smell. The alternative would be to use locks which I disliked

Re: [PR] KAFKA-16227: Avoid IllegalStateException during fetch initialization [kafka]

2024-03-11 Thread via GitHub
cadonna commented on code in PR #15491: URL: https://github.com/apache/kafka/pull/15491#discussion_r1519991935 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java: ## @@ -278,32 +278,48 @@ private CompletedFetch handleInitializeSuccess(final

[jira] [Commented] (KAFKA-16359) kafka-clients-3.7.0.jar published to Maven Central is defective

2024-03-11 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825373#comment-17825373 ] Gaurav Narula commented on KAFKA-16359: --- [~apoorvmittal10] I stumbled upon [https

[jira] [Created] (KAFKA-16360) Release plan of 3.x kafka releases.

2024-03-11 Thread kaushik srinivas (Jira)
kaushik srinivas created KAFKA-16360: Summary: Release plan of 3.x kafka releases. Key: KAFKA-16360 URL: https://issues.apache.org/jira/browse/KAFKA-16360 Project: Kafka Issue Type: Impro

[jira] [Commented] (KAFKA-16360) Release plan of 3.x kafka releases.

2024-03-11 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825385#comment-17825385 ] Greg Harris commented on KAFKA-16360: - Hi [~kaushik srinivas], thanks for your quest

[jira] [Commented] (KAFKA-16360) Release plan of 3.x kafka releases.

2024-03-11 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825386#comment-17825386 ] Justine Olshan commented on KAFKA-16360: Hey there – there was some discussion o

[jira] [Created] (KAFKA-16361) Rack aware sticky assignor minQuota violations

2024-03-11 Thread Luke D (Jira)
Luke D created KAFKA-16361: -- Summary: Rack aware sticky assignor minQuota violations Key: KAFKA-16361 URL: https://issues.apache.org/jira/browse/KAFKA-16361 Project: Kafka Issue Type: Bug

[jira] [Assigned] (KAFKA-16298) Ensure user callbacks exceptions are propagated to the user on consumer poll

2024-03-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16298: - Assignee: Kirk True > Ensure user callbacks exceptions are propagated to the user on consumer p

[jira] [Updated] (KAFKA-16256) Update ConsumerConfig to validate use of group.remote.assignor and partition.assignment.strategy based on group.protocol

2024-03-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16256: -- Priority: Minor (was: Major) > Update ConsumerConfig to validate use of group.remote.assignor and >

[jira] [Updated] (KAFKA-15553) Review consumer positions update

2024-03-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15553: -- Priority: Minor (was: Major) > Review consumer positions update > >

[jira] [Updated] (KAFKA-16255) AsyncKafkaConsumer should not use partition.assignment.strategy

2024-03-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16255: -- Priority: Minor (was: Major) > AsyncKafkaConsumer should not use partition.assignment.strategy >

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

2024-03-11 Thread via GitHub
jolshan commented on PR #15364: URL: https://github.com/apache/kafka/pull/15364#issuecomment-1988980430 > This is a non-backward compatible change. I think that we should do this change to cleanup the record. As KIP-848 is only in early access in 3.7 and that we clearly state that we don't

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

2024-03-11 Thread via GitHub
jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520113443 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

2024-03-11 Thread via GitHub
CalvinConfluent commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1520115750 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -336,10 +350,10 @@ public ControllerResult registerBroker(

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

2024-03-11 Thread via GitHub
CalvinConfluent commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1520115442 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -2240,6 +2283,25 @@ private void updatePartitionDirectories(

Re: [PR] KAFKA-15586: Clean shutdown detection - server side [kafka]

2024-03-11 Thread via GitHub
CalvinConfluent commented on code in PR #14706: URL: https://github.com/apache/kafka/pull/14706#discussion_r1520116151 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1837,8 +1872,13 @@ void generateLeaderAndIsrUpdates(String context,

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

2024-03-11 Thread via GitHub
jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520125834 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1211,13 +1192,99 @@ private CoordinatorResult consumerGr

Re: [PR] MINOR: update kraft_upgrade_test to create a new topic after metadata upgrade [kafka]

2024-03-11 Thread via GitHub
soarez commented on PR #15451: URL: https://github.com/apache/kafka/pull/15451#issuecomment-1989015331 @showuon could you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (KAFKA-16362) Fix type-unsafety in KStreamKStreamJoin caused by isLeftSide

2024-03-11 Thread Greg Harris (Jira)
Greg Harris created KAFKA-16362: --- Summary: Fix type-unsafety in KStreamKStreamJoin caused by isLeftSide Key: KAFKA-16362 URL: https://issues.apache.org/jira/browse/KAFKA-16362 Project: Kafka I

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

2024-03-11 Thread via GitHub
jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520152684 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1400,35 +1440,35 @@ private void cancelConsumerGroupSessionTimeo

Re: [PR] Fix incorrect syntax for config [kafka]

2024-03-11 Thread via GitHub
mjsax commented on PR #15500: URL: https://github.com/apache/kafka/pull/15500#issuecomment-1989056918 Merged to `trunk` and cherry-picked to `3.7` and `3.6` branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

2024-03-11 Thread via GitHub
jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520152684 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1400,35 +1440,35 @@ private void cancelConsumerGroupSessionTimeo

[PR] MINOR: Change KStreamKstreamOuterJoinTest to use distinct left and right types [kafka]

2024-03-11 Thread via GitHub
gharris1727 opened a new pull request, #15513: URL: https://github.com/apache/kafka/pull/15513 This test uses the same value types on the left and right, and so wouldn't be sensitive to a mixup between left and right values. So I changed one of the stream types to `Long`, and updated the as

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

2024-03-11 Thread via GitHub
jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520152684 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1400,35 +1440,35 @@ private void cancelConsumerGroupSessionTimeo

[jira] [Commented] (KAFKA-16362) Fix type-unsafety in KStreamKStreamJoin caused by isLeftSide

2024-03-11 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825397#comment-17825397 ] Greg Harris commented on KAFKA-16362: - cc [~mjsax] [~ableegoldman] I looked through

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

2024-03-11 Thread via GitHub
jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520152684 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1400,35 +1440,35 @@ private void cancelConsumerGroupSessionTimeo

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

2024-03-11 Thread via GitHub
jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520171958 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1796,12 +1834,12 @@ public void onLoaded() {

[jira] [Created] (KAFKA-16363) Storage crashes if dir is unavailable

2024-03-11 Thread Igor Soarez (Jira)
Igor Soarez created KAFKA-16363: --- Summary: Storage crashes if dir is unavailable Key: KAFKA-16363 URL: https://issues.apache.org/jira/browse/KAFKA-16363 Project: Kafka Issue Type: Sub-task

[jira] [Assigned] (KAFKA-16363) Storage crashes if dir is unavailable

2024-03-11 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez reassigned KAFKA-16363: --- Assignee: Igor Soarez > Storage crashes if dir is unavailable > ---

[jira] [Commented] (KAFKA-16363) Storage crashes if dir is unavailable

2024-03-11 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825402#comment-17825402 ] Igor Soarez commented on KAFKA-16363: - cc [~pprovenzano]  > Storage crashes if dir

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

2024-03-11 Thread via GitHub
jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520191884 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -37,4 +42,28 @@ public static OptionalInt ofSentinel(int value) { public st

Re: [PR] KAFKA-15417 flip joinSpuriousLookBackTimeMs and emit non-joined items [kafka]

2024-03-11 Thread via GitHub
VictorvandenHoven commented on code in PR #14426: URL: https://github.com/apache/kafka/pull/14426#discussion_r1520201655 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java: ## @@ -230,8 +234,19 @@ private void emitNonJoinedOuterRecords(

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-11 Thread via GitHub
chia7712 commented on code in PR #15474: URL: https://github.com/apache/kafka/pull/15474#discussion_r1520206161 ## core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala: ## @@ -36,40 +37,79 @@ class ListOffsetsIntegrationTest extends KafkaServerTestHarnes

[PR] User/rjobse/add xinfra identifier check [kafka]

2024-03-11 Thread via GitHub
JobseRyan opened a new pull request, #15514: URL: https://github.com/apache/kafka/pull/15514 Pull request to add a check for the client type and library version to check if the client which is accessing this broker is a xinfra client ### Committer Checklist (excluded from commit messa

Re: [PR] User/rjobse/add xinfra identifier check [kafka]

2024-03-11 Thread via GitHub
JobseRyan closed pull request #15514: User/rjobse/add xinfra identifier check URL: https://github.com/apache/kafka/pull/15514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] dummy PR to check acls [kafka]

2024-03-11 Thread via GitHub
JobseRyan opened a new pull request, #15515: URL: https://github.com/apache/kafka/pull/15515 dummy PR ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (inclu

Re: [PR] dummy PR to check acls [kafka]

2024-03-11 Thread via GitHub
JobseRyan closed pull request #15515: dummy PR to check acls URL: https://github.com/apache/kafka/pull/15515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[PR] KAFKA-7632: Support Compression Levels (KIP-390) [kafka]

2024-03-11 Thread via GitHub
mimaison opened a new pull request, #15516: URL: https://github.com/apache/kafka/pull/15516 Based on https://github.com/apache/kafka/pull/5927 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build st

Re: [PR] KAFKA-16341: fix the LogValidator for non-compressed type [kafka]

2024-03-11 Thread via GitHub
jolshan commented on code in PR #15476: URL: https://github.com/apache/kafka/pull/15476#discussion_r1520299410 ## core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala: ## @@ -0,0 +1,77 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-16341: fix the LogValidator for non-compressed type [kafka]

2024-03-11 Thread via GitHub
jolshan commented on code in PR #15476: URL: https://github.com/apache/kafka/pull/15476#discussion_r1520300581 ## core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala: ## @@ -0,0 +1,77 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[PR] MINOR: Kafka Streams docs fixes [kafka]

2024-03-11 Thread via GitHub
mjsax opened a new pull request, #15517: URL: https://github.com/apache/kafka/pull/15517 - add missing section to TOC - add default value for client.id -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[PR] Minor: Tweak streams config doc [kafka]

2024-03-11 Thread via GitHub
cherylws opened a new pull request, #15518: URL: https://github.com/apache/kafka/pull/15518 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testin

Re: [PR] KAFKA-16295: Align RocksDB and in-memory store init() sequences [kafka]

2024-03-11 Thread via GitHub
wcarlson5 commented on code in PR #15421: URL: https://github.com/apache/kafka/pull/15421#discussion_r1520361134 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java: ## @@ -170,9 +170,6 @@ public void init(final ProcessorContext context, @Ove

Re: [PR] MINOR: Tweak streams config doc [kafka]

2024-03-11 Thread via GitHub
cherylws commented on PR #15518: URL: https://github.com/apache/kafka/pull/15518#issuecomment-1989345872 @mjsax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

2024-03-11 Thread via GitHub
jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520381484 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -528,27 +478,6 @@ public Map> partitionsPendingRevocatio

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

2024-03-11 Thread via GitHub
jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520383812 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -33,49 +33,6 @@ * The CurrentAssignmentBuilder cla

[jira] [Commented] (KAFKA-16356) Remove class-name dispatch in RemoteLogMetadataSerde

2024-03-11 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825439#comment-17825439 ] Greg Harris commented on KAFKA-16356: - [~linu] I have given you permissions to assig

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

2024-03-11 Thread via GitHub
jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520414314 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -170,72 +127,122 @@ public CurrentAssignmentBuilder

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

2024-03-11 Thread via GitHub
jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520383812 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -33,49 +33,6 @@ * The CurrentAssignmentBuilder cla

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

2024-03-11 Thread via GitHub
jolshan commented on code in PR #15364: URL: https://github.com/apache/kafka/pull/15364#discussion_r1520418403 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/MemberState.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-16345: Optionally URL-encode clientID and clientSecret in authorization header [kafka]

2024-03-11 Thread via GitHub
bachmanity1 commented on PR #15475: URL: https://github.com/apache/kafka/pull/15475#issuecomment-1989425275 @kirktrue @mimaison kind reminder. Could you please have a look at the KIP? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-15841) Add Support for Topic-Level Partitioning in Kafka Connect

2024-03-11 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825454#comment-17825454 ] Greg Harris commented on KAFKA-15841: - [~henriquemota] Okay I think i understand bet

[jira] [Comment Edited] (KAFKA-15841) Add Support for Topic-Level Partitioning in Kafka Connect

2024-03-11 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825454#comment-17825454 ] Greg Harris edited comment on KAFKA-15841 at 3/11/24 9:46 PM:

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

2024-03-11 Thread via GitHub
artemlivshits commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1520443872 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {

[PR] MINOR: simplify consumer logic [kafka]

2024-03-11 Thread via GitHub
mjsax opened a new pull request, #15519: URL: https://github.com/apache/kafka/pull/15519 For static member, the `group.instance.id` cannot change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] MINOR: simplify consumer logic [kafka]

2024-03-11 Thread via GitHub
mjsax commented on PR #15519: URL: https://github.com/apache/kafka/pull/15519#issuecomment-1989525897 Follow up from https://github.com/apache/kafka/pull/15419/files#r1513841644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-16152: Fix PlaintextConsumerTest.testStaticConsumerDetectsNewPartitionCreatedAfterRestart [kafka]

2024-03-11 Thread via GitHub
mjsax commented on code in PR #15419: URL: https://github.com/apache/kafka/pull/15419#discussion_r1520482326 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -546,8 +546,9 @@ public ConsumerGroupHeartbeatRequestData buildRe

[jira] [Created] (KAFKA-16364) MM2 High-Resolution Offset Translation

2024-03-11 Thread Greg Harris (Jira)
Greg Harris created KAFKA-16364: --- Summary: MM2 High-Resolution Offset Translation Key: KAFKA-16364 URL: https://issues.apache.org/jira/browse/KAFKA-16364 Project: Kafka Issue Type: New Feature

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

2024-03-11 Thread via GitHub
CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1520495884 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

2024-03-11 Thread via GitHub
CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1520498085 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {

[jira] [Commented] (KAFKA-16291) Mirrormaker2 wrong checkpoints

2024-03-11 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825467#comment-17825467 ] Greg Harris commented on KAFKA-16291: - [~claudio.benfatto] That's a good idea, I agr

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

2024-03-11 Thread via GitHub
CalvinConfluent commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1520495884 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2184,9 +2178,139 @@ void handleFailure(Throwable throwable) {

[PR] KAFKA-16223 Replace EasyMock/PowerMock with Mockito for KafkaConfigBackingStoreTest (1/3) [kafka]

2024-03-11 Thread via GitHub
hgeraldino opened a new pull request, #15520: URL: https://github.com/apache/kafka/pull/15520 This is the last remaining Kafka Connect test that needs migration from PowerMock/EasyMock to Mockito. Following the same approach as the `WorkerSinkTaskTest` migration, which was migrated i

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-11 Thread via GitHub
hgeraldino commented on PR #15506: URL: https://github.com/apache/kafka/pull/15506#issuecomment-1989568163 Thanks @chia7712 for your review @gharris1727 does this looks good to you? It's the final PR to consider the `WorkerSinkTaskTest` migration done done -- This is an automated m

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-11 Thread via GitHub
junrao commented on code in PR #15474: URL: https://github.com/apache/kafka/pull/15474#discussion_r1520506664 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -52,20 +53,24 @@ public class GetOffsetShellTest { private final int topicCount = 4;

Re: [PR] KAFKA-16341: fix the LogValidator for non-compressed type [kafka]

2024-03-11 Thread via GitHub
chia7712 commented on code in PR #15476: URL: https://github.com/apache/kafka/pull/15476#discussion_r1520520996 ## core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala: ## @@ -0,0 +1,77 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

  1   2   >