Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Thomas Lübking
> On Jan. 27, 2015, 6:59 vorm., Martin Gräßlin wrote: > > startkde/kcminit/main.cpp, lines 250-254 > > > > > > I do not like this. If the only need is to check whether it's X11 > > multi-head, it should open an

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270/ --- (Updated Jan. 29, 2015, 1:19 a.m.) Review request for kde-workspace, Alei

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Nick Shaforostoff
> On Jan. 27, 2015, 6:59 a.m., Martin Gräßlin wrote: > > startkde/kcminit/main.cpp, lines 250-254 > > > > > > I do not like this. If the only need is to check whether it's X11 > > multi-head, it should open an x

Re: Feature matrix for future infrastructure

2015-01-28 Thread Jan Kundrát
On Monday, 26 January 2015 18:11:34 CEST, Thomas Lübking wrote: Eg. I can very well see that somebody concerned w/ i18n would like to lookup code via cgit (or similar - no flames here, please ;-), download a single file, fix a so far untranslated string, "diff -pru" it with the original and sim

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Nick Shaforostoff
> On Jan. 27, 2015, 6:59 a.m., Martin Gräßlin wrote: > > startkde/kcminit/main.cpp, lines 250-254 > > > > > > I do not like this. If the only need is to check whether it's X11 > > multi-head, it should open an x

Re: libkgeomap

2015-01-28 Thread Tobias Leupold
> Automatically? Cool then i have to do nothing next time! \o/ Sorry if I get something/anything/everything wrong. Just to say it again: I am a very new and very unexperienced developer. I "just" implemented some functionality for KPA using the libraries we're talking about. I have no idea what

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-28 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ --- (Updated Jan. 28, 2015, 8:35 p.m.) Review request for KDE Base Apps, Mart

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-28 Thread Gregor Mi
> On Jan. 26, 2015, 7:05 a.m., Martin Gräßlin wrote: > > My opinion is that this is a feature which should not be exposed in > > libksysguard. It actually ties libksysguard to KWin, while libksysguard was > > in the past also used in e.g. kdevelop. > > > > If libksysguard wants to offer the fu

Re: Another proposal for modernization of our infrastructure

2015-01-28 Thread Alex Merry
On Wednesday 28 January 2015 13:14:14 Martin Gräßlin wrote: > At the moment I must say that I find gerrit's web interface extremely > cumbersome to use. This is something I experienced with both Qt's as well > as KDE's setup. Navigation through the code is difficult, you cannot see > the complete

Re: Another proposal for modernization of our infrastructure

2015-01-28 Thread Alex Merry
On Wednesday 28 January 2015 12:27:06 Jan Kundrát wrote: > On Wednesday, 28 January 2015 10:08:54 CEST, Ben Cooksley wrote: > > 11) We actually do use some of Jenkins advanced features, and it > > offers quite a lot more than just a visual view of the last failure. > > > > As a quick overview: > >

Re: libkgeomap

2015-01-28 Thread Albert Astals Cid
El Dimecres, 28 de gener de 2015, a les 14:57:18, Tobias Leupold va escriure: > > Why does libkgeomap need to move "somewhere" just to be used by some > > other extragear application? Just do independent releases of it, and > > stop bundling it in digikam > > If I remember correctly, this is the

Re: Placement of config files for Plasma 5 and KF5-based applications

2015-01-28 Thread Thomas Lübking
On Mittwoch, 28. Januar 2015 08:43:41 CET, Martin Gräßlin wrote: c) I simply don't care whether users have a "problem" with ~/.config containing many files, it's a directory for applications, not for the user I don't think this is much about "scaring the user" but how we behave wrt and align

Re: Review Request 122252: KRecursiveFilterProxyModel: fix emitting superfluous dataChanged signals

2015-01-28 Thread Christian Mollekopf
> On Jan. 26, 2015, 9:41 a.m., Christian Mollekopf wrote: > > Looks reasonable to me. I'll apply the patch locally and test it for a > > while. This patch brings the original problem back, that shared folders do not appear until something causes a dataChanged signal (usually a sync). Since the

Re: libkgeomap

2015-01-28 Thread Tobias Leupold
> As you (or they) describe the situation, it seems like kdegraphics is a > dumping ground for stuff which is developed on its own anyway, but whose > maintainer refuses to release on its own. This sounds *bad* to me, > especially that digikam is released so often, that having to release > some ex

Re: libkgeomap

2015-01-28 Thread Pino Toscano
On Wednesday 28 January 2015 14:57:18 Tobias Leupold wrote: > > Why does libkgeomap need to move "somewhere" just to be used by some > > other extragear application? Just do independent releases of it, and > > stop bundling it in digikam > > If I remember correctly, this is the problem. The Digik

Re: libkgeomap

2015-01-28 Thread Tobias Leupold
> Why does libkgeomap need to move "somewhere" just to be used by some > other extragear application? Just do independent releases of it, and > stop bundling it in digikam If I remember correctly, this is the problem. The Digikam team can't or do not want to do single releases, and moving the li

Re: Another proposal for modernization of our infrastructure

2015-01-28 Thread Milian Wolff
On Wednesday 28 January 2015 13:14:14 Martin Gräßlin wrote: I agree on what Martin says about some issues with the web interface of Gerrit, esp. in regard to shortcuts. Note though that the Qt gerrit has the ability (via custom code) to show the full patch. > Given that code review is the cor

Re: Re: Another proposal for modernization of our infrastructure

2015-01-28 Thread Martin Gräßlin
On Wednesday 28 January 2015 11:52:17 Martin Klapetek wrote: > Hey, > > On Tue, Jan 27, 2015 at 11:08 AM, Jan Kundrát wrote: > > Hi, > > as promised, here is a proposal on how our infrastructure can be improved, > > with emphasis on service integration. There are screenshots inside. > > > > Feed

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Martin Gräßlin
> On Jan. 27, 2015, 7:59 a.m., Martin Gräßlin wrote: > > startkde/kcminit/main.cpp, lines 250-254 > > > > > > I do not like this. If the only need is to check whether it's X11 > > multi-head, it should open an x

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Thomas Lübking
> On Jan. 27, 2015, 6:59 vorm., Martin Gräßlin wrote: > > startkde/kcminit/main.cpp, lines 250-254 > > > > > > I do not like this. If the only need is to check whether it's X11 > > multi-head, it should open an

Re: Another proposal for modernization of our infrastructure

2015-01-28 Thread Jan Kundrát
On Wednesday, 28 January 2015 10:08:54 CEST, Ben Cooksley wrote: 1) Most applications integrate extremely poorly with LDAP. They basically take the details once on first login and don't sync the details again after that (this is what both Chiliproject and Reviewboard do). How does Gerrit perform

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Nick Shaforostoff
> On Jan. 27, 2015, 6:59 a.m., Martin Gräßlin wrote: > > startkde/kcminit/main.cpp, lines 250-254 > > > > > > I do not like this. If the only need is to check whether it's X11 > > multi-head, it should open an x

Re: Another proposal for modernization of our infrastructure

2015-01-28 Thread Martin Klapetek
Hey, On Tue, Jan 27, 2015 at 11:08 AM, Jan Kundrát wrote: > Hi, > as promised, here is a proposal on how our infrastructure can be improved, > with emphasis on service integration. There are screenshots inside. > > Feedback is very welcome. > Thanks for putting that together. One thing I still

Re: Another proposal for modernization of our infrastructure

2015-01-28 Thread Ben Cooksley
On Tue, Jan 27, 2015 at 11:08 PM, Jan Kundrát wrote: > Hi, Hi Jan, > as promised, here is a proposal on how our infrastructure can be improved, > with emphasis on service integration. There are screenshots inside. > > Feedback is very welcome. A few comments. 1) Most applications integrate ext

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270/#review74892 --- startkde/kcminit/main.cpp

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-28 Thread Martin Gräßlin
> On Jan. 27, 2015, 7:59 a.m., Martin Gräßlin wrote: > > startkde/kcminit/main.cpp, lines 250-254 > > > > > > I do not like this. If the only need is to check whether it's X11 > > multi-head, it should open an x