BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/67/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 27 Nov 2017 08:03:09 +
Build duration:
4 min 32 sec and counting
JUnit Test
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:70b09f9b08fb: Warn about errors when parsing json files
(authored by apol).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8992?vs=22910&id=22986
REVISION DETA
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/6/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
Date of build:
Mon, 27 Nov 2017 08:03:09 +
Build duration:
7 min 59 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/8/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Mon, 27 Nov 2017 08:03:09 +
Build duration:
7 min 49 sec and counting
JUnit Tests
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20WindowsMSVCQt5.9/17/
Project:
Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9
Date of build:
Mon, 27 Nov 2017 05:19:50 +
Build duration:
3 hr 1 min and counting
anthonyfieroni added a comment.
Ship it, it's only tests and looks good.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
To: franckarrecot, renatoo, ervin, mlaurent
Cc: anthonyfieroni, ervin, ngraham, mlaurent, #frameworks
mart added a comment.
In https://phabricator.kde.org/D8982#171694, @davidedmundson wrote:
> I like the GridView
>
> Note that we'll want to use that from the WallpaperDialog in Plasma, which
isn't a KCM. I don't think it will be a problem though ?
yes, those components should
davidedmundson added inline comments.
INLINE COMMENTS
> mart wrote in SimpleKCM.qml:23
> yeah, it does that..
> it keeps the qquickwidget small enough so the qwidget scrollbar won't be
> there.
> which isn't optimal, but i think the scrolling should be handed by the qml
> part.
> but i think t
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.9/25/
Project:
Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9
Date of build:
Mon, 27 Nov 2017 08:03:08 +
Build duration:
2 hr 25 min and counting
JUn
cgiboudeaux added a comment.
ping !
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8858
To: cgiboudeaux, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
mart updated this revision to Diff 22996.
mart added a comment.
- documentation
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8982?vs=22897&id=22996
BRANCH
arcpatch-D8982
REVISION DETAIL
https://phabricator.kde.org/D8982
AFFECTED FILES
src/qm
mart marked 10 inline comments as done.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D8982
To: mart, #plasma, hein, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mar
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in SimpleKCM.qml:23
> > but i think the scrolling should be handed by the qml part.
>
> Why?
3 reasons:
1. because the long term goal is to get rid of the qwidget version, so even if
it's long down the road things should be de
franckarrecot added a dependent revision: D8366: Factoring out lists of url
data within KFilePlacesModelTest.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8948
To: renatoo, dfaure
Cc: #frameworks
franckarrecot edited the summary of this revision.
franckarrecot added a dependency: D8948: Created an auxiliary function
'KFilePlacesModel::movePlace'.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
To: franckarrecot, renatoo, ervin, mlaurent
Cc: anthonyfieroni, ervi
franckarrecot added a dependent revision: D8367: Hidding place groups
implementation in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8946
To: renatoo, dfaure
Cc: ngraham, #frameworks
franckarrecot edited the summary of this revision.
franckarrecot added dependencies: D8948: Created an auxiliary function
'KFilePlacesModel::movePlace', D8947: Expose KFilePlacesModel 'iconName' role,
D8946: Avoid unnecessary 'dataChanged' signal, D8945: Return a valid bookmark
object for any e
franckarrecot added a dependent revision: D8367: Hidding place groups
implementation in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8945
To: renatoo, dfaure
Cc: ngraham, #frameworks
franckarrecot added a dependent revision: D8367: Hidding place groups
implementation in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8948
To: renatoo, dfaure
Cc: #frameworks
franckarrecot added a dependent revision: D8367: Hidding place groups
implementation in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8943
To: renatoo, dfaure
Cc: ngraham, #frameworks
franckarrecot added a dependent revision: D8367: Hidding place groups
implementation in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8944
To: renatoo, dfaure
Cc: ngraham, #frameworks
franckarrecot added a dependent revision: D8367: Hidding place groups
implementation in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8947
To: renatoo, dfaure
Cc: ngraham, kossebau, #frameworks
leinir added a comment.
Quicker is better here, i think... Perhaps it is worth adding the
documentation we discussed as well in this review? Thinking about making it
easier to track the history and whatnot of what happened and why...
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://pha
franckarrecot added a comment.
I'll ship it as soon as the commits it's built on will be shipped. Sorry I
rebased this one to renato new commit split so we would avoid conflict if
interlaced commit pushed happend.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
To
franckarrecot edited the summary of this revision.
franckarrecot added dependencies: D8948: Created an auxiliary function
'KFilePlacesModel::movePlace', D8947: Expose KFilePlacesModel 'iconName' role,
D8946: Avoid unnecessary 'dataChanged' signal, D8945: Return a valid bookmark
object for any e
franckarrecot added a dependent revision: D8450: User can now hide an entire
places group from KFilePlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8943
To: renatoo, dfaure
Cc: ngraham, #frameworks
franckarrecot added a dependent revision: D8450: User can now hide an entire
places group from KFilePlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8944
To: renatoo, dfaure
Cc: ngraham, #frameworks
franckarrecot added a dependent revision: D8450: User can now hide an entire
places group from KFilePlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8946
To: renatoo, dfaure
Cc: ngraham, #frameworks
franckarrecot added a dependent revision: D8450: User can now hide an entire
places group from KFilePlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8948
To: renatoo, dfaure
Cc: #frameworks
franckarrecot added a dependent revision: D8450: User can now hide an entire
places group from KFilePlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8945
To: renatoo, dfaure
Cc: ngraham, #frameworks
franckarrecot added a dependent revision: D8450: User can now hide an entire
places group from KFilePlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8947
To: renatoo, dfaure
Cc: ngraham, kossebau, #frameworks
franckarrecot updated this revision to Diff 22998.
franckarrecot added a comment.
fix variable name
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=22901&id=22998
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autotests/kfileplace
franckarrecot updated this revision to Diff 22999.
franckarrecot added a comment.
now related to the refactoring commit coming after
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8450?vs=22902&id=22999
REVISION DETAIL
https://phabricator.kde.org/D8450
AFFE
franckarrecot added a dependent revision: D9015: Refactoring the
hidding/showing animation use within KFilePlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks
franckarrecot created this revision.
franckarrecot added reviewers: ervin, renatoo, mlaurent, ngraham.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Depends on https://phabricator.kde.org/D8367
Depends on https://pha
franckarrecot added a dependent revision: D9015: Refactoring the
hidding/showing animation use within KFilePlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #framework
franckarrecot marked an inline comment as done.
franckarrecot added inline comments.
INLINE COMMENTS
> ervin wrote in kfileplacesview.cpp:863-866
> Cool, I'll wait for that extra review to appear before accepting that one. So
> that we don't forget it. :-)
Was that the thing you had in mind ?
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/5/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
Date of build:
Mon, 27 Nov 2017 12:50:56 +
Build duration:
1 min 45 sec and counting
JUnit Tests
Nam
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/150/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 27 Nov 2017 12:50:56 +
Build duration:
1 min 36 sec and counting
JUnit Tests
renatoo updated this revision to Diff 23009.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8943?vs=22962&id=23009
REVISION DETAIL
https://phabricator.kde.org/D8943
AFFECTED FILES
autotests/kfileplacesmodelte
renatoo updated this revision to Diff 23010.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8944?vs=22963&id=23010
REVISION DETAIL
https://phabricator.kde.org/D8944
AFFECTED FILES
autotests/kfileplacesmodelte
renatoo updated this revision to Diff 23014.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8948?vs=22967&id=23014
REVISION DETAIL
https://phabricator.kde.org/D8948
AFFECTED FILES
autotests/kfileplacesmodelte
renatoo updated this revision to Diff 23012.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8946?vs=22965&id=23012
REVISION DETAIL
https://phabricator.kde.org/D8946
AFFECTED FILES
autotests/kfileplacesmodelte
renatoo updated this revision to Diff 23011.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8945?vs=22964&id=23011
REVISION DETAIL
https://phabricator.kde.org/D8945
AFFECTED FILES
autotests/kfileplacesmodelte
renatoo updated this revision to Diff 23013.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8947?vs=22966&id=23013
REVISION DETAIL
https://phabricator.kde.org/D8947
AFFECTED FILES
autotests/kfileplacesmodelte
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:66682d0df7e6: Create
'KFilePlacesModel::convertedUrl' static function (authored by Renato
Araujo Oliveira Filho ).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://ph
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/5/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Mon, 27 Nov 2017 13:24:16 +
Build duration:
5 min 41 sec and counting
JUnit Tests
Name: (root) Fa
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/5/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Mon, 27 Nov 2017 13:24:16 +
Build duration:
10 min and counting
JUnit Tests
Name: (root) Failed
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:4186286c16b1: Create a
'KFilePlacesModel::refresh' function (authored by Renato Araujo
Oliveira Filho ).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:62c5d76f17a1: Avoid unnecessary 'dataChanged'
signal (authored by Renato Araujo Oliveira Filho
).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/146/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 27 Nov 2017 13:43:24 +
Build duration:
2 min 38 sec and counting
CONSOLE OUTPUT
[...
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c8bd7ad4b296: Created an auxiliary function
'KFilePlacesModel::movePlace' (authored by Renato Araujo Oliveira
Filho ).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https:
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/147/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 27 Nov 2017 13:46:16 +
Build duration:
12 min and counting
JUnit Tests
Name: (root)
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/6/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Mon, 27 Nov 2017 13:41:46 +
Build duration:
19 min and counting
JUnit Tests
Name: (root) Failed:
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/6/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Mon, 27 Nov 2017 13:41:46 +
Build duration:
19 min and counting
JUnit Tests
Name: (root) Failed
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:531d7759578e: Return a valid bookmark object for any
entry in KFilePlacesModel (authored by Renato Araujo Oliveira Filho
).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
h
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/7/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Mon, 27 Nov 2017 14:01:17 +
Build duration:
11 min and counting
JUnit Tests
Name: (root) Failed
mlaurent added a comment.
oh it was abandoned ! ok :)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8862
To: renatoo, dfaure, mwolff
Cc: mlaurent, mwolff, dfaure, ngraham, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:700c7d3af43b: Avoid run kfileplacesmodeltest and
kfileplacesviewtest in parallel (authored by Renato Araujo Oliveira Filho
).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/7/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Mon, 27 Nov 2017 14:00:55 +
Build duration:
18 min and counting
JUnit Tests
Name: (root) Failed:
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:7be5649a0d9c: Expose KFilePlacesModel
'iconName' role (authored by Renato Araujo Oliveira Filho
).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.o
franckarrecot added a comment.
this one is landable now that its dependencies are pushed.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
To: franckarrecot, renatoo, ervin, mlaurent
Cc: anthonyfieroni, ervin, ngraham, mlaurent, #frameworks
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/8/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Mon, 27 Nov 2017 14:14:22 +
Build duration:
10 min and counting
JUnit Tests
Name: (root) Failed
franckarrecot updated this revision to Diff 23023.
franckarrecot added a comment.
update
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8366?vs=22900&id=23023
REVISION DETAIL
https://phabricator.kde.org/D8366
AFFECTED FILES
autotests/kfileplacesmodeltest.
franckarrecot updated this revision to Diff 23025.
franckarrecot marked an inline comment as done.
franckarrecot added a comment.
update, have to wait to be pushed, since it contains i18n translation, next
week:
in the first two weeks after the first saturday of the month
REPOSITORY
R241
franckarrecot updated this revision to Diff 23024.
franckarrecot added a comment.
update - should be landable now
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=22998&id=23024
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autote
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
serialize-unit-test
REVISION DETAIL
https://phabricator.kde.org/D9017
To: renatoo, dfaure
Cc: #frameworks
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Both tests modify the bookmark file and that can cause test failure
TEST PLAN
run all kio unit test
REPOSITORY
R241 KIO
BRANCH
seria
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/8/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Mon, 27 Nov 2017 14:19:43 +
Build duration:
15 min and counting
JUnit Tests
Name: (root) Failed:
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/9/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Mon, 27 Nov 2017 14:27:47 +
Build duration:
8 min 31 sec and counting
JUnit Tests
Name: (root)
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesmodel.cpp:77
> +if (day > 0) {
> +date += QString("-%1").arg(day, 2, 10, QChar('0'));
> +}
QStringLiteral("-%1").arg(...)
> kfileplacesmodel.cpp:96
> +timelineUrl = QUrl(timelinePrefix + timelin
ngraham added a comment.
Can you mark the Not Done comments as Done if they're done now?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks
leinir created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
When building plugins, don't arbitrarily rename the output files (as this
will occasionally result in circular dependencies).
In this re
vhanda added a comment.
> @vhanda do you know if there is something to do to update Baloo database
when metadata returned by KFileMetaData are changed even if the file itself did
not change ?
I'm starting to forget the code base and what all I implemented. But I don't
think such a thing
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/9/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Mon, 27 Nov 2017 14:35:34 +
Build duration:
17 min and counting
JUnit Tests
Name: (root) Failed:
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/149/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 27 Nov 2017 14:31:29 +
Build duration:
23 min and counting
JUnit Tests
Name: (root)
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3e537c4dd935: Factoring out lists of url data within
KFilePlacesModelTest (authored by franckarrecot, committed by ngraham).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.o
franckarrecot updated this revision to Diff 23026.
franckarrecot added a comment.
update
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9015?vs=23000&id=23026
REVISION DETAIL
https://phabricator.kde.org/D9015
AFFECTED FILES
src/filewidgets/kfileplacesview
vhanda added a comment.
To give some history - Strigi used to do this guessing, and when I
implemented KFileMetaData, I decided to do the same. I don't have an opinion on
whether it is a good idea or not.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D8007
T
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.9/117/
Project:
Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9
Date of build:
Mon, 27 Nov 2017 12:50:56 +
Build duration:
2 hr 23 min and counting
JUnit Te
leinir added a reviewer: Frameworks.
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator.kde.org/D9018
To: leinir, #frameworks
Cc: #frameworks
akulichalexandr added a task: T7499: Fix plasma calendar applet layout.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9019
To: akulichalexandr, #plasma
Cc: plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterbe
akulichalexandr created this revision.
akulichalexandr added a reviewer: Plasma.
akulichalexandr added a project: Plasma.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added a project: Frameworks.
REPOSITORY
R242 Plasma Framework (Library)
REVISION D
akulichalexandr updated this revision to Diff 23032.
akulichalexandr added a comment.
Updating https://phabricator.kde.org/D9019: Plasma: Adjust the calendar
toolbar layout
The new diff is created via Arcanist
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
http
akulichalexandr edited the test plan for this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9019
To: akulichalexandr, #plasma
Cc: plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, seba
akulichalexandr retitled this revision from "Plasma: Adjust the calendar
toolbar layout" to "[Calendar] Adjust the calendar toolbar anchors".
akulichalexandr edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9019
To:
franckarrecot marked 2 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/61/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 27 Nov 2017 16:24:23 +
Build duration:
8 min 17 sec and counting
JUnit Tests
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8858
To: cgiboudeaux, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff,
lesliezhai, ali-moha
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/2/
Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
Date of build:
Mon, 27 Nov 2017 16:24:22 +
Build duration:
9 min 45 sec and counting
JUnit Tests
Nam
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.7/2/
Project:
Frameworks kwayland kf5-qt5 SUSEQt5.7
Date of build:
Mon, 27 Nov 2017 16:24:22 +
Build duration:
10 min and counting
JUnit Tests
Name: (root
cgiboudeaux added a comment.
Mostly good. Last question : is the version important ? If yes, please add an
additional way to get the version if Seccomp_VERSION is empty. (you can parse
seccomp.h to find it, look at the other Find*.cmake modules for examples)
INLINE COMMENTS
> FindSeccomp.cm
akulichalexandr edited the test plan for this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9019
To: akulichalexandr, #plasma
Cc: plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, seba
franckarrecot marked 15 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:7cd465a3bad3: Fix testWaylandFullscreenShell. (authored
by cgiboudeaux).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8858?vs=22546&id=23037#toc
REPOSITORY
R127 KWayland
CHANGES SINCE LAS
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
Thanks! It's the little things that make it feel polished :)
Do you have commit access?
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
upstreaming
REVISION DETAIL
https://p
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.9/118/
Project:
Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9
Date of build:
Mon, 27 Nov 2017 15:14:08 +
Build duration:
2 hr 5 min and counting
JUnit Tes
akulichalexandr added a comment.
In https://phabricator.kde.org/D9019#172612, @broulik wrote:
> Thanks! It's the little things that make it feel polished :)
>
> Do you have commit access?
Yes, I have the access, but I did not contribute for a long time and still
have to get us
davidedmundson added a comment.
> but I did not contribute for a long time
Good to have you back!
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
upstreaming
REVISION DETAIL
https://phabricator.kde.org/D9019
To: akulichalexandr, #plasma, broulik
Cc: davidedmundson, broulik, pla
kossebau added a comment.
In https://phabricator.kde.org/D9012#172387, @leinir wrote:
> Quicker is better here, i think... Perhaps it is worth adding the
documentation we discussed as well in this review? Thinking about making it
easier to track the history and whatnot of what happened a
1 - 100 of 133 matches
Mail list logo