Re: [libvirt] [test-API PATCH 7/7] domain/[start|destroy]: Add a optional noping flag to skip the ping test

On 03/21/2012 06:13 PM, Guannan Ren wrote: > On 03/21/2012 08:46 PM, Peter Krempa wrote: >> For some tests it's not needed to ping the guest in the startup process. >> This patch adds a flag to the start and destroy test to skip such >> attempts (that consume a lot of time) >> --- >> repos/domain

Re: [libvirt] [PATCH 06/14] Store parsed query parameters directly in the virURIPtr struct

On 2012年03月21日 01:33, Daniel P. Berrange wrote: From: "Daniel P. Berrange" Avoid the need for each driver to parse query parameters itself by storing them directly in the virURIPtr struct. The parsing code is a copy of that from src/util/qparams.c The latter will be removed in a later patch *

Re: [libvirt] [PATCH 06/14] Store parsed query parameters directly in the virURIPtr struct

On 2012年03月21日 01:33, Daniel P. Berrange wrote: From: "Daniel P. Berrange" Avoid the need for each driver to parse query parameters itself by storing them directly in the virURIPtr struct. The parsing code is a copy of that from src/util/qparams.c The latter will be removed in a later patch *

Re: [libvirt] [PATCH 07/14] Convert drivers over to use virURIPtr for query params

On 2012年03月21日 01:33, Daniel P. Berrange wrote: From: "Daniel P. Berrange" Convert drivers currently using the qparams APIs, to instead use the virURIPtr query parameters directly. * src/esx/esx_util.c, src/hyperv/hyperv_util.c, src/remote/remote_driver.c, src/xenapi/xenapi_utils.c: Remove

Re: [libvirt] [test-API PATCH 0/7] Multiple fixes and improvements series

On 03/21/2012 08:46 PM, Peter Krempa wrote: This is a set of more or less independent fixes and improvements to the test API. I ran across these while trying to write a basic test case as a "Hello world!" to the test-API. Improvements are in fields of cross-distro compatibility, broken API's and

Re: [libvirt] [test-API PATCH 7/7] domain/[start|destroy]: Add a optional noping flag to skip the ping test

On 03/22/2012 03:02 PM, Martin Kletzander wrote: I'd rather do it using the get() method for dictionaries with some default, i.e. params.get('flags', None). Just my $0.02 Martin Thanks, This belongs to enhancement work, let us do it a little later. Probably, we need a cleanup patch f

Re: [libvirt] [PATCH 09/14] Rename src/util/authhelper.[ch] to src/util/virauth.[ch]

On 2012年03月21日 01:33, Daniel P. Berrange wrote: From: "Daniel P. Berrange" To follow latest naming conventions, rename src/util/authhelper.[ch] to src/util/virauth.[ch]. * src/util/authhelper.[ch]: Rename to src/util/virauth.[ch] * src/esx/esx_driver.c, src/hyperv/hyperv_driver.c, src/phyp/p

Re: [libvirt] [PATCH 10/14] Rename virRequest{Username, Password} to virAuthGet{Username, Password}

On 2012年03月21日 01:33, Daniel P. Berrange wrote: From: "Daniel P. Berrange" Ensure that the functions in virauth.h have names matching the file prefix, by renaming virRequest{Username,Password} to virAuthGet{Username,Password} --- src/esx/esx_driver.c |8 src/hyperv/hyperv_

Re: [libvirt] [PATCH 11/14] Add helper API for finding auth file path

On 2012年03月21日 01:33, Daniel P. Berrange wrote: From: "Daniel P. Berrange" * src/util/virauth.c, src/util/virauth.h: Add virAuthGetConfigFilePath * include/libvirt/virterror.h, src/util/virterror.c: Add VIR_FROM_AUTH error domain --- include/libvirt/virterror.h |1 + src/libvirt_privat

Re: [libvirt] [PATCH 12/14] Add APIs for handling lookup of auth credentials from config file

On 2012年03月21日 01:33, Daniel P. Berrange wrote: From: "Daniel P. Berrange" This defines the format for the auth credential config file and provides APIs to access the data. The config file contains one or more named 'credential' sets [credentials-$NAME] credname1=value1 credname2=value

Re: [libvirt] [test-API PATCH 2/7] lib: fix streamAPI class

On 03/21/2012 04:45 PM, Guannan Ren wrote: On 03/21/2012 08:46 PM, Peter Krempa wrote: The streamAPI class that encapsulates work with libvirt's streams was fundamentaly broken: - each call to one of the methods created a new stream and performed the call - some methods called virStream methods

Re: [libvirt] [PATCH 13/14] Refactor code prompting for SASL credentials

On 2012年03月21日 01:33, Daniel P. Berrange wrote: From: "Daniel P. Berrange" SASL may prompt for credentials after either a 'start' or 'step' invocation. In both cases the code to handle this is the same. Refactor this code into a separate method to reduce the duplication, since the complexity is

Re: [libvirt] [test-API PATCH 3/7] domainAPI: Add wrapper method to work with domain's console connections

On 03/21/2012 05:02 PM, Guannan Ren wrote: On 03/21/2012 08:46 PM, Peter Krempa wrote: This patch adds a wrapper that enables work with consoles in the test-API. --- lib/domainAPI.py | 9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/lib/domainAPI.py b/lib/domainAPI.py

Re: [libvirt] [PATCH 14/14] Lookup auth credentials in config file before prompting

On 2012年03月21日 01:33, Daniel P. Berrange wrote: From: "Daniel P. Berrange" When SASL requests auth credentials, try to look them up in the config file first. If any are found, remove them from the list that the user is prompted for --- src/esx/esx_driver.c | 58 +- src

Re: [libvirt] [test-API PATCH 3/7] domainAPI: Add wrapper method to work with domain's console connections

Wouldn't this actualy defeat the encapsulation that is provided in the StreamAPI class? With this change you can reuse the StreamAPI object for other actions later on too, without loosing the abstraction. With the chagne you pushed: diff --git a/lib/domainAPI.py b/lib/domainAPI.py index 91f

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

On Tue, Mar 13, 2012 at 11:53:19AM -0300, Eduardo Habkost wrote: > So, trying to summarize what was discussed in the call: > > On Mon, Mar 12, 2012 at 10:08:10AM -0300, Eduardo Habkost wrote: > > > Let's say we moved CPU definitions to /usr/share/qemu/cpu-models.xml. > > > > > > Obviously, we'd w

Re: [libvirt] [PATCH 08/14] Add a virKeyfilePtr object for parsing '.ini' files

On 2012年03月21日 01:33, Daniel P. Berrange wrote: From: "Daniel P. Berrange" The '.ini' file format is a useful alternative to the existing config file style, when you need to have config files which are hashes of hashes. The 'virKeyFilePtr' object provides a way to parse these file types. * src/

Re: [libvirt] Does libvirt check MCS labels during hot-add disk image ?

On Thu, Mar 22, 2012 at 09:36:30AM +0530, Onkar N Mahajan wrote: > Libvirt doesn't care about security during hot add disk images. It even > accepts addition of disk images of other guest running on the host. > > Steps followed to create this scenario : > Now, try to add vm1's disk image into

Re: [libvirt] [test-API PATCH 0/7] Multiple fixes and improvements series

On 03/22/2012 08:54 AM, Guannan Ren wrote: On 03/21/2012 08:46 PM, Peter Krempa wrote: This is a set of more or less independent fixes and improvements to the test API. I ran across these while trying to write a basic test case as a "Hello world!" to the test-API. Improvements are in fields of

[libvirt] [PATCH 0/2] Cleanup for return with parentheses

There was one big inconsistency in our source files when return was used. Sometimes it was used with parentheses and sometimes without. The old-style return(value) was removed in the first commit, the second commit introduces new syntax-check to ensure the style will remain the same in the future.

[libvirt] [PATCH 2/2] Added syntax-check rule for return with parentheses

After cleanup introduced with previous commit, there is a need for syntax-check rule taking care of return(). Regexp used in 'prohibit' parameter is taken from the cleanup commit and modified so it fits 'grep -E' format. Semicolon at the end is needed, otherwise the regexp could match return with c

[libvirt] [PATCH] Use virDomainFindbyID and pass id instead of a pointer to lxcMontitorEvent.

This fixes a race condition when VIR_EVENT_HANDLE_HANGUP is triggered during lxcDomainDestroyFlags: lxcMonitorEvent tries to acquire the driver lock held by lxcDomainDestroyFlags and blocks. Meanwhile lxcDomainDestroyFlags will free the "vm" structure and release the driver lock. lxcMonitorEvent un

[libvirt] [test-API PATCH] streamAPI: Create stream objects that are already encapsulated

With this patch, the newStream() method of the ConnectAPI class returns an already encapsulated StreamAPI object . *lib/connectAPI.py: - modify newStream method to return StreamAPI object *lib/streamAPI.py: - modify constructor to take virStream objects --- lib/connectAPI.

[libvirt] [test-API PATCH] libs: Add flags for streams and the console

Add the local copy of the flags. --- lib/connectAPI.py |2 ++ lib/domainAPI.py |3 +++ 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/lib/connectAPI.py b/lib/connectAPI.py index dab5e7d..2723fc8 100644 --- a/lib/connectAPI.py +++ b/lib/connectAPI.py @@ -350,3 +350,5 @@ cla

Re: [libvirt] [PATCH 12/14] Add APIs for handling lookup of auth credentials from config file

On 03/20/2012 11:33 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > This defines the format for the auth credential config file and > provides APIs to access the data. The config file contains > one or more named 'credential' sets > > [credentials-$NAME] > credname1=value1 >

[libvirt] Problem with Open vSwitch and dnsmasq

Dear all, I have the following situation: -I replaced the standard bridge driver with the Open VSwitch one; -I started a NAT-network on Libvirt (bridge name virbr1); -I started a Virtual Machine (VM1) on Libvirt, and I tagged his interface (vnet0) with tag=2; -if I run "# ovs-vsctl show" I obtain

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

On Thu, Mar 22, 2012 at 11:32:44AM +0200, Gleb Natapov wrote: > On Tue, Mar 13, 2012 at 11:53:19AM -0300, Eduardo Habkost wrote: > > So, trying to summarize what was discussed in the call: > > > > On Mon, Mar 12, 2012 at 10:08:10AM -0300, Eduardo Habkost wrote: > > > > Let's say we moved CPU defin

Re: [libvirt] [test-API PATCH] streamAPI: Create stream objects that are already encapsulated

On 03/22/2012 08:54 PM, Peter Krempa wrote: With this patch, the newStream() method of the ConnectAPI class returns an already encapsulated StreamAPI object . *lib/connectAPI.py: - modify newStream method to return StreamAPI object *lib/streamAPI.py: - modify construct

Re: [libvirt] [test-API PATCH] libs: Add flags for streams and the console

On 03/22/2012 08:56 PM, Peter Krempa wrote: Add the local copy of the flags. --- lib/connectAPI.py |2 ++ lib/domainAPI.py |3 +++ 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/lib/connectAPI.py b/lib/connectAPI.py index dab5e7d..2723fc8 100644 --- a/lib/connectAPI.p

[libvirt] [PATCH] Leave all child processes running when stopping systemd service

From: "Daniel P. Berrange" Currently the libvirt.service unit file for systemd does not specify any kill mode. So systemd kills off every process inside its cgroup. ie all dnsmasq processes, all virtual machines. This obviously not what we want. Set KillMode=process so that it only kills the top

Re: [libvirt] [PATCH] Leave all child processes running when stopping systemd service

On Thu, 2012-03-22 at 14:03 +, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Currently the libvirt.service unit file for systemd does not > specify any kill mode. So systemd kills off every process > inside its cgroup. ie all dnsmasq processes, all virtual > machines. This obviou

Re: [libvirt] [PATCH 1/2] snapshot: add support for qemu transaction command

On 03/17/2012 10:27 PM, Eric Blake wrote: QEmu 1.1 is adding a 'transaction' command to the JSON monitor. Each element of a transaction corresponds to a top-level command, with the additional guarantee that the transaction flushes all pending I/O, then guarantees that all actions will be successf

Re: [libvirt] [PATCH] Leave all child processes running when stopping systemd service

On Thu, 2012-03-22 at 14:10 +, Mark McLoughlin wrote: > On Thu, 2012-03-22 at 14:03 +, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > Currently the libvirt.service unit file for systemd does not > > specify any kill mode. So systemd kills off every process > > inside its

Re: [libvirt] [PATCH] Leave all child processes running when stopping systemd service

On Thu, Mar 22, 2012 at 02:10:30PM +, Mark McLoughlin wrote: > On Thu, 2012-03-22 at 14:03 +, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > Currently the libvirt.service unit file for systemd does not > > specify any kill mode. So systemd kills off every process > > ins

Re: [libvirt] [PATCH] Leave all child processes running when stopping systemd service

On Thu, 2012-03-22 at 14:22 +, Daniel P. Berrange wrote: > On Thu, Mar 22, 2012 at 02:10:30PM +, Mark McLoughlin wrote: > > On Thu, 2012-03-22 at 14:03 +, Daniel P. Berrange wrote: > > > From: "Daniel P. Berrange" > > > > > > Currently the libvirt.service unit file for systemd does no

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

On Thu, Mar 22, 2012 at 10:31:21AM -0300, Eduardo Habkost wrote: > On Thu, Mar 22, 2012 at 11:32:44AM +0200, Gleb Natapov wrote: > > On Tue, Mar 13, 2012 at 11:53:19AM -0300, Eduardo Habkost wrote: > > > So, trying to summarize what was discussed in the call: > > > > > > On Mon, Mar 12, 2012 at 10

Re: [libvirt] [PATCH] Leave all child processes running when stopping systemd service

On Thu, Mar 22, 2012 at 02:27:59PM +, Mark McLoughlin wrote: > On Thu, 2012-03-22 at 14:22 +, Daniel P. Berrange wrote: > > On Thu, Mar 22, 2012 at 02:10:30PM +, Mark McLoughlin wrote: > > > On Thu, 2012-03-22 at 14:03 +, Daniel P. Berrange wrote: > > > > From: "Daniel P. Berrange"

Re: [libvirt] [PATCH 2/2] snapshot: wire up qemu transaction command

On 03/17/2012 10:27 PM, Eric Blake wrote: The hardest part about adding transactions is not using the new monitor command, but undoing the partial changes we made prior to a failed transaction. * src/qemu/qemu_driver.c (qemuDomainSnapshotCreateDiskActive): Use transaction when available. (qemuDo

Re: [libvirt] [PATCH 2/2] snapshot: wire up qemu transaction command

On 03/22/2012 08:47 AM, Peter Krempa wrote: > On 03/17/2012 10:27 PM, Eric Blake wrote: >> The hardest part about adding transactions is not using the new >> monitor command, but undoing the partial changes we made prior >> to a failed transaction. >> >> +if (virSecurityManagerRestoreImageLabe

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

On Thu, Mar 22, 2012 at 04:30:55PM +0200, Gleb Natapov wrote: > On Thu, Mar 22, 2012 at 10:31:21AM -0300, Eduardo Habkost wrote: > > On Thu, Mar 22, 2012 at 11:32:44AM +0200, Gleb Natapov wrote: > > > What does this mean? Will -nodefconfig disable loading of bios.bin, > > > option roms, keymaps? >

Re: [libvirt] [PATCH] snapshot: improve qemu handling of reused snapshot targets

On 03/20/2012 03:29 PM, Eric Blake wrote: > The oVirt developers have stated that the real reasons they want > to have qemu reuse existing volumes when creating a snapshot are: > 1. the management framework is set up so that creation has to be > done from a central node for proper resource tracking

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

On 03/22/2012 04:32 AM, Gleb Natapov wrote: On Tue, Mar 13, 2012 at 11:53:19AM -0300, Eduardo Habkost wrote: So, trying to summarize what was discussed in the call: On Mon, Mar 12, 2012 at 10:08:10AM -0300, Eduardo Habkost wrote: Let's say we moved CPU definitions to /usr/share/qemu/cpu-models

Re: [libvirt] [PATCH 1/1] Clarify what documentation is being referenced

On 03/21/2012 10:07 PM, Dave Allan wrote: > virsh.pod had several instances in which it referred to "the > documentation" which was a little puzzling to me since it is > documentation. Reading the document from end to end makes it clear > that it means a specific URI which was noted previously in

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

On Thu, Mar 22, 2012 at 11:37:39AM -0500, Anthony Liguori wrote: > On 03/22/2012 04:32 AM, Gleb Natapov wrote: > >On Tue, Mar 13, 2012 at 11:53:19AM -0300, Eduardo Habkost wrote: > >>So, this problem is solved if the defaults are easily found on > >>/usr/share. > >> > >What problem is solved and wh

[libvirt] [libvirt PATCHv6 1/1] add DHCP snooping

This patch adds DHCP snooping support to libvirt. The learning method for IP addresses is specified by setting the "ip_learning" variable to one of "any" [default] (existing IP learning code), "none" (static only addresses) or "dhcp" (DHCP snooping). Active leases are saved in a lease file and rel

Re: [libvirt] Problem with Open vSwitch and dnsmasq

On Thu, Mar 22, 2012 at 6:10 AM, Daniele Milani wrote: > Dear all, > I have the following situation: > -I replaced the standard bridge driver with the Open VSwitch one; > -I started a NAT-network on Libvirt (bridge name virbr1); > -I started a Virtual Machine (VM1) on Libvirt, and I tagged his i

Re: [libvirt] Problem with Open vSwitch and dnsmasq

I think I could try the first solution. Can you explain me how do I create the port used by dnsmasq? For example, is it correct to execute # ovs-vsctl add-port virbr1 port2 tag=2 to create a port for the vLan whose tag is 2 named "port2"? Daniele Milani Date: Thu, 22 Mar 2012 10:54:21 -0700

Re: [libvirt] Problem with Open vSwitch and dnsmasq

On Thu, Mar 22, 2012 at 11:11 AM, Daniele Milani wrote: > I think I could try the first solution. Can you explain me how do I > create the port used by dnsmasq? > > For example, is it correct to execute > # ovs-vsctl add-port virbr1 port2 tag=2 > to create a port for the vLan whose tag is 2 named

Re: [libvirt] Problem with Open vSwitch and dnsmasq

On 03/22/2012 09:10 AM, Daniele Milani wrote: > Dear all, > I have the following situation: > -I replaced the standard bridge driver with the Open VSwitch one; I'm curious what you mean by this. libvirt's virtual networks currently only support the standard linux bridge device. There is no code i

Re: [libvirt] Problem with Open vSwitch and dnsmasq

(Cc'ing to libvirt-us...@redhat.com) On 03/22/2012 02:43 PM, Ansis Atteka wrote: > > > On Thu, Mar 22, 2012 at 11:11 AM, Daniele Milani > wrote: > > I think I could try the first solution. Can you explain me how do > I create the port used by dnsmasq? > > F

Re: [libvirt] [libvirt PATCHv6 1/1] add DHCP snooping

David Stevens/Beaverton/IBM@IBMUS wrote on 03/22/2012 01:27:10 PM: > > This patch adds DHCP snooping support to libvirt. The learning method for > IP addresses is specified by setting the "ip_learning" variable to one of > "any" [default] (existing IP learning code), "none" (static only addre

[libvirt] clarify freecell documentation

There were a couple of minor inaccuracies in the freecell manpage and virsh help. The first patch fixes the manpage and the second, to virsh.c, attempts to fix the help output. The virsh.c patch appears to produce the correct output, but is pure cargo cult programming, so it should be very caref

[libvirt] [PATCH 1/2] Clarify virsh freecell manpage entry

--- tools/virsh.pod | 23 ++- 1 files changed, 18 insertions(+), 5 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index f0df4fd..b4deae8 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -401,11 +401,24 @@ B list --title 0 Domain-0 running

Re: [libvirt] [Qemu-devel] Modern CPU models cannot be used with libvirt

On 03/22/2012 12:14 PM, Eduardo Habkost wrote: On Thu, Mar 22, 2012 at 11:37:39AM -0500, Anthony Liguori wrote: On 03/22/2012 04:32 AM, Gleb Natapov wrote: On Tue, Mar 13, 2012 at 11:53:19AM -0300, Eduardo Habkost wrote: So, this problem is solved if the defaults are easily found on /usr/share

[libvirt] [PATCH 2/2] Indicate freecell --cellno is optional

--- tools/virsh.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 9e5c9b2..d9cff0c 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -4742,7 +4742,7 @@ static const vshCmdInfo info_freecell[] = { }; static const vshCmdOptDef opts_fre

Re: [libvirt] [PATCH 2/2] Indicate freecell --cellno is optional

On 03/22/2012 01:59 PM, Dave Allan wrote: > --- > tools/virsh.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/virsh.c b/tools/virsh.c > index 9e5c9b2..d9cff0c 100644 > --- a/tools/virsh.c > +++ b/tools/virsh.c > @@ -4742,7 +4742,7 @@ static const vshCmdInfo

Re: [libvirt] [PATCH 1/1] Clarify what documentation is being referenced

On 03/22/2012 12:56 PM, Laine Stump wrote: > On 03/21/2012 10:07 PM, Dave Allan wrote: >> virsh.pod had several instances in which it referred to "the >> documentation" which was a little puzzling to me since it is >> documentation. Reading the document from end to end makes it clear >> that it me

Re: [libvirt] [PATCH 1/2] Clarify virsh freecell manpage entry

On 03/22/2012 01:59 PM, Dave Allan wrote: > --- > tools/virsh.pod | 23 ++- > 1 files changed, 18 insertions(+), 5 deletions(-) > > diff --git a/tools/virsh.pod b/tools/virsh.pod > index f0df4fd..b4deae8 100644 > --- a/tools/virsh.pod > +++ b/tools/virsh.pod > @@ -401,11 +40

Re: [libvirt] [libvirt PATCHv6 1/1] add DHCP snooping

Stefan Berger/Watson/IBM wrote on 03/22/2012 12:22:20 PM: > > I tried it. It doesn't apply more than one IP address. The code also > doesn't apply cleanly to the tip. > >Stefan Stefan, I did a git pull yesterday to which this patch is applied; here is the last entry before the patch

Re: [libvirt] [PATCH 1/2] Clarify virsh freecell manpage entry

On Thu, Mar 22, 2012 at 02:13:07PM -0600, Eric Blake wrote: > On 03/22/2012 01:59 PM, Dave Allan wrote: > > --- > > tools/virsh.pod | 23 ++- > > 1 files changed, 18 insertions(+), 5 deletions(-) > > > > diff --git a/tools/virsh.pod b/tools/virsh.pod > > index f0df4fd..b4dea

Re: [libvirt] [PATCH 2/2] Indicate freecell --cellno is optional

On Thu, Mar 22, 2012 at 02:10:30PM -0600, Eric Blake wrote: > On 03/22/2012 01:59 PM, Dave Allan wrote: > > --- > > tools/virsh.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/tools/virsh.c b/tools/virsh.c > > index 9e5c9b2..d9cff0c 100644 > > --- a/tools/vi

[libvirt] clarify freecell documentation v2

Modified per Eric's feedback: removed incorrect virsh help change, removed unnecessary examples in the manpage. I also fixed two instances in which I referred to nodes instead of cells. Dave -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 1/1] Clarify virsh freecell manpage entry

--- tools/virsh.pod | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index f0df4fd..a8bd739 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -401,11 +401,16 @@ B list --title 0 Domain-0 runningMailserv

Re: [libvirt] [libvirt PATCHv6 1/1] add DHCP snooping

David Stevens/Beaverton/IBM wrote on 03/22/2012 04:22:55 PM: > From: David Stevens/Beaverton/IBM > To: Stefan Berger/Watson/IBM > Cc: "Daniel P. Berrange" , libvir-list@redhat.com > Date: 03/22/2012 04:23 PM > Subject: Re: [libvirt PATCHv6 1/1] add DHCP snooping > > Stefan Berger/Watson/IBM wrote

Re: [libvirt] [libvirt PATCHv6 1/1] add DHCP snooping

Stefan Berger/Watson/IBM wrote on 03/22/2012 03:04:53 PM: > > I have some concerns about the cancelation of the thread. It can > hold the snoop lock and get cancelled while holding it. Next time > that lock is grabbed we will get a deadlock... > The snoop lock is acquired in virNWFilterDHCPSno

Re: [libvirt] [libvirt PATCHv6 1/1] add DHCP snooping

On 03/22/2012 04:49 PM, David Stevens wrote: > Stefan Berger/Watson/IBM wrote on 03/22/2012 03:04:53 PM: > >> >> I have some concerns about the cancelation of the thread. It can >> hold the snoop lock and get cancelled while holding it. Next time >> that lock is grabbed we will get a deadlock...

Re: [libvirt] [libvirt PATCHv6 1/1] add DHCP snooping

Eric Blake wrote on 03/22/2012 03:54:31 PM: > > pthread_cancel() tends to imply that you are properly managing signal > blocking across threads; we haven't used it anywhere else in libvirt, > and I'm extremely wary of pulling it in now, as there's probably a lot > of subtle bugs that it would ex

Re: [libvirt] [libvirt PATCHv6 1/1] add DHCP snooping

David Stevens/Beaverton/IBM wrote on 03/22/2012 07:26:06 PM: > From: David Stevens/Beaverton/IBM > To: Eric Blake > Cc: libvir-list@redhat.com, Stefan Berger/Watson/IBM@IBMUS > Date: 03/22/2012 07:26 PM > Subject: Re: [libvirt] [libvirt PATCHv6 1/1] add DHCP snooping > > Eric Blake wrote on 03/

Re: [libvirt] [libvirt PATCHv6 1/1] add DHCP snooping

Stefan Berger/Watson/IBM wrote on 03/22/2012 05:00:45 PM: > Maybe we should go with the previous code from a while ago which was > setting a flag for the thread to die. It caused other work-arounds > to become necessary but at least we don't have to deal with possibly > async. deaths of threads h

Re: [libvirt] [libvirt PATCHv6 1/1] add DHCP snooping

Eric Blake wrote on 03/22/2012 06:54:31 PM: > > On 03/22/2012 04:49 PM, David Stevens wrote: > > Stefan Berger/Watson/IBM wrote on 03/22/2012 03:04:53 PM: > > > >> > >> I have some concerns about the cancelation of the thread. It can > >> hold the snoop lock and get cancelled while holding it

Re: [libvirt] [libvirt PATCHv6 1/1] add DHCP snooping

David Stevens/Beaverton/IBM wrote on 03/22/2012 08:10:44 PM: > From: David Stevens/Beaverton/IBM > To: Stefan Berger/Watson/IBM > Cc: Eric Blake , libvir-list@redhat.com > Date: 03/22/2012 08:10 PM > Subject: Re: [libvirt] [libvirt PATCHv6 1/1] add DHCP snooping > > Stefan Berger/Watson/IBM wrote

Re: [libvirt] [libvirt PATCHv6 1/1] add DHCP snooping

Stefan Berger/Watson/IBM wrote on 03/22/2012 05:33:41 PM: > > Ok. > An idea may be that the threat has to 'find' its snoop request in a > global list every time it processes a packet. Once it cannot find it > anymore, it dies. Removing the request from the global list would be > the way to termi

[libvirt] [PATCH] libvirt:docs: fix typo

--- docs/formatdomain.html.in |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 4edada3..3a504a1 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2903,8 +2903,8 @@ qemu-kvm -net nic,mode

Re: [libvirt] [PATCH] libvirt:docs: fix typo

On 03/22/2012 08:40 PM, Zhou Peng wrote: Commit message could have mentioned the typo; it took me three reads to see what you changed. > --- > docs/formatdomain.html.in |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/docs/formatdomain.html.in b/docs/formatdomain

Re: [libvirt] [PATCH 1/1] Clarify virsh freecell manpage entry

On 03/22/2012 02:49 PM, Dave Allan wrote: > --- > tools/virsh.pod | 15 ++- > 1 files changed, 10 insertions(+), 5 deletions(-) > > diff --git a/tools/virsh.pod b/tools/virsh.pod > index f0df4fd..a8bd739 100644 > --- a/tools/virsh.pod > +++ b/tools/virsh.pod > @@ -401,11 +401,16 @@

Re: [libvirt] [PATCH 1/2] Cleanup for a return statement in source files

On 2012年03月22日 19:33, Martin Kletzander wrote: Return statements with parameter enclosed in parentheses were modified and parentheses were removed. The whole change was scripted, here is how: List of files was obtained using this command: git grep -l -e '\ Quite long, but looks good, ACK. -- l

[libvirt] [PATCH 4/6] snapshot: expose qemu commands for mirrored storage migration

A snapshot-based mirrored storage migration sequence requires both the 'drive-mirror' action in 'transaction' (present if the 'drive-mirror' standalone monitor command also exists) and the 'drive-reopen' monitor command (it would be nice if that were also part of a 'transaction', but the initial qe

[libvirt] [PATCH 5/6] snapshot: implement new snapshot delete flags in qemu

Delete a mirrored snapshot by picking which of the two files in the mirror to reopen. This is not atomic, so we update the snapshot in place as we iterate through each successful disk. Since we limited mirrored snapshots to transient domains, there is no persistent configuration to update. This

[libvirt] [PATCH 0/6] atomic snapshots, rounds 4 and 5

I was originally going to send this as two rounds, one for the XML additions of adding mirrors, and one for the flag addition to virDomainSnapshotDelete for mapping to drive-reopen; but it turned out that testing is easier if I finish the series. Note that this is minimally tested at the moment; I

[libvirt] [PATCH 1/6] snapshot: allow for creation of mirrored snapshots

This extends XML to add a new element under each of a disk snapshot: For now, if a is requested, the snapshot must be external, and assumes the same driver format (qcow2 or qed) as the . qemu allows more flexibility in mirror creation, which could possibly be added by further X

[libvirt] [PATCH 6/6] snapshot: enable mirrored snapshots on transient vm

The hardest part of this patch is figuring out how to provide proper security labeling and lock manager setup for the mirror, as well as rolling it all back on error. * src/qemu/qemu_driver.c (qemuDomainSnapshotCreateXML): Decide when mirrors are allowed. (qemuDomainSnapshotDiskPrepare): Prepare f

[libvirt] [PATCH 2/6] snapshot: add new snapshot delete flags

This completes the public API for using mirrored snapshots as a means of performing live storage migration. Of course, it will take additional patches to actually provide the implementation. The idea here is that oVirt can start with a domain with 'vda' open on /path1/to/old.qcow2 with a base fil

[libvirt] [PATCH 3/6] snapshot: make it possible to check for mirrored snapshot

For now, disk migration via mirroring is not implemented. But when we do implement it, we have to deal with the fact that qemu does not provide an easy way to re-start a qemu process with mirroring still intact (it _might_ be possible by using qemu -S then an initial 'drive-mirror' with disk reuse

[libvirt] [PATCH] Add qemu support for ppc64 on FC16 or above for rpm packaging

On Fedora16 or above, qemu is supported now. So it is added in rpm packaging. Signed-off-by: Li Zhang --- libvirt.spec.in |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 072fd8e..568a84f 100644 --- a/libvirt.spec.in +++ b/libvir

Re: [libvirt] [PATCH 2/2] Added syntax-check rule for return with parentheses

On 03/22/2012 07:33 PM, Martin Kletzander wrote: After cleanup introduced with previous commit, there is a need for syntax-check rule taking care of return(). Regexp used in 'prohibit' parameter is taken from the cleanup commit and modified so it fits 'grep -E' format. Semicolon at the end is nee