Re: [PATCH v1 2/3] perf cs-etm: Add callchain to instruction sample

On Fri, Aug 30, 2019 at 02:24:20PM +0800, Leo Yan wrote: > Firstly, this patch adds support for the thread stack; when every branch > packet is coming we will push or pop the stack based on the sample > flags. > > Secondly, based on the thread stack we can synthesize call chain for the > instructi

Re: "beyond 2038" warnings from loopback mount is noisy

Am 03.09.19 um 23:17 schrieb Theodore Y. Ts'o: > I know of a truly vast number of servers in production all over the > world which are using 128 byte inodes, and spamming the inodes at the > maximum rate limit is a really bad idea. This includes at some major > cloud data centers where the life

Re: "beyond 2038" warnings from loopback mount is noisy

On Tue, Sep 3, 2019 at 11:31 PM Deepa Dinamani wrote: > On Tue, Sep 3, 2019 at 2:18 PM Theodore Y. Ts'o wrote: > > On Tue, Sep 03, 2019 at 09:18:44AM -0700, Deepa Dinamani wrote: > > > > > > This prints a warning for each inode that doesn't extend limits beyond > > > 2038. It is rate limited by t

Re: [PATCH v4 3/4] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings

Quoting Jack Pham (2019-09-03 10:39:24) > On Mon, Sep 02, 2019 at 08:23:04AM +0200, Jorge Ramirez wrote: > > On 8/30/19 20:28, Stephen Boyd wrote: > > > Quoting Bjorn Andersson (2019-08-30 09:45:20) > > >> On Fri 30 Aug 09:01 PDT 2019, Stephen Boyd wrote: > > >> > > > > > > The USB-C connec

Re: [PATCH v2 15/27] drm/dp_mst: Cleanup drm_dp_send_link_address() a bit

On Wed, 4 Sep 2019 at 06:48, Lyude Paul wrote: > > Declare local pointer to the drm_dp_link_address_ack_reply struct > instead of constantly dereferencing it through the union in > txmsg->reply. Then, invert the order of conditionals so we don't have to > do the bulk of the work inside them, and c

Re: [PATCH] net/skbuff: silence warnings under memory pressure

On Tue, 2019-09-03 at 20:53 +0200, Michal Hocko wrote: > On Tue 03-09-19 11:42:22, Qian Cai wrote: > > On Tue, 2019-09-03 at 15:22 +0200, Michal Hocko wrote: > > > On Fri 30-08-19 18:15:22, Eric Dumazet wrote: > > > > If there is a risk of flooding the syslog, we should fix this > > > > generically

Re: Regression in 5.1.20: Reading long directory fails

Am Dienstag, 3. September 2019, 14:06:33 schrieb Jason L Tibbitts III: > > "WW" == Wolfgang Walter writes: > WW> What filesystem do you use on the server? xfs? > > Yeah, it's XFS. > > WW> If yes, does it use 64bit inodes (or started to use them)? > > These filesystems aren't super old, and

Re: [PATCH v2 1/2] dt-bindings: phy: intel-sdxc-phy: Add YAML schema for LGM SDXC PHY

On Tue, Sep 3, 2019 at 11:52 AM Ramuthevar, Vadivel MuruganX wrote: > > Hi Rob, > > Thank you for your suggestions and clarifications. > > On 3/9/2019 6:34 PM, Rob Herring wrote: > > On Tue, Sep 3, 2019 at 11:08 AM Ramuthevar, Vadivel MuruganX > > wrote: > >> Hi Rob, > >> > >>Thank you so

Re: [RFC PATCH 0/3] x86/mm/tlb: Defer TLB flushes with PTI

On Thu, Aug 29, 2019 at 10:24 AM Nadav Amit wrote: > > > On Aug 27, 2019, at 5:30 PM, Andy Lutomirski wrote: > > > > On Tue, Aug 27, 2019 at 4:52 PM Nadav Amit wrote: > >>> On Aug 27, 2019, at 4:18 PM, Andy Lutomirski wrote: > >>> > >>> On Fri, Aug 23, 2019 at 11:07 PM Nadav Amit wrote: >

Re: [PATCH 2/3] task: RCU protect tasks on the runqueue

On Tue, Sep 03, 2019 at 10:06:03PM +0200, Peter Zijlstra wrote: > On Tue, Sep 03, 2019 at 12:18:47PM -0700, Linus Torvalds wrote: > > Now, if you can point to some particular field where that ordering > > makes sense for the particular case of "make it active on the > > runqueue" vs "look up the ta

Re: "beyond 2038" warnings from loopback mount is noisy

On Tue, Sep 3, 2019 at 2:18 PM Theodore Y. Ts'o wrote: > > On Tue, Sep 03, 2019 at 09:18:44AM -0700, Deepa Dinamani wrote: > > > > This prints a warning for each inode that doesn't extend limits beyond > > 2038. It is rate limited by the ext4_warning_inode(). > > Looks like your filesystem has ino

Re: "fs/namei.c: keep track of nd->root refcount status" causes boot panic

On Tue, Sep 03, 2019 at 06:50:24AM -0700, Christoph Hellwig wrote: > On Tue, Sep 03, 2019 at 02:48:32PM +0100, Al Viro wrote: > > Not sure what would be the best way to do it... I don't mind breaking > > the out-of-tree modules, whatever their license is; what I would rather > > avoid is _quiet_ b

Re: [PATCH v2] mm/hugetlb: avoid looping to the same hugepage if !pages and !vmas

On 8/29/19 6:50 AM, Zhigang Lu wrote: > From: Zhigang Lu > > When mmapping an existing hugetlbfs file with MAP_POPULATE, we find > it is very time consuming. For example, mmapping a 128GB file takes > about 50 milliseconds. Sampling with perfevent shows it spends 99% > time in the same_page loop

Re: [PATCH] net: sched: taprio: Fix potential integer overflow in taprio_set_picos_per_byte

Hi, Vladimir Oltean writes: > Right. And while we're at it, there's still the potential > division-by-zero problem which I still don't know how to solve without > implementing a full-blown __ethtool_get_link_ksettings parser that > checks against all the possible outputs it can have under the "n

Re: [PATCH] mailmap: Update email address for Quentin Perret

On Tue, 2019-09-03 at 15:59 +0100, Will Deacon wrote: > What's the best way > for get_maintainer.pl to retrieve up-to-date contact details for developers > who aren't in MAINTAINERS? Updated .mailmap entries.

Re: "beyond 2038" warnings from loopback mount is noisy

On Tue, Sep 03, 2019 at 09:18:44AM -0700, Deepa Dinamani wrote: > > This prints a warning for each inode that doesn't extend limits beyond > 2038. It is rate limited by the ext4_warning_inode(). > Looks like your filesystem has inodes that cannot be extended. > We could use a different rate limit

Re: [PATCH RESEND] fs/epoll: fix the edge-triggered mode for nested epoll

On 9/2/19 11:36 AM, Roman Penyaev wrote: > Hi, > > This is indeed a bug. (quick side note: could you please remove efd[1] > from your test, because it is not related to the reproduction of a > current bug). > > Your patch lacks a good description, what exactly you've fixed.  Let > me speak out

Re: "beyond 2038" warnings from loopback mount is noisy

On Tue, 2019-09-03 at 21:50 +0200, Arnd Bergmann wrote: > On Tue, Sep 3, 2019 at 9:39 PM Andreas Dilger wrote: > > > > On Sep 3, 2019, at 12:15 PM, Qian Cai wrote: > > > > > > On Tue, 2019-09-03 at 09:36 -0700, Deepa Dinamani wrote: > > > > We might also want to consider updating the file syste

Re: KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device

Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device usb 6-1: Using ep0 maxpacket: 16 usb 6-1: BOS total length 54, descriptor 168 usb 6-1: Old BOS 8881cd814f60 Len 0xa8 usb 6-1: New BOS 88

Re: [PATCH v2 1/3] fuse: on 64-bit store time in d_fsdata directly

On Thu, Aug 22, 2019 at 1:00 PM Khazhismel Kumykov wrote: > > Implements the optimization noted in f75fdf22b0a8 ("fuse: don't use > ->d_time"), as the additional memory can be significant. (In particular, > on SLAB configurations this 8-byte alloc becomes 32 bytes). Per-dentry, > this can consume

[PATCH v2] staging: exfat: cleanup explicit comparisons to NULL

Fixes checkpatch.pl warnings: CHECK: Comparison to NULL could be written "expr" CHECK: Comparison to NULL could be written "!expr" Signed-off-by: Valentin Vidic --- v2: fix gcc warning in strsep call drivers/staging/exfat/exfat_core.c | 34 - drivers/staging/exfat/exfat_su

Re: [PATCH v2 3/8] mips: compat: vdso: Use legacy syscalls as fallback

Hello, Vincenzo Frascino wrote: > The generic VDSO implementation uses the Y2038 safe clock_gettime64() and > clock_getres_time64() syscalls as fallback for 32bit VDSO. This breaks > seccomp setups because these syscalls might be not (yet) allowed. > > Implement the 32bit variants which use the l

Re: KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device

On Tue, 3 Sep 2019, syzbot wrote: > Hello, > > syzbot has tested the proposed patch but the reproducer still triggered > crash: > KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device > > usb 4-1: Using ep0 maxpacket: 16 > usb 4-1: Old BOS 8881d516b780 Len 0xa8 > usb 4-1: New BOS

Re: [PATCH] Smack: Move request_buffer from stack to smack_audit_data

On 9/3/2019 11:01 AM, Denis Efremov wrote: > request_buffer is required to describe an access type in a string for > the audit. The problem here is that the string is saved on the stack > and then passed by reference to the next function in request field of > the smack_audit_data structure. Referen

Re: [RFC PATCH 1/2] Fix: sched/membarrier: p->mm->membarrier_state racy load

- On Sep 3, 2019, at 4:27 PM, Linus Torvalds torva...@linux-foundation.org wrote: > On Tue, Sep 3, 2019 at 1:11 PM Mathieu Desnoyers > wrote: >> >> + cpus_read_lock(); >> + for_each_online_cpu(cpu) { > > This would likely be better off using mm_cpumask(mm) instead of all > onlin

Re: [PATCH v2 2/2] mm, sl[aou]b: guarantee natural alignment for kmalloc(power-of-two)

On Tue, Sep 03, 2019 at 08:13:45PM +, Christopher Lameter wrote: > On Sat, 31 Aug 2019, Matthew Wilcox wrote: > > > > The current behavior without special alignment for these caches has been > > > in the wild for over a decade. And this is now coming up? > > > > In the wild ... and rarely enab

Re: [PATCH 09/10] drm/msm/dpu: async commit support

On Thu, Aug 29, 2019 at 09:45:17AM -0700, Rob Clark wrote: > From: Rob Clark > > In addition, moving to kms->flush_commit() lets us drop the only user > of kms->commit(). > > Signed-off-by: Rob Clark Reviewed-by: Sean Paul > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 13 -- > d

Re: [RFC PATCH] mm, oom: disable dump_tasks by default

On 2019/09/03 23:45, Michal Hocko wrote: > It's primary purpose is > to help analyse oom victim selection decision. I disagree, for I use the process list for understanding what / how many processes are consuming what kind of memory (without crashing the system) for anomaly detection purpose. Alth

Re: [RFC PATCH 1/2] Fix: sched/membarrier: p->mm->membarrier_state racy load

- On Sep 3, 2019, at 4:24 PM, Peter Zijlstra pet...@infradead.org wrote: > On Tue, Sep 03, 2019 at 04:11:34PM -0400, Mathieu Desnoyers wrote: > >> diff --git a/include/linux/sched.h b/include/linux/sched.h >> index 9f51932bd543..e24d52a4c37a 100644 >> --- a/include/linux/sched.h >> +++ b/incl

Re: [RFC PATCH 1/2] Fix: sched/membarrier: p->mm->membarrier_state racy load

On Tue, Sep 3, 2019 at 1:25 PM Peter Zijlstra wrote: > > Why can't we frob this state into a line/word we already have to > unconditionally touch, like the thread_info::flags word for example. I agree, but we don't have any easily used flags left, I think. But yes, it would be better to not have

Re: [PATCH 07/10] drm/msm: split power control from prepare/complete_commit

On Thu, Aug 29, 2019 at 09:45:15AM -0700, Rob Clark wrote: > From: Rob Clark > > With atomic commit, ->prepare_commit() and ->complete_commit() may not > be evenly balanced (although ->complete_commit() will complete each > crtc that had been previously prepared). So these will no longer be > a

[PATCH v2 08/26] nfs: stash nfs_subversion reference into nfs_mount_info

From: Al Viro That will allow to get rid of passing those references around in quite a few places. Moreover, that will allow to merge xdev and remote file_system_type. Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/internal.h | 1 + fs/nfs/namespace.c | 6 +++--- fs/nfs/nfs4su

[PATCH v2 03/26] nfs: lift setting mount_info from nfs4_remote{,_referral}_mount

From: Al Viro Do that (fhandle allocation, setting struct server up) in nfs4_referral_mount() and nfs4_try_mount() resp. and pass the server and pointer to mount_info into nfs_do_root_mount() so that nfs4_remote_referral_mount()/nfs_remote_mount() could be merged. Since we are moving stuff from

[PATCH v2 02/26] nfs: stash server into struct nfs_mount_info

From: Al Viro Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/internal.h | 3 ++- fs/nfs/nfs4super.c | 10 -- fs/nfs/super.c | 19 --- 3 files changed, 14 insertions(+), 18 deletions(-) diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h index a2346a2

[PATCH v2 06/26] nfs4: fold nfs_do_root_mount/nfs_follow_remote_path

From: Al Viro Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/nfs4super.c | 88 +++--- 1 file changed, 37 insertions(+), 51 deletions(-) diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c index a0b66f98f6ba..91ba1b6741dc 100644 --- a/fs/n

[PATCH v2 12/26] nfs: don't pass nfs_subversion to ->create_server()

From: Al Viro pick it from mount_info Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/client.c | 4 ++-- fs/nfs/internal.h | 7 ++- fs/nfs/nfs3_fs.h| 2 +- fs/nfs/nfs3client.c | 5 ++--- fs/nfs/nfs4client.c | 3 +-- fs/nfs/nfs4super.c |

Re: [PATCH] drm: bridge/dw_hdmi: add audio sample channel status setting

On 2019-09-03 20:08, Jernej Škrabec wrote: > Hi! > > Dne torek, 03. september 2019 ob 20:00:33 CEST je Neil Armstrong napisal(a): >> Hi, >> >> Le 03/09/2019 à 11:53, Neil Armstrong a écrit : >>> Hi, >>> >>> On 03/09/2019 07:51, Cheng-Yi Chiang wrote: From: Yakir Yang When transmitti

[PATCH v2 10/26] nfs: merge xdev and remote file_system_type

From: Al Viro they are identical now... Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/internal.h | 2 +- fs/nfs/namespace.c | 2 +- fs/nfs/nfs4super.c | 22 +- fs/nfs/super.c | 14 -- 4 files changed, 11 insertions(+), 29 deletions(-) dif

[PATCH v2 05/26] nfs: don't bother setting/restoring export_path around do_nfs_root_mount()

From: Al Viro nothing in it will be looking at that thing anyway Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/nfs4super.c | 4 1 file changed, 4 deletions(-) diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c index d0237d8ffa2b..a0b66f98f6ba 100644 --- a/fs/nfs/nfs4sup

[PATCH v2 07/26] nfs: lift setting mount_info from nfs_xdev_mount()

From: Al Viro Do it in nfs_do_submount() instead. As a side benefit, nfs_clone_data doesn't need ->fh and ->fattr anymore. Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/internal.h | 3 +-- fs/nfs/namespace.c | 35 +-- fs/nfs/super.c | 25 +

[PATCH v2 15/26] nfs: get rid of ->set_security()

From: Al Viro it's always either nfs_set_sb_security() or nfs_clone_sb_security(), the choice being controlled by mount_info->cloned != NULL. No need to add methods, especially when both instances live right next to the caller and are never accessed anywhere else. Reviewed-by: David Howells Si

[PATCH v2 17/26] NFS: Constify mount argument match tables

From: David Howells The mount argument match tables should never be altered so constify them. Signed-off-by: David Howells Signed-off-by: Al Viro --- fs/nfs/fs_context.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/nfs/fs_context.c b/fs/nfs/fs_context.c index 8

[PATCH v2 09/26] nfs: don't bother passing nfs_subversion to ->try_mount() and nfs_fs_mount_common()

From: Al Viro Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/internal.h | 6 ++ fs/nfs/nfs4_fs.h| 2 +- fs/nfs/nfs4super.c | 5 ++--- fs/nfs/super.c | 19 --- include/linux/nfs_xdr.h | 3 +-- 5 files changed, 14 insertions(+), 2

[PATCH v2 22/26] NFS: Do some tidying of the parsing code

From: David Howells Do some tidying of the parsing code, including: (*) Returning 0/error rather than true/false. (*) Putting the nfs_fs_context pointer first in some arg lists. (*) Unwrap some lines that will now fit on one line. (*) Provide unioned sockaddr/sockaddr_storage fields to av

[PATCH v2 20/26] NFS: Deindent nfs_fs_context_parse_option()

From: David Howells Deindent nfs_fs_context_parse_option(). Signed-off-by: David Howells Signed-off-by: Al Viro --- fs/nfs/fs_context.c | 739 ++-- 1 file changed, 367 insertions(+), 372 deletions(-) diff --git a/fs/nfs/fs_context.c b/fs/nfs/fs_context

[PATCH v2 16/26] NFS: Move mount parameterisation bits into their own file

From: David Howells Split various bits relating to mount parameterisation out from fs/nfs/super.c into their own file to form the basis of filesystem context handling for NFS. No other changes are made to the code beyond removing 'static' qualifiers. Signed-off-by: David Howells Signed-off-by:

[PATCH v2 04/26] nfs: fold nfs4_remote_fs_type and nfs4_remote_referral_fs_type

From: Al Viro They are identical now. Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/nfs4super.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c index 773c347df3ab..d0237d8ffa2b 100644 --- a/

[PATCH v2 23/26] NFS: rename nfs_fs_context pointer arg in a few functions

Split out from commit "NFS: Add fs_context support." Rename cfg to ctx in nfs_init_server(), nfs_verify_authflavors(), and nfs_request_mount(). No functional changes. Signed-off-by: Scott Mayhew --- fs/nfs/client.c | 62 - fs/nfs/super.c | 54 ++

[PATCH v2 00/26] nfs: Mount API conversion

Hi Trond, Anna, Here's a set of patches that converts NFS to use the mount API. Note that there are a lot of preliminary patches, some from David and some from Al. The final patch (the one that does the actual conversion) from the David's initial posting has been split into 4 separate patches, an

[PATCH v2 19/26] NFS: Split nfs_parse_mount_options()

From: David Howells Split nfs_parse_mount_options() to move the prologue, list-splitting and epilogue into one function and the per-option processing into another. Signed-off-by: David Howells Signed-off-by: Al Viro --- fs/nfs/fs_context.c | 126 f

[PATCH v2 25/26] NFS: Add fs_context support.

From: David Howells Add filesystem context support to NFS, parsing the options in advance and attaching the information to struct nfs_fs_context. The highlights are: (*) Merge nfs_mount_info and nfs_clone_mount into nfs_fs_context. This structure represents NFS's superblock config. (*)

[PATCH v2 11/26] nfs: unexport nfs_fs_mount_common()

From: Al Viro Make it static, even. And remove a stale extern of (long-gone) nfs_xdev_mount_common() from internal.h, while we are at it. Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/internal.h | 3 --- fs/nfs/super.c| 5 +++-- 2 files changed, 3 insertions(+), 5 deletion

[PATCH v2 21/26] NFS: Add a small buffer in nfs_fs_context to avoid string dup

From: David Howells Add a small buffer in nfs_fs_context to avoid string duplication when parsing numbers. Also make the parsing function wrapper place the parsed integer directly in the appropriate nfs_fs_context struct member. Signed-off-by: David Howells Signed-off-by: Al Viro --- fs/nfs/

[PATCH v2 24/26] NFS: Convert mount option parsing to use functionality from fs_parser.h

Split out from commit "NFS: Add fs_context support." Convert existing mount option definitions to fs_parameter_enum's and fs_parameter_spec's. Parse mount options using fs_parse() and lookup_constant(). Notes: 1) Fixed a typo in the udp6 definition in nfs_xprt_protocol_tokens from the original

[PATCH v2 14/26] nfs_clone_sb_security(): simplify the check for server bogosity

From: Al Viro We used to check ->i_op for being nfs_dir_inode_operations. With separate inode_operations for v3 and v4 that became bogus, but rather than going for protocol-dependent comparison we could've just checked ->i_fop instead; _that_ is the same for all protocol versions. Reviewed-by:

[PATCH v2 26/26] NFS: Attach supplementary error information to fs_context.

Split out from commit "NFS: Add fs_context support." Add wrappers nfs_errorf(), nfs_invalf(), and nfs_warnf() which log error information to the fs_context. Convert some printk's to use these new wrappers instead. Signed-off-by: Scott Mayhew --- fs/nfs/fs_context.c | 105 +++---

[PATCH v2 13/26] nfs: get rid of mount_info ->fill_super()

From: Al Viro The only possible values are nfs_fill_super and nfs_clone_super. The latter is used only when crossing into a submount and it is almost identical to the former; the only differences are * ->s_time_gran unconditionally set to 1 (even for v2 mounts). Regression dating back to

[PATCH v2 01/26] saner calling conventions for nfs_fs_mount_common()

From: Al Viro Allow it to take ERR_PTR() for server and return ERR_CAST() of it in such case. All callers used to open-code that... Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/nfs4super.c | 16 +--- fs/nfs/super.c | 11 --- 2 files changed, 5 insertio

[PATCH v2 18/26] NFS: Rename struct nfs_parsed_mount_data to struct nfs_fs_context

From: David Howells Rename struct nfs_parsed_mount_data to struct nfs_fs_context and rename pointers to it to "ctx". At some point this will be pointed to by an fs_context struct's fs_private pointer. Signed-off-by: David Howells Signed-off-by: Al Viro --- fs/nfs/client.c | 66 +++

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

Hi! > > Also, you all didn't document the heck out of this. So no, I really do > > not want to see this patch accepted as-is. > > > > > Provided that will be fixed, can we count on your ack for the > > > implementation of the solution you proposed? :-) > > > > Let's see the patch that actually im

Re: [PATCH 09/15] sched,fair: refactor enqueue/dequeue_entity

On Tue, 2019-09-03 at 17:38 +0200, Vincent Guittot wrote: > Hi Rik, > > On Thu, 22 Aug 2019 at 04:18, Rik van Riel wrote: > > Refactor enqueue_entity, dequeue_entity, and update_load_avg, in > > order > > to split out the things we still want to happen at every level in > > the > > cgroup hierarc

Re: [PATCH] drm/virtio: Use vmalloc for command buffer allocations.

On Sun, Sep 1, 2019 at 10:28 PM Gerd Hoffmann wrote: > > On Fri, Aug 30, 2019 at 10:49:25AM -0700, David Riley wrote: > > Hi Gerd, > > > > On Fri, Aug 30, 2019 at 4:16 AM Gerd Hoffmann wrote: > > > > > > Hi, > > > > > > > > > - kfree(vbuf->data_buf); > > > > > > + kvfree(vbuf->data_buf)

Re: [RFC PATCH 1/2] Fix: sched/membarrier: p->mm->membarrier_state racy load

On Tue, Sep 3, 2019 at 1:11 PM Mathieu Desnoyers wrote: > > + cpus_read_lock(); > + for_each_online_cpu(cpu) { This would likely be better off using mm_cpumask(mm) instead of all online CPU's. Plus doing the rcu_read_lock() inside the loop seems pointless. Even with a lot of cores, i

Re: [RFC PATCH 1/2] Fix: sched/membarrier: p->mm->membarrier_state racy load

On Tue, Sep 03, 2019 at 04:11:34PM -0400, Mathieu Desnoyers wrote: > diff --git a/include/linux/sched.h b/include/linux/sched.h > index 9f51932bd543..e24d52a4c37a 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -1130,6 +1130,10 @@ struct task_struct { > unsigned long

Re: [PATCH v2 3/6] powerpc: Convert flush_icache_range & friends to C

On Tue, Sep 03, 2019 at 01:31:57PM -0500, Segher Boessenkool wrote: > On Tue, Sep 03, 2019 at 07:05:19PM +0200, Christophe Leroy wrote: > > Le 03/09/2019 à 18:04, Segher Boessenkool a écrit : > > >(Why are they separate though? It could just be one loop var). > > > > Yes it could just be a single

[PATCH v3 8/9] media: ov6650: Fix stored frame format not in sync with hardware

The driver stores frame format settings supposed to be in line with hardware state in a device private structure. Since the driver initial submission, those settings are updated before they are actually applied on hardware. If an error occurs on device update, the stored settings my not reflect h

[PATCH v3 3/9] media: ov6650: Fix crop rectangle alignment not passed back

Commit 4f996594ceaf ("[media] v4l2: make vidioc_s_crop const") introduced a writable copy of constified user requested crop rectangle in order to be able to perform hardware alignments on it. Later on, commit 10d5509c8d50 ("[media] v4l2: remove g/s_crop from video ops") replaced s_crop() video ope

[PATCH v3 2/9] media: ov6650: Fix control handler not freed on init error

Since commit afd9690c72c3 ("[media] ov6650: convert to the control framework"), if an error occurs during initialization of a control handler, resources possibly allocated to the handler are not freed before device initialiaton is aborted. Fix it. Fixes: afd9690c72c3 ("[media] ov6650: convert to

Re: [PATCH v2 2/2] mm, sl[aou]b: guarantee natural alignment for kmalloc(power-of-two)

On Sat, 31 Aug 2019, Matthew Wilcox wrote: > > The current behavior without special alignment for these caches has been > > in the wild for over a decade. And this is now coming up? > > In the wild ... and rarely enabled. When it is enabled, it may or may > not be noticed as data corruption, or t

[PATCH v3 6/9] media: ov6650: Fix .get_fmt() V4L2_SUBDEV_FORMAT_TRY support

Commit da298c6d98d5 ("[media] v4l2: replace video op g_mbus_fmt by pad op get_fmt") converted a former ov6650_g_fmt() video operation callback to an ov6650_get_fmt() pad operation callback. However, the converted function disregards a format->which flag that pad operations should obey and always r

[PATCH v3 4/9] media: ov6650: Fix incorrect use of JPEG colorspace

Since its initial submission, the driver selects V4L2_COLORSPACE_JPEG for supported formats other than V4L2_MBUS_FMT_SBGGR8_1X8. According to v4l2-compliance test program, V4L2_COLORSPACE_JPEG applies exclusively to V4L2_PIX_FMT_JPEG. Since the sensor does not support JPEG format, fix it to alway

[PATCH v3 5/9] media: ov6650: Fix some format attributes not under control

User arguments passed to .get/set_fmt() pad operation callbacks may contain unsupported values. The driver takes control over frame size and pixel code as well as colorspace and field attributes but has never cared for remainig format attributes, i.e., ycbcr_enc, quantization and xfer_func, introd

[PATCH v3 7/9] media: ov6650: Fix default format not applied on device probe

It is not clear what pixel format is actually configured in hardware on reset. MEDIA_BUS_FMT_YUYV8_2X8, assumed on device probe since the driver was intiially submitted, is for sure not the one. Fix it by explicitly applying a known, driver default frame format just after initial device reset. F

[PATCH v3 0/9] media: ov6650: A collection of fixes

Janusz Krzysztofik (9): media: ov6650: Fix MODULE_DESCRIPTION media: ov6650: Fix control handler not freed on init error media: ov6650: Fix crop rectangle alignment not passed back media: ov6650: Fix incorrect use of JPEG colorspace media: ov6650: Fix some format attributes not under cont

[PATCH v3 1/9] media: ov6650: Fix MODULE_DESCRIPTION

Commit 23a52386fabe ("media: ov6650: convert to standalone v4l2 subdevice") converted the driver from a soc_camera sensor to a standalone V4L subdevice driver. Unfortunately, module description was not updated to reflect the change. Fix it. While being at it, update email address of the module a

Re: [RFC PATCH 2/3] Fix: sched/membarrier: READ_ONCE p->mm in membarrier_global_expedited

- On Sep 3, 2019, at 12:23 PM, Linus Torvalds torva...@linux-foundation.org wrote: > On Tue, Sep 3, 2019 at 9:00 AM Mathieu Desnoyers > wrote: >> >> Due to the lack of READ_ONCE() on p->mm, this code can in fact turn into >> a NULL deref when we hit do_exit() around exit_mm(). The first p->m

Re: [PATCH 03/12] media: hantro: Fix H264 motion vector buffer offset

On 2019-09-03 12:58, Philipp Zabel wrote: > Hi Jonas, > > On Sun, 2019-09-01 at 12:45 +, Jonas Karlman wrote: >> A decoded 8-bit 4:2:0 frame need memory for up to 448 macroblocks >> and is laid out in memory as follow: > Do you mean "A decoded 8-bit 4:2:0 frame needs up to 448 bytes per > macro

[PATCH v3 9/9] media: ov6650: Fix stored crop rectangle not in sync with hardware

The driver stores crop rectangle settings supposed to be in line with hardware state in a device private structure. Since the driver initial submission, crop rectangle width and height settings are not updated correctly when rectangle offset settings are applied on hardware. If an error occurs wh

[RFC PATCH 2/2] Fix: sched/membarrier: private expedited registration check

Fix a logic flaw in the way membarrier_register_private_expedited() handles ready state checks for private expedited sync core and private expedited registrations. If a private expedited membarrier registration is first performed, and then a private expedited sync_core registration is performed, t

[RFC PATCH 1/2] Fix: sched/membarrier: p->mm->membarrier_state racy load

The membarrier_state field is located within the mm_struct, which is not guaranteed to exist when used from runqueue-lock-free iteration on runqueues by the membarrier system call. Copy the membarrier_state from the mm_struct into the next task_struct in the scheduler prepare task switch. Upon mem

Re: [PATCH] staging: exfat: cleanup explicit comparisons to NULL

On Tue, Sep 03, 2019 at 07:13:37PM +0200, Valentin Vidic wrote: > Fixes checkpatch.pl warnings: > > CHECK: Comparison to NULL could be written "expr" > CHECK: Comparison to NULL could be written "!expr" > > Signed-off-by: Valentin Vidic > --- > drivers/staging/exfat/exfat_core.c | 34 +

[PATCH v2] mm: emit tracepoint when RSS changes by threshold

Useful to track how RSS is changing per TGID to detect spikes in RSS and memory hogs. Several Android teams have been using this patch in various kernel trees for half a year now. Many reported to me it is really useful so I'm posting it upstream. Initial patch developed by Tim Murray. Changes I m

Re: [PATCH] net/mlx5: Use PTR_ERR_OR_ZERO rather than its implementation

On Tue, 2019-09-03 at 14:56 +0800, zhong jiang wrote: > PTR_ERR_OR_ZERO contains if(IS_ERR(...)) + PTR_ERR. It is better > to use it directly. hence just replace it. > > Signed-off-by: zhong jiang > --- > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 5 + > 1 file changed, 1 insertion(+)

Re: [PATCH 1/5] rcu/rcuperf: Add kfree_rcu() performance Tests

On Thu, Aug 29, 2019 at 04:56:37PM -0400, Joel Fernandes wrote: > On Wed, Aug 28, 2019 at 02:12:26PM -0700, Paul E. McKenney wrote: [ . . . ] > > > +static int > > > +kfree_perf_thread(void *arg) > > > +{ > > > + int i, loop = 0; > > > + long me = (long)arg; > > > + struct kfree_obj *alloc_ptr; >

Re: [PATCH 2/3] task: RCU protect tasks on the runqueue

On Tue, Sep 03, 2019 at 12:18:47PM -0700, Linus Torvalds wrote: > Now, if you can point to some particular field where that ordering > makes sense for the particular case of "make it active on the > runqueue" vs "look up the task from the runqueue using RCU", then I do > think that the whole releas

[PATCH] mm: emit tracepoint when RSS changes by threshold

Useful to track how RSS is changing per TGID. Several Android teams have been using this patch in various kernel trees for half a year now. Many reported to me it is really useful. Initial patch developed by Tim Murray. Changes I made from original patch: o Prevent any additional space consumed by

Re: [PATCH -rcu dev 2/2] rcu/dyntick-idle: Add better tracing

On Fri, Aug 30, 2019 at 12:23:48PM -0400, Joel Fernandes (Google) wrote: > The dyntick-idle traces are a bit confusing. This patch makes it simpler > and adds some missing cases such as EQS-enter due to user vs idle mode. > > Following are the changes: > (1) Add a new context field to trace_rcu_dy

Re: [PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter")

On Fri, Aug 30, 2019 at 12:23:47PM -0400, Joel Fernandes (Google) wrote: > This code is unused and can be removed now. Revert was straightforward. > > Tested with light rcutorture. > > Link: > http://lore.kernel.org/r/CALCETrWNPOOdTrFabTDd=h7+wc6xj9rjceg6ol1s0rtv5pf...@mail.gmail.com > Suggested

Re: [GIT PULL] Please pull FPGA Manager changes for 5.4

On Sat, Aug 31, 2019 at 01:45:28PM -0700, Moritz Fischer wrote: > The following changes since commit 2949dc443116a66fd1a92d9ef107be16cdd197cd: > > dt-bindings: fpga: Consolidate bridge properties (2019-07-24 14:19:15 -0700) > > are available in the Git repository at: > > git://git.kernel.org

Re: KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device

Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: KASAN: slab-out-of-bounds Read in usb_reset_and_verify_device usb 4-1: Using ep0 maxpacket: 16 usb 4-1: Old BOS 8881d516b780 Len 0xa8 usb 4-1: New BOS 8881d5dd6d20 Len 0xa8

Re: [GIT PULL] Thunderbolt changes for v5.4

On Sat, Aug 31, 2019 at 04:56:16PM +0300, Mika Westerberg wrote: > Hi Greg, > > The following changes since commit e21a712a9685488f5ce80495b37b9fdbe96c230d: > > Linux 5.3-rc3 (2019-08-04 18:40:12 -0700) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kerne

Re: [GIT PULL] PHY: For 5.4

On Tue, Aug 27, 2019 at 08:21:46PM +0530, Kishon Vijay Abraham I wrote: > Hi Greg, > > Please find the pull request for 5.4 merge window below. Most of the > updates here are in Marvell's Armada CP110 COMPHY. It also adds a new > PHY driver for Lantiq (now Intel) VRX200/ARX300 PCIe PHY. Please see

Re: [PATCH] unicode: Move static keyword to the front of declarations

Krzysztof Wilczynski writes: > Move the static keyword to the front of declarations of nfdi_test_data > and nfdicf_test_data, and resolve the following compiler warnings that > can be seen when building with warnings enabled (W=1): > > fs/unicode/utf8-selftest.c:38:1: warning: > ‘static’ is not

Re: [PATCH v2 3/4] drm/ttm, drm/vmwgfx: Correctly support support AMD memory encryption

On Tue, Sep 3, 2019 at 9:38 PM Dave Hansen wrote: > > This whole thing looks like a fascinating collection of hacks. :) > > ttm is taking a stack-alllocated "VMA" and handing it to vmf_insert_*() > which obviously are expecting "real" VMAs that are linked into the mm. > It's extracting some pgprot

Re: "beyond 2038" warnings from loopback mount is noisy

On Tue, Sep 3, 2019 at 9:39 PM Andreas Dilger wrote: > > On Sep 3, 2019, at 12:15 PM, Qian Cai wrote: > > > > On Tue, 2019-09-03 at 09:36 -0700, Deepa Dinamani wrote: > >> We might also want to consider updating the file system the LTP is > >> being run on here. > > > > It simply format (mkfs.ext

Re: [GIT PULL] interconnect changes for 5.4

On Fri, Aug 23, 2019 at 06:14:19PM +0300, Georgi Djakov wrote: > Hi Greg, > > This is a pull request with interconnect patches for the 5.4 merge window. > The patches have been for a while in linux-next without reported issues. The > details are in the signed tag. Please consider pulling into char

Re: [RFC 08/12] media: hantro: Fix H264 decoding of field encoded content

On 2019-09-03 17:01, Philipp Zabel wrote: > On Tue, 2019-09-03 at 14:02 +, Jonas Karlman wrote: >> On 2019-09-03 15:21, Philipp Zabel wrote: >>> On Sun, 2019-09-01 at 12:45 +, Jonas Karlman wrote: This need code cleanup and formatting Signed-off-by: Jonas Karlman >>> The pre

Re: [GIT PULL] extcon next for v5.4

On Mon, Aug 26, 2019 at 11:55:13AM +0900, Chanwoo Choi wrote: > Dear Greg, > > This is extcon-next pull request for v5.4. I add detailed description of > this pull request on below. Please pull extcon with following updates. > > > Detailed description for this pull request: > 1. Clean up the and

Re: [PATCH 0/3] task: Making tasks on the runqueue rcu protected

On Tue, Sep 03, 2019 at 08:44:40AM -0700, Linus Torvalds wrote: > That said, it won't affect any of the core architectures much, because > smp_store_release() isn't that expensive (it's just a compiler barrier > on x86, it's a cheap instruction on arm64, and it should be very cheap > on any other

Re: [PATCH AUTOSEL 4.19 066/167] iio: adc: exynos-adc: Add S5PV210 variant

On Tue, Sep 03, 2019 at 06:53:28PM +0100, Jonathan Cameron wrote: On Tue, 3 Sep 2019 12:23:38 -0400 Sasha Levin wrote: From: Jonathan Bakker [ Upstream commit 882bf52fdeab47dbe991cc0e564b0b51c571d0a3 ] S5PV210's ADC variant is almost the same as v1 except that it has 10 channels and doesn'

<    1   2   3   4   5   6   7   8   9   10   >