Re: [RESEND PATCH] MAINTAINERS: update thermal CPU cooling section

2021-04-10 Thread Javi Merino
gt; >>> > >>> Regards, > >>> Lukasz > >>> > >>>   MAINTAINERS | 2 +- > >>>   1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/MAINTAINERS b/MAINTAINERS > >>> index f32eb

Re: [PATCH] thermal: cpu_cooling: Actually trace CPU load in thermal_power_cpu_get_power

2019-05-09 Thread Javi Merino
d, so > just remove the check. > > Fixes: 6828a4711f99 ("thermal: add trace events to the power allocator > governor") > Signed-off-by: Matthias Kaehlcke Yep, looks good to me. Acked-by: Javi Merino > --- > drivers/thermal/cpu_cooling.c | 2 +- > 1 file

Re: [RFC PATCH 6/7] sched/fair: update cpu_capcity to reflect thermal pressure

2018-10-09 Thread Javi Merino
On Tue, Oct 09, 2018 at 12:25:01PM -0400, Thara Gopinath wrote: > cpu_capacity relflects the maximum available capacity of a cpu. Thermal > pressure on a cpu means this maximum available capacity is reduced. This > patch reduces the average thermal pressure for a cpu from its maximum > available ca

Re: [RFC PATCH 0/7] Introduce thermal pressure

2018-10-09 Thread Javi Merino
On Tue, Oct 09, 2018 at 12:24:55PM -0400, Thara Gopinath wrote: > Thermal governors can respond to an overheat event for a cpu by > capping the cpu's maximum possible frequency. This in turn > means that the maximum available compute capacity of the > cpu is restricted. But today in linux kernel, i

Re: [RFC PATCH v3 03/10] PM: Introduce an Energy Model management framework

2018-06-09 Thread Javi Merino
On Fri, Jun 08, 2018 at 04:47:39PM +0100, Quentin Perret wrote: > Hi Javi, > > On Friday 08 Jun 2018 at 14:39:42 (+0100), Javi Merino wrote: > > On Wed, Jun 06, 2018 at 05:26:47PM +0100, Quentin Perret wrote: > > > On Wednesday 06 Jun 2018 at 16:29:50 (+0100), Quentin

Re: [RFC PATCH v3 03/10] PM: Introduce an Energy Model management framework

2018-06-09 Thread Javi Merino
On Thu, Jun 07, 2018 at 06:04:19PM +0200, Juri Lelli wrote: > On 07/06/18 16:19, Quentin Perret wrote: > > Hi Juri, > > > > On Thursday 07 Jun 2018 at 16:44:09 (+0200), Juri Lelli wrote: > > > On 21/05/18 15:24, Quentin Perret wrote: > > [...] > > > > > +static void fd_update_cs_table(struct em_

Re: [RFC PATCH v3 03/10] PM: Introduce an Energy Model management framework

2018-06-08 Thread Javi Merino
On Wed, Jun 06, 2018 at 05:26:47PM +0100, Quentin Perret wrote: > On Wednesday 06 Jun 2018 at 16:29:50 (+0100), Quentin Perret wrote: > > On Wednesday 06 Jun 2018 at 17:20:00 (+0200), Juri Lelli wrote: > > > > > This brings me to another question. Let's say there are multiple > > > > > users of >

Re: [PATCH V2 4/4] cpu_cooling: Drop static-power related stuff

2017-12-30 Thread Javi Merino
uot;thermal: cpu_cooling: implement the power cooling device API") also added documentation for it. You should remove the documentation, to keep it in sync. > Cc: Javi Merino > Cc: Punit Agrawal > Acked-by: Eduardo Valentin > Signed-off-by: Viresh Kumar >

Re: [PATCH 4/4] cpu_cooling: Drop static-power related stuff

2017-11-21 Thread Javi Merino
Hi, On Tue, Nov 21, 2017 at 08:57:06AM -0800, Eduardo Valentin wrote: [snip] > As I said before, the minimal you guys (ARM and Linaro) can do is to at > least upstream the Juno code! as a reference. Come on guys? what is > preventing you to upstream Juno model? As Ionela pointed out earlier in

Re: [PATCH 4/4] cpu_cooling: Drop static-power related stuff

2017-11-15 Thread Javi Merino
On Wed, Nov 15, 2017 at 02:49:48PM +0530, Viresh Kumar wrote: > No one has used it for the last two and half years (since it was > introduced by commit c36cf0717631 ("thermal: cpu_cooling: implement the > power cooling device API")), get rid of it. Linaro used it in lsk 3.18 for the cpufreq driver

Re: [PATCH] thermal: cpu_cooling: pr_err() strings should end with newlines

2017-10-25 Thread Javi Merino
On Tue, Oct 24, 2017 at 01:20:39PM +0530, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav FWIW, Acked-by: Javi Merino > --- > drivers/thermal/cpu_cooling.c | 2 +- > 1 file

Re: [PATCH 2/2] tracing, thermal: Hide cpu cooling trace events when not in use

2017-10-17 Thread Javi Merino
> The trace events thermal_power_cpu_get_power and > thermal_power_cpu_limit are only used when CONFIG_CPU_THERMAL is set. > Make those events only defined when that is set as well. > > Signed-off-by: Steven Rostedt (VMware) Acked-by: Javi Merino > --- > Index: linux-t

Re: [PATCH 1/2] tracing, thermal: Hide devfreq trace events when not in use

2017-10-17 Thread Javi Merino
> The trace events thermal_power_devfreq_get_power and > thermal_power_devfreq_limit are only used when CONFIG_DEVFREQ_THERMAL > is set. Make those events only defined when that is set as well. > > Signed-off-by: Steven Rostedt (VMware) Acked-by: Javi Merino > --- > Index: linux-t

[PATCH RESEND] drm: use .hword to represent 16-bit numbers

2017-03-29 Thread Javi Merino
they should work in spite of the default target of the cc you are using, so use .hword where EDID specifies 16-bit numbers. Cc: Carsten Emde Cc: David Airlie Signed-off-by: Javi Merino --- Documentation/EDID/edid.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

Re: [PATCH 0/2] Documentation/EDID fixes

2017-03-07 Thread Javi Merino
On Tue, Mar 07, 2017 at 06:16:51PM +0200, Jani Nikula wrote: > On Mon, 06 Mar 2017, Javi Merino wrote: > > I found these two minor issues while building an EDID. I'm not sure > > whether the second patch (Add O= to support) is upstream material, but > > I'm sendin

[PATCH 2/2] drm: Add O= support

2017-03-06 Thread Javi Merino
Add an option to put all output files in a given directory, similar to what kbuild does. Cc: Carsten Emde Cc: David Airlie Signed-off-by: Javi Merino --- Documentation/EDID/Makefile | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/Documentation/EDID

[PATCH 1/2] drm: use .hword to represent 16-bit numbers

2017-03-06 Thread Javi Merino
they should work in spite of the default target of the cc you are using, so use .hword where EDID specifies 16-bit numbers. Cc: Carsten Emde Cc: David Airlie Signed-off-by: Javi Merino --- Documentation/EDID/edid.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH 0/2] Documentation/EDID fixes

2017-03-06 Thread Javi Merino
Hi, I found these two minor issues while building an EDID. I'm not sure whether the second patch (Add O= to support) is upstream material, but I'm sending it just in case. Thanks, Javi Javi Merino (2): drm: use .hword to represent 16-bit numbers drm: Add O= support Document

Re: [PATCH v2] v4l: async: make v4l2 coexist with devicetree nodes in a dt overlay

2016-12-06 Thread Javi Merino
On Mon, Dec 05, 2016 at 10:13:38AM -0300, Javier Martinez Canillas wrote: > Hello Javi, > > On 12/05/2016 07:09 AM, Javi Merino wrote: > > In asds configured with V4L2_ASYNC_MATCH_OF, the v4l2 subdev can be > > part of a devicetree overlay, for example: &

[PATCH v2] v4l: async: make v4l2 coexist with devicetree nodes in a dt overlay

2016-12-05 Thread Javi Merino
e of_node_cmp() so that we continue matching after the overlay has been removed and reapplied. Cc: Mauro Carvalho Chehab Cc: Javier Martinez Canillas Cc: Sakari Ailus Signed-off-by: Javi Merino --- drivers/media/v4l2-core/v4l2-async.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH] v4l: async: make v4l2 coexists with devicetree nodes in a dt overlay

2016-11-29 Thread Javi Merino
On Fri, Nov 25, 2016 at 10:21:21AM +0200, Sakari Ailus wrote: Hi Sakari, > On Wed, Nov 23, 2016 at 04:15:11PM +0000, Javi Merino wrote: > > On Wed, Nov 23, 2016 at 05:10:42PM +0200, Sakari Ailus wrote: > > > Hi Javi, > > > > Hi Sakari, > > > > > O

Re: [PATCH] v4l: async: make v4l2 coexists with devicetree nodes in a dt overlay

2016-11-23 Thread Javi Merino
On Wed, Nov 23, 2016 at 05:10:42PM +0200, Sakari Ailus wrote: > Hi Javi, Hi Sakari, > On Wed, Nov 23, 2016 at 10:09:57AM +, Javi Merino wrote: > > In asd's configured with V4L2_ASYNC_MATCH_OF, if the v4l2 subdev is in > > a devicetree overlay, its of_node pointer will

Re: [PATCH] v4l: async: make v4l2 coexists with devicetree nodes in a dt overlay

2016-11-23 Thread Javi Merino
On Wed, Nov 23, 2016 at 11:25:39AM -0300, Javier Martinez Canillas wrote: > Hello Javi, > > On 11/23/2016 07:09 AM, Javi Merino wrote: > > In asd's configured with V4L2_ASYNC_MATCH_OF, if the v4l2 subdev is in > > a devicetree overlay, its of_node pointer will be d

[PATCH] v4l: async: make v4l2 coexists with devicetree nodes in a dt overlay

2016-11-23 Thread Javi Merino
o use of_node_cmp() so that we continue matching after the overlay has been removed and reapplied. Cc: Mauro Carvalho Chehab Cc: Javier Martinez Canillas Cc: Sakari Ailus Signed-off-by: Javi Merino --- Hi, I feel it is a bit of a hack, but I couldn't think of anything better. I'm ccing

[PATCH] MAINTAINERS: Switch to kernel.org email address for Javi Merino

2016-09-30 Thread Javi Merino
Change my email address to my kernel.org account instead of the ARM one. Signed-off-by: Javi Merino --- .mailmap| 1 + MAINTAINERS | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index de22daefd9da..1dab0a156489 100644 --- a/.mailmap +++ b/.mailmap

Re: [PATCH] of: thermal: Fixed governor at each thermal zone

2016-09-27 Thread Javi Merino
On Tue, Sep 27, 2016 at 09:46:57AM +0800, Zhang Rui wrote: > On 一, 2016-09-19 at 10:18 +0900, Inhyuk Kang wrote: > > It is necessary to be added governor at each thermal_zone. > > Because some governors should be operated in the during the kernel > > booting > > in order to avoid heating problem. >

Re: [PATCH] thermal: cpu_cooling: Fix wrong comment call function name

2016-09-08 Thread Javi Merino
On Wed, Sep 07, 2016 at 09:35:39AM +0900, Inhyuk Kang wrote: > The last_load is updated not cpufreq_get_actual_power() function call > but cpufreq_get_requested_power() function call. Yep, my bad. Thanks for fixing it! > Signed-off-by: Inhyuk Kang Acked-by: Javi Merino >

Re: [PATCH] devfreq_cooling: pass a pointer to devfreq in the power model callbacks

2016-06-20 Thread Javi Merino
Eduardo, Rui, On Fri, Jun 03, 2016 at 10:25:31AM +0100, Javi Merino wrote: > When the devfreq cooling device was designed, it was an oversight not to > pass a pointer to the struct devfreq as the first parameters of the > callbacks. The design patterns of the kernel suggest it f

[PATCH 1/2] arm64: defconfig: enable SENSORS_ARM_SCPI

2016-06-13 Thread Javi Merino
ARM SCPI Sensors were merged for v4.4 and they are defined in the Juno dts. Enable it in the defconfig to get them registered automatically in Juno by default. Signed-off-by: Javi Merino --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs

[PATCH 2/2] arm64: dts: juno: add thermal zones for scpi sensors

2016-06-13 Thread Javi Merino
Will Deacon Signed-off-by: Javi Merino --- arch/arm64/boot/dts/arm/juno-base.dtsi | 42 ++ arch/arm64/boot/dts/arm/juno-r1.dts| 16 + arch/arm64/boot/dts/arm/juno-r2.dts| 16 + 3 files changed, 74 insertions(+) diff --git a/arch/arm64

[PATCH 0/2] Enable SCPI sensors for Juno

2016-06-13 Thread Javi Merino
Enable the ARM SCPI sensors in arm64 defconfig and add thermal zones for the thermal scpi sensors on Juno. The hwmon support for SCPI sensors was merged for v4.4, this just enables it by default. Javi Merino (2): arm64: defconfig: enable SENSORS_ARM_SCPI arm64: dts: juno: add thermal zones

Re: [PATCH] thermal: fix race condition when updating cooling device

2016-06-06 Thread Javi Merino
thermal_cdev_update(). > > The other solution is to make cdev->updated an atomic_t, change the if > condition to an atomic_cmpxchg and extend the critical section to include the > call to cdev->ops->set_cur_state(). True. In any case, the mutex needs to cover set_cur_state() in th

Re: [PATCH v5 1/5] thermal: Add support for hardware-tracked trip points

2016-06-06 Thread Javi Merino
t; Cc: Eduardo Valentin > Cc: linux...@vger.kernel.org > > --- > > Changes in v5: > - add the lock for thermal_zone_set_trips function. Looks good to me! Reviewed-by: Javi Merino > - change based on next kernel. > > Changes in v4: > - Missing the lock added in

[PATCH] devfreq_cooling: pass a pointer to devfreq in the power model callbacks

2016-06-03 Thread Javi Merino
driver can identify which device it's referring to. Cc: Zhang Rui Cc: Eduardo Valentin Reviewed-by: Punit Agrawal Signed-off-by: Javi Merino --- drivers/thermal/devfreq_cooling.c | 5 +++-- include/linux/devfreq_cooling.h | 6 -- 2 files changed, 7 insertions(+), 4 deletions(-) diff

Re: [PATCH V2 2/6] cpufreq: Remove cpufreq_frequency_get_table()

2016-06-02 Thread Javi Merino
On Thu, Jun 02, 2016 at 09:06:26PM +0530, Viresh Kumar wrote: > On 2 June 2016 at 20:29, Javi Merino wrote: > > In 5a31d594a973 ("cpufreq: Allow freq_table to be obtained for offline > > CPUs") you did the opposite: don't use cpufreq_cpu_get_raw() because > > i

Re: [RESEND PATCH v4 1/5] thermal: Add support for hardware-tracked trip points

2016-06-02 Thread Javi Merino
Hi Caesar, On Fri, May 27, 2016 at 04:36:44PM +0800, Caesar Wang wrote: > From: Sascha Hauer > > This adds support for hardware-tracked trip points to the device tree > thermal sensor framework. > > The framework supports an arbitrary number of trip points. Whenever > the current temperature is

Re: [PATCH V2 2/6] cpufreq: Remove cpufreq_frequency_get_table()

2016-06-02 Thread Javi Merino
Hi Viresh, On Thu, Jun 02, 2016 at 07:34:56PM +0530, Viresh Kumar wrote: > Most of the callers of cpufreq_frequency_get_table() already have the > pointer to a valid 'policy' structure and they don't really need to go > through the per-cpu variable first and then a check to validate the > frequenc

Re: [PATCH v3 2/5] thermal: of: implement .set_trips for device tree thermal zones

2016-05-25 Thread Javi Merino
> > patch[0] > "thermal: Add support for hardware-tracked trip points". > > Signed-off-by: Sascha Hauer > Signed-off-by: Caesar Wang > Cc: Zhang Rui > Cc: Eduardo Valentin Other than that, it looks good to me. You can add my Reviewed-by: Javi Merino

Re: [PATCH v2 1/5] thermal: Add support for hardware-tracked trip points

2016-05-25 Thread Javi Merino
Hi Caesar, On Wed, May 25, 2016 at 11:27:24AM +0800, Caesar Wang wrote: > On 2016年05月24日 20:57, Javi Merino wrote: > >On Tue, May 03, 2016 at 05:33:29PM +0800, Caesar Wang wrote: > >>From: Sascha Hauer > >> > >>This adds support for hardware-tracked trip p

Re: [PATCH v3 1/5] thermal: Add support for hardware-tracked trip points

2016-05-25 Thread Javi Merino
Hi Caesar, On Wed, May 25, 2016 at 11:47:45AM +0800, Caesar Wang wrote: > From: Sascha Hauer > > This adds support for hardware-tracked trip points to the device tree > thermal sensor framework. > > The framework supports an arbitrary number of trip points. Whenever > the current temperature is

Re: [PATCH v2 4/5] thermal: bang-bang governor: act on lower trip boundary

2016-05-24 Thread Javi Merino
Ccing Peter Feuerer, author of the bang bang governor. On Tue, May 03, 2016 at 05:33:32PM +0800, Caesar Wang wrote: > From: Sascha Hauer > > With interrupt driven thermal zones we pass the lower and upper > temperature on which shall be acted, so in the governor we have to act on > the exact low

Re: [PATCH v2 2/5] thermal: of: implement .set_trips for device tree thermal zones

2016-05-24 Thread Javi Merino
On Tue, May 03, 2016 at 05:33:30PM +0800, Caesar Wang wrote: > From: Sascha Hauer > > This patch implemnets .set_trips for device tree thermal zones. > As the hardware-tracked trip points is supported by thermal core patch[0]. > > patch[0] > "thermal: Add support for hardware-tracked trip points

Re: [PATCH v2 1/5] thermal: Add support for hardware-tracked trip points

2016-05-24 Thread Javi Merino
On Tue, May 03, 2016 at 05:33:29PM +0800, Caesar Wang wrote: > From: Sascha Hauer > > This adds support for hardware-tracked trip points to the device tree > thermal sensor framework. > > The framework supports an arbitrary number of trip points. Whenever > the current temperature is updated, th

Re: [PATCH] Syntactic and factual errors in the API document

2016-03-31 Thread Javi Merino
On Thu, Mar 31, 2016 at 08:32:26AM +, Champ, Andy wrote: > I thought that _was_ the current kernel (not the obsolete one our chip vendor > supports). > > Which one do you mean by current? (URL & commit ID would be great!) You can find it in the MAINTAINERS file. I think Jon refers to git:

Re: [PATCH] Syntactic and factual errors in the API document

2016-03-22 Thread Javi Merino
Hi Andy, Thanks for improving the documentation! One minor nit below. Other than that, you can add my reviewed-by. On Tue, Mar 22, 2016 at 12:37:25PM +, Andy Champ wrote: > There are several places where the English in the document is syntactically > invalid, or unclear. There are also one

Re: [PATCH v3 2/4] devicetree: bindings: let thermal-sensor point to other thermal zones

2016-03-21 Thread Javi Merino
On Wed, Mar 02, 2016 at 07:21:53PM -0800, Eduardo Valentin wrote: > On Mon, Jan 04, 2016 at 03:17:09PM +0100, Sascha Hauer wrote: > > On Wed, Nov 25, 2015 at 03:09:44PM +0000, Javi Merino wrote: > > > The thermal-sensor property of the thermal zone node accepts phandles to >

Re: [PATCH v2 1/5] thermal: change "hysteresis" as optional property

2016-03-09 Thread Javi Merino
On Tue, Mar 08, 2016 at 12:55:59PM -0800, Eduardo Valentin wrote: > On Tue, Mar 08, 2016 at 09:57:43PM +0800, Leo Yan wrote: > > Hi Eduardo, > > > > On Fri, Mar 04, 2016 at 11:57:53AM +, Javi Merino wrote: > > > On Fri, Mar 04, 2016 at 11:03:49AM +0800, Leo Yan

Re: [PATCH] thermal: trace: migrating thermal traces to use TRACE_DEFINE_ENUM() macros

2016-03-08 Thread Javi Merino
On Tue, Mar 08, 2016 at 09:48:42AM +, Zhang, Rui wrote: > Punit and Javi, > > What do you think of this? I'd like to get your ACK before taking it. Sorry, I didn't realize you were waiting for us. I'm quite happy for this to go in: Acked-by: Javi Merino &g

Re: [PATCH v2 1/5] thermal: change "hysteresis" as optional property

2016-03-04 Thread Javi Merino
On Fri, Mar 04, 2016 at 11:03:49AM +0800, Leo Yan wrote: > Hi Eduardo, > > On Thu, Mar 03, 2016 at 08:29:44AM -0800, Eduardo Valentin wrote: > > Hi Leo, > > > > On Fri, Feb 26, 2016 at 11:43:43AM +0800, Leo Yan wrote: > > > The property "hysteresis" is mandatory for trip points, so if without > >

Re: [PATCH v2 1/5] thermal: change "hysteresis" as optional property

2016-03-03 Thread Javi Merino
pr_warning("missing hysteresis property\n"); I'd remove the warning. It is an optional parameter, so there is no need to warn about something going wrong. As you say in the commit log, it is ignored in the thermal subsystem and only used by some sensors so no need to warn about it missing. Other than that, I'm happy to see this merged. Acked-by: Javi Merino > + else > + trip->hysteresis = prop; > > ret = thermal_of_get_trip_type(np, &trip->type); > if (ret < 0) { > -- > 1.9.1 >

[PATCH] doc: fix grammar

2016-02-25 Thread Javi Merino
Some minor typos: - make is unbindable -> make it unbindable - a underlying -> an underlying - different version -> different versions Cc: Jonathan Corbet Signed-off-by: Javi Merino --- Documentation/filesystems/sharedsubtree.txt | 8 1 file changed, 4 inserti

Re: [PATCH 3/3] arm64: dts: register Hi6220's thermal zone for power allocator

2016-02-24 Thread Javi Merino
= <&target>; > + contribution = <1024>; As Hikey has only one voltage domain, you only have one cpu cooling device. "contribution" is only useful when you have more than one cooling device, as it's relative to the other cooling device's contribution. You can remove contribution from here. Other than this minor stuff, it looks good to me. FWIW, Reviewed-by: Javi Merino > + cooling-device = <&cpu0 > THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > + }; > + }; > }; > };

Re: Regard of thermal power allocator's coefficients

2016-02-18 Thread Javi Merino
Hi Leo, On Mon, Feb 15, 2016 at 12:47:51PM +0800, Leo Yan wrote: > Hi Eduardo, > > Thanks for replying. > > On Sun, Feb 14, 2016 at 09:12:19AM -0800, Eduardo Valentin wrote: > > On Sun, Feb 14, 2016 at 07:00:41PM +0800, Leo Yan wrote: > > [...] > > > > So want to firstly to confirm if should w

Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support

2016-02-18 Thread Javi Merino
Hi Sascha, On Thu, Feb 18, 2016 at 11:56:03AM +0100, Sascha Hauer wrote: > On Wed, Feb 17, 2016 at 06:05:57PM +0100, Matthias Brugger wrote: > > On 15/02/16 03:14, Daniel Kurtz wrote: > > >On Mon, Feb 15, 2016 at 10:11 AM, Daniel Kurtz > > >wrote: > > >>Hi Eduardo, Sascha, > > >> > > Any inp

Re: [PATCH] thermal: cpu_cooling: fix out of bounds access in time_in_idle

2016-02-11 Thread Javi Merino
On Thu, Feb 11, 2016 at 07:00:28AM -0800, Eduardo Valentin wrote: > On Thu, Feb 11, 2016 at 12:00:51PM +0000, Javi Merino wrote: > > In __cpufreq_cooling_register() we allocate the arrays for time_in_idle > > and time_in_idle_timestamp to be as big as the number of cpus in this >

[PATCH] thermal: cpu_cooling: fix out of bounds access in time_in_idle

2016-02-11 Thread Javi Merino
ff-by: Javi Merino --- Hi Andrew, This patch fixes an out of bounds access found by Nicolas Boichat using KASAN. It is acked by Viresh, comaintainer of the cpu cooling device and tested by the reporter. It's been in the list[0] for more than a month, I've pinged the thermal maintainers

Re: [PATCH] thermal: cpu_cooling: fix out of bounds access in time_in_idle

2016-01-25 Thread Javi Merino
On Mon, Jan 18, 2016 at 10:25:35AM +0800, Nicolas Boichat wrote: > On Fri, Jan 15, 2016 at 11:20 PM, Javi Merino wrote: > > Eduardo, Rui, > > > > On Tue, Jan 05, 2016 at 07:19:25PM +, Javi Merino wrote: > >> On Mon, Dec 21, 2015 at 08:49:40AM +0530, Viresh Kumar

Re: [PATCH v3 0/4] thermal: re-calculate k_po/k_pu when update sustainable power

2016-01-06 Thread Javi Merino
On Wed, Jan 06, 2016 at 11:21:54AM +, Daniel Thompson wrote: > On 06/01/16 10:07, Javi Merino wrote: > >On Wed, Jan 06, 2016 at 04:53:44PM +0800, Leo Yan wrote: > >>k_po/k_pu are two proportional term constants and essentially they have > >>fixed ratio compared

Re: [PATCH v3 0/4] thermal: re-calculate k_po/k_pu when update sustainable power

2016-01-06 Thread Javi Merino
On Wed, Jan 06, 2016 at 04:53:44PM +0800, Leo Yan wrote: > k_po/k_pu are two proportional term constants and essentially they have > fixed ratio compared with sustainable power. In current implementation, > k_po and k_pu are absolute value after calculation and cannot represent > the ratio relation

Re: [PATCH] thermal: cpu_cooling: fix out of bounds access in time_in_idle

2016-01-05 Thread Javi Merino
Eduardo, Rui, On Mon, Dec 21, 2015 at 08:49:40AM +0530, Viresh Kumar wrote: > On 19-12-15, 12:54, Javi Merino wrote: > > In __cpufreq_cooling_register() we allocate the arrays for time_in_idle > > and time_in_idle_timestamp to be as big as the number of cpus in this > > cpu

Re: [PATCH v2] thermal: re-calculate k_po/k_pu when update sustainable power

2016-01-05 Thread Javi Merino
On Mon, Jan 04, 2016 at 11:22:26AM +, Daniel Thompson wrote: > On 01/01/16 00:03, Leo Yan wrote: > >Hi Eduardo, > > > >Thanks for review. > > > >On Thu, Dec 31, 2015 at 09:21:26AM -0800, Eduardo Valentin wrote: > >>On Wed, Dec 30, 2015 at 06:38:40PM +0800, Leo Yan wrote: > >>>k_po/k_pu are in e

Re: [PATCH v2] thermal: re-calculate k_po/k_pu when update sustainable power

2016-01-05 Thread Javi Merino
On Fri, Jan 01, 2016 at 08:03:47AM +0800, Leo Yan wrote: > Hi Eduardo, > > Thanks for review. > > On Thu, Dec 31, 2015 at 09:21:26AM -0800, Eduardo Valentin wrote: > > On Wed, Dec 30, 2015 at 06:38:40PM +0800, Leo Yan wrote: > > > k_po/k_pu are in essence ratio values compared with sustainable po

[PATCH] thermal: cpu_cooling: fix out of bounds access in time_in_idle

2015-12-19 Thread Javi Merino
{,_timestamp} using the index in the cpufreq_device's allowed_cpus mask, as we do for the load_cpu array in cpufreq_get_requested_power() Reported-by: Nicolas Boichat Cc: Amit Daniel Kachhap Cc: Viresh Kumar Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- drivers/th

Re: [PATCH v3 2/4] devicetree: bindings: let thermal-sensor point to other thermal zones

2015-11-25 Thread Javi Merino
On Wed, Nov 25, 2015 at 05:54:41PM +, Mark Rutland wrote: > On Wed, Nov 25, 2015 at 03:09:44PM +0000, Javi Merino wrote: > > The thermal-sensor property of the thermal zone node accepts phandles to > > thermal sensors. However, thermal zones can be created as an > >

[PATCH v3 4/4] thermal: show the sub thermal zones in sysfs

2015-11-25 Thread Javi Merino
When a thermal zone is created that has sub thermal zones via devicetree or via thermal_zone_add_subtz() expose that relationship in sysfs. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- Documentation/thermal/sysfs-api.txt | 33 ++ drivers/thermal/thermal_core.c

[PATCH v3 3/4] thermal: of: parse stacked thermal zones from device tree

2015-11-25 Thread Javi Merino
Now that devicetree specifies how to create a hierarchy of thermal zones, let of-thermal parse it. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- drivers/thermal/of-thermal.c | 100 +++ 1 file changed, 100 insertions(+) diff --git a

[PATCH v3 1/4] thermal: Add support for hierarchical thermal zones

2015-11-25 Thread Javi Merino
Add the ability to stack thermal zones on top of each other, creating a hierarchy of thermal zones. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- Documentation/thermal/sysfs-api.txt | 39 +++ drivers/thermal/thermal_core.c | 210

[PATCH v3 2/4] devicetree: bindings: let thermal-sensor point to other thermal zones

2015-11-25 Thread Javi Merino
how a board thermal zone can be created from the aggregation of the cpu, gpu and lcd thermal zones. Cc: Zhang Rui Cc: Eduardo Valentin Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: devicet...@vger.kernel.org Signed-off-by: Javi Merino --- Notes: Hi

[PATCH v3 0/4] Hierarchical thermal zones

2015-11-25 Thread Javi Merino
. Changes since v2: - The aggregation function can be maximum or weighted average - Separated the update of the devicetree binding and the of-thermal into two separate patches Javi Merino (4): thermal: Add support for hierarchical thermal zones devicetree: bindings: let thermal-sensor

Re: [PATCH 3/4] sched: introduce synchronized idle injection

2015-11-25 Thread Javi Merino
On Tue, Nov 24, 2015 at 10:22:07AM -0800, Jacob Pan wrote: > On Tue, 24 Nov 2015 12:00:07 + > Javi Merino wrote: > > > > - you first set 50% idle > > > - then launch 6 busy loops > > > > Correct > Do you mind sharing the workload or test script

Re: [GIT PULL] Thermal-SoC management updates for v4.4-rc2 #1

2015-11-24 Thread Javi Merino
On Mon, Nov 16, 2015 at 07:32:41PM -0800, Eduardo Valentin wrote: > Hello Rui, > > Please pull from > > git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal > fixes > > to receive Thermal-SoC Management updates for v4.4-rc2 with top-most > > 84f0e490bee0684bd00c8ee02b1548

Re: [PATCH] thermal: fix thermal_zone_bind_cooling_device prototype

2015-11-24 Thread Javi Merino
r shows up, there is no doubt that > the prototype is still wrong, so let's just fix it anyway. > > Signed-off-by: Arnd Bergmann > Fixes: 6cd9e9f629f1 ("thermal: of: fix cooling device weights in device tree") Yes, we forgot to fix the case for !THERMAL Reviewed-by

Re: [PATCH 3/4] sched: introduce synchronized idle injection

2015-11-24 Thread Javi Merino
On Tue, Nov 24, 2015 at 03:10:59AM -0800, Jacob Pan wrote: > On Tue, 24 Nov 2015 11:09:56 +0100 > Peter Zijlstra wrote: > > > On Tue, Nov 24, 2015 at 09:12:40AM +0000, Javi Merino wrote: > > > On Mon, Nov 23, 2015 at 07:07:06PM +0100, Peter Zijlstra wrote: > > >

Re: [PATCH 3/4] sched: introduce synchronized idle injection

2015-11-24 Thread Javi Merino
On Mon, Nov 23, 2015 at 07:07:06PM +0100, Peter Zijlstra wrote: > On Mon, Nov 23, 2015 at 05:56:44PM +0000, Javi Merino wrote: > > I've tested this series on Juno (2xCortex-A57 4xCortex-A53). If you > > idle inject for 50% of the time, when I run 6 busy loops the scheduler >

Re: [PATCH 3/4] sched: introduce synchronized idle injection

2015-11-23 Thread Javi Merino
On Fri, Nov 13, 2015 at 11:53:06AM -0800, Jacob Pan wrote: > With increasingly constrained power and thermal budget, it's often > necessary to cap power via throttling. Throttling individual CPUs > or devices at random times can help power capping but may not be > optimal in terms of energy efficie

Re: [PATCH 4/4] sched: add trace event for idle injection

2015-11-19 Thread Javi Merino
[ CCing Steve Rostedt for the tracing bits ] On Fri, Nov 13, 2015 at 11:53:07AM -0800, Jacob Pan wrote: > Trace events for idle injection can be used to determine > timer activities for checking synchronization. In addition they > also helps to determine when the runqueue is throttled. > > Signed

Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support

2015-11-13 Thread Javi Merino
On Fri, Nov 13, 2015 at 11:09:12AM +0100, Sascha Hauer wrote: > On Wed, Nov 11, 2015 at 08:27:47AM +0100, Sascha Hauer wrote: > > On Tue, Nov 10, 2015 at 10:26:30AM -0800, Eduardo Valentin wrote: > > > On Tue, Nov 10, 2015 at 12:05:54PM +, Javi Merino wrote: > > > &

Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support

2015-11-11 Thread Javi Merino
On Wed, Nov 11, 2015 at 08:27:47AM +0100, Sascha Hauer wrote: > On Tue, Nov 10, 2015 at 10:26:30AM -0800, Eduardo Valentin wrote: > > On Tue, Nov 10, 2015 at 12:05:54PM +0000, Javi Merino wrote: > > > On Mon, Nov 09, 2015 at 11:13:32AM +0100,

Re: [PATCH v3 1/2] thermal: mediatek: Add cpu power cooling model.

2015-11-11 Thread Javi Merino
On Tue, Nov 10, 2015 at 10:41:22AM -0800, Eduardo Valentin wrote: > On Tue, Nov 10, 2015 at 11:20:18AM +0000, Javi Merino wrote: > > On Fri, Nov 06, 2015 at 08:54:33AM +0530, Viresh Kumar wrote: > > > Cc'ing Javi (which you should have as he wrote the power-thin

Re: [PATCH v3 3/3] cpufreq: arm_big_little: Add support to register a cpufreq cooling device

2015-11-10 Thread Javi Merino
hermal_cooling_device *cdev; > +}; > + My first impression was that this is redundant and you could store the pointer to cdev in driver_data itself. But seeing that it's mirroring the structure in cpufreq-dt and it's simpler to do it this way I guess it's ok to create this struct with

Re: [PATCH v3 2/3] cpufreq-dt: Supply power coefficient when registering cooling devices

2015-11-10 Thread Javi Merino
; Signed-off-by: Punit Agrawal > Acked-by: Viresh Kumar > Cc: Eduardo Valentin > --- > drivers/cpufreq/cpufreq-dt.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) FWIW, Reviewed-by: Javi Merino -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support

2015-11-10 Thread Javi Merino
On Mon, Nov 09, 2015 at 11:13:32AM +0100, Sascha Hauer wrote: > This adds support for the Mediatek thermal controller found on MT8173 > and likely other SoCs. > The controller is a bit special. It does not have its own ADC, instead > it controls the on-SoC AUXADC via AHB bus accesses. For this reas

Re: [PATCH v3 1/2] thermal: mediatek: Add cpu power cooling model.

2015-11-10 Thread Javi Merino
On Fri, Nov 06, 2015 at 08:54:33AM +0530, Viresh Kumar wrote: > Cc'ing Javi (which you should have as he wrote the power-thing for > cpu-cooling). > > On 05-11-15, 19:10, dawei chien wrote: > > This is because our platform currently only support mt8173_cpufreq.c, so > > that I only add static powe

Re: [PATCH v2 1/3] thermal: Add support for hierarchical thermal zones

2015-11-09 Thread Javi Merino
On Wed, Nov 04, 2015 at 10:51:02AM -0800, Eduardo Valentin wrote: > Javi, > > First of all, thanks for taking the lead on implementing this. > > It follows comments. > > On Wed, Nov 04, 2015 at 05:37:40PM +, Javi Merino wrote: > > Add the ability to stack thermal

Re: [PATCH v2 2/3] thermal: of: parse stacked thermal zones from device tree

2015-11-09 Thread Javi Merino
On Wed, Nov 04, 2015 at 10:56:34AM -0800, Eduardo Valentin wrote: > On Wed, Nov 04, 2015 at 05:37:41PM +0000, Javi Merino wrote: > > Let device tree set thermal zones in the thermal-sensors list of > > phandles and set up the thermal zone hierarchy based on the information &g

[PATCH v2 3/3] thermal: show the sub thermal zones in sysfs

2015-11-04 Thread Javi Merino
When a thermal zone is created that has sub thermal zones via devicetree or via thermal_zone_add_subtz() expose that relationship in sysfs. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- Documentation/thermal/sysfs-api.txt | 5 + drivers/thermal/thermal_core.c

[PATCH v2 2/3] thermal: of: parse stacked thermal zones from device tree

2015-11-04 Thread Javi Merino
Let device tree set thermal zones in the thermal-sensors list of phandles and set up the thermal zone hierarchy based on the information present there. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- .../devicetree/bindings/thermal/thermal.txt| 154

[PATCH v2 1/3] thermal: Add support for hierarchical thermal zones

2015-11-04 Thread Javi Merino
Add the ability to stack thermal zones on top of each other, creating a hierarchy of thermal zones. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- Documentation/thermal/sysfs-api.txt | 35 + drivers/thermal/thermal_core.c | 151

[PATCH v2 0/3] Hierarchical thermal zones

2015-11-04 Thread Javi Merino
support to thermal core. Patch 2 adds device tree support and patch 3 exports the hierarchy to sysfs. Changes since v1: - Fix the prototype of thermal_zone_{add,del}_subtz() for !CONFIG_THERMAL as reported by the kbuild test robot Javi Merino (3): thermal: Add support for hierarchical

[PATCH 2/2] thermal: devfreq_cooling: Make power a u64

2015-11-02 Thread Javi Merino
include/asm-generic/div64.h:35:17: note: expected 'uint64_t *' but argument is of type 'long unsigned int *' Reported-by: kbuild test robot Cc: Eduardo Valentin Cc: Zhang Rui Signed-off-by: Javi Merino --- drivers/thermal/devfreq_cooling.c | 2 +- 1 file changed, 1 insert

[PATCH 1/2] thermal: devfreq_cooling: use a thermal_cooling_device for register and unregister

2015-11-02 Thread Javi Merino
Be consistent with what other cooling devices do and return a struct thermal_cooling_device * on register. Also, for the unregister, accept a struct thermal_cooling_device * as parameter. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- drivers/thermal/devfreq_cooling.c | 16

[PATCH 0/2] Fixes for devfreq cooling

2015-11-02 Thread Javi Merino
When devfreq cooling entered Eduardo's tree, the kbuild test robot spotted a compilation warning on sh. Also, the first patch aligns the return type and the parameters of the devfreq register/unregister with those of the cpu cooling device. This patches apply on top of eduardo/next. Javi M

[PATCH 3/3] thermal: show the sub thermal zones in sysfs

2015-10-30 Thread Javi Merino
When a thermal zone is created that has sub thermal zones via devicetree or via thermal_zone_add_subtz() expose that relationship in sysfs. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- Documentation/thermal/sysfs-api.txt | 5 + drivers/thermal/thermal_core.c

[PATCH 1/3] thermal: Add support for hierarchical thermal zones

2015-10-30 Thread Javi Merino
Add the ability to stack thermal zones on top of each other, creating a hierarchy of thermal zones. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- Documentation/thermal/sysfs-api.txt | 35 + drivers/thermal/thermal_core.c | 151

[PATCH 2/3] thermal: of: parse stacked thermal zones from device tree

2015-10-30 Thread Javi Merino
Let device tree set thermal zones in the thermal-sensors list of phandles and set up the thermal zone hierarchy based on the information present there. Cc: Zhang Rui Cc: Eduardo Valentin Signed-off-by: Javi Merino --- .../devicetree/bindings/thermal/thermal.txt| 154

[PATCH 0/3] Hierarchical thermal zones

2015-10-30 Thread Javi Merino
support to thermal core. Patch 2 adds device tree support and patch 3 exports the hierarchy to sysfs. Javi Merino (3): thermal: Add support for hierarchical thermal zones thermal: of: parse stacked thermal zones from device tree thermal: show the sub thermal zones in sysfs .../devicetree

Re: [PATCH 3/3][v2] Thermal: do thermal zone update after a cooling device registered

2015-10-28 Thread Javi Merino
Hi Yu, One minor nit below. Other than that you can add my Reviewed-by: Javi Merino On Mon, Oct 26, 2015 at 11:15:30AM +0800, Chen Yu wrote: > When a new cooling device is registered, we need to update the > thermal zone to set the new registered cooling device to a proper > state.

Re: [PATCH 2/3][v2] Thermal: handle thermal zone device properly during system sleep

2015-10-28 Thread Javi Merino
Hi Yu, some minor nits below. Other than that, you can add my Reviewed-by: Javi Merino On Mon, Oct 26, 2015 at 11:14:31AM +0800, Chen Yu wrote: > From: Zhang Rui > > Current thermal code does not handle system sleep well because > 1. the cooling device cooling state may be ch

Re: [PATCH 3/3] Thermal: do thermal zone update after a cooling device registered

2015-10-20 Thread Javi Merino
Hi Yu, On Tue, Oct 20, 2015 at 01:44:20AM +, Chen, Yu C wrote: > > -Original Message- > > From: Javi Merino [mailto:javi.mer...@arm.com] > > Sent: Thursday, October 15, 2015 10:05 PM > > To: Chen, Yu C > > Cc: linux...@vger.kernel.org; edubez...@gmail.co

Re: [PATCH 3/3] Thermal: do thermal zone update after a cooling device registered

2015-10-15 Thread Javi Merino
On Wed, Oct 14, 2015 at 07:23:55PM +, Chen, Yu C wrote: > > -Original Message- > > From: Javi Merino [mailto:javi.mer...@arm.com] > > Sent: Thursday, October 15, 2015 1:08 AM > > To: Chen, Yu C > > Cc: linux...@vger.kernel.org; edubez...@gmail.c

  1   2   3   4   5   >