On Tue, Feb 17, 2015 at 6:45 PM, Stephen Boyd wrote:
> On 02/17/15 15:02, Bjorn Andersson wrote:
>> On Thu, Feb 12, 2015 at 8:26 PM, Stephen Boyd wrote:
[..]
>>> This doesn't seem to do anything for the OVP spike mentioned in this
>>> patch[1]. Do you see that problem on your device? I imagine th
On 02/17/15 15:02, Bjorn Andersson wrote:
> On Thu, Feb 12, 2015 at 8:26 PM, Stephen Boyd wrote:
>> On 01/23/15 16:54, Bjorn Andersson wrote:
>>> +
>>> +static int pm8941_wled_set(struct led_classdev *cdev,
>>> +enum led_brightness value)
>>> +{
>>> + struct pm8941_wled
On Thu, Feb 12, 2015 at 8:04 PM, Stephen Boyd wrote:
[..]
>> +
>> +static int pm8941_wled_remove(struct platform_device *pdev)
>> +{
>> + struct pm8941_wled *wled;
>> +
>> + wled = platform_get_drvdata(pdev);
>> + led_classdev_unregister(&wled->cdev);
>
> Would be nice to have a devm f
On Thu, Feb 12, 2015 at 8:07 PM, Stephen Boyd wrote:
> On 01/29/15 04:48, Ivan T. Ivanov wrote:
>>
>> Otherwise it looks good. Driver is loaded and device is detected
>> properly (i have added readings for type and subtype registers).
>> Do you know where I can measure result from changing brightn
On Thu, Feb 12, 2015 at 8:26 PM, Stephen Boyd wrote:
> On 01/23/15 16:54, Bjorn Andersson wrote:
>> +
>> +static int pm8941_wled_set(struct led_classdev *cdev,
>> +enum led_brightness value)
>> +{
>> + struct pm8941_wled *wled;
>> + u8 ctrl = 0;
>> + u16 val;
>>
On Tue, Feb 17, 2015 at 2:30 PM, Bjorn Andersson wrote:
> On Tue, Feb 17, 2015 at 2:14 PM, Bryan Wu wrote:
>> On Thu, Feb 12, 2015 at 8:04 PM, Stephen Boyd wrote:
>>> On 01/23/15 16:54, Bjorn Andersson wrote:
>>
>> Thanks for the review, Stephen.
>> Bjorn, could you please update your patch acco
On Tue, Feb 17, 2015 at 2:14 PM, Bryan Wu wrote:
> On Thu, Feb 12, 2015 at 8:04 PM, Stephen Boyd wrote:
>> On 01/23/15 16:54, Bjorn Andersson wrote:
>
> Thanks for the review, Stephen.
> Bjorn, could you please update your patch according to Stephen's review.
>
I will do so, do you want me to se
On Thu, Feb 12, 2015 at 8:04 PM, Stephen Boyd wrote:
> On 01/23/15 16:54, Bjorn Andersson wrote:
Thanks for the review, Stephen.
Bjorn, could you please update your patch according to Stephen's review.
-Bryan
>> +
>> +static int pm8941_wled_configure(struct pm8941_wled *wled, struct device
>>
On 02/12/15 20:28, Ivan T. Ivanov wrote:
> On Thu, 2015-02-12 at 20:07 -0800, Stephen Boyd wrote:
>> On 01/29/15 04:48, Ivan T. Ivanov wrote:
>>> Otherwise it looks good. Driver is loaded and device is detected
>>> properly (i have added readings for type and subtype registers).
>>> Do you know whe
On Thu, 2015-02-12 at 20:07 -0800, Stephen Boyd wrote:
> On 01/29/15 04:48, Ivan T. Ivanov wrote:
> > Otherwise it looks good. Driver is loaded and device is detected
> > properly (i have added readings for type and subtype registers).
> > Do you know where I can measure result from changing brigh
On 01/23/15 16:54, Bjorn Andersson wrote:
> +
> +static int pm8941_wled_set(struct led_classdev *cdev,
> +enum led_brightness value)
> +{
> + struct pm8941_wled *wled;
> + u8 ctrl = 0;
> + u16 val;
> + int rc;
> + int i;
> +
> + wled = container_of(cd
On 01/29/15 04:48, Ivan T. Ivanov wrote:
>
> Otherwise it looks good. Driver is loaded and device is detected
> properly (i have added readings for type and subtype registers).
> Do you know where I can measure result from changing brightness
> sysfs entry. I am using 8074 dragonboard?
Does the b
On 01/23/15 16:54, Bjorn Andersson wrote:
> +
> +static int pm8941_wled_configure(struct pm8941_wled *wled, struct device
> *dev)
> +{
> + struct pm8941_wled_config *cfg = &wled->cfg;
> + u32 val;
> + int rc;
> + int i;
> +
> + const struct {
> + const char *name;
>
On Thu, Jan 29, 2015 at 11:07 AM, Bjorn Andersson
wrote:
> On Thu 29 Jan 04:48 PST 2015, Ivan T. Ivanov wrote:
>
>>
>> Hi Bjorn,
>>
>> Just few nitpick comments.
>>
>
> Thanks.
>
>> On Fri, 2015-01-23 at 16:54 -0800, Bjorn Andersson wrote:
>> > From: Courtney Cavin ca...@sonymobile.com>
>> >
>> >
On Thu 29 Jan 04:48 PST 2015, Ivan T. Ivanov wrote:
>
> Hi Bjorn,
>
> Just few nitpick comments.
>
Thanks.
> On Fri, 2015-01-23 at 16:54 -0800, Bjorn Andersson wrote:
> > From: Courtney Cavin ca...@sonymobile.com>
> >
> > This adds support for the WLED ('White' LED) block on Qualcomm's
> >
Hi Bjorn,
Just few nitpick comments.
On Fri, 2015-01-23 at 16:54 -0800, Bjorn Andersson wrote:
> From: Courtney Cavin ca...@sonymobile.com>
>
> This adds support for the WLED ('White' LED) block on Qualcomm's
> PM8941 PMICs.
>
> Signed-off-by: Courtney Cavin ca...@sonymobile.com>
> Signed-off
On Fri, Jan 23, 2015 at 4:54 PM, Bjorn Andersson
wrote:
> From: Courtney Cavin
>
> This adds support for the WLED ('White' LED) block on Qualcomm's
> PM8941 PMICs.
>
> Signed-off-by: Courtney Cavin
> Signed-off-by: Bjorn Andersson
> ---
Sorry, I missed the change log.
Changed since v1:
* Repl
17 matches
Mail list logo
