re have been problems reported when using
i2cdetect...
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
I2C adapter
'i2cdetect -r ...' would be more interesting to see communication with
slaves happening :) Also, what kernel did you test?
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | h
rupts for I2C are 26
> and 27 that why I assigned these two in the dts.
You might want to try my for-next branch or wait for 3.8-rc1, maybe the
DMA termination patch helps? Also enabling I2C debug messages is
probably worth it.
Regards,
Wolfram
--
Pengutronix e.K.
Hi,
working on the transparency thing here regarding the current I2C
workflow. I am currently on, well, let's call it something between
holiday and retreat. I will work on (hopefully all) pending I2C patches
half-time until Friday and then probably disappear for about 3 weeks
again. Disappearing m
On Thu, Feb 14, 2013 at 12:28:18PM +0100, Cong Ding wrote:
> If it goes to eclk through line 1107, the variable res would be NULL. It will
> cause a null pointer dereference error if we call release_mem_region. The
> correct way should be using devm_kzalloc rather than kzalloc to allocate
> memory.
On Fri, Mar 01, 2013 at 08:57:32AM -0800, Doug Anderson wrote:
> The commit: "i2c-core: dt: Pick i2c bus number from i2c alias if
> present" adds support for automatically picking the bus number based
> on the alias ID. Remove the now unnecessary code from i2c-pxa that
> did the same thing.
>
> S
Change to my private email, change to my shiny new kernel.org repos,
and drop outdated entry from the former maintainer. Drop my PCA entry,
too, since it belongs to the I2C realm anyhow.
Signed-off-by: Wolfram Sang
---
MAINTAINERS | 16 +++-
1 file changed, 3 insertions(+), 13
Hi,
thanks for doing this cleanup series. Looks very worthwhile!
> --- a/drivers/i2c/i2c-core.c
> +++ b/drivers/i2c/i2c-core.c
> @@ -935,25 +935,16 @@ out_list:
> */
> int i2c_add_adapter(struct i2c_adapter *adapter)
> {
> - int id, res = 0;
> -
> -retry:
> - if (idr_pre_get(&i2c_
king is unnecessary.
>
> Update idr_*() functions to fail with -EINVAL when negative @id is
> specified and update other MAX_IDR_MASK users as described above.
>
> This leaves MAX_IDR_MASK without any user, remove it and relocate
> other MAX_IDR_* constants to lib/idr.
Hi Doug,
On Mon, Jan 14, 2013 at 10:53:21AM -0800, Doug Anderson wrote:
> This allows you to get the equivalent functionality of
> i2c_add_numbered_adapter() with all data in the device tree and no
> special case code in your driver. This is a common device tree
> technique.
>
> For quick refere
> what happend to this one ? It was a patch updating Kconfig help for at24.
Do you know linux-next? Have a look there...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/m
> Seth recently sent a patch adding IDs for the Avoton:
> http://marc.info/?l=linux-kernel&m=135959209218860&w=2
>
> Your patch conflicts with his. Please rebase on top of Seth's patch, so
> that both patches can be applied in sequence.
Yes, please.
> > --- a/drivers/i2c/busses/i2c-i801.c
> > +
be my first guess. Also, which
eeprom do you have? Check its datasheet, some in deed use 8 addresses.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
On Fri, Nov 23, 2012 at 02:11:51PM +0530, Tushar Behera wrote:
> This patchset cleans up the probe function of i2c-s3c2410 driver.
> These have been tested on Exynos4210 based Origen board.
>
> Changes since V1:
> * devm_request_mem_region and devm_ioremap calls were replaced by
> devm_request_a
On Fri, Dec 07, 2012 at 11:14:28AM +0100, Lars Poeschel wrote:
> > > > > I wanted to use a fm24c04 i2c fram chip with linux. I grepped the
> > > > > source and found nothing. I later found that my chip can be handled
> > > > > by at24 eeprom driver. It creates a sysfs file called eeprom to
> > > >
On Thu, Jan 10, 2013 at 03:07:42PM +0100, Laurent Navet wrote:
> avoid these checkpatch.pl issues :
> - ERROR: "foo * bar" should be "foo *bar"
> - ERROR: switch and case should be at the same indent
> - ERROR: "(foo*)" should be "(foo *)"
> - ERROR: do not use assignment in if condition
> - ERROR:
On Sat, Jan 05, 2013 at 05:34:46PM +0530, Laxman Dewangan wrote:
> NVIDIA's Tegra114 has following enhanced feature in i2c controller:
> - Enable/disable control for per packet transfer complete interrupt.
> Earlier SoCs could not disable this.
> - Single clock source for standard/fast and HS mod
On Thu, Jan 17, 2013 at 12:31:03PM +0200, Mika Westerberg wrote:
> Hi all,
>
> This series adds support for the Intel Lynxpoint Low Power Subsystem I2C
> controllers. They are compatible with the DesignWare I2C controller.
>
> Patches [1/4] and [2/4] are fixes that are necessary to get the driver
re. Can you elaborate?
That being said. Grant's design was the most promising one.
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
On Thu, Jan 24, 2013 at 07:18:47PM +0800, Mark Brown wrote:
> On Thu, Jan 24, 2013 at 12:13:29PM +0100, Wolfram Sang wrote:
> > On Sat, Dec 15, 2012 at 11:21:36PM +0900, Mark Brown wrote:
>
> > > also get things like read operations which appear as multiple
> > >
nnot meet bus frequency required\n");
> return -EINVAL;
> }
> @@ -939,7 +967,8 @@ static int s3c24xx_i2c_init(struct s3c24xx_i2c *i2c)
> /* todo - check that the i2c lines aren't being dragged anywhere */
>
> dev_info(i2c->dev, "bus frequency set to %d KHz\n", freq);
> - dev_dbg(i2c->dev, "S3C2410_IICCON=0x%02lx\n", iicon);
> + dev_dbg(i2c->dev, "S3C2410_IICCON=0x%02x\n",
> + readl(i2c->regs + S3C2410_IICCON));
>
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
ubtle issues with devm_request_irq. The
remove path can already render the ISR unusable/oopsable but devm will
free the interrupt only after remove has finished. Interrupts need to be
properly masked out before.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang
memory_accessor macc;
> int use_smbus;
> + int use_smbuse_write;
Can't you use the same 'use_smbus' variable and do a similar switch-case
as in the read function?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang
d, please stick to that.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
function
i2c: s3c2410: Remove err_cpufreq label
Wolfram Sang (1):
i2c: nomadik: drop superfluous variable initialization
.../devicetree/bindings/i2c/brcm,bcm2835-i2c.txt | 20 +
.../devicetree/bindings/i2c/i2c-s3c2410.txt|2 +
Documentation/i2c/busses/i2c-i801
On Tue, Feb 26, 2013 at 11:02:17AM +0100, Jiri Kosina wrote:
> On Fri, 22 Feb 2013, 송은봉 wrote:
>
> >
> >
> >
> > I've been debugging the abnormal operation of i2c on octeon.
> > If a process is terminated by signal in the middle of i2c operation,
> > next i2c read operation which is done by an
commit 6b4d0b27 (clean shmem_file_setup() a bit) broke allnoconfig since
this needs the NOMMU path where 'error' is still needed:
mm/shmem.c:2935:2: error: 'error' undeclared (first use in this function)
Signed-off-by: Wolfram Sang
Cc: Al Viro
---
mm/shmem.c |1
> > Doug Anderson (2):
> > i2c-core: dt: Pick i2c bus number from i2c alias if present
> > i2c: pxa: Use i2c-core to get bus number now
> >
> > drivers/i2c/busses/i2c-pxa.c | 20
> > drivers/i2c/i2c-core.c | 54
> >
> > 2 fi
On Wed, Feb 20, 2013 at 12:50:10AM -0800, Dmitry Torokhov wrote:
> The remove() methods should not be marked __exit unless we are using
> platform_driver_probe() which disables unbinding device from driver
> via sysfs.
>
> Signed-off-by: Dmitry Torokhov
Eeks, I broke this with my very first linu
;
> + if (!pdata) {
> + ret = -ENOMEM;
> + goto err_no_mem;
> + }
> + }
> + nmk_i2c_of_probe(np, pdata);
> + }
> +
> if (!pdata)
> /*
_probe modifies pdata which in this case the default config which
might already be in use. So, you will get problems if you have two
instances with different configuration. So, we need to allocate memory
but copy the content of the default data. The patch above just copies
the pointer which is bogus.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
On Mon, Sep 03, 2012 at 10:16:22PM +0200, Roland Stigge wrote:
> Hi Wolfram,
>
> On 20/08/12 19:55, Wolfram Sang wrote:
> >> I've never had my hands on a PNX4008 chip at NXP, but I do
> >> believe they are the same IP. That specific I2C IP was used in a
> >
to do from my side?
>
> Wolfram, ping?
>
> Can we imagine to have this support and the device tree patches from
> Ludovic in 3.7-final?
Yes. I'd need your ack since it touches mach-specific stuff. Reviewed-by
would be even better since you know the HW better than me :)
--
board_info(). After this patch, each sub-device can
> > be registered directly from Device Tree instead, removing the
> > requirement for the aforementioned calls from platform code.
> >
> > CC: linux-...@vger.kernel.org
> > CC: Wolfram Sang
> > Signed-off-by:
Guide people to where their patches can be found these days.
Signed-off-by: Wolfram Sang
---
MAINTAINERS |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index fdc0119..53cc13c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3388,7 +3388,7 @@ M
igned-off-by: Murali Karicheri
Subject had "i2c:clk" where "i2c: davinci" would be more precise.
Fixed that and pushed to -next.
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://
look much like I2C, neither.
There is no ACK/NACK/START/STOP, so I wonder if it should be in i2c
after all...
Jean, maybe you want to have a glimpse on this as well?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solution
can follow, but how should I know you aimed for that? I
only saw a patch [3/3] in one series making the driver probable via DT
and a patch [12/19] in another series to scan the child nodes. That's
all the infos I got. Some more context would have been helpful. Is there
a bra
ill allow me to
resolve the merge conflict in my tree on my own. I don't see a strong
reason to have those go via arm-soc (like prevented build-failures or
easier merges), if I missed such a reason, please let me know.
Regards,
Wolfram
--
Pengutronix e.K.
;;
> +
> + gpios[2].gpio = chost->sel_gpio;
> + gpios[2].flags = GPIOF_OUT_INIT_HIGH;
> + gpios[2].label = "CBUS sel";
> +
> + ret = gpio_request_array(gpios, ARRAY_SIZE(gpios));
> + if (ret)
> + goto error_gpio;
> +
> + gpio_set_value(c
t's just as easy
> to make reference to.
It makes reviewing a lot easier if the documentation what is supposed to
be coded and the actual code are in one place. It also prevents what
happened in this case where the documentation never showed up on the
i2c-list.
--
Pengutronix e.K.
)
Roland Stigge (2):
i2c: pnx: Fix bit definitions
i2c: pnx: Fix read transactions of >= 2 bytes
Thomas Kavanagh (1):
i2c: algo: pca: Fix mode selection for PCA9665
Wolfram Sang (2):
i2c: mxs: correctly se
Signed-off-by: Laxman Dewangan
> Acked-by: Jean Delvare
Applied to for-current, thanks.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
)
Laxman Dewangan (1):
i2c: tegra: set irq name as device name
Philippe Begnic (1):
i2c-nomadik: Fixup clock handling
Wolfram Sang (1):
i2c: mxs: remove broken PIOQUEUE support
drivers/i2c/busses/i2c-mxs.c | 186
Jean,
> * Wolfram Sang, for joining the crew when it became clear that there
> was more review work than Ben and myself could deal with.
Thank you for guiding me when I entered the kernel space and again when
you entrusted me to do maintainer work in i2c.
> I hope I did not forg
vpetimath (1):
i2c-nomadik: Add 10-bit addressing support
Wolfram Sang (4):
devicetree: bindings: gpio-i2c belongs to i2c not gpio
i2c: imx: make bitrate an u32 type
i2c: mv64: remove EXPERIMENTAL tag
Revert "i2c: tegra: convert normal suspend/resume to *_noirq&
> The driver should support the same chip models reardless of whether it's used
> with or without DT. If an entry in the OF table has no corresponding entry in
> the I2C table I would consider that as a driver bug.
Linus Walleij posted a patch to support DT only probing, but too many
side-effec
On Tue, Aug 27, 2013 at 04:55:22PM +0900, Nguyen Viet Dung wrote:
> This patch modify I2C driver of rcar-H1 to usable on both rcar-H1 and rcar-H2.
>
> Signed-off-by: Nguyen Viet Dung
Yes, this is much better. Only minor things...
> + switch (priv->devtype) {
> + default:
> + case I2
On Mon, Aug 19, 2013 at 03:07:54PM +0300, Mika Westerberg wrote:
> Some Intel LPSS I2C devices make the SDA hold time and *CNT parameters
> available via SSCN (standard mode) and FMCN (fast mode) ACPI methods.
>
> Implement support for this so that we check whether an ACPI method exists
> and if i
On Mon, Aug 19, 2013 at 03:07:53PM +0300, Mika Westerberg wrote:
> The DesignWare I2C controller has high count (HCNT) and low count (LCNT)
> registers for each of the I2C speed modes (standard and fast). These
> registers are programmed based on the input clock speed in the driver.
>
> The curren
On Tue, Aug 20, 2013 at 05:03:35PM +0300, Mika Westerberg wrote:
> From: Aaron Lu
>
> This patch adds runtime PM support for the I2C bus in a similar way that
> has been done for PCI bus already. This means that the I2C bus core
> prepares runtime PM for a client device just before a driver is ab
> >> +Optional properties :
> >> +- i2c-min-scl-pulse-width-us : The minimum valid SCL pulse width that is
> >> allowed
> >> + through the deglitch circuit. In units of us.
> >> +- i2c-min-sda-pulse-width-us : The minimum valid SDA pulse width that is
> >> allowed
> >> + through the deglitch c
On Wed, Oct 02, 2013 at 01:46:47PM +0200, Linus Walleij wrote:
> Currently the BH1780GLI I2C driver relies on the device tree node
> having the right name, but this is fragile. Use the compatible
> string to probe the driver instead.
>
> Cc: Wolfram Sang
> Signed-off-by: Linus
On Sun, Sep 29, 2013 at 10:50:58AM +0200, Lars-Peter Clausen wrote:
> Hi,
>
> This series removes the redundant driver field from the i2c_client struct. The
> field is redundant since the same pointer can be accessed through
> to_i2c_driver(client->dev.driver). The commit log suggests that the fie
> + i2c->base = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(i2c->base)) {
> + dev_err(&pdev->dev, "Could not allocate iomem\n");
devm_ioremap_resource already prints error messages.
> + ret = devm_request_irq(&pdev->dev, irq, xiic_isr, 0, pdev->name, i2c);
Thi
> + cr = xiic_getreg32(i2c, XIIC_CR_REG_OFFSET);
> + cr |= XIIC_CR_DIR_IS_TX_MASK;
> + xiic_setreg32(i2c, XIIC_CR_REG_OFFSET, cr);
> +
Is there no need to clear the bit again when receiving? And did
transferring ever work if this bit was never set before?
signature.asc
Description:
On Fri, Oct 04, 2013 at 11:53:49AM +0200, Michal Simek wrote:
> On 10/04/2013 07:46 AM, Wolfram Sang wrote:
> >
> >> + cr = xiic_getreg32(i2c, XIIC_CR_REG_OFFSET);
> >> + cr |= XIIC_CR_DIR_IS_TX_MASK;
> >> + xiic_setreg32(i2c, XIIC_CR_REG_OFFSET, cr);
>
On Fri, Oct 04, 2013 at 11:16:20AM +0200, Michal Simek wrote:
> On 10/04/2013 07:33 AM, Wolfram Sang wrote:
> >
> >> + i2c->base = devm_ioremap_resource(&pdev->dev, res);
> >> + if (IS_ERR(i2c->base)) {
> >> +
> > First register the handler, then activate interrupts. You are right,
> > this needs to be fixed, too.
>
> Do you want me to create separate patch just about moving request irq in
> front of
> xiic_reinit()? And then devm_ conversion?
Yes, seperate, please.
signature.asc
Description: Digi
On Thu, Aug 15, 2013 at 12:30:25PM +0200, Wolfram Sang wrote:
> Use of this function is discouraged in favour of
> devm_ioremap_resource(). Don't advertise it.
>
> Signed-off-by: Wolfram Sang
Ping.
signature.asc
Description: Digital signature
easier to remember which function to use and to make code more readable,
introduce a new inline function with the proper name and consistent argument
type. Update the kernel-doc for init_completion while we are here.
Signed-off-by: Wolfram Sang
Acked-by: Linus Walleij (personally at LCE13
Use this new function to make code more comprehensible, since we are
reinitialzing the completion, not initializing.
Signed-off-by: Wolfram Sang
Acked-by: Linus Walleij (personally at LCE13)
---
This is now a tree-wide patch for easier review. I can easily split it up later.
arch/arm/mach
ested on
an AT91 board. More testing welcome.
Looking forward to opinions. If accepted, I'd think it is probably best if this
gets in in one go via Linus directly?
Thanks,
Wolfram
Wolfram Sang (2):
sched: replace INIT_COMPLETION with reinit_completion
tree-wide: use reinit_completi
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij (personally at LCE13)
Signed-off-by: Wolfram Sang
---
drivers/net/ethernet/cadence/at91_ether.c | 11
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij (personally at LCE13)
Signed-off-by: Wolfram Sang
---
drivers/video/mxsfb.c |8
1 file changed, 8
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij (personally at LCE13)
Signed-off-by: Wolfram Sang
---
drivers/net/can/c_can/c_can_platform.c |7 ---
1
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij (personally at LCE13)
Signed-off-by: Wolfram Sang
---
drivers/net/ieee802154/mrf24j40.c |7 ---
1 file
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij (personally at LCE13)
Signed-off-by: Wolfram Sang
---
drivers/mtd/nand/atmel_nand.c |9 -
1 file
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij (personally at LCE13)
Signed-off-by: Wolfram Sang
---
drivers/tty/serial/atmel_serial.c |8
drivers
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij (personally at LCE13)
Signed-off-by: Wolfram Sang
---
drivers/gpu/drm/tilcdc/tilcdc_panel.c |6
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij (personally at LCE13)
Signed-off-by: Wolfram Sang
---
drivers/misc/atmel-ssc.c |8
1 file changed, 8
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij (personally at LCE13)
Signed-off-by: Wolfram Sang
---
drivers/pwm/pwm-mxs.c |6 --
drivers/pwm/pwm
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij (personally at LCE13)
Signed-off-by: Wolfram Sang
---
drivers/mtd/nand/gpmi-nand/gpmi-nand.c |9 -
1
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij (personally at LCE13)
Signed-off-by: Wolfram Sang
---
drivers/mmc/host/mvsdio.c |6 --
drivers
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij (personally at LCE13)
Signed-off-by: Wolfram Sang
---
drivers/i2c/busses/i2c-omap.c | 13 -
1 file
> Briefly looking into ACPI tables we have and mechanisms that we can
> use in ACPI case, I doubt we may apply all the ideas, probably some of
> them, though I didn't get yet where to read about in details. What I
> could say now is that the patch provided by Bin Gao is definitely no
> go.
Lauren
On Mon, Sep 16, 2013 at 02:51:18PM +0100, Mark Brown wrote:
> On Mon, Sep 16, 2013 at 02:44:35PM +0200, Linus Walleij wrote:
>
> > I've tried to fix this for DT-only I2C devices
> > and this very driver was the reason.
>
> > But a tiresome regression due to drivers relying on this
> > i2c_device
> So in the mean time are you happy with this "dummy" approach?
No. "dummy" is reserved for a dummy device in case an i2c slave needs
more than one address. The proper solution would be if
i2c_sysfs_new_device() could recognize the of_device_ids.
signature.asc
Description: Digital signature
On Tue, Sep 03, 2013 at 09:09:25AM +0900, Nguyen Viet Dung wrote:
> This patch modify I2C driver of rcar-H1 to usable on both rcar-H1 and rcar-H2.
>
> Signed-off-by: Nguyen Viet Dung
Applied to for-next, thanks!
signature.asc
Description: Digital signature
check to i2c_put_adapter
Wei Yongjun (1):
i2c: pnx: fix error return code in i2c_pnx_probe()
Wolfram Sang (6):
drivers/i2c/busses: don't use devm_pinctrl_get_select_default() in probe
drivers/i2c/busses: don't check resource with devm_ioremap_resource
i2c: powermac: fix re
On Wed, Aug 21, 2013 at 02:54:37PM +0530, Naveen Krishna Ch wrote:
> Adds support for High Speed I2C driver found in Exynos5 and
> later SoCs from Samsung.
>
> Highspeed mode is a minor change in the i2c protocol.
> Starts with
> 1. start condition,
> 2. 8-bit master ID code (1xxx)
> 3. follo
On Thu, Sep 12, 2013 at 01:04:55PM +0200, Rafael J. Wysocki wrote:
> On Thursday, September 12, 2013 12:43:02 PM Mika Westerberg wrote:
> > On Thu, Sep 12, 2013 at 10:31:45AM +0100, Mark Brown wrote:
> > > On Thu, Sep 12, 2013 at 12:27:43PM +0300, Mika Westerberg wrote:
> > > > On Wed, Sep 11, 2013
probe.
Signed-off-by: Wolfram Sang
---
drivers/spi/spi-s3c64xx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 512b889..3df81c6 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -1633,6 +1
probe.
Signed-off-by: Wolfram Sang
---
drivers/spi/spi-txx9.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-txx9.c b/drivers/spi/spi-txx9.c
index 7c6d157..c67a1b8 100644
--- a/drivers/spi/spi-txx9.c
+++ b/drivers/spi/spi-txx9.c
@@ -440,6 +440,7 @@ static int
probe.
Signed-off-by: Wolfram Sang
---
drivers/spi/spi-au1550.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-au1550.c b/drivers/spi/spi-au1550.c
index 1d00d9b3..313dd49 100644
--- a/drivers/spi/spi-au1550.c
+++ b/drivers/spi/spi-au1550.c
@@ -985,6 +985,
probe.
Signed-off-by: Wolfram Sang
---
drivers/spi/spi-omap-uwire.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-omap-uwire.c b/drivers/spi/spi-omap-uwire.c
index a6a8f09..9313fd3 100644
--- a/drivers/spi/spi-omap-uwire.c
+++ b/drivers/spi/spi-omap-uw
probe.
Signed-off-by: Wolfram Sang
---
drivers/spi/spi-bfin5xx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-bfin5xx.c b/drivers/spi/spi-bfin5xx.c
index 45bdf73..a563bd5 100644
--- a/drivers/spi/spi-bfin5xx.c
+++ b/drivers/spi/spi-bfin5xx.c
@@ -1
probe.
Signed-off-by: Wolfram Sang
Cc: Zhangfei Gao
---
drivers/i2c/busses/i2c-designware-platdrv.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c
b/drivers/i2c/busses/i2c-designware-platdrv.c
index 4c1b605..0aa0113 100644
--
ies is based on 3.12-rc4 and was compile-tested. It is available at
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
platform_driver_probe_drop
Regards,
Wolfram
Wolfram Sang (9):
i2c: i2c-designware-platdrv: replace platform_driver_probe to support
deferred probing
i
probe.
Signed-off-by: Wolfram Sang
Cc: Linus Walleij
---
drivers/i2c/busses/i2c-stu300.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/i2c/busses/i2c-stu300.c b/drivers/i2c/busses/i2c-stu300.c
index f8f6f2e..04a17b9 100644
--- a/drivers/i2c/busses/i2c
probe.
Signed-off-by: Wolfram Sang
Cc: Marek Vasut
---
drivers/i2c/busses/i2c-mxs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c
index f4a0167..b7c8577 100644
--- a/drivers/i2c/busses/i2c-mxs.c
+++ b/drivers
probe.
Signed-off-by: Wolfram Sang
Cc: ker...@pengutronix.de
---
drivers/i2c/busses/i2c-imx.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index ccf4665..1d7efa3 100644
--- a/drivers/i2c/busses/i2c-imx.
On Tue, Oct 08, 2013 at 03:51:50PM +0200, Ionut Nicu wrote:
> If the i2c-parent bus driver is not loaded, returning
> -EINVAL will force people to unload and then reload the
> module again to get it working.
>
> Signed-off-by: Ionut Nicu
Doesn't the non-DT case need fixing, too?
> ---
> driver
> > WS> Doesn't the non-DT case need fixing, too?
> >
> > Arguably yes.
>
> Yes, and it's also a one line fix. Should I do it in a separate
> patch or should I change this one and resubmit?
Resubmit please.
signature.asc
Description: Digital signature
On Mon, Oct 07, 2013 at 01:41:59PM +0300, Taras Kondratiuk wrote:
> Initially commit cb527ede1bf6ff2008a025606f25344b8ed7b4ac
> "i2c-omap: Double clear of ARDY status in IRQ handler"
> added a workaround for undocumented errata ProDB0017052.
> But then commit 1d7afc95946487945cc7f5019b41255b72224b7
ANDLE(&client->dev))
> + acpi_dev_pm_attach(&client->dev, true);
I'd prefer to drop the 'if's in case they are checked inside the acpi_*
calls anyway. Not a show-stopper, though, so:
Acked-by: Wolfram Sang
signature.asc
Description: Digital signature
On Thu, Oct 10, 2013 at 10:39:32AM +0200, Ionut Nicu wrote:
> Some gpio chips may have get/set operations that
> can sleep. For this type of chips we must use the
> _cansleep() version of gpio_set_value.
>
> Signed-off-by: Ionut Nicu
> ---
> drivers/i2c/muxes/i2c-mux-gpio.c | 11 ---
>
> > Changes since v3:
> >- Switch back to vendor specific DT properties regarding the anti-glitch
> > filter configuration, as this IP is the only one having such a filter.
> Do you agree to keep these properties vendor-specifics?
My preference is generic bindings. There are no other use
On Thu, Oct 10, 2013 at 10:46:41AM +0200, Lars-Peter Clausen wrote:
> > + if (gpio_cansleep(gpio))
> > + gpio_set_value_cansleep(gpio, val & (1 << i));
> > + else
> > + gpio_set_value(gpio, val & (1 << i));
>
> The proper way to do this is j
Hi,
> > What race condition?
> >
>
> Userspace trying to access the name attribute before it is created.
> See http://kroah.com/log/blog/2013/06/26/how-to-create-a-sysfs-file-correctly/
Thanks!
> > Have you tried this with two instances? I don't think it will work since
> > class_register modi
1 - 100 of 4396 matches
Mail list logo
