Re: [PATCH v4 00/17] media: blackfin: bfin_capture enhancements

2015-05-05 Thread Scott Jiang
2015-04-24 18:04 GMT+08:00 Hans Verkuil : > On 04/10/2015 12:42 PM, Scott Jiang wrote: >> Hi Hans, >> >>>> >>>> Hans, I tried to use v4l2-compliance but it failed to compile. Sorry >>>> for telling you it have passed compilation because I forg

Re: [PATCH 1/7] v4l2: replace enum_mbus_fmt by enum_mbus_code

2015-04-16 Thread Scott Jiang
2015-04-09 18:21 GMT+08:00 Hans Verkuil : > From: Hans Verkuil > > Replace all calls to the enum_mbus_fmt video op by the pad > enum_mbus_code op and remove the duplicate video op. > > Signed-off-by: Hans Verkuil > Cc: Guennadi Liakhovetski > Cc: Scott Jiang > Cc: J

Re: [PATCH 5/7] v4l2: replace try_mbus_fmt by set_fmt in bridge drivers

2015-04-16 Thread Scott Jiang
2015-04-09 18:21 GMT+08:00 Hans Verkuil : > From: Hans Verkuil > > Replace all calls to try_mbus_fmt in bridge drivers by calls to the > set_fmt pad op. > > Signed-off-by: Hans Verkuil > Cc: Guennadi Liakhovetski > Cc: Scott Jiang > Cc: Jonathan Corbet > --

Re: [PATCH 6/7] v4l2: replace s_mbus_fmt by set_fmt in bridge drivers

2015-04-16 Thread Scott Jiang
Guennadi Liakhovetski > Cc: Prabhakar Lad > Cc: Scott Jiang > Cc: Jonathan Corbet > --- > drivers/media/platform/blackfin/bfin_capture.c | 8 +-- Acked-by: Scott Jiang -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a mess

Re: [PATCH v4 00/17] media: blackfin: bfin_capture enhancements

2015-03-26 Thread Scott Jiang
capture: drop bcap_get_unmapped_area() > media: blackfin: bfin_capture: embed video_device struct in > bcap_device > > drivers/media/platform/blackfin/bfin_capture.c | 348 > ++++----- > 1 file changed, 103 insertions(+), 245 deletions(-) > for patch

Re: [PATCH v3 00/15] media: blackfin: bfin_capture enhancements

2015-03-05 Thread Scott Jiang
Hi Hans, > > On Tue, Mar 3, 2015 at 9:39 AM, Hans Verkuil wrote: >> On 03/03/2015 10:30 AM, Lad, Prabhakar wrote: >>> Hi Hans, >>> >>> On Tue, Mar 3, 2015 at 8:49 AM, Hans Verkuil wrote: >>>> On 03/02/2015 08:57 AM, Scott Jiang wrote: >>&

Re: [PATCH v3 00/15] media: blackfin: bfin_capture enhancements

2015-03-01 Thread Scott Jiang
bfin_capture: add support for VIDIOC_EXPBUF > media: blackfin: bfin_capture: set v4l2 buffer sequence > > drivers/media/platform/blackfin/bfin_capture.c | 306 > ++++----- > 1 file changed, 94 insertions(+), 212 deletions(-) > > -- For all these patches, Acked-by

Re: [PATCH v2 08/15] media: blackfin: bfin_capture: use vb2_ioctl_* helpers

2015-02-03 Thread Scott Jiang
Hi Lad, 2015-01-23 6:18 GMT+08:00 Lad, Prabhakar : > this patch adds support to vb2_ioctl_* helpers. > > Signed-off-by: Lad, Prabhakar > --- > drivers/media/platform/blackfin/bfin_capture.c | 108 > ++--- > 1 file changed, 23 insertions(+), 85 deletions(-) > > diff --git a/d

Re: [PATCH v2 00/15] media: blackfin: bfin_capture enhancements

2015-02-03 Thread Scott Jiang
Hi Hans, >> On Thu, Jan 22, 2015 at 10:18 PM, Lad, Prabhakar >> wrote: >>> This patch series, enhances blackfin capture driver with >>> vb2 helpers. >>> >>> Changes for v2: >>> -- >>> Only patches 5/15 and 8/15 as per Scott's suggestions. >>> >>> Lad, Prabhakar (15): >>> media: bla

Re: [PATCH 00/15] media: blackfin: bfin_capture enhancements

2015-01-21 Thread Scott Jiang
Hi Lad, >> >> Although I was on holiday but couldn't resist myself from working, >> since I was away from my hardware I had to choose a different one, >> blackfin driver was lucky one. Since I don't have the blackfin >> board I haven't tested them on the actual board, but just compile >> tested, C

Re: [PATCH 08/15] media: blackfin: bfin_capture: use vb2_ioctl_* helpers

2015-01-21 Thread Scott Jiang
2014-12-20 18:47 GMT+08:00 Lad, Prabhakar : > this patch adds support to vb2_ioctl_* helpers. > > Signed-off-by: Lad, Prabhakar > --- > drivers/media/platform/blackfin/bfin_capture.c | 107 > + > 1 file changed, 22 insertions(+), 85 deletions(-) > > diff --git a/drivers/m

Re: [PATCH 05/15] media: blackfin: bfin_capture: improve queue_setup() callback

2015-01-21 Thread Scott Jiang
2014-12-20 18:47 GMT+08:00 Lad, Prabhakar : > this patch improves the queue_setup() callback. > > Signed-off-by: Lad, Prabhakar > --- > drivers/media/platform/blackfin/bfin_capture.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/platform/blackfi

Re: [PATCH 00/15] media: blackfin: bfin_capture enhancements

2014-12-25 Thread Scott Jiang
Hi Lad, I'm on holiday these days. I will test these patches later. Thanks, Scott 2014-12-20 18:47 GMT+08:00 Lad, Prabhakar : > Hi Scott, > > Although I was on holiday but couldn't resist myself from working, > since I was away from my hardware I had to choose a different one, > blackfin driver

Re: [PATCH 3/3] v4l2: blackfin: select proper pinctrl state in ppi_set_params if CONFIG_PINCTRL is enabled

2014-07-24 Thread Scott Jiang
2014-07-23 17:57 GMT+08:00 Sonic Zhang : > From: Sonic Zhang > > Multiple pinctrl states are defined for 8, 16 and 24 data pin groups in PPI > peripheral. > The driver should select correct group before set up further PPI parameters. > > Signed-off-by: Sonic Zhang Acked-b

Re: [PATCH 2/3] v4l2: bfin: Ensure delete and reinit list entry on NOMMU architecture

2014-07-24 Thread Scott Jiang
2014-07-23 17:57 GMT+08:00 Sonic Zhang : > From: Sonic Zhang > > On NOMMU architecture page fault is not triggered if a deleted list entry is > accessed without reinit. > > Signed-off-by: Sonic Zhang Acked-by: Scott Jiang -- To unsubscribe from this list: send the line "

Re: [PATCH 1/3] media: blackfin: ppi: Pass device pointer to request peripheral pins

2014-07-24 Thread Scott Jiang
2014-07-23 17:57 GMT+08:00 Sonic Zhang : > From: Sonic Zhang > > if the pinctrl driver is enabled. > > Signed-off-by: Sonic Zhang Acked-by: Scott Jiang -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.

[PATCH] v4l2: don't warn before we release buffer

2014-07-22 Thread Scott Jiang
In fact we only need to give a warning if the driver still use the buffer after we release all queued buffers. Signed-off-by: Scott Jiang --- drivers/media/v4l2-core/videobuf2-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c

Re: [PATCH v2 14/48] media: bfin_capture: Switch to pad-level DV operations

2014-03-13 Thread Scott Jiang
2014-03-11 7:15 GMT+08:00 Laurent Pinchart : > The video-level enum_dv_timings and dv_timings_cap operations are > deprecated in favor of the pad-level versions. All subdev drivers > implement the pad-level versions, switch to them. > > Cc: Scott Jiang > Signed-off-by

Re: [PATCH] v4l: vs6624: Fix warning due to unused function

2013-12-01 Thread Scott Jiang
t; @@ -515,6 +516,7 @@ static int vs6624_read(struct v4l2_subdev *sd, u16 index) > > return buf[0]; > } > +#endif > > static int vs6624_write(struct v4l2_subdev *sd, u16 index, > u8 value) Acked-by: Scott Jiang -- To un

Re: [RFC PATCH 1/3] adv7842: add new video decoder driver.

2013-08-16 Thread Scott Jiang
> + > +static int adv7842_g_mbus_fmt(struct v4l2_subdev *sd, > + struct v4l2_mbus_framefmt *fmt) > +{ > + struct adv7842_state *state = to_state(sd); > + > + fmt->width = state->timings.bt.width; > + fmt->height = state->timings.bt.height; > + fmt

Re: [RFC PATCH 6/8] v4l2: use new V4L2_DV_BT_BLANKING/FRAME defines

2013-07-31 Thread Scott Jiang
2013/7/29 Hans Verkuil : > From: Hans Verkuil > > Use the new defines to calculate the full blanking and frame sizes. > > Signed-off-by: Hans Verkuil > Cc: Lad, Prabhakar > Cc: Scott Jiang > --- > drivers/media/platform/blackfin/bfin_capture.c | 9 ++--- &

[PATCH RFC v4 0/1] [media] blackfin: add video display device driver

2013-07-18 Thread Scott Jiang
v4l2-compliance output for this driver root:/> v4l2-compliance -d 0 Driver Info:bfin_display bfin_display.0: = START STATUS = Driver name : bfin_display Card type : BF609 Bus info : platform:bfin_display Driver version:

[PATCH RFC v4 1/1] [media] blackfin: add video display device driver

2013-07-18 Thread Scott Jiang
This is a V4L2 driver for Blackfin video display (E)PPI interface. This module is common for BF537/BF561/BF548/BF609. Signed-off-by: Scott Jiang --- drivers/media/platform/blackfin/Kconfig| 15 +- drivers/media/platform/blackfin/Makefile |1 + drivers/media/platform/blackfin

Re: [REVIEW PATCH 2/3] bfin_capture: fix compiler warning

2013-06-26 Thread Scott Jiang
red with attribute > warn_unused_result [-Wunused-result] > vb2_queue_init(q); > ^ > > Signed-off-by: Hans Verkuil > Cc: Scott Jiang > --- > drivers/media/platform/blackfin/bfin_capture.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >

[PATCH RFC v3] [media] blackfin: add video display device driver

2013-06-04 Thread Scott Jiang
This is a V4L2 driver for Blackfin video display (E)PPI interface. This module is common for BF537/BF561/BF548/BF609. Signed-off-by: Scott Jiang --- drivers/media/platform/blackfin/Kconfig| 15 +- drivers/media/platform/blackfin/Makefile |1 + drivers/media/platform/blackfin

Re: [PATCHv1 02/38] v4l2: remove g_chip_ident from bridge drivers where it is easy to do so.

2013-05-31 Thread Scott Jiang
ans Verkuil > Cc: Mauro Carvalho Chehab > Cc: st...@linuxtv.org > Cc: Scott Jiang > Cc: Lad, Prabhakar > Cc: Guennadi Liakhovetski > Cc: Jonathan Corbet > Cc: Ezequiel Garcia > Cc: Devin Heitmueller > Cc: Andrey Smirnov > --- > drivers/media/platform/blackf

Re: [RFC PATCH 01/14] adv7183: fix querystd

2013-05-31 Thread Scott Jiang
-off-by: Hans Verkuil > Cc: Scott Jiang > --- > drivers/media/i2c/adv7183.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > Acked-by: Scott Jiang -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message

Re: [PATCH v2] [media] blackfin: fix error return code in bcap_probe()

2013-05-13 Thread Scott Jiang
v) > } else { > v4l2_err(&bcap_dev->v4l2_dev, > "Unable to register sub device\n"); > + ret = -ENODEV; > goto err_unreg_vdev; > } > > Acked-by: Scott Jiang -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [media] blackfin: fix error return code in bcap_probe()

2013-05-13 Thread Scott Jiang
Hi Wei Yongjun, > drivers/media/platform/blackfin/bfin_capture.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/platform/blackfin/bfin_capture.c > b/drivers/media/platform/blackfin/bfin_capture.c > index 0e55b08..2d1e032 100644 > --- a/drivers/media/platform/blackfin/bf

[PATCH RFC v2] [media] blackfin: add video display device driver

2013-04-28 Thread Scott Jiang
This is a V4L2 driver for Blackfin video display (E)PPI interface. This module is common for BF537/BF561/BF548/BF609. Signed-off-by: Scott Jiang --- drivers/media/platform/blackfin/Kconfig| 15 +- drivers/media/platform/blackfin/Makefile |1 + drivers/media/platform/blackfin

Re: [PATCH RFC] [media] blackfin: add video display driver

2013-04-24 Thread Scott Jiang
Hi Sylwester, > >> + struct v4l2_device v4l2_dev; >> + /* v4l2 control handler */ >> + struct v4l2_ctrl_handler ctrl_handler; > > > This handler seems to be unused, I couldn't find any code adding controls > to it. Any initialization of this handler is a dead code now. You probab

Re: [PATCH RFC] [media] blackfin: add video display driver

2013-04-16 Thread Scott Jiang
Hi Sylwester , >> @@ -9,7 +9,18 @@ config VIDEO_BLACKFIN_CAPTURE >> To compile this driver as a module, choose M here: the >> module will be called bfin_capture. >> >> +config VIDEO_BLACKFIN_DISPLAY >> + tristate "Blackfin Video Display Driver" >> + depends on VIDEO

Re: [PATCH RFC] [media] blackfin: add video display driver

2013-04-16 Thread Scott Jiang
Hi Hans, >> +/* >> + * Analog Devices video display driver >> + * >> + * Copyright (c) 2011 Analog Devices Inc. > > Analog Devices? What has this to do with Analog Devices? > I wrote this driver for Analog Devices Blackfin. >> + >> +static int disp_mmap(struct file *file, struct vm_area_struct *

Re: [PATCH 1/2] [media] blackfin: add display support in ppi driver

2013-04-14 Thread Scott Jiang
2013/4/12 Hans Verkuil : > On Sat April 13 2013 01:52:57 Scott Jiang wrote: >> Signed-off-by: Scott Jiang > > Is it OK if I postpone these two patches for 3.11? They don't make sense > AFAICT without the new display driver, and that will definitely not make it > fo

[PATCH RFC] [media] blackfin: add video display driver

2013-04-12 Thread Scott Jiang
This is a bridge driver for blackfin diplay device. It can work with ppi or eppi interface. DV timings are supported. Signed-off-by: Scott Jiang --- drivers/media/platform/blackfin/Kconfig| 15 +- drivers/media/platform/blackfin/Makefile |1 + drivers/media/platform/blackfin

[PATCH 1/2] [media] blackfin: add display support in ppi driver

2013-04-12 Thread Scott Jiang
Signed-off-by: Scott Jiang --- drivers/media/platform/blackfin/ppi.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/media/platform/blackfin/ppi.c b/drivers/media/platform/blackfin/ppi.c index 01b5b50..15e9c2b 100644 --- a/drivers/media/platform

[PATCH 2/2] [media] bfin_capture: add query_dv_timings/enum_dv_timings support

2013-04-12 Thread Scott Jiang
More dv_timings ioctl ops are introduced in video core. Add query_dv_timings/enum_dv_timings accordingly. Signed-off-by: Scott Jiang --- drivers/media/platform/blackfin/bfin_capture.c | 28 ++-- 1 files changed, 21 insertions(+), 7 deletions(-) diff --git a/drivers/media

Re: [PATCH RFC] [media] add Aptina mt9m114 HD digital image sensor driver

2013-04-07 Thread Scott Jiang
Hi Laurent, >> >> >> +struct mt9m114_reg { >> >> >> + u16 reg; >> >> >> + u32 val; >> >> >> + int width; >> >> >> +}; >> >> >> + >> >> >> +enum { >> >> >> + MT9M114_QVGA, >> >> >> + MT9M114_VGA, >> >> >> + MT9M114_WVGA, >> >> >> + MT9M114_720P, >> >> >> +}; >> >> > >> >

Re: [PATCH RFC] [media] add Aptina mt9m114 HD digital image sensor driver

2013-04-01 Thread Scott Jiang
Hi Laurent, >> > >> >> +struct mt9m114_reg { >> >> + u16 reg; >> >> + u32 val; >> >> + int width; >> >> +}; >> >> + >> >> +enum { >> >> + MT9M114_QVGA, >> >> + MT9M114_VGA, >> >> + MT9M114_WVGA, >> >> + MT9M114_720P, >> >> +}; >> > >> > This is the part I don't like. In

Re: [PATCH RFC] [media] add Aptina mt9m114 HD digital image sensor driver

2013-03-28 Thread Scott Jiang
>> This driver support parallel data output mode and >> QVGA/VGA/WVGA/720P resolution. You can select YCbCr and RGB565 >> output format. > > What host bridge do you use this driver with ? > I only tested with blackfin. > >> + */ > > [snip] > >> +struct mt9m114_reg { >> + u16 reg; >> + u32

[PATCH] [media] dma-mapping: enable no mmu support in dma_common_mmap

2013-03-05 Thread Scott Jiang
No MMU systems also make use of this function to do mmap. Signed-off-by: Scott Jiang --- drivers/base/dma-mapping.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/base/dma-mapping.c b/drivers/base/dma-mapping.c index 0ce39a3..ae655b2 100644 --- a/drivers/base

Re: [RFC PATCH 07/18] blackfin: replace V4L2_IN/OUT_CAP_CUSTOM_TIMINGS by DV_TIMINGS

2013-02-16 Thread Scott Jiang
INGS defines might be removed. > > Signed-off-by: Hans Verkuil > Cc: Scott Jiang Acked-by: Scott Jiang > --- > arch/blackfin/mach-bf609/boards/ezkit.c|8 > drivers/media/platform/blackfin/bfin_capture.c |4 ++-- > 2 files changed, 6 insertions(+), 6 d

[PATCH RFC] [media] add Aptina mt9m114 HD digital image sensor driver

2013-01-18 Thread Scott Jiang
This driver support parallel data output mode and QVGA/VGA/WVGA/720P resolution. You can select YCbCr and RGB565 output format. Signed-off-by: Scott Jiang --- drivers/media/i2c/Kconfig | 10 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/mt9m114.c | 1055

[PATCH 1/2] [media] add maintainer for blackfin media drivers

2013-01-18 Thread Scott Jiang
Signed-off-by: Scott Jiang --- MAINTAINERS |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index c5de529..e7ca531 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1652,6 +1652,15 @@ W: http://blackfin.uclinux.org/ S: Supported

[PATCH 2/2] [media] blackfin: add error frame support

2013-01-18 Thread Scott Jiang
Mark current frame as error frame when ppi error interrupt report fifo error. Member next_frm in struct bcap_device can be optimized out. Signed-off-by: Scott Jiang --- drivers/media/platform/blackfin/bfin_capture.c | 37 +--- drivers/media/platform/blackfin/ppi.c

Re: [PATCH] [media] blackfin Kconfig: select is evil; use, instead depends on

2012-12-31 Thread Scott Jiang
2012/12/28 Mauro Carvalho Chehab : > Select is evil as it has issues with dependencies. Better to convert > it to use depends on. > > That fixes a breakage with out-of-tree compilation of the media > tree. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/platform/blackfin/Kconfig |

[PATCH 1/2] v4l2: blackfin: convert ppi driver to a module

2012-11-19 Thread Scott Jiang
Other drivers can make use of it. Signed-off-by: Scott Jiang --- drivers/media/platform/blackfin/Kconfig |6 +- drivers/media/platform/blackfin/Makefile |4 ++-- drivers/media/platform/blackfin/ppi.c|7 +++ 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a

[PATCH 2/2] v4l2: blackfin: add EPPI3 support

2012-11-19 Thread Scott Jiang
Bf60x soc has a new PPI called Enhanced PPI version 3. HD video is supported now. To achieve this, we redesign ppi params and add dv timings feature. Signed-off-by: Scott Jiang --- drivers/media/platform/blackfin/bfin_capture.c | 148 +--- drivers/media/platform/blackfin

Re: [PATCH] i2c: adv7183: use module_i2c_driver to simplify the code

2012-10-08 Thread Scott Jiang
2012/10/8 Wei Yongjun : > From: Wei Yongjun > > Use the module_i2c_driver() macro to make the code smaller > and a bit simpler. > > dpatch engine is used to auto generate this patch. > (https://github.com/weiyj/dpatch) > > Signed-off-by: Wei Yongjun Acked-by: Sco

Re: [PATCH] i2c: vs6624: use module_i2c_driver to simplify the code

2012-10-08 Thread Scott Jiang
2012/10/8 Wei Yongjun : > From: Wei Yongjun > > Use the module_i2c_driver() macro to make the code smaller > and a bit simpler. > > dpatch engine is used to auto generate this patch. > (https://github.com/weiyj/dpatch) > > Signed-off-by: Wei Yongjun Acked-by: Sco

Re: [PATCH] nommu: remap_pfn_range: fix addr parameter check

2012-09-16 Thread Scott Jiang
>> I was using 3.3 linux kernel. I will again check if videobuf2 in 3.5 has >> already >> fixed this issue. > > [snip..] > > Ok I just checked the vb2_dma_contig allocator and it has no major changes > from my version, > http://lxr.linux.no/linux+v3.5.3/drivers/media/video/videobuf2-dma-contig.c#

Re: [PATCH] nommu: remap_pfn_range: fix addr parameter check

2012-09-14 Thread Scott Jiang
> Yes, the MMU version of remap_pfn_range() does permit non-page-aligned > `addr' (at least, if the userspace maaping is a non-COW one). But I > suspect that was an implementation accident - it is a nonsensical thing > to do, isn't it? The MMU cannot map a bunch of kernel pages onto a > non-page-

Re: Using MMAP calls on a video capture device having underlying NOMMU arch

2012-09-12 Thread Scott Jiang
> > Now, I see that the requested videobuffers are correctly allocated via > 'vb2_dma_contig_alloc' > call (see [3] for reference). But the MMAP call fails in > 'vb2_dma_contig_alloc' function > in mm/nommu.c (see [4] for reference) when it tries to make the following > check: > > if (ad

Re: [RFCv3 PATCH 26/33] videobuf2-core: add helper functions.

2012-06-28 Thread Scott Jiang
> +int vb2_fop_mmap(struct file *file, struct vm_area_struct *vma) > +{ > +       struct video_device *vdev = video_devdata(file); > + > +       return vb2_mmap(vdev->queue, vma); > +} > +EXPORT_SYMBOL_GPL(vb2_fop_mmap); Missed one file ops. #ifndef CONFIG_MMU unsigned long vb2_fop_get_unmapped_ar

Re: About s_std_output

2012-06-27 Thread Scott Jiang
2012/6/27 Hans Verkuil : > On Wed 27 June 2012 11:37:24 Scott Jiang wrote: >> Hi Hans, >> >> I noticed there are two s_std ops in core and video for output. And >> some drivers call video->s_std_out and then core->s_std in their S_STD >> iotcl. Coul

About s_std_output

2012-06-27 Thread Scott Jiang
Hi Hans, I noticed there are two s_std ops in core and video for output. And some drivers call video->s_std_out and then core->s_std in their S_STD iotcl. Could anyone share me the story why we have s_std_output/g_std_output/g_tvnorms_output ops in video instead of making use of s_std/g_std in cor

Re: extend v4l2_mbus_framefmt

2012-06-20 Thread Scott Jiang
> I would expect that the combination of v4l2_mbus_framefmt + > v4l2_dv_timings > gives you the information you need. > I can solve this problem in HD, but how about SD? Add a fake dv_timings ops in SD decoder driver? >>> >>> No, you add g/s_std instead. SD timings ar

Re: extend v4l2_mbus_framefmt

2012-06-13 Thread Scott Jiang
>> >> > I would expect that the combination of v4l2_mbus_framefmt + v4l2_dv_timings >> > gives you the information you need. >> > >> I can solve this problem in HD, but how about SD? Add a fake >> dv_timings ops in SD decoder driver? >> > > No, you add g/s_std instead. SD timings are set through th

Re: extend v4l2_mbus_framefmt

2012-06-12 Thread Scott Jiang
Hi Hans, > I would expect that the combination of v4l2_mbus_framefmt + v4l2_dv_timings > gives you the information you need. > I can solve this problem in HD, but how about SD? Add a fake dv_timings ops in SD decoder driver? -- To unsubscribe from this list: send the line "unsubscribe linux-media"

Re: extend v4l2_mbus_framefmt

2012-06-11 Thread Scott Jiang
Hi Hans, > I would expect that the combination of v4l2_mbus_framefmt + v4l2_dv_timings > gives you the information you need. About v4l2_mbus_framefmt, you use V4L2_MBUS_FMT_FIXED. I guess you can't find any yuv 24 or rgb 16/24bit format in current v4l2_mbus_framefmt. But a bridge driver working w

extend v4l2_mbus_framefmt

2012-06-11 Thread Scott Jiang
Hi Guennadi and Hans, We use v4l2_mbus_framefmt to get frame format on the media bus in bridge driver. It only contains width and height. It's not a big problem in SD. But we need more info like front porch, sync width and back porch (similar to disp_format_s in v4l2_formats.h) in HD. I want to ad

Re: Firmware blob in vs6624 driver

2012-05-28 Thread Scott Jiang
Hi Ben, > This doesn't touch any of the documented registers, so presumably it's a > patch to the firmware loaded from non-volatile memory.  Unless you can > provide source code for the patch, this should go in the linux-firmware > repository and be loaded with request_firmware() instead of embedd

How to implement i2c map device

2012-04-26 Thread Scott Jiang
Hi Laurent, I'm writing a driver for adv7842 video decoder. This chip has 12 i2c register maps. IO map is fixed to 0x20 and others are configurable. I plan to use 0x20 as the subdevice addr to call v4l2_i2c_new_subdev_board, and call i2c_new_device and i2c_add_driver in i2c_probe to enumerate othe

[PATCH 2/3 v3] [FOR 3.3] v4l2: add vs6624 sensor driver

2012-03-08 Thread Scott Jiang
This is a v4l2 sensor-level driver for the ST VS6624 camera. Signed-off-by: Scott Jiang --- drivers/media/video/Kconfig | 10 + drivers/media/video/Makefile |1 + drivers/media/video/vs6624.c | 928 + drivers/media/video/vs6624_regs.h

[PATCH 3/3 v3] [FOR 3.3] v4l2: add blackfin capture bridge driver

2012-03-08 Thread Scott Jiang
This is a v4l2 bridge driver for Blackfin video capture device, support ppi and eppi interface. Signed-off-by: Scott Jiang --- drivers/media/video/Kconfig |2 + drivers/media/video/Makefile|2 + drivers/media/video/blackfin/Kconfig| 10

[PATCH 1/3 v3] [FOR 3.3] v4l: add adv7183 decoder driver

2012-03-08 Thread Scott Jiang
This driver is a v4l2 subdevice driver to support Analog Devices ADV7183 SDTV video decoder. Signed-off-by: Scott Jiang --- drivers/media/video/Kconfig| 10 + drivers/media/video/Makefile |1 + drivers/media/video/adv7183.c | 699

Re: subdev support for querying struct v4l2_input *

2012-01-04 Thread Scott Jiang
2012/1/5 Steven Toth : > Hans, > > In the cx23885 driver as part of vidioc_enum_input call, I have a need > to return V4L2_IN_ST_NO_SIGNAL in the status > field as part of struct v4l2_input. Thus, when no signal is detected > by the video decoder it can be signalled to the calling application. > v4

Re: [PATCH] v4l2: v4l2-fh: v4l2_fh_is_singular should use list head to test

2012-01-04 Thread Scott Jiang
2012/1/4 Sakari Ailus : > Hi Scott, > > Thanks for the patch. > > On Wed, Dec 21, 2011 at 10:30:54AM -0500, Scott Jiang wrote: >> list_is_singular accepts a list head to test whether a list has just one >> entry. >> fh->list is the entry, fh->vdev->fh_

Re: v4l: how to get blanking clock count?

2012-01-04 Thread Scott Jiang
>> If I disable this interrupt, other errors like fifo underflow are ignored. >> Perhaps I can add a parameter in platform data to let user decide to >> register this interrupt or not. > > I think a more generic solution would be preferrable. If that causes > ignoring real errors, that's of course

Re: v4l: how to get blanking clock count?

2012-01-04 Thread Scott Jiang
2012/1/4 Sakari Ailus : > Hi Scott, > > On Wed, Jan 04, 2012 at 01:50:17PM +0800, Scott Jiang wrote: >> >> I the case of your bridge, that may not be possible, but that's the only >> >> one >> >> I've heard of so I think it's definitel

Re: v4l: how to get blanking clock count?

2012-01-03 Thread Scott Jiang
>> I the case of your bridge, that may not be possible, but that's the only one >> I've heard of so I think it's definitely a special case. In that case the >> sensor driver can't be allowed to change the blanking periods while >> streaming is ongoing. > > I agree, it's just a matter of adding prop

Re: v4l: how to get blanking clock count?

2011-12-30 Thread Scott Jiang
2011/12/31 Sakari Ailus : > Hi Scott, > > On Fri, Dec 30, 2011 at 03:20:43PM +0800, Scott Jiang wrote: >> Hi Hans and Guennadi, >> >> Our bridge driver needs to know line clock count including active >> lines and blanking area. >> I can compute active clock c

v4l: how to get blanking clock count?

2011-12-29 Thread Scott Jiang
Hi Hans and Guennadi, Our bridge driver needs to know line clock count including active lines and blanking area. I can compute active clock count according to pixel format, but how can I get this in blanking area in current framework? Thanks, Scott -- To unsubscribe from this list: send the line

[PATCH] v4l2: v4l2-fh: v4l2_fh_is_singular should use list head to test

2011-12-20 Thread Scott Jiang
list_is_singular accepts a list head to test whether a list has just one entry. fh->list is the entry, fh->vdev->fh_list is the list head. Signed-off-by: Scott Jiang --- drivers/media/video/v4l2-fh.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/me

about v4l2_fh_is_singular

2011-12-20 Thread Scott Jiang
Hi Sakari, Hans recommends me using v4l2_fh_is_singular in first open, but I found it used list_is_singular(&fh->list). Should it use &fh->vdev->fh_list or I missed something? Regards, Scott -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majo

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-16 Thread Scott Jiang
>> How about this implementation? I know it's not for soc, but I post it >> to give my idea. >> Bridge knows the layout, so it doesn't need to query the subdevice. > > Where from? AFAIU, we are talking here about subdevice inputs, right? In > this case about various inputs of the TV decoder. How sh

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-16 Thread Scott Jiang
Hi Guennadi, > First question: you probably also want to patch soc_camera_g_input() and > soc_camera_enum_input(). But no, I do not know how. The video subdevice > operations do not seem to provide a way to query subdevice routing > capabilities, so, I've got no idea how we're supposed to support

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-16 Thread Scott Jiang
2011/12/16 Javier Martin : > Some v4l-subdevs such as tvp5150 have multiple > inputs. This patch allows the user of a soc-camera > device to select between them. > > Signed-off-by: Javier Martin > --- >  drivers/media/video/soc_camera.c |    6 +++--- >  1 files changed, 3 insertions(+), 3 deletion

Re: v4l: How bridge driver get subdev std?

2011-12-15 Thread Scott Jiang
2011/12/15 Hans Verkuil : > On Thursday, December 15, 2011 10:48:39 Scott Jiang wrote: >> Hi Hans and Guennadi, >> >> I'm wondering how does bridge driver get subdev std (not query)? >> My case is that bridge needs to get subdev default std. > > It can just c

v4l: How bridge driver get subdev std?

2011-12-15 Thread Scott Jiang
Hi Hans and Guennadi, I'm wondering how does bridge driver get subdev std (not query)? My case is that bridge needs to get subdev default std. Regards, Scott -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majord

Re: [PATCH 4/4 v2][FOR 3.1] v4l2: add blackfin capture bridge driver

2011-09-27 Thread Scott Jiang
> > What you would typically do in a case like this (if I understand it > correctly) is that in the s_input ioctl you first select the input in the > subdev, and then you can call the subdev to determine the standard and > format and use that information to set up the bridge. This requires that > t

Re: [PATCH 4/4 v2][FOR 3.1] v4l2: add blackfin capture bridge driver

2011-09-27 Thread Scott Jiang
> >> +             ret = v4l2_subdev_call(bcap_dev->sd, video, >> +                                     g_mbus_fmt, &mbus_fmt); >> +             if (ret < 0) >> +                     return ret; >> + >> +             for (i = 0; i < BCAP_MAX_FMTS; i++) { >> +                     if (mbus_fmt.code !

Re: New SOC Camera hardware

2011-09-26 Thread Scott Jiang
2011/9/27 Gilles : > Scott, > > A late echo. I am just now getting into the heart of this project and realize > I missed your answer here from back in August. Just grabbed the trunk from > the repo and trying to compile it. > > I'm not sure I understand why it would work with one sensor driver an

Re: Problems cloning the git repostories

2011-09-26 Thread Scott Jiang
2011/9/26 Mauro Carvalho Chehab : > Em 25-09-2011 15:03, Johannes Stezenbach escreveu: >> On Sun, Sep 25, 2011 at 07:33:57AM -0500, Patrick Dickey wrote: >>> >>> I tried to follow the steps for cloning both the "media_tree.git" and >>> "media_build.git" repositories, and received errors for both.  

[PATCH 2/4 v2][FOR 3.1] v4l2: add adv7183 decoder driver

2011-09-19 Thread Scott Jiang
this driver is a v4l2 subdevice driver to support Analog Devices ADV7183 SDTV video decoder Signed-off-by: Scott Jiang --- drivers/media/video/Kconfig| 10 + drivers/media/video/Makefile |1 + drivers/media/video/adv7183.c | 686

[PATCH 3/4 v2][FOR 3.1] v4l2: add vs6624 sensor driver

2011-09-19 Thread Scott Jiang
this is a v4l2 sensor-level driver for the ST VS6624 camera Signed-off-by: Scott Jiang --- drivers/media/video/Kconfig | 10 + drivers/media/video/Makefile |1 + drivers/media/video/vs6624.c | 930 + drivers/media/video/vs6624_regs.h

[PATCH 1/4 v2][FOR 3.1] v4l2: add vb2_get_unmapped_area in vb2 core

2011-09-19 Thread Scott Jiang
no mmu system needs get_unmapped_area file operations to do mmap Signed-off-by: Scott Jiang --- drivers/media/video/videobuf2-core.c | 31 +++ include/media/videobuf2-core.h |7 +++ 2 files changed, 38 insertions(+), 0 deletions(-) diff --git a

[PATCH 4/4 v2][FOR 3.1] v4l2: add blackfin capture bridge driver

2011-09-19 Thread Scott Jiang
this is a v4l2 bridge driver for Blackfin video capture device, support ppi interface Signed-off-by: Scott Jiang --- drivers/media/video/Kconfig |2 + drivers/media/video/Makefile|2 + drivers/media/video/blackfin/Kconfig| 10 + drivers/media

Re: [PATCH 4/4] v4l2: add blackfin capture bridge driver

2011-09-16 Thread Scott Jiang
2011/9/13 Guennadi Liakhovetski : > On Tue, 13 Sep 2011, Scott Jiang wrote: > >> >> + >> >> +struct bcap_format { >> >> +     u8 *desc; >> >> +     u32 pixelformat; >> >> +     enum v4l2_mbus_pixelcode mbus_code; >> >>

Re: [PATCH 4/4] v4l2: add blackfin capture bridge driver

2011-09-15 Thread Scott Jiang
2011/9/16 Sylwester Nawrocki : > On 09/15/2011 04:40 AM, Scott Jiang wrote: >> 2011/9/14 Sylwester Nawrocki: >>> On 09/14/2011 09:10 AM, Scott Jiang wrote: >>>> >>>>>> +                     fmt =&bcap_fo

Re: [PATCH 4/4] v4l2: add blackfin capture bridge driver

2011-09-15 Thread Scott Jiang
>> I have considered using soc, but it can't support decoder when I began >> to write this driver in 2.6.38. > > soc_mediabus.c is a stand-alone module, it has no dependencies on > soc-camera. > > Out of interest - what kind of decoder you mean? A tv-decoder? We do have > a tv-decoder driver tw9910

Re: [PATCH 4/4] v4l2: add blackfin capture bridge driver

2011-09-14 Thread Scott Jiang
2011/9/15 Guennadi Liakhovetski : > On Thu, 15 Sep 2011, Scott Jiang wrote: > >> accually this array is to convert mbus to pixformat. ppi supports any >> formats. > > You mean, it doesn't distinguish formats? It just packs bytes in RAM > exactly as it ready them f

Re: [PATCH 4/4] v4l2: add blackfin capture bridge driver

2011-09-14 Thread Scott Jiang
> >> + >> +#define CAPTURE_DRV_NAME        "bfin_capture" >> +#define BCAP_MIN_NUM_BUF        2 >> + >> +struct bcap_format { >> +     u8 *desc; >> +     u32 pixelformat; >> +     enum v4l2_mbus_pixelcode mbus_code; >> +     int bpp; /* bytes per pixel */ > > Don't you think you might have to proce

Re: [PATCH 4/4] v4l2: add blackfin capture bridge driver

2011-09-14 Thread Scott Jiang
2011/9/14 Sylwester Nawrocki : > On 09/14/2011 09:10 AM, Scott Jiang wrote: >>>> +static int bcap_qbuf(struct file *file, void *priv, >>>> +                     struct v4l2_buffer *buf) >>>> +{ >>>> +     struct bcap_device *bcap_dev = video_

Re: Asking advice for Camera/ISP driver framework design

2011-09-14 Thread Scott Jiang
2011/9/14 Cliff Cai : > Dear guys, > > I'm currently working on a camera/ISP Linux driver project.Of course,I > want it to be a V4L2 driver,but I got a problem about how to design > the driver framework. > let me introduce the background of this ISP(Image signal processor) a > little bit. > 1.The I

Re: [uclinux-dist-devel] [PATCH 3/4] v4l2: add vs6624 sensor driver

2011-09-14 Thread Scott Jiang
> >> +#ifdef CONFIG_VIDEO_ADV_DEBUG > > just use DEBUG ? > no, v4l2 use CONFIG_VIDEO_ADV_DEBUG >> +       v4l_info(client, "chip found @ 0x%02x (%s)\n", >> +                       client->addr << 1, client->adapter->name); > > is that "<< 1" correct ?  i dont think so ... every driver under media

Re: [uclinux-dist-devel] [PATCH 4/4] v4l2: add blackfin capture bridge driver

2011-09-14 Thread Scott Jiang
> i think at least these three are unused and should get punted > >> +static int __devinit bcap_probe(struct platform_device *pdev) >> +{ >> +       struct bcap_device *bcap_dev; >> +       struct video_device *vfd; >> +       struct i2c_adapter *i2c_adap; > > you need to include linux/i2c.h for th

Re: [PATCH 4/4] v4l2: add blackfin capture bridge driver

2011-09-14 Thread Scott Jiang
>> +static int bcap_qbuf(struct file *file, void *priv, >> +                     struct v4l2_buffer *buf) >> +{ >> +     struct bcap_device *bcap_dev = video_drvdata(file); >> +     struct v4l2_fh *fh = file->private_data; >> +     struct bcap_fh *bcap_fh = container_of(fh, struct bcap_fh, fh); >>

Re: [PATCH 4/4] v4l2: add blackfin capture bridge driver

2011-09-13 Thread Scott Jiang
>> > I think, the direct use of vb2_plane_cookie() is discouraged. >> > vb2_dma_contig_plane_dma_addr() should work for you. >> > >> I guess you mean vb2_dma_contig_plane_paddr > > no, in the current kernel it's vb2_dma_contig_plane_dma_addr(). See > > http://git.linuxtv.org/media_tree.git/shortlog

Re: [PATCH 4/4] v4l2: add blackfin capture bridge driver

2011-09-13 Thread Scott Jiang
>> + >> +struct bcap_format { >> +     u8 *desc; >> +     u32 pixelformat; >> +     enum v4l2_mbus_pixelcode mbus_code; >> +     int bpp; /* bytes per pixel */ > > Don't you think you might have to process 12 bpp formats at some point, > like YUV 4:2:0, or NV12? Maybe better calculate in bits from

  1   2   >