[PATCH for v4.8] cec: don't Feature Abort broadcast msgs when unregistered

2016-08-24 Thread Hans Verkuil
If the adapter is configured as 'Unregistered', then cec_receive_notify incorrectly thinks that broadcast messages are directed messages. The destination for broadcast messages is 0xf, and the logical address assigned to Unregistered devices is also 0xf and the logic didn't handle that correctly

[RESEND PATCH] [media] atmel-isc: remove the warning

2016-08-24 Thread Songjun Wu
Replace the 'IS_ERR_VALUE(irq)' with 'ret < 0' in function 'atmel_isc_probe'. Reported-by: Hans Verkuil Signed-off-by: Songjun Wu --- drivers/media/platform/atmel/atmel-isc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers

[PATCH for v4.8] cec: fix ioctl return code when not registered

2016-08-24 Thread Hans Verkuil
Don't return the confusing -EIO error code when the device is not registered, instead return -ENODEV which is the proper thing to do in this situation. Signed-off-by: Hans Verkuil --- diff --git a/drivers/staging/media/cec/cec-api.c b/drivers/staging/media/cec/cec-api.c index 7be7615..049f171 10

Re: [PATCH v5 2/2] media: Add a driver for the ov5645 camera sensor.

2016-08-24 Thread Sakari Ailus
Hi Todor, Thank you for the patch. Please see my comments below. On Fri, Jul 08, 2016 at 05:54:39PM +0300, Todor Tomov wrote: > The ov5645 sensor from Omnivision supports up to 2592x1944 > and CSI2 interface. > > The driver adds support for the following modes: > - 1280x960 > - 1920x1080 > - 259

Re: [PATCH] [media] m2m-deinterlace: Fix error print during probe

2016-08-24 Thread Sakari Ailus
Hi, Peter! On Tue, Aug 23, 2016 at 04:39:39PM +0300, Peter Ujfalusi wrote: > v4l2_err() can not be used for printing error for missing interleaved > support in DMA as this point the pcdev->v4l2_dev is not valid. > > Signed-off-by: Peter Ujfalusi > --- > drivers/media/platform/m2m-deinterlace.c

[GIT PULL] Samsung media driver updates

2016-08-24 Thread Sylwester Nawrocki
Hi Mauro, this includes Samsung SoC media driver fixes and cleanups for v4.9. The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc: Linux 4.8-rc1 (2016-08-07 18:18:00 -0700) are available in the git repository at: git://linuxtv.org/snawrocki/samsung.git for-v4.9/medi

[PATCH] cec-compliance: fix Device OSD Transfer tests

2016-08-24 Thread Johan Fjeldtvedt
Remove a check for whether the first Set OSD String test applies, since this test itself is used to determine whether the others apply. This bug caused the tests to never be run. Also fix the test for Set OSD String where the default display control operand is given. In this case, when in interact

[PATCH] cec-ctl: print correct destination address for broadcast msgs

2016-08-24 Thread Johan Fjeldtvedt
When messages are broadcast, it is not necessary to supply a --to option to cec-ctl, but in that case the destination address was printed wrongly. Signed-off-by: Johan Fjeldtvedt --- utils/cec-ctl/cec-ctl.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/cec-ctl/cec-c

Re: [PATCH 0/9] Prepare Sphinx to build media PDF books

2016-08-24 Thread Mauro Carvalho Chehab
Markus, Em Thu, 18 Aug 2016 17:21:27 -0600 Jonathan Corbet escreveu: > On Tue, 16 Aug 2016 13:25:34 -0300 > Mauro Carvalho Chehab wrote: > > > I think this patch series belong to docs-next. Feel free to merge them > > there, if > > you agree. There's one extra patch that touches Documentation

[PATCH] cec tools: exit if device is disconnected

2016-08-24 Thread Johan Fjeldtvedt
If the CEC device is disconnected, ioctl will return ENODEV. This is checked for in cec-ctl (when monitoring), cec-follower and cec-compliance, to make these exit when the CEC device disappears. Signed-off-by: Johan Fjeldtvedt --- utils/cec-compliance/cec-compliance.h | 9 +++-- utils/cec-c

[PATCH] cec tools: exit when CEC device is disconnected

2016-08-24 Thread Johan Fjeldtvedt
When devices are disconnected, -EIO is currently returned by ioctl, but this will be replaced by -ENODEV. When ioctl returns that, there is no reason to let cec-ctl, cec-follower or cec-compliance run, so just exit them. This patch must be applied when the CEC framework has been changed to return

Re: [PATCH] cec tools: exit if device is disconnected

2016-08-24 Thread Hans Verkuil
On 08/24/16 12:31, Johan Fjeldtvedt wrote: > If the CEC device is disconnected, ioctl will return ENODEV. This is > checked for in cec-ctl (when monitoring), cec-follower and > cec-compliance, to make these exit when the CEC device disappears. > > Signed-off-by: Johan Fjeldtvedt > --- > utils/ce

[PATCHv2] cec tools: exit if device is disconnected

2016-08-24 Thread Johan Fjeldtvedt
If the CEC device is disconnected, ioctl will return ENODEV. This is checked for in cec-ctl (when monitoring), cec-follower and cec-compliance, to make these exit when the CEC device disappears. Signed-off-by: Johan Fjeldtvedt --- utils/cec-compliance/cec-compliance.h | 9 +++-- utils/cec-c

[PATCH] [media] ad5820: fix one smatch warning

2016-08-24 Thread Mauro Carvalho Chehab
drivers/media/i2c/ad5820.c:61:24: error: dubious one-bit signed bitfield Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/ad5820.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c index 62cc1f54622f..d7ad5c1a121

Re: [PATCH] [media] ad5820: fix one smatch warning

2016-08-24 Thread Sakari Ailus
Hi Mauro, Mauro Carvalho Chehab wrote: > drivers/media/i2c/ad5820.c:61:24: error: dubious one-bit signed bitfield > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/i2c/ad5820.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/ad5820.c b/dr

Re: [PATCH 0/9] Prepare Sphinx to build media PDF books

2016-08-24 Thread Markus Heiser
Am 24.08.2016 um 12:42 schrieb Mauro Carvalho Chehab : > Markus, > > Em Thu, 18 Aug 2016 17:21:27 -0600 > Jonathan Corbet escreveu: > >> On Tue, 16 Aug 2016 13:25:34 -0300 >> Mauro Carvalho Chehab wrote: >> >>> I think this patch series belong to docs-next. Feel free to merge them >>> there

Re: [PATCH 0/9] Prepare Sphinx to build media PDF books

2016-08-24 Thread Mauro Carvalho Chehab
Hi Markus, Em Wed, 24 Aug 2016 13:46:48 +0200 Markus Heiser escreveu: > Am 24.08.2016 um 12:42 schrieb Mauro Carvalho Chehab > : > > > Markus, > > > > Em Thu, 18 Aug 2016 17:21:27 -0600 > > Jonathan Corbet escreveu: > > > >> On Tue, 16 Aug 2016 13:25:34 -0300 > >> Mauro Carvalho Chehab w

[PATCH] doc-rst:sphinx-extensions: add metadata parallel-safe

2016-08-24 Thread Markus Heiser
From: Markus Heiser The setup() function of a Sphinx-extension can return a dictionary. This is treated by Sphinx as metadata of the extension [1]. With metadata "parallel_read_safe = True" a extension is marked as save for "parallel reading of source". This is needed if you want build in parall

Re: [PATCH] [media] v4l2-async: Always unregister the subdev on failure

2016-08-24 Thread Alban Bedel
On Fri, 1 Jul 2016 13:55:44 +0200 Hans Verkuil wrote: > On 05/11/2016 06:32 PM, Alban Bedel wrote: > > On Wed, 11 May 2016 12:22:44 -0400 > > Javier Martinez Canillas wrote: > > > >> Hello Alban, > >> > >> On 05/11/2016 11:40 AM, Alban Bedel wrote: > >>> In v4l2_async_test_notify() if the r

[PATCH] [media] extended-controls.rst: fix a build warning

2016-08-24 Thread Mauro Carvalho Chehab
/devel/v4l/patchwork/Documentation/media/uapi/v4l/extended-controls.rst:2116: WARNING: Inline literal start-string without end-string. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/extended-controls.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

[PATCH v2] [media] v4l2-async: Always unregister the subdev on failure

2016-08-24 Thread Alban Bedel
In v4l2_async_test_notify() if the registered_async callback or the complete notifier returns an error the subdev is not unregistered. This leave paths where v4l2_async_register_subdev() can fail but leave the subdev still registered. Add the required calls to v4l2_device_unregister_subdev() to pl

Re: [PATCH] doc-rst:sphinx-extensions: add metadata parallel-safe

2016-08-24 Thread Mauro Carvalho Chehab
Em Wed, 24 Aug 2016 15:35:24 +0200 Markus Heiser escreveu: > From: Markus Heiser > > The setup() function of a Sphinx-extension can return a dictionary. This > is treated by Sphinx as metadata of the extension [1]. > > With metadata "parallel_read_safe = True" a extension is marked as > save f

Re: [PATCH 2/2] v4l-utils: fixed dvbv5 vdr format

2016-08-24 Thread Mauro Carvalho Chehab
Hi Markus, Em Wed, 10 Aug 2016 11:52:19 +0200 Markus Heiser escreveu: > From: Markus Heiser > > From: Heiser, Markus > > The vdr format was broken, I got '(null)' entries > > HD:11494:S1HC23I0M5N1O35:S:(null):22000:5101:5102,5103,5106,5108:0:0:10301:0:0:0: > 0-:1:2--:3:4

Re: [PATCH 2/2] v4l-utils: fixed dvbv5 vdr format

2016-08-24 Thread Mauro Carvalho Chehab
Em Wed, 24 Aug 2016 11:49:27 -0300 Mauro Carvalho Chehab escreveu: > Hi Markus, > > Em Wed, 10 Aug 2016 11:52:19 +0200 > Markus Heiser escreveu: > > > From: Markus Heiser > > > > From: Heiser, Markus > > > > The vdr format was broken, I got '(null)' entries > > > > HD:11494:S1HC23I0M5N1O3

Re: [PATCH v5 2/2] media: Add a driver for the ov5645 camera sensor.

2016-08-24 Thread Todor Tomov
Hi Sakari, Thanks a lot for the time spent to review the driver! I have a few responses bellow. On 08/24/2016 01:17 PM, Sakari Ailus wrote: > Hi Todor, > > Thank you for the patch. Please see my comments below. > > On Fri, Jul 08, 2016 at 05:54:39PM +0300, Todor Tomov wrote: >> The ov5645 sens

[PATCH 2/3] doc-rst: define PDF's of the media folder

2016-08-24 Thread Markus Heiser
From: Markus Heiser To build only the PDF of the media folder run:: make SPHINXDIRS=media pdfdocs Signed-off-by: Markus Heiser --- Documentation/media/conf.py | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/media/conf.py b/Documentation/media/conf.py index 77cb2bb..be

[PATCH 3/3] doc-rst:media: build separated PDF books (experimental)

2016-08-24 Thread Markus Heiser
From: Markus Heiser This patch is only to demonstrate, how to build separated PDF books of the media sub-folder and close open links with intersphinx. It is an experimental state (I detected an build error, which I have not yet traced deep). Builds PDFs of: * media_uapi.pdf: Linux Media Infra

[PATCH 1/3] doc-rst: generic way to build PDF of sub-folders

2016-08-24 Thread Markus Heiser
From: Markus Heiser This extends the method to build only sub-folders to the targets "latexdocs" and "pdfdocs". To do so, a conf.py in the sub-folder is required, where the latex_documents of the sub-folder are defined. E.g. to build only gpu's PDF add the following to the Documentation/gpu/conf.

[PATCH 0/3] doc-rst: generic way to build PDF of sub-folder

2016-08-24 Thread Markus Heiser
From: Markus Heiser Hi Mauro, here is a small patch series which extends the method to build only sub-folders to the targets "latexdocs" and "pdfdocs". If you think, that the two first patches works for you, path them with your next merge to Jon's doc-next. The last patch in this series is jus

[PATCH 2/2] [media] tw5864: remove two unused vars

2016-08-24 Thread Mauro Carvalho Chehab
Remove those two vars that aren't used, as reported by smatch: drivers/media/pci/tw5864/tw5864-video.c: In function 'tw5864_prepare_frame_headers': drivers/media/pci/tw5864/tw5864-video.c:1219:16: warning: variable 'space_before_sl_hdr' set but not used [-Wunused-but-set-variable] unsigned lon

[PATCH 1/2] [media] tw5864-core: remove double irq lock code

2016-08-24 Thread Mauro Carvalho Chehab
As warned by smatch: drivers/media/pci/tw5864/tw5864-core.c:160 tw5864_h264_isr() error: double lock 'irqsave:flags' drivers/media/pci/tw5864/tw5864-core.c:174 tw5864_h264_isr() error: double unlock 'irqsave:flags' Remove the IRQ duplicated lock. Signed-off-by: Mauro Carvalho Ch

Re: pwc over musb: 100% frame drop (lost) on high resolution stream

2016-08-24 Thread Matwey V. Kornilov
2016-08-22 11:32 GMT+03:00 Matwey V. Kornilov : > 2016-08-22 1:00 GMT+03:00 Alan Stern : >> On Sun, 21 Aug 2016, Matwey V. Kornilov wrote: >> >>> In both cases (with or without HCD_BH), usb_hcd_giveback_urb is called >>> every 0.01 sec. It is not clear why behavior is so different. >> >> What behav

Re: [PATCH v2] docs-rst: kernel-doc: better output struct members

2016-08-24 Thread Jonathan Corbet
On Mon, 22 Aug 2016 22:02:57 -0300 Mauro Carvalho Chehab wrote: > So, change kernel-doc, for it to produce the output on a different way: > > **Members** > > ``prios[4]`` > > array with elements to store the array priorities > > Also, as the type is not part of LaTeX "item

Re: [PATCH 2/2] [media] tw5864: remove two unused vars

2016-08-24 Thread Andrey Utkin
On Wed, Aug 24, 2016 at 01:30:40PM -0300, Mauro Carvalho Chehab wrote: > Remove those two vars that aren't used, as reported by smatch: Acked-by: Andrey Utkin Sorry for missing this. Thanks a lot. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message

cron job: media_tree daily build: ERRORS

2016-08-24 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Aug 25 04:00:22 CEST 2016 git branch: test git hash: fb6609280db902bd5d34445fba1c926e95e63914 gcc versi

[PATCH] [media] tw5864-core: remove excessive irqsave

2016-08-24 Thread Andrey Utkin
As warned by smatch: drivers/media/pci/tw5864/tw5864-core.c:160 tw5864_h264_isr() error: double lock 'irqsave:flags' drivers/media/pci/tw5864/tw5864-core.c:174 tw5864_h264_isr() error: double unlock 'irqsave:flags' Two different spinlocks are obtained, so having two calls is corr