[ufs]: [scsi]: BUG: spinlock recursion on CPU#4

2017-05-31 Thread Asutosh Das (asd)
Hi All, Recently, I came across an issue with the below call stack. -000|arch_counter_get_cntvct(inline) -000|__delay() -001|__const_udelay(?) -002|msm_trigger_wdog_bite() -003|spin_dump(inline) -003|spin_bug(lock = ?, ?) -004|current_thread_info(inline) -004|debug_spin_lock_before(inline) -004|

Re: [PATCH] target: Avoid target_shutdown_sessions loop during queue_depth change

2017-05-31 Thread Christoph Hellwig
How about this slightly easier to read version? --- >From 75276cd521ccecba244c1ee6c1100e27518c628d Mon Sep 17 00:00:00 2001 From: Nicholas Bellinger Date: Thu, 1 Jun 2017 06:54:06 + Subject: target: Avoid target_shutdown_sessions loop during queue_depth change When target_shutdown_sessions()

[PATCH] target: Avoid target_shutdown_sessions loop during queue_depth change

2017-05-31 Thread Nicholas A. Bellinger
From: Nicholas Bellinger When target_shutdown_sessions() is invoked to shutdown all active sessions associated with a se_node_acl when se_node_acl->queue_depth is changed via core_tpg_set_initiator_node_queue_depth(), it's possible that new connections reconnect immediately after explicit shutdow

Re: [PATCH 2/8] target: remove iblock WRITE_SAME passthrough support

2017-05-31 Thread Christoph Hellwig
On Wed, May 31, 2017 at 11:27:01PM -0700, Nicholas A. Bellinger wrote: > Hey HCH & Jens, > > Is this already queued up for v4.13 to address the missing LBPRZ feature > bit..? > > If not, I'll happy to take it via target-pending along with the > following to re-enable it via max_write_zeroes_secto

Re: [PATCH 2/8] target: remove iblock WRITE_SAME passthrough support

2017-05-31 Thread Nicholas A. Bellinger
Hey HCH & Jens, Is this already queued up for v4.13 to address the missing LBPRZ feature bit..? If not, I'll happy to take it via target-pending along with the following to re-enable it via max_write_zeroes_sectors. diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_d

Re: [PATCH] iscsi: Fix a sleep-in-atomic bug

2017-05-31 Thread Nicholas A. Bellinger
Hi Jia-Ju, On Wed, 2017-05-31 at 11:26 +0800, Jia-Ju Bai wrote: > The driver may sleep under a spin lock, and the function call path is: > iscsit_tpg_enable_portal_group (acquire the lock by spin_lock) > iscsi_update_param_value > kstrdup(GFP_KERNEL) --> may sleep > > To fix it, the "GFP_KE

Re: [PATCH] tcmu: Add fifo type waiter list support to avoid starvation

2017-05-31 Thread Nicholas A. Bellinger
Hey MNC, Any comments on this..? It's been sitting on the list for a while now.. ;) On Fri, 2017-05-05 at 10:51 +0800, lixi...@cmss.chinamobile.com wrote: > From: Xiubo Li > > The fifo type waiter list will hold the udevs who are waiting for the > blocks from the data global pool. The unmap t

Re: [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler

2017-05-31 Thread Christoph Hellwig
> + case SAS_PROTOCOL_SSP: > + { > + unsigned char op = task->ssp_task.cmd->cmnd[0]; > + > + if (op == READ_6 || op == WRITE_6 || > + op == READ_10 || op == WRITE_10 || > + op == READ_12 || op == WRITE_12 || > +

Re: [PATCH v3 13/23] scsi: hisi_sas: add phy up/down/bcast and channel ISR

2017-05-31 Thread Christoph Hellwig
On Wed, May 31, 2017 at 10:33:05PM +0800, John Garry wrote: > From: Xiang Chen > > Add code to initialise interrupts and add some interrupt handlers. > > Signed-off-by: John Garry > Signed-off-by: Xiang Chen > --- > drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 281 > +

[GIT PULL] target fixes for v4.12-rc4

2017-05-31 Thread Nicholas A. Bellinger
Hello Linus, Here are the target-pending fixes for v4.12-rc4. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master This includes: - ibmviscsis ABORT_TASK handling fixes that missed the v4.12 merge window. (Bryant Ly and Michael Cyr

Re: [PATCH] megaraid: Fix a sleep-in-atomic bug

2017-05-31 Thread Jia-Ju Bai
On 05/31/2017 06:18 PM, Sumit Saxena wrote: -Original Message- From: Jia-Ju Bai [mailto:baijiaju1...@163.com] Sent: Wednesday, May 31, 2017 8:27 AM To: kashyap.de...@broadcom.com; sumit.sax...@broadcom.com; shivasharan.srikanteshw...@broadcom.com; j...@linux.vnet.ibm.com; martin.peter...@

Re: [PATCH 1/1] scsi: scsi_debug: Avoid PI being disabled when TGPS is enabled

2017-05-31 Thread Martin K. Petersen
Ewan, > Code is correct. > > s/TGPS/TPGS in the subject line and in one place in the patch > description. Also fixed the original, incorrect comment in the code that begat the patch description typo. Thanks! Applied to 4.12/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: lpfc: fix spelling mistake "entrys" -> "entries"

2017-05-31 Thread Martin K. Petersen
Colin, > Trivial fix to spelling mistake in debugfs message Applied to 4.13/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] qla2xxx: Fix extraneous ref on sp's after adapter break

2017-05-31 Thread Martin K. Petersen
Bill, > Hung task timeouts can result if a qlogic board breaks unexpectedly > while running I/O. These tasks become hung because command srb > reference counts are not going to zero, hence the affected srbs and > commands do not get freed. This fix accounts for this extra reference > in the srbs

Re: [PATCH] scsi: lpfc: Avoid NULL pointer dereference in lpfc_els_abort()

2017-05-31 Thread Martin K. Petersen
Guilherme, > We might have a NULL pring in lpfc_els_abort(), for example on error > recovery path, since queues are destroyed during error recovery > mechanism. > > In this case, we should just drop the abort since the queues will be > recreated anyway. This patch just verifies for NULL pointer a

Re: [PATCH] scsi: lpfc: prevent potential null pointer dereference

2017-05-31 Thread Martin K. Petersen
Gustavo A., > Null check at line 966: if (ndlp) {, implies that ndlp might be NULL. > Functions lpfc_nlp_set_state() and lpfc_issue_els_prli() dereference > pointer ndlp. Include these function calls inside the IF block that > tests pointer ndlp. Applied to 4.12/scsi-fixes. Thank you! -- Marti

Re: [PATCH] lpfc: nvmet_fc: fix format string

2017-05-31 Thread Martin K. Petersen
Arnd, > The lpfc_nvmeio_data() tracing helper always takes a format string and > three additional arguments. The latest caller has a format string with > only two integer arguments, causing this harmless warning: Applied to 4.12/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux En

Linux kernel 4.9.25: signed integer overflow in drivers/scsi/scsicam.c:173:29

2017-05-31 Thread Alice Ferrazzi
Hello scsi maintainer, I would like to report a signed integer overflow in drivers/scsi/scsicam.c:173:29 reported on the Gentoo bug reporting system. https://bugs.gentoo.org/show_bug.cgi?id=617820 The problem looks present ,at least , in the Linux kernel 4.9.25 regards, Alice Ferrazzi Gentoo

Re: [PATCH v3 3/9] blk-mq: use the introduced blk_mq_unquiesce_queue()

2017-05-31 Thread Ming Lei
On Wed, May 31, 2017 at 03:21:41PM +, Bart Van Assche wrote: > On Wed, 2017-05-31 at 20:37 +0800, Ming Lei wrote: > > diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c > > index 99e16ac479e3..ffcf05765e2b 100644 > > --- a/drivers/scsi/scsi_lib.c > > +++ b/drivers/scsi/scsi_lib.c >

Hello Dear Greetings from the Almighty God

2017-05-31 Thread elvir cerrato
Hello dear greetings to you from the almighty God , my name is Mrs Elvir Cerrato from Honduras i am 45 years old , i ma a dying woman who have decided to donate what i have to the churches , mosque , motherless homes , less privilege and the poor through you i was diagonsed for cancer two years a

Re: [PATCH] iscsi-target: Fix initial login PDU asynchronous socket close OOPs

2017-05-31 Thread Nicholas A. Bellinger
On Wed, 2017-05-31 at 15:28 -0500, Mike Christie wrote: > On 05/30/2017 11:58 PM, Nicholas A. Bellinger wrote: > > Hey MNC, > > > > On Fri, 2017-05-26 at 22:14 -0500, Mike Christie wrote: > >> Thanks for the patch. > >> The patch fixes the crash for me. However, is there a possible > >> regress

Re: [PATCH v2 11/17] qla2xxx: Turn on FW option for exchange check

2017-05-31 Thread Bart Van Assche
On Tue, 2017-05-30 at 10:54 -0700, Himanshu Madhani wrote: > - ctio->u.status1.flags = (atio->u.isp24.attr << 9) | > - cpu_to_le16(CTIO7_FLAGS_STATUS_MODE_1 | CTIO7_FLAGS_SEND_STATUS); > + temp = (atio->u.isp24.attr << 9)| > + CTIO7_FLAGS_STATUS_MODE_1 | CTIO7_FLAGS_SEND

Re: [PATCH v2 06/17] tcm_qla2xxx: Do not allow aborted cmd to advance.

2017-05-31 Thread Bart Van Assche
On Tue, 2017-05-30 at 10:54 -0700, Himanshu Madhani wrote: > From: Quinn Tran > > In case of hardware queue full, commands can loop between > TCM stack and tcm_qla2xx shim layers for retry. While command > is waiting for retry, task mgmt can get ahead and abort the > cmmand that encountered queue

Re: [PATCH v2 05/17] qla2xxx: Fix path recovery

2017-05-31 Thread Bart Van Assche
On Tue, 2017-05-30 at 10:54 -0700, Himanshu Madhani wrote: > From: Quinn Tran > > If the port is moved/changed, current code would trigger > a deletion. If the port is already deleted, then do relogin. Reviewed-by: Bart Van Assche

Re: [PATCH 20/25] qla2xxx: Remove redundant code

2017-05-31 Thread Tran, Quinn
Bart, Will make available in the next upstream, once it has a chance to go through our internal test cycle. Regards, Quinn Tran -Original Message- From: Bart Van Assche Date: Wednesday, May 31, 2017 at 4:41 PM To: "Tran, Quinn" , Nicholas Bellinger Cc: "linux-scsi@vger.kernel.org" ,

Re: [PATCH v2 03/17] qla2xxx: Retain loop test for fwdump length exceeding buffer length

2017-05-31 Thread Bart Van Assche
On Tue, 2017-05-30 at 10:54 -0700, Himanshu Madhani wrote: > From: Joe Carnuccio Reviewed-by: Bart Van Assche

Re: [PATCH v2 02/17] qla2xxx: Replace usage of spin_lock with spin_lock_irqsave

2017-05-31 Thread Bart Van Assche
On Tue, 2017-05-30 at 10:54 -0700, Himanshu Madhani wrote: > From: Quinn Tran > > Convert usage of spin_lock to spin_lock_irqsave because qla2xxx driver > accesses all the data structures in an interrupt context. Did you perhaps mean "*can* access all data structures in interrupt context"? Anyw

Re: [PATCH v2 01/17] qla2xxx: Allow ABTS RX, RIDA on ATIOQ for ISP83XX/27XX

2017-05-31 Thread Bart Van Assche
On Tue, 2017-05-30 at 10:54 -0700, Himanshu Madhani wrote: > From: Quinn Tran > > Driver added mechanism to move ABTS/PUREX/RIDA mailbox to > ATIO queue as part of commit id 41dc529a4602ac737020f423f84686a81de38e6d > ("qla2xxx: Improve RSCN handling in driver"). > > This patch addes a check to o

Re: [PATCH 20/25] qla2xxx: Remove redundant code

2017-05-31 Thread Bart Van Assche
On Mon, 2017-05-22 at 22:14 +, Tran, Quinn wrote: > > I think an initiator could get > really confused if it receives two responses for the same exchange. > > QT: I do see the window you’re describing in the > qlt_try_to_dequeue_unknown_atios(). > Will have to follow up with another pat

Re: [PATCH v2 15/17] qla2xxx: Accelerate SCSI BUSY status generation in target mode

2017-05-31 Thread Bart Van Assche
On Tue, 2017-05-30 at 10:54 -0700, Himanshu Madhani wrote: > + /* FW perform Exchang validation */ Did you perhaps intend "exchange" instead of "Exchang"? Please fix this if you repost this patch. Thanks, Bart.

Re: [PATCH v2 13/17] qla2xxx: Remove redundant code

2017-05-31 Thread Bart Van Assche
On Tue, 2017-05-30 at 10:54 -0700, Himanshu Madhani wrote: > The reason for hard coding LUN ID to 0 is that, from the FC > protocol perspective, ABTS does not have any knowledge of > LUN ID. So, there is no reason for qla2xxx driver to > manufacture the LUN ID. Sorry but I think this is completely

Re: [PATCH v2 12/17] qla2xxx: Add ql2xiniexchg parameter

2017-05-31 Thread Bart Van Assche
On Tue, 2017-05-30 at 10:54 -0700, Himanshu Madhani wrote: > -   "For Dual Mode (qlini_mode=dual), this parameter determines " > -   "the percentage of exchanges/cmds FW will allocate resources " > -   "for Target mode."); > + "For Dual Mode (qlini_mode=dual), this parameter determi

Re: [PATCH v2 08/17] qla2xxx: Convert 32-bit LUN usage to 64-bit

2017-05-31 Thread Bart Van Assche
On Tue, 2017-05-30 at 10:54 -0700, Himanshu Madhani wrote: > From: Quinn Tran Reviewed-by: Bart Van Assche

Re: [PATCH v2 04/17] qla2xxx: Include Exchange offload/Extended Login into FW dump

2017-05-31 Thread Bart Van Assche
On Tue, 2017-05-30 at 10:54 -0700, Himanshu Madhani wrote: > static inline void * > +qla25xx_copy_exlogin(struct qla_hw_data *ha, void *ptr, uint32_t > **last_chain) > +{ > + struct qla2xxx_offld_chain *c = ptr; > + > + if (!ha->exlogin_buf) > + return ptr; > + > + *last_c

Re: [PATCH] qla2xxx: Fix extraneous ref on sp's after adapter break

2017-05-31 Thread Madhani, Himanshu
> On May 25, 2017, at 12:26 PM, Bill Kuzeja wrote: > > Hung task timeouts can result if a qlogic board breaks unexpectedly while > running I/O. These tasks become hung because command srb reference counts > are not going to zero, hence the affected srbs and commands do not get > freed. This fix

Re: [PATCH] iscsi-target: Fix initial login PDU asynchronous socket close OOPs

2017-05-31 Thread Mike Christie
On 05/30/2017 11:58 PM, Nicholas A. Bellinger wrote: > Hey MNC, > > On Fri, 2017-05-26 at 22:14 -0500, Mike Christie wrote: >> Thanks for the patch. >> > > Btw, after running DATERA's internal longevity and scale tests across > ~20 racks on v4.1.y with this patch over the long weekend, there have

Re: [PATCH] scsi: lpfc: Fix crash on PCI hotplug remove path

2017-05-31 Thread James Smart
Actually, I think we solved this in a better manner in this patch in the 11.4.0.0 patch set: PATCH 10/15] lpfc: Fix crash on powering off BFS VM with passthrough device http://marc.info/?l=linux-scsi&m=149621070910290&w=2 See if the above patch fixes your error. -- james On 5/29/2017 4:

Re: [PATCH 1/1] scsi: scsi_debug: Avoid PI being disabled when TGPS is enabled

2017-05-31 Thread Ewan D. Milne
On Fri, 2017-05-26 at 12:59 -0400, Martin K. Petersen wrote: > It was not possible to enable both T10 PI and TGPS because they share > the same byte in the INQUIRY response. Logically OR the TPGS value > instead of using assignment. > > Reported-by: Ritika Srivastava > Signed-off-by: Martin K. Pe

Re: [PATCH v3 3/9] blk-mq: use the introduced blk_mq_unquiesce_queue()

2017-05-31 Thread Bart Van Assche
On Wed, 2017-05-31 at 20:37 +0800, Ming Lei wrote: > diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c > index 99e16ac479e3..ffcf05765e2b 100644 > --- a/drivers/scsi/scsi_lib.c > +++ b/drivers/scsi/scsi_lib.c > @@ -3031,7 +3031,10 @@ scsi_internal_device_unblock(struct scsi_device *sde

Re: [PATCH 1/1] scsi: scsi_debug: Avoid PI being disabled when TGPS is enabled

2017-05-31 Thread Bart Van Assche
On Fri, 2017-05-26 at 12:59 -0400, Martin K. Petersen wrote: > It was not possible to enable both T10 PI and TGPS because they share > the same byte in the INQUIRY response. Logically OR the TPGS value > instead of using assignment. Reviewed-by: Bart Van Assche

[PATCH] scsi: Add STARGET_CREATE_REMOVE state to scsi_target_state

2017-05-31 Thread Ewan D. Milne
From: "Ewan D. Milne" The addition of the STARGET_REMOVE state had the side effect of introducing a race condition that can cause a crash. scsi_target_reap_ref_release() checks the starget->state to see if it still in STARGET_CREATED, and if so, skips calling transport_remove_device() and device

[PATCH v3 4/5] tcmu: Make dev_config configurable

2017-05-31 Thread Bryant G. Ly
This allows for userspace to change the device path after it has been created. Thus giving the user the ability to change the path. The use case for this is to allow for virtual optical to have media change. v3 - Fix kree spelling error to kfree Signed-off-by: Bryant G. Ly --- drivers/target/ta

[PATCH v3 02/23] scsi: hisi_sas: define hisi_sas_device.device_id as int

2017-05-31 Thread John Garry
Currently hisi_sas_device.device_id is a u64. This can create a problem in selecting the queue for a device, in that this code does a 64b division on device id. For some 32b systems, 64b division is slow and the lib reference must be explicitly included. The device id does not need to be 64b in si

[PATCH v3 03/23] scsi: hisi_sas: optimise the usage of hisi_hba.lock

2017-05-31 Thread John Garry
From: Xiang Chen Currently hisi_hba.lock is locked to deliver and receive a command to/from any hw queue. This causes much contention at high data-rates. To boost performance, lock on a per queue basis for sending and receiving commands to/from hw. Certain critical regions still need to be lock

[PATCH v3 06/23] scsi: hisi_sas: relocate get_ncq_tag_v2_hw()

2017-05-31 Thread John Garry
From: Xiang Chen Relocate get_ncq_tag_v2_hw() to a common location, as future hw versions will require it. Also rename with "hisi_sas_" prefix for consistency. Signed-off-by: Xiang Chen Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 1 + drivers/scsi/hisi_sas/hisi_sas

[PATCH v3 07/23] scsi: hisi_sas: add pci_dev in hisi_hba struct

2017-05-31 Thread John Garry
Since hip08 SAS controller is based on pci device, add hisi_hba.pci_dev for hip08 (will be v3), and also rename hisi_hba.pdev to .platform_dev for clarity. In addition, for common code which wants to reference the controller device struct, add hisi_hba.dev, and change the common code to use it. S

[PATCH v3 04/23] scsi: hisi_sas: relocate get_ata_protocol()

2017-05-31 Thread John Garry
From: Xiang Chen Relocate get_ata_protocol() to a common location, as future hw versions will require it. Also rename with "hisi_sas_" prefix for consistency. Signed-off-by: Xiang Chen Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 1 + drivers/scsi/hisi_sas/hisi_sas_

[PATCH v3 08/23] scsi: hisi_sas: create hisi_sas_get_fw_info()

2017-05-31 Thread John Garry
Move the functionality to retrieve the fw info into a dedicated device type-agnostic function, hisi_sas_get_fw_info(). The reasoning is that this function will be required for future pci-based platforms. Also add some debug logs for failure. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/

[PATCH v3 01/23] scsi: hisi_sas: fix timeout check in hisi_sas_internal_task_abort()

2017-05-31 Thread John Garry
From: Xiang Chen We need to check for timeout before task status, or the task will be mistook as completed internal abort command. Also add protection for sas_task.task_state_flags in hisi_sas_tmf_timedout(). Signed-off-by: Xiang Chen Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_s

[PATCH v3 09/23] scsi: hisi_sas: add skeleton v3 hw driver

2017-05-31 Thread John Garry
Add skeleton driver for v3 hw in hisi_sas_v3_hw.c File hisi_sas_v3_hw.c will serve 2 purposes: - probing and initialisation of the controller based on pci device - hw layer for v3-based controllers The controller design is quite similar to v2 hw in hip07. However key differences include: -All v2

[PATCH v3 05/23] scsi: hisi_sas: relocate sata_done_v2_hw()

2017-05-31 Thread John Garry
From: Xiang Chen Relocate get_ata_protocol() to a common location, as future hw versions will require it. Also rename with "hisi_sas_" prefix for consistency. Signed-off-by: Xiang Chen Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 2 ++ drivers/scsi/hisi_sas/hisi_sas

[PATCH v3 23/23] scsi: hisi_sas: modify internal abort dev flow for v3 hw

2017-05-31 Thread John Garry
From: Xiang Chen There is a change for abort dev for v3 hw: add registers to configure unaborted iptt for a device, and then inform this to logic. Signed-off-by: Xiang Chen Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 2 ++ drivers/scsi/hisi_sas/hisi_sas_main.c | 1

[PATCH v3 21/23] scsi: hisi_sas: Add v3 code to support ECC and AXI bus fatal error

2017-05-31 Thread John Garry
From: Xiang Chen For ECC 1bit error, logic can recover it, so we only print a warning. For ECC multi-bit and AXI bus fatal error, we panic. Note: once v3 hw controller reset support is added, the panic will be replaced by a controller reset, like v2 hw. Signed-off-by: John Garry Signed-o

[PATCH v3 18/23] scsi: hisi_sas: add v3 code for itct setup and free

2017-05-31 Thread John Garry
From: Xiang Chen Add code to itct setup and free for v3 hw. Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 114 + 1 file changed, 114 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers

[PATCH v3 15/23] scsi: hisi_sas: add v3 code to send SSP frame

2017-05-31 Thread John Garry
From: Xiang Chen Add code to prepare SSP frame and deliver it to hardware. Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 208 + 1 file changed, 208 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_

[PATCH v3 16/23] scsi: hisi_sas: add v3 code to send SMP frame

2017-05-31 Thread John Garry
From: Xiang Chen Add code to prepare SMP frame. Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sa

[PATCH v3 11/23] scsi: hisi_sas: add v3 hw init

2017-05-31 Thread John Garry
From: Xiang Chen Add code to initialise v3 hardware. Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 277 + 1 file changed, 277 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/h

[PATCH v3 10/23] scsi: hisi_sas: add initialisation for v3 pci-based controller

2017-05-31 Thread John Garry
Add the code to initialise the controller which is based on pci device in hisi_sas_v3_hw.c The core controller routines are still in hisi_sas_main.c; some common initialisation functions are also exported from hisi_sas_main.c For pci-based controller, the device properties, like phy count and sas

[PATCH v3 17/23] scsi: hisi_sas: add v3 code to send ATA frame

2017-05-31 Thread John Garry
From: Xiang Chen Add code to prepare ATA frame for v3 hw Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 106 + 1 file changed, 106 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/sc

[PATCH v3 13/23] scsi: hisi_sas: add phy up/down/bcast and channel ISR

2017-05-31 Thread John Garry
From: Xiang Chen Add code to initialise interrupts and add some interrupt handlers. Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 281 + 1 file changed, 281 insertions(+) diff --git a/drivers/scsi/hisi_sas/his

[PATCH v3 12/23] scsi: hisi_sas: add v3 hw PHY init

2017-05-31 Thread John Garry
From: Xiang Chen Add code to configure PHYs for v3 hw. Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 127 - 1 file changed, 126 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c

[PATCH v3 20/23] scsi: hisi_sas: add get_wideport_bitmap_v3_hw()

2017-05-31 Thread John Garry
From: Xiang Chen Add code for interface get_wideport_bitmap. Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_

[PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler

2017-05-31 Thread John Garry
From: Xiang Chen Add v3 cq interrupt handler slot_complete_v2_hw(). Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas.h | 1 + drivers/scsi/hisi_sas/hisi_sas_main.c | 32 drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 331 +

[PATCH v3 19/23] scsi: hisi_sas: add v3 code to send internal abort command

2017-05-31 Thread John Garry
From: Xiang Chen Add code to prepare internal abort command. Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers

[PATCH v3 22/23] scsi: hisi_sas: add v3 code to fill some more hw function pointers

2017-05-31 Thread John Garry
From: Xiang Chen Add code to fill the interface of phy_hard_reset, phy_get_max_linkrate, and phy enable/disable. Signed-off-by: John Garry Signed-off-by: Xiang Chen --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 40 +- 1 file changed, 39 insertions(+), 1 deletion

[PATCH v3 00/23] hisi_sas: hip08 support

2017-05-31 Thread John Garry
This patchset adds support for the HiSilicon SAS controller in the hip08 chipset. The key difference compared to earlier chipsets is that the controller is an integrated PCI endpoint in hip08. As such, the controller is a pci device (not a platform device, like v2 hw in hip07). The driver is refa

[PATCH V2 12/15] qedf: Move some prints to a debug level so they do not print when no debugging is enabled.

2017-05-31 Thread Dupuis, Chad
Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 45c741b..4b688d6 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qe

[PATCH V2 14/15] qedf: Add change_queue_depth member to scsi_host_template().

2017-05-31 Thread Dupuis, Chad
Add the change_queue_depth member to our SCSI host template so the queue depth of devices attached to qedf can be changed dynamically. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qed

[PATCH V2 15/15] qedf: Update version number to 8.18.22.0.

2017-05-31 Thread Dupuis, Chad
Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_version.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_version.h b/drivers/scsi/qedf/qedf_version.h index d46c487..6fa4420 100644 --- a/drivers/scsi/qedf/qedf_version.h +++ b/drivers/scsi/qed

[PATCH V2 13/15] qedf: Change cmd_per_lun in scsi_host_template to 32 to increase performance.

2017-05-31 Thread Dupuis, Chad
Increase the default number of commands that the driver tells the SCSI mid-layer it can do to increase the default performance of the driver. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_ma

[PATCH V2 10/15] qedf: Add non-offload receive filters.

2017-05-31 Thread Dupuis, Chad
Drop invalid or unexpected FCoE frames that come into the non-offload path since the FCoE firmware would not do the filtering for us. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/driv

[PATCH V2 08/15] qedf: Use same logic for SCSI host reset and FC lip_reset.

2017-05-31 Thread Dupuis, Chad
We should be using the same logic to do a soft reset of the FCoE function whether it is initiated via sg_reset or the fc_host issue_lip attribute. Refactor the host reset and fcoe reset handlers to use the preferred logic which is currently contained in qedf_eh_host_reset(). Signed-off-by: Chad Du

[PATCH V2 05/15] qedf: Check that fcport is offloaded before dereferencing pointers in initiate_abts|cleanup.

2017-05-31 Thread Dupuis, Chad
If an fcport is not offloaded then the members of the qedf_rport struct are undefined which may cause a system crash. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_io.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c

[PATCH V2 09/15] qedf: Add bus_reset No-op.

2017-05-31 Thread Dupuis, Chad
We need to add a bus reset no-op as without it some of the LUNs attached to a vport may go offline when the error handler escalates to host reset due to not having a bus reset handler in the driver. What happens is we escalate to host reset which does a soft link down/link up to reset the adapter.

[PATCH V2 06/15] qedf: Add fka_period SCSI host attribute to show fip keep alive period.

2017-05-31 Thread Dupuis, Chad
Expose this information for interested applications. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_attr.c | 57 --- 1 file changed, 38 insertions(+), 19 deletions(-) diff --git a/drivers/scsi/qedf/qedf_attr.c b/drivers/scsi/qedf/qedf_attr.c index

[PATCH V2 11/15] qedf: Fixup unnecessary parantheses around test_bit operations.

2017-05-31 Thread Dupuis, Chad
Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_els.c | 6 +++--- drivers/scsi/qedf/qedf_io.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qedf/qedf_els.c b/drivers/scsi/qedf/qedf_els.c index e197fd6..78d9f1c 100644 --- a/drivers/scsi/qedf/qedf_els.c

[PATCH V2 04/15] qedf: Look at all descriptors when processing a clear virtual link.

2017-05-31 Thread Dupuis, Chad
If there are multiple descriptors for a particular type in a clear virtual link we receive, we will not process it correctly but rather take the last value. This can cause us not to not flap the virtual link as the value from the descriptors that we compare against the our stored FCF or fc_lport va

[PATCH V2 03/15] qedf: Honor qed_ops->common->set_fp_int() return code.

2017-05-31 Thread Dupuis, Chad
We need to check the return code the set_fp_int() callback in case we were not allocated any fastpath interrupts or there was an error setting up the fastpath interrupts from the qed perspective. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH V2 00/15] qedf: Update driver to version 8.18.22.0.

2017-05-31 Thread Dupuis, Chad
Hi Martin, Please apply the following patches to the scsi tree at your earliest convenience. Thanks, Chad Change from V1 -> V2: - Use fc_host attributes directly instead of using fc_host_* macros when setting FDMI attributes - Fix typos in patch descriptions - Implement suggested code refacto

[PATCH V2 01/15] qedf: Enable basic FDMI information.

2017-05-31 Thread Dupuis, Chad
For libfc to register FDMI attributes we need to do two things: - Set the appropriate fc_host attributes that libfc will use to form the FDMI registration commands - Set lport->fdmi_enabled to 1 Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 56

[PATCH V2 07/15] qedf: Set qed logging level to QED_LEVEL_NOTICE.

2017-05-31 Thread Dupuis, Chad
Reduce the logging level we set for qed messages pertaining to this PCI function so that unnecessary messages are not printed in the kernel message log. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/q

[PATCH V2 02/15] qedf: Update copyright to 2017.

2017-05-31 Thread Dupuis, Chad
Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/drv_fcoe_fw_funcs.c | 2 +- drivers/scsi/qedf/drv_fcoe_fw_funcs.h | 2 +- drivers/scsi/qedf/drv_scsi_fw_funcs.c | 2 +- drivers/scsi/qedf/drv_scsi_fw_funcs.h | 2 +- drivers/scsi/qedf/qedf.h | 2 +- drivers/scsi/qedf/qedf_attr.c

[PATCH v3 3/9] blk-mq: use the introduced blk_mq_unquiesce_queue()

2017-05-31 Thread Ming Lei
blk_mq_unquiesce_queue() is used for unquiescing the queue explicitly, so replace blk_mq_start_stopped_hw_queues() with it. Cc: linux-n...@lists.infradead.org Cc: linux-scsi@vger.kernel.org Cc: dm-de...@redhat.com Signed-off-by: Ming Lei --- drivers/md/dm-rq.c | 2 +- drivers/nvme/host/cor

RE: [PATCH] megaraid: Fix a sleep-in-atomic bug

2017-05-31 Thread Sumit Saxena
>-Original Message- >From: Jia-Ju Bai [mailto:baijiaju1...@163.com] >Sent: Wednesday, May 31, 2017 8:27 AM >To: kashyap.de...@broadcom.com; sumit.sax...@broadcom.com; >shivasharan.srikanteshw...@broadcom.com; j...@linux.vnet.ibm.com; >martin.peter...@oracle.com >Cc: megaraidlinux@broadc

Re: [PATCH 0/3] libfc: fix potential timer list corruption

2017-05-31 Thread Johannes Thumshirn
On 05/30/2017 05:14 PM, Hannes Reinecke wrote: > Hi all, > > we've seen reports for a crash with an invalid timer_list->function, > which turned out to be an unsafe usage of libfc discovery callbacks. > This patchset fixes up the problem > > As usual, comments and reviews are welcome. The patche

SCSI controller with CDB-16 (Was: sym53c8xx and Large disk (DCB-16))

2017-05-31 Thread Alexander Voropay
Hello, linux-scsi! I've re replaced sym53c8xx SCSI controller with Adaptec ASC-29320ALP (chip AIC-7901). - Ultra320 bus does not work physically, too many errors. - Ultra160 bus works relable, no errors. Unfortunately Adaptec does not work with CDB-16 too :( scsi11 : Adaptec AIC79XX PCI-X SCSI H