Re: [PATCH v2] virtio_scsi: don't select CONFIG_BLK_DEV_INTEGRITY

2015-04-27 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> T10 PI is just another optional feature, LLDDs should work Christoph> without the infrastructure. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscrib

Re: [PATCH 1/9] dm-mpath: check kstrdup return value in parse_hw_handler

2015-05-01 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 7/9] scsi_dh: kill struct scsi_dh_data

2015-05-01 Thread Martin K. Petersen
Christoph> require rebuilding every SCSI LLDD. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] [RFC] block: Add blk_max_rw_sectors attribute

2015-06-14 Thread Martin K. Petersen
he HBA hardware request size limit which is what BLOCK_PC callers should be constrained by exclusively. That way you don't get into having to parse the CDB and other evils. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe lin

Re: optimal io size / custom alignment

2015-06-16 Thread Martin K. Petersen
uraging. Tom> I just feel like the kernel shouldn't bind values from totally Tom> different source (raid stripe vs vpd limit) to the same variable. RAID devices communicate the stripe width through the Block Limits VPD. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe

Re: [PATCH 1/1] [PATCH] block: Add blk_max_rw_sectors limit

2015-06-16 Thread Martin K. Petersen
queue limit directly. Also update the comment in blk_limits_max_hw_sectors() to clarify that max_hw_sectors defines the limit for the I/O controller only. Signed-off-by: Martin K. Petersen Reported-by: Brian King Cc: sta...@vger.kernel.org # 3.17+ diff --git a/block/blk-settings.c b/block/

Re: optimal io size / custom alignment

2015-06-18 Thread Martin K. Petersen
us. As do enterprise disk drives. We deal with broken devices by blacklisting them. I suggest you try to find a way we can reliably identify your UAS devices. If there is a common pattern, we can entertain adding a workaround. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe f

Re: [PATCH v1 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-19 Thread Martin K. Petersen
six96_vector) { > + writel((reply_q->msix_index & 7)<< > +MPI2_RPHI_MSIX_INDEX_SHIFT, > +ioc->replyPostRegisterIndex[reply_q->msix_index/8]); > + } else { > + writel(reply_q->msix_index << > + MPI2_RPHI_MSIX_INDEX_SHIFT, > + &ioc->chip->ReplyPostHostIndex); > + } > + Too many brackets. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH 03/20] [SCSI] mpt3sas: Don't block the drive when drive addition under the control of SML

2015-06-19 Thread Martin K. Petersen
o this drive. Also > any subsequent device removal (TARGET_NOT_RESPONDING) or link > update(RC_PHY_CHANGED) event couldn't be processed as they are in the > queue to get processed after disk addition event. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Eng

Re: [PATCH v1 02/20] [SCSI] mpt3sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state.

2015-06-19 Thread Martin K. Petersen
HBA is in operational or > ready state. > 2.If IOC is in fault state, a diagnostic reset would be issued. > 3.If IOC is in reset state then driver will wait for 10 seconds to exit out > of reset state. >If the HBA continues to be in reset state, then the HBA wouldn't b

Re: [PATCH 04/20] [SCSI] mpt3sas: Remove redundancy code while freeing the controller resources.

2015-06-19 Thread Martin K. Petersen
>>>>> Sreekanth Reddy writes: > Removed the redundancy code while freeing the controller resources. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH 05/20] [SCSI] mpt3sas: MPI 2.5 Rev I (2.5.4) specifications.

2015-06-19 Thread Martin K. Petersen
>>>>> Sreekanth Reddy writes: > Update MPI 2.5 Release: MPI 2.5 Rev I (2.5.4) specification and > 2.00.33 header files Below is the change set from the MPI > specification for I Rev Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineerin

Re: [PATCH v1 06/20] [SCSI] mpt3sas: Provides the physical location of sas drives

2015-06-19 Thread Martin K. Petersen
ready status for the end device, - > When a Predicted fault is detected on an end device. > This information can be used by the user to identify the location of > the desired drive in the topology. > Driver will get these information by reading the sas device page0. Reviewed-by: Martin

Re: [PATCH 07/20] [SCSI] mpt3sas: Bump mpt3sas Driver version to v5.100.00.00

2015-06-19 Thread Martin K. Petersen
>>>>> Sreekanth Reddy writes: > Bump mpt3sas Driver version to v5.100.00.00 Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH 08/20] [SCSI] mpt3sas: Update MPI2 strings to MPI2.5

2015-06-19 Thread Martin K. Petersen
>>>>> Sreekanth Reddy writes: > Update MPI2 strings to MPI2.5. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH 09/20] [SCSI] mpt3sas: MPI 2.5 Rev J (2.5.5) specification and 2.00.34 header files

2015-06-19 Thread Martin K. Petersen
; +#define MPI2_BIOSPAGE1_OPTIONS_DISABLE_REGISTRATION_UEFI_BSD (0x0300) Otherwise OK. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH 10/20] [SCSI] mpt3sas: Add branding string support for OEM's HBA

2015-06-19 Thread Martin K. Petersen
>>>>> Sreekanth Reddy writes: > Added the following Dell branding to the mpt3sas driver. "VendorID" > "DeviceID" "SubsystemVendor ID" "SubsystemDevice ID" Dell Branding > String 0x1000 0x0097 0x1028 0x1F46 DELL 12Gbps HBA Revi

Re: [PATCH 12/20] [SCSI] mpt3sas: Bump mpt3sas driver version to v6.100.00.00

2015-06-19 Thread Martin K. Petersen
>>>>> Sreekanth Reddy writes: > Bump mpt3sas driver version to v6.100.00.00. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH 11/20] [SCSI] mpt3sas: Add branding string support for OEM custom HBA

2015-06-19 Thread Martin K. Petersen
12G SAS HBA I'm not so keen on all this branding stuff. It is purely cosmetic and doesn't change driver behavior. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH 13/20] [SCSI] mpt3sas: MPI 2.5 Rev K (2.5.6) specifications

2015-06-19 Thread Martin K. Petersen
equest. 3) For BIOS Page 1, added > SSUTimeout field, and added Product Name String Format bits to the > BiosOptions field Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH 15/20] [SCSI] mpt3sas: Return host busy error status to SML when DMA mapping of scatter gather list fails for a SCSI command

2015-06-19 Thread Martin K. Petersen
>>>>> Sreekanth Reddy writes: > scsi_dma_map API will return a negative value (i.e. -ENOMEM) if DMA > mapping of sg lists fails and zero if the sg list in the SCSI cmd is > NULL. But drivers doesn't handled sg list DMA mapping failure case > properly.

Re: [PATCH 16/20] [SCSI] mpt3sas: Added support for customer specific branding

2015-06-19 Thread Martin K. Petersen
BA 0x1000 > 0x97 0x1137 0x155 Cisco 12G Modular SAS Pass through Controller 0x1000 > 0x97 0x1137 0x156 UCS C3X60 12G SAS Pass through Controller Same comment about not actually changing driver behavior. These changes belong in pci.ids, not in a driver. -- Martin K. Petersen Oracle Linux En

Re: [PATCH 17/20 v1] [SCSI] mpt3sas: Use alloc_ordered_workqueue() API instead of create_singlethread_workqueue() API

2015-06-19 Thread Martin K. Petersen
>>>>> Sreekanth Reddy writes: > Created a thread using alloc_ordered_workqueue() API in order to > process the works from firmware Work-queue sequentially instead of > create_singlethread_workqueue() API. Reviewed-by: Martin K. Petersen -- Martin K. Petersen

Re: [PATCH 20/20] [SCSI] mpt3sas : Bump mpt3sas driver version to 9.100.00.00

2015-06-19 Thread Martin K. Petersen
>>>>> Sreekanth Reddy writes: > Bump mpt3sas driver version to 9.100.00.00 Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH 18/20] [SCSI] mpt3sas: Call dma_mapping_error() API after mapping an address with dma_map_single() API

2015-06-19 Thread Martin K. Petersen
address with dma_map_single Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH 14/20 v1] [SCSI] mpt3sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081

2015-06-19 Thread Martin K. Petersen
ailing the IO permanently even > though drive came back successfully. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: optimal io size / custom alignment

2015-06-20 Thread Martin K. Petersen
rive. To me they look like to be of different nature. We don't know whether a discovered device is "a simple drive". And once again: The whole point of the queue limit is to have an common abstraction for all block devices. -- Martin K. Petersen Oracle Linux Engineering -- T

Re: configurable discard parameters

2015-06-20 Thread Martin K. Petersen
gt; for users. Because if the vendor got these trivial values wrong there is little to no chance that they implemented discard correctly in their firmware. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH 16/20] [SCSI] mpt3sas: Added support for customer specific branding

2015-06-22 Thread Martin K. Petersen
x27;s a bad habit to use the kernel for marketing purposes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH v1 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-22 Thread Martin K. Petersen
>>>>> "Sreekanth" == Sreekanth Reddy writes: Sreekanth> I will remove these extra brackets. but SAS3 HBA's less than Sreekanth> C0 revision (which doesn't support this Combined Reply Queue Sreekanth> feature) will support up to 16 MSI-X vectors. A

Re: configurable discard parameters

2015-06-22 Thread Martin K. Petersen
Linux' libata was one of the first implementations of SCSI-ATA translation for TRIM. Initially we bent the rules for UNMAP a bit. When the standards caught up we switched to WRITE SAME. Tom> So it actually tells. And I hope that the kernel wouldn't "falsify" Tom> anything f

Re: configurable discard parameters

2015-06-23 Thread Martin K. Petersen
please focus on your bridge devices and what, if anything, can be done to uniquely identify them and override any incorrect values they might report to the SCSI stack. Up to and including us disabling discard entirely on these devices if their translation isn't verifiable and bullet proof. -- M

[PATCH] sd: Fix maximum I/O size for BLOCK_PC requests

2015-06-23 Thread Martin K. Petersen
void using blk_queue_max_hw_sectors() and set the max_sectors queue limit directly. Also update the comment in blk_limits_max_hw_sectors() to clarify that max_hw_sectors defines the limit for the I/O controller only. Signed-off-by: Martin K. Petersen Reported-by: Brian King Tested-by: Brian Kin

[PATCH 1/2] sd: Sanity check the optimal I/O size

2015-06-23 Thread Martin K. Petersen
. Signed-off-by: Martin K. Petersen Reported-by: Chris Friesen Cc: sta...@vger.kernel.org --- drivers/scsi/sd.c | 3 ++- drivers/scsi/sd.h | 9 + 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index a20da8c25b4f..118b336e0ddf 100644

[PATCH 2/2] scsi: Remove VPD quirk for Seagate drives

2015-06-23 Thread Martin K. Petersen
Now that we sanity check the optimal I/O size reported by the device we no longer need to blacklist the VPD pages on certain Seagate drives. Signed-off-by: Martin K. Petersen Cc: sta...@vger.kernel.org --- drivers/scsi/scsi_devinfo.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers

Re: [PATCH v2 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-23 Thread Martin K. Petersen
>>>>> "Sreekanth" == Sreekanth Reddy writes: Sreekanth> In this patch, increased the number of MSIX vector support Sreekanth> for SAS3 C0 HBAs to up-to 96. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscrib

Re: [PATCH v1 09/20] [PATCH 09/20] [SCSI] mpt3sas: MPI 2.5 Rev J (2.5.5) specification and 2.00.34 header files

2015-06-23 Thread Martin K. Petersen
>>>>> Sreekanth Reddy writes: > Following is the change set, 1. Added more defines for the BiosOptions > field of MPI2_CONFIG_PAGE_BIOS_1. 2. Added > MPI2_TOOLBOX_CLEAN_BIT26_PRODUCT_SPECIFIC definition. Reviewed-by: Martin K. Petersen -- Martin K. Petersen

Re: configurable discard parameters

2015-06-23 Thread Martin K. Petersen
ll hell broke loose. So we reverted to a single sector payload for libata. I still have the payload patch in my SSD test branch and regularly test with it. But there are still drives that fail in mysterious ways with it in place and so far I haven't felt compelled to maintain yet another

Re: configurable discard parameters

2015-06-23 Thread Martin K. Petersen
hat happens if you discard sectors 0-6 and then sector 7? Tom> I can workaround this by specifying --step in blkdiscard, but I Tom> think the kernel should have a param configurable for general. This is on the Intel 530? What does the drive report in /sys/block/sdN/queue/discard_zeroes_data?

Re: configurable discard parameters

2015-06-23 Thread Martin K. Petersen
blow up as a result of this patch... -- Martin K. Petersen Oracle Linux Engineering diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 3131adcc1f87..9c270a303f0b 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -2238,8 +2238,24 @@ static uns

Re: configurable discard parameters

2015-06-24 Thread Martin K. Petersen
he drives "blow up" on less blocks Tom> per range. Isn't that even more of a firmware bug than the problem Tom> I have? I have several older drives that expect a single contiguous LBA range. They don't handle multiple discontiguous ranges at all. -- Martin K. Petersen

Re: [PATCH v4 1/5] target: Inline transport_get_sense_codes()

2015-07-09 Thread Martin K. Petersen
>>>>> "Sagi" == Sagi Grimberg writes: Sagi> From: Bart Van Assche Inline this Sagi> function in its call site since it performs a trivial task and Sagi> since it is only called once. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux

Re: [PATCH v4 2/5] target: Split transport_send_check_condition_and_sense()

2015-07-09 Thread Martin K. Petersen
nse_reason(). Convert the switch Sagi> statement that performs the translation into table-driven code. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a messag

Re: [PATCH v4 3/5] scsi: Move sense handling routines to scsi_common

2015-07-09 Thread Martin K. Petersen
separate patch. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 4/5] target: Use scsi helpers to build the sense data correctly

2015-07-09 Thread Martin K. Petersen
>>>>> "Sagi" == Sagi Grimberg writes: Sagi> Instead of open coding the sense buffer construction, use scsi Sagi> scsi_build_sense_buffer() and scsi_set_sense_information() helpers Sagi> which moved to scsi_common. Reviewed-by: Martin K. Petersen -- Ma

Re: [PATCH v4 5/5] target: Return ABORTED_COMMAND sense key for PI errors

2015-07-09 Thread Martin K. Petersen
use ILLEGAL REQUEST with the same ASC/ASCQ to signal errors detected by the initiator. The target should always use ABORTED COMMAND. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-s

Re: [PATCH] scsi: Fix sense information setting in fixed sized format

2015-07-09 Thread Martin K. Petersen
>>>>> "Sagi" == Sagi Grimberg writes: Sagi> In fixed size sense format the information field is a four byte Sagi> field. Correct. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the l

Re: [PATCH 1/3] scsi: Fix wrong additional sense length in descriptor format

2015-07-13 Thread Martin K. Petersen
instead of 0xa. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] scsi: Protect against buffer possible overflow in scsi_set_sense_information

2015-07-13 Thread Martin K. Petersen
t it's callers scsi target and libata. Nitpicking: s/it's/its/ Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org

Re: [PATCH 3/3] target: Return descriptor format sense data

2015-07-13 Thread Martin K. Petersen
r information. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] qla2xxx: use t10_pi_tuple

2015-07-13 Thread Martin K. Petersen
>>>>> "Sebastian" == Sebastian Herbszt writes: Sebastian> Drop unused scsi_dif_tuple and use t10_pi_tuple instead of Sebastian> own sd_dif_tuple copy. Also use sg_virt() instead of open Sebastian> coding it. Reviewed-by: Martin K. Petersen -- Martin K. Pete

Re: [PATCH] fix host max depth checking for the 'queue_depth' sysfs interface

2015-07-13 Thread Martin K. Petersen
ns> host when the controller/devices probing happens. Yeah. We can't rely on the template for this. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a mes

Re: [PATCH 3/3] target: Return descriptor format sense data

2015-07-14 Thread Martin K. Petersen
could make it conditional and only use the descriptor format if the LBA is big enough to warrant it. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org Mo

Re: [PATCH] fix host max depth checking for the 'queue_depth' sysfs interface

2015-07-14 Thread Martin K. Petersen
read-only host template seems like somewhat Jens> of a relic. Agree 100%. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v1 4/4] libiscsi: Use scsi helper to set information descriptor

2015-07-15 Thread Martin K. Petersen
>>>>> "Sagi" == Sagi Grimberg writes: Sagi> In case encountered a PI error, use scsi_set_sense_information Sagi> instead of open coding information descriptor format. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To u

Re: [PATCH v1 3/4] target: Return descriptor format sense data in case the LU spans 64bit sectors

2015-07-15 Thread Martin K. Petersen
format sense Sagi> data to correctly report sector information. I'm fine with Bart's suggestion. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a

Re: [PATCH] MAINTAINERS: Update LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI) maintainers list

2015-07-15 Thread Martin K. Petersen
>>>>> "Sreekanth" == Sreekanth Reddy writes: Sreekanth> Updating maintainers list for the entry LSILOGIC MPT FUSION Sreekanth> DRIVERS in MAINTAINERS file Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscrib

[PATCH] sd: Fix maximum I/O size for BLOCK_PC requests

2015-07-15 Thread Martin K. Petersen
void using blk_queue_max_hw_sectors() and set the max_sectors queue limit directly. Also update the comment in blk_limits_max_hw_sectors() to clarify that max_hw_sectors defines the limit for the I/O controller only. Signed-off-by: Martin K. Petersen Reported-by: Brian King Tested-by: Brian King C

Re: [PATCH v2 3/4] target: Return descriptor format sense data in case the LU spans 64bit sectors

2015-07-16 Thread Martin K. Petersen
format sense Sagi> data to correctly report sector information. A-OK. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.

Re: [PATCH 1/1] Using the local variable instead of I/O flag to acquire io_req_lock in fnic_queuecommand() to avoid deadloack

2015-07-16 Thread Martin K. Petersen
/O flag and this could be modified if IO abort occurs Hiral> before I/O completion. In this case we wont release the lock and Hiral> causes deadlock in some scenerios. Using the local variable to Hiral> check the IO lock status will resolve the problem. Maybe bool instead of int?

Re: [PATCH 1/3] [RESEND] ipr: Fix locking for unit attention handling

2015-07-16 Thread Martin K. Petersen
ing lock_flags to hrrq_flags makes sense. But it muddles what is supposed to be a bugfix patch. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majo

Re: [PATCH 2/3] [RESEND] ipr: Fix incorrect trace indexing

2015-07-16 Thread Martin K. Petersen
g to us. This patch fixes this by removing the modulo and Brian> instead just mask off the low bits. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a mess

Re: [PATCH 3/3] [RESEND] ipr: Fix invalid array indexing for HRRQ

2015-07-16 Thread Martin K. Petersen
t; ipr_hrr_queue data, so bad things could certainly happen. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 14/20] scsi_dh_alua: parse target device id

2015-07-24 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> Can you move this to scsi_mod.ko? I'll need the same code Christoph> for the NFS SCSI layout driver soon. Same here. Working on copy offload again. -- Martin K. Petersen Oracle Linux Engineer

Re: [scsi 2/7 RESEND] scsi_debug: use SCSI_W_LUN_REPORT_LUNS instead of SAM2_WLUN_REPORT_LUNS;

2015-07-30 Thread Martin K. Petersen
>>>>> "Tomas" == Tomas Winkler writes: Tomas> use SCSI_W_LUN_REPORT_LUNS from scsi.h instead of localy defined Tomas> SAM2_WLUN_REPORT_LUNS Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: s

Re: [scsi 1/7 RESEND] scsi_debug: define pr_fmt() for consistent logging

2015-07-30 Thread Martin K. Petersen
>>>>> "Tomas" == Tomas Winkler writes: Tomas> Use pr_fmt with both module name and __func__ Also drop few bare Tomas> printk leftovers Tomas> The log format should stay pretty much intact Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle L

Re: [scsi 3/7 RESEND] scsi_debug: vfree is null safe so drop the check

2015-07-30 Thread Martin K. Petersen
>>>>> "Tomas" == Tomas Winkler writes: Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kern

Re: [scsi 4/7 RESEND] scsi_debug: make dump_sector static

2015-07-30 Thread Martin K. Petersen
>>>>> "Tomas" == Tomas Winkler writes: Tomas> fixes warning: warning: no previous prototype for ‘dump_sector’ Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [scsi 6/7 RESEND] scsi_debug: fix REPORT LUNS Well Known LU

2015-07-30 Thread Martin K. Petersen
is we set: max_lun = SCSI_W_LUN_REPORT_LUNS + 1; Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check

2015-07-30 Thread Martin K. Petersen
>>>>> "Tomas" == Tomas Winkler writes: Tomas> The function should never be called with cmnd NULL so put a fat Tomas> WARN there. Fix also smatch wraning: schedule_resp() warn: Tomas> variable dereferenced before check 'cmnd' Reviewed-by: Martin K. P

Re: [scsi 7/7] scsi_debug: resp_request: remove unused variable

2015-07-30 Thread Martin K. Petersen
>>>>> "Tomas" == Tomas Winkler writes: Tomas> Fixes the following warning In function ‘resp_requests’: Tomas> drivers/scsi//scsi_debug.c:1432:15: warning: variable Tomas> ‘want_dsense’ set but not used [-Wunused-but-set-variable] bool Tomas> dsense, want_dse

[PATCH] sd: Make discard granularity match logical block size when LBPRZ=1

2015-08-11 Thread Martin K. Petersen
thinp personality relies on the block layer's current behavior and is unable to deal with partial discard blocks we work around the problem by setting the granularity to match the logical block size when LBPRZ is enabled. Signed-off-by: Martin K. Petersen Cc: Mike Snitzer Cc: --- drivers/scsi

Re: [PATCH 1/6] block: cleanup blkdev_ioctl

2015-08-11 Thread Martin K. Petersen
s Christoph> actually need. Looks good. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/6] block: add a API for persistent reservations

2015-08-11 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Happy to see a generic interface for this. I wish PR semantics were simpler but the code looks good to me. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from

Re: [PATCH 3/6] sd: implement the persisten reservation API

2015-08-11 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Slightly more verbose patch description would be nice. Code looks OK. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH 1/7] megaraid_sas : Jbod sequence number support

2015-08-11 Thread Martin K. Petersen
_CFG_SEQ_NUM_SYNC *pd_seq_sync[2]; + dma_addr_t pd_seq_phys[2]; Please define a suitable constant for 2 and use it in the code. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/7] megaraid_sas : Support for max_io_size 1MB

2015-08-11 Thread Martin K. Petersen
priority; + u8 numSGEExt; /* 0x1E 1M IO support */ + u8 resvd2; /* 0x1F */ }; Mystery priority addition. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a me

Re: [PATCH 1/7] megaraid_sas : Jbod sequence number support

2015-08-13 Thread Martin K. Petersen
truct Sumit> MR_PD_CFG_SEQ_NUM_SYNC. That's why -1 here. OK. Just checking. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/6] arcmsr: use pci_alloc_irq_vectors

2016-10-11 Thread Martin K. Petersen
ph> vectors. Christoph> Otherwise this cleans up a lot of cruft and allows to use a Christoph> common request_irq loop for irq types, which happens to only Christoph> iterate over a single line in the non MSI-X case. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linu

Re: [PATCH 2/6] ipr: use pci_irq_allocate_vectors

2016-10-11 Thread Martin K. Petersen
ph> Otherwise this cleans up a lot of cruft and allows to use a Christoph> common request_irq loop for irq types, which happens to only Christoph> iterate over a single line in the non MSI-X case. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- T

Re: [PATCH] fnic: Use time64_t to represent trace timestamps

2016-10-11 Thread Martin K. Petersen
gt; with y2038 safe struct timespec64 and ktime_get_real_ts64(), Deepa> respectively. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majo

Re: [PATCH v2 0/3] hisi_sas add hip07 support

2016-10-11 Thread Martin K. Petersen
depending on the John> refclock rate. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2 0/7] libfc: sanitize kref and state machine fixes

2016-10-11 Thread Martin K. Petersen
updates the 'disc_mutex' handling to match the new kref usage. Hannes> There are also some state machine fixes to handle FLOGI better Hannes> and a fix from Chad to harden FCoE login. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubsc

Re: [RESEND PATCH v3] scsi: ufshcd: fix possible unclocked register access

2016-10-11 Thread Martin K. Petersen
> turned off, it could result into unclocked register access. Subhash> To prevent possible unclock register access, this change adds Subhash> one more argument to setup_clocks callback to let it know Subhash> whether it is called pre/post the clock changes by core driver. Appli

Re: [Resend PATCH] SCSI: scan: fix use-after-free

2016-10-11 Thread Martin K. Petersen
>>>>> "Ming" == Ming Lei writes: Ming> This patch fixes one use-after-free report[1] by KASAN. In Ming> __scsi_scan_target(), when a type 31 device is probed, Ming> SCSI_SCAN_TARGET_PRESENT is returned and the target will be Ming> scanned again. App

Re: [PATCH] scsi: replace wrong device handler name for CLARiiON arrays

2016-10-11 Thread Martin K. Petersen
>>>>> "Xose" == Xose Vazquez Perez writes: Xose> At drivers/scsi/device_handler/scsi_dh_emc.c it was defined as: Xose> #define CLARIION_NAME "emc" Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from th

Re: [PATCH] SCSI: remove one useless stack variable

2016-10-11 Thread Martin K. Petersen
>>>>> "Ming" == Ming Lei writes: Ming> The local variable of 'devname' in scsi_report_lun_scan() isn't Ming> used any more, so remove it. Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this l

Re: [PATCH 00/12] Fixes, cleanup and g_NCR5380_mmio/g_NCR5380 merger

2016-10-14 Thread Martin K. Petersen
0. Finn> I've tested this patch series on a Powerbook 180. If someone would Finn> test some of the other platforms that would be very helpful. All Finn> drivers were compile-tested. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe f

Re: [PATCH] mptscsih: remove bogus interpretation of request->ioprio

2016-10-14 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> Having an I/O priority does not mean we should send all Christoph> requests as HEAD OF QUEUE tags. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscrib

Re: [PATCH] MAINTAINERS: remove defunct iss storage mailing list

2016-10-14 Thread Martin K. Petersen
unknown in virtual alias table (in reply to RCPT TO command) Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: hpsa: remove unneeded void pointer cast

2016-10-14 Thread Martin K. Petersen
ed by memory allocation function to Javier> (BIG_IOCTL_Command_struct *) is useless. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.ke

Re: [patch] zfcp: spin_lock_irqsave() is not nestable

2016-10-14 Thread Martin K. Petersen
>>>>> "Steffen" == Steffen Maier writes: Steffen> could you please queue this as fix for one of my patches that Steffen> went into the 4.9 merge window, so for 4.9-rc I guess? Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To u

Re: [PATCH 1/1] [4.9-rc] ipr: Fix async error WARN_ON

2016-10-14 Thread Martin K. Petersen
interrupt context, which is what is causing the WARN_ON, just Brian> wake the ipr worker thread which will send a KOBJ_CHANGE uevent. Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi"

Re: [PATCH] scsi: ufs: changing maintainer

2016-10-14 Thread Martin K. Petersen
>>>>> "Joao" == Joao Pinto writes: Joao> I am going to leave Synopsys and so this patch changes the Joao> Maintainer for UFS Synopsys' specific drivers to my colleagues Joao> Manjunath and Prabu. Applied to 4.10/scsi-queue. -- Martin K. Petersen Ora

Re: [PATCH v3 00/17] lpfc: Update driver to version 11.2.0.2

2016-10-14 Thread Martin K. Petersen
>>>>> "James" == James Smart writes: James> This patch set updates the lpfc driver to revision 11.2.0.2 Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi&qu

Re: Patch: [Open-FCoE] Revert commit 3e22760d4db6fd89e0be46c3d132390a251da9c6 due to performance issues

2016-10-14 Thread Martin K. Petersen
db6fd89e0be46c3d132390a251da9c6 lands sup with large Laurence> count CPU systems seeing continual blk_requeue_request() calls Laurence> due to ML_QUEUE_HOST_BUSY. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the

Re: [PATCH 00/24] FCoE VN2VN fixes, part two

2016-10-14 Thread Martin K. Petersen
gt; - Correctly handle timed-out xids Hannes> Additionally there are some minor fixes to get things to work Hannes> when running with FCoE over virtio. Hannes> Patches are relative to mkp/4.10/scsi-queue. Hannes> As usual, comments and reviews are welcome. Somebody please review patches 11, 1

Re: [RESEND PATCH] scsi: ufs: fix race between clock gating and devfreq scaling work

2016-10-14 Thread Martin K. Petersen
h> this deadlock state: Somebody from the UFS camp, please review! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] Locking issue in libiscsi and be2iscsi

2016-10-14 Thread Martin K. Petersen
no spin_lock taken with IRQs Jitendra> disabled when calling into libiscsi, so no issues were found Jitendra> with use of spin_lock_bh/spin_unlock_bh except for one in Jitendra> iscsi_eh_cmd_timeout. Somebody please review. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe fr

Re: [PATCH 0/2] Locking issue in libiscsi and be2iscsi

2016-10-17 Thread Martin K. Petersen
no spin_lock taken with IRQs Jitendra> disabled when calling into libiscsi, so no issues were found Jitendra> with use of spin_lock_bh/spin_unlock_bh except for one in Jitendra> iscsi_eh_cmd_timeout. Jitendra> This needs to be applied on top 11.2.0.0 of be2iscsi committed Jitendra> in 4.9/s

  1   2   3   4   5   6   7   8   9   10   >