Re: [PATCH v5 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

2018-03-17 Thread Fengguang Wu
On Sat, Mar 17, 2018 at 11:07:27AM +1100, Benjamin Herrenschmidt wrote: On Sat, 2018-03-17 at 04:29 +0800, kbuild test robot wrote: Hi Benjamin, I love your patch! Perhaps something to improve: [auto build test WARNING on v4.16-rc4] [if your patch is applied to the wrong git tree, please drop

Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

2018-01-25 Thread Fengguang Wu
On Fri, Jan 26, 2018 at 10:58:56AM +1100, Benjamin Herrenschmidt wrote: On Wed, 2018-01-24 at 11:30 +0800, kbuild test robot wrote: Hi Benjamin, I love your patch! Perhaps something to improve: [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.15-rc9 next-20180119] [if

Re: [PATCH 13/13] usb: host: xhci-plat: Use of_device_get_match_data() helper

2017-10-08 Thread Fengguang Wu
kbuild just spit out the following warning for this patch: drivers/usb/host/max3421-hcd.c:1707:2-8: preceding lock on line 1702 Error ids grouped by kconfigs: recent_errors └── i386-allmodconfig └── drivers-usb-host-max3421-hcd.c:preceding-lock-on-line I don't really know what it means, a

Re: 4879b7ae05 ("Merge tag 'dmaengine-4.12-rc1' of .."): WARNING: kernel stack regs at bd92bc2e in 01-cpu-hotplug:3811 has bad 'bp' value 000001be

2017-10-03 Thread Fengguang Wu
Hi Josh, On Mon, Oct 02, 2017 at 04:31:09PM -0500, Josh Poimboeuf wrote: On Mon, Oct 02, 2017 at 04:26:54PM -0500, Josh Poimboeuf wrote: Fengguang, assuming it's reliably recreatable, any chance you could recreate with the following patch? Sorry, here's a version which actually compiles. dif

Re: 4879b7ae05 ("Merge tag 'dmaengine-4.12-rc1' of .."): WARNING: kernel stack regs at bd92bc2e in 01-cpu-hotplug:3811 has bad 'bp' value 000001be

2017-10-02 Thread Fengguang Wu
Hi Josh, On Mon, Oct 02, 2017 at 04:31:09PM -0500, Josh Poimboeuf wrote: On Mon, Oct 02, 2017 at 04:26:54PM -0500, Josh Poimboeuf wrote: Fengguang, assuming it's reliably recreatable, any chance you could recreate with the following patch? Sure, I'll try your patch on v4.14-rc3 since it looks

Re: [LKP] [usb] bea5b158ff WARNING: CPU: 0 PID: 25 at drivers/usb/core/urb.c:338 usb_submit_urb

2017-02-27 Thread Fengguang Wu
The dummy_udc WARN is gone with this patch for 100+ times of boot tests. Tested-by: Xiaolong Ye Thanks, Xiaolong Thanks, Xiaolong. I will submit a patch for it. Thank you Peter! We've been noised by this warning for quite some time. Fengguang -- To unsubscribe from this list: send the lin

[usb] bea5b158ff WARNING: CPU: 0 PID: 25 at drivers/usb/core/urb.c:338 usb_submit_urb

2017-02-26 Thread Fengguang Wu
[Sorry, resend to correct Felipe's email address] Greetings, This debug patch possibly discloses some USB/I2C bugs. Since the USB warning shows up earlier in dmesg, it might also be the root cause of the I2C bug. The attached reproduce-* script may help debug them. https://git.kernel.org/pub/scm

[usb] bea5b158ff WARNING: CPU: 0 PID: 25 at drivers/usb/core/urb.c:338 usb_submit_urb

2017-02-26 Thread Fengguang Wu
Greetings, This debug patch possibly discloses some USB/I2C bugs. Since the USB warning shows up earlier in dmesg, it might also be the root cause of the I2C bug. The attached reproduce-* script may help debug them. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit

Re: [usb:usb-next 124/126] ERROR: "ulpi_unregister_driver" [drivers/phy/phy-tusb1210.ko] undefined!

2016-09-11 Thread Fengguang Wu
On Mon, Sep 12, 2016 at 11:36:20AM +0800, Peter Chen wrote: On Mon, Sep 12, 2016 at 07:16:07AM +0800, kbuild test robot wrote: tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next head: ab57f86198d6ff20371613d4a02fd4841972a5c0 commit: ad764c49f65ac171e493e6baf39bc8ba

Re: [usb:usb-next 124/126] ERROR: "ulpi_unregister_driver" [drivers/phy/phy-tusb1210.ko] undefined!

2016-09-11 Thread Fengguang Wu
Hi Peter, On Mon, Sep 12, 2016 at 11:36:20AM +0800, Peter Chen wrote: On Mon, Sep 12, 2016 at 07:16:07AM +0800, kbuild test robot wrote: tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next head: ab57f86198d6ff20371613d4a02fd4841972a5c0 commit: ad764c49f65ac171e493e

Re: [PATCH] HID: fix noderef.cocci warnings

2016-06-20 Thread Fengguang Wu
> > sizeof when applied to a pointer typed expression gives the size of the > pointer > > Generated by: scripts/coccinelle/misc/noderef.cocci > > CC: Masaki Ota > Signed-off-by: Fengguang Wu > --- > > hid-alps.c |5 +++-- > 1 file changed, 3 inse

[PATCH] usb: gadget: f_hid: hidg_alloc() can be static

2014-11-12 Thread Fengguang Wu
drivers/usb/gadget/function/f_hid.c:852:21: sparse: symbol 'hidg_alloc' was not declared. Should it be static? Signed-off-by: Fengguang Wu --- f_hid.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadge

[PATCH] usb: gadget: fix ptr_ret.cocci warnings

2014-10-29 Thread Fengguang Wu
drivers/usb/gadget/udc/r8a66597-udc.c:1849:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by: Fengguang Wu --- r8a66597-udc.c |5 + 1 file changed, 1 insertion(+), 4

[xhci] kernel BUG at arch/x86/mm/physaddr.c:26!

2014-08-27 Thread Fengguang Wu
Hi Dan, Just in case it helps, here we find a different bug message in the same commit. git://git.kernel.org/pub/scm/linux/kernel/git/djbw/usb.git td-fragments-v1 commit e65e21a542cab81d794db4e5fe919c4e1d624ea7 Author: Dan Williams AuthorDate: Tue Jul 22 00:08:51 2014 -0700 Commit: Dan

drivers/usb/musb/tusb6010.c:946:2: error: implicit declaration of function 'irq_set_irq_type'

2013-03-28 Thread Fengguang Wu
Greetings, These *huge number* of *long standing* errors make me wonder whether the below USB driver code should be disabled on s390? tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux master head: 9064171268d838b8f283fe111ef086b9479d059a commit: dced35aeb0367dda2636ee9ee914bd

Re: [PATCH] usb/gadget: initialize gadget functions helper befor functions & gadgets

2013-03-05 Thread Fengguang Wu
On Tue, Mar 05, 2013 at 05:57:34PM +0800, Fengguang Wu wrote: > On Mon, Mar 04, 2013 at 10:28:09PM +0100, Sebastian Andrzej Siewior wrote: > > Fengguang Wu run into a kernel ops after he complied dummy_hcd and g_cdc > > into the kernel. The problem was that u_serial was used

Re: [PATCH] usb/gadget: initialize gadget functions helper befor functions & gadgets

2013-03-05 Thread Fengguang Wu
On Mon, Mar 04, 2013 at 10:28:09PM +0100, Sebastian Andrzej Siewior wrote: > Fengguang Wu run into a kernel ops after he complied dummy_hcd and g_cdc > into the kernel. The problem was that u_serial was used by g_cdc before > u_serial was initialized. In the module case eveything is initi

Re: [usb gadget] WARNING: at kernel/mutex.c:198 __mutex_lock_common()

2013-03-02 Thread Fengguang Wu
On Sat, Mar 02, 2013 at 02:41:07PM +0100, Sebastian Andrzej Siewior wrote: > On 03/02/2013 02:37 PM, Fengguang Wu wrote: > > On Wed, Feb 27, 2013 at 12:49:35PM +0200, Felipe Balbi wrote: > >> Hi, > >> > >> On Wed, Feb 06, 2013 at 10:04:24AM +0800, Fengguang Wu w

Re: [usb gadget] WARNING: at kernel/mutex.c:198 __mutex_lock_common()

2013-03-02 Thread Fengguang Wu
On Wed, Feb 27, 2013 at 12:49:35PM +0200, Felipe Balbi wrote: > Hi, > > On Wed, Feb 06, 2013 at 10:04:24AM +0800, Fengguang Wu wrote: > > Greetings, > > > > I got the below warning and the first bad commit is > > can you send a fixup patch ? Sorry I don'

[PATCH] usb: gadget: make gzero_options static

2013-02-02 Thread Fengguang Wu
Signed-off-by: Fengguang Wu --- drivers/usb/gadget/zero.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next.orig/drivers/usb/gadget/zero.c 2013-02-03 09:50:18.426689812 +0800 +++ linux-next/drivers/usb/gadget/zero.c2013-02-03 09:53:35.162694484 +0800 @@ -63,7

[PATCH] usb: gadget: make userial_init() static

2013-02-02 Thread Fengguang Wu
Signed-off-by: Fengguang Wu --- drivers/usb/gadget/u_serial.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next.orig/drivers/usb/gadget/u_serial.c 2013-02-03 09:50:18.422689811 +0800 +++ linux-next/drivers/usb/gadget/u_serial.c2013-02-03 09:50:27.570690026

Re: [balbi-usb:gadget 19/61] drivers/usb/gadget/mv_udc_core.c:1124:16: error: 'struct mv_usb_platform_data' has no member named 'phy_init'

2013-01-21 Thread Fengguang Wu
On Mon, Jan 21, 2013 at 10:13:43AM +0200, Felipe Balbi wrote: > On Sun, Jan 20, 2013 at 05:24:05PM -0800, Chao Xie wrote: [snip] > > I am formatting and re-test the patches. I will send out today. > > Thanks. > > > great, please make sure to compile test on x86 and ARM with > allyesconfig, allnoc

[PATCH] usb: misc: usb3503_probe() can be static

2013-01-11 Thread Fengguang Wu
Signed-off-by: Fengguang Wu --- drivers/usb/misc/usb3503.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next.orig/drivers/usb/misc/usb3503.c 2013-01-12 13:12:34.367933402 +0800 +++ linux-next/drivers/usb/misc/usb3503.c 2013-01-12 13:12:37.251933471 +0800 @@ -178,7

Re: [usb:usb-next 4/10] drivers/usb/misc/usb3503.c:238 usb3503_probe() error: we previously assumed 'pdata' could be null (see line 196)

2013-01-11 Thread Fengguang Wu
Dongjin, > Do I need to send another patch on top of it to fix the warning or Yes, you'll need to send another incremental fix to Greg. Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo i

[usb:usb-next 4/10] drivers/usb/misc/usb3503.c:238 usb3503_probe() error: we previously assumed 'pdata' could be null (see line 196)

2013-01-11 Thread Fengguang Wu
Dongjin Kim 2012-12-08 239 6a099c63 Dongjin Kim 2012-12-08 240dev_info(&i2c->dev, "%s: probed on %s mode\n", __func__, 6a099c63 Dongjin Kim 2012-12-08 241(hub->mode == USB3503_MODE_HUB) ? "hub" : "standby"); --- 0-DAY kernel build

[balbi-usb:gadget 13/13] drivers/usb/gadget/m66592-udc.c:1756:1: warning: data definition has no type or storage class

2013-01-10 Thread Fengguang Wu
--*/ 4cf2503c Yoshihiro Shimoda 2007-05-10 @1748 static struct platform_driver m66592_driver = { 598f22e1 Yoshihiro Shimoda 2007-07-17 1749 .remove = __exit_p(m66592_remove), 4cf2503c Yoshihiro Shimoda 2007-05-10 1750

Re: [net-next:master 209/235] drivers/net/usb/smsc95xx.c:1134:39-50: ERROR: reference preceded by free on line 1136

2012-11-08 Thread Fengguang Wu
ree(filter_mask); > >bbd9f9ee Steve Glendinning 2012-10-26 1137 > >check_warn_return(ret, "Error writing WUFF"); > >bbd9f9ee Steve Glendinning 2012-10-26 1138 } > >06a221be Ming Lei 2012-11-06 1139 > >k

Re: [usb:usb-next 92/93] drivers/usb/chipidea/../host/ehci.h:665:2: error: implicit declaration of function 'readl'

2012-11-03 Thread Fengguang Wu
On Fri, Nov 02, 2012 at 03:13:54PM -0400, Alan Stern wrote: > On Sat, 3 Nov 2012, Fengguang Wu wrote: > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > > usb-next > > head: bc8d51ea7e8ae0abb90fa89407b55a7e0bcb0a2a > > commit: 09f6ffde2e

[usb:usb-next 92/93] drivers/usb/chipidea/../host/ehci.h:665:2: error: implicit declaration of function 'readl'

2012-11-02 Thread Fengguang Wu
7 Benjamin Herrenschmidt 2006-12-15 679 } 8cd42e97 Kumar Gala 2006-01-20 680 --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu Intel Corporation -- To unsubscribe from this list: send the line

Re: [usb:usb-next 87/89] usbmisc_imx6q.c:(.text+0xa30): multiple definition of `ehci_init_driver'

2012-11-02 Thread Fengguang Wu
On Fri, Nov 02, 2012 at 11:13:56AM +0200, Felipe Balbi wrote: > Hi, > > On Fri, Nov 02, 2012 at 02:05:52AM +0800, kbuild test robot wrote: > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > > usb-next > > head: 99f91934a907df31ba878dfdd090002049dc476a > > commit: 3e02320

Re: [usb:usb-next 89/89] drivers/usb/host/ehci.h:662:3: error: implicit declaration of function 'readl_be'

2012-11-01 Thread Fengguang Wu
Hi Alan, > It's hard to know which headers are needed for foreign architectures. > Still, I think this ought to fix the problems you found. Can you test > this patch? Yes, it works. Thanks for the quick fix! Thanks, Fengguang > Index: usb-3.7/drivers/usb/host/ehci-platform.c > ==

[usb:usb-next 89/89] drivers/usb/host/ehci.h:662:3: error: implicit declaration of function 'readl_be'

2012-11-01 Thread Fengguang Wu
njamin Herrenschmidt 2006-12-28 676 #else 68f50e52 Al Viro2007-02-09 677 writel(val, regs); d728e327 Benjamin Herrenschmidt 2006-12-28 678 #endif --- 0-DAY kernel build testing backend Open Source Technology Center Fengguang Wu, Yuanhan Liu

Re: [balbi-usb:xceiv 3/3] drivers/usb/phy/rcar-phy.c:75:3: error: implicit declaration of function 'iowrite32'

2012-11-01 Thread Fengguang Wu
On Thu, Nov 01, 2012 at 04:47:14PM +0300, Max Filippov wrote: > On Thu, Nov 1, 2012 at 5:23 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Nov 01, 2012 at 06:04:20AM -0700, Greg KH wrote: > >> On Thu, Nov 01, 2012 at 12:50:34PM +0200, Felipe Balbi wrote: > >> > On Thu, Nov 01, 2012 at 12:33:39PM

Re: [balbi-usb:i2c-transferred-bytes-on-NACK 7/9] drivers/media/i2c/adv7604.c:406:9: warning: initialization makes integer from pointer without a cast

2012-10-24 Thread Fengguang Wu
On Wed, Oct 24, 2012 at 04:37:20PM +0300, Felipe Balbi wrote: > Hi, > > On Wed, Oct 24, 2012 at 09:23:23PM +0800, Fengguang Wu wrote: > > Sorry, this should really be CCed to the media list. > > I'll use the list recommended by get_maintainer.pl in future. > >

Re: [PATCH usb:usb-next] USB: ezusb: make some vars/funcs static

2012-09-28 Thread Fengguang Wu
On Thu, Sep 27, 2012 at 10:10:26AM -0700, Greg KH wrote: > On Thu, Sep 27, 2012 at 02:24:13PM +0800, Fengguang Wu wrote: > > Signed-off-by: Fengguang Wu > > --- > > drivers/usb/misc/ezusb.c | 16 > > 1 file changed, 8 insertions(+), 8 deleti

[PATCH usb:usb-next] USB: ezusb: make some vars/funcs static

2012-09-26 Thread Fengguang Wu
Signed-off-by: Fengguang Wu --- drivers/usb/misc/ezusb.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next head: 70c048a238c780c226eb4b115ebaa908cb3b34ec commit

[usb:usb-next 66/70] drivers/usb/storage/uas.c:638:12: sparse: context imbalance in 'uas_eh_task_mgmt' - wrong count at exit

2012-09-25 Thread Fengguang Wu
if (be16_to_cpu(devinfo->response.tag) != tag) { 668 shost_printk(KERN_INFO, shost, 669 "%s: %s failed (wrong tag %d/%d)\n", __func__, 670 fname, be16_to_cpu(devinfo->response.tag), tag); 671 return FAILED

usb-serial.c:1415 code aligned with following code on line 1416

2012-09-18 Thread Fengguang Wu
= serial_drivers; *sd; ++sd) { 1414 if ((*sd)->reset_resume) > 1415 udriver->reset_resume = usb_serial_reset_resume; > 1416 break; 1417 } --- 0-DAY kernel build testing backend Open Source Technology Centre

[usb:usb-next 25/32] drivers/usb/serial/omninet.c:165:6: warning: unused variable 'i'

2012-09-18 Thread Fengguang Wu
ty = tty_port_tty_get(&port->port); 175 if (tty) { --- 0-DAY kernel build testing backend Open Source Technology Centre Fengguang Wu, Yuanhan Liu Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-us

ehci-dbg.c:656 fill_periodic_buffer() warn: variable dereferenced before check 'p.qh' (see line 599)

2012-09-13 Thread Fengguang Wu
Open Source Technology Centre Fengguang Wu Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[usb:usb-next 141/145] drivers/usb/chipidea/udc.c:1683 udc_irq() warn: bitwise AND condition is false here

2012-09-13 Thread Fengguang Wu
spin_unlock(&ci->lock); 1687 1688 return retval; 1689 } 1690 1691 /** 1692 * udc_release: driver release function 1693 * @dev: device --- 0-DAY kernel build testing backend Open Source Technology Centre Fengguang Wu I

Re: [balbi-usb:merge-result-for-greg 66/99] drivers/usb/core/hub.c:2654 usb_get_hub_port_power_state() error: doing dma on the stack ((null))

2012-09-12 Thread Fengguang Wu
On Wed, Sep 12, 2012 at 03:02:13PM +0300, Felipe Balbi wrote: > Hi, > > On Wed, Sep 12, 2012 at 11:50:57AM +0300, Dan Carpenter wrote: > > On Wed, Sep 12, 2012 at 04:26:22PM +0800, Fengguang Wu wrote: > > > Hi Felipe, > > > > > > FYI, there are new sm

[balbi-usb:merge-result-for-greg 66/99] drivers/usb/core/hub.c:2654 usb_get_hub_port_power_state() error: doing dma on the stack ((null))

2012-09-12 Thread Fengguang Wu
3 return port_is_power_on(hub, portstatus); 2664 } --- 0-DAY kernel build testing backend Open Source Technology Centre Fengguang Wu Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body o

Re: [balbi-usb:master 33/36] drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from constant value (24000000 becomes 0)

2012-09-11 Thread Fengguang Wu
On Mon, Sep 10, 2012 at 07:05:15PM +0200, Sebastian Andrzej Siewior wrote: > On 09/10/2012 06:40 PM, Fengguang Wu wrote: > >tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git master > >head: d9c88901337158c9f253a7de58a10b5125d

[balbi-usb:master 33/36] drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from constant value (24000000 becomes 0)

2012-09-10 Thread Fengguang Wu
escriptor otg_descriptor = { 96 .bLength = sizeof otg_descriptor, 97 .bDescriptorType = USB_DT_OTG, 98 99 /* REVISIT SRP-only hardware is possible, although --- 0-DAY kernel build testing backend Open Source Technology Centre Fen

Re: [balbi-usb:master 18/19] drivers/usb/musb/musb_core.c:357:21: error: 'struct usb_phy' has no member named 'state'

2012-09-05 Thread Fengguang Wu
h to balbi's tree > for fixing this. > Also added you as a reviewer in the to list of the patch. > Plz verify and let me know if you still see any issues. It should be fine if you already verified the patch with allmodconfig build test. When a commit tagged with Reported-by: Feng

Re: BUG: unable to handle kernel paging request in usb_match_id()

2012-08-17 Thread Fengguang Wu
On Fri, Aug 17, 2012 at 05:27:08PM +0800, Fengguang Wu wrote: > Hi Bjørn, > > > -static const struct usb_device_id id_table[] __devinitconst = { > > +static const struct usb_device_id id_table[] = { > > Good catch! It magically fixed the oops. So that id_table w

Re: BUG: unable to handle kernel paging request in usb_match_id()

2012-08-17 Thread Fengguang Wu
Hi Bjørn, > -static const struct usb_device_id id_table[] __devinitconst = { > +static const struct usb_device_id id_table[] = { Good catch! It magically fixed the oops. So that id_table was freed sometime with __devinitconst? There are some more "usb_device_id .* __devinitconst" users in the sy

Re: BUG: unable to handle kernel paging request in usb_match_id()

2012-08-16 Thread Fengguang Wu
On Sun, Aug 05, 2012 at 09:58:26AM -0700, Greg KH wrote: > On Sun, Aug 05, 2012 at 10:59:38AM +0800, Fengguang Wu wrote: > > Hi all, > > > > This line triggers an oops in kvm boot test: > > > > usb_match_id(): > > ==> 748 for (; id->idVen