le_irq_event+0x58/0xc0
[] handle_fasteoi_irq+0x98/0x180
[] generic_handle_irq+0x24/0x38
[] __handle_domain_irq+0x60/0xac
[] gic_handle_irq+0xd4/0x17c
Cc: Andrzej Pietrasiewicz
Signed-off-by: Peter Chen
---
drivers/usb/gadget/configfs.c | 110 --
1 file changed,
Not every platform needs this regulator.
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
b/drivers/usb/chipidea/ci_hdrc_imx.c
index 16700170bc34..25a38ed27aa8 100644
--- a
- -EPROBE_DEFER is an error, but without need show error message
- If pintrol is not existed, as pintrol is NULL
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci_hdrc_imx.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/chipidea
For imx chipidea controllers, if they use mxs PHY, they need pinctrl
for HSIC. Otherwise, it doesn't need pinctrl and usbmisc control. Like
imx7d and imx8mm.
Reported-by: AndréDraszik
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci_hdrc_imx.c | 63 +-
1
mpatible = "nvidia,tegra114-udc",
> - .data = &tegra114_udc_soc_info,
> + .data = &tegra_udc_soc_info,
> }, {
> .compatible = "nvidia,tegra124-udc",
> - .data = &tegra124_udc_soc_info,
> + .data = &tegra_udc_soc_info,
> }, {
> /* sentinel */
> }
> --
> 2.17.1
>
Applied, thanks.
--
Thanks,
Peter Chen
of_property_read_bool(np, "usb-role-switch"))
> + data->usbmisc_data->ext_id = 1;
> +
> + if (!IS_ERR(pdata.vbus_extcon.edev) ||
> + of_property_read_bool(np, "usb-role-switch"))
> + data->usbmisc_data->ext_vbus = 1;
> + }
>
> ret = imx_usbmisc_init_post(data->usbmisc_data);
> if (ret) {
Applied, thanks.
--
Thanks,
Peter Chen
On 19-10-02 19:15:11, Igor Opaniuk wrote:
> + Li Jun
>
> Hi Peter, Li,
>
> On Mon, Sep 30, 2019 at 2:35 PM Igor Opaniuk wrote:
> >
> > Hi Peter,
> >
> > On Wed, Sep 25, 2019 at 3:44 AM Peter Chen wrote:
> > >
> > >
> > > &g
> On 29.9.2019 9.07, Peter Chen wrote:
> > On some situations, the software handles TRB events slower than adding
> > TRBs, then xhci_handle_event can't return zero long time, the xHC will
> > consider the event ring is full, and trigger "Event Ring Full" erro
st no chance to
update ERDP (event ring dequeue pointer).
In this commit, we force update ERDP if half of TRBS_PER_SEGMENT
events have handled to avoid "Event Ring Full" error.
Signed-off-by: Peter Chen
---
Changes for v2:
- If current ERDP value is the same with intended written on
*/
> - usleep_range(1000, 2000);
> + mdelay(1);
> cdns3_set_register_bit(&priv_dev->regs->usb_cmd,
>USB_CMD_STMODE |
>USB_STS_TMODE_SEL(tmode - 1));
> --
> 2.17.1
>
Reviewed-by: Peter Chen
Peter
On 19-09-26 13:25:39, Mathias Nyman wrote:
> On 24.9.2019 11.35, Peter Chen wrote:
> > On some situations, the software handles TRB events slower
> > than adding TRBs, then xhci_handle_event can't return zero
> > long time, the xHC will consider the event ring is full,
&
especially for VCO which has many stages, then
the multiwave will kept until PLL power down. Hold_ring_off(bit11) can
force the VCO in one determined state when VCO supply start ramp up, to
avoid this multiwave issue. Per IC design's suggestion it's better this
bit can be
On 19-09-23 16:46:56, Mathias Nyman wrote:
> On 23.9.2019 14.19, Mathias Nyman wrote:
> > On 19.9.2019 16.59, Suwan Kim wrote:
> > > On Thu, Sep 19, 2019 at 05:54:25PM +0800, Peter Chen wrote:
> > > > > On 17.9.2019 12.55, Peter Chen wrote:
> > > > &g
st no chance to
update ERDP (event ring dequeue pointer).
In this commit, we force update ERDP if half of TRBS_PER_SEGMENT
events have handled to avoid "Event Ring Full" error.
Signed-off-by: Peter Chen
---
drivers/usb/host/xhci-ring.c | 53
1 file chan
Vbus regualtor is an optional regulator, for platforms, which
doesn't have this regulator, it will get a dummy regulator and
show warning message.
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/chi
> On 17.9.2019 12.55, Peter Chen wrote:
> >>>
> >>> I met "event ring full error" like below, this error is met when
> >>> I do iozone test on UAS storage at v4.19.35 kernel, but not meet
> >>> this error at linux-next tree (08/24). T
On 19-09-13 10:47:58, André Draszik wrote:
> Hi Peter,
>
> On Tue, 2018-12-11 at 02:08 +0000, Peter Chen wrote:
> > To support imx HSIC, there are some special requirement:
> > - The HSIC pad is 1.2v, it may need to supply from external
> > - The data/strobe pin needs t
> > >I should add that the USB 2.0 spec includes the following text (from
> > >section
> 11.24.2.13):
> > >
> > >Test mode of a downstream facing port can only be used in
> > >a well defined sequence of hub states. This sequence is
> > >defined as follows:
> > >
> > >
> >>>
> >>> Further down in the mailing list chain Peter Chen states
> >>>> Besides, do not connect HUB between your host board and emulation
> >>>> board (for sending VID/PID).
> >>> but there is no additional information
sb_ehset_test: probe of failed with error -32
> for either the PCIe root hub or the USB3503 HSIC hub.
>
> Further down in the mailing list chain Peter Chen states
> > Besides, do not connect HUB between your host board and emulation board
> > (for sending VID/PID).
> but
f-by: Jun Li
Signed-off-by: Peter Chen
---
Jun, I changed a little for your patch, please check if it is OK.
drivers/usb/chipidea/udc.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index 59f
This API is used enable device function, it is called at below
situations:
- VBUS is connected during boots up
- Hot plug occurs during runtime
Signed-off-by: Peter Chen
Signed-off-by: Jun Li
---
drivers/usb/chipidea/udc.c | 63 +++---
1 file changed, 32
_lock_irqsave(&usbmisc->lock, flags);
> val = readl(usbmisc->base);
> if (enabled) {
> - writel(val | wakeup_setting, usbmisc->base);
> + val &= ~MX6_USB_OTG_WAKEUP_BITS;
> + val |= usbmisc_wakeup_setting(data);
> + writel(val, usbmisc->base);
> } else {
> if (val & MX6_BM_WAKEUP_INTR)
> dev_dbg(data->dev, "wakeup int\n");
> - writel(val & ~wakeup_setting, usbmisc->base);
> + writel(val & ~MX6_USB_OTG_WAKEUP_BITS, usbmisc->base);
> }
> spin_unlock_irqrestore(&usbmisc->lock, flags);
>
> --
> 2.7.4
>
This patch is ok for me, I will queue it from next -rc1.
--
Thanks,
Peter Chen
On 19-08-26 15:10:55, Peter Chen wrote:
> We meet several NULL pointer issues if configfs_composite_unbind
> and composite_setup (or composite_disconnect) are running together.
> These issues occur when do the function switch stress test, the
> configfs_compsoite_unbind is called from
Chuhong Yuan (1):
usb: chipidea: msm: Use device-managed registration API
Li Jun (1):
usb: chipidea: add role switch class support
Peter Chen (2):
dt-binding: usb: ci-hdrc-usb2: add imx7ulp compatible
dt-binding: usb: usbmisc-imx
On 19-08-26 18:25:12, jun...@nxp.com wrote:
> From: Li Jun
>
> USB role is fully controlled by usb role switch consumer(e.g. typec),
> usb port can be at host mode(USB_ROLE_HOST), device mode connected to
> host(USB_ROLE_DEVICE), or not connecting any partner(USB_ROLE_NONE).
>
> Signed-off-by: L
On 19-07-23 11:02:07, Chuhong Yuan wrote:
> Use devm_reset_controller_register to get rid
> of manual unregistration.
>
> Signed-off-by: Chuhong Yuan
> ---
> drivers/usb/chipidea/ci_hdrc_msm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/chipidea/ci_hd
el0_svc_handler+0x34/0x90
el0_svc+0x8/0xc
Code: aa1303e0 392c203f 97ff8732 f940a260 (f940)
It is very easy to reproduce it, just create ncm function,
and sleep 1 second, then, remove it.
I am not sure if it is the common issue for dwc3, there is no such
requirement for chipidea and cadence3. Would you please have a check?
Thanks.
Best regards,
Peter Chen
le_irq_event+0x58/0xc0
[] handle_fasteoi_irq+0x98/0x180
[] generic_handle_irq+0x24/0x38
[] __handle_domain_irq+0x60/0xac
[] gic_handle_irq+0xd4/0x17c
Signed-off-by: Peter Chen
---
drivers/usb/gadget/configfs.c | 110 --
1 file changed, 105 insertions(+), 5 deleti
On 19-08-23 01:59:24, Ran Wang wrote:
> HI Peter, Mathias,
>
> Sorry for the late review.
>
> On Friday, August 23, 2019 09:02, Peter Chen wrote:
> >
> > On 19-08-22 14:08:26, Mathias Nyman wrote:
> > > On 21.8.2019 6.18, Peter Chen wrote:
> > >
On 19-08-22 14:08:26, Mathias Nyman wrote:
> On 21.8.2019 6.18, Peter Chen wrote:
> > According to xHCI 1.1 CH4.19.4 Port Power:
> > While Chip Hardware Reset or HCRST is asserted,
> > the value of PP is undefined. If the xHC supports
> > powe
: Ran Wang
Signed-off-by: Peter Chen
---
drivers/usb/host/xhci.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 6b34a573c3d9..f5a7b5d63031 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host
Add imx7ulp and imx8qm compatible
Signed-off-by: Peter Chen
---
Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
index
Add imx7ulp compatible
Signed-off-by: Peter Chen
---
Documentation/devicetree/bindings/usb/usbmisc-imx.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
index a85a631ec434
41769810983&w=2.
Cc: #v4.9+
Signed-off-by: Peter Chen
---
This patch is at NXP internal tree long time, and no issues have found.
Submit to mainline kenrel.
drivers/usb/chipidea/udc.c | 32
1 file changed, 24 insertions(+), 8 deletions(-)
diff --git a/driv
Hi Greg,
When the driver enables runtime pm, it may cause the system hang
when plug out the cable from PC. The patch fixes this issue by
avoiding hardware accessing at this situation.
Peter Chen (1):
usb: chipidea: udc: don't do hardware access if gadget has stopped
drivers/usb/chi
41769810983&w=2.
Cc: #v4.9+
Signed-off-by: Peter Chen
---
This patch is at NXP internal tree long time, and no issues have found.
Submit to mainline kenrel.
drivers/usb/chipidea/udc.c | 32
1 file changed, 24 insertions(+), 8 deletions(-)
diff --git a/driv
>
> Changes for v3:
> - Remove the patch usb: chipidea: replace ci_role with usb_role
> as the existing ci->role usage can't map to usb_role.
> - Use the suggested ci_hdrc_cable for reuse current role change
> handling.
> - Fix build robot warning by add usb_role head file.
>
You may need
>
> Yes, driver frees not used buffers here.
> I think that it's the safest place for this purpose.
>
> >
> +dma_free_coherent(priv_dev->sysdev, buf-
> >size,
> + buf->buf,
> +
> > > USB role is fully controlled by usb role switch consumer(e.g.
> > > typec), usb port can be at host mode(USB_ROLE_HOST), device mode
> > > connected to host(USB_ROLE_DEVICE), or not connecting any
> parter(USB_ROLE_NONE).
> > >
> >
> > %s/parter/partner ?
>
> Yes, I will update.
>
> >
> >
> USB role is fully controlled by usb role switch consumer(e.g. typec), usb
> port can be
> at host mode(USB_ROLE_HOST), device mode connected to
> host(USB_ROLE_DEVICE), or not connecting any parter(USB_ROLE_NONE).
>
%s/parter/partner ?
Are there any ways you could get external cable status
>
> On Wed, Aug 07, 2019 at 10:47:49AM +0300, Felipe Balbi wrote:
> > Peter Chen writes:
> > >> (Pinging Mathias regarding xHCI support of the USB 2.0 test modes)
> > >>
> > >> On Mon, Aug 05, 2019 at 02:07:23PM +0800, Peter Chen wrote:
>
> Hi Everyone,
>
> (Pinging Mathias regarding xHCI support of the USB 2.0 test modes)
>
> On Mon, Aug 05, 2019 at 02:07:23PM +0800, Peter Chen wrote:
> > On Sun, Aug 4, 2019 at 10:45 AM Evan Gates wrote:
> > >
> > > I'm trying to get my
> >
> >
> > > >
> > > > You may use connect bit at portsc since VBUS may not connect to SoC.
> > >
> > > By this way, disconnect can be decided but connect is a problem in
> > > current driver, as controller was stopped in low power mode so can't
> > > detect connection from host, unless we also
> >
> > You may use connect bit at portsc since VBUS may not connect to SoC.
>
> By this way, disconnect can be decided but connect is a problem in current
> driver,
> as controller was stopped in low power mode so can't detect connection from
> host,
> unless we also update this behavior too.
On Sun, Aug 4, 2019 at 10:45 AM Evan Gates wrote:
>
> I'm trying to get my device to pass the EHSET tests. I found the thread
> "Using EHSET module" from March. I'm having similar issues.
>
> I don't have access to the PID VID board that the lab uses. Instead I'm
> using another computer setup
> > > > > USB role is fully controlled by usb role switch consumer(e.g.
> > > > > typec), usb port either at host mode, or at device connected
> > > > > mode, will not stay at USB_ROLE_NONE mode.
> > > > >
> > > >
> > > > Then, if the Type-C cable is disconnected from PC host, the
> > > > control
> >
> > > USB role is fully controlled by usb role switch consumer(e.g. typec),
> > > usb port either at host mode, or at device connected mode, will not
> > > stay at USB_ROLE_NONE mode.
> > >
> >
> > Then, if the Type-C cable is disconnected from PC host, the controller
> > driver can't be
> > n
> USB role is fully controlled by usb role switch consumer(e.g. typec),
> usb port either at host mode, or at device connected mode, will not
> stay at USB_ROLE_NONE mode.
>
Then, if the Type-C cable is disconnected from PC host, the controller
driver can't be notified?If that, how controller ente
provements, no function change.
Fabio Estevam (3):
usb: chipidea: Use dev_err() instead of pr_err()
usb: chipidea: imx: Use devm_platform_ioremap_resource()
usb: chipidea: msm: Use devm_platform_ioremap_resource()
>
> > Do you have any components at VBUS?
>
> There were ESD protection diodes that connected D+/D- with VBUS. We removed
> those from the PCB and the problem is gone meaning VBUS discharges as
> expected, the controller runtime-suspends and ultimately systemd-networkd
> reports
> a lost carr
> >
> > I suspect it is not related to USB, would you please disable USB node at
> > DTS to
> measure again?
>
> With USB disabled (&usbotg1 and &usbotg2), VBUS is available when I connect to
> the host and properly discharged when I disconnect.
> I also tried the OTG's host mode yesterday. Whe
>
> Hi Felipe,
>
> Would you please have a review for Patch 1 and Patch 2 in this series?
> Thanks.
>
Ping...
The DTS and controller patches have already queued. Thanks.
Peter
> Peter
>
> > Signed-off-by: Peter Chen
> > ---
>
> Peter Chen writes:
> > That's very strange, that means the SoC doesn't know VBUS fails down after
> detaching from the host.
> > You could measure the VBUS value at the board, then read the VBUS value at
> register to confirm it.
>
> I have put a scope on
> > I have rebooted with 4.9:
> > [0.658594] ci_hdrc ci_hdrc.0: entering suspend
> > # ConfigFS setup in userspace
> > [9.925361] ci_hdrc ci_hdrc.0: leaving suspend
> > [ 12.081571] ci_hdrc ci_hdrc.0: entering suspend
> > # Attach a cable
> > [ 37.869333] ci_hdrc ci_hdrc.0: leaving s
> Felipe Balbi writes:
> > Kai Ruhnau writes:
> >>> Which peripheral controller is this board using? Is it chipidea? dwc2?
> >>> dwc3? High Speed or Super Speed?
> >>
> >> According to the device tree it's 'fsl,imx6sx-usb' driven by
> >> chipidea/ci_hdrc_imx.c
> >> When connecting to Windows, the
> In case usb phy mode is other than USBPHY_INTERFACE_MODE_HSIC the pinctrl
> for device is not acquired. It is however used later regardless of the mode,
> hence
> leads to requesting access to uninitialized data.
>
> Signed-off-by: Krzysztof Michonski
> ---
> drivers/usb/chipidea/ci_hdrc_im
> On 19-06-26 02:40, Peter Chen wrote:
> >
> > > Subject: [PATCH] ARM: imx25: provide a fixed regulator for usb phys
> > >
> > > The usb phys are internal to the SoC and so it their 5V supply. With
> > > this regulator added explicitly the foll
> Subject: [PATCH] ARM: imx25: provide a fixed regulator for usb phys
>
> The usb phys are internal to the SoC and so it their 5V supply. With this
> regulator
> added explicitly the following (harmless) boot messages go away:
>
> usb_phy_generic usbphy:usb-phy@0: usbphy:usb-phy@0 supply
> At imx7ulp, the USB related analog register is located in PHY register
> region too, so we need to control PLL at PHY driver directly.
>
Hi Felipe,
Would you please have a review for Patch 1 and Patch 2 in this series?
Thanks.
Peter
> Signed-off-by: Peter Chen
> ---
> d
Since the chipidea common code support get the USB PHY phandle from
"phys", the glue layer is not mandatory to get the "fsl,usbphy" phandle
any more.
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci_hdrc_imx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Add compatible string for imx7ulp
Reviewed-by: Rob Herring
Signed-off-by: Peter Chen
---
Documentation/devicetree/bindings/usb/usbmisc-imx.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
b/Documentation/devicetree/bindings/usb
Add imx7ulp USBOTG1 support.
Signed-off-by: Peter Chen
---
arch/arm/boot/dts/imx7ulp.dtsi | 28
1 file changed, 28 insertions(+)
diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
index d6b711011cba..2679856aaf65 100644
--- a/arch/arm/boot
Enable USBOTG1 support for evk board, it is dual-role function
port.
Signed-off-by: Peter Chen
---
arch/arm/boot/dts/imx7ulp-evk.dts | 35 +++
1 file changed, 35 insertions(+)
diff --git a/arch/arm/boot/dts/imx7ulp-evk.dts
b/arch/arm/boot/dts/imx7ulp-evk.dts
In this commit, we add CI_HDRC_PMQOS to avoid system entering idle,
at imx7ulp, if the system enters idle, the DMA will stop, so the USB
transfer can't work at this case.
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci_hdrc_imx.c | 28 +++-
drivers/usb/chi
Add compatible string for imx7ulp.
Reviewed-by: Rob Herring
Signed-off-by: Peter Chen
---
Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
b/Documentation/devicetree/bindings/usb
At imx7ulp, the USB related analog register is located in PHY register
region too, so we need to control PLL at PHY driver directly.
Signed-off-by: Peter Chen
---
drivers/usb/phy/phy-mxs-usb.c | 67 ++-
1 file changed, 66 insertions(+), 1 deletion
Rob.
There is a dual-role USB controller at imx7ulp, we add support for it
in this patch set, and the dual-role function is tested at imx7ulp-evk
board.
Thanks.
Peter Chen (8):
doc: dt-binding: mxs-usb-phy: add compatible for 7ulp
usb: phy: phy-mxs-usb: add imx7ulp support
doc: dt-binding: ci
Add compatible for 7ulp USB PHY.
Reviewed-by: Rob Herring
Signed-off-by: Peter Chen
---
Documentation/devicetree/bindings/phy/mxs-usb-phy.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
b/Documentation/devicetree
Hi Greg,
We have found an IP bug recently, it will cause the audio device
stop working at the HUB downstream face port, and the commit can
reduce the possibilities for failures, needs to improve RTL code
to fix it totally.
Peter Chen (1):
usb: chipidea: udc: workaround for endpoint conflict
could do is numbering isochronous IN from the highest endpoint since we
have observed most of device number endpoint from the lowest.
Cc: #v3.14+
Cc: Fabio Estevam
Cc: Greg KH
Cc: Sergei Shtylyov
Cc: Jun Li
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/udc.c | 20
1
> >
> > Signed-off-by: Peter Chen
> > ---
> > arch/arm/boot/dts/imx7ulp.dtsi | 28
> > 1 file changed, 28 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi
> > b/arch/arm/boot/dts/imx7ulp.dtsi index
Since the chipidea common code support get the USB PHY phandle from
"phys", the glue layer is not mandatory to get the "fsl,usbphy" phandle
any more.
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci_hdrc_imx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Add compatible string for imx7ulp
Reviewed-by: Rob Herring
Signed-off-by: Peter Chen
---
Documentation/devicetree/bindings/usb/usbmisc-imx.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
b/Documentation/devicetree/bindings/usb
At imx7ulp, the USB related analog register is located in PHY register
region too, so we need to control PLL at PHY driver directly.
Signed-off-by: Peter Chen
---
drivers/usb/phy/phy-mxs-usb.c | 67 ++-
1 file changed, 66 insertions(+), 1 deletion
Enable USBOTG1 support for evk board, it is dual-role function
port.
Signed-off-by: Peter Chen
---
arch/arm/boot/dts/imx7ulp-evk.dts | 35 +++
1 file changed, 35 insertions(+)
diff --git a/arch/arm/boot/dts/imx7ulp-evk.dts
b/arch/arm/boot/dts/imx7ulp-evk.dts
In this commit, we add CI_HDRC_PMQOS to avoid system entering idle,
at imx7ulp, if the system enters idle, the DMA will stop, so the USB
transfer can't work at this case.
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci_hdrc_imx.c | 28 +++-
drivers/usb/chi
Add imx7ulp USBOTG1 support.
Signed-off-by: Peter Chen
---
arch/arm/boot/dts/imx7ulp.dtsi | 28
1 file changed, 28 insertions(+)
diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
index fca6e50f37c8..5115e47715c3 100644
--- a/arch/arm/boot
Add compatible string for imx7ulp.
Reviewed-by: Rob Herring
Signed-off-by: Peter Chen
---
Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
b/Documentation/devicetree/bindings/usb
ual-role function is tested at imx7ulp-evk
board.
Thanks.
Peter Chen (8):
doc: dt-binding: mxs-usb-phy: add compatible for 7ulp
usb: phy: phy-mxs-usb: add imx7ulp support
doc: dt-binding: ci-hdrc-usb2: add compatible string for imx7ulp
doc: dt-binding: usbmisc-imx: add compatible string fo
Add compatible for 7ulp USB PHY.
Reviewed-by: Rob Herring
Signed-off-by: Peter Chen
---
Documentation/devicetree/bindings/phy/mxs-usb-phy.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
b/Documentation/devicetree/bindings/phy/mxs
> > Signed-off-by: Peter Chen
> > ---
> > arch/arm/boot/dts/imx7ulp.dtsi | 31 +++
> > 1 file changed, 31 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi
> > b/arch/arm/boot/dts/imx7ulp.dtsi index fca6e
could do is numbering isochronous IN from the highest endpoint since we
have observed most of device number endpoint from the lowest.
Cc: #v3.14+
Cc: Fabio Estevam
Cc: Greg KH
Cc: Sergei Shtylyov
Cc: Jun Li
Signed-off-by: Peter Chen
---
Changes for v3:
- Using MACRO to simply the code
- One
On Thu, May 30, 2019 at 10:14 PM Fabio Estevam wrote:
>
> Hi Peter,
>
> On Thu, May 30, 2019 at 5:50 AM Peter Chen wrote:
> >
> > An endpoint conflict occurs when the USB is working in device mode
> > during an isochronous communication. When the endpointA IN dire
could do is numbering isochronous IN from the highest endpoint since we
have observed most of device number endpoint from the lowest.
Cc: Sergei Shtylyov
Cc: Jun Li
Signed-off-by: Peter Chen
---
Changes for v2:
- Improve the code sytle
drivers/usb/chipidea/udc.c | 23 +++
1
> On 30.05.2019 9:45, Peter Chen wrote:
>
> > An endpoint conflict occurs when the USB is working in device mode
> > during an isochronous communication. When the endpointA IN direction
> > is an isochronous IN endpoint, and the host sends an IN token to
> > end
could do is numbering isochronous IN from the highest endpoint since we
have observed most of device number endpoint from the lowest.
Cc: #v3.14+
Cc: Jun Li
Signed-off-by: Peter Chen
---
Changes for v2:
- Some coding style improvements
drivers/usb/chipidea/udc.c | 24
1
On Mon, May 27, 2019 at 5:04 PM Sergei Shtylyov
wrote:
>
> On 27.05.2019 10:42, Peter Chen wrote:
>
> > An endpoint conflict occurs when the USB is working in device mode
> > during an isochronous communication. When the endpointA IN direction
> > is an isochronous IN e
could do is numbering isochronous IN from the highest endpoint since we
have observed most of device number endpoint from the lowest.
Cc: #v3.14+
Cc: Jun Li
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/udc.c | 24
1 file changed, 24 insertions(+)
diff --git a
Add compatible string for imx7ulp.
Reviewed-by: Rob Herring
Signed-off-by: Peter Chen
---
Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
b/Documentation/devicetree/bindings/usb
In this commit, we add CI_HDRC_PMQOS to avoid system entering idle,
at imx7ulp, if the system enters idle, the DMA will stop, so the USB
transfer can't work at this case.
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci_hdrc_imx.c | 28 +++-
drivers/usb/chi
Add imx7ulp USBOTG1 support.
Signed-off-by: Peter Chen
---
arch/arm/boot/dts/imx7ulp.dtsi | 31 +++
1 file changed, 31 insertions(+)
diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
index fca6e50f37c8..37b058119505 100644
--- a/arch/arm
Add compatible string for imx7ulp
Reviewed-by: Rob Herring
Signed-off-by: Peter Chen
---
Documentation/devicetree/bindings/usb/usbmisc-imx.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
b/Documentation/devicetree/bindings/usb
Enable USBOTG1 support for evk board, it is dual-role function
port.
Signed-off-by: Peter Chen
---
arch/arm/boot/dts/imx7ulp-evk.dts | 35 +++
1 file changed, 35 insertions(+)
diff --git a/arch/arm/boot/dts/imx7ulp-evk.dts
b/arch/arm/boot/dts/imx7ulp-evk.dts
Add compatible for 7ulp USB PHY.
Reviewed-by: Rob Herring
Signed-off-by: Peter Chen
---
Documentation/devicetree/bindings/phy/mxs-usb-phy.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
b/Documentation/devicetree/bindings/phy/mxs
last patch that "fsl,usbphy" phandle is not mandatory now
[Patch 8/8]
- Add Reviewed-by from Rob.
There is a dual-role USB controller at imx7ulp, we add support for it
in this patch set, and the dual-role function is tested at imx7ulp-evk
board.
Thanks.
Peter Chen (8):
doc: dt-bindin
At imx7ulp, the USB related analog register is located in PHY register
region too, so we need to control PLL at PHY driver directly.
Signed-off-by: Peter Chen
---
drivers/usb/phy/phy-mxs-usb.c | 67 ++-
1 file changed, 66 insertions(+), 1 deletion
Since the chipidea common code support get the USB PHY phandle from
"phys", the glue layer is not mandatory to get the "fsl,usbphy" phandle
any more.
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci_hdrc_imx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
> > 1 file changed, 31 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi
> > b/arch/arm/boot/dts/imx7ulp.dtsi index fca6e50f37c8..60c9ea116d0a
> > 100644
> > --- a/arch/arm/boot/dts/imx7ulp.dtsi
> > +++ b/arch/arm/boot/dts/imx7ulp.dtsi
> > @@ -30,6 +30,7 @@
> > serial
> > Signed-off-by: Peter Chen
> > ---
> > drivers/usb/phy/phy-mxs-usb.c | 76
> > ++-
> > 1 file changed, 75 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/phy/phy-mxs-usb.c
> > b/
1 - 100 of 3915 matches
Mail list logo
