properly initialize their sg tables when
CONFIG_DEBUG_SG is enabled.
Signed-off-by: Akinobu Mita
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: Michael Ellerman
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-a...@vger.kernel.org
---
* New patch from v2
arch/powerpc/kernel/vio.c | 10
2015-01-23 5:41 GMT+09:00 Kim Phillips :
> On Thu, 22 Jan 2015 10:45:51 +0900
> Joonsoo Kim wrote:
>
>> On Wed, Jan 21, 2015 at 09:57:59PM +0900, Akinobu Mita wrote:
>> > 2015-01-21 9:07 GMT+09:00 Andrew Morton :
>> > > On Tue, 20 Jan 2015 15:01:
2015-01-21 9:07 GMT+09:00 Andrew Morton :
> On Tue, 20 Jan 2015 15:01:50 -0800 j...@joshtriplett.org wrote:
>
>> On Tue, Jan 20, 2015 at 02:02:00PM -0600, Kim Phillips wrote:
>> > It's possible to configure DEBUG_PAGEALLOC without PAGE_POISONING on
>> > ppc. Fix building the generic kernel_map_pag
The BITOP_LE_SWIZZLE macro was used in the little-endian bitops functions
for powerpc. But these functions were converted to generic bitops and
the BITOP_LE_SWIZZLE is not used anymore.
Signed-off-by: Akinobu Mita
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linuxppc-dev@lists.ozlabs.org
d rename it along the way.
>
> Signed-off-by: Benjamin Herrenschmidt
Looks good.
Acked-by: Akinobu Mita
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
convert to use
asm-generic/bitops/le.h for powerpc.
Signed-off-by: Akinobu Mita
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linuxppc-dev@lists.ozlabs.org
---
arch/powerpc/include/asm/bitops.h | 55 +--
1 file changed, 1 insertion(+), 54 deletions
Replace BITOP_MASK and BITOP_WORD with BIT_MASK and BIT_WORD defined
in linux/bitops.h and remove BITOP_* which are not used anymore.
Signed-off-by: Akinobu Mita
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linuxppc-dev@lists.ozlabs.org
---
arch/powerpc/include/asm/bitops.h | 20
- Caluculate the bitmap size with BITS_TO_LONGS()
- Use bitmap_empty() to verify that all bits are cleared
This also includes a printk to pr_warn() conversion.
Signed-off-by: Akinobu Mita
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linuxppc-dev@lists.ozlabs.org
---
arch/powerpc
2012/7/4 Andrew Morton :
> On Sat, 30 Jun 2012 14:59:24 +0900
> Akinobu Mita wrote:
>
>> This provides kernel modules that can be used to test the error handling
>> of notifier call chain failures by injecting artifical errors to the
>> following notifier chain c
interface to control what error code
should be returned and which event should be failed.
Signed-off-by: Akinobu Mita
Cc: Pavel Machek
Cc: "Rafael J. Wysocki"
Cc: linux...@lists.linux-foundation.org
Cc: Greg KH
Cc: linux...@kvack.org
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc
even if PM_DEBUG is disabled
- make CONFIG_PM_NOTIFIER_ERROR_INJECTION default if PM_DEBUG is enabled
Akinobu Mita (6):
fault-injection: notifier error injection
cpu: rewrite cpu-notifier-error-inject module
PM: PM notifier error injection module
memory: memory notifier error injection module
powerpc: pSeries recon
error handling by injecting notifier errors
7. Online all hot-pluggable memory in preparation for testing
8. Test memory hot-remove error handling by injecting notifier errors
Signed-off-by: Akinobu Mita
Suggested-by: Andrew Morton
Cc: Pavel Machek
Cc: "Rafael J. Wysocki"
to "actions//error".
Signed-off-by: Akinobu Mita
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linuxppc-dev@lists.ozlabs.org
---
No changes since v4
lib/Kconfig.debug| 17 +
lib/Makefile |2 +
lib/pSerie
2012/6/27 Andrew Morton :
> On Sat, 23 Jun 2012 23:58:22 +0900
> Akinobu Mita wrote:
>
>> This adds two testing scripts with notifier error injection
>
> Can we move these into tools/testing/selftests/, so that a "make
> run_tests" runs these tests?
>
> A
in preparation for testing
2. Test memory hot-add error handling by injecting notifier errors
3. Online all hot-pluggable memory in preparation for testing
4. Test memory hot-remove error handling by injecting notifier errors
Signed-off-by: Akinobu Mita
Suggested-by: Andrew Morton
Cc: Pavel
to "actions//error".
Signed-off-by: Akinobu Mita
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linuxppc-dev@lists.ozlabs.org
---
* v4
- update modules to follow new interface
lib/Kconfig.debug| 17 +
lib/Makefile
interface to control what error code
should be returned and which event should be failed.
Signed-off-by: Akinobu Mita
Cc: Pavel Machek
Cc: "Rafael J. Wysocki"
Cc: linux...@lists.linux-foundation.org
Cc: Greg KH
Cc: linux...@kvack.org
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc
y allow valid errno to be injected (-MAX_ERRNO <= errno <= 0)
- improve Kconfig help text
- make CONFIG_PM_NOTIFIER_ERROR_INJECTION visible even if PM_DEBUG is disabled
- make CONFIG_PM_NOTIFIER_ERROR_INJECTION default if PM_DEBUG is enabled
Akinobu Mita (6):
fault-injection: notifier error inj
- Use memchr_inv to check if the data contains all 0xFF bytes.
It is faster than looping for each byte.
- Use memcmp to compare memory areas
Signed-off-by: Akinobu Mita
Cc: Benjamin Herrenschmidt
Cc: linuxppc-dev@lists.ozlabs.org
---
arch/powerpc/platforms/powermac/nvram.c | 42
preparation for testing
4. Test CPU hot-remove error handling by injecting notifier errors
* tools/testing/fault-injection/memory-notifier.sh is doing the same thing
for memory hotplug notifier.
Signed-off-by: Akinobu Mita
Suggested-by: Andrew Morton
Cc: Pavel Machek
Cc: "Rafael J. Wy
the error code. If the notifier call chain should be failed
with some events notified, write the error code to the files.
This module needs pSeries_reconfig_notifier_{,un}register symbols to be
exported.
Signed-off-by: Akinobu Mita
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linuxppc-dev
interface to control what error code
should be returned and which event should be failed.
Signed-off-by: Akinobu Mita
Cc: Pavel Machek
Cc: "Rafael J. Wysocki"
Cc: linux...@lists.linux-foundation.org
Cc: Greg KH
Cc: linux...@kvack.org
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc
the error code. If the notifier call chain should
be failed with some events notified, write the error code to the files.
Signed-off-by: Akinobu Mita
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linuxppc-dev@lists.ozlabs.org
---
- Nothing changed from v1
arch/powerpc/platforms/pseries
interface to control what error code
should be returned and which event should be failed.
Signed-off-by: Akinobu Mita
Cc: Pavel Machek
Cc: "Rafael J. Wysocki"
Cc: linux...@lists.linux-foundation.org
Cc: Greg Kroah-Hartman
Cc: linux...@kvack.org
Cc: Benjamin Herrenschmidt
Cc: Paul Mac
2011/7/4 Pavel Machek :
>
>> + for (action = enb->actions; action->name; action++) {
>> + struct dentry *file = debugfs_create_int(action->name, mode,
>> + enb->dir, &action->error);
>> +
>> + if (!file) {
>> +
the error code. If the notifier call chain should
be failed with some events notified, write the error code to the files.
Signed-off-by: Akinobu Mita
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linuxppc-dev@lists.ozlabs.org
---
arch/powerpc/platforms/pseries/reconfig.c | 31
interface to control what error code
should be returned and which event should be failed.
Signed-off-by: Akinobu Mita
Cc: Pavel Machek
Cc: "Rafael J. Wysocki"
Cc: Greg Kroah-Hartman
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linux...@lists.linux-foundation.org
Cc: linux...@kv
with notifier_from_errno().
Signed-off-by: Akinobu Mita
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linuxppc-dev@lists.ozlabs.org
---
arch/powerpc/kernel/prom.c |8 +++-
arch/powerpc/platforms/pseries/hotplug-cpu.c| 10 +++---
arch/powerpc/platforms
This introduces pSeries_reconfig_notify() as a just wrapper of
blocking_notifier_call_chain() for pSeries_reconfig_chain.
This is a preparation to improvement of error code on reconfiguration
notifier failure.
Signed-off-by: Akinobu Mita
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc
2011/2/7 Benjamin Herrenschmidt :
> On Thu, 2011-01-27 at 22:56 +0900, Akinobu Mita wrote:
>> (This patch is intended to be folded into the patch in -mm:
>> powerpc-introduce-little-endian-bitops.patch)
>>
>> The little-endian bitops on powerpc are written as preproces
that is a Very Bad Thing.
This converts the little-endian bitops macros to static inline functions
with proper prototypes.
Suggested-by: "H. Peter Anvin"
Signed-off-by: Akinobu Mita
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linuxppc-dev@lists.ozlabs.org
---
arch/powerpc/
Introduce little-endian bit operations by renaming existing powerpc
native little-endian bit operations and changing them to take any
pointer types.
Signed-off-by: Akinobu Mita
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linuxppc-dev@lists.ozlabs.org
---
Change from v4:
- change the
Introduce little-endian bit operations by renaming existing powerpc
native little-endian bit operations.
Signed-off-by: Akinobu Mita
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linuxppc-dev@lists.ozlabs.org
---
The whole series is available in the git repository at:
git
Simplify read file operation for /proc/powerpc/rtas/* interface
by using simple_read_from_buffer.
Signed-off-by: Akinobu Mita
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linuxppc-dev@lists.ozlabs.org
---
arch/powerpc/kernel/rtas_flash.c | 53 -
1
Simplify several write fileoperations for spufs by using
simple_write_to_buffer().
Signed-off-by: Akinobu Mita
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: Jeremy Kerr
Cc: linuxppc-dev@lists.ozlabs.org
Cc: cbe-oss-...@lists.ozlabs.org
---
arch/powerpc/platforms/cell/spufs/file.c | 27
/test_and_set_le_bit/
s/generic_test_and_clear_le_bit/test_and_clear_le_bit/
Signed-off-by: Akinobu Mita
Acked-by: Arnd Bergmann
Acked-by: Hans-Christian Egtvedt
Cc: Geert Uytterhoeven
Cc: Roman Zippel
Cc: Andreas Schwab
Cc: linux-m...@lists.linux-m68k.org
Cc: Greg Ungerer
Cc: Benjamin Herrenschmidt
/test_and_set_le_bit/
s/generic_test_and_clear_le_bit/test_and_clear_le_bit/
Signed-off-by: Akinobu Mita
Cc: Hans-Christian Egtvedt
Cc: Geert Uytterhoeven
Cc: Roman Zippel
Cc: Andreas Schwab
Cc: linux-m...@lists.linux-m68k.org
Cc: Greg Ungerer
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linuxppc
clk_get() should return an ERR_PTR value on error, not NULL.
Signed-off-by: Akinobu Mita
Cc: Grant Likely
Cc: linuxppc-dev@lists.ozlabs.org
---
arch/powerpc/platforms/512x/clock.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/platforms/512x/clock.c
b
Replace open-coded rate limiting logic with __ratelimit().
Signed-off-by: Akinobu Mita
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linuxppc-...@ozlabs.org
---
arch/powerpc/platforms/iseries/pci.c | 10 +++---
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/arch
2009/10/29 Andrew Morton :
>
> Why were these patches resent? What changed?
>
> Everybody who is going to review these patches has already reviewed
> them and now they need to review them all again?
I resent the patches because the iommu-helper change was not correct
and I introduced serious bug
t bit of the limit in bitmap
4. Remove iommu_area_free, iommu_area_reserve, and find_next_zero_area
Signed-off-by: Akinobu Mita
Cc: "David S. Miller"
Cc: sparcli...@vger.kernel.org
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linuxppc-...@ozlabs.org
Cc: Thomas Gleixner
Cc: Ingo
= bitmap size
Signed-off-by: Akinobu Mita
Cc: FUJITA Tomonori
Cc: "David S. Miller"
Cc: sparcli...@vger.kernel.org
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linuxppc-...@ozlabs.org
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc: x...@kernel.org
Cc: Gr
>> >> --- a/lib/iommu-helper.c
>> >> +++ b/lib/iommu-helper.c
>> >> @@ -19,7 +19,7 @@ again:
>> >> index = (index + align_mask) & ~align_mask;
>> >>
>> >> end = index + nr;
>> >> - if (end >= size)
>> >> + if (end > size)
>> >
>> > I think that this is intentional; the last byte
2009/10/17 FUJITA Tomonori :
> On Tue, 13 Oct 2009 18:10:17 +0900
> Akinobu Mita wrote:
>
>> My user space testing exposed off-by-one error find_next_zero_area
>> in iommu-helper. Some zero area cannot be found by this bug.
>>
>> Subject: [PATCH] Fix off-by
From: Akinobu Mita
Subject: Fix
bitmap-introduce-bitmap_set-bitmap_clear-bitmap_find_next_zero_area.patch
- Rewrite bitmap_set and bitmap_clear
Instead of setting or clearing for each bit.
- Fix off-by-one errors in bitmap_find_next_zero_area
This bug was derived from find_next_zero_area
On Wed, Oct 14, 2009 at 08:54:47AM +1100, Michael Ellerman wrote:
> On Tue, 2009-10-13 at 18:10 +0900, Akinobu Mita wrote:
> > My user space testing exposed off-by-one error find_next_zero_area
> > in iommu-helper.
>
> Why not merge those tests into the kernel as a configur
Update PATCH 2/8 based on review comments by Andrew and bugfix
exposed by user space testing.
I didn't change argument of align_mask at this time because it
turned out that it needs more changes in iommu-helper users.
From: Akinobu Mita
Subject: Fix
bitmap-introduce-bitmap_set-bitmap_
My user space testing exposed off-by-one error find_next_zero_area
in iommu-helper. Some zero area cannot be found by this bug.
Subject: [PATCH] Fix off-by-one error in find_next_zero_area
Signed-off-by: Akinobu Mita
---
lib/iommu-helper.c |2 +-
1 files changed, 1 insertions(+), 1
On Fri, Oct 09, 2009 at 04:41:00PM -0700, Andrew Morton wrote:
> On Fri, 9 Oct 2009 17:29:15 +0900
> Akinobu Mita wrote:
>
> > This introduces new bitmap functions:
> >
> > bitmap_set: Set specified bit area
> > bitmap_clear: Clear specified bit area
> >
Cc: FUJITA Tomonori
Signed-off-by: Akinobu Mita
---
arch/powerpc/kernel/iommu.c |4 +-
arch/sparc/kernel/iommu.c|3 +-
arch/x86/kernel/amd_iommu.c |4 +-
arch/x86/kernel/pci-calgary_64.c |6 ++--
arch/x86/kernel/pci-gart_64.c|6 ++--
include/linux/iommu
eter Anvin"
Cc: x...@kernel.org
Cc: Greg Kroah-Hartman
Cc: Lothar Wassmann
Cc: linux-...@vger.kernel.org
Cc: Roland Dreier
Cc: Yevgeny Petrilin
Cc: net...@vger.kernel.org
Cc: Tony Luck
Cc: Fenghua Yu
Cc: linux-i...@vger.kernel.org
Cc: linux-al...@sgi.com
Signed-off-by: Akinobu Mita
---
Looks good. I tested it on x86_32.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
On Wed, Apr 01, 2009 at 04:33:31PM -0500, Kumar Gala wrote:
> The following commit breaks PPC builds with CONFIG_HIGHMEM=y
>
> commit f4112de6b679d84bd9b9681c7504be7bdfb7c7d5
> Author: Akinobu Mita
> Date: Tue Mar 31 15:23:25 2009 -0700
>
> mm: introduce debug_kmap_a
2007/7/4, Jan-Bernd Themann <[EMAIL PROTECTED]>:
> diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
> index bdb5241..f8c0908 100644
> --- a/drivers/net/ehea/ehea_main.c
> +++ b/drivers/net/ehea/ehea_main.c
> @@ -2923,6 +2923,15 @@ static int check_module_parm(void)
>
54 matches
Mail list logo
