[LyX/master] QFontMetrics::xHeight() is not always the ascent of 'x'

commit 194b53ef9d2896664772a12c0038eedd717daec3 Author: Jean-Marc Lasgouttes Date: Mon Sep 23 19:15:20 2024 +0200 QFontMetrics::xHeight() is not always the ascent of 'x' Use the real ascent of glyph 'x' as LyX 2.3.x did. It can make a difference at least

[LyX/2.4.x] Do not use big characters for some unicode points

commit cc1fca88688a77e3c6e9f4b25909c095827b6cac Author: Jean-Marc Lasgouttes Date: Mon Sep 23 19:42:29 2024 +0200 Do not use big characters for some unicode points This modifies LOGICAL AND, LOGICAL OR, INTERSECTION and UNION. Fixes bug #13099. (cherry picked

[LyX/master] Do not use big characters for some unicode points

commit edf56d644d9eb25258f996e0806233851b2a19fb Author: Jean-Marc Lasgouttes Date: Mon Sep 23 19:42:29 2024 +0200 Do not use big characters for some unicode points This modifies LOGICAL AND, LOGICAL OR, INTERSECTION and UNION. Fixes bug #13099. --- lib/unicodesymbols | 8

[LyX/master] Move assertion at the right position

commit 77e4092b99e79c68edb055c006062de9f4420ceb Author: Jean-Marc Lasgouttes Date: Thu Sep 19 23:17:48 2024 +0200 Move assertion at the right position It would wrongly trigger when doing a multi-cell selection. --- src/Statistics.cpp | 2 +- 1 file changed, 1 insertion(+), 1

[LyX/master] More places where DocumentClassPtr should not be copied

commit 928f9514a890edf37e298e419104a98c4ebfe844 Author: Jean-Marc Lasgouttes Date: Sat Sep 14 20:40:53 2024 +0200 More places where DocumentClassPtr should not be copied Spotted by COverity scan. --- src/CutAndPaste.cpp | 10 +- src/CutAndPaste.h | 2 +- 2 files

[LyX/master] Pass sigPtr object as const reference too

commit 8c76a9fc3da7ab200f36e501ca67fc0421f0517e Author: Jean-Marc Lasgouttes Date: Sat Sep 14 20:36:04 2024 +0200 Pass sigPtr object as const reference too Spotted by Coverity scan. --- src/support/ForkedCalls.cpp | 2 +- src/support/ForkedCalls.h | 2 +- 2 files changed, 2

[LyX/master] Pass SocketCallback object as const reference

commit 980f91d12ee9f47ad944ec0f0befb9c638511bdc Author: Jean-Marc Lasgouttes Date: Sat Sep 14 20:19:34 2024 +0200 Pass SocketCallback object as const reference Spotted by Coverity scan. --- src/frontends/qt/GuiApplication.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[LyX/master] Transform CoordCache::check/checkDim in ASSERT_DIM/POS macros

commit 375aba7b5d8404511553e4e2d6154476bd00fcf2 Author: Jean-Marc Lasgouttes Date: Fri Sep 13 15:41:53 2024 +0200 Transform CoordCache::check/checkDim in ASSERT_DIM/POS macros This makes it more obvious to the reader that these are actually assertions, and should help Coverity

[LyX/master] Pass shared_ptr<> arguments by const reference

commit 3af0bad22a9f6200fcfc09534f5c0925ad63271c Author: Jean-Marc Lasgouttes Date: Fri Sep 13 14:54:43 2024 +0200 Pass shared_ptr<> arguments by const reference These arguments are not expensive to copy. However, it makes sense to pass such pointers by const referenc

[LyX/master] Pass DocumentClassConstPtr arguments by const reference

commit 58ee4c9ec74172b7600f1cc5d2299eba465496d7 Author: Jean-Marc Lasgouttes Date: Fri Sep 13 14:16:21 2024 +0200 Pass DocumentClassConstPtr arguments by const reference This arguments are shared_ptr objects, so they are not expensive to copy. However, it makes sense to pass

[LyX/master] Make two parameters const references

commit 3649cea9e59ecbf1c1831c54781a7aaff342714f Author: Jean-Marc Lasgouttes Date: Fri Sep 13 11:27:00 2024 +0200 Make two parameters const references --- src/insets/InsetIndexMacro.cpp | 2 +- src/insets/InsetIndexMacro.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

[LyX/master] Fix uninitialized variable

commit ffca6730d6fd97ec9be1bbf70eabd2ef9835f607 Author: Jean-Marc Lasgouttes Date: Fri Sep 13 11:21:19 2024 +0200 Fix uninitialized variable Spotted by Coverity scan. --- src/frontends/qt/GuiWorkArea.cpp | 2 +- src/frontends/qt/GuiWorkArea_Private.h | 2 +- 2 files changed

[LyX/master] Do not use rand() to set a BranchList id

commit 9f40eaee15d53ce418a728d3ff3716541d35775f Author: Jean-Marc Lasgouttes Date: Fri Sep 13 11:07:05 2024 +0200 Do not use rand() to set a BranchList id Use a simple counting instead, beecause Coverity complains that rand() is not safe, and counting is siimpler anyway

[LyX/master] Make string parameter a const reference

commit 9b3c28178cf8835213e9da418dc66208a9afd6cd Author: Jean-Marc Lasgouttes Date: Fri Sep 13 10:27:24 2024 +0200 Make string parameter a const reference Spotted by Coverity scan. --- src/frontends/qt/GuiDelimiter.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[LyX/master] Avoid a couple of copies.

commit 8e181e992da3054fc1a0221615f9dd4920332ace Author: Jean-Marc Lasgouttes Date: Thu Sep 12 18:33:45 2024 +0200 Avoid a couple of copies. Spotted by Coverity scan. --- src/frontends/qt/Menus.cpp | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src

[LyX/master] Make docstring parameters const references

commit 7a99ef7fbbe5760e7d70e8ef6b446aebb0af04e2 Author: Jean-Marc Lasgouttes Date: Thu Sep 12 18:28:26 2024 +0200 Make docstring parameters const references Spotted by Coverity scan. --- src/insets/InsetLabel.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[LyX/master] Graph::getReachable(): pass a parameter by const reference

commit b743870d71db1c13e10078e1bb7028e9db1af377 Author: Jean-Marc Lasgouttes Date: Thu Sep 12 18:20:43 2024 +0200 Graph::getReachable(): pass a parameter by const reference Spotted by coverity. --- src/Graph.cpp | 5 ++--- src/Graph.h | 4 ++-- 2 files changed, 4 insertions

[LyX/master] Avoid a copy

commit b1bbf64a28331c6b5eb3f5fb987d2e88d30167bc Author: Jean-Marc Lasgouttes Date: Thu Sep 12 18:05:50 2024 +0200 Avoid a copy Spotted by Coverity scan. --- src/Buffer.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Buffer.cpp b/src/Buffer.cpp index

[LyX/master] Avoid a couple of copies

commit cc40330e00cc8a222f31c53551873f5d2ae66b14 Author: Jean-Marc Lasgouttes Date: Thu Sep 12 17:59:41 2024 +0200 Avoid a couple of copies Spotted by Coverity scan. --- src/insets/InsetCitation.cpp | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src

[LyX/master] GuiWorkArea: pass KeySymbol parameters as const references

commit 91f3f27545121e5869c74db8d68a34908ab01ad4 Author: Jean-Marc Lasgouttes Date: Thu Sep 12 17:52:57 2024 +0200 GuiWorkArea: pass KeySymbol parameters as const references Spotted by Coverity scan. --- src/frontends/qt/GuiWorkArea.cpp | 2 +- src/frontends/qt/GuiWorkArea.h | 6

[LyX/master] Avoid a couple copies in Trans::addDeadKeys().

commit 8ea9c2da03d97be8cd74d90bf4deed5f405d16df Author: Jean-Marc Lasgouttes Date: Thu Sep 12 17:24:32 2024 +0200 Avoid a couple copies in Trans::addDeadKeys(). Spotted by Coverity scan. --- src/Trans.cpp | 10 ++ src/Trans.h | 3 +++ 2 files changed, 5 insertions

[LyX/master] TransState::addkey() pass parameter by const reference

commit 7946dfacfa57f031ec5de9a03e63937578fe9430 Author: Jean-Marc Lasgouttes Date: Thu Sep 12 16:54:02 2024 +0200 TransState::addkey() pass parameter by const reference Spotted by Coverity scan. --- src/Trans.cpp | 6 +++--- src/Trans.h | 10 +- 2 files changed, 8

[LyX/master] Pass three string parameters by address

commit eeb84bce17f74cba1c6482411fa14434a9703b7f Author: Jean-Marc Lasgouttes Date: Wed Sep 11 17:33:52 2024 +0200 Pass three string parameters by address Spoted by Coverity scan. --- src/lyxfind.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src

[LyX/master] Pass a docstring parameter by address

commit 13b05102f2d9dcecd9d0fe24e49000867c5b835a Author: Jean-Marc Lasgouttes Date: Wed Sep 11 17:30:33 2024 +0200 Pass a docstring parameter by address Spotted by Coverity scan. --- src/insets/InsetCommandParams.cpp | 2 +- src/insets/InsetCommandParams.h | 2 +- 2 files

[LyX/master] Pass a pair of docstring arguments by address

commit e6930ffec8be56f3a54dbf17f499ec14dd0cd59a Author: Jean-Marc Lasgouttes Date: Wed Sep 11 17:25:03 2024 +0200 Pass a pair of docstring arguments by address Spotted by Coverity scan. --- src/frontends/qt/GuiCitation.cpp | 2 +- src/frontends/qt/GuiCitation.h | 4 ++-- 2

[LyX/master] Avoid an unnecessary string copy

commit 851e59cd2657a73a5fd376d01ce2d1dfc336fe23 Author: Jean-Marc Lasgouttes Date: Wed Sep 11 17:08:45 2024 +0200 Avoid an unnecessary string copy Spotted by Coverity scan. --- src/LyXVC.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/LyXVC.cpp b/src

[LyX/master] Pass arguments by address in convert() templates

commit a47d66df34d27742d21efd84e662031d4c0a0a60 Author: Jean-Marc Lasgouttes Date: Wed Sep 11 16:43:26 2024 +0200 Pass arguments by address in convert() templates The situation of the convert<>() template was a mess: the header announced that template specializations

[LyX/master] Fix linking of test programs in support/.

commit 291d2db18ed8e7a886a349b5138367233577f537 Author: Jean-Marc Lasgouttes Date: Wed Sep 11 16:42:41 2024 +0200 Fix linking of test programs in support/. --- src/support/Makefile.am | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/support/Makefile.am b/src

[LyX/master] Pass parameters of constructor by address

commit 100075c8901a72d875f90f2e46ef02af29dc2f6f Author: Jean-Marc Lasgouttes Date: Wed Sep 11 16:25:45 2024 +0200 Pass parameters of constructor by address Spotted by Coverity scan. --- src/insets/InsetNomencl.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[LyX/master] Fixup 716e20ae: revert useless part

commit 951cb62f47a73fca8c9724f5d385280d79344740 Author: Jean-Marc Lasgouttes Date: Wed Sep 11 13:37:32 2024 +0200 Fixup 716e20ae: revert useless part --- development/coverity_modeling.cpp | 11 --- 1 file changed, 11 deletions(-) diff --git a/development/coverity_modeling.cpp b

[LyX/master] Limit the number of iterations for some tabular features in math

commit 716e20ae1bd7ab012c953d1dad18c88859e4252d Author: Jean-Marc Lasgouttes Date: Wed Sep 11 13:29:20 2024 +0200 Limit the number of iterations for some tabular features in math Try to please Coverity scan. --- development/coverity_modeling.cpp | 11 +++ src/mathed

[LyX/master] Make some code that handle authors more readable

commit 3f5b836aa9f263e8680d80726cae35a245495b5a Author: Jean-Marc Lasgouttes Date: Tue Sep 10 15:29:36 2024 +0200 Make some code that handle authors more readable Create accssors authodmap() in BufferParams. Use [] operator instead of find(). Hopefully this will

[LyX/2.4.x] Initialize client's name in main()

commit 2c5f284f895356647cda38d3dccdaa53c984e6ae Author: Jean-Marc Lasgouttes Date: Mon Sep 9 15:29:39 2024 +0200 Initialize client's name in main() Initializing clientName at declaration time is not a good idea. Spotted by Coverity scan. (cherry picked

[LyX/2.4.x] Do not forget to reset stream after std::hex

commit 615f03585431adafa49a3110842dacca1435bed6 Author: Jean-Marc Lasgouttes Date: Mon Sep 9 17:49:20 2024 +0200 Do not forget to reset stream after std::hex Spotted by Coverity scan. (cherry picked from commit f4c02d670b60a56bc6fb4a49e201c7134af1011b) --- src/frontends

Re: [LyX/master] Initialize client's name in main()

Le 09/09/2024 à 15:33, Jean-Marc Lasgouttes a écrit : commit 3d323412ad5b4d47774de43f985202f20cabd156 Author: Jean-Marc Lasgouttes Date: Mon Sep 9 15:29:39 2024 +0200 Initialize client's name in main() Initializing clientName at declaration time is not a good idea. Th

[LyX/master] Improve coverity modeling

commit 2ea95fa71bf2085a1e8753df968f31bf43a80e73 Author: Jean-Marc Lasgouttes Date: Mon Sep 9 17:50:01 2024 +0200 Improve coverity modeling This tells coverity that these functions terminate the program. --- development/coverity_modeling.cpp | 13 + 1 file changed, 13

[LyX/master] Do not forget to reset stream after std::hex

commit f4c02d670b60a56bc6fb4a49e201c7134af1011b Author: Jean-Marc Lasgouttes Date: Mon Sep 9 17:49:20 2024 +0200 Do not forget to reset stream after std::hex Spotted by Coverity scan. --- src/frontends/qt/GuiWorkArea.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[LyX/master] Do not handle special case where buffer == NULL

commit 6687b34c072064950ff52efd79439fa4fc03604f Author: Jean-Marc Lasgouttes Date: Mon Sep 9 15:52:01 2024 +0200 Do not handle special case where buffer == NULL If it is so, we have already crashed in isBranchSelected() above. (and hopefully, buffer_ is never null these

[LyX/master] Do not access current_view_ if it is NULL

commit ffde470363c0bfafc915751fa788a34d4c9e06b8 Author: Jean-Marc Lasgouttes Date: Mon Sep 9 15:35:57 2024 +0200 Do not access current_view_ if it is NULL Spotted by Coverity scan. --- src/frontends/qt/GuiApplication.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[LyX/master] Initialize client's name in main()

commit 3d323412ad5b4d47774de43f985202f20cabd156 Author: Jean-Marc Lasgouttes Date: Mon Sep 9 15:29:39 2024 +0200 Initialize client's name in main() Initializing clientName at declaration time is not a good idea. Spotted by Coverity scan. --- src/client/client.cpp

[LyX/master] Fixup b8cdfd1e1db: fix thinko

commit 12d771c43fc121c89e6df5ae1e0b6aedc11d799e Author: Jean-Marc Lasgouttes Date: Mon Sep 9 15:19:25 2024 +0200 Fixup b8cdfd1e1db: fix thinko Spotted by Coverity. --- src/KeyMap.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/KeyMap.cpp b/src

[LyX/master] Do not use lyxerr in from_ascii(char const *)

commit ed291f0d4fbc778229840a9ad830c2481aa60bbd Author: Jean-Marc Lasgouttes Date: Mon Sep 9 12:08:23 2024 +0200 Do not use lyxerr in from_ascii(char const *) This function is used a lot to initialize static docstrings. This is an issue in theory because lyxerr may not have

[LyX/master] Remove handling of dispatched() property in BufferView::dispatch

commit e5c31699b4d8fd13c71212158d835c7fa750100f Author: Jean-Marc Lasgouttes Date: Fri Sep 6 16:21:47 2024 +0200 Remove handling of dispatched() property in BufferView::dispatch As indicated in DispatchResult.h, this is only needed in insets' doDispatch() methods, where

[LyX/master] Add ScrollType BOTTOM and TOGGLE for BufferView::scrollToCursor()

commit 6c20e5db7db662239e8c2bd47fe28d18b27bd729 Author: Jean-Marc Lasgouttes Date: Thu Sep 5 22:05:38 2024 +0200 Add ScrollType BOTTOM and TOGGLE for BufferView::scrollToCursor() BOTTOM shows the paragraph containing the cursor at the bottom of the work area. TOGGLE

[LyX/master] Cleanup Page Up/Down code

commit 9c443d965114318dacbb67db68f5a3fd9b1b8fc2 Author: Jean-Marc Lasgouttes Date: Wed Sep 4 15:48:38 2024 +0200 Cleanup Page Up/Down code Since BufferView::scroll() does not correct scrolling amount at top/bottom anymore, remove its return value and add a new one to

[LyX/master] Get rid of BufferView::scrollUp/Down

commit 439b7bb9c97ba2f267a4ccc9ae3d9af5eab100f9 Author: Jean-Marc Lasgouttes Date: Tue Sep 3 18:13:02 2024 +0200 Get rid of BufferView::scrollUp/Down LFUN_SCROLL was the last user, change it to use only scroll(). Take this opportunity to improve a bit this dispatch code

[LyX/master] Streamline BufferView::scrollToCursor

commit f52842d289d1434c44ffb4c9971279a8e56af612 Author: Jean-Marc Lasgouttes Date: Tue Sep 3 16:21:32 2024 +0200 Streamline BufferView::scrollToCursor There are two parts in this patch : 1/ in the part where the cursor is already visible, replace calls to scroll

[LyX/master] Simplify greatly Buffer::scroll/Up/Down methods

commit 86d2313ce323fd20fadd63f103625e15704ae527 Author: Jean-Marc Lasgouttes Date: Tue Sep 3 15:55:34 2024 +0200 Simplify greatly Buffer::scroll/Up/Down methods The code there that checks whether we scroll beyond the top/bottom of document is not needed anymore, this is

[LyX/2.4.x] Fix update of cursor in tab-delete when there is a selection

commit 5ca48a7a39e7211bf9f55487d8de38821c8613e6 Author: Jean-Marc Lasgouttes Date: Fri Aug 30 16:56:16 2024 +0200 Fix update of cursor in tab-delete when there is a selection The position of the cursor should not be decreased if it is already at the start of the paragraph

[LyX/2.4.x] Avoid missing updates after some operations on selection

commit 4d46f766ea3f24608b8b7b418893054bfa7495dd Author: Jean-Marc Lasgouttes Date: Fri Aug 30 17:26:48 2024 +0200 Avoid missing updates after some operations on selection The logic at the end of Text::dispatch failed when needsUpdate and singleParUpdate were true at the same

[LyX/2.4.x] Get rid of QPA_XCB define

commit d7e2ca377f9fab169431e41e820973fad49224b5 Author: Jean-Marc Lasgouttes Date: Thu Aug 29 11:15:26 2024 +0200 Get rid of QPA_XCB define Since the platform is selected at run time (e.g. xcb vs. Wayland), it is not a good idea to decide at compile time what code is run

[LyX/2.4.x] Streamline -geometry command-line option support

commit 390f45812202a80d80b27a2191c1b8e1ce5f0190 Author: Jean-Marc Lasgouttes Date: Thu Aug 29 11:10:31 2024 +0200 Streamline -geometry command-line option support Instead of baking our own support for -geometry command line option on Windows (Qt only does that for Xcb), use

[LyX/master] Fix update of cursor in tab-delete when there is a selection

commit 16be88ca18719a98a555ced268431ca1040658b7 Author: Jean-Marc Lasgouttes Date: Fri Aug 30 16:56:16 2024 +0200 Fix update of cursor in tab-delete when there is a selection The position of the cursor should not be decreased if it is already at the start of the paragraph

[LyX/2.4.x] Fixup e2cf6731: fix thinko

commit 76ef192214237a5ac11edfd9c09062131eabde12 Author: Jean-Marc Lasgouttes Date: Fri Aug 30 15:07:03 2024 +0200 Fixup e2cf6731: fix thinko The current buffer is part of allRelatives(), contrary to what I thought. Therefore updateId() increased the buffer id by two

[LyX/master] Fixup 999fb37e: fix thinko

commit 2eb4e3d3ca063d12371695282ae0bc3d9609ab06 Author: Jean-Marc Lasgouttes Date: Fri Aug 30 15:07:03 2024 +0200 Fixup 999fb37e: fix thinko The current buffer is part of allRelatives(), contrary to what I thought. Therefore updateId() increased the buffer id by two. --- src

[LyX/master] update comments

commit 53c8e0b77d2fbc62bf7d895714977d906122657f Author: Jean-Marc Lasgouttes Date: Fri Aug 30 14:53:07 2024 +0200 update comments --- src/Buffer.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Buffer.h b/src/Buffer.h index 2cd1495796..d4e8db8748 100644 --- a

[LyX/master] Remove legacy code to compute geometry

commit 3c59a9a23cdcae77fd0b85dc2d66d86fe611d051 Author: Jean-Marc Lasgouttes Date: Fri Aug 30 14:31:47 2024 +0200 Remove legacy code to compute geometry This code is not necessary anymore after the fix to #13069. Remove the first QString argument to createView(). Set the

[LyX/master] Get rid of QPA_XCB define

commit 18c310a8cf60ebc8cab27aeea6fc0a6e1fcc7fcc Author: Jean-Marc Lasgouttes Date: Thu Aug 29 11:15:26 2024 +0200 Get rid of QPA_XCB define Since the platform is selected at run time (e.g. xcb vs. Wayland), it is not a good idea to decide at compile time what code is run

[LyX/master] Streamline -geometry command-line option support

commit ce9de28f06eb770ae440992fb8ca8b98a07c1cfd Author: Jean-Marc Lasgouttes Date: Thu Aug 29 11:10:31 2024 +0200 Streamline -geometry command-line option support Instead of baking our own support for -geometry command line option on Windows (Qt only does that for Xcb), use

[LyX/2.4.x] Do not run updateMacros if the buffer has not changed

commit e2cf6731c0ca3a3d4edec19a24754a8ddcbd3284 Author: Jean-Marc Lasgouttes Date: Sat Jul 20 22:31:34 2024 +0200 Do not run updateMacros if the buffer has not changed Each buffer now has an id which is increased when it is marked dirty (or when one of its relatives is marked

[LyX/2.4.x] Force a metrics update of buffer after reload

commit f06de64047f5b9d3e3033ed208c832c263779497 Author: Jean-Marc Lasgouttes Date: Tue Aug 27 00:09:04 2024 +0200 Force a metrics update of buffer after reload It makes reload more robust and is in any case good enough to avoid crash in #139091. Fixes bug #13091

[LyX/master] Force a metrics update of buffer after reload

commit 52ec69a1af7f8c860d6f1d6ed6337db58d5ce163 Author: Jean-Marc Lasgouttes Date: Tue Aug 27 00:09:04 2024 +0200 Force a metrics update of buffer after reload It makes reload more robust and is in any case good enough to avoid crash in #139091. Fixes bug #13091

Re: [LyX/master] Transform InsetNomenclature to a collapsible

Le 12/08/2024 à 12:35, Juergen Spitzmueller a écrit : commit a5841b3312d549bb7984ea8382afe490129c0750 Author: Juergen Spitzmueller Date: Mon Aug 12 12:33:16 2024 +0200 Transform InsetNomenclature to a collapsible Looks like a good move! JMarc Fixes: #10460, #12595, #6353

[LyX/master] Fixup 999fb37e: always run updateMacros when in batch mode

commit fe1a3b57df2cd6adf1bd4752d05b1aae40a4e5b7 Author: Jean-Marc Lasgouttes Date: Thu Jul 25 18:30:38 2024 +0200 Fixup 999fb37e: always run updateMacros when in batch mode The optimization is useful in GUI mode only, and it turns out that it creates weird crashes otherwise

[LyX/2.4.x] Make scrolling-by-selection smoother

commit 73bfef16f3d5a9fe1064dfb8b2782bf82111e4c0 Author: Jean-Marc Lasgouttes Date: Sat Jul 20 19:47:32 2024 +0200 Make scrolling-by-selection smoother This trivial patch makes scrolling-by-selection smoother by dividing the step size and the time between steps by 8 when

[LyX/master] Do not update statisitics if buffer has not changed

commit 0d50a8417f059f7bffc86b562817042564970c05 Author: Jean-Marc Lasgouttes Date: Wed Jul 24 22:19:32 2024 +0200 Do not update statisitics if buffer has not changed Rely on the newly-introduced Buffer::id() to skip statistics computation if the id is the same as last time

[LyX/master] fix warning

commit a042d6a9d2a2762f78c51891dc3e6263bc28a126 Author: Jean-Marc Lasgouttes Date: Wed Jul 24 21:08:53 2024 +0200 fix warning --- src/insets/InsetTabular.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/insets/InsetTabular.h b/src/insets/InsetTabular.h index

[LyX/master] Fixup 6e81f317: cut and paste error

commit 393f65c737b7857ba2cc610b15fe085d34dfb231 Author: Jean-Marc Lasgouttes Date: Wed Jul 24 18:51:35 2024 +0200 Fixup 6e81f317: cut and paste error --- src/BufferView.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/BufferView.cpp b/src/BufferView.cpp index

[LyX/master] Do not run updateMacros if the buffer has not changed

commit 999fb37ebb1aecfda9889fa6a2b2fbb15133f2aa Author: Jean-Marc Lasgouttes Date: Sat Jul 20 22:31:34 2024 +0200 Do not run updateMacros if the buffer has not changed Each buffer now has an id which is increased when it is marked dirty (or when one of its relatives is marked

[LyX/2.4.x] Do not export the content of InsetMathBoxed as text in MathML

commit 2baa292314cad5255f6779339de3f646dc9d8a2a Author: Jean-Marc Lasgouttes Date: Tue Jul 23 23:44:58 2024 +0200 Do not export the content of InsetMathBoxed as text in MathML \boxed{} is the only box in LaTeX that contains math. It is amusing that the example file that we had

[LyX/2.4.x] Fixup b29b3eb1: fix broken xml syntax

commit 8ea0987644eae6f6ec2e5eff308feded4ef51f3e Author: Jean-Marc Lasgouttes Date: Tue Jul 23 15:04:49 2024 +0200 Fixup b29b3eb1: fix broken xml syntax This commit addresses two issues: 1/ the embarassing one: the member SetMode::old_text_level_ was declared as

[LyX/2.4.x] Fixup b29b3eb1: close when quitting text mode

commit 458ce0fdba19094f97b96b7747a2d7b82d4d7087 Author: Jean-Marc Lasgouttes Date: Tue Jul 23 22:02:50 2024 +0200 Fixup b29b3eb1: close when quitting text mode This fixes malformed documents on UserGuide export. Related to bug #13069. (cherry picked from commit

[LyX/master] Rewrite statistics code

commit 6e81f317229a585e4d74b68af967873acd1f74ae Author: Jean-Marc Lasgouttes Date: Sun Jul 21 22:09:28 2024 +0200 Rewrite statistics code The statistics code is known to be very slow, because it relies on DocIterator to go through the buffer. This commit introduces a

[LyX/master] Do not export the content of InsetMathBoxed as text in MathML

commit 1186d90edf9a6702573f296d5642c5e61ceaaedf Author: Jean-Marc Lasgouttes Date: Tue Jul 23 23:44:58 2024 +0200 Do not export the content of InsetMathBoxed as text in MathML \boxed{} is the only box in LaTeX that contains math. It is amusing that the example file that we had

[LyX/master] Fixup 216a6fb348: close when quitting text mode

commit 1385f0fddd0229770496b1e50b76782892032d18 Author: Jean-Marc Lasgouttes Date: Tue Jul 23 22:02:50 2024 +0200 Fixup 216a6fb348: close when quitting text mode This fixes malformed documents on UserGuide export. Related to bug #13069. --- src/mathed/MathStream.cpp | 1

[LyX/master] Fixup 216a6fb3: fix broken xml syntax

commit a268fe096a58a7818554a7da4da85896bb289c81 Author: Jean-Marc Lasgouttes Date: Tue Jul 23 15:04:49 2024 +0200 Fixup 216a6fb3: fix broken xml syntax This commit addresses two issues: 1/ the embarassing one: the member SetMode::old_text_level_ was declared as

[LyX/2.4.x] Fix crash when generating MathML with InsetMathBox

commit b29b3eb1fcbc30aad3c5e2800a9db61b823f65ae Author: Jean-Marc Lasgouttes Date: Sat Jul 20 12:15:32 2024 +0200 Fix crash when generating MathML with InsetMathBox Instead of generating code and parsing it to add ... at the right spots, this commit honors the text mode

[LyX/2.4.x] Cleanup MathMLStream

commit 17bc6d05b327034c2034087978c2ebf9f8d9e469 Author: Jean-Marc Lasgouttes Date: Fri Jul 19 14:57:58 2024 +0200 Cleanup MathMLStream This is preparatory work for fixing ticket #13069. Remove direct accesses to the underlying stream of MathMLStream in InsetMathChar

[LyX/master] Make scrolling-by-selection smoother

commit 1cc1f0ba27d1846ba244507529d4795ecfa29a39 Author: Jean-Marc Lasgouttes Date: Sat Jul 20 19:47:32 2024 +0200 Make scrolling-by-selection smoother This trivial patch makes scrolling-by-selection smoother by dividing the step size and the time between steps by 8 when

[LyX/master] Fix crash when generating MathML with InsetMathBox

commit 216a6fb348dedac3230f651287a0ccfb48b88818 Author: Jean-Marc Lasgouttes Date: Sat Jul 20 12:15:32 2024 +0200 Fix crash when generating MathML with InsetMathBox Instead of generating code and parsing it to add ... at the right spots, this commit honors the text mode

[LyX/master] Cleanup MathMLStream

commit fbd4b0a13fae4263cc88aa76bc4fbba5178b15fa Author: Jean-Marc Lasgouttes Date: Fri Jul 19 14:57:58 2024 +0200 Cleanup MathMLStream This is preparatory work for fixing ticket #13069. Remove direct accesses to the underlying stream of MathMLStream in InsetMathChar

[LyX/master] Revert "Cmake build: Add Qt?Xml modules to build."

commit cd4d54f76af59b3fba9e1d5565e463c28493f8cb Author: Jean-Marc Lasgouttes Date: Fri Jul 19 14:20:53 2024 +0200 Revert "Cmake build: Add Qt?Xml modules to build." This reverts commit 01160486974a69e62e0b21490454e8dc2e0a4c8e. --- src/frontends/qt/CMakeLists.txt | 8 +

[LyX/master] Revert "Fix bug #13069."

commit d7ba7bceb300c49ed1c3edb9b129810bb8a5160b Author: Jean-Marc Lasgouttes Date: Fri Jul 19 14:22:10 2024 +0200 Revert "Fix bug #13069." This reverts commit fafe3ea5d7be1c06fb734e3bc621c551d617a6f7. --- config/qt.m4| 13 +++ src/mathed/InsetMathBo

[LyX/master] Remove alpha component of system colors

commit 095bb18331f8eb4653691a64520d89d4a2d60fc4 Author: Jean-Marc Lasgouttes Date: Mon Jul 22 20:36:20 2024 +0200 Remove alpha component of system colors When using system colors it may happen (on windows 11 in particular) that the background color is actually translucid. This

[LyX/master] Store spellchecker_esc_chars as a docstring

commit 23379bb1d596359a0922b9d14e6f83c003ecd14d Author: Jean-Marc Lasgouttes Date: Sun Jul 21 21:33:01 2024 +0200 Store spellchecker_esc_chars as a docstring This is a minor optimization to avoid calling from_utf8() repeatedly on a hot path. --- src/LyXRC.cpp

[LyX/2.4.x] Fixup f4364c75: remove two more Update::SinglePar instances

commit 0867aaf5c59ee91871dca51bd1c46942ea6c3379 Author: Jean-Marc Lasgouttes Date: Sat Jul 20 17:12:09 2024 +0200 Fixup f4364c75: remove two more Update::SinglePar instances They do not do what the author(s) of these lines thought it would do, and can create crashes

[LyX/master] Use background to make math comments more visible

commit 3040eb0fa2930ae117b9166217ddb8089997c5aa Author: Jean-Marc Lasgouttes Date: Wed Jun 5 10:41:47 2024 +0200 Use background to make math comments more visible --- src/mathed/InsetMathComment.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mathed/InsetMathComment.cpp

[LyX/master] Fixup 2bdd691130: remove two more Update::SinglePar instances

commit 485f5afc21ba553fd16465231de7570b0c631298 Author: Jean-Marc Lasgouttes Date: Sat Jul 20 17:12:09 2024 +0200 Fixup 2bdd691130: remove two more Update::SinglePar instances They do not do what the author(s) of these lines thought it would do, and can create crashes

[LyX/2.4.x] Fix faulty undo recording

commit e57ccede186fa3705578a4908cbf8f96f5b9f5b5 Author: Jean-Marc Lasgouttes Date: Tue Jul 16 15:43:11 2024 +0200 Fix faulty undo recording The recordUndo() call is very wrong, since we may be inserting over a selection covering several paragraphs (undo itself works at

[LyX/master] Fix faulty undo recording

commit 82f387dabc2b18de6a9917192f4304e92bff8bc1 Author: Jean-Marc Lasgouttes Date: Tue Jul 16 15:43:11 2024 +0200 Fix faulty undo recording The recordUndo() call is very wrong, since we may be inserting over a selection covering several paragraphs (undo itself works at

[LyX/2.4.x] Add explicit check for EGREP in configure.ac

commit 2882bed1abcce146107b936f81d77ecd0f051bc0 Author: Jean-Marc Lasgouttes Date: Fri Jul 12 16:02:53 2024 +0200 Add explicit check for EGREP in configure.ac It is used in lib/Makefile.am and we were relying some autoconf macros to define it as a side-effect. This is not the

[LyX/master] Sort entries in src/Makefile.am

commit 281744d24f999eb8896a88c5c0829469a0afa13c Author: Jean-Marc Lasgouttes Date: Mon Jul 15 12:10:08 2024 +0200 Sort entries in src/Makefile.am Remove also STANDALONEFILES variable, which is a remain of monolithic builds. --- src/Makefile.am | 111

[LyX/master] missing quote in message

commit ed2e5554d8a1165d284ca75bf6ed191b2427c047 Author: Jean-Marc Lasgouttes Date: Fri Jul 12 19:04:18 2024 +0200 missing quote in message --- src/LyXRC.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/LyXRC.cpp b/src/LyXRC.cpp index feda5110c0..fb9eb8f303

[LyX/master] Add explicit check for EGREP in configure.ac

commit 31cde7247638a50c2302744984732064505b7d85 Author: Jean-Marc Lasgouttes Date: Fri Jul 12 16:02:53 2024 +0200 Add explicit check for EGREP in configure.ac It is used in lib/Makefile.am and we were relying some autoconf macros to define it as a side-effect. This is not the

[LyX/2.4.x] Make BufferView::singeParUpdate more robust

commit aadf3d8a5da69a5a0a21f4f4420407ce0da37691 Author: Jean-Marc Lasgouttes Date: Mon Jul 1 23:56:33 2024 +0200 Make BufferView::singeParUpdate more robust In some cases, it might happen that this method is called with no metrics or position known for the current paragraph

[LyX/2.4.x] Remove useless SinglePar update when scrolling in text

commit f4364c7593a66c63a7a2b588ff60c3350353d89c Author: Jean-Marc Lasgouttes Date: Wed Jul 3 17:31:38 2024 +0200 Remove useless SinglePar update when scrolling in text Using SinglePar does not majke sense here since the paragraph is not modified and it might even not have a

[LyX/2.4.x] Handle metrics of not visible paragraphs

commit 10b8861d103490e4598582608ac60407d6b0b711 Author: Jean-Marc Lasgouttes Date: Fri May 17 15:42:08 2024 +0200 Handle metrics of not visible paragraphs The code is not ready for situations where some paragraphs that are not visible have metrics available. In

[LyX/2.4.x] Make sure paragraph positions are updated when scrolling

commit 288684356016f5cca7959462735f6153cd1adab2 Author: Jean-Marc Lasgouttes Date: Wed Jul 3 00:22:55 2024 +0200 Make sure paragraph positions are updated when scrolling Sometimes quick selection-scrolling could cause a crash because the position of some paragraphs is not

[LyX/2.4.x] Fix display of page references when language is not specified

commit f64349db8d544bbce835d958371a39acf67adf41 Author: Jean-Marc Lasgouttes Date: Fri Jul 5 16:10:17 2024 +0200 Fix display of page references when language is not specified Using translateIfPossible with null language does not make sense (and gives an error on console

[LyX/master] Fixup 145af7c2: remove unused method

commit 8bc3799b354908f22270f9d96b2cce43ebd96d66 Author: Jean-Marc Lasgouttes Date: Wed Jul 10 13:42:57 2024 +0200 Fixup 145af7c2: remove unused method TextMetrics::firstVisible(), introduced in this commit, is actually unused. --- src/TextMetrics.cpp | 11 --- src

  1   2   3   4   5   6   7   8   9   10   >