On Sat, 2015-03-21 at 20:06 -0400, Ilia Mirkin wrote:
> Patches 1, 2, 3, 4, 8, and 11 are Reviewed-by: Ilia Mirkin
>
>
> The rest I sent comments on, although even if you address my feedback,
> I'm not sufficiently familiar to r-b at least some of them.
Thanks for the reviews.
>
> If you do de
https://bugs.freedesktop.org/show_bug.cgi?id=89705
Vinson Lee changed:
What|Removed |Added
Keywords||bisected
--- Comment #2 from Vinson Lee --
The only hackish ones are llvmpipe and softpipe, which currently return
the same string as for get_vendor(), while ideally they should return
the CPU vendor.
Signed-off-by: Giuseppe Bilotta
Reviewed-by: Tom Stellard
---
src/gallium/drivers/freedreno/freedreno_screen.c | 8
src/gallium
The pipe's get_vendor method returns something more akin to a driver
vendor string in most cases, instead of the actual device vendor. Use
get_device_vendor instead, which was introduced specifically for this
purpose.
Signed-off-by: Giuseppe Bilotta
Reviewed-by: Michel Dänzer
Reviewed-by: Franc
This will be needed by Clover to return the correct information
to CL_DEVICE_VENDOR info queries.
Signed-off-by: Giuseppe Bilotta
Reviewed-by: Michel Dänzer
---
src/gallium/docs/source/screen.rst | 6 ++
src/gallium/include/pipe/p_screen.h | 8
2 files changed, 14 insertions(+)
OpenCL (as opposed to OpenGL) has separate vendor strings for the
implementation/driver/platform and the device. CL_PLATFORM_VENDOR
is akin to the GL_VENDOR string, while CL_DEVICE_VENDOR is supposed to
return the actual device vendor.
(For example, the AMD OpenCL platform returns GenuineIntel as
Signed-off-by: Giuseppe Bilotta
Reviewed-by: Michel Dänzer
---
src/gallium/include/pipe/p_screen.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/include/pipe/p_screen.h
b/src/gallium/include/pipe/p_screen.h
index ac88506..4018f8a 100644
--- a/src/gallium/inclu
On Sat, 2015-03-21 at 19:57 -0400, Ilia Mirkin wrote:
> On Sat, Mar 21, 2015 at 5:49 AM, Timothy Arceri wrote:
> > Add support for setting the max access of an unsized member
> > of an interface array of arrays.
> >
> > For example ifc[j][k].foo[i] where foo is unsized.
> > ---
> > src/glsl/ast_a
On Sat, 2015-03-21 at 23:35 -0400, Ilia Mirkin wrote:
> Perhaps I'm blind, but I don't see where that array var is used beyond
> just being incremented. Mind pointing it out?
No problem.
unsigned int length = MIN2(val->type->length, (storage->array_elements -
*array_elements));
>
> On Mar 21, 20
On Sat, 2015-03-21 at 19:51 -0400, Ilia Mirkin wrote:
> On Sat, Mar 21, 2015 at 5:49 AM, Timothy Arceri wrote:
> > Adds support for linking AoA interface blocks
> > which countain unsized arrays
> > ---
> > src/glsl/ir.cpp | 4 ++--
> > src/glsl/linker.cpp | 9 +
> > 2 files changed,
Perhaps I'm blind, but I don't see where that array var is used beyond just
being incremented. Mind pointing it out?
On Mar 21, 2015 11:31 PM, "Timothy Arceri" wrote:
> On Sat, 2015-03-21 at 19:46 -0400, Ilia Mirkin wrote:
> > On Sat, Mar 21, 2015 at 5:49 AM, Timothy Arceri
> wrote:
> > > ---
>
On Sat, 2015-03-21 at 19:46 -0400, Ilia Mirkin wrote:
> On Sat, Mar 21, 2015 at 5:49 AM, Timothy Arceri wrote:
> > ---
> > src/glsl/link_uniform_initializers.cpp | 51
> > --
> > src/glsl/link_uniforms.cpp | 28 +++
> > 2 files changed,
On Sat, 2015-03-21 at 19:34 -0400, Ilia Mirkin wrote:
> On Sat, Mar 21, 2015 at 5:49 AM, Timothy Arceri wrote:
> > Signed-off-by: Timothy Arceri
> > ---
> > src/glsl/ast_to_hir.cpp | 6 +-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/glsl/ast_to_hir.cpp b/src/g
https://bugs.freedesktop.org/show_bug.cgi?id=89705
--- Comment #1 from Dieter Nützel ---
I get this too on r600/Turks XT.
/opt/mesa> llc --version
LLVM (http://llvm.org/):
LLVM version 3.7.0svn
Optimized build with assertions.
Built Mar 21 2015 (16:59:53).
Default target: x86_64-unknown-
On Sat, 2015-03-21 at 19:30 -0400, Ilia Mirkin wrote:
> On Sat, Mar 21, 2015 at 5:49 AM, Timothy Arceri wrote:
> > Also add TODO comment about adding proper support
> >
> > Signed-off-by: Timothy Arceri
> > ---
> > src/glsl/ir_set_program_inouts.cpp | 6 ++
> > 1 file changed, 6 insertions(+
Patches 1, 2, 3, 4, 8, and 11 are Reviewed-by: Ilia Mirkin
The rest I sent comments on, although even if you address my feedback,
I'm not sufficiently familiar to r-b at least some of them.
If you do decide to play with UBO's, you can use idr's excellent
random_ubo script to stress-test the vari
On Sat, Mar 21, 2015 at 5:49 AM, Timothy Arceri wrote:
> ---
> src/glsl/lower_named_interface_blocks.cpp | 51
> ++-
> 1 file changed, 37 insertions(+), 14 deletions(-)
>
> diff --git a/src/glsl/lower_named_interface_blocks.cpp
> b/src/glsl/lower_named_interface_bloc
On Sat, Mar 21, 2015 at 5:49 AM, Timothy Arceri wrote:
> Add support for setting the max access of an unsized member
> of an interface array of arrays.
>
> For example ifc[j][k].foo[i] where foo is unsized.
> ---
> src/glsl/ast_array_index.cpp | 16
> 1 file changed, 12 insertion
On Sat, Mar 21, 2015 at 5:49 AM, Timothy Arceri wrote:
> Adds support for linking AoA interface blocks
> which countain unsized arrays
> ---
> src/glsl/ir.cpp | 4 ++--
> src/glsl/linker.cpp | 9 +
> 2 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/src/glsl/ir.cpp b/s
On Sat, Mar 21, 2015 at 5:49 AM, Timothy Arceri wrote:
> ---
> src/glsl/link_uniform_initializers.cpp | 51
> --
> src/glsl/link_uniforms.cpp | 28 +++
> 2 files changed, 52 insertions(+), 27 deletions(-)
>
> diff --git a/src/glsl/link_
On Sat, Mar 21, 2015 at 5:49 AM, Timothy Arceri wrote:
> Signed-off-by: Timothy Arceri
> ---
> src/glsl/ast_to_hir.cpp | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
> index 36f3eb7..7516e60 100644
> --- a/src/glsl/
On Sat, Mar 21, 2015 at 5:49 AM, Timothy Arceri wrote:
> Also add TODO comment about adding proper support
>
> Signed-off-by: Timothy Arceri
> ---
> src/glsl/ir_set_program_inouts.cpp | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/glsl/ir_set_program_inouts.cpp
> b/src/glsl/
https://bugs.freedesktop.org/show_bug.cgi?id=89705
Bug ID: 89705
Summary: lp_bld_debug.cpp:280:54: error: no matching function
for call to ‘llvm::TargetMachine::getSubtargetImpl()’
Product: Mesa
Version: git
Hardware: x86-6
On Friday, March 20, 2015 02:36:15 PM Jason Ekstrand wrote:
> On Fri, Mar 20, 2015 at 2:28 PM, Ian Romanick wrote:
> > On 03/20/2015 02:26 PM, Jason Ekstrand wrote:
> >> On Fri, Mar 20, 2015 at 2:24 PM, Ian Romanick wrote:
> >>> On 03/20/2015 11:24 AM, Jason Ekstrand wrote:
> ---
> src
Signed-off-by: Ilia Mirkin
---
Not sure what kind of testing is needed here... thought I'd just send
this out though, as the extension is simple enough. Wasn't sure
whether mesa already handles the requirements re marking the texture
as incomplete if the sampler has funny settings.
src/glsl/bui
On Fri, Mar 20, 2015 at 7:11 AM, Francisco Jerez wrote:
> This defines helper functions implementing some common swizzle
> transformations that are usually open-coded in the compiler back-end,
> causing a lot of clutter. Some optimization passes will become almost
> trivial implemented in terms o
On Fri, Mar 20, 2015 at 7:11 AM, Francisco Jerez wrote:
> This seemed to be trying to deduce the number of uniform vector
> components from the parameter swizzle, but the algorithm would always
> give 4 as result. Instead grab the correct number of components from
> the GLSL type.
> ---
Function
On Fri, Mar 20, 2015 at 7:11 AM, Francisco Jerez wrote:
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp
> b/src/mesa/drivers/dri/i965/brw_vec4.cpp
> index a6842fc..8e4df8c 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4.cpp
> @@ -572,12 +572,
On Fri, Mar 20, 2015 at 7:11 AM, Francisco Jerez wrote:
> ---
> src/mesa/drivers/dri/i965/brw_vec4.cpp | 40
> ++
> 1 file changed, 11 insertions(+), 29 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp
> b/src/mesa/drivers/dri/i965/brw_vec4.cp
On Fri, Mar 20, 2015 at 2:21 PM, Jason Ekstrand wrote:
> On Fri, Mar 20, 2015 at 1:56 PM, Matt Turner wrote:
>> On Fri, Mar 20, 2015 at 1:37 PM, Jason Ekstrand wrote:
>>> On Fri, Mar 20, 2015 at 1:12 PM, Matt Turner wrote:
On Fri, Mar 20, 2015 at 11:24 AM, Jason Ekstrand
wrote:
On Friday, March 20, 2015 04:35:11 PM Jason Ekstrand wrote:
> On Fri, Mar 20, 2015 at 4:26 PM, Ian Romanick wrote:
> > On 03/20/2015 03:10 PM, Jason Ekstrand wrote:
> >> There are a couple of reasons I'm asking for this. One is that NIR
> >> may be able to CSE something that results in one of the
Signed-off-by: Emil Velikov
---
Should have sent with the "remove st/gbm" series. Ohh well.
-Emil
src/gbm/main/backend.c | 24
1 file changed, 24 deletions(-)
diff --git a/src/gbm/main/backend.c b/src/gbm/main/backend.c
index aceb662..4929d73 100644
--- a/src/gbm/ma
On 14/03/15 22:36, Emil Velikov wrote:
> Hi all,
>
> As a follow up to Jose's initial series dropping st/{egl,vega} and
> others here is the next round of cleanups,
>
> Namely this series
> - removes st/gbm, winsys/sw/{wayland,fbdev}, all of which no longer
> used by anyone,
> - cleans up libEGL
On Sat, Mar 21, 2015 at 10:10 AM, Emil Velikov wrote:
> On 17/03/15 23:44, Emil Velikov wrote:
>> On 17/03/15 01:25, Jonathan Gray wrote:
>>> On Mon, Mar 16, 2015 at 08:37:28PM +, Emil Velikov wrote:
On 26/02/15 13:49, Jose Fonseca wrote:
> On 26/02/15 13:42, Jose Fonseca wrote:
>
On 17/03/15 23:44, Emil Velikov wrote:
> On 17/03/15 01:25, Jonathan Gray wrote:
>> On Mon, Mar 16, 2015 at 08:37:28PM +, Emil Velikov wrote:
>>> On 26/02/15 13:49, Jose Fonseca wrote:
On 26/02/15 13:42, Jose Fonseca wrote:
> On 26/02/15 03:55, Jonathan Gray wrote:
>> On Wed, Feb 2
On Mar 21, 2015 2:49 AM, "Timothy Arceri" wrote:
>
> This series adds most of the remaining glsl arrays of arrays support.
Support for uniform blocks is still missing, I've played around with this
but don't have anything working yet.
>
> What do you guys think about adding these changes without th
When glDrawPixels was used with an external texture, the pixels passed in
were sampled instead of the texture. Change gallium to instead move the user
texture to a new sampler below the glDrawPixels samplers.
While the piglit test now works, the texture coordinates that are used to
sample the tex
Jan Vesely writes:
> On Sat, 2015-03-21 at 14:57 +0200, Francisco Jerez wrote:
>> Jan Vesely writes:
>>
>> > On Fri, 2015-03-20 at 23:29 +, Tom Stellard wrote:
>> >> The storage size for local kernel args can be queried before the
>> >> arguments are set by using the CL_KERNEL_LOCAL_MEM_SIZ
On Sat, 2015-03-21 at 14:57 +0200, Francisco Jerez wrote:
> Jan Vesely writes:
>
> > On Fri, 2015-03-20 at 23:29 +, Tom Stellard wrote:
> >> The storage size for local kernel args can be queried before the
> >> arguments are set by using the CL_KERNEL_LOCAL_MEM_SIZE param
> >> of clGetKernelW
Ian Romanick writes:
> From: Ian Romanick
>
> The casts to remove const from ir are ugly. The alternative was to add
> const versions of all the as_foo functions, and I just couldn't get up
> the motivation to do that.
>
Wouldn't the alternative be roughly as much typing as casting const
away?
Tom Stellard writes:
> ---
> src/gallium/state_trackers/clover/api/device.cpp | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/state_trackers/clover/api/device.cpp
> b/src/gallium/state_trackers/clover/api/device.cpp
> index 04f293d..43e7475 100644
> -
Tom Stellard writes:
> This is required by the spec.
Déjà-vu?
Reviewed-by: Francisco Jerez
> ---
> src/gallium/state_trackers/clover/api/device.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/state_trackers/clover/api/device.cpp
> b/src/gallium/state
Jan Vesely writes:
> On Fri, 2015-03-20 at 23:29 +, Tom Stellard wrote:
>> The storage size for local kernel args can be queried before the
>> arguments are set by using the CL_KERNEL_LOCAL_MEM_SIZE param
>> of clGetKernelWorkGroupInfo().
>>
>> The spec says that if local kernel arguments ha
Tom Stellard writes:
> ---
> src/gallium/state_trackers/clover/api/device.cpp | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/gallium/state_trackers/clover/api/device.cpp
> b/src/gallium/state_trackers/clover/api/device.cpp
> index 43e7475..bc93f91 100644
> --- a/src/gallium/sta
https://bugs.freedesktop.org/show_bug.cgi?id=89699
Michel Dänzer changed:
What|Removed |Added
Component|Other |Drivers/Gallium/radeonsi
Assig
Looks good to me. :)
On 03/20/2015 10:20 PM, Emil Velikov wrote:
The path is provided by libdrm.pc and already used appropriately by
the build system.
Signed-off-by: Emil Velikov
---
src/gallium/targets/d3dadapter9/drm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sr
Add support for setting the max access of an unsized member
of an interface array of arrays.
For example ifc[j][k].foo[i] where foo is unsized.
---
src/glsl/ast_array_index.cpp | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/src/glsl/ast_array_index.cpp b/src
This series adds most of the remaining glsl arrays of arrays support. Support
for uniform blocks is still missing, I've played around with this but don't
have anything working yet.
What do you guys think about adding these changes without the uniform blocks
support? Adding these changes now I a
---
src/glsl/lower_named_interface_blocks.cpp | 51 ++-
1 file changed, 37 insertions(+), 14 deletions(-)
diff --git a/src/glsl/lower_named_interface_blocks.cpp
b/src/glsl/lower_named_interface_blocks.cpp
index 7304c51..8321bc1 100644
--- a/src/glsl/lower_named_interf
Also add TODO comment about adding proper support
Signed-off-by: Timothy Arceri
---
src/glsl/ir_set_program_inouts.cpp | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/glsl/ir_set_program_inouts.cpp
b/src/glsl/ir_set_program_inouts.cpp
index e877a20..49cf85d 100644
--- a/src/glsl/i
Signed-off-by: Timothy Arceri
---
src/glsl/link_varyings.cpp | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp
index 2261799..80c54cc 100644
--- a/src/glsl/link_varyings.cpp
+++ b/src/glsl/link_varyings.cpp
Signed-off-by: Timothy Arceri
---
src/glsl/ast_to_hir.cpp | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index d387b2e..36f3eb7 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -3584,9 +3584,7 @@ ast_de
Assigns a new array type based on the max access of
unsized array members.
---
src/glsl/linker.cpp | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index eb25163..97f5023 100644
--- a/src/glsl/linker.cpp
+++ b/src/gls
Adds support for linking AoA interface blocks
which countain unsized arrays
---
src/glsl/ir.cpp | 4 ++--
src/glsl/linker.cpp | 9 +
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp
index 54656f8..2e1442f 100644
--- a/src/glsl/ir.cpp
+++
---
src/glsl/link_uniform_initializers.cpp | 51 --
src/glsl/link_uniforms.cpp | 28 +++
2 files changed, 52 insertions(+), 27 deletions(-)
diff --git a/src/glsl/link_uniform_initializers.cpp
b/src/glsl/link_uniform_initializers.cpp
ind
Signed-off-by: Timothy Arceri
---
src/glsl/glsl_types.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/glsl/glsl_types.h b/src/glsl/glsl_types.h
index 7359e94..f5bc846 100644
--- a/src/glsl/glsl_types.h
+++ b/src/glsl/glsl_types.h
@@ -534,7 +534,12 @@ struct glsl_ty
---
src/glsl/glsl_types.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/glsl/glsl_types.cpp b/src/glsl/glsl_types.cpp
index 38b37a6..994c5c5 100644
--- a/src/glsl/glsl_types.cpp
+++ b/src/glsl/glsl_types.cpp
@@ -1016,7 +1016,8 @@ glsl_type::std140_base_alignment(bool
---
src/glsl/lower_packed_varyings.cpp | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/src/glsl/lower_packed_varyings.cpp
b/src/glsl/lower_packed_varyings.cpp
index 2c9a1c4..f8e79bd 100644
--- a/src/glsl/lower_packed_varyings.cpp
+++ b/src/glsl/lower_packed_varyings
Signed-off-by: Timothy Arceri
---
src/glsl/ast_to_hir.cpp | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 36f3eb7..7516e60 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -5595,7 +5595,11 @@ ast
59 matches
Mail list logo
