Re: [Mesa-dev] [PATCH v2] glsl: builtin: always return clones of the builtins

2017-07-31 Thread Timothy Arceri
On 27/07/17 17:52, Timothy Arceri wrote: On 09/03/17 18:01, Kenneth Graunke wrote: On Wednesday, March 8, 2017 1:15:04 PM PST Lionel Landwerlin wrote: Builtins are created once and allocated using their own private ralloc context. When reparenting IR that includes builtins, we might be steal bi

[Mesa-dev] [Bug 101334] Any vulkan app seems to freeze the system

2017-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #24 from Marko --- -ping -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.

[Mesa-dev] [PATCH 1/2] android: link libmesa_intel_common with zlib and expat

2017-07-31 Thread Tapani Pälli
Makes it possible to build Mesa on Android with -DDEBUG with the next patch that reverts 4f695731. Signed-off-by: Tapani Pälli --- src/intel/Android.common.mk | 5 + 1 file changed, 5 insertions(+) diff --git a/src/intel/Android.common.mk b/src/intel/Android.common.mk index f056f0a..12cea6e

[Mesa-dev] [PATCH 2/2] intel: move gen_decoder.* back to COMMON_FILES

2017-07-31 Thread Tapani Pälli
this change reverts commit 4f695731, we want to be able to build with -DDEBUG and gen_decoder on Android. Signed-off-by: Tapani Pälli --- src/intel/Makefile.common.am | 2 +- src/intel/Makefile.sources | 6 ++ 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/intel/Makefil

[Mesa-dev] [Bug 101971] Mesa fails to build when Wayland and EGL support enabled due to missing C++ lib from mesautil

2017-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101971 --- Comment #2 from Timo Aaltonen --- *** This bug has been marked as a duplicate of bug 101851 *** -- You are receiving this mail because: You are the QA Contact for the bug.___ mesa-dev mailing l

[Mesa-dev] [Bug 101851] [regression] libEGL_common.a undefined reference to '__gxx_personality_v0'

2017-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101851 Timo Aaltonen changed: What|Removed |Added CC||mp...@kde.org --- Comment #4 from Timo

[Mesa-dev] [PATCH 2/2] i965: Cancel make_surface() if the surface format is unsupported

2017-07-31 Thread Chris Wilson
Return early if translate_tex_format() makes the incoming format onto an unsupported type, otherwise we try to access beyond the end of the isl formats array. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_mi

[Mesa-dev] [PATCH 1/2] i965: Check result of make_surface() for intel_miptree_create_bo_bo

2017-07-31 Thread Chris Wilson
Since make_surface() can fail, if the format isn't support by hw or simlar error, we need to check the result before dereferencing it. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/d

Re: [Mesa-dev] [PATCH] radeonsi: expose MRT-draw-calls to HUD

2017-07-31 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 28.07.2017 06:36, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/drivers/radeon/r600_query.c | 7 +++ src/gallium/drivers/radeon/r600_query.h | 1 + src/gallium/drivers/radeonsi/si_s

[Mesa-dev] [PATCH] i965/blit: Remember to include miptree buffer offset in relocs

2017-07-31 Thread Chris Wilson
Remember to add the offset to the start of the buffer in the relocation or else we write 0xff into random bytes elsewhere. --- src/mesa/drivers/dri/i965/intel_blit.c | 4 ++-- src/mesa/drivers/dri/i965/intel_pixel_bitmap.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --gi

Re: [Mesa-dev] [PATCH 1/2] mesa: make _mesa_check_init_viewport() static

2017-07-31 Thread Nicolai Hähnle
On 28.07.2017 15:47, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle --- src/mesa/main/context.c | 7 +++ src/mesa/main/context.h | 4 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/context.c b/src/mesa/main/conte

Re: [Mesa-dev] [PATCH 2/2] mesa: clamp viewport values only once when using glViewport()

2017-07-31 Thread Nicolai Hähnle
On 28.07.2017 15:47, Samuel Pitoiset wrote: It's useless to clamp the same values for all viewports. +7% in the "viewport change" test (drawoverhead benchmark). Signed-off-by: Samuel Pitoiset I think it would be cleaner to call clamp_viewport in all callers of set_viewport_no_notify. Fewer

Re: [Mesa-dev] [PATCH] dri_interface, egl, gallium: only expose RGBA visuals on Android

2017-07-31 Thread Nicolai Hähnle
On 28.07.2017 19:38, Marek Olšák wrote: From: Marek Olšák X/GLX can't handle them. This removes almost 500 GLX visuals that were incorrectly exposed. Add an optional getCapability callback for querying what the loader can do. I'm not splitting this patch, because it's already too small. v2:

Re: [Mesa-dev] [PATCH 2/2] mesa: clamp viewport values only once when using glViewport()

2017-07-31 Thread Samuel Pitoiset
On 07/31/2017 12:02 PM, Nicolai Hähnle wrote: On 28.07.2017 15:47, Samuel Pitoiset wrote: It's useless to clamp the same values for all viewports. +7% in the "viewport change" test (drawoverhead benchmark). Signed-off-by: Samuel Pitoiset I think it would be cleaner to call clamp_viewport

Re: [Mesa-dev] [PATCH mesa] util/ra: fix memory leak

2017-07-31 Thread Nicolai Hähnle
On 30.07.2017 00:53, Eric Engestrom wrote: CID: 1415909 Fixes: 7a34a0e8903249c41fae "ra: Add a callback for selecting a register from what's available." Signed-off-by: Eric Engestrom --- src/util/register_allocate.c | 1 + 1 file changed, 1 insertion(+) diff --g

[Mesa-dev] [ANNOUNCE] mesa 17.2.0-rc2

2017-07-31 Thread Emil Velikov
The second release candidate for Mesa 17.2.0 is now available. Charmaine Lee (1): st/mesa: create framebuffer iface hash table per st manager Daniel Stone (3): egl/wayland: Ignore invalid modifiers st/dri: Check get-handle return value in queryImage st/dri2: Return invalid

Re: [Mesa-dev] [ANNOUNCE] mesa 17.2.0-rc2

2017-07-31 Thread Samuel Pitoiset
Hi Emil, Looks like you missed https://cgit.freedesktop.org/mesa/mesa/commit/?id=b38c9c57f272b54a190be4efd4297effa1a3deab , is that expected? Thanks! On 07/31/2017 12:56 PM, Emil Velikov wrote: The second release candidate for Mesa 17.2.0 is now available. Charmaine Lee (1): st/mesa

Re: [Mesa-dev] [PATCH] st/dri: enable 32-bit RGBX/RGBA formats only on Android

2017-07-31 Thread Marek Olšák
On Mon, Jul 31, 2017 at 3:11 AM, Marek Olšák wrote: > On Sun, Jul 30, 2017 at 4:44 AM, Tomasz Figa wrote: > >> On Sun, Jul 30, 2017 at 6:51 AM, Marek Olšák wrote: >> > Hi Tomasz, >> > >> > This is for 17.2 only. Not master. I have a different fix for master. >> >> Right, we don't need this in m

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeonsi: ensure that temp array allocas are in the entry block

2017-07-31 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sat, Jul 29, 2017 at 10:47 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Otherwise, code generation fails. This has become necessary since some > shaders are wrapped in control flow. > > Fixes: 081ac6e5c6d2 ("radeonsi/gfx9: always wrap GS and TCS in an

[Mesa-dev] [RFC PATCH] nv50/ir: allow spilling of def values for constrained MERGES/UNIONS

2017-07-31 Thread Tobias Klausmann
This lets us spill more values and compile a big shader for Civilization 6. Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp b/src/gallium/drivers/nouvea

[Mesa-dev] [PATCH 2/4] mesa: only check errors when the state change in glCullFace()

2017-07-31 Thread Samuel Pitoiset
When this GL call is a no-op, it should be a little faster in the errors path only. Signed-off-by: Samuel Pitoiset --- src/mesa/main/polygon.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/polygon.c b/src/mesa/main/polygon.c index f4479930

[Mesa-dev] [PATCH 1/4] mesa: only check errors when the state change in glProvokingVertex()

2017-07-31 Thread Samuel Pitoiset
When this GL call is a no-op, it should be a little faster. Signed-off-by: Samuel Pitoiset --- src/mesa/main/light.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/light.c b/src/mesa/main/light.c index 245692a54c..f52ed8ed25 100644 --- a/src/mesa/main/lig

[Mesa-dev] [PATCH 3/4] mesa: only check errors when the state change in glPointSize()

2017-07-31 Thread Samuel Pitoiset
When this GL call is a no-op, it should be a little faster in the errors path only. Signed-off-by: Samuel Pitoiset --- src/mesa/main/points.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/points.c b/src/mesa/main/points.c index 30bd7b8952.

[Mesa-dev] [PATCH 4/4] mesa: only check errors when the state change in glClipControl()

2017-07-31 Thread Samuel Pitoiset
When this GL call is a no-op, it should be a little faster in the errors path only. Signed-off-by: Samuel Pitoiset --- src/mesa/main/viewport.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/viewport.c b/src/mesa/main/viewport.c

Re: [Mesa-dev] [ANNOUNCE] mesa 17.2.0-rc2

2017-07-31 Thread Emil Velikov
On 31 July 2017 at 11:59, Samuel Pitoiset wrote: > Hi Emil, > > Looks like you missed > https://cgit.freedesktop.org/mesa/mesa/commit/?id=b38c9c57f272b54a190be4efd4297effa1a3deab > , is that expected? > The patch was not tested by the Intel CI as part of the branch. It'll feature in RC3. Thanks

[Mesa-dev] [PATCH] mesa: drop unnecessary GLAPIENTRY to _mesa_init_line()

2017-07-31 Thread Samuel Pitoiset
Noticed randomly. Signed-off-by: Samuel Pitoiset --- src/mesa/main/lines.c | 2 +- src/mesa/main/lines.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/lines.c b/src/mesa/main/lines.c index c6931eca69..78d3a7729b 100644 --- a/src/mesa/main/lines.c +++ b/src/

Re: [Mesa-dev] [PATCH] dri_interface, egl, gallium: only expose RGBA visuals on Android

2017-07-31 Thread Emil Velikov
Hi Marek, On 28 July 2017 at 18:38, Marek Olšák wrote: > From: Marek Olšák > > X/GLX can't handle them. This removes almost 500 GLX visuals that were > incorrectly exposed. > > Add an optional getCapability callback for querying what the loader can do. > > I'm not splitting this patch, because i

Re: [Mesa-dev] [PATCH] st/dri: enable 32-bit RGBX/RGBA formats only on Android

2017-07-31 Thread Emil Velikov
On 31 July 2017 at 12:03, Marek Olšák wrote: > On Mon, Jul 31, 2017 at 3:11 AM, Marek Olšák wrote: >> >> On Sun, Jul 30, 2017 at 4:44 AM, Tomasz Figa wrote: >>> >>> On Sun, Jul 30, 2017 at 6:51 AM, Marek Olšák wrote: >>> > Hi Tomasz, >>> > >>> > This is for 17.2 only. Not master. I have a diffe

[Mesa-dev] [Bug 101981] Commit ddc32537d6db69198e88ef0dfe19770bf9daa536 breaks rendering in multiple applications

2017-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101981 Bug ID: 101981 Summary: Commit ddc32537d6db69198e88ef0dfe19770bf9daa536 breaks rendering in multiple applications Product: Mesa Version: git Hardware: x86-64 (AMD64)

[Mesa-dev] [Bug 101981] Commit ddc32537d6db69198e88ef0dfe19770bf9daa536 breaks rendering in multiple applications

2017-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101981 network...@rkmail.ru changed: What|Removed |Added CC||samuel.pitoi...@gmail.com -- You

[Mesa-dev] [Bug 101981] Commit ddc32537d6db69198e88ef0dfe19770bf9daa536 breaks rendering in multiple applications

2017-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101981 --- Comment #1 from Samuel Pitoiset --- Thanks for reporting this. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing li

[Mesa-dev] [PATCH] mesa/st: fix conditional jump depends on uninitialised value

2017-07-31 Thread Timothy Arceri
Reported by valgrind at: glsl_to_tgsi_visitor::visit(ir_expression*) (st_glsl_to_tgsi.cpp:1560) When compiling the Deus Ex shaders. Cc: Karol Herbst Cc: Nicolai Hähnle --- There is probably more to this. I didn't look too hard. src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 + 1 file change

Re: [Mesa-dev] [PATCH] mesa/st: fix conditional jump depends on uninitialised value

2017-07-31 Thread Nicolai Hähnle
On 31.07.2017 14:48, Timothy Arceri wrote: Reported by valgrind at: glsl_to_tgsi_visitor::visit(ir_expression*) (st_glsl_to_tgsi.cpp:1560) When compiling the Deus Ex shaders. Cc: Karol Herbst Cc: Nicolai Hähnle --- There is probably more to this. I didn't look too hard. Nah, I don't thin

[Mesa-dev] [PATCH] i965: expose RGBA visuals only on Android

2017-07-31 Thread Emil Velikov
From: Emil Velikov As Marek pointed out in earlier commit - exposing RGBA on other platforms introduces ~500 Visuals, which are not tested. Fixes: 1bf703e4ea5 ("dri_interface,egl,gallium: only expose RGBA visuals on Android") Cc: Tomasz Figa Cc: Chad Versace Cc: Marek Olšák Signed-off-by: Emi

Re: [Mesa-dev] [PATCH mesa] util/ra: fix memory leak

2017-07-31 Thread Eric Engestrom
On Monday, 2017-07-31 12:07:37 +0200, Nicolai Hähnle wrote: > On 30.07.2017 00:53, Eric Engestrom wrote: > > CID: 1415909 > > Fixes: 7a34a0e8903249c41fae "ra: Add a callback for selecting a register > > from what's available." > > Signed-off-by: Eric Engestrom > > ---

Re: [Mesa-dev] [PATCH 4/4] mesa: only check errors when the state change in glClipControl()

2017-07-31 Thread Nicolai Hähnle
For the series: Reviewed-by: Nicolai Hähnle On 31.07.2017 14:07, Samuel Pitoiset wrote: When this GL call is a no-op, it should be a little faster in the errors path only. Signed-off-by: Samuel Pitoiset --- src/mesa/main/viewport.c | 30 -- 1 file changed, 16

[Mesa-dev] [Bug 101982] Weston crashes when running an OpenGL program on i965

2017-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101982 Bug ID: 101982 Summary: Weston crashes when running an OpenGL program on i965 Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: no

[Mesa-dev] [PATCH mesa v2] util/ra: fix memory leak

2017-07-31 Thread Eric Engestrom
From: Eric Engestrom CID: 1415909 Fixes: 7a34a0e8903249c41fae "ra: Add a callback for selecting a register from what's available." Signed-off-by: Eric Engestrom --- v2: don't free inside the loop... (Nicolai) --- src/util/register_allocate.c | 2 ++ 1 file changed,

[Mesa-dev] [Bug 101982] Weston crashes when running an OpenGL program on i965

2017-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101982 --- Comment #1 from Daniel Stone --- That'd be linux-dmabuf then. Wonderful. Could you please get a backtrace out of Weston somehow? I'm running it on Intel myself (both upstream Weston as well as the atomic branch), but haven't seen any failure

[Mesa-dev] [PATCH 1/3] dri_interface: drop loaderPrivate from loader::getCapability()

2017-07-31 Thread Emil Velikov
From: Emil Velikov Unused and I cannot see any case where we'll need it Fixes: 1bf703e4ea5 ("dri_interface,egl,gallium: only expose RGBA visuals on Android") Cc: Marek Olšák Signed-off-by: Emil Velikov --- Mostly an RFC, since I don't feel too strongly about it. Marek, can you elaborate about

[Mesa-dev] [PATCH 3/3] i965: expose RGBA visuals only on Android

2017-07-31 Thread Emil Velikov
From: Emil Velikov As Marek pointed out in earlier commit - exposing RGBA on other platforms introduces ~500 Visuals, which are not tested. Fixes: 1bf703e4ea5 ("dri_interface,egl,gallium: only expose RGBA visuals on Android") Cc: Tomasz Figa Cc: Chad Versace Cc: Marek Olšák Signed-off-by: Emi

[Mesa-dev] [PATCH 2/3] st/dri: NULL check before deref DRI loader .getCapability

2017-07-31 Thread Emil Velikov
From: Emil Velikov One could have vX+1 which introduces another entrypoint without implementing older ones. Fixes: 1bf703e4ea5 ("dri_interface,egl,gallium: only expose RGBA visuals on Android") Cc: Marek Olšák Signed-off-by: Emil Velikov --- src/gallium/state_trackers/dri/dri_screen.c | 6 +++

Re: [Mesa-dev] [PATCH] i965: expose RGBA visuals only on Android

2017-07-31 Thread Emil Velikov
On 31 July 2017 at 13:54, Emil Velikov wrote: > From: Emil Velikov > > As Marek pointed out in earlier commit - exposing RGBA on other > platforms introduces ~500 Visuals, which are not tested. > > Fixes: 1bf703e4ea5 ("dri_interface,egl,gallium: only expose RGBA visuals > on Android") > Cc: Tomas

Re: [Mesa-dev] [PATCH mesa 1/3] egl: use designated initaliser for _eglGlobal

2017-07-31 Thread Emil Velikov
On 30 July 2017 at 02:11, Eric Engestrom wrote: > Turn comments into actual code, that the compiler can check for us :) > (Speaking of, one of the comments had a typo. Challenge: find it) > Challenge accepted. > Signed-off-by: Eric Engestrom > --- > src/egl/main/eglglobals.c | 18 +-

Re: [Mesa-dev] [PATCH mesa 1/4] gbm: add gbm_bo_get_bpp()

2017-07-31 Thread Emil Velikov
Hi Eric, On 19 July 2017 at 15:05, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/gbm/gbm-symbols-check | 1 + > src/gbm/main/gbm.c| 66 > +++ > src/gbm/main/gbm.h| 3 +++ > 3 files changed, 70 insertions(+) > For

Re: [Mesa-dev] [PATCH 03/16] xmlconfig: remove GL type dependencies

2017-07-31 Thread Nicolai Hähnle
On 05.07.2017 15:46, Emil Velikov wrote: On 5 July 2017 at 14:35, Emil Velikov wrote: I think it matters too much here, I meant to say "I don't think it matters..." Forgot this last time around: other code in the same function already uses true/false, so we really should be good :) Chee

[Mesa-dev] [Bug 101952] OpenCL enqueueReadBuffer returns trash

2017-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101952 Janpieter Sollie changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 101982] Weston crashes when running an OpenGL program on i965

2017-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101982 --- Comment #2 from Link Mauve --- Created attachment 133146 --> https://bugs.freedesktop.org/attachment.cgi?id=133146&action=edit Stack trace Here it is. I can still reproduce it on Weston master and Mesa master from ten minutes ago, on Lin

[Mesa-dev] [Bug 101952] OpenCL enqueueReadBuffer returns trash

2017-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101952 --- Comment #16 from Jan Vesely --- (In reply to Janpieter Sollie from comment #15) > Today I installed LLVM/CLANG 5.0.0 (git) and Mesa 17.2-rc2 > this seems to work: the bug is resolved. > do you need any additional info from me to figure out w

Re: [Mesa-dev] [PATCH 00/16]: Allow Gallium drivers to support driver-specific drirc options

2017-07-31 Thread Nicolai Hähnle
So, this series has been on my hard disk for quite some time, although nothing has really changed. Mostly I haven't pushed it out of build-system related fear :) So I think what I'm going to do is push the xmlconfig move first in a while, and then wait a bit if there's any fall-out from it. If

Re: [Mesa-dev] [PATCH] mesa/st: fix conditional jump depends on uninitialised value

2017-07-31 Thread Karol Herbst
On Mon, Jul 31, 2017 at 2:48 PM, Timothy Arceri wrote: > Reported by valgrind at: > glsl_to_tgsi_visitor::visit(ir_expression*) (st_glsl_to_tgsi.cpp:1560) > > When compiling the Deus Ex shaders. > > Cc: Karol Herbst > Cc: Nicolai Hähnle > --- > > There is probably more to this. I didn't look to

[Mesa-dev] [PATCH 2/2] egl: Add dma_buf_import_modifiers for glvnd

2017-07-31 Thread Daniel Stone
Make sure we advertise the new entrypoints to libglvnd's EGL dispatch. Signed-off-by: Daniel Stone Reported-by: Emmanuel Gil Peyrot Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101982 Fixes: 4c412293d0e ("egl: advertise EGL_EXT_image_dma_buf_import_modifiers") --- src/egl/generate/egl

[Mesa-dev] [PATCH 1/2] egl: Update headers from Khronos

2017-07-31 Thread Daniel Stone
Taken from egl-registry 7d68647c4dab. Signed-off-by: Daniel Stone --- include/EGL/egl.h | 6 +- include/EGL/eglext.h | 73 +- include/KHR/khrplatform.h | 10 +- src/egl/generate/egl.xml | 626 +++--- 4 files changed, 673 insertions(+)

[Mesa-dev] [Bug 101982] Weston crashes when running an OpenGL program on i965

2017-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101982 --- Comment #3 from Daniel Stone --- I guess you're using glvnd ... ? If so: https://patchwork.freedesktop.org/series/28130/ -- You are receiving this mail because: You are the QA Contact for the bug.___

[Mesa-dev] [Bug 101982] Weston crashes when running an OpenGL program on i965

2017-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101982 --- Comment #4 from Link Mauve --- Yes I am using glvnd, it’s the default in ArchLinux. Your patch didn’t fix it, but now I have 2784 formats instead. -- You are receiving this mail because: You are the QA Contact for the bug.

[Mesa-dev] [Bug 101982] Weston crashes when running an OpenGL program on i965

2017-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101982 --- Comment #5 from Emil Velikov --- There's a misplaced bracket - patch is coming in a second --- a/src/mesa/drivers/dri/i965/intel_screen.c +++ b/src/mesa/drivers/dri/i965/intel_screen.c @@ -1058,7 +1058,7 @@ intel_query_dma_buf_formats(__DRI

Re: [Mesa-dev] [PATCH 00/16]: Allow Gallium drivers to support driver-specific drirc options

2017-07-31 Thread Nicolai Hähnle
On 31.07.2017 16:00, Nicolai Hähnle wrote: So, this series has been on my hard disk for quite some time, although nothing has really changed. Mostly I haven't pushed it out of build-system related fear :) So I think what I'm going to do is push the xmlconfig move first in a while, and then wa

[Mesa-dev] [PATCH] Android: fix compile error for DRI2 loader getCapability

2017-07-31 Thread Rob Herring
Fix compile failure from commit 1bf703e4ea5c ("dri_interface,egl,gallium: only expose RGBA visuals on Android"). Fixes: 1bf703e4ea5c ("dri_interface,egl,gallium: only expose RGBA visuals on Android") Cc: Marek Olšák Signed-off-by: Rob Herring --- I only got around to testing this this morning.

[Mesa-dev] [Bug 101982] Weston crashes when running an OpenGL program on i965

2017-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101982 --- Comment #6 from Emil Velikov --- *Scratch that... there should be no difference with/without my suggestion. -- You are receiving this mail because: You are the QA Contact for the bug.___ mesa-dev

[Mesa-dev] [AppVeyor] mesa master #5071 failed

2017-07-31 Thread AppVeyor
Build mesa 5071 failed Commit 601093f95d by Nicolai Hähnle on 6/30/2017 9:57 AM: xmlconfig: move into src/util\n\nv2: attempt to fix Android build (Emil)\n\nv3: add missing include path\n\nReviewed-by: Marek Olšák (v1) Configure your notification pre

Re: [Mesa-dev] [PATCH] Android: fix compile error for DRI2 loader getCapability

2017-07-31 Thread Marek Olšák
Cc: 17.2 Reviewed-by: Marek Olšák Marek On Mon, Jul 31, 2017 at 4:40 PM, Rob Herring wrote: > Fix compile failure from commit 1bf703e4ea5c ("dri_interface,egl,gallium: > only expose RGBA visuals on Android"). > > Fixes: 1bf703e4ea5c ("dri_interface,egl,gallium: only expose RGBA visuals > on A

[Mesa-dev] [Bug 101982] Weston crashes when running an OpenGL program on i965

2017-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101982 --- Comment #7 from Daniel Stone --- (In reply to Link Mauve from comment #4) > Yes I am using glvnd, it’s the default in ArchLinux. > > Your patch didn’t fix it, but now I have 2784 formats instead. That's certainly interesting. So at the '*f

Re: [Mesa-dev] [PATCH 1/3] dri_interface: drop loaderPrivate from loader::getCapability()

2017-07-31 Thread Marek Olšák
The idea is to allow the loader to access its own structures. It's sort of like "this" in C++. Marek On Mon, Jul 31, 2017 at 3:19 PM, Emil Velikov wrote: > From: Emil Velikov > > Unused and I cannot see any case where we'll need it > > Fixes: 1bf703e4ea5 ("dri_interface,egl,gallium: only expos

Re: [Mesa-dev] [PATCH 1/3] dri_interface: drop loaderPrivate from loader::getCapability()

2017-07-31 Thread Daniel Stone
Hi Emil, On 31 July 2017 at 14:19, Emil Velikov wrote: > Unused and I cannot see any case where we'll need it This is also an ABI break, right? IOW, anyone having shipped v2 image loader or v4 DRI2 loader is going to need to rebuild the module. In order to do this backwards compatibly, we'd need

Re: [Mesa-dev] [PATCH 2/3] st/dri: NULL check before deref DRI loader .getCapability

2017-07-31 Thread Marek Olšák
I don't think this is necessary. Anyway: Cc: 17.2 Reviewed-by: Marek Olšák Marek On Mon, Jul 31, 2017 at 3:19 PM, Emil Velikov wrote: > From: Emil Velikov > > One could have vX+1 which introduces another entrypoint without > implementing older ones. > > Fixes: 1bf703e4ea5 ("dri_interface,egl

Re: [Mesa-dev] [PATCH 1/2] egl: Update headers from Khronos

2017-07-31 Thread Eric Engestrom
On Monday, 2017-07-31 15:15:13 +0100, Daniel Stone wrote: > Taken from egl-registry 7d68647c4dab. > > Signed-off-by: Daniel Stone > --- > include/EGL/egl.h | 6 +- > include/EGL/eglext.h | 73 +- > include/KHR/khrplatform.h | 10 +- > src/egl/generate/egl.xml | 626 > +

Re: [Mesa-dev] [PATCH] Android: fix compile error for DRI2 loader getCapability

2017-07-31 Thread Rob Herring
On Mon, Jul 31, 2017 at 9:43 AM, Marek Olšák wrote: > Cc: 17.2 I thought this was only for master? > Reviewed-by: Marek Olšák > > Marek > > On Mon, Jul 31, 2017 at 4:40 PM, Rob Herring wrote: >> >> Fix compile failure from commit 1bf703e4ea5c ("dri_interface,egl,gallium: >> only expose RGBA v

[Mesa-dev] [AppVeyor] mesa master #5074 completed

2017-07-31 Thread AppVeyor
Build mesa 5074 completed Commit 90c8f17cf8 by Nicolai Hähnle on 7/31/2017 3:17 PM: Attempt to fix AppVeyor build, round 2 Configure your notification preferences ___ mesa-dev mailing list mesa-dev@lists.fr

Re: [Mesa-dev] [PATCH] Android: fix compile error for DRI2 loader getCapability

2017-07-31 Thread Marek Olšák
On Mon, Jul 31, 2017 at 5:21 PM, Rob Herring wrote: > On Mon, Jul 31, 2017 at 9:43 AM, Marek Olšák wrote: >> Cc: 17.2 > > I thought this was only for master? Not anymore. See the commit in master. Marek ___ mesa-dev mailing list mesa-dev@lists.freede

Re: [Mesa-dev] [PATCH] mesa/st: fix conditional jump depends on uninitialised value

2017-07-31 Thread Marek Olšák
Please don't forget to nominate patches for stable. Thanks. Cc: 17.2 Reviewed-by: Marek Olšák Marek On Mon, Jul 31, 2017 at 2:48 PM, Timothy Arceri wrote: > Reported by valgrind at: > glsl_to_tgsi_visitor::visit(ir_expression*) (st_glsl_to_tgsi.cpp:1560) > > When compiling the Deus Ex shaders

Re: [Mesa-dev] [PATCH 1/3] dri_interface: drop loaderPrivate from loader::getCapability()

2017-07-31 Thread Emil Velikov
On 31 July 2017 at 15:49, Daniel Stone wrote: > Hi Emil, > > On 31 July 2017 at 14:19, Emil Velikov wrote: >> Unused and I cannot see any case where we'll need it > > This is also an ABI break, right? IOW, anyone having shipped v2 image > loader or v4 DRI2 loader is going to need to rebuild the m

Re: [Mesa-dev] [PATCH mesa v2] util/ra: fix memory leak

2017-07-31 Thread Nicolai Hähnle
On 31.07.2017 15:13, Eric Engestrom wrote: From: Eric Engestrom CID: 1415909 Fixes: 7a34a0e8903249c41fae "ra: Add a callback for selecting a register from what's available." Signed-off-by: Eric Engestrom --- v2: don't free inside the loop... (Nicolai) Thanks! R

[Mesa-dev] [PATCH] Android: fix xmlconfig build

2017-07-31 Thread Rob Herring
Commit 601093f95ddf ("xmlconfig: move into src/util") broke the Android build due to missing libexpat dependency: external/mesa3d/src/util/xmlconfig.c:34:10: fatal error: 'expat.h' file not found Fixes: 601093f95ddf ("xmlconfig: move into src/util") Cc: Nicolai Hähnle Signed-off-by: Rob Herring

[Mesa-dev] [PATCH] ac/common: always build NIR translation

2017-07-31 Thread Nicolai Hähnle
From: Nicolai Hähnle radeonsi needs it now, and we require LLVM 3.9 anyway. Fixes a build with radeonsi but not radv. --- src/amd/Makefile.common.am | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/amd/Makefile.common.am b/src/amd/Makefile.common.am index dff461c

Re: [Mesa-dev] [PATCH 1/3] dri_interface: drop loaderPrivate from loader::getCapability()

2017-07-31 Thread Emil Velikov
On 31 July 2017 at 15:46, Marek Olšák wrote: > The idea is to allow the loader to access its own structures. It's sort of > like "this" in C++. > IIRC we have those for API that create objects (context, drawables, "get" buffers) and alike. I don't recall any other instances where we'd have a loade

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-31 Thread Rob Herring
On Fri, Jul 28, 2017 at 1:25 AM, Chih-Wei Huang wrote: > 2017-07-26 23:34 GMT+08:00 Rob Herring : >> On Tue, Jul 25, 2017 at 10:16 PM, Chih-Wei Huang >> wrote: >>> 2017-07-26 1:24 GMT+08:00 Rob Herring : I double checked and I get 8-8-8-8. I'm have HWC2 enabled and SurfaceFlinger i

Re: [Mesa-dev] [PATCH] Android: fix compile error for DRI2 loader getCapability

2017-07-31 Thread Emil Velikov
On 31 July 2017 at 16:26, Marek Olšák wrote: > On Mon, Jul 31, 2017 at 5:21 PM, Rob Herring wrote: >> On Mon, Jul 31, 2017 at 9:43 AM, Marek Olšák wrote: >>> Cc: 17.2 >> >> I thought this was only for master? > > Not anymore. See the commit in master. > Honestly I'll just do with Tomasz's fix f

Re: [Mesa-dev] [PATCH] Android: fix xmlconfig build

2017-07-31 Thread Nicolai Hähnle
Sorry about that, and thanks for fixing it! Reviewed-by: Nicolai Hähnle On 31.07.2017 17:46, Rob Herring wrote: Commit 601093f95ddf ("xmlconfig: move into src/util") broke the Android build due to missing libexpat dependency: external/mesa3d/src/util/xmlconfig.c:34:10: fatal error: 'expat.h'

Re: [Mesa-dev] [PATCH v7 0/6] mesa/st: glsl_to_tgsi: improved temp-reg lifetime estimation

2017-07-31 Thread Gert Wollny
Hi, the patch no longer applies to mesa master. I've pushed the rebased patch set to my github mirror (see below), but should I also send the corrected patches here? Best, Gert Am Montag, den 17.07.2017, 17:47 +0200 schrieb Gert Wollny: > Hello Nicolai, > > many thanks for the review. Wit

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-31 Thread Rob Herring
On Sun, Jul 30, 2017 at 10:48 AM, Chih-Wei Huang wrote: > Hi Rob, > Sorry to bother you again. > This patch also breaks the srwast/llvmpipe on Android > since the red and blue are just swapped. My guess is because in this case you use the framebuffer (/dev/fb0) and the format is fixed. The same p

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-31 Thread Rob Herring
On Fri, Jul 28, 2017 at 6:06 AM, Chih-Wei Huang wrote: > Hi Rob, > I'm testing this patch on an AMD radeon chip (PALM) now. > I use our legacy drm_gralloc since the radeon driver > doesn't support atomic api required by drm_hwcomposer. > > On SurfaceFlinger started, the screen just messed up. In

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-31 Thread Chih-Wei Huang
2017-08-01 0:18 GMT+08:00 Rob Herring : > On Fri, Jul 28, 2017 at 6:06 AM, Chih-Wei Huang > wrote: >> Hi Rob, >> I'm testing this patch on an AMD radeon chip (PALM) now. >> I use our legacy drm_gralloc since the radeon driver >> doesn't support atomic api required by drm_hwcomposer. >> >> On Surf

[Mesa-dev] [PATCH] dri_interface: document loaderPrivate for getCapability

2017-07-31 Thread Marek Olšák
From: Marek Olšák --- include/GL/internal/dri_interface.h | 4 1 file changed, 4 insertions(+) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index c314a43..457fc63 100644 --- a/include/GL/internal/dri_interface.h +++ b/include/GL/internal/dri_inter

Re: [Mesa-dev] [PATCH 5/6] mesa: Implement a new GL_MESA_tile_raster_order extension.

2017-07-31 Thread Eric Anholt
Jason Ekstrand writes: > On Thu, Jul 27, 2017 at 7:30 PM, Eric Anholt wrote: > >> The intent is to use this extension on vc4 to allow X11 to do overlapping >> CopyArea() within a pixmap without first blitting the pixmap to a >> temporary. With associated glamor patches, improves x11perf >> -cop

Re: [Mesa-dev] [PATCH] mesa/st: fix conditional jump depends on uninitialised value

2017-07-31 Thread Emil Velikov
On 31 July 2017 at 16:28, Marek Olšák wrote: > Please don't forget to nominate patches for stable. Thanks. > > Cc: 17.2 > Reviewed-by: Marek Olšák > Thanks Marek. JFYI: If the Fixes tag mentions a commit in stable, the fix will be automatically promoted. -Emil _

Re: [Mesa-dev] [PATCH] dri_interface: document loaderPrivate for getCapability

2017-07-31 Thread Emil Velikov
On 31 July 2017 at 17:21, Marek Olšák wrote: > From: Marek Olšák > > --- > include/GL/internal/dri_interface.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/include/GL/internal/dri_interface.h > b/include/GL/internal/dri_interface.h > index c314a43..457fc63 100644 > --- a/include

Re: [Mesa-dev] [PATCH] mesa: drop unnecessary GLAPIENTRY to _mesa_init_line()

2017-07-31 Thread Emil Velikov
Reviewed-by: Emil Velikov -Emil P.S. All other _mesa_init_* seems to be free of the notation. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2] gallium: add PIPE_QUERY_SO_OVERFLOW_ANY_PREDICATE and corresponding cap

2017-07-31 Thread Nicolai Hähnle
From: Nicolai Hähnle v2: rename cap to PIPE_CAP_QUERY_SO_OVERFLOW and be a bit more explicit in the documentation --- I decided to keep the query names as they were, to avoid any possibility of regression. Perhaps the non-ANY query could separate be renamed to PIPE_QUERY_SO_OVERFLOW_STREAM_P

[Mesa-dev] [PATCH] docs: Update feature list for GL 4.6

2017-07-31 Thread Adam Jackson
ARB_polygon_offset_clamp and ARB_texture_filter_anisotropic look like they'd be pretty trivial to wire up. Signed-off-by: Adam Jackson --- docs/features.txt | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index 79b

Re: [Mesa-dev] [PATCH 2/2] i965: Queue the buffer with a sync fence for Android OS v4.2

2017-07-31 Thread Marathe, Yogesh
Rafael, Tomasz, > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Rafael Antognolli > Sent: Tuesday, July 25, 2017 9:39 PM > To: Wu, Zhongmin > Cc: Gao, Shuo ; Liu, Zhiquan ; > Daniel Stone ; emil.l.veli...@gmail.com; Eric > Engestrom ;

[Mesa-dev] [RFC mesa 1/3] egl: deduplicate swap interval clamping logic

2017-07-31 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/platform_wayland.c | 14 +- src/egl/drivers/dri2/platform_x11.c | 9 + src/egl/main/eglapi.c | 6 ++ src/egl/main/eglsurface.c | 19 +-- 4 files changed, 9 insertio

[Mesa-dev] [RFC mesa 2/3] loader: remove clamp_swap_interval()

2017-07-31 Thread Eric Engestrom
As of last commit, no invalid swap interval can be stored, so there's no need to sanitize the values when reading them anymore. Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/platform_x11_dri3.c | 14 -- src/glx/dri3_glx.c | 7 --- src/loader/loader

[Mesa-dev] [RFC mesa 3/3] egl: make platform's SwapInterval() optional

2017-07-31 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/platform_wayland.c | 11 --- src/egl/main/eglapi.c | 5 - 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index

Re: [Mesa-dev] [RFC mesa 1/3] egl: deduplicate swap interval clamping logic

2017-07-31 Thread Daniel Stone
Hi Eric, On 31 July 2017 at 18:04, Eric Engestrom wrote: > @@ -956,16 +956,9 @@ dri2_x11_swap_interval(_EGLDriver *drv, _EGLDisplay > *disp, _EGLSurface *surf, > struct dri2_egl_display *dri2_dpy = dri2_egl_display(disp); > struct dri2_egl_surface *dri2_surf = dri2_egl_surface(surf); > >

[Mesa-dev] [PATCH] egl/dri2: Allow modifiers to add FDs to imports

2017-07-31 Thread Daniel Stone
When using dmabuf import, make sure that the modifier is actually allowed to add planes to the base format, as implied by the comment. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/egl_dri2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/egl_d

[Mesa-dev] [PATCH] intel/isl: Stop padding surfaces

2017-07-31 Thread Jason Ekstrand
The docs contain a bunch of commentary about the need to pad various surfaces out to multiples of something or other. However, all of those requirements are about avoiding GTT errors due to missing pages when the data port or sampler accesses slightly out-of-bounds. However, because the kernel al

[Mesa-dev] [PATCH 1/2] i965: annotate struct intel_image_format as const

2017-07-31 Thread Emil Velikov
From: Emil Velikov Already used as such througout the code. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/intel_image.h | 2 +- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 +- src/mesa/drivers/dri/i965/intel_screen.c | 16 3 files changed, 10 ins

[Mesa-dev] [PATCH 2/2] i965: simplify intel_image_format_lookup()

2017-07-31 Thread Emil Velikov
From: Emil Velikov Drop the local variable and return directly. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/intel_screen.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_sc

[Mesa-dev] [PATCH] util: use cannonical form of ARRAY_SIZE

2017-07-31 Thread Emil Velikov
From: Emil Velikov Namely sizeof(foo)/sizeof((foo)[]) Signed-off-by: Emil Velikov --- src/util/macros.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/macros.h b/src/util/macros.h index a66f1bfed07..a9a52a1a478 100644 --- a/src/util/macros.h +++ b/src/util/macros.

[Mesa-dev] [PATCH v2 1/2] st/dri: NULL check before deref DRI loader .getCapability

2017-07-31 Thread Emil Velikov
From: Emil Velikov One could have vX+1 which introduces another entrypoint without implementing older ones. v2: Rebase, while keeping loaderPrivate Fixes: 1bf703e4ea5 ("dri_interface,egl,gallium: only expose RGBA visuals on Android") Cc: 17.2 Signed-off-by: Emil Velikov Reviewed-by: Marek Olš

  1   2   3   >