[PATCH net-next v2 05/10] bnxt_en: Fix ethtool -l|-L inconsistent channel counts.

2016-09-19 Thread Michael Chan
The existing code is inconsistent in reporting and accepting the combined channel count. bnxt_get_channels() reports maximum combined as the maximum rx count. bnxt_set_channels() accepts combined count that cannot be bigger than max rx or max tx. For example, if max rx = 2 and max tx = 1, we rep

[PATCH net-next v2 09/10] bnxt_en: Support for "ethtool -r" command

2016-09-19 Thread Michael Chan
From: Deepak Khungar Restart autoneg if autoneg is enabled. Signed-off-by: Deepak Khungar Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool

[PATCH net-next v2 10/10] bnxt_en: Fixed the VF link status after a link state change

2016-09-19 Thread Michael Chan
From: Eddie Wai The VF link state can be changed via the 'ip link set' cmd. Currently, the new link state does not take effect immediately. The fix is for the PF to send a link change async event to the designated VF after a VF link state change. This async event will trigger the VF to update t

[PATCH net-next v2 04/10] bnxt_en: Added support for Secure Firmware Update

2016-09-19 Thread Michael Chan
From: Rob Swindell Using Ethtool flashdev command, entire NVM package (*.pkg) files may now be staged into the "update" area of the NVM and subsequently verified and installed by the firmware using the newly introduced command: NVM_INSTALL_UPDATE. We also introduce use of the new firmware comman

[PATCH net-next v2 03/10] bnxt_en: Update to firmware interface spec 1.5.1.

2016-09-19 Thread Michael Chan
Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c |3 + drivers/net/ethernet/broadcom/bnxt/bnxt.h | 14 +- drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 1251 +++-- 3 files changed, 760 insertions(+), 508 deletions(-) diff --git a/drive

[PATCH net-next v2 08/10] bnxt_en: Pad TX packets below 52 bytes.

2016-09-19 Thread Michael Chan
The hardware has a limitation that it won't pass host to BMC loopback packets below 52-bytes. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/eth

[PATCH net-next v2 01/10] bnxt_en: Use RSS flags defined in the bnxt_hsi.h file.

2016-09-19 Thread Michael Chan
And remove redundant definitions of the same flags. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 drivers/net/ethernet/broadcom/bnxt/bnxt.h | 5 - 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.

[PATCH net-next v2 00/10] bnxt: update for net-next.

2016-09-19 Thread Michael Chan
Misc. changes and minor bug fixes for net-next. Please review. v2: Updated "bnxt_en: Added support for Secure Firmware Update" patch. Deepak Khungar (1): bnxt_en: Support for "ethtool -r" command Eddie Wai (1): bnxt_en: Fixed the VF link status after a link state change Michael Chan (7):

[PATCH net-next v2 02/10] bnxt_en: Simplify PCI device names and add additinal PCI IDs.

2016-09-19 Thread Michael Chan
Remove "Single-port/Dual-port" from the device names. Dual-port devices will appear as 2 separate devices, so no need to call each a dual-port device. Use a more generic name for VF devices belonging to the same chip fanmily. Add some remaining NPAR device IDs. Signed-off-by: David Christensen

Re: [net-next PATCH] net: netlink messages for HW addr programming

2016-09-19 Thread Roopa Prabhu
On 9/19/16, 10:49 PM, Jiri Pirko wrote: > Tue, Sep 20, 2016 at 07:31:27AM CEST, ro...@cumulusnetworks.com wrote: >> On 9/19/16, 7:46 AM, Patrick Ruddy wrote: >>> On Sun, 2016-09-18 at 07:51 -0700, Roopa Prabhu wrote: On 9/15/16, 9:48 AM, Patrick Ruddy wrote: > Add RTM_NEWADDR and RTM_DELAD

[PATCH net-next 1/7] net/faraday: Separate rx page storage from rxdesc

2016-09-19 Thread Joel Stanley
From: Andrew Jeffery The ftgmac100 hardware revision in e.g. the Aspeed AST2500 no longer reserves all bits in RXDES#2 but instead uses the bottom 16 bits to store MAC frame metadata. Avoid corruption by shifting struct page pointers out to their own member in struct ftgmac100. Signed-off-by: An

[PATCH net-next 2/7] net/faraday: Make EDO{R,T}R bits configurable

2016-09-19 Thread Joel Stanley
From: Andrew Jeffery These bits are #defined at a fixed location. In order to support future hardware that has chosen to move these bits around move the bits into a member of the struct ftgmac100. Signed-off-by: Andrew Jeffery Signed-off-by: Joel Stanley --- drivers/net/ethernet/faraday/ftgma

[PATCH net-next 0/7] ftgmac100 support for ast2500

2016-09-19 Thread Joel Stanley
Hello Dave, This series adds support to the ftgmac100 driver for the Aspeed ast2400 and ast2500 SoCs. In particular, they ensure the driver works correctly on the ast2500 where the MAC block has seen some changes in register layout. They have been tested on ast2400 and ast2500 systems with the NC

[PATCH net-next 3/7] net/faraday: Adapt for Aspeed SoCs

2016-09-19 Thread Joel Stanley
The RXDES and TXDES registers bits in the ftgmac100 indicates EDO{R,T}R at bit position 15 for the Faraday Tech IP. However, the version of this IP present in the Aspeed SoCs has these bits at position 30 in the registers. It appers that ast2400 SoCs support both positions, with the 15th bit marke

[PATCH net-next 5/7] net/faraday: Clear stale interrupts

2016-09-19 Thread Joel Stanley
From: Gavin Shan There is stale interrupt (PHYSTS_CHG in ISR, bit#6 in 0x0) from the bootloader (uboot) when enabling the MAC. The stale interrupts aren't part of kernel and should be cleared. This clears the stale interrupts in ISR (0x0) when enabling the MAC. Signed-off-by: Gavin Shan Signed

[PATCH net-next 4/7] net/faraday: Avoid PHYSTS_CHG interrupt

2016-09-19 Thread Joel Stanley
From: Gavin Shan Bit#11 in MACCR (0x50) designates the signal level for PHY link status change. It's cleared, meaning high level enabled, by default. However, we can see continuous interrupt (bit#6) in ISR (0x0) for it and it's obviously a false alarm. The side effect is CPU cycles wasted to proc

[PATCH net-next 7/7] net/faraday: Configure old MDIO interface on Aspeed SoCs

2016-09-19 Thread Joel Stanley
The Aspeed SoCs have a new MDIO interface as an option in the G4 and G5 SoCs. The old one is still available, so select it in order to remain compatible with the ftgmac100 driver. Signed-off-by: Joel Stanley --- drivers/net/ethernet/faraday/ftgmac100.c | 9 + drivers/net/ethernet/faraday

[PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5 SoCs

2016-09-19 Thread Joel Stanley
On Aspeed SoC with a direct PHY connection (non-NSCI), we receive continual PHYSTS interrupts: [ 20.28] ftgmac100 1e66.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG [ 20.28] ftgmac100 1e66.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG [ 20.28] ftgmac100 1e66.ethernet eth0: [

[PATCHv2 net] cxgb4/cxgb4vf: Allocate more queues for 25G and 100G adapter

2016-09-19 Thread Hariprasad Shenai
We were missing check for 25G and 100G while checking port speed, which lead to less number of queues getting allocated for 25G & 100G adapters and leading to low throughput. Adding the missing check for both NIC and vNIC driver. Also fixes port advertisement for 25G and 100G in ethtool output. S

Re: [PATCH net] cxgb4/cxgb4vf: Allocate more queues for 100G adapter

2016-09-19 Thread Hariprasad Shenai
On Mon, Sep 19, 2016 at 01:32:46PM +0530, Hariprasad Shenai wrote: > We were missing check for 100G while checking port speed, which lead to > less number of queues getting allocated for 100G and leading to low > throughput. Adding the missing check for both NIC and vNIC driver. > > Signed-off-by:

Re: [patch net-next RFC 0/2] fib4 offload: notifier to let hw to be aware of all prefixes

2016-09-19 Thread Roopa Prabhu
On Mon, Sep 19, 2016 at 11:02 PM, Jiri Pirko wrote: > Tue, Sep 20, 2016 at 07:49:47AM CEST, ro...@cumulusnetworks.com wrote: [snip] >> >>Do you see any scale problems with using notifiers ?. as you know these ascis >>can scale to >>32k-128k routes. > > I don't see any problem there. What do you

Re: [patch net-next RFC 0/2] fib4 offload: notifier to let hw to be aware of all prefixes

2016-09-19 Thread Jiri Pirko
Tue, Sep 20, 2016 at 07:49:47AM CEST, ro...@cumulusnetworks.com wrote: >On 9/19/16, 8:15 AM, Jiri Pirko wrote: >> Mon, Sep 19, 2016 at 04:59:22PM CEST, ro...@cumulusnetworks.com wrote: >>> On 9/18/16, 11:14 PM, Jiri Pirko wrote: Mon, Sep 19, 2016 at 01:16:17AM CEST, ro...@cumulusnetworks.com w

[PATCH v3] iproute2: build nsid-name cache only for commands that need it

2016-09-19 Thread Anton Aksola
The calling of netns_map_init() before command parsing introduced a performance issue with large number of namespaces. As commands such as add, del and exec do not need to iterate through /var/run/netns it would be good not no build the cache before executing these commands. Example: unpatched: t

Re: [patch net-next RFC 0/2] fib4 offload: notifier to let hw to be aware of all prefixes

2016-09-19 Thread Roopa Prabhu
On 9/19/16, 8:15 AM, Jiri Pirko wrote: > Mon, Sep 19, 2016 at 04:59:22PM CEST, ro...@cumulusnetworks.com wrote: >> On 9/18/16, 11:14 PM, Jiri Pirko wrote: >>> Mon, Sep 19, 2016 at 01:16:17AM CEST, ro...@cumulusnetworks.com wrote: On 9/18/16, 1:00 PM, Florian Fainelli wrote: > Le 06/09/2016

Re: [net-next PATCH] net: netlink messages for HW addr programming

2016-09-19 Thread Jiri Pirko
Tue, Sep 20, 2016 at 07:31:27AM CEST, ro...@cumulusnetworks.com wrote: >On 9/19/16, 7:46 AM, Patrick Ruddy wrote: >> On Sun, 2016-09-18 at 07:51 -0700, Roopa Prabhu wrote: >>> On 9/15/16, 9:48 AM, Patrick Ruddy wrote: Add RTM_NEWADDR and RTM_DELADDR netlink messages with family AF_UNSPEC

Re: [net-next PATCH] net: netlink messages for HW addr programming

2016-09-19 Thread Roopa Prabhu
On 9/19/16, 7:46 AM, Patrick Ruddy wrote: > On Sun, 2016-09-18 at 07:51 -0700, Roopa Prabhu wrote: >> On 9/15/16, 9:48 AM, Patrick Ruddy wrote: >>> Add RTM_NEWADDR and RTM_DELADDR netlink messages with family >>> AF_UNSPEC to indicate interest in specific unicast and multicast >>> hardware addresse

Re: [PATCH v2 4/6] net: ethernet: bgmac: convert to feature flags

2016-09-19 Thread Rafał Miłecki
On 17 August 2016 at 13:34, Rafał Miłecki wrote: > On 8 July 2016 at 01:08, Jon Mason wrote: >> mode = (bgmac_read(bgmac, BGMAC_DEV_STATUS) & BGMAC_DS_MM_MASK) >> >> BGMAC_DS_MM_SHIFT; >> - if (ci->id != BCMA_CHIP_ID_BCM47162 || mode != 0) >> + if (bgmac->featu

[PATCH net-next] mlxsw: spectrum: Make offloads stats functions static

2016-09-19 Thread Or Gerlitz
The offloads stats functions are local to this file, make them static. Fixes: fc1bbb0f1831 ('mlxsw: spectrum: Implement offload stats ndo [..]') Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: 答复: [PATCH] sunrpc: queue work on system_power_efficient_wq

2016-09-19 Thread Chunyan Zhang
Resend behalf on Ke Wang. Thanks, Chunyan On 20 September 2016 at 10:33, Ke Wang (王科) wrote: > May I have any comments for this patch? > or > This patch can be merged directly into next release? > > Thanks, > Ke > > 发件人: Anna Schumaker > 发送时间: 2016年9月2日

Re: [PATCH v2 0/2] act_vlan: Introduce TCA_VLAN_ACT_MODIFY vlan action

2016-09-19 Thread Shmulik Ladkani
This is for net-next, forgot to mention. Deprecates the v1 of https://patchwork.ozlabs.org/patch/671403/

Re: [RFC v3 18/22] cgroup,landlock: Add CGRP_NO_NEW_PRIVS to handle unprivileged hooks

2016-09-19 Thread Sargun Dhillon
On Thu, Sep 15, 2016 at 09:41:33PM +0200, Mickaël Salaün wrote: > > On 15/09/2016 06:48, Alexei Starovoitov wrote: > > On Wed, Sep 14, 2016 at 09:38:16PM -0700, Andy Lutomirski wrote: > >> On Wed, Sep 14, 2016 at 9:31 PM, Alexei Starovoitov > >> wrote: > >>> On Wed, Sep 14, 2016 at 09:08:57PM -07

Re: [PATCH] net: skbuff: Fix length validation in skb_vlan_pop()

2016-09-19 Thread Shmulik Ladkani
Hi, On Mon, 19 Sep 2016 13:46:10 -0700 pravin shelar wrote: > On Mon, Sep 19, 2016 at 1:04 PM, Shmulik Ladkani > wrote: > > Hi Pravin, > > > > On Sun, 18 Sep 2016 13:26:30 -0700 pravin shelar wrote: > >> > +++ b/net/core/skbuff.c > >> > @@ -4537,7 +4537,7 @@ int skb_vlan_pop(struct sk_buff *s

[PATCH v4 net-next 10/16] tcp: allow congestion control module to request TSO skb segment count

2016-09-19 Thread Neal Cardwell
Add the tso_segs_goal() function in tcp_congestion_ops to allow the congestion control module to specify the number of segments that should be in a TSO skb sent by tcp_write_xmit() and tcp_xmit_retransmit_queue(). The congestion control module can either request a particular number of segments in T

[PATCH v4 net-next 12/16] tcp: export tcp_mss_to_mtu() for congestion control modules

2016-09-19 Thread Neal Cardwell
Export tcp_mss_to_mtu(), so that congestion control modules can use this to help calculate a pacing rate. Signed-off-by: Van Jacobson Signed-off-by: Neal Cardwell Signed-off-by: Yuchung Cheng Signed-off-by: Nandita Dukkipati Signed-off-by: Eric Dumazet Signed-off-by: Soheil Hassas Yeganeh --

[PATCH v4 net-next 00/16] tcp: BBR congestion control algorithm

2016-09-19 Thread Neal Cardwell
tcp: BBR congestion control algorithm This patch series implements a new TCP congestion control algorithm: BBR (Bottleneck Bandwidth and RTT). A paper with a detailed description of BBR will be published in ACM Queue, September-October 2016, as "BBR: Congestion-Based Congestion Control". BBR is wi

[PATCH v4 net-next 13/16] tcp: allow congestion control to expand send buffer differently

2016-09-19 Thread Neal Cardwell
From: Yuchung Cheng Currently the TCP send buffer expands to twice cwnd, in order to allow limited transmits in the CA_Recovery state. This assumes that cwnd does not increase in the CA_Recovery. For some congestion control algorithms, like the upcoming BBR module, if the losses in recovery do n

[PATCH v4 net-next 06/16] tcp: count packets marked lost for a TCP connection

2016-09-19 Thread Neal Cardwell
Count the number of packets that a TCP connection marks lost. Congestion control modules can use this loss rate information for more intelligent decisions about how fast to send. Specifically, this is used in TCP BBR policer detection. BBR uses a high packet loss rate as one signal in its policer

[PATCH v4 net-next 01/16] tcp: cdg: rename struct minmax in tcp_cdg.c to avoid a naming conflict

2016-09-19 Thread Neal Cardwell
From: Soheil Hassas Yeganeh The upcoming change "lib/win_minmax: windowed min or max estimator" introduces a struct called minmax, which is then included in include/linux/tcp.h in the upcoming change "tcp: use windowed min filter library for TCP min_rtt estimation". This would create a compilatio

[PATCH v4 net-next 02/16] lib/win_minmax: windowed min or max estimator

2016-09-19 Thread Neal Cardwell
This commit introduces a generic library to estimate either the min or max value of a time-varying variable over a recent time window. This is code originally from Kathleen Nichols. The current form of the code is from Van Jacobson. A single struct minmax_sample will track the estimated windowed-m

[PATCH v4 net-next 14/16] tcp: new CC hook to set sending rate with rate_sample in any CA state

2016-09-19 Thread Neal Cardwell
From: Yuchung Cheng This commit introduces an optional new "omnipotent" hook, cong_control(), for congestion control modules. The cong_control() function is called at the end of processing an ACK (i.e., after updating sequence numbers, the SACK scoreboard, and loss detection). At that moment we h

[PATCH v4 net-next 09/16] tcp: export data delivery rate

2016-09-19 Thread Neal Cardwell
From: Yuchung Cheng This commit export two new fields in struct tcp_info: tcpi_delivery_rate: The most recent goodput, as measured by tcp_rate_gen(). If the socket is limited by the sending application (e.g., no data to send), it reports the highest measurement instead of the most

[PATCH v4 net-next 16/16] tcp_bbr: add BBR congestion control

2016-09-19 Thread Neal Cardwell
This commit implements a new TCP congestion control algorithm: BBR (Bottleneck Bandwidth and RTT). A detailed description of BBR will be published in ACM Queue, Vol. 14 No. 5, September-October 2016, as "BBR: Congestion-Based Congestion Control". BBR has significantly increased throughput and redu

[PATCH v4 net-next 15/16] tcp: increase ICSK_CA_PRIV_SIZE from 64 bytes to 88

2016-09-19 Thread Neal Cardwell
The TCP CUBIC module already uses 64 bytes. The upcoming TCP BBR module uses 88 bytes. Signed-off-by: Van Jacobson Signed-off-by: Neal Cardwell Signed-off-by: Yuchung Cheng Signed-off-by: Nandita Dukkipati Signed-off-by: Eric Dumazet Signed-off-by: Soheil Hassas Yeganeh --- include/net/inet

[PATCH v4 net-next 11/16] tcp: export tcp_tso_autosize() and parameterize minimum number of TSO segments

2016-09-19 Thread Neal Cardwell
To allow congestion control modules to use the default TSO auto-sizing algorithm as one of the ingredients in their own decision about TSO sizing: 1) Export tcp_tso_autosize() so that CC modules can use it. 2) Change tcp_tso_autosize() to allow callers to specify a minimum number of segments p

[PATCH v4 net-next 08/16] tcp: track application-limited rate samples

2016-09-19 Thread Neal Cardwell
From: Soheil Hassas Yeganeh This commit adds code to track whether the delivery rate represented by each rate_sample was limited by the application. Upon each transmit, we store in the is_app_limited field in the skb a boolean bit indicating whether there is a known "bubble in the pipe": a point

[PATCH v4 net-next 03/16] tcp: use windowed min filter library for TCP min_rtt estimation

2016-09-19 Thread Neal Cardwell
Refactor the TCP min_rtt code to reuse the new win_minmax library in lib/win_minmax.c to simplify the TCP code. This is a pure refactor: the functionality is exactly the same. We just moved the windowed min code to make TCP easier to read and maintain, and to allow other parts of the kernel to use

[PATCH v4 net-next 05/16] tcp: switch back to proper tcp_skb_cb size check in tcp_init()

2016-09-19 Thread Neal Cardwell
From: Eric Dumazet Revert to the tcp_skb_cb size check that tcp_init() had before commit b4772ef879a8 ("net: use common macro for assering skb->cb[] available size in protocol families"). As related commit 744d5a3e9fe2 ("net: move skb->dropcount to skb->cb[]") explains, the sock_skb_cb_check_size

[PATCH v4 net-next 04/16] net_sched: sch_fq: add low_rate_threshold parameter

2016-09-19 Thread Neal Cardwell
From: Eric Dumazet This commit adds to the fq module a low_rate_threshold parameter to insert a delay after all packets if the socket requests a pacing rate below the threshold. This helps achieve more precise control of the sending rate with low-rate paths, especially policers. The basic issue

[PATCH v4 net-next 07/16] tcp: track data delivery rate for a TCP connection

2016-09-19 Thread Neal Cardwell
From: Yuchung Cheng This patch generates data delivery rate (throughput) samples on a per-ACK basis. These rate samples can be used by congestion control modules, and specifically will be used by TCP BBR in later patches in this series. Key state: tp->delivered: Tracks the total number of data

[PATCH net-next] net: ethernet: mediatek: enhance with avoiding superfluous assignment inside mtk_get_ethtool_stats

2016-09-19 Thread sean.wang
From: Sean Wang data_src is unchanged inside the loop, so this patch moves the assignment to outside the loop to avoid unnecessarily assignment Signed-off-by: Sean Wang --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers

Re: [PATCHv2 net-next 0/2] Preparation for mv88e6390

2016-09-19 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > These two patches are a couple of preparation steps for supporting the > the MV88E6390 family of chips. This is a new generation from Marvell, > and will need more feature flags than are currently available in an > unsigned long. Expand to an unsigned long long.

Re: [PATCHv2 net-next 1/2] net: dsa: mv88e6xxx: Add helper for accessing port registers

2016-09-19 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > @@ -585,19 +601,19 @@ static void mv88e6xxx_adjust_link(struct dsa_switch > *ds, int port, > struct phy_device *phydev) > { > struct mv88e6xxx_chip *chip = ds->priv; > - u32 reg; > - int ret; > + u16 reg; > +

Re: [PATCH net 0/3] mlx5 fixes to 4.8-rc6

2016-09-19 Thread David Miller
From: Or Gerlitz Date: Sun, 18 Sep 2016 18:20:26 +0300 > This series series has a fix from Roi to memory corruption bug in > the bulk flow counters code and two late and hopefully last fixes > from me to the new eswitch offloads code. > > Series done over net commit 37dd348 "bna: fix crash in

Re: [PATCHv6 net-next 00/15] BPF hardware offload (cls_bpf for now)

2016-09-19 Thread David Miller
From: Jakub Kicinski Date: Sun, 18 Sep 2016 16:09:10 +0100 > As spotted by Daniel JIT might have accessed indexes past the end > of verifier's reg_state array. This series doesn't apply cleanly to net-next, please respin. Thanks.

Re: [PATCH net-next 1/1] net sched actions police: peg drop stats for conforming traffic

2016-09-19 Thread David Miller
From: Jamal Hadi Salim Date: Sun, 18 Sep 2016 07:53:08 -0400 > From: Roman Mashak > > setting conforming action to drop is a valid policy. > When it is set we need to at least see the stats indicating it > for debugging. > > Signed-off-by: Roman Mashak > Signed-off-by: Jamal Hadi Salim Appl

Re: [PATCH net-next 1/1] net sched: stylistic cleanups

2016-09-19 Thread David Miller
From: Jamal Hadi Salim Date: Sun, 18 Sep 2016 08:45:33 -0400 > From: Jamal Hadi Salim > > Signed-off-by: Jamal Hadi Salim Applied.

Re: [PATCH] net: hns: mark symbols static where possible

2016-09-19 Thread David Miller
From: Baoyou Xie Date: Sun, 18 Sep 2016 17:07:25 +0800 > We get a few warnings when building kernel with W=1: > drivers/net/ethernet/hisilicon/hisi_femac.c:943:5: warning: no previous > prototype for 'hisi_femac_drv_suspend' [-Wmissing-prototypes] > drivers/net/ethernet/hisilicon/hisi_femac.c:96

Re: [PATCH v3 net-next 1/2] net sched ife action: add 16 bit helpers

2016-09-19 Thread David Miller
From: Jamal Hadi Salim Date: Sun, 18 Sep 2016 07:31:42 -0400 > From: Jamal Hadi Salim > > encoder and checker for 16 bits metadata > > Signed-off-by: Jamal Hadi Salim Applied.

Re: [PATCH] phy: mark lan88xx_suspend() static

2016-09-19 Thread David Miller
From: Baoyou Xie Date: Sun, 18 Sep 2016 16:26:34 +0800 > We get 1 warning when building kernel with W=1: > drivers/net/phy/microchip.c:58:5: warning: no previous prototype for > 'lan88xx_suspend' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declare

Re: [PATCH v3 net-next 2/2] net sched ife action: Introduce skb tcindex metadata encap decap

2016-09-19 Thread David Miller
From: Jamal Hadi Salim Date: Sun, 18 Sep 2016 07:31:43 -0400 > From: Jamal Hadi Salim > > Sample use case of how this is encoded: > user space via tuntap (or a connected VM/Machine/container) > encodes the tcindex TLV. > > Sample use case of decoding: > IFE action decodes it and the skb->tc_in

Re: [PATCH] cxgb4: mark symbols static where possible

2016-09-19 Thread David Miller
From: Baoyou Xie Date: Sun, 18 Sep 2016 17:18:23 +0800 > We get a few warnings when building kernel with W=1: > drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c:178:5: warning: no previous > prototype for 'setup_sge_queues_uld' [-Wmissing-prototypes] > drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.

Re: [PATCH] be2net: mark symbols static where possible

2016-09-19 Thread David Miller
From: Baoyou Xie Date: Sun, 18 Sep 2016 16:35:29 +0800 > We get 4 warnings when building kernel with W=1: > drivers/net/ethernet/emulex/benet/be_main.c:4368:6: warning: no previous > prototype for 'be_calculate_pf_pool_rss_tables' [-Wmissing-prototypes] > drivers/net/ethernet/emulex/benet/be_cmd

Re: [v3 PATCH 1/2] rhashtable: Add rhlist interface

2016-09-19 Thread Herbert Xu
On Mon, Sep 19, 2016 at 11:16:21PM +0200, Thomas Graf wrote: > > Nice, I like how this simplifies users! Is this suitable for > ILA as well? Does it have duplicate objects and use inelastic_security? If so then yes it should switch over to rhlist. Cheers, -- Email: Herbert Xu Home Page: http://

Re: [PATCH RFC 2/6] rhashtable: Call library function alloc_bucket_locks

2016-09-19 Thread Herbert Xu
Tom Herbert wrote: > To allocate the array of bucket locks for the hash table we now > call library function alloc_bucket_spinlocks. This function is > based on the old alloc_bucket_locks in rhashtable and should > produce the same effect. > > Signed-off-by: Tom Herbert This conflicts with the

Re: [PATCH 2/2] net: ethernet: broadcom: b44: use new api ethtool_{get|set}_link_ksettings

2016-09-19 Thread David Miller
From: Philippe Reynes Date: Sun, 18 Sep 2016 00:11:35 +0200 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 2/2] net: ethernet: broadcom: bcm63xx: use new api ethtool_{get|set}_link_ksettings

2016-09-19 Thread David Miller
From: Philippe Reynes Date: Sun, 18 Sep 2016 16:59:07 +0200 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 1/2] net: ethernet: broadcom: bcm63xx: use phydev from struct net_device

2016-09-19 Thread David Miller
From: Philippe Reynes Date: Sun, 18 Sep 2016 16:59:06 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one contained in struct

Re: [PATCH] net: ethernet: broadcom: bcmgenet: use new api ethtool_{get|set}_link_ksettings

2016-09-19 Thread David Miller
From: Philippe Reynes Date: Sun, 18 Sep 2016 17:16:45 +0200 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 1/2] net: ethernet: broadcom: b44: use phydev from struct net_device

2016-09-19 Thread David Miller
From: Philippe Reynes Date: Sun, 18 Sep 2016 00:11:34 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one contained in struct

Re: [PATCH net-next 00/10] bnxt: update for net-next.

2016-09-19 Thread David Miller
From: Michael Chan Date: Mon, 19 Sep 2016 03:57:59 -0400 > Misc. changes and minor bug fixes for net-next. Please review. Series applied, thanks Michael.

Re: lsm naming dilemma. Re: [RFC v3 07/22] landlock: Handle file comparisons

2016-09-19 Thread Sargun Dhillon
I'm fine giving up the Checmate name. Landlock seems easy enough to Google. I haven't gotten a chance to look through the entire patchset yet, but it does seem like they are somewhat similar. On Mon, Sep 19, 2016 at 5:12 PM, Alexei Starovoitov wrote: > On Thu, Sep 15, 2016 at 11:25:10PM +0200, Mi

Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

2016-09-19 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > On Mon, Sep 19, 2016 at 07:56:11PM -0400, Vivien Didelot wrote: >> An address can be loaded in the ATU with multiple ports, for instance >> when adding multiple ports to a Multicast group with "bridge mdb". >> >> The current code doesn't allow that. Add an helper

Re: [PATCH net-next v6] gso: Support partial splitting at the frag_list pointer

2016-09-19 Thread David Miller
From: Alexander Duyck Date: Mon, 19 Sep 2016 08:12:15 -0700 > On Mon, Sep 19, 2016 at 3:58 AM, Steffen Klassert > wrote: >> Since commit 8a29111c7 ("net: gro: allow to build full sized skb") >> gro may build buffers with a frag_list. This can hurt forwarding >> because most NICs can't offload su

Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

2016-09-19 Thread Andrew Lunn
On Mon, Sep 19, 2016 at 07:56:11PM -0400, Vivien Didelot wrote: > An address can be loaded in the ATU with multiple ports, for instance > when adding multiple ports to a Multicast group with "bridge mdb". > > The current code doesn't allow that. Add an helper to get a single entry > from the ATU,

[PATCHv2 net-next 1/2] net: dsa: mv88e6xxx: Add helper for accessing port registers

2016-09-19 Thread Andrew Lunn
There is a device coming soon which places its port registers somewhere different to all other Marvell switches supported so far. Add helper functions for reading/writing port registers, making it easier to handle this new device. Signed-off-by: Andrew Lunn --- v2: Call mv88e6xxx_{read|write} in

[PATCHv2 net-next 2/2] net: dsa: mv88e6xxx: Convert flag bits to unsigned long long

2016-09-19 Thread Andrew Lunn
We are soon going to run out of flag bits on 32bit systems. Convert to unsigned long long. Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 62 +-- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/d

[PATCHv2 net-next 0/2] Preparation for mv88e6390

2016-09-19 Thread Andrew Lunn
These two patches are a couple of preparation steps for supporting the the MV88E6390 family of chips. This is a new generation from Marvell, and will need more feature flags than are currently available in an unsigned long. Expand to an unsigned long long. The MV88E6390 also places its port registe

Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

2016-09-19 Thread Andrew Lunn
On Mon, Sep 19, 2016 at 08:29:40PM -0400, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > > Hi Vivien > > > >> + do { > >> + err = _mv88e6xxx_atu_getnext(chip, fid, &next); > >> + if (err) > >> + return err; > >> + > >> + if (next.state

Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

2016-09-19 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > Hi Vivien > >> +do { >> +err = _mv88e6xxx_atu_getnext(chip, fid, &next); >> +if (err) >> +return err; >> + >> +if (next.state == GLOBAL_ATU_DATA_STATE_UNUSED) >> +break; >> + >> +

Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

2016-09-19 Thread Andrew Lunn
Hi Vivien > + do { > + err = _mv88e6xxx_atu_getnext(chip, fid, &next); > + if (err) > + return err; > + > + if (next.state == GLOBAL_ATU_DATA_STATE_UNUSED) > + break; > + > + if (ether_addr_equal(next.mac,

lsm naming dilemma. Re: [RFC v3 07/22] landlock: Handle file comparisons

2016-09-19 Thread Alexei Starovoitov
On Thu, Sep 15, 2016 at 11:25:10PM +0200, Mickaël Salaün wrote: > >> Agreed. With this RFC, the Checmate features (i.e. network helpers) > >> should be able to sit on top of Landlock. > > > > I think neither of them should be called fancy names for no technical > > reason. > > We will have only o

[PATCH iproute2 net-next] iptnl: add support for collect_md flag in IPv4 and IPv6 tunnels

2016-09-19 Thread Alexei Starovoitov
Signed-off-by: Alexei Starovoitov --- Stephen, please sync include/uapi/linux/if_tunnel.h from the kernel tree before applying. Thanks --- ip/link_ip6tnl.c | 10 ++ ip/link_iptnl.c | 11 +++ 2 files changed, 21 insertions(+) diff --git a/ip/link_ip6tnl.c b/ip/link_ip6tnl.c index

[PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

2016-09-19 Thread Vivien Didelot
An address can be loaded in the ATU with multiple ports, for instance when adding multiple ports to a Multicast group with "bridge mdb". The current code doesn't allow that. Add an helper to get a single entry from the ATU, then set or clear the requested port, before loading the entry back in the

Re: [PATCH v3 net-next 16/16] tcp_bbr: add BBR congestion control

2016-09-19 Thread Eric Dumazet
> > It generates some slightly smaller code. > if (bbr->lt_rtt_cnt < bbr_lt_intvl_min_rtts) > - 3e7: 0f b6 c0movzbl %al,%eax > - 3ea: 83 f8 03cmp$0x3,%eax > - 3ed: 0f 86 d4 00 00 00 jbe4c7 > + 3e7: 3c 03 cmp$0x3,%al >

Re: [PATCH v3 net-next 16/16] tcp_bbr: add BBR congestion control

2016-09-19 Thread Stephen Hemminger
On Mon, 19 Sep 2016 14:10:39 -0700 Eric Dumazet wrote: > On Mon, Sep 19, 2016 at 1:57 PM, Stephen Hemminger > wrote: > > > Looks good, but could I suggest a simple optimization. > > All these parameters are immutable in the version of BBR you are submitting. > > Why not make the values const? A

[PATCH v5 net-next 1/1] net sched actions: fix GETing actions

2016-09-19 Thread Jamal Hadi Salim
From: Jamal Hadi Salim With the batch changes that translated transient actions into a temporary list lost in the translation was the fact that tcf_action_destroy() will eventually delete the action from the permanent location if the refcount is zero. Example of what broke: ...add a gact action

Re: [PATCH net-next 2/2] net: dsa: mv88e6xxx: Convert flag bits to unsigned long long

2016-09-19 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > We are soon going to run out of flag bits on 32bit systems. Convert to > unsigned long long. > > Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot Thanks, Vivien

Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: Add helper for accessing port registers

2016-09-19 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > @@ -41,6 +41,11 @@ static void assert_reg_lock(struct mv88e6xxx_chip *chip) > } > } > > +static int mv88e6xxx_reg_port(struct mv88e6xxx_chip *chip, int port) > +{ > + return chip->info->port_base_addr + port; > +} > + If we really want such helper,

[PATCH net-next 0/3] BPF direct packet access improvements

2016-09-19 Thread Daniel Borkmann
This set adds write support to the currently available read support for {cls,act}_bpf programs. First one is a fix for affected commit sitting in net-next and prerequisite for the second one, last patch adds a number of test cases against the verifier. For details, please see individual patches. T

[PATCH net-next 1/3] bpf, verifier: enforce larger zero range for pkt on overloading stack buffs

2016-09-19 Thread Daniel Borkmann
Current contract for the following two helper argument types is: * ARG_CONST_STACK_SIZE: passed argument pair must be (ptr, >0). * ARG_CONST_STACK_SIZE_OR_ZERO: passed argument pair can be either (NULL, 0) or (ptr, >0). With 6841de8b0d03 ("bpf: allow helpers access the packet directly"),

[PATCH net-next 2/3] bpf: direct packet write and access for helpers for clsact progs

2016-09-19 Thread Daniel Borkmann
This work implements direct packet access for helpers and direct packet write in a similar fashion as already available for XDP types via commits 4acf6c0b84c9 ("bpf: enable direct packet data write for xdp progs") and 6841de8b0d03 ("bpf: allow helpers access the packet directly"), and as a compleme

[PATCH net-next 3/3] bpf: add test cases for direct packet access

2016-09-19 Thread Daniel Borkmann
Add couple of test cases for direct write and the negative size issue, and also adjust the direct packet access test4 since it asserts that writes are not possible, but since we've just added support for writes, we need to invert the verdict to ACCEPT, of course. Summary: 133 PASSED, 0 FAILED. Sig

[PATCH net-next 0/2] Preparation for mv88e6390

2016-09-19 Thread Andrew Lunn
These two patches are a couple of preparation steps for supporting the the MV88E6390 family of chips. This is a new generation from Marvell, and will need more feature flags than are currently available in an unsigned long. Expand to an unsigned long long. The MV88E6390 also places its port registe

[PATCH net-next 1/2] net: dsa: mv88e6xxx: Add helper for accessing port registers

2016-09-19 Thread Andrew Lunn
There is a device coming soon which places its port registers somewhere different to all other Marvell switches supported so far. Add helper functions for reading/writing port registers, making it easier to handle this new device. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c

[PATCH net-next 2/2] net: dsa: mv88e6xxx: Convert flag bits to unsigned long long

2016-09-19 Thread Andrew Lunn
We are soon going to run out of flag bits on 32bit systems. Convert to unsigned long long. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 62 +-- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/mv88

Re: [PATCH] igb: mark igb_rxnfc_write_vlan_prio_filter() static

2016-09-19 Thread Jeff Kirsher
On Sun, 2016-09-18 at 16:50 +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: no previous > prototype for 'igb_rxnfc_write_vlan_prio_filter' [-Wmissing-prototypes] > > In fact, this function is only used in th

Re: [PATCHv6 net-next 04/15] bpf: don't (ab)use instructions to store state

2016-09-19 Thread Daniel Borkmann
On 09/19/2016 11:48 PM, Jakub Kicinski wrote: On Mon, 19 Sep 2016 23:44:50 +0200, Daniel Borkmann wrote: On 09/19/2016 11:36 PM, Jakub Kicinski wrote: On Mon, 19 Sep 2016 23:03:17 +0200, Daniel Borkmann wrote: On 09/18/2016 05:09 PM, Jakub Kicinski wrote: Storing state in reserved fields of i

Re: [PATCH v5 0/6] Add eBPF hooks for cgroups

2016-09-19 Thread Sargun Dhillon
On Mon, Sep 19, 2016 at 06:34:28PM +0200, Daniel Mack wrote: > Hi, > > On 09/16/2016 09:57 PM, Sargun Dhillon wrote: > > On Wed, Sep 14, 2016 at 01:13:16PM +0200, Daniel Mack wrote: > > >> I have no idea what makes you think this is limited to systemd. As I > >> said, I provided an example for us

Re: [PATCHv6 net-next 04/15] bpf: don't (ab)use instructions to store state

2016-09-19 Thread Jakub Kicinski
On Mon, 19 Sep 2016 23:44:50 +0200, Daniel Borkmann wrote: > On 09/19/2016 11:36 PM, Jakub Kicinski wrote: > > On Mon, 19 Sep 2016 23:03:17 +0200, Daniel Borkmann wrote: > >> On 09/18/2016 05:09 PM, Jakub Kicinski wrote: > >>> Storing state in reserved fields of instructions makes > >>> it impo

Re: [PATCHv6 net-next 04/15] bpf: don't (ab)use instructions to store state

2016-09-19 Thread Daniel Borkmann
On 09/19/2016 11:36 PM, Jakub Kicinski wrote: On Mon, 19 Sep 2016 23:03:17 +0200, Daniel Borkmann wrote: On 09/18/2016 05:09 PM, Jakub Kicinski wrote: Storing state in reserved fields of instructions makes it impossible to run verifier on programs already marked as read-only. Allocate and use a

  1   2   3   >