[PATCH bpf-next 10/10] [bpf]: make virtio compatible w/ bpf_xdp_adjust_tail

2018-04-16 Thread Nikita V. Shirokov
w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as well (only "decrease" of pointer's location is going to be supported). changing of this pointer will change packet's size. for virtio driver we need to adjust XDP_PASS handling by recalculating length of the packet if it was p

[PATCH bpf-next 09/10] [bpf]: make tun compatible w/ bpf_xdp_adjust_tail

2018-04-16 Thread Nikita V. Shirokov
w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as well (only "decrease" of pointer's location is going to be supported). changing of this pointer will change packet's size. for tun driver we need to adjust XDP_PASS handling by recalculating length of the packet if it was pass

Re: tcp hang when socket fills up ?

2018-04-16 Thread Michal Kubecek
On Mon, Apr 16, 2018 at 10:28:11PM -0700, Eric Dumazet wrote: > > I turned pr_debug on in tcp_in_window() for another try and it's a bit > > mangled because the information on multiple lines and the function is > > called in parallel but it looks like I do have some seq > maxend +1 > > > > Althoug

[PATCH bpf-next 08/10] [bpf]: make netronome nfp compatible w/ bpf_xdp_adjust_tail

2018-04-16 Thread Nikita V. Shirokov
w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as well (only "decrease" of pointer's location is going to be supported). changing of this pointer will change packet's size. for nfp driver we will just calculate packet's length unconditionally Signed-off-by: Nikita V. Shiroko

[PATCH bpf-next 02/10] [bpf]: adding tests for bpf_xdp_adjust_tail

2018-04-16 Thread Nikita V. Shirokov
adding selftests for bpf_xdp_adjust_tail helper. in this syntetic test we are testing that 1) if data_end < data helper will return EINVAL 2) for normal use case packet's length would be reduced. aside from adding new tests i'm changing behaviour of bpf_prog_test_run so it would recalculate packet

[PATCH bpf-next 05/10] [bpf]: make mlx4 compatible w/ bpf_xdp_adjust_tail

2018-04-16 Thread Nikita V. Shirokov
w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as well (only "decrease" of pointer's location is going to be supported). changing of this pointer will change packet's size. for mlx4 driver we will just calculate packet's length unconditionally (the same way as it's already be

[PATCH bpf-next 04/10] [bpf]: make generic xdp compatible w/ bpf_xdp_adjust_tail

2018-04-16 Thread Nikita V. Shirokov
w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as well (only "decrease" of pointer's location is going to be supported). changing of this pointer will change packet's size. for generic XDP we need to reflect this packet's length change by adjusting skb's tail pointer Signed-

[PATCH bpf-next 00/10] introduction of bpf_xdp_adjust_tail

2018-04-16 Thread Nikita V. Shirokov
In this patch series i'm adding new bpf helper which allow to manupulate xdp's data_end pointer. right now only "shrinking" (reduce packet's size by moving pointer) is supported (and i see no use case for "growing"). Main use case for such helper is to be able to generate controll (ICMP) messages f

[PATCH bpf-next 06/10] [bpf]: make bnxt compatible w/ bpf_xdp_adjust_tail

2018-04-16 Thread Nikita V. Shirokov
w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as well (only "decrease" of pointer's location is going to be supported). changing of this pointer will change packet's size. for bnxt driver we will just calculate packet's length unconditionally Signed-off-by: Nikita V. Shirok

[PATCH bpf-next 07/10] [bpf]: make cavium thunder compatible w/ bpf_xdp_adjust_tail

2018-04-16 Thread Nikita V. Shirokov
w/ bpf_xdp_adjust_tail helper xdp's data_end pointer could be changed as well (only "decrease" of pointer's location is going to be supported). changing of this pointer will change packet's size. for cavium's thunder driver we will just calculate packet's length unconditionally Signed-off-by: Niki

[PATCH bpf-next 01/10] [bpf]: adding bpf_xdp_adjust_tail helper

2018-04-16 Thread Nikita V. Shirokov
Adding new bpf helper which would allow us to manipulate xdp's data_end pointer, and allow us to reduce packet's size indended use case: to generate ICMP messages from XDP context, where such message would contain truncated original packet. Signed-off-by: Nikita V. Shirokov --- include/uapi/linu

[PATCH bpf-next 03/10] [bpf]: add bpf_xdp_adjust_tail sample prog

2018-04-16 Thread Nikita V. Shirokov
adding bpf's sample program which is using bpf_xdp_adjust_tail helper by generating ICMPv4 "packet to big" message if ingress packet's size is bigger then 600 bytes Signed-off-by: Nikita V. Shirokov --- samples/bpf/Makefile | 4 + samples/bpf/xdp_adjust_tail_kern.c

[PATCH net-next] liquidio: Enhanced ethtool stats

2018-04-16 Thread Felix Manlunas
From: Intiyaz Basha 1. Added red_drops stats. Inbound packets dropped by RED, buffer exhaustion 2. Included fcs_err, jabber_err, l2_err and frame_err errors under rx_errors 3. Included fifo_err, dmac_drop, red_drops, fw_err_pko, fw_err_link and fw_err_drop under rx_dropped 4. Included max_c

[PATCH] VSOCK: make af_vsock.ko removable again

2018-04-16 Thread Stefan Hajnoczi
Commit c1eef220c1760762753b602c382127bfccee226d ("vsock: always call vsock_init_tables()") introduced a module_init() function without a corresponding module_exit() function. Modules with an init function can only be removed if they also have an exit function. Therefore the vsock module was consi

Re: XDP performance regression due to CONFIG_RETPOLINE Spectre V2

2018-04-16 Thread Christoph Hellwig
> I'm not sure if I am really a fan of trying to solve this in this way. > It seems like this is going to be optimizing the paths for one case at > the detriment of others. Historically mapping and unmapping has always > been expensive, especially in the case of IOMMU enabled environments. > I woul

Re: XDP performance regression due to CONFIG_RETPOLINE Spectre V2

2018-04-16 Thread Christoph Hellwig
On Mon, Apr 16, 2018 at 11:07:04PM +0200, Jesper Dangaard Brouer wrote: > On X86 swiotlb fallback (via get_dma_ops -> get_arch_dma_ops) to use > x86_swiotlb_dma_ops, instead of swiotlb_dma_ops. I also included that > in below fix patch. x86_swiotlb_dma_ops should not exist any mor, and x86 now us

[PATCH net-next] vxlan: add ttl inherit support

2018-04-16 Thread Hangbin Liu
Like tos inherit, ttl inherit should also means inherit the inner protocol's ttl values, which actually not implemented in vxlan yet. But we could not treat ttl == 0 as "use the inner TTL", because that would be used also when the "ttl" option is not specified and that would be a behavior change,

Re: tcp hang when socket fills up ?

2018-04-16 Thread Eric Dumazet
On 04/16/2018 08:52 PM, Dominique Martinet wrote: > Thank you for the hints. Out of order reply. > > Florian Westphal wrote on Mon, Apr 16, 2018: >> echo 1 > /proc/sys/net/netfilter/nf_conntrack_tcp_be_liberal >> >> which stops conntrack from marking packets with out-of-window >> acks as invalid

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

2018-04-16 Thread Michael Karcher
[Andrew, sorry for the dup. I did hit reply-to-auhor instead of reply-to-all first.] Andrew Lunn schrieb: >> > This should really be fixed in the PHY driver, not the MAC. >> >> OK - do you want this separate, or as part of this series? Might have >> a few side effects on more commonly used hardwar

[PATCH bpf-next 1/2] bpf: add helper for getting xfrm states

2018-04-16 Thread Eyal Birger
This commit introduces a helper which allows fetching xfrm state parameters by eBPF programs attached to TC. Prototype: bpf_skb_get_xfrm_state(skb, index, xfrm_state, size, flags) skb: pointer to skb index: the index in the skb xfrm_state secpath array xfrm_state: pointer to 'struct bpf_xfrm_stat

[PATCH bpf-next 2/2] samples/bpf: extend test_tunnel_bpf.sh with xfrm state test

2018-04-16 Thread Eyal Birger
Add a test for fetching xfrm state parameters from a tc program running on ingress. Signed-off-by: Eyal Birger --- samples/bpf/tcbpf2_kern.c | 15 +++ samples/bpf/test_tunnel_bpf.sh| 71 +++ tools/include/uapi/linux/bpf.h| 2

Re: [PATCH net-next 2/2] openvswitch: Support conntrack zone limit (fwd)

2018-04-16 Thread Julia Lawall
Line 1814 frees something that is dereferenced on the next line. julia -- Forwarded message -- Date: Tue, 17 Apr 2018 10:32:17 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH net-next 2/2] openvswitch: Support conntrack zone limit CC: kbuild

[PATCH bpf-next 0/2] bpf: add helper for getting xfrm states

2018-04-16 Thread Eyal Birger
This patchset adds support for fetching XFRM state information from an eBPF program called from TC. The first patch introduces a helper for fetching an XFRM state from the skb's secpath. The XFRM state is modeled using a new virtual struct which contains the SPI, peer address, and reqid values of

[PATCH RESEND net-next] net/ncsi: Refactor MAC, VLAN filters

2018-04-16 Thread Samuel Mendoza-Jonas
The NCSI driver defines a generic ncsi_channel_filter struct that can be used to store arbitrarily formatted filters, and several generic methods of accessing data stored in such a filter. However in both the driver and as defined in the NCSI specification there are only two actual filters: VLAN ID

general protection fault in encode_rpcb_string

2018-04-16 Thread syzbot
Hello, syzbot hit the following crash on bpf-next commit 5d1365940a68dd57b031b6e3c07d7d451cd69daf (Thu Apr 12 18:09:05 2018 +) Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=4b98281f2401ab849f4b So far this cras

Re: [PATCH net-next 3/5] ipv4: support sport, dport and ip protocol in RTM_GETROUTE

2018-04-16 Thread Roopa Prabhu
On Mon, Apr 16, 2018 at 3:58 PM, David Miller wrote: > From: Roopa Prabhu > Date: Mon, 16 Apr 2018 13:41:36 -0700 > >> diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h >> index 9b15005..7947252 100644 >> --- a/include/uapi/linux/rtnetlink.h >> +++ b/include/uapi/linux/

[PATCH][net-next] net: ip tos cgroup

2018-04-16 Thread Li RongQing
ip tos segment can be changed by setsockopt(IP_TOS), or by iptables; this patch creates a new method to change socket tos segment of processes based on cgroup The usage: 1. mount ip_tos cgroup, and setting tos value mount -t cgroup -o ip_tos ip_tos /cgroups/tos echo tos_value >/cgroup

Re: [RFC v2] virtio: support packed ring

2018-04-16 Thread Tiwei Bie
On Tue, Apr 17, 2018 at 10:11:58AM +0800, Jason Wang wrote: > On 2018年04月13日 15:15, Tiwei Bie wrote: > > On Fri, Apr 13, 2018 at 12:30:24PM +0800, Jason Wang wrote: > > > On 2018年04月01日 22:12, Tiwei Bie wrote: [...] > > > > +static int detach_buf_packed(struct vring_virtqueue *vq, unsigned int > >

Re: [RFC v2] virtio: support packed ring

2018-04-16 Thread Michael S. Tsirkin
On Tue, Apr 17, 2018 at 10:24:32AM +0800, Jason Wang wrote: > > > On 2018年04月17日 10:17, Michael S. Tsirkin wrote: > > On Tue, Apr 17, 2018 at 10:11:58AM +0800, Jason Wang wrote: > > > > > > On 2018年04月13日 15:15, Tiwei Bie wrote: > > > > On Fri, Apr 13, 2018 at 12:30:24PM +0800, Jason Wang wrote:

[PATCH] samples/bpf: correct comment in sock_example.c

2018-04-16 Thread Wang Sheng-Hui
The program run against loopback interace "lo", not "eth0". Correct the comment. Signed-off-by: Wang Sheng-Hui --- samples/bpf/sock_example.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/bpf/sock_example.c b/samples/bpf/sock_example.c index 6fc6e193ef1b..33a637

Re: [RFC v2] virtio: support packed ring

2018-04-16 Thread Jason Wang
On 2018年04月17日 10:17, Michael S. Tsirkin wrote: On Tue, Apr 17, 2018 at 10:11:58AM +0800, Jason Wang wrote: On 2018年04月13日 15:15, Tiwei Bie wrote: On Fri, Apr 13, 2018 at 12:30:24PM +0800, Jason Wang wrote: On 2018年04月01日 22:12, Tiwei Bie wrote: Hello everyone, This RFC implements packed

Re: [RFC v2] virtio: support packed ring

2018-04-16 Thread Michael S. Tsirkin
On Tue, Apr 17, 2018 at 10:11:58AM +0800, Jason Wang wrote: > > > On 2018年04月13日 15:15, Tiwei Bie wrote: > > On Fri, Apr 13, 2018 at 12:30:24PM +0800, Jason Wang wrote: > > > On 2018年04月01日 22:12, Tiwei Bie wrote: > > > > Hello everyone, > > > > > > > > This RFC implements packed ring support fo

Re: [PATCH net,stable] tun: fix vlan packet truncation

2018-04-16 Thread Jason Wang
On 2018年04月17日 06:00, Bjørn Mork wrote: Bogus trimming in tun_net_xmit() causes truncated vlan packets. skb->len is correct whether or not skb_vlan_tag_present() is true. There is no more reason to adjust the skb length on xmit in this driver than any other driver. tun_put_user() adds 4 bytes

Re: [RFC v2] virtio: support packed ring

2018-04-16 Thread Jason Wang
On 2018年04月13日 15:15, Tiwei Bie wrote: On Fri, Apr 13, 2018 at 12:30:24PM +0800, Jason Wang wrote: On 2018年04月01日 22:12, Tiwei Bie wrote: Hello everyone, This RFC implements packed ring support for virtio driver. The code was tested with DPDK vhost (testpmd/vhost-PMD) implemented by Jens at

Re: SRIOV switchdev mode BoF minutes

2018-04-16 Thread Samudrala, Sridhar
On 4/16/2018 5:39 AM, Andy Gospodarek wrote: On Sun, Apr 15, 2018 at 09:01:16AM +0300, Or Gerlitz wrote: On Sat, Apr 14, 2018 at 2:03 AM, Samudrala, Sridhar wrote: I meant between PFs on 2 compute nodes. If the PF serves as uplink rep, it functions as a switch port -- applications don't ru

[PATCH v2 0/8] New network driver for Amiga X-Surf 100 (m68k)

2018-04-16 Thread Michael Schmitz
This patch series adds support for the Individual Computers X-Surf 100 network card for m68k Amiga, a network adapter based on the AX88796 chip set. The driver was originally written for kernel version 3.19 by Michael Karcher (see CC:), and adapted to 4.16 for submission to netdev by me. Questions

[PATCH v2 4/8] net: ax88796: Add block_input/output hooks to ax_plat_data

2018-04-16 Thread Michael Schmitz
Add platform specific hooks for block transfer reads/writes of packet buffer data, superseding the default provided ax_block_input/output. Currently used for m68k Amiga XSurf100. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c | 10 +++

[PATCH v2 2/8] net: ax88796: Attach MII bus only when open

2018-04-16 Thread Michael Schmitz
From: Michael Karcher Call ax_mii_init in ax_open(), and unregister/remove mdiobus resources in ax_close(). This is needed to be able to unload the module, as the module is busy while the MII bus is attached. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ether

[PATCH v2 7/8] net: ax88796: release platform device drvdata on probe error and module remove

2018-04-16 Thread Michael Schmitz
The net device struct pointer is stored as platform device drvdata on module probe - clear the drvdata entry on probe fail there, as well as when unloading the module. Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(

[PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-16 Thread Michael Schmitz
From: John Paul Adrian Glaubitz This complements the fix in 82533ad9a1c that removed the free_irq call in the error path of probe, to also not call free_irq when remove is called to revert the effects of probe. Signed-off-by: Michael Karcher --- drivers/net/ethernet/8390/ax88796.c |1 - 1

[PATCH v2 6/8] net: ax88796: set IRQF_SHARED flag when IRQ resource is marked as shareable

2018-04-16 Thread Michael Schmitz
From: John Paul Adrian Glaubitz On the Amiga X-Surf100, the network card interrupt is shared with many other interrupt sources, so requires the IRQF_SHARED flag to register. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |3 +++ 1 fil

[PATCH v2 5/8] net: ax88796: add interrupt status callback to platform data

2018-04-16 Thread Michael Schmitz
To be able to tell the ax88796 driver whether it is sensible to enter the 8390 interrupt handler, an "is this interrupt caused by the 88796" callback has been added to the ax_plat_data structure (with NULL being compatible to the previous behaviour). Signed-off-by: Michael Karcher Signed-off-by:

[PATCH v2 1/8] net: ax88796: Fix MAC address reading

2018-04-16 Thread Michael Schmitz
From: Michael Karcher To read the MAC address from the (virtual) SAprom, the remote DMA unit needs to be set up like for every other process access to card-local memory. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |6 ++ 1 file

[PATCH v2 8/8] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

2018-04-16 Thread Michael Schmitz
Add platform device driver to populate the ax88796 platform data from information provided by the XSurf100 zorro device driver. This driver will have to be loaded before loading the ax88796 module, or compiled as built-in. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- driver

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

2018-04-16 Thread Andrew Lunn
> > This should really be fixed in the PHY driver, not the MAC. > > OK - do you want this separate, or as part of this series? Might have > a few side effects on more commonly used hardware, perhaps? Hi Michael What PHY driver is used? In the driver you can implement a .soft_reset function which

RE: [next-queue PATCH] igb: Fix the transmission mode of queue 0 for Qav mode

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:28 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: Gomes, Vinicius ; Kirsher, Jeffrey T > ; netdev@vger.kernel.org; Sanchez-Palencia, > Jesus ; Guedes, Andre > > Subject: RE: [next-queue PATCH] igb: Fix the transm

RE: [next-queue PATCH v7 10/10] igb: Add support for adding offloaded clsflower filters

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:25 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: Gomes, Vinicius ; Kirsher, Jeffrey T > ; netdev@vger.kernel.org; Sanchez-Palencia, > Jesus > Subject: RE: [next-queue PATCH v7 10/10] igb: Add support for adding

RE: [Intel-wired-lan] [next-queue PATCH v7 09/10] igb: Add the skeletons for tc-flower offloading

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:23 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: netdev@vger.kernel.org; Sanchez-Palencia, Jesus palen...@intel.com> > Subject: RE: [Intel-wired-lan] [next-queue PATCH v7 09/10] igb: Add the > skeletons for tc-f

RE: [next-queue PATCH v7 08/10] igb: Add MAC address support for ethtool nftuple filters

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:23 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: Gomes, Vinicius ; Kirsher, Jeffrey T > ; netdev@vger.kernel.org; Sanchez-Palencia, > Jesus > Subject: RE: [next-queue PATCH v7 08/10] igb: Add MAC address support

RE: [next-queue PATCH v7 07/10] igb: Enable nfc filters to specify MAC addresses

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:22 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: Gomes, Vinicius ; Kirsher, Jeffrey T > ; netdev@vger.kernel.org; Sanchez-Palencia, > Jesus > Subject: RE: [next-queue PATCH v7 07/10] igb: Enable nfc filters to s

RE: [Intel-wired-lan] [next-queue PATCH v7 06/10] igb: Allow filters to be added for the local MAC address

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:20 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: netdev@vger.kernel.org; Sanchez-Palencia, Jesus palen...@intel.com> > Subject: RE: [Intel-wired-lan] [next-queue PATCH v7 06/10] igb: Allow filters > to be added

RE: [Intel-wired-lan] [next-queue PATCH v7 05/10] igb: Add support for enabling queue steering in filters

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:20 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: netdev@vger.kernel.org; Sanchez-Palencia, Jesus palen...@intel.com> > Subject: RE: [Intel-wired-lan] [next-queue PATCH v7 05/10] igb: Add support > for enabling q

RE: [Intel-wired-lan] [next-queue PATCH v7 03/10] igb: Enable the hardware traffic class feature bit for igb models

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:18 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: netdev@vger.kernel.org; Sanchez-Palencia, Jesus palen...@intel.com> > Subject: RE: [Intel-wired-lan] [next-queue PATCH v7 03/10] igb: Enable the > hardware traffi

RE: [next-queue PATCH v7 04/10] igb: Add support for MAC address filters specifying source addresses

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:19 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: Gomes, Vinicius ; Kirsher, Jeffrey T > ; netdev@vger.kernel.org; Sanchez-Palencia, > Jesus > Subject: RE: [next-queue PATCH v7 04/10] igb: Add support for MAC add

RE: [next-queue PATCH v7 01/10] igb: Fix not adding filter elements to the list

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:17 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: Gomes, Vinicius ; Kirsher, Jeffrey T > ; netdev@vger.kernel.org; Sanchez-Palencia, > Jesus > Subject: RE: [next-queue PATCH v7 01/10] igb: Fix not adding filter e

RE: [Intel-wired-lan] [next-queue PATCH v7 02/10] igb: Fix queue selection on MAC filters on i210

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:18 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: netdev@vger.kernel.org; Sanchez-Palencia, Jesus palen...@intel.com> > Subject: RE: [Intel-wired-lan] [next-queue PATCH v7 02/10] igb: Fix queue > selection on MAC

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

2018-04-16 Thread Michael Schmitz
Hi Andrew, On Tue, Apr 17, 2018 at 11:12 AM, Andrew Lunn wrote: > On Tue, Apr 17, 2018 at 10:04:43AM +1200, Michael Schmitz wrote: >> From: John Paul Adrian Glaubitz >> >> The AX88796B as installed on the X-Surf-100 does not recognize a MII reset >> request if the previous write to the MII contr

Re: [PATCH iproute2] utils: Do not reset family for default, any, all addresses

2018-04-16 Thread Stephen Hemminger
On Fri, 13 Apr 2018 09:36:33 -0700 David Ahern wrote: > Thomas reported a change in behavior with respect to autodectecting > address families. Specifically, 'ip ro add default via fe80::1' > syntax was failing to treat fe80::1 as an IPv6 address as it did in > prior releases. The root causes app

Re: [PATCH net-next 2/2] openvswitch: Support conntrack zone limit

2018-04-16 Thread Gregory Rose
On 4/16/2018 11:15 AM, Yi-Hung Wei wrote: Currently, nf_conntrack_max is used to limit the maximum number of conntrack entries in the conntrack table for every network namespace. For the VMs and containers that reside in the same namespace, they share the same conntrack table, and the total # of

Re: [iproute PATCH] iproute: Abort if nexthop cannot be parsed

2018-04-16 Thread Stephen Hemminger
On Wed, 11 Apr 2018 11:43:11 +0200 Jakub Sitnicki wrote: > Attempt to add a multipath route where a nexthop definition refers to a > non-existent device causes 'ip' to crash and burn due to stack buffer > overflow: > > # ip -6 route add fd00::1/64 nexthop dev fake1 > Cannot find device "fake

Re: [PATCH bpf-next 1/3] bpftool: Add missing prog types and attach types

2018-04-16 Thread Andrey Ignatov
Jakub Kicinski [Mon, 2018-04-16 16:53 -0700]: > On Mon, 16 Apr 2018 14:41:57 -0700, Andrey Ignatov wrote: > > diff --git a/tools/bpf/bpftool/cgroup.c b/tools/bpf/bpftool/cgroup.c > > index cae32a6..8689916 100644 > > --- a/tools/bpf/bpftool/cgroup.c > > +++ b/tools/bpf/bpftool/cgroup.c > > @@ -16,

Re: [PATCH 02/10] net: ax88796: Attach MII bus only when open

2018-04-16 Thread Michael Schmitz
Hi Andrew, thank you for reviewing this series! On Tue, Apr 17, 2018 at 10:59 AM, Andrew Lunn wrote: > On Tue, Apr 17, 2018 at 10:04:37AM +1200, Michael Schmitz wrote: >> From: Michael Karcher >> >> Call ax_mii_init in ax_open(), and unregister/remove mdiobus resources >> in ax_close(). >> >> T

Re: [PATCH net-next 1/2] openvswitch: Add conntrack limit netlink definition

2018-04-16 Thread Gregory Rose
On 4/16/2018 11:15 AM, Yi-Hung Wei wrote: Define netlink messages and attributes to support user kernel communication that using conntrack limit feature. s/using/uses the/ Signed-off-by: Yi-Hung Wei --- include/uapi/linux/openvswitch.h | 62 1 file

Re: [PATCH bpf-next 1/3] bpftool: Add missing prog types and attach types

2018-04-16 Thread Jakub Kicinski
On Mon, 16 Apr 2018 14:41:57 -0700, Andrey Ignatov wrote: > diff --git a/tools/bpf/bpftool/cgroup.c b/tools/bpf/bpftool/cgroup.c > index cae32a6..8689916 100644 > --- a/tools/bpf/bpftool/cgroup.c > +++ b/tools/bpf/bpftool/cgroup.c > @@ -16,15 +16,28 @@ > #define HELP_SPEC_ATTACH_FLAGS

Re: [PATCH 1/5] dt-bindings: allow dwmac-sun8i to use other devices' exported regmap

2018-04-16 Thread Icenowy Zheng
于 2018年4月17日 GMT+08:00 上午2:47:45, Rob Herring 写到: >On Wed, Apr 11, 2018 at 10:16:37PM +0800, Icenowy Zheng wrote: >> On some Allwinner SoCs the EMAC clock register needed by dwmac-sun8i >is >> in another device's memory space. In this situation dwmac-sun8i can >use >> a regmap exported by the ot

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

2018-04-16 Thread Andrew Lunn
On Tue, Apr 17, 2018 at 10:04:43AM +1200, Michael Schmitz wrote: > From: John Paul Adrian Glaubitz > > The AX88796B as installed on the X-Surf-100 does not recognize a MII reset > request if the previous write to the MII control register also was a reset > request. So a dummy write to the control

Re: [PATCH net-next] net: Remove unused tcp_set_state tracepoint

2018-04-16 Thread David Miller
From: Andrey Ignatov Date: Mon, 16 Apr 2018 15:07:13 -0700 > This tracepoint was replaced by inet_sock_set_state in 563e0bb and not > used anywhere in the kernel anymore. Remove it. > > Signed-off-by: Andrey Ignatov Applied, thank you.

Re: [PATCH 02/10] net: ax88796: Attach MII bus only when open

2018-04-16 Thread Andrew Lunn
On Tue, Apr 17, 2018 at 10:04:37AM +1200, Michael Schmitz wrote: > From: Michael Karcher > > Call ax_mii_init in ax_open(), and unregister/remove mdiobus resources > in ax_close(). > > This is needed to be able to unload the module, as the module is busy > while the MII bus is attached. > > Sig

Re: [PATCH net-next 3/5] ipv4: support sport, dport and ip protocol in RTM_GETROUTE

2018-04-16 Thread David Miller
From: Roopa Prabhu Date: Mon, 16 Apr 2018 13:41:36 -0700 > diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h > index 9b15005..7947252 100644 > --- a/include/uapi/linux/rtnetlink.h > +++ b/include/uapi/linux/rtnetlink.h > @@ -327,6 +327,9 @@ enum rtattr_type_t { >

Re: [PATCH net-next 0/2] PCI: add two more values for PCIe Max_Read_Request_Size and initially use them in r8169 network driver

2018-04-16 Thread David Miller
From: Heiner Kallweit Date: Mon, 16 Apr 2018 21:35:42 +0200 > In r8169 network driver I stumbled across a magic number translating > to PCI MRRS size 4K. The PCI core is still missing constants for > values 2K and 4K (as defined in PCI standard). > > So let's add these two constants and use the

Re: [PATCH] textsearch: fix kernel-doc warnings and add kernel-api section

2018-04-16 Thread David Miller
From: Randy Dunlap Date: Mon, 16 Apr 2018 12:32:55 -0700 > From: Randy Dunlap > > Make lib/textsearch.c usable as kernel-doc. > Add textsearch() function family to kernel-api documentation. > Fix kernel-doc warnings in : > ../include/linux/textsearch.h:65: warning: Incorrect use of kernel-doc

Re: [PATCH net-next 0/5] net: stmmac: Stop using hard-coded callbacks

2018-04-16 Thread David Miller
From: Jose Abreu Date: Mon, 16 Apr 2018 16:08:11 +0100 > This a starting point for a cleanup and re-organization of stmmac. > > In this series we stop using hard-coded callbacks along the code and use > instead helpers which are defined in a single place ("hwif.h"). > > This brings several adva

Re: [PATCH net-next 0/5] tcp: add zero copy receive

2018-04-16 Thread David Miller
From: Eric Dumazet Date: Mon, 16 Apr 2018 10:33:34 -0700 > This patch series add mmap() support to TCP sockets for RX zero copy. > > While tcp_mmap() patch itself is quite small (~100 LOC), optimal support > for asynchronous mmap() required better SO_RCVLOWAT behavior, and a > test program to de

Re: [PATCH net-next 1/1] tc-testing: add sample action tests

2018-04-16 Thread David Miller
From: Roman Mashak Date: Mon, 16 Apr 2018 12:06:04 -0400 > Signed-off-by: Roman Mashak Applied to net-next.

Re: [PATCH] ipv6: remove unnecessary check in addrconf_prefix_rcv_add_addr()

2018-04-16 Thread David Miller
From: Lorenzo Bianconi Date: Mon, 16 Apr 2018 17:52:59 +0200 > Remove unnecessary check on update_lft variable in > addrconf_prefix_rcv_add_addr routine since it is always set to 0. > Moreover remove update_lft re-initialization to 0 > > Signed-off-by: Lorenzo Bianconi Applied to net-next, tha

Re: [PATCH v2] net: ipv6: xfrm6_state: remove VLA usage

2018-04-16 Thread Stefano Brivio
Andreas, On Sat, 10 Mar 2018 09:40:44 +0200 Andreas Christoforou wrote: > The kernel would like to have all stack VLA usage removed[1]. > Instead of dynamic allocation, just use XFRM_MAX_DEPTH > as already done for the "class" array, but as per feedback, > I will not drop maxclass because that c

Re: [PATCH net 0/2] tipc: Better check user provided attributes

2018-04-16 Thread David Miller
From: Jon Maloy Date: Mon, 16 Apr 2018 19:21:44 + > Acked-by: Jon Maloy > > Thank you, Eric. Series applied and patch #1 queued up for -stable, thanks Eric.

[PATCH net-next] net: Remove unused tcp_set_state tracepoint

2018-04-16 Thread Andrey Ignatov
This tracepoint was replaced by inet_sock_set_state in 563e0bb and not used anywhere in the kernel anymore. Remove it. Signed-off-by: Andrey Ignatov --- include/trace/events/tcp.h | 47 -- 1 file changed, 47 deletions(-) diff --git a/include/trace/eve

[PATCH 07/10] net: ax88796: unregister mdiobus on ax_mii_init() fail

2018-04-16 Thread Michael Schmitz
From: Michael Schmitz Unregister and free up mdiobus resources if ax_mii_init() failed. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/8390

Re: [PATCH net-next 1/2] PCI: Add two more values for PCIe Max_Read_Request_Size

2018-04-16 Thread David Miller
From: Bjorn Helgaas Date: Mon, 16 Apr 2018 16:42:04 -0500 > On Mon, Apr 16, 2018 at 09:37:13PM +0200, Heiner Kallweit wrote: >> This patch adds missing values for the max read request size. >> E.g. network driver r8169 uses a value of 4K. >> >> Signed-off-by: Heiner Kallweit > > I'd prefer a s

[PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

2018-04-16 Thread Michael Schmitz
Add platform specific hooks for block transfer reads/writes of packet buffer data, superseding the default provided ax_block_input/output. Currently used for m68k Amiga XSurf100. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c | 10 +++

[PATCH 02/10] net: ax88796: Attach MII bus only when open

2018-04-16 Thread Michael Schmitz
From: Michael Karcher Call ax_mii_init in ax_open(), and unregister/remove mdiobus resources in ax_close(). This is needed to be able to unload the module, as the module is busy while the MII bus is attached. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ether

[PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

2018-04-16 Thread Michael Schmitz
From: John Paul Adrian Glaubitz The AX88796B as installed on the X-Surf-100 does not recognize a MII reset request if the previous write to the MII control register also was a reset request. So a dummy write to the control register makes the soft reset in the PHY initialization code work. Signed

[PATCH 06/10] net: ax88796: set IRQF_SHARED flag when IRQ resource is marked as shareable

2018-04-16 Thread Michael Schmitz
From: John Paul Adrian Glaubitz On the Amiga X-Surf100, the network card interrupt is shared with many other interrupt sources, so requires the IRQF_SHARED flag to register. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |3 +++ 1 fil

[PATCH 09/10] net: ax88796: release platform device drvdata on probe error and module remove

2018-04-16 Thread Michael Schmitz
The net device struct pointer is stored as platform device drvdata on module probe - clear the drvdata entry on probe fail there, as well as when unloading the module. Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(

[PATCH 05/10] net: ax88796: add interrupt status callback to platform data

2018-04-16 Thread Michael Schmitz
To be able to tell the ax88796 driver whether it is sensible to enter the 8390 interrupt handler, an "is this interrupt caused by the 88796" callback has been added to the ax_plat_data structure (with NULL being compatible to the previous behaviour). Signed-off-by: Michael Karcher Signed-off-by:

[PATCH 01/10] net: ax88796: Fix MAC address reading

2018-04-16 Thread Michael Schmitz
From: Michael Karcher To read the MAC address from the (virtual) SAprom, the remote DMA unit needs to be set up like for every other process access to card-local memory. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |6 ++ 1 file

[PATCH 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-16 Thread Michael Schmitz
This patch series adds support for the Individual Computers X-Surf 100 network card for m68k Amiga, a network adapter based on the AX88796 chip set. The driver was originally written for kernel version 3.19 by Michael Karcher (see CC:), and adapted to 4.16 for submission to netdev by me. Questions

[PATCH 03/10] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-16 Thread Michael Schmitz
From: John Paul Adrian Glaubitz This complements the fix in 82533ad9a1c that removed the free_irq call in the error path of probe, to also not call free_irq when remove is called to revert the effects of probe. Signed-off-by: Michael Karcher --- drivers/net/ethernet/8390/ax88796.c |1 - 1

[PATCH 10/10] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

2018-04-16 Thread Michael Schmitz
Add platform device driver to populate the ax88796 platform data from information provided by the XSurf100 zorro device driver. This driver will have to be loaded before loading the ax88796 module, or compiled as built-in. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- driver

[PATCH net,stable] tun: fix vlan packet truncation

2018-04-16 Thread Bjørn Mork
Bogus trimming in tun_net_xmit() causes truncated vlan packets. skb->len is correct whether or not skb_vlan_tag_present() is true. There is no more reason to adjust the skb length on xmit in this driver than any other driver. tun_put_user() adds 4 bytes to the total for tagged packets because it t

[PATCH bpf-next 3/3] libbpf: Type functions for raw tracepoints

2018-04-16 Thread Andrey Ignatov
Add missing pieces for BPF_PROG_TYPE_RAW_TRACEPOINT in libbpf: * is- and set- functions; * support guessing prog type. Signed-off-by: Andrey Ignatov --- tools/lib/bpf/libbpf.c | 2 ++ tools/lib/bpf/libbpf.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tools/lib/bpf/libbpf.c b/tools/lib

[PATCH bpf-next 1/3] bpftool: Add missing prog types and attach types

2018-04-16 Thread Andrey Ignatov
Add missing prog types to `bpftool prog` and missing attach types to `bpftool cgroup`. Signed-off-by: Andrey Ignatov --- tools/bpf/bpftool/cgroup.c | 19 --- tools/bpf/bpftool/prog.c | 3 +++ 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/tools/bpf/bpftool/cgr

[PATCH bpf-next 2/3] libbpf: Support guessing post_bind{4,6} progs

2018-04-16 Thread Andrey Ignatov
libbpf can guess prog type and expected attach type based on section name. Add hints for "cgroup/post_bind4" and "cgroup/post_bind6" section names. Existing "cgroup/sock" is not changed, i.e. expected_attach_type for it is not set to `BPF_CGROUP_INET_SOCK_CREATE`, for backward compatibility. Sign

[PATCH bpf-next 0/3] Add missing types to bpftool, libbpf

2018-04-16 Thread Andrey Ignatov
Add support for various BPF prog types and attach types that have been added to kernel recently but not to bpftool or libbpf yet. Andrey Ignatov (3): bpftool: Add missing prog types and attach types libbpf: Support guessing post_bind{4,6} progs libbpf: Type functions for raw tracepoints t

Re: [PATCH net-next 1/2] PCI: Add two more values for PCIe Max_Read_Request_Size

2018-04-16 Thread Bjorn Helgaas
On Mon, Apr 16, 2018 at 09:37:13PM +0200, Heiner Kallweit wrote: > This patch adds missing values for the max read request size. > E.g. network driver r8169 uses a value of 4K. > > Signed-off-by: Heiner Kallweit I'd prefer a subject line with more details, e.g., PCI: Add #defines for 2K and 4

[PATCH RESEND net-next v2] KEYS: DNS: limit the length of option strings

2018-04-16 Thread Eric Biggers
From: Eric Biggers Adding a dns_resolver key whose payload contains a very long option name resulted in that string being printed in full. This hit the WARN_ONCE() in set_precision() during the printk(), because printk() only supports a precision of up to 32767 bytes: precision 100 too

Re: [PATCH v2] KEYS: DNS: limit the length of option strings

2018-04-16 Thread Eric Biggers
On Mon, Apr 02, 2018 at 12:20:35PM -0700, Eric Biggers wrote: > On Fri, Mar 23, 2018 at 01:21:22PM -0700, Eric Biggers wrote: > > On Mon, Mar 12, 2018 at 10:57:07AM -0700, Eric Biggers wrote: > > > On Wed, Mar 07, 2018 at 03:54:37PM +, David Howells wrote: > > > > Eric Biggers wrote: > > > >

Proposal

2018-04-16 Thread MS Zeliha Omer Faruk
Hello Greeetings to you please did you get my previous email regarding my investment proposal last week friday ? MS.Zeliha ömer faruk zeliha.omer.fa...@gmail.com

Re: [PATCH net] net: Fix one possible memleak in ip_setup_cork

2018-04-16 Thread Eric Dumazet
On 04/16/2018 09:58 AM, David Miller wrote: > From: gfree.w...@vip.163.com > Date: Mon, 16 Apr 2018 10:16:45 +0800 > >> From: Gao Feng >> >> It would allocate memory in this function when the cork->opt is NULL. But >> the memory isn't freed if failed in the latter rt check, and return error >>

  1   2   3   >