Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-09-25 Thread Hannes Reinecke
Hi Tomo, FUJITA Tomonori wrote: > On Sat, 8 Sep 2007 13:00:36 +0100 > Christoph Hellwig <[EMAIL PROTECTED]> wrote: > >> On Sat, Sep 08, 2007 at 07:32:27AM -0400, Jeff Garzik wrote: >>> FUJITA Tomonori wrote: Yeah, iommu code ignores the lld limitations (the problem is that the lld limit

Re: [PATCH V6 5/9] net/bonding: Enable IP multicast for bonding IPoIB devices

2007-09-25 Thread Moni Shoua
> > Please get rid of the warning. Make bonding work correctly and allow > enslave/remove > of device when bonding is down. > - > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/maj

Re: [ofa-general] [PATCH V6 0/9] net/bonding: ADD IPoIB support for the bonding driver

2007-09-25 Thread Moni Shoua
Jay, I think that all comments to the patches were discussed and handled. If you agree, can you please push then to the networking tree so they will be merged into 2.6.24? This includes the IPoIB patches (agreed with Roland). Note that there are *no* patches to net/core (like in V5). thanks Moni

[PATCH 6/7] CAN: Add maintainer entries

2007-09-25 Thread Urs Thuermann
This patch adds entries in the CREDITS and MAINTAINERS file for CAN. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- CREDITS | 16 MAINTAINERS |9 + 2 files changed, 25 insertions(+) Index: net-2.6.24/CRE

[PATCH 0/7] CAN: Add new PF_CAN protocol family, try #8

2007-09-25 Thread Urs Thuermann
Hello Dave, hello Patrick, this is the eigth post of the patch series that adds the PF_CAN protocol family for the Controller Area Network. Since our last post we have changed the following: * Some changes in debug code, following suggestions from Joe Perches: - Remove dynamically allocated bu

[PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-25 Thread Urs Thuermann
This patch adds the virtual CAN bus (vcan) network driver. The vcan device is just a loopback device for CAN frames, no real CAN hardware is involved. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- drivers/net/Makefile |1 drivers

[PATCH 3/7] CAN: Add raw protocol

2007-09-25 Thread Urs Thuermann
This patch adds the CAN raw protocol. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/can/raw.h | 31 + net/can/Kconfig | 11 net/can/Makefile|3 net/can/raw.c | 822 +++

[PATCH 1/7] CAN: Allocate protocol numbers for PF_CAN

2007-09-25 Thread Urs Thuermann
This patch adds a protocol/address family number, ARP hardware type, ethernet packet type, and a line discipline number for the SocketCAN implementation. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/if_arp.h |1 + inc

[PATCH 4/7] CAN: Add broadcast manager (bcm) protocol

2007-09-25 Thread Urs Thuermann
This patch adds the CAN broadcast manager (bcm) protocol. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/can/bcm.h | 65 + net/can/Kconfig | 13 net/can/Makefile|3 net/can/bcm.c | 1778 +++

[PATCH 7/7] CAN: Add documentation

2007-09-25 Thread Urs Thuermann
This patch adds documentation for the PF_CAN protocol family. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- Documentation/networking/00-INDEX |2 Documentation/networking/can.txt | 634 ++ 2 file

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-25 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 25, 2007 at 02:20:31PM +0200, Urs Thuermann escreveu: > + > +static void can_sock_destruct(struct sock *sk) > +{ > + DBG("called for sock %p\n", sk); > + > + skb_queue_purge(&sk->sk_receive_queue); > + if (sk->sk_protinfo) > + kfree(sk->sk_protinfo); > +} Is it

Re: [PATCH 4/7] CAN: Add broadcast manager (bcm) protocol

2007-09-25 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 25, 2007 at 02:20:33PM +0200, Urs Thuermann escreveu: > This patch adds the CAN broadcast manager (bcm) protocol. > > +static void bcm_can_tx(struct bcm_op *op) > +{ > + skb = alloc_skb(CFSIZ, > + in_interrupt() ? GFP_ATOMIC : GFP_KERNEL); We have gfp_any() for

RE: [PATCH 1/4] [NET_SCHED] explict hold dev tx lock

2007-09-25 Thread jamal
On Mon, 2007-24-09 at 16:47 -0700, Waskiewicz Jr, Peter P wrote: > We should make sure we're symmetric with the locking on enqueue to > dequeue. If we use the single device queue lock on enqueue, then > dequeue will also need to check that lock in addition to the individual > queue lock. The det

Re: [PATCH 1/4] [NET_SCHED] explict hold dev tx lock

2007-09-25 Thread jamal
On Mon, 2007-24-09 at 17:14 -0700, Stephen Hemminger wrote: > Since we are redoing this, > is there any way to make the whole TX path > more lockless? The existing model seems to be more of a monitor than > a real locking model. What do you mean it is "more of a monitor"? On the challenge of m

Re: [PATCH] sb1250-mac: Driver model & phylib update

2007-09-25 Thread Ralf Baechle
On Fri, Sep 21, 2007 at 12:44:09PM -0700, Andrew Morton wrote: > > A driver model and phylib update. > > akpm:/usr/src/25> diffstat patches/git-net.patch | tail -n 1 > 1013 files changed, 187667 insertions(+), 23587 deletions(-) > > Sorry, but raising networking patches against Linus's crufty

Re: [PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-25 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Tue, 25 Sep 2007 14:20:34 +0200), Urs Thuermann <[EMAIL PROTECTED]> says: > Index: net-2.6.24/drivers/net/can/vcan.c > === > --- /dev/null 1970-01-01 00:00:00.0 + > +++ net-2.6.2

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-25 Thread Urs Thuermann
Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> writes: > > + skb_queue_purge(&sk->sk_receive_queue); > > + if (sk->sk_protinfo) > > + kfree(sk->sk_protinfo); > > +} > > Is it really needed to do this sk_protinfo check? Thanks for finding this. This is from 2.6.12 times or so. We ha

Re: [PATCH 4/7] CAN: Add broadcast manager (bcm) protocol

2007-09-25 Thread Urs Thuermann
Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> writes: > > + skb = alloc_skb(CFSIZ, > > + in_interrupt() ? GFP_ATOMIC : GFP_KERNEL); > > We have gfp_any() for this: Ah, ok. That looks better. Applied. urs - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-25 Thread Urs Thuermann
YOSHIFUJI Hideaki / È£ÑÀ <[EMAIL PROTECTED]> writes: > I'm not a lawyer, but the following lines: > > | + * Alternatively, provided that this notice is retained in full, this > ~~ > | + * software may be distributed under the terms

Re: [PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-25 Thread Patrick McHardy
Urs Thuermann wrote: > YOSHIFUJI Hideaki / È£ÑÀ <[EMAIL PROTECTED]> writes: > > >>I'm not a lawyer, but the following lines: >> >>| + * Alternatively, provided that this notice is retained in full, this >> ~~ >>| + * software may be

Re: [PATCH V6 0/9] net/bonding: ADD IPoIB support for the bonding driver

2007-09-25 Thread Jay Vosburgh
ACK patches 3 - 9. Roland, are you comfortable with the IB changes in patches 1 and 2? Jeff, when Roland acks patches 1 and 2, please apply all 9. -J --- -Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED] Moni Shoua <[EMAIL PROTECTED]> wrote: >This

Re: [PATCH 1/4] [NET_SCHED] explict hold dev tx lock

2007-09-25 Thread Stephen Hemminger
On Tue, 25 Sep 2007 09:15:38 -0400 jamal <[EMAIL PROTECTED]> wrote: > On Mon, 2007-24-09 at 17:14 -0700, Stephen Hemminger wrote: > > > Since we are redoing this, > > is there any way to make the whole TX path > > more lockless? The existing model seems to be more of a monitor than > > a real l

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-25 Thread Stephen Hemminger
On 25 Sep 2007 15:24:33 +0200 Urs Thuermann <[EMAIL PROTECTED]> wrote: > Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> writes: > > > > + skb_queue_purge(&sk->sk_receive_queue); > > > + if (sk->sk_protinfo) > > > + kfree(sk->sk_protinfo); > > > +} > > > > Is it really needed to do this sk_

Re: [PATCH: 2.6.13-15-SMP 3/3] network: concurrently runsoftirqnetwork code on SMP

2007-09-25 Thread john ye
Jamal, You pointed out a key point: it's NOT acceptable if massive packet re-ordering couldn¡¯t be avoided. I debugged function tcp_ofo_queue in net/ipv4/tcp_input.c & monitored out_of_order_queue, found that re-ordering becomes unacceptable with the softirq load grows. It's simple to avoid out

Re: [PATCH V6 0/9] net/bonding: ADD IPoIB support for the bonding driver

2007-09-25 Thread Roland Dreier
> Roland, are you comfortable with the IB changes in patches 1 and 2? Yes, they look fine to me. Feel free to apply, with Acked-by: Roland Dreier <[EMAIL PROTECTED]> - R. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] Mor

Re: [PATCH: 2.6.13-15-SMP 3/3] network: concurrently runsoftirqnetwork code on SMP

2007-09-25 Thread Stephen Hemminger
On Tue, 25 Sep 2007 23:36:25 +0800 "john ye" <[EMAIL PROTECTED]> wrote: > Jamal, > > You pointed out a key point: it's NOT acceptable if massive packet > re-ordering couldn¡¯t be avoided. > I debugged function tcp_ofo_queue in net/ipv4/tcp_input.c & monitored > out_of_order_queue, found that re

Re: [PATCH] Remove broken netfilter binary sysctls from bridging code

2007-09-25 Thread Stephen Hemminger
On Tue, 25 Sep 2007 06:07:24 +0200 Patrick McHardy <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > On Mon, 24 Sep 2007 18:55:38 +0200 > > Patrick McHardy <[EMAIL PROTECTED]> wrote: > > > >>Eric W. Biederman wrote: > >> > >>>A really good fix would be to remove the binary side and then t

Re: 2.6.23-rc8-mm1 - drivers/net/ibm_newemac/mal - broken

2007-09-25 Thread Andrew Morton
On Tue, 25 Sep 2007 18:23:58 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > Hi Andrew, > > The drivers/net/ibm_newemac/mal seems to be broken, which stop with > build error (please cc netdev@vger.kernel.org on networking things) > CC drivers/net/ibm_newemac/mal.o > drivers/net/ibm_new

Re: [PATCH] sb1250-mac: Driver model & phylib update

2007-09-25 Thread Andrew Morton
On Tue, 25 Sep 2007 14:18:17 +0100 Ralf Baechle <[EMAIL PROTECTED]> wrote: > On Fri, Sep 21, 2007 at 12:44:09PM -0700, Andrew Morton wrote: > > > > A driver model and phylib update. > > > > akpm:/usr/src/25> diffstat patches/git-net.patch | tail -n 1 > > 1013 files changed, 187667 insertions(+

Re: [PATCH] Remove broken netfilter binary sysctls from bridging code

2007-09-25 Thread Patrick McHardy
Stephen Hemminger wrote: On Tue, 25 Sep 2007 06:07:24 +0200 Patrick McHardy <[EMAIL PROTECTED]> wrote: I meant removing brnf_sysctl_call_tables function, not the sysctls themselves, all it does is change values != 0 to 1. Or did you actually mean that something in userspace might depend on r

Re: [PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-25 Thread Oliver Hartkopp
Patrick McHardy wrote: > Urs Thuermann wrote: > >> YOSHIFUJI Hideaki / È£ÑÀ <[EMAIL PROTECTED]> writes: >> >> >> >>> I'm not a lawyer, but the following lines: >>> >>> | + * Alternatively, provided that this notice is retained in full, this >>> ~

Userspace network stack and netchannels.

2007-09-25 Thread Evgeniy Polyakov
Hi. I've released new version of the extremely small userspace netowork stack [1] implementation. Stack supports TCP and UDP over IP. It works on top of netchannels [2] or packet socket (returned back in this release). Supported features: * TCP/UDP sending and receiving. * Times

Re: [PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-25 Thread Patrick McHardy
Oliver Hartkopp wrote: I do think you need to allow people to select GPLv2 only. >>> > The Linux Kernel is currently under GPLv2 and we just wanted to follow > Linus' mind and so we referenced the COPYING file which many other > source does as well. Indeed it was a hard thing to make

Re: [PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-25 Thread Oliver Hartkopp
Patrick McHardy wrote: > > Yoshifuji's point was that the license seems to contradict itself, > it says you may choose GPL, but have to retain BSD. And that is > not about Dual BSD/GPL but about the specific wording. > Got it (finally)! Trying to specify the GPL Version (and the reference to t

Re: Userspace network stack and netchannels.

2007-09-25 Thread Robert Iakobashvili
Evgeniy, On 9/25/07, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > I've released new version of the extremely small > userspace netowork stack [1] implementation. > > 1. Userspace network stack. > http://tservice.net.ru/~s0mbre/old/?section=projects&item=unetstack > > 2. Netchannel subsystem. >

Re: Userspace network stack and netchannels.

2007-09-25 Thread Stephen Hemminger
On Tue, 25 Sep 2007 22:00:48 +0400 Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > Hi. > > I've released new version of the extremely small > userspace netowork stack [1] implementation. > Stack supports TCP and UDP over IP. > It works on top of netchannels [2] or packet socket > (returned back i

[git patches] additional net driver fixes

2007-09-25 Thread Jeff Garzik
These two wireless fixes are IN ADDITION to the previously submitted fixes. Same linear history. In other words, if you pull "upstream-linus", you will get both the changes below, _and_ the changes I submitted yesterday. If you have already pulled yesterday's fixes, then you will only receive t

Re: [DOC] Net batching driver howto

2007-09-25 Thread Randy Dunlap
On Mon, 24 Sep 2007 18:54:19 -0400 jamal wrote: > I have updated the driver howto to match the patches i posted yesterday. > attached. Thanks for sending this. This is an early draft, right? I'll fix some typos etc. in it (patch attached) and add some whitespace. Please see RD: in the patch fo

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-25 Thread Urs Thuermann
Stephen Hemminger <[EMAIL PROTECTED]> writes: > Then please make all exported symbols marked EXPORT_SYMBOL_GPL to make > sure that the other CAN protocol can not reuse your infrastructure. We don't want to force other CAN protocol implementations to be GPL also. AFAIR from discussions on LKML, i

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-25 Thread Stephen Hemminger
On 25 Sep 2007 23:00:15 +0200 Urs Thuermann <[EMAIL PROTECTED]> wrote: > Stephen Hemminger <[EMAIL PROTECTED]> writes: > > > Then please make all exported symbols marked EXPORT_SYMBOL_GPL to > > make sure that the other CAN protocol can not reuse your > > infrastructure. > > We don't want to for

my plans...

2007-09-25 Thread David Miller
I just got back from some travelling this past weekend, so what I'm going to do today is: 1) Rebase net-2.6.24, that's what I'm doing right now. I'll be combining bug fixes for feature patches as much as possible, so this might take most if not all of this afternoon. 2) After the rebase

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-25 Thread David Miller
From: Urs Thuermann <[EMAIL PROTECTED]> Date: 25 Sep 2007 23:00:15 +0200 > Stephen Hemminger <[EMAIL PROTECTED]> writes: > > > Then please make all exported symbols marked EXPORT_SYMBOL_GPL to make > > sure that the other CAN protocol can not reuse your infrastructure. > > We don't want to force

Re: [PATCH 1/4] [NET_SCHED] explict hold dev tx lock

2007-09-25 Thread jamal
On Tue, 2007-25-09 at 08:24 -0700, Stephen Hemminger wrote: > The transmit code path is locked as a code region, rather than just object > locking > on the transmit queue or other fine grained object. This leads to moderately > long > lock hold times when multiple qdisc's and classification is b

Re: [PATCH: 2.6.13-15-SMP 3/3] network: concurrently runsoftirqnetwork code on SMP

2007-09-25 Thread jamal
On Tue, 2007-25-09 at 09:03 -0700, Stephen Hemminger wrote: > There is a standard hash called RSS, that many drivers support because it is > used by other operating systems. I think any stateless/simple thing will do (something along the lines what 802.1ad does for trunk, a 5 classical five tupl

Re: [DOC] Net batching driver howto

2007-09-25 Thread jamal
On Tue, 2007-25-09 at 13:16 -0700, Randy Dunlap wrote: > On Mon, 24 Sep 2007 18:54:19 -0400 jamal wrote: > > > I have updated the driver howto to match the patches i posted yesterday. > > attached. > > Thanks for sending this. Thank you for reading it Randy. > This is an early draft, right?

Re: [PATCH 1/4] [NET_SCHED] explict hold dev tx lock

2007-09-25 Thread jamal
On Tue, 2007-25-09 at 18:15 -0400, jamal wrote: > A further optimization i made was to reduce the time it takes to hold > the tx lock at the driver by moving gunk that doesnt need lock-holding > into the new method dev->hard_end_xmit() (refer to patch #2) Sorry, that should have read dev->hard_pr

[PATCH] mv643xx_eth: duplicate methods in initializer

2007-09-25 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/net/mv643xx_eth.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c index 6a117e9..456d1e1 100644 --- a/drivers/net/mv643xx_eth.c +++ b/drivers/net/mv643xx_eth.c @@

Re: [net-2.6.24][patch 2/2] Dynamically allocate the loopback device

2007-09-25 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Mon, 17 Sep 2007 20:44:14 -0600 > David Miller <[EMAIL PROTECTED]> writes: > > > From: "Peter Waskiewicz" <[EMAIL PROTECTED]> > > Date: Mon, 17 Sep 2007 12:12:24 -0700 > > > >> This would be a good opportunity to remove the single-allocated queue

Re: [PATCH 0/3] move hardware header functions out of netdevice

2007-09-25 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Fri, 24 Aug 2007 13:43:10 -0700 > The follow patches series starts the process of moving function > pointers out of network device structure. This saves space and > separates code from data. > > The first step is moving the functions dealing with

Re: [RFC][NET_SCHED] explict hold dev tx lock

2007-09-25 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 22:43:03 -0400 > [NET_SCHED] explict hold dev tx lock > > For N cpus, with full throttle traffic on all N CPUs, funneling traffic > to the same ethernet device, the devices queue lock is contended by all > N CPUs constantly. The TX lock is on

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-25 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Wed, 19 Sep 2007 23:53:31 -0700 > In the same vein as print_mac, the implementations > introduce declaration macros: I'm going to hold on this for now, there is no universal agreement that this is something we want to do and I'd like to take care of get

Re: [PATCH: 2.6.13-15-SMP 3/3] network: concurrentlyrunsoftirqnetwork code on SMP

2007-09-25 Thread John Ye
Jamal & Stephen, I found BSS-hash paper you mentioned and have browsed it briefly. The issue "may end sending all your packets to one cpu" might be dealt with by cpu hash (srcip + dstip) % nr_cpus, plus checking cpu balance periodically, shift cpu by an extra seed value? Any way, the cpu hash cod

Re: [patch 1/1] revert "8139too: clean up I/O remapping"

2007-09-25 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 16:58:43 -0400 > [EMAIL PROTECTED] wrote: > > From: Andrew Morton <[EMAIL PROTECTED]> > > > > Revert git-netdev-all's 9ee6b32a47b9abc565466a9c3b127a5246b452e5. Michal > > was > > getting oopses. > > > > Cc: Michal Piotrowski <[EMAIL

Re: Please pull 'iwlwifi' branch of wireless-2.6

2007-09-25 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 21:34:03 -0400 > On Fri, Sep 21, 2007 at 09:20:30AM +0800, Zhu Yi wrote: > > On Wed, 2007-09-19 at 11:13 +0100, Christoph Hellwig wrote: > > > it really needs to be moved into a directory of it's own. > > > > It used to be... Joh

Re: [PATCH] note that NETIF_F_LLTX is deprecated

2007-09-25 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sat, 22 Sep 2007 08:57:10 +0800 > On Fri, Sep 21, 2007 at 04:59:54PM +0200, Christian Borntraeger wrote: > > > > I suggest to document that LLTX is deprecated. > > > > Signed-off-by: Christian Borntraeger <[EMAIL PROTECTED]> > > This looks good to me.

Re: Please pull 'fixes-davem' branch of wireless-2.6 (for 2.6.23)

2007-09-25 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Sat, 22 Sep 2007 11:41:42 -0400 > These are a few more minor fixes that I would like to have in 2.6.23 if > at all possible. I've pulled these into my net-2.6 tree and will push to Linus, thanks! - To unsubscribe from this list: send the line "un

Re: [RFC] Zero-length write() does not generate a datagram on connected socket

2007-09-25 Thread Herbert Xu
Stephen Hemminger <[EMAIL PROTECTED]> wrote: > The bug http://bugzilla.kernel.org/show_bug.cgi?id=5731 > describes an issue where write() can't be used to generate a zero-length > datagram (but send, and sendto do work). > > I think the following is needed: > > --- a/net/socket.c 2007-08-20

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-25 Thread Joe Perches
On Tue, 2007-09-25 at 19:29 -0700, David Miller wrote: > I'm going to hold on this for now, there is no universal > agreement that this is something we want to do and I'd > like to take care of getting the more certain stuff into > net-2.6.24 before "iffy" bits like this one. Here's an argument fo

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-25 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Tue, 25 Sep 2007 21:36:38 -0700 > On Tue, 2007-09-25 at 19:29 -0700, David Miller wrote: > > I'm going to hold on this for now, there is no universal > > agreement that this is something we want to do and I'd > > like to take care of getting the more cer

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-25 Thread Jeff Garzik
David Miller wrote: From: Joe Perches <[EMAIL PROTECTED]> Date: Tue, 25 Sep 2007 21:36:38 -0700 On Tue, 2007-09-25 at 19:29 -0700, David Miller wrote: I'm going to hold on this for now, there is no universal agreement that this is something we want to do and I'd like to take care of getting th

Re: [RFC] Zero-length write() does not generate a datagram on connected socket

2007-09-25 Thread Stephen Hemminger
On Wed, 26 Sep 2007 11:18:39 +0800 Herbert Xu <[EMAIL PROTECTED]> wrote: > Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > The bug http://bugzilla.kernel.org/show_bug.cgi?id=5731 > > describes an issue where write() can't be used to generate a zero-length > > datagram (but send, and sendto do wor

Re: Please pull 'upstream-davem' branch of wireless-2.6 (for 2.6.24)

2007-09-25 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Sat, 22 Sep 2007 15:54:57 -0400 > The individual patches are available here: > > > http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/upstream-davem/ I sucked these into my net-2.6.24 tree, thanks John. It may look sligh

Re: [PATCH 1/3] [TCP]: Re-place highest_sack check to a more robust position

2007-09-25 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 24 Sep 2007 12:04:06 +0300 > I previously added checking to position that is rather poor as > state has already been adjusted quite a bit. Re-placing it above > all state changes should be more robust though the return should > never ever get ex

Re: [RFC PATCH 2/3] [TCP]: Reordered ACK's (old) SACKs not included to discarded MIB

2007-09-25 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 24 Sep 2007 12:04:07 +0300 > In case of ACK reordering, the SACK block might be valid in it's > time but is already obsoleted since we've received another kind > of confirmation about arrival of the segments through snd_una > advancement of an e

Re: [RFC PATCH 3/3] [TCP] MIB: Count FRTO's successfully detected spurious RTOs

2007-09-25 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 24 Sep 2007 12:04:08 +0300 > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> This also looks fine, applied, thanks! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordom

Re: [SCTP PULL Request]: Bug fixes for 2.6.23

2007-09-25 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Mon, 24 Sep 2007 16:59:25 -0400 > Can you please pull the following changes since commit > a41d3015c11a4e864b95cb57f579f2d8f40cd41b: I had to apply this by hand because: > David S. Miller (1): > Revert "PCI: disable MSI by default on syste

net-2.6.24 rebased...

2007-09-25 Thread David Miller
Ok the rebase is complete and I integrated all of the "easy" stuff in my backlog. In the usual spot: kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git John, one patch didn't go in cleanly after I removed the Z1211 driver. I put it here for your consideration so it doesn't get lost

[patch 33/43] lguest: Net driver using virtio

2007-09-25 Thread rusty
The network driver uses two virtqueues: one for input packets and one for output packets. This has nice locking properties (ie. we don't do any for recv vs send). TODO: 1) Big packets. 2) Multi-client devices (maybe separate driver?). 3) Resolve freeing of old xmit skbs (C