Re: linux-next: manual merge of the akpm-current tree with the bpf-next tree

2020-12-14 Thread Andrew Morton
On Mon, 14 Dec 2020 17:29:43 -0800 Roman Gushchin wrote: > On Tue, Dec 15, 2020 at 07:21:56AM +1100, Stephen Rothwell wrote: > > Hi all, > > > > On Fri, 4 Dec 2020 20:20:05 +1100 Stephen Rothwell > > wrote: > > > > > > Today's linux-next merge of the akpm-current tree got conflicts in: > > >

Re: linux-next: manual merge of the akpm-current tree with the bpf-next tree

2020-12-14 Thread Andrew Morton
On Mon, 14 Dec 2020 18:06:29 -0800 Jakub Kicinski wrote: > On Mon, 14 Dec 2020 17:40:21 -0800 Andrew Morton wrote: > > On Mon, 14 Dec 2020 17:29:43 -0800 Roman Gushchin wrote: > > > On Tue, Dec 15, 2020 at 07:21:56AM +1100, Stephen Rothwell wrote: > > > > On

Re: [PATCH v3 1/1] page_frag: Recover from memory pressure

2020-11-18 Thread Andrew Morton
On Wed, 18 Nov 2020 11:46:54 -0800 Jakub Kicinski wrote: > > 1. The kernel is under memory pressure and allocation of > > PAGE_FRAG_CACHE_MAX_ORDER in __page_frag_cache_refill() will fail. Instead, > > the pfmemalloc page is allocated for page_frag_cache->va. > > > > 2: All skb->data from page_f

Re: [PATCH bpf-next v5 01/34] mm: memcontrol: use helpers to read page's memcg data

2020-11-12 Thread Andrew Morton
On Thu, 12 Nov 2020 19:04:56 -0800 Alexei Starovoitov wrote: > On Thu, Nov 12, 2020 at 04:26:10PM -0800, Roman Gushchin wrote: > > > > These patches are not intended to be merged through the bpf tree. > > They are included into the patchset to make bpf selftests pass and for > > informational p

Re: [PATCH bpf-next v5 01/34] mm: memcontrol: use helpers to read page's memcg data

2020-11-12 Thread Andrew Morton
On Thu, 12 Nov 2020 19:25:48 -0800 Alexei Starovoitov wrote: > On Thu, Nov 12, 2020 at 7:18 PM Andrew Morton > wrote: > > > > On Thu, 12 Nov 2020 19:04:56 -0800 Alexei Starovoitov > > wrote: > > > > > On Thu, Nov 12, 2020 at 04:26:10PM -0800, Roma

Re: [PATCH] compiler-clang: remove version check for BPF Tracing

2020-11-04 Thread Andrew Morton
On Wed, 4 Nov 2020 11:10:51 -0800 Nick Desaulniers wrote: > bpftrace parses the kernel headers and uses Clang under the hood. Remove > the version check when __BPF_TRACING__ is defined (as bpftrace does) so > that this tool can continue to parse kernel headers, even with older > clang sources.

Re: [PATCH V2 1/1] mm:improve the performance during fork

2021-03-30 Thread Andrew Morton
On Mon, 29 Mar 2021 20:36:35 +0800 qianjun.ker...@gmail.com wrote: > From: jun qian > > In our project, Many business delays come from fork, so > we started looking for the reason why fork is time-consuming. > I used the ftrace with function_graph to trace the fork, found > that the vm_normal_pa

Re: [PATCH] lib: remove "expecting prototype" kernel-doc warnings

2021-04-13 Thread Andrew Morton
On Sun, 11 Apr 2021 15:17:56 -0700 Randy Dunlap wrote: > Fix various kernel-doc warnings in lib/ due to missing or > erroneous function names. > Add kernel-doc for some function parameters that was missing. > Use kernel-doc "Return:" notation in earlycpio.c. > > Quietens the following warnings:

Re: [PATCH 2/5] mm/page_alloc: Add a bulk page allocator

2021-03-10 Thread Andrew Morton
On Wed, 10 Mar 2021 10:46:15 + Mel Gorman wrote: > This patch adds a new page allocator interface via alloc_pages_bulk, > and __alloc_pages_bulk_nodemask. A caller requests a number of pages > to be allocated and added to a list. They can be freed in bulk using > free_pages_bulk(). Why am I

Re: [PATCH 0/5] Introduce a bulk order-0 page allocator with two in-tree users

2021-03-10 Thread Andrew Morton
On Wed, 10 Mar 2021 10:46:13 + Mel Gorman wrote: > This series introduces a bulk order-0 page allocator with sunrpc and > the network page pool being the first users. Right now, the [0/n] doesn't even tell us that it's a performance patchset! The whole point of this patchset appears to a

Re: [PATCH 0/3] Fix some seq_file users that were recently broken

2021-02-05 Thread Andrew Morton
On Fri, 05 Feb 2021 11:36:30 +1100 NeilBrown wrote: > A recent change to seq_file broke some users which were using seq_file > in a non-"standard" way ... though the "standard" isn't documented, so > they can be excused. The result is a possible leak - of memory in one > case, of references to

Re: [PATCH 0/3] Fix some seq_file users that were recently broken

2021-02-07 Thread Andrew Morton
On Sat, 6 Feb 2021 14:29:24 -0800 Jakub Kicinski wrote: > On Fri, 5 Feb 2021 14:35:50 -0800 Andrew Morton wrote: > > On Fri, 05 Feb 2021 11:36:30 +1100 NeilBrown wrote: > > > > > A recent change to seq_file broke some users which were using seq_file > > > in

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-17 Thread Andrew Morton
On Mon, 15 Mar 2021 18:30:03 -0700 Arjun Roy wrote: > From: Arjun Roy > > TCP zerocopy receive is used by high performance network applications > to further scale. For RX zerocopy, the memory containing the network > data filled by the network driver is directly mapped into the address > space

Re: [PATCH v2 1/2] mm: add GFP mask param to strndup_user

2020-08-21 Thread Andrew Morton
On Fri, 21 Aug 2020 20:28:26 -0700 Pascal Bouchareine wrote: > Let caller specify allocation. > Preserve existing calls with GFP_USER. > > 21 files changed, 65 insertions(+), 43 deletions(-) Why change all existing callsites so that one callsite can pass in a different gfp_t? > diff --git a/d

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-05-01 Thread Andrew Morton
On Tue, 24 Apr 2018 12:33:01 -0400 (EDT) Mikulas Patocka wrote: > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > On Tue 24-04-18 11:30:40, Mikulas Patocka wrote: > > > > > > > > > On Tue, 24 Apr 2018, Michal Hocko wrote: > > > > > > > On Mon 23-04-18 20:25:15, Mikulas Patocka wrote: >

Re: [lkp-robot] 486ad79630 [ 15.532543] BUG: unable to handle kernel NULL pointer dereference at 0000000000000004

2018-05-02 Thread Andrew Morton
b9fe15ba392f5ee32 > Author: Andrew Morton > AuthorDate: Fri Apr 20 22:00:53 2018 + > Commit: Johannes Weiner > CommitDate: Fri Apr 20 22:00:53 2018 + > > origin OK, this got confusing. origin.patch is the diff between 4.17-rc3 and current mainline. > >

Re: [lkp-robot] 486ad79630 [ 15.532543] BUG: unable to handle kernel NULL pointer dereference at 0000000000000004

2018-05-02 Thread Andrew Morton
On Wed, 2 May 2018 21:58:25 -0700 Cong Wang wrote: > On Wed, May 2, 2018 at 9:27 PM, Andrew Morton > wrote: > > > > So it's saying that something which got committed into Linus's tree > > after 4.17-rc3 has caused a NULL deref in > > sock_release->l

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-04-19 Thread Andrew Morton
On Thu, 19 Apr 2018 12:12:38 -0400 (EDT) Mikulas Patocka wrote: > The kvmalloc function tries to use kmalloc and falls back to vmalloc if > kmalloc fails. > > Unfortunatelly, some kernel code has bugs - it uses kvmalloc and then > uses DMA-API on the returned memory or frees it with kfree. Such

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-04-19 Thread Andrew Morton
On Thu, 19 Apr 2018 17:19:20 -0400 (EDT) Mikulas Patocka wrote: > > > In order to detect these bugs reliably I submit this patch that changes > > > kvmalloc to always use vmalloc if CONFIG_DEBUG_VM is turned on. > > > > > > ... > > > > > > --- linux-2.6.orig/mm/util.c 2018-04-18 15:46:23.0

Re: simplify procfs code for seq_file instances

2018-04-24 Thread Andrew Morton
On Tue, 24 Apr 2018 16:23:04 +0200 Christoph Hellwig wrote: > On Thu, Apr 19, 2018 at 09:57:50PM +0300, Alexey Dobriyan wrote: > > > git://git.infradead.org/users/hch/misc.git proc_create > > > > > > I want to ask if it is time to start using poorman function overloading > > with _b_c_e().

Re: [PATCH] bpfilter: fix user mode helper cross compilation

2018-06-27 Thread Andrew Morton
On Wed, 20 Jun 2018 16:04:34 +0200 Matteo Croce wrote: > Use $(OBJDUMP) instead of literal 'objdump' to avoid > using host toolchain when cross compiling. > I'm still having issues here, with ld. x86_64 machine, ARCH=i386: y:/usr/src/25> make V=1 M=net/bpfilter test -e include/generated/autoc

Re: [PATCH 0/3] Remove accidental VLA usage

2018-03-08 Thread Andrew Morton
On Thu, 8 Mar 2018 09:02:36 -0600 Josh Poimboeuf wrote: > On Wed, Mar 07, 2018 at 07:30:44PM -0800, Kees Cook wrote: > > This series adds SIMPLE_MAX() to be used in places where a stack array > > is actually fixed, but the compiler still warns about VLA usage due to > > confusion caused by the sa

Re: [PATCH] kernel.h: Skip single-eval logic on literals in min()/max()

2018-03-08 Thread Andrew Morton
On Thu, 8 Mar 2018 13:40:45 -0800 Kees Cook wrote: > When max() is used in stack array size calculations from literal values > (e.g. "char foo[max(sizeof(struct1), sizeof(struct2))]", the compiler > thinks this is a dynamic calculation due to the single-eval logic, which > is not needed in the li

Re: [PATCH] net/9p: avoid -ERESTARTSYS leak to userspace

2018-03-09 Thread Andrew Morton
On Fri, 09 Mar 2018 21:41:38 +0100 Greg Kurz wrote: > If it was interrupted by a signal, the 9p client may need to send some > more requests to the server for cleanup before returning to userspace. > > To avoid such a last minute request to be interrupted right away, the > client memorizes if a

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

2018-03-09 Thread Andrew Morton
On Fri, 9 Mar 2018 12:05:36 -0800 Kees Cook wrote: > When max() is used in stack array size calculations from literal values > (e.g. "char foo[max(sizeof(struct1), sizeof(struct2))]", the compiler > thinks this is a dynamic calculation due to the single-eval logic, which > is not needed in the li

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

2018-03-09 Thread Andrew Morton
On Fri, 9 Mar 2018 16:28:51 -0800 Linus Torvalds wrote: > On Fri, Mar 9, 2018 at 4:07 PM, Andrew Morton > wrote: > > > > A brief poke failed to reveal a workaround - gcc-4.4.4 doesn't appear > > to know that __builtin_constant_p(x) is a constant. Or something

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

2018-03-12 Thread Andrew Morton
On Fri, 9 Mar 2018 17:30:15 -0800 Kees Cook wrote: > > It's one reason why I wondered if simplifying the expression to have > > just that single __builtin_constant_p() might not end up working.. > > Yeah, it seems like it doesn't bail out as "false" for complex > expressions given to __builtin_c

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

2018-03-13 Thread Andrew Morton
On Mon, 12 Mar 2018 21:28:57 -0700 Kees Cook wrote: > On Mon, Mar 12, 2018 at 4:57 PM, Linus Torvalds > wrote: > > On Mon, Mar 12, 2018 at 3:55 PM, Andrew Morton > > wrote: > >> > >> Replacing the __builtin_choose_expr() with ?: works of course. > > &g

Re: [PATCH] mm: Replace all open encodings for NUMA_NO_NODE

2018-11-23 Thread Andrew Morton
On Fri, 23 Nov 2018 15:24:16 +0530 Anshuman Khandual wrote: > At present there are multiple places where invalid node number is encoded > as -1. Even though implicitly understood it is always better to have macros > in there. Replace these open encodings for an invalid node number with the > glo

Re: rfc: bool structure members (was Re: [PATCH V3] net/mlx4: Get rid of page operation after dma_alloc_coherent)

2018-12-20 Thread Andrew Morton
On Thu, 20 Dec 2018 18:25:05 -0800 Joe Perches wrote: > On Thu, 2018-12-20 at 09:49 -0800, Bart Van Assche wrote: > > On Thu, 2018-12-20 at 18:44 +0100, Christoph Hellwig wrote: > > > On Thu, Dec 20, 2018 at 10:43:18AM -0700, Jason Gunthorpe wrote: > > > > > - chunk->coherent is an int not a bo

Re: [PATCH 2/2] x86/modules: Make x86 allocs to flush when free

2018-11-28 Thread Andrew Morton
On Tue, 27 Nov 2018 16:07:54 -0800 Rick Edgecombe wrote: > Change the module allocations to flush before freeing the pages. > > ... > > --- a/arch/x86/kernel/module.c > +++ b/arch/x86/kernel/module.c > @@ -87,8 +87,8 @@ void *module_alloc(unsigned long size) > p = __vmalloc_node_range(siz

Re: [net-next PATCH 1/2] mm: add dma_addr_t to struct page

2019-02-11 Thread Andrew Morton
uires a 64-bit value even on * 32-bit architectures. */ Otherwise, Acked-by: Andrew Morton

Re: [PATCH] mm: page_alloc: fix ref bias in page_frag_alloc() for 1-byte allocs

2019-02-13 Thread Andrew Morton
On Wed, 13 Feb 2019 21:41:57 +0100 Jann Horn wrote: > The basic idea behind ->pagecnt_bias is: If we pre-allocate the maximum > number of references that we might need to create in the fastpath later, > the bump-allocation fastpath only has to modify the non-atomic bias value > that tracks the nu

Re: [PATCH] mm: page_alloc: fix ref bias in page_frag_alloc() for 1-byte allocs

2019-02-13 Thread Andrew Morton
On Wed, 13 Feb 2019 22:11:58 +0100 Jann Horn wrote: > > This is probably more a davem patch than a -mm one. > > Ah, sorry. I assumed that I just should go by which directory the > patched code is in. > > You did just add it to the -mm tree though, right? So I shouldn't > resend it to davem? Ye

Re: [PATCH V11 0/5] hash addresses printed with %p

2017-11-29 Thread Andrew Morton
On Wed, 29 Nov 2017 13:05:00 +1100 "Tobin C. Harding" wrote: > Currently there exist approximately 14 000 places in the Kernel where > addresses are being printed using an unadorned %p. This potentially > leaks sensitive information regarding the Kernel layout in memory. Many > of these calls are

Re: [PATCH V11 3/5] printk: hash addresses printed with %p

2017-11-29 Thread Andrew Morton
On Wed, 29 Nov 2017 13:05:03 +1100 "Tobin C. Harding" wrote: > Currently there exist approximately 14 000 places in the kernel where > addresses are being printed using an unadorned %p. This potentially > leaks sensitive information regarding the Kernel layout in memory. Many > of these calls are

Re: [PATCH V11 4/5] vsprintf: add printk specifier %px

2017-11-29 Thread Andrew Morton
On Wed, 29 Nov 2017 13:05:04 +1100 "Tobin C. Harding" wrote: > printk specifier %p now hashes all addresses before printing. Sometimes > we need to see the actual unmodified address. This can be achieved using > %lx but then we face the risk that if in future we want to change the > way the Kerne

Re: clean up and streamline probe_kernel_* and friends v4

2020-05-27 Thread Andrew Morton
On Tue, 26 May 2020 08:13:09 +0200 Christoph Hellwig wrote: > On Mon, May 25, 2020 at 03:19:12PM -0700, Andrew Morton wrote: > > hm. Applying linux-next to this series generates a lot of rejects against > > powerpc: > > > > -rw-rw-r-- 1 akpm akpm 493 May 2

Re: [PATCH 10/23] maccess: unify the probe kernel arch hooks

2020-05-27 Thread Andrew Morton
On Thu, 21 May 2020 17:22:48 +0200 Christoph Hellwig wrote: > Currently architectures have to override every routine that probes > kernel memory, which includes a pure read and strcpy, both in strict > and not strict variants. Just provide a single arch hooks instead to > make sure all architect

Re: [PATCH 12/23] bpf: handle the compat string in bpf_trace_copy_string better

2020-05-27 Thread Andrew Morton
> strncpy_from_kernel_nofault(buf, unsafe_ptr, bufsz); Another user of strncpy_from_unsafe() has popped up in linux-next's bpf. I did the below, but didn't try very hard - it's probably wrong if CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE=n? Anyway, please take

Re: clean up and streamline probe_kernel_* and friends v4

2020-05-25 Thread Andrew Morton
On Thu, 21 May 2020 17:22:38 +0200 Christoph Hellwig wrote: > this series start cleaning up the safe kernel and user memory probing > helpers in mm/maccess.c, and then allows architectures to implement > the kernel probing without overriding the address space limit and > temporarily allowing acce

Re: [PATCH v5 2/2] mm, treewide: Rename kzfree() to kfree_sensitive()

2020-06-16 Thread Andrew Morton
On Tue, 16 Jun 2020 11:43:11 -0400 Waiman Long wrote: > As said by Linus: > > A symmetric naming is only helpful if it implies symmetries in use. > Otherwise it's actively misleading. > > In "kzalloc()", the z is meaningful and an important part of what the > caller wants. > > In "kz

Re: [netfilter-core] kernel panic: Out of memory and no killable processes... (2)

2018-02-07 Thread Andrew Morton
> > Date: Wed, 31 Jan 2018 09:16:56 +0100 > > Subject: [PATCH] net/netfilter/x_tables.c: remove size check > > > > Back in 2002 vmalloc used to BUG on too large sizes. We are much better > > behaved these days and vmalloc simply returns NULL for those. Remove > > the

Re: [netfilter-core] kernel panic: Out of memory and no killable processes... (2)

2018-01-30 Thread Andrew Morton
On Tue, 30 Jan 2018 15:01:04 +0100 Michal Hocko wrote: > > Well, this is not about syzkaller, it merely pointed out a potential > > DoS... And that has to be addressed somehow. > > So how about this? > --- argh ;) > >From d48e950f1b04f234b57b9e34c363bdcfec10aeee Mon Sep 17 00:00:00 2001 > From

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Andrew Morton
On Tue, 29 May 2007 11:01:13 -0700 Venki Pallipadi <[EMAIL PROTECTED]> wrote: > round_jiffies for net dev watchdog timer. > > Signed-off-by: Venkatesh Pallipadi <[EMAIL PROTECTED]> > > Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c > ===

e100 resume failure

2007-05-30 Thread Andrew Morton
I was doing some suspend-to-ram testing on the Vaio with the 2.6.22-rc3-mm1 lineup. After 10 or 15 cycles a resume failed: [ 357.119436] Suspending device full [ 357.120450] Suspending device zero [ 358.084978] Suspending device port [ 358.085664] Suspending device null [ 358.086432] Suspen

Re: [PATCH] bugfix GFP_KERNEL -> GFP_ATOMIC in spin_locked region

2007-06-04 Thread Andrew Morton
On Mon, 04 Jun 2007 18:25:28 +0200 Yoann Padioleau <[EMAIL PROTECTED]> wrote: > > In a few files a function such as usb_submit_urb is taking GFP_KERNEL > as an argument whereas this function call is inside a > spin_lock_irqsave region of code. Documentation says that it must be > GFP_ATOMIC inste

Re: [PATCH] bugfix GFP_KERNEL -> GFP_ATOMIC in spin_locked region

2007-06-04 Thread Andrew Morton
On Mon, 4 Jun 2007 21:00:18 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > > diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c > > index 544098d..9ec38e3 100644 > > --- a/drivers/usb/serial/io_ti.c > > +++ b/drivers/usb/serial/io_ti.c > &

warnings in git-wireless

2007-06-05 Thread Andrew Morton
i386 allmodconfig isn't that hard, guys. drivers/net/wireless/mac80211/zd1211rw/zd_mac.c:600: warning: 'fill_rt_header' defined but not used drivers/net/wireless/mac80211/iwlwifi/iwl-4965.c: In function 'iwl_hw_tx_queue_free_tfd': drivers/net/wireless/mac80211/iwlwifi/iwl-4965.c:964: warning: l

Re: warnings in git-wireless

2007-06-05 Thread Andrew Morton
On Tue, 05 Jun 2007 13:12:03 -0700 James Ketrenos <[EMAIL PROTECTED]> wrote: > John W. Linville wrote: > > On Tue, Jun 05, 2007 at 02:06:14AM -0700, Andrew Morton wrote: > > > >> Please, don't anybody dare think about thinking about letting this anywhere &g

Re: 2.6.22-rc3-mm1 - pppd hanging in netdev_run_todo while holding mutex

2007-06-05 Thread Andrew Morton
On Mon, 04 Jun 2007 14:00:56 -0400 [EMAIL PROTECTED] wrote: > On Wed, 30 May 2007 23:58:23 PDT, Andrew Morton said: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc3/2.6.22-rc3-mm1/ > > Under 22-rc2-mm1, if my VPN connection got reset, ppp0 just qu

Re: warnings in git-wireless

2007-06-06 Thread Andrew Morton
On Wed, 06 Jun 2007 13:51:41 -0700 James Ketrenos <[EMAIL PROTECTED]> wrote: > > >> * make C=2 CF=-Wall will complain if you use ARRAY_SIZE on global data > >> */ > >> #define GLOBAL_ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) > > > > This is identical to ARRAY_SIZE. > > > > And if there's some

Re: warnings in git-wireless

2007-06-06 Thread Andrew Morton
On Wed, 06 Jun 2007 15:33:46 -0700 James Ketrenos <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > On Wed, 06 Jun 2007 13:51:41 -0700 James Ketrenos <[EMAIL PROTECTED]> wrote: > > > >>>> * make C=2 CF=-Wall will complain if you use ARRAY_SIZ

Re: 2.6.22-rc4-mm2 -- ipw2200 -- SIOCSIFADDR: No buffer space available

2007-06-07 Thread Andrew Morton
On Thu, 7 Jun 2007 11:25:30 -0700 "Miles Lane" <[EMAIL PROTECTED]> wrote: > Hi Andrew, > > This might be some problem with my kernel configuration. > I added: > CONFIG_BONDING=y > > # dhclient eth1 > There is already a pid file /var/run/dhclient.pid with pid 134993416 > Internet Systems Consorti

Re: 2.6.22-rc4-mm2: Assigning IP address fails

2007-06-07 Thread Andrew Morton
On Thu, 7 Jun 2007 17:46:09 -0400 [EMAIL PROTECTED] (Joseph Fannin) wrote: > On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote: > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/ > > I'm not able to bring

Re: [PATCH 1/1] make network DMA usable for non-tcp drivers

2007-06-08 Thread Andrew Morton
On Fri, 8 Jun 2007 10:30:53 -0400 "Ed L. Cashin" <[EMAIL PROTECTED]> wrote: > Here is a patch against the netdev-2.6 git tree that makes the net DMA > feature usable for drivers like the ATA over Ethernet block driver, > which can use dma_skb_copy_datagram_iovec when receiving data from the > netw

Re: [Bugme-new] [Bug 8635] New: EV6 version of csum_ipv6_magic causing unaligned access errors

2007-06-16 Thread Andrew Morton
On Fri, 15 Jun 2007 13:47:33 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8635 > >Summary: EV6 version of csum_ipv6_magic causing unaligned access > errors >Product: Networking >Version: 2.5 > Kernel

Re: [Bugme-new] [Bug 8638] New: unregister_netdevice: waiting for ppp0 to become free. pppoe + multihome + htb qos?

2007-06-16 Thread Andrew Morton
On Sat, 16 Jun 2007 03:11:30 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8638 > >Summary: unregister_netdevice: waiting for ppp0 to become free. > pppoe + multihome + htb qos? >Product: Networking >Versi

Re: [Bugme-new] [Bug 8638] New: unregister_netdevice: waiting for ppp0 to become free. pppoe + multihome + htb qos?

2007-06-18 Thread Andrew Morton
On Mon, 18 Jun 2007 10:56:06 -0400 Chuck Ebbert <[EMAIL PROTECTED]> wrote: > > Is there any way to print the addresses the notifier is calling > to try and release net device references? I see: > > net/core/dev/c::netdev_wait_allrefs(): > > while (atomic_read(&dev->refcnt) != 0) { >

Re: [Bugme-new] [Bug 8654] New: possible connect() bug

2007-06-20 Thread Andrew Morton
> On Wed, 20 Jun 2007 03:56:28 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8654 > >Summary: possible connect() bug >Product: Networking >Version: 2.5 > KernelVersion: Linux version 2.6.21.1 ([EMAIL PROTECTED]) (gcc >

Re: [patch] alpha: fix alignment problem in csum_ipv6_magic()

2007-06-21 Thread Andrew Morton
> On Sun, 17 Jun 2007 01:20:20 +0400 Ivan Kokshaysky <[EMAIL PROTECTED]> wrote: > Hopefully this fixes http://bugzilla.kernel.org/show_bug.cgi?id=8635 > > The struct in6_addr passed to csum_ipv6_magic() is 4 byte aligned, > so we can't use the regular 64-bit loads. > Since the cost of handling of

Re: [PATCH] Ethernet driver for EISA only SNI RM200/RM400 machines

2007-06-23 Thread Andrew Morton
> On Fri, 22 Jun 2007 21:53:58 +0200 [EMAIL PROTECTED] (Thomas Bogendoerfer) > wrote: > Hi, > > This is new ethernet driver, which use the code taken out of lasi_82596 > (done by the other patch I just sent). > > Thomas. > > > Ethernet driver for EISA only SNI RM200/RM400 machines > > ... > >

Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2

2007-06-23 Thread Andrew Morton
> On Thu, 21 Jun 2007 18:48:30 +0530 "pradeep singh" <[EMAIL PROTECTED]> wrote: > Hi, > My mistake. > Resending after reformatting the patch by hand. > Looks like gmail messes the plain text patches. > That's still mangled so I typed it in again. Please always include a full changlog with each v

Re: Scaling Max IP address limitation

2007-06-24 Thread Andrew Morton
On Sun, 24 Jun 2007 12:20:01 -0500 David Jones <[EMAIL PROTECTED]> wrote: > Hi, > I am trying to add multiple IP addresses ( v6 ) to my FC7 box on eth0. > But I am hitting a max limit of 4000 IP address . Seems like there is a > limiting variable in linux kernel (which one? ) that prevents from

Re: [Bugme-new] [Bug 8668] New: HTB Deadlock

2007-06-24 Thread Andrew Morton
On Sun, 24 Jun 2007 21:57:19 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8668 > >Summary: HTB Deadlock >Product: Networking >Version: 2.5 > KernelVersion: 2.6.19.7 > Platform: All > OS/Version: Linux

Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2

2007-06-25 Thread Andrew Morton
On Thu, 21 Jun 2007 18:48:30 +0530 "pradeep singh" <[EMAIL PROTECTED]> wrote: > diff --git a/drivers/net/chelsio/cxgb2.c b/drivers/net/chelsio/cxgb2.c > index 231ce43..006c634 100644 > --- a/drivers/net/chelsio/cxgb2.c > +++ b/drivers/net/chelsio/cxgb2.c > @@ -1022,6 +1022,11 @@ static int __devin

Re: [NET] au1000_eth: Fix warnings.

2007-06-25 Thread Andrew Morton
On Sun, 24 Jun 2007 15:59:54 +0200 Ralf Baechle <[EMAIL PROTECTED]> wrote: > Fixed by including : > > CC drivers/net/au1000_eth.o > drivers/net/au1000_eth.c: In function 'au1000_probe': > drivers/net/au1000_eth.c:661: warning: implicit declaration of function > 'dma_alloc_noncoherent' > d

Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2

2007-06-25 Thread Andrew Morton
On Mon, 25 Jun 2007 19:14:05 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > The chelsio driver is assuming that pci_device_id.driver_data has been > > initialised to the board index, but I am unable to locate anywhere where > > that init

Re: 2.6.22: ERROR: "__ucmpdi2" [drivers/net/s2io.ko] undefined!

2007-06-26 Thread Andrew Morton
On Thu, 21 Jun 2007 05:55:13 -0400 "Sivakumar Subramani" <[EMAIL PROTECTED]> wrote: > -Original Message- > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > > On Behalf Of Olaf Hering > > Sent: Wednesday, June 20, 2007 2:11 AM > > To: Stephen Hemminger > > Cc: [EMAIL PROTECTED]; netde

Re: [Bugme-new] [Bug 8678] New: Kernel OOPSes when suspend/resume

2007-06-26 Thread Andrew Morton
On Tue, 26 Jun 2007 08:22:11 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8678 > >Summary: Kernel OOPSes when suspend/resume >Product: Power Management >Version: 2.5 > KernelVersion: 2.6.21.5 > Platform: All >

Re: [Bugme-new] [Bug 8678] New: Kernel OOPSes when suspend/resume

2007-06-26 Thread Andrew Morton
On Tue, 26 Jun 2007 19:42:14 +0200 CIJOML <[EMAIL PROTECTED]> wrote: > > > EIP is at put_page+0x5/0xb2 > > > eax: ebx: ecx: c0317380 edx: f63f70c0 > > > esi: ea6e2680 edi: f784dd84 ebp: f784de48 esp: f784dd4c > > > ds: 007b es: 007b fs: 00d8 gs: 0033 ss: 0068 >

Re: [Bugme-new] [Bug 8678] New: Kernel OOPSes when suspend/resume

2007-06-26 Thread Andrew Morton
On Tue, 26 Jun 2007 23:16:14 +0200 CIJOML <[EMAIL PROTECTED]> wrote: > > Can you please retest without DRM? > > > > Greetings, > > Rafael > > Ehm What is DRM??? Digital Right Management Direct-rendering manager: the thing which does accelerated 3d in X. Disable CONFIG_DRM in your .config. -

Re: [PATCH] Re: [2.6.21.1] soft lockup when removing netconsole module

2007-06-26 Thread Andrew Morton
y, I don't > think this patch is right... > > > > From: Jason Wessel <[EMAIL PROTECTED]> > > > > > > Do not call cancel_rearming_delayed_work() if there is no > > > pending work. > > > > > > Signed-off-by: Jason Wessel <[EM

Re: [PATCH] Re: [2.6.21.1] soft lockup when removing netconsole module

2007-06-26 Thread Andrew Morton
On Tue, 26 Jun 2007 17:46:13 -0700 "Wessel, Jason" <[EMAIL PROTECTED]> wrote: > > > } > > > } > > > > Everything went quiet? > > > > If this patch has been tested and fixes the bug, can you > > please send a version which is ready for merging? (ie: add a > > suitab

git-net, git-netdev-all and everything else on g5

2007-06-28 Thread Andrew Morton
With the full -mm lineup, my tg3-using powerpc g5 spits lots of these: windfarm: Drive bay control loop started. audit(1183017094.732:2): audit_pid=2117 old=0 by auid=4294967295 [ cut here ] Badness at net/core/dev.c:1303 Call Trace: [cb45ead0] [c00108c8] .

Re: e1000: backport ich9 support from 7.5.5 ?

2007-06-29 Thread Andrew Morton
On Fri, 29 Jun 2007 14:39:20 -0700 "Kok, Auke" <[EMAIL PROTECTED]> wrote: > > That's why we want to introduce a second e1000 driver (named differently, > pick > any name) that contains the new code base, side-by-side into the kernel with > the > current e1000. Sounds like a reasonable approa

Re: [Bugme-new] [Bug 8697] New: nfs-root doesn't work with jumbo frames

2007-07-01 Thread Andrew Morton
please submit the patch via email as per http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt to Andrew Morton <[EMAIL PROTECTED]> netdev@vger.kernel.org [EMAIL PROTECTED] thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Andrew Morton
On Mon, 02 Jul 2007 11:32:41 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Bitfields are to be avoided for many reasons: > * more difficult, in general, for a compiler to generate optimal code > * in particular, known to generate worse code on various architectures > * often causes endian problem

Re: [PATCH 07/12] use a dynamic pool of sk_buffs to keep up with fast targets

2007-07-02 Thread Andrew Morton
On Tue, 26 Jun 2007 14:50:11 -0400 "Ed L. Cashin" <[EMAIL PROTECTED]> wrote: > Use a dynamic pool of sk_buffs to keep up with fast targets. That's far too skimpy a description of what this patch is doing, what it is for, what makes AOE need this functionality, etc. My initial thought is that if

Re: [PATCH 2/2] net: make net and forcedeth to use kmalloc_node

2007-07-03 Thread Andrew Morton
On Fri, 29 Jun 2007 13:30:36 -0700 Yinghai Lu <[EMAIL PROTECTED]> wrote: > [PATCH 2/2] net: make net and forcedeth to use kmalloc_node Please copy netdev@vger.kernel.org on net patches. This patch modifies a net driver as well as the networking core. These subsytems have different maintainers w

Re: [Bugme-new] [Bug 8724] New: Unaligned acess in udp_recvmsg() on EV56

2007-07-08 Thread Andrew Morton
On Sun, 8 Jul 2007 14:30:17 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8724 > >Summary: Unaligned acess in udp_recvmsg() on EV56 >Product: Platform Specific/Hardware >Version: 2.5 > KernelVersion: 2.6.22-rc7-git7 >

Re: [Bugme-new] [Bug 8726] New: MSG_TRUNC not regarded in unix_dgram_recvmsg()

2007-07-09 Thread Andrew Morton
On Mon, 9 Jul 2007 04:01:58 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8726 > >Summary: MSG_TRUNC not regarded in unix_dgram_recvmsg() >Product: Networking >Version: 2.5 > KernelVersion: 2.6.19 > Platform:

O_CLOEXEC patches

2007-07-09 Thread Andrew Morton
A couple of patches here which affect networking. Please review... - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH re-resend] fix race in AF_UNIX garbage collector

2007-07-10 Thread Andrew Morton
On Tue, 10 Jul 2007 11:50:30 +0200 Miklos Szeredi <[EMAIL PROTECTED]> wrote: > Can you please add this to -mm. Sometimes that has wonderful effect > on the willingness of people to look at a patch. sure ;) > It fixes a bug in AF_UNIX sockets that affects the ulockmgr library in > the fuse packa

Re: ata and netdev (was Re: -mm merge plans for 2.6.23)

2007-07-10 Thread Andrew Morton
On Tue, 10 Jul 2007 13:42:16 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > > (just to provide my indicator of status) Thanks. > > libata-add-irq_flags-to-struct-pata_platform_info-fix.patch > > are other pata_platform people happy with this? I don't know embedded > well enough to know if ad

Re: ata and netdev (was Re: -mm merge plans for 2.6.23)

2007-07-10 Thread Andrew Morton
On Wed, 11 Jul 2007 00:31:23 +0400 Sergei Shtylyov <[EMAIL PROTECTED]> wrote: > Hello. > > Andrew Morton wrote: > > > 3x59x-fix-pci-resource-management.patch: you wrote it ;) I have a comment > > No, I did, almost a year ago already. :-) I thought that was

Re: [patch 2/8] Make some network-related proc files use seq_list_xxx helpers

2007-07-10 Thread Andrew Morton
On Wed, 11 Jul 2007 09:05:13 +0900 (JST) Yasuyuki KOZAKAI <[EMAIL PROTECTED]> wrote: > > I've met compile error on net-2.6.23 tree. > > net/built-in.o: In function `proto_seq_next': > sock.c:(.text+0x3008): undefined reference to `seq_list_next' > net/built-in.o: In function `proto_seq_start': >

Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-10 Thread Andrew Morton
On Tue, 10 Jul 2007 22:12:24 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > But myself, nor any other developers, are going to review your work > any faster if you do things like try to slip things in behind the > maintainer's back as you attempted to do yesterday by asking Andrew to > put

Re: [Bugme-new] [Bug 8736] New: New TC deadlock scenario

2007-07-11 Thread Andrew Morton
On Wed, 11 Jul 2007 08:45:12 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8736 > >Summary: New TC deadlock scenario >Product: Networking >Version: 2.5 > KernelVersion: 2.6.22 > Platform: All > OS/Versi

Re: [2.6.23 PATCH 13/18] dm: netlink

2007-07-11 Thread Andrew Morton
On Wed, 11 Jul 2007 22:01:37 +0100 Alasdair G Kergon <[EMAIL PROTECTED]> wrote: > From: Mike Anderson <[EMAIL PROTECTED]> > > This patch adds a dm-netlink skeleton support to the Makefile, and the dm > directory. > > ... > > +config DM_NETLINK > + bool "DM netlink events (EXPERIMENTAL)" >

Re: [2.6.23 PATCH 14/18] dm: netlink add to core

2007-07-11 Thread Andrew Morton
On Wed, 11 Jul 2007 22:01:59 +0100 Alasdair G Kergon <[EMAIL PROTECTED]> wrote: > From: Mike Anderson <[EMAIL PROTECTED]> > > This patch adds support for the dm_path_event dm_send_event funtions which > create and send netlink attribute events. > > ... > > --- linux.orig/drivers/md/dm-netlink.c

Re: [Bugme-new] [Bug 8724] New: Unaligned acess in udp_recvmsg() on EV56

2007-07-12 Thread Andrew Morton
On Thu, 12 Jul 2007 12:45:26 -0500 Dustin Marquess <[EMAIL PROTECTED]> wrote: > Bingo! That did it. > > I copied/modified the #ifdef from tulip_core.c: > > /* Set the copy breakpoint for the copy-only-tiny-buffer Rx structure. */ > #if defined(__alpha__) || defined(__arm__) || defined(__hppa__)

Re: [2.6.23 PATCH 13/18] dm: netlink

2007-07-12 Thread Andrew Morton
On Thu, 12 Jul 2007 18:19:20 -0500 Matt Mackall <[EMAIL PROTECTED]> wrote: > On Wed, Jul 11, 2007 at 02:27:12PM -0700, Andrew Morton wrote: > > On Wed, 11 Jul 2007 22:01:37 +0100 > > Alasdair G Kergon <[EMAIL PROTECTED]> wrote: > > > > > From: Mike Ande

Re: [Bugme-new] [Bug 8747] New: MSG_ERRQUEUE messages do not pass to connected raw sockets

2007-07-13 Thread Andrew Morton
On Fri, 13 Jul 2007 09:56:20 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8747 > >Summary: MSG_ERRQUEUE messages do not pass to connected raw > sockets >Product: Networking >Version: 2.5 > KernelVers

Re: [Bugme-new] [Bug 8754] New: Kernel addrconf modifies MTU of non-kernel routes

2007-07-14 Thread Andrew Morton
On Sat, 14 Jul 2007 14:54:32 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8754 > >Summary: Kernel addrconf modifies MTU of non-kernel routes >Product: Networking >Version: 2.5 > Platform: All > OS/Version:

Re: [Bugme-new] [Bug 8755] New: "ip -6 route change " behaves like "ip -6 route add"

2007-07-14 Thread Andrew Morton
On Sat, 14 Jul 2007 15:21:21 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8755 > >Summary: "ip -6 route change " behaves like "ip -6 route add" >Product: Networking >Version: 2.5 > Platform: All > OS/Versio

Re: [Bugme-new] [Bug 8756] New: Route advmss copied to ALL routes when interface MTU changes

2007-07-14 Thread Andrew Morton
On Sat, 14 Jul 2007 15:34:31 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8756 It is unclear which kernel version this applies to? >Summary: Route advmss copied to ALL routes when interface MTU > changes >Product: N

Re: [Bugme-new] [Bug 8766] New: 802.1q VLAN stacking + REORDER_HDR is broken

2007-07-16 Thread Andrew Morton
On Sun, 15 Jul 2007 23:57:32 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8766 > >Summary: 802.1q VLAN stacking + REORDER_HDR is broken >Product: Networking >Version: 2.5 > KernelVersion: 2.6.20 > Platform: Al

Re: Linux 2.6.22: had to reboot after OOM

2007-07-17 Thread Andrew Morton
On Sun, 15 Jul 2007 15:03:21 +0300 Sami Farin <[EMAIL PROTECTED]> wrote: > After I got this error [1], system got real slow, like 386 having 32 MB of RAM > and swapping constantly. > My system is P4 SMP with 1GB of RAM. > > I got this same behavior with 2.6.19, too, but then I used GNU cp v6.9 >

Re: [Bugme-new] [Bug 8778] New: Ocotea board: kernel reports access of bad area during boot with DEBUG_SLAB=y

2007-07-18 Thread Andrew Morton
On Wed, 18 Jul 2007 00:07:50 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8778 > >Summary: Ocotea board: kernel reports access of bad area during > boot with DEBUG_SLAB=y >Product: Platform Specific/Hardware >

  1   2   3   4   5   6   7   8   9   10   >