xsj24 closed pull request #1845: Tweak StringGroovyMethods
URL: https://github.com/apache/groovy/pull/1845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
paulk-asert merged PR #1846:
URL: https://github.com/apache/groovy/pull/1846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
codecov-commenter commented on PR #1845:
URL: https://github.com/apache/groovy/pull/1845#issuecomment-1383135076
#
[Codecov](https://codecov.io/gh/apache/groovy/pull/1845?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw
xsj24 opened a new pull request, #1845:
URL: https://github.com/apache/groovy/pull/1845
Group zero is not included in the result of the groupCount method. Set the
correct initial capacity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
paulk-asert commented on PR #1844:
URL: https://github.com/apache/groovy/pull/1844#issuecomment-1382702376
I don't know whether the original code was chosen to avoid the exception
being thrown when using the NIO method (for the not exists case) but it
shouldn't be too much of a drama.
--
daniellansun commented on PR #1844:
URL: https://github.com/apache/groovy/pull/1844#issuecomment-1382693991
Merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #1844:
URL: https://github.com/apache/groovy/pull/1844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
codecov-commenter commented on PR #1844:
URL: https://github.com/apache/groovy/pull/1844#issuecomment-1382677553
#
[Codecov](https://codecov.io/gh/apache/groovy/pull/1844?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw
Matyrobbrt opened a new pull request, #1844:
URL: https://github.com/apache/groovy/pull/1844
This PR replaces the different usages of `Path#toFile` in `NioExtensions`
with the equivalent methods in the NIO API (`Files`). This change is done
because there is no guarantee a `Path` can always
Matyrobbrt opened a new pull request, #1843:
URL: https://github.com/apache/groovy/pull/1843
This PR adds `asBoolean` extension methods to `Path` and `File` in order to
allow Groovy Truth usage.
I have also added an `exists(LinkOption...)` extension method in
`NioExtensions` but I can
daniellansun commented on PR #1841:
URL: https://github.com/apache/groovy/pull/1841#issuecomment-1380855302
Merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #1841:
URL: https://github.com/apache/groovy/pull/1841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #1837:
URL: https://github.com/apache/groovy/pull/1837#issuecomment-1380800056
The build is still failing:
https://github.com/apache/groovy/actions/runs/3886703609/jobs/6634225416#step:6:569
--
This is an automated message from the Apache Git Service.
To re
paulk-asert merged PR #1842:
URL: https://github.com/apache/groovy/pull/1842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
runningcode commented on PR #1837:
URL: https://github.com/apache/groovy/pull/1837#issuecomment-1377762884
Thanks, do you mean that the build in general is failing? Or that this PR
caused this failure?
--
This is an automated message from the Apache Git Service.
To respond to the message,
codecov-commenter commented on PR #1842:
URL: https://github.com/apache/groovy/pull/1842#issuecomment-1374828179
#
[Codecov](https://codecov.io/gh/apache/groovy/pull/1842?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw
daniellansun commented on PR #1837:
URL: https://github.com/apache/groovy/pull/1837#issuecomment-1374790998
```
> Task :groovy-xml:asciidoctor
Dependency verification has been disabled for configuration
detachedConfiguration2
Dependency verification has been disabled for configurati
daniellansun commented on PR #1841:
URL: https://github.com/apache/groovy/pull/1841#issuecomment-1374789309
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
codecov-commenter commented on PR #1841:
URL: https://github.com/apache/groovy/pull/1841#issuecomment-1374701185
#
[Codecov](https://codecov.io/gh/apache/groovy/pull/1841?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw
PaintNinja opened a new pull request, #1841:
URL: https://github.com/apache/groovy/pull/1841
This small PR fixes the following error when trying to run the Groovy
runtime benchmarks (`./gradlew -PbenchInclude=CallsiteBench :perf:jmh`):
```
Execution failed for task ':performance:jmh'.
daniellansun merged PR #1840:
URL: https://github.com/apache/groovy/pull/1840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
codecov-commenter commented on PR #1840:
URL: https://github.com/apache/groovy/pull/1840#issuecomment-1371638430
#
[Codecov](https://codecov.io/gh/apache/groovy/pull/1840?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw
dependabot[bot] opened a new pull request, #1840:
URL: https://github.com/apache/groovy/pull/1840
Bumps com.gradle.enterprise from 3.12.1 to 3.12.2.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.gradle.ent
paulk-asert merged PR #1839:
URL: https://github.com/apache/groovy/pull/1839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
royteeuwen commented on PR #1836:
URL: https://github.com/apache/groovy/pull/1836#issuecomment-1371305256
> Will this cause many passes of class scanning and
`DefaultFastStringService` instances? How are `loadService()` and
`getService()` used?
INSTANCE s a static field, meaning that
eric-milles commented on PR #1836:
URL: https://github.com/apache/groovy/pull/1836#issuecomment-1371268084
Will this cause many passes of class scanning and `DefaultFastStringService`
instances? How are `loadService()` and `getService()` used?
--
This is an automated message from the Apa
eric-milles commented on PR #1836:
URL: https://github.com/apache/groovy/pull/1836#issuecomment-1371265481
Can you please make the test class `final` and JUnit4-based by using `@Test`
instead of `GroovyTestCase`?
--
This is an automated message from the Apache Git Service.
To respond to t
paulk-asert commented on PR #1839:
URL: https://github.com/apache/groovy/pull/1839#issuecomment-1370224768
My thinking was since this is missing functionality it makes sense for
4.0.8. We have the find/findAll variants (Groovy truth) in 4.0.7 why not the
missing findResult/s variants (null-
eric-milles commented on PR #1839:
URL: https://github.com/apache/groovy/pull/1839#issuecomment-1369834434
Not sure why the new methods are listed as "since 4.0.8". Are these such a
must have that they should be available immediately. If kept for 5+, the
array-based overloads can start of
paulk-asert commented on PR #1839:
URL: https://github.com/apache/groovy/pull/1839#issuecomment-1369681830
Is the "further clarification request" on your -1 veto satisfied? Perhaps
you can formally remove it?
--
This is an automated message from the Apache Git Service.
To respond to the m
paulk-asert commented on PR #1839:
URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368542797
We picked the name `findResult` many years ago. Naming is hard. I wasn't
going to open the naming can of worms myself. Just plugging that hole in the
existing named functions.
B
eric-milles commented on PR #1839:
URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368491569
Okay, just picked up on the difference. `find` and `findAll` apply groovy
truth and `findResult` and `findResults` check `null` only. Is that too subtle
a difference?
If this
eric-milles commented on PR #1839:
URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368484663
And since `find` and `findAll` are based on groovy truth, to get a default
value, you can just pepper in elvis:
```groovy
def list = [null,false,'',[]]
def result = list.find()
eric-milles commented on PR #1839:
URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368483874
I don't think it is hole in existing functionality though. I'm missing the
clear and obvious part of all this. Leaving the default value stuff aside,
```groovy
def list = [null,
paulk-asert commented on PR #1839:
URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368316519
It is filling a hole in existing functionality. Take `find` and `findAll`
for instance, they have the no Closure variants:
```
var list = [null, '', 'A', null, 'B']
assert list
eric-milles commented on PR #1839:
URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368284125
-1 for me unless some description is provided. What is the specific purpose
of this and what does to replace that is currently available? More discussion
from Feb 2019: https://www.m
codecov-commenter commented on PR #1839:
URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368212345
#
[Codecov](https://codecov.io/gh/apache/groovy/pull/1839?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw
paulk-asert opened a new pull request, #1839:
URL: https://github.com/apache/groovy/pull/1839
… which use Closure.IDENTITY in that case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
daniellansun merged PR #1838:
URL: https://github.com/apache/groovy/pull/1838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
codecov-commenter commented on PR #1838:
URL: https://github.com/apache/groovy/pull/1838#issuecomment-1367678028
#
[Codecov](https://codecov.io/gh/apache/groovy/pull/1838?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw
dependabot[bot] opened a new pull request, #1838:
URL: https://github.com/apache/groovy/pull/1838
Bumps build-info-extractor-gradle from 4.30.1 to 4.31.0.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.jfro
codecov-commenter commented on PR #1837:
URL: https://github.com/apache/groovy/pull/1837#issuecomment-1366848283
#
[Codecov](https://codecov.io/gh/apache/groovy/pull/1837?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw
runningcode opened a new pull request, #1837:
URL: https://github.com/apache/groovy/pull/1837
The deprecation warning that this PR fixes can be seen [in this build
scan](https://scans.gradle.com/s/njuvm77j3jark/deprecations?expanded=WyI1OSJd#60)
--
This is an automated message from th
daniellansun commented on PR #1834:
URL: https://github.com/apache/groovy/pull/1834#issuecomment-1362284825
Merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #1834:
URL: https://github.com/apache/groovy/pull/1834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
codecov-commenter commented on PR #1836:
URL: https://github.com/apache/groovy/pull/1836#issuecomment-1361193224
#
[Codecov](https://codecov.io/gh/apache/groovy/pull/1836?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw
daniellansun merged PR #1835:
URL: https://github.com/apache/groovy/pull/1835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
codecov-commenter commented on PR #1835:
URL: https://github.com/apache/groovy/pull/1835#issuecomment-1360651016
#
[Codecov](https://codecov.io/gh/apache/groovy/pull/1835?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw
dependabot[bot] opened a new pull request, #1835:
URL: https://github.com/apache/groovy/pull/1835
Bumps com.gradle.enterprise from 3.12 to 3.12.1.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.gradle.enter
paulk-asert commented on PR #1834:
URL: https://github.com/apache/groovy/pull/1834#issuecomment-1360225048
There are 24 methods but it is basically:
4 types: Iterators, Iterables, arrays and Maps BY
2 options: supplied collector or new map BY
3 scenarios: change key and value, change
eric-milles commented on PR #1834:
URL: https://github.com/apache/groovy/pull/1834#issuecomment-1359449154
That's a lot of new methods. Any chance of splitting it up into separate
PRs for each name so they can be reviewed separately? new `collectEntries`
variant seemed reasonable-ish. B
daniellansun commented on PR #1834:
URL: https://github.com/apache/groovy/pull/1834#issuecomment-1359128768
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
sonatype-lift[bot] commented on code in PR #1834:
URL: https://github.com/apache/groovy/pull/1834#discussion_r1053074864
##
src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
##
@@ -4005,6 +3998,405 @@ public static Map
collectEntries(Iterator self, Map col
daniellansun commented on PR #1832:
URL: https://github.com/apache/groovy/pull/1832#issuecomment-1358708115
Asciidoctor Gradle Plugin is not that active any more...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
paulk-asert commented on PR #1832:
URL: https://github.com/apache/groovy/pull/1832#issuecomment-1356167530
> The issue of Asciidoctor Gradle Plugin had been filed at
[asciidoctor/asciidoctor-gradle-plugin#655](https://github.com/asciidoctor/asciidoctor-gradle-plugin/issues/655).
Thank
Goooler commented on PR #1832:
URL: https://github.com/apache/groovy/pull/1832#issuecomment-1356157190
The issue of Asciidoctor Gradle Plugin had been filed at
https://github.com/asciidoctor/asciidoctor-gradle-plugin/issues/655.
--
This is an automated message from the Apache Git Service.
daniellansun merged PR #1833:
URL: https://github.com/apache/groovy/pull/1833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
dependabot[bot] opened a new pull request, #1833:
URL: https://github.com/apache/groovy/pull/1833
Bumps build-info-extractor-gradle from 4.30.0 to 4.30.1.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.jfro
daniellansun merged PR #1831:
URL: https://github.com/apache/groovy/pull/1831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
dependabot[bot] opened a new pull request, #1831:
URL: https://github.com/apache/groovy/pull/1831
Bumps build-info-extractor-gradle from 4.29.4 to 4.30.0.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.jfro
daniellansun merged PR #1830:
URL: https://github.com/apache/groovy/pull/1830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
dependabot[bot] opened a new pull request, #1830:
URL: https://github.com/apache/groovy/pull/1830
Bumps com.gradle.enterprise from 3.11.4 to 3.12.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.gradle.enter
daniellansun merged PR #1829:
URL: https://github.com/apache/groovy/pull/1829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
dependabot[bot] opened a new pull request, #1829:
URL: https://github.com/apache/groovy/pull/1829
Bumps build-info-extractor-gradle from 4.29.3 to 4.29.4.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.jfro
eric-milles commented on PR #1824:
URL: https://github.com/apache/groovy/pull/1824#issuecomment-1320201876
I relocated the lambda tests and reworked the generics tests to ensure the
placeholders are not returned.
https://github.com/apache/groovy/commit/ef9b58463e83f842b56f24dff0ac4df
eric-milles closed pull request #1824: GROOVY-10813: Fix NullPointerException
for lambdas with raw types
URL: https://github.com/apache/groovy/pull/1824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
paulk-asert closed pull request #1719: GROOVY-10615: Bump Codenarc to 3.0.1
(build dependency)
URL: https://github.com/apache/groovy/pull/1719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
paulk-asert commented on PR #1719:
URL: https://github.com/apache/groovy/pull/1719#issuecomment-1314679995
We'll wait for the next release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
paulk-asert merged PR #1826:
URL: https://github.com/apache/groovy/pull/1826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
daniellansun merged PR #1827:
URL: https://github.com/apache/groovy/pull/1827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
dependabot[bot] opened a new pull request, #1827:
URL: https://github.com/apache/groovy/pull/1827
Bumps com.github.ben-manes.versions from 0.43.0 to 0.44.0.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.gi
Shadow-Devil commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1020890479
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -855,10 +855,16 @@ private static Map
doMakeDeclaringAndActualGenericsT
Gener
paulk-asert commented on PR #1822:
URL: https://github.com/apache/groovy/pull/1822#issuecomment-1312638940
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
paulk-asert merged PR #1822:
URL: https://github.com/apache/groovy/pull/1822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
Shadow-Devil commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1020470376
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -855,10 +855,16 @@ private static Map
doMakeDeclaringAndActualGenericsT
Gener
Shadow-Devil commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1020468865
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -855,10 +855,16 @@ private static Map
doMakeDeclaringAndActualGenericsT
Gener
Shadow-Devil commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1020468865
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -855,10 +855,16 @@ private static Map
doMakeDeclaringAndActualGenericsT
Gener
Shadow-Devil commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1020417769
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -855,10 +855,16 @@ private static Map
doMakeDeclaringAndActualGenericsT
Gener
Shadow-Devil commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1020266114
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -855,10 +855,16 @@ private static Map
doMakeDeclaringAndActualGenericsT
Gener
Shadow-Devil commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1020265603
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -950,7 +956,7 @@ public static boolean hasUnresolvedGenerics(final ClassNode
type) {
Shadow-Devil commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1020046859
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -950,7 +956,7 @@ public static boolean hasUnresolvedGenerics(final ClassNode
type) {
FelixSchnabel commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1020045088
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -950,7 +956,7 @@ public static boolean hasUnresolvedGenerics(final ClassNode
type) {
daniellansun merged PR #1825:
URL: https://github.com/apache/groovy/pull/1825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
paulk-asert commented on PR #1820:
URL: https://github.com/apache/groovy/pull/1820#issuecomment-1311122050
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
asfgit closed pull request #1820: Fix doc typos
URL: https://github.com/apache/groovy/pull/1820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifica
dependabot[bot] opened a new pull request, #1825:
URL: https://github.com/apache/groovy/pull/1825
Bumps [build-info-extractor-gradle](https://github.com/jfrog/build-info)
from 4.29.2 to 4.29.3.
Changelog
Sourced from https://github.com/jfrog/build-info/blob/master/RELEASE.md";>buil
eric-milles commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1019717220
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -950,7 +956,7 @@ public static boolean hasUnresolvedGenerics(final ClassNode
type) {
p
Shadow-Devil opened a new pull request, #1824:
URL: https://github.com/apache/groovy/pull/1824
I've added a test case and a fix for the bug reported in GROOVY-10813.
I'm not sure if there are any other edge cases that will now break because
of this change, but one
[test](https://github.
tisonkun closed pull request #1821: Replace gradlew command with relative path
URL: https://github.com/apache/groovy/pull/1821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
tisonkun commented on PR #1821:
URL: https://github.com/apache/groovy/pull/1821#issuecomment-1309832274
@paulk-asert Thanks! I read it.
Closed as invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
paulk-asert commented on PR #1821:
URL: https://github.com/apache/groovy/pull/1821#issuecomment-1309829154
We already have the relative path for unix systems as a comment the first
time the command appears.
--
This is an automated message from the Apache Git Service.
To respond to the mes
daniellansun merged PR #1823:
URL: https://github.com/apache/groovy/pull/1823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
dependabot[bot] opened a new pull request, #1823:
URL: https://github.com/apache/groovy/pull/1823
Bumps com.gradle.enterprise from 3.11.3 to 3.11.4.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.gradle.ent
tisonkun opened a new pull request, #1822:
URL: https://github.com/apache/groovy/pull/1822
The AWT window is launched by DocCommand. I want to exclude this
functionality to avoid opening a new window so I suggest to add an option to
disable it.
--
This is an automated message from the Ap
eric-milles commented on PR #1816:
URL: https://github.com/apache/groovy/pull/1816#issuecomment-1307353408
I merged the main changes that should fix GROOVY-9541 and will cherry-pick
them back as well. The `ExtendedVerifier` spot has some history --
`getTypeClass()` -- I'm reworking it to u
eric-milles closed pull request #1816: Bugfix/groovy 9541 stc take classloader
param
URL: https://github.com/apache/groovy/pull/1816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
eric-milles commented on PR #1816:
URL: https://github.com/apache/groovy/pull/1816#issuecomment-1307253615
Thanks. I should be able to look at it today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
tisonkun opened a new pull request, #1821:
URL: https://github.com/apache/groovy/pull/1821
Current working directory is not always in PATH
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
jonnybot0 commented on code in PR #1816:
URL: https://github.com/apache/groovy/pull/1816#discussion_r1015853496
##
src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java:
##
@@ -2181,6 +2182,14 @@ public static boolean missesGenericsTypes(ClassNode cn) {
sonatype-lift[bot] commented on code in PR #1816:
URL: https://github.com/apache/groovy/pull/1816#discussion_r1014858643
##
src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java:
##
@@ -2181,6 +2182,14 @@ public static boolean missesGenericsTypes(ClassNo
1 - 100 of 1001 matches
Mail list logo