Re: [webkit][10] Review request: 8187568: JavaFX crash in libjfxwebkit.so

2017-10-11 Thread Guru Hb
Resending with correct Bug id in Subject line. > On 11-Oct-2017, at 6:57 PM, Guru Hb wrote: > > Hi Arun, Murali & Kevin, > > Please review the fix for > JBS : https://bugs.openjdk.java.net/browse/JDK-8187568 > <https://bugs.openjdk.java.net/browse

[webkit][10] Review request: 8170955: JavaFX crash in libjfxwebkit.so

2017-10-11 Thread Guru Hb
Hi Arun, Murali & Kevin, Please review the fix for JBS : https://bugs.openjdk.java.net/browse/JDK-8187568 <https://bugs.openjdk.java.net/browse/JDK-8187568> Webrev: http://cr.openjdk.java.net/~ghb/8187568/webrev.00/ <http://cr.openjdk.java.net/~ghb/8187568/webrev.00/> RC and

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-10-10 Thread Kevin Rushforth
Note that there is now a 04 version. It looks good to me, although someone more familiar with AWT should also check the AWT changes. We will need a test program for this (as a follow-on issue if not now). -- Kevin Alexander Zvegintsev wrote: Please review the updated version http

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-10-08 Thread Alexander Zvegintsev
Please review the updated version http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/02/ Now we are postponing actual window closing, it happens only after we ensure that native window pointer is valid on Swing side. Thanks, Alexander. On 23/09/2017 08:01, Sergey Bylokhov wrote: Hi

[10] Review request for 8181922: Provide media support for libav version 57

2017-10-03 Thread Alexander Matveev
Hi Kevin and David, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8181922 Added support for libav version 57. Thanks, Alexander

[10] Review request for 8187366: Remove hardcoded MSVC Version in win.gradle

2017-09-28 Thread Murali Billa
  Hi Kevin, Arun Please review the below simple fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8187366   Webrev: http://cr.openjdk.java.net/~mbilla/8187366/webrev.01/     Thanks, Murali

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-09-25 Thread Dmitry Markov
-8080729 for more details. >> >> To avoid possible problems in multi monitor set-up I suggest that you should >> replace addChildWindow() with orderWindow() or use some another approach to >> locate the window above the stage. >> >> Thanks, >> Dmitry >

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-09-25 Thread Semyon Sadetsky
Alexander Zvegintsev wrote: Hi Phil, Please review the updated fix with reflection incorporated http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/01/ New issue created JDK-8187803 <https://bugs.openjdk.java.net/browse/JDK-8187803> as JDK counterpart of this issue. Thanks, Alexander. On

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-09-25 Thread Alexander Zvegintsev
= peer.getOverridenWindowHandle(); <<<<< Dispose the peer if (ownerWindowPtr != 0) {     //Place window above JavaFX stage     CWrapper.NSWindow.addChildWindow(     ownerWindowPtr, ptr, CWrapper.NSWindow.NSWindowAbove); <<<<< Boom } On 9/21/17 22:56, Alexander Zvegintsev wrote: Hi Phil,

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-09-25 Thread Alexander Zvegintsev
lti monitor set-up I suggest that you should replace addChildWindow() with orderWindow() or use some another approach to locate the window above the stage. Thanks, Dmitry On 22 Sep 2017, at 06:56, Alexander Zvegintsev wrote: Hi Phil, Please review the updated fix with reflection in

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-09-23 Thread Dmitry Markov
problems in multi monitor set-up I suggest that you should replace addChildWindow() with orderWindow() or use some another approach to locate the window above the stage. Thanks, Dmitry > On 22 Sep 2017, at 06:56, Alexander Zvegintsev > wrote: > > Hi Phil, > > Please review th

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-09-22 Thread Sergey Bylokhov
.addChildWindow( ownerWindowPtr, ptr, CWrapper.NSWindow.NSWindowAbove); <<<<< Boom } On 9/21/17 22:56, Alexander Zvegintsev wrote: Hi Phil, Please review the updated fix with reflection incorporated http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/01/ New issue created JDK-8187803

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-09-22 Thread Phil Race
10:56 PM, Alexander Zvegintsev wrote: Hi Phil, Please review the updated fix with reflection incorporated http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/01/ New issue created JDK-8187803 <https://bugs.openjdk.java.net/browse/JDK-8187803> as JDK counterpart of this issue. Thanks, Al

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-09-21 Thread Alexander Zvegintsev
Hi Phil, Please review the updated fix with reflection incorporated http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/01/ New issue created JDK-8187803 <https://bugs.openjdk.java.net/browse/JDK-8187803> as JDK counterpart of this issue. Thanks, Alexander. On 21/09/2017 22:25, Phi

Re: [10] Review request for 185634: Java Fx-Swing dialogs appearing behind main stage

2017-09-21 Thread Phil Race
2017 03:38 AM, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8185634

[10] Review request for 185634: Java Fx-Swing dialogs appearing behind main stage

2017-09-21 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8185634 -- Thanks, Alexander.

[webkit][10] Review request - 8187726: Copy and Paste of Image not resulting in expected behavior

2017-09-21 Thread Rajath Kamath
Hi all, Please review a patch for fixing Copy and Paste functionality in FX WebView. Details in JBS. JBS : https://bugs.openjdk.java.net/browse/JDK-8187726 WebRev : http://cr.openjdk.java.net/~ghb/rkamath/8187726/webrev.00/ Thanks, Rajath

[webkit][10] Review request - 8187671: Drag and Drop of text or html results in an image

2017-09-20 Thread Rajath Kamath
Hi all, Please review a bug fix done for `Drag and Drop use case in WebView` explained in the JBS JBS : https://bugs.openjdk.java.net/browse/JDK-8187671 WebRev : http://cr.openjdk.java.net/~ghb/rkamath/8187671/webrev.00/ Thanks, Rajath

[10] Review request : JDK-8089265 : [ProgressIndicator] behaves itself wrong, when aligned

2017-09-18 Thread Ajit Ghaisas
Hi Jonathan, Request you to review following fix : Issue : https://bugs.openjdk.java.net/browse/JDK-8089265 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8089265/webrev.0/ Regards, Ajit

Re: [10] Review request: 8187361: Revert non reviewed commit done for the fix to JDK-8087528

2017-09-07 Thread Prasanta Sadhukhan
8087528 has been reverted ok. +1. Regards Prasanta On 9/8/2017 11:28 AM, Guru Hb wrote: Hi Murali & Arun, Please do the review for JBS : https://bugs.openjdk.java.net/browse/JDK-8187361 <https://bugs.openjdk.java.net/browse/JDK-8187361>Webrev : http://cr.openjdk.java.net/~g

[10] Review request: 8187361: Revert non reviewed commit done for the fix to JDK-8087528

2017-09-07 Thread Guru Hb
Hi Murali & Arun, Please do the review for JBS : https://bugs.openjdk.java.net/browse/JDK-8187361 <https://bugs.openjdk.java.net/browse/JDK-8187361>Webrev : http://cr.openjdk.java.net/~ghb/8187361/webrev.00/ <http://cr.openjdk.java.net/~ghb/8187361/webrev.00/> Thanks, Guru

[webkit][10] Review request - 8089124: HTML5: Number input allows non-numeric input

2017-09-06 Thread Rajath Kamath
Hi all, Please review the patch for enabling HTML5 form validation. With this enabled, WebKit would by default show validation specific error message dialogs using Shadow DOM + CSS styled web elements. This will serve as a placeholder until the FX platform implementation of

[10] Review request: 8187043: JavaFX fails to launch on some Windows platforms due to missing VS2017 libraries

2017-09-06 Thread Kevin Rushforth
Please review the following fix for a critical regression introduced in 10 (and 9.x) due to the VS 2017 compiler upgrade that was done as part of the recent WebKit update: https://bugs.openjdk.java.net/browse/JDK-8187043 http://cr.openjdk.java.net/~kcr/8187043/webrev.00/ -- Kevin

[10] Review request: 8187059 Update VS Projects

2017-08-31 Thread Chris Bensen
Victor, Please review this change to upgrade the native projects to the latest version of VS 2017: JIRA: https://bugs.openjdk.java.net/browse/JDK-8187059 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8187059/webrev.00/ Chris

[webkit][10] Review request: 8170955: HTML5 canvas shadow properties should not be affected by transform

2017-08-22 Thread Guru Hb
Hi Arun & Murali, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JDK-8170955 <https://bugs.openjdk.java.net/browse/JDK-8170955> webrev : http://cr.openjdk.java.net/~ghb/8170955/webrev.00/ <http://cr.openjdk.java.net/~ghb/8170955/webrev.00/> Thanks, Guru

[webkit][10] Review request - 8185314: Remove unused third-party python scripts from WebKit sources

2017-08-22 Thread Rajath Kamath
Hi Guru\Arun, Please review this simple cleanup of unused third-party library download scripts. JBS : https://bugs.openjdk.java.net/browse/JDK-8185314 WebRev : http://cr.openjdk.java.net/~ghb/rkamath/8185314/webrev.00/ Thanks, Rajath

Re: Review Request: JDK-8185954: Mac: JavaFx TextArea doesn't display the Emoji and Symbols on dropping them on the text area

2017-08-21 Thread Manajit Halder
you should close it as a dup. and return to the previous bug ? > > -phil. > > On 8/18/17, 2:05 AM, Manajit Halder wrote: >> Hi Phil, >> >> Please review the fix. >> >> Regards, >> Manajit >> >>> On 08-Aug-2017, at 4:52 PM,

Re: Review Request: JDK-8185954: Mac: JavaFx TextArea doesn't display the Emoji and Symbols on dropping them on the text area

2017-08-18 Thread Philip Race
17, 2:05 AM, Manajit Halder wrote: Hi Phil, Please review the fix. Regards, Manajit On 08-Aug-2017, at 4:52 PM, Manajit Halder wrote: Hi All, Kindly review the following JavaFx fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8185954<https://bugs.openjdk.java.net/browse/JDK-8185954

Re: Review Request: JDK-8185954: Mac: JavaFx TextArea doesn't display the Emoji and Symbols on dropping them on the text area

2017-08-18 Thread Manajit Halder
Hi Phil, Please review the fix. Regards, Manajit > On 08-Aug-2017, at 4:52 PM, Manajit Halder wrote: > > Hi All, > > Kindly review the following JavaFx fix. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8185954 > <https://bugs.openjdk.java.net/browse/

[10] Review Request : JDK-8173301 : Provide API to exclude parts of the SceneGraph from being processed by the CSS-Engine

2017-08-17 Thread Ajit Ghaisas
you to review. Regards, Ajit

[10] Review request: 8186237 Refactor jdk.packager to legacy package

2017-08-16 Thread Chris Bensen
Victor, Please review this refactor to get ready for the new CLI. JIRA: https://bugs.openjdk.java.net/browse/JDK-8186237 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8186237/webrev.00/ Chris

Re: [10] Review request : JDK-8090462 : CSS performance: Link style helpers together to avoid going through parent chain looking for parent style helpers

2017-08-10 Thread David Grieve
Ajit, I have provided some comments in the bug. On 8/10/17 8:45 AM, Ajit Ghaisas wrote: Hi Jonathan, Request you to review following change : Issue : https://bugs.openjdk.java.net/browse/JDK-8090462 Fix : http://cr.openjdk.java.net/~aghaisas/fx/e8090462/webrev.2/ Regards

[10] Review request : JDK-8090462 : CSS performance: Link style helpers together to avoid going through parent chain looking for parent style helpers

2017-08-10 Thread Ajit Ghaisas
Hi Jonathan, Request you to review following change : Issue : https://bugs.openjdk.java.net/browse/JDK-8090462 Fix : http://cr.openjdk.java.net/~aghaisas/fx/e8090462/webrev.2/ Regards, Ajit

[webkit][10] Review request: 8186061: libjfxwebkit.dylib ld warning libicudata.a was built for newer OSX version

2017-08-10 Thread Guru Hb
Hi Arun, Murali, Please review the fix for https://bugs.openjdk.java.net/browse/JDK-8186061 <https://bugs.openjdk.java.net/browse/JDK-8186061> webrev : http://cr.openjdk.java.net/~ghb/8186061/webrev.00/ <http://cr.openjdk.java.net/~ghb/8186061/webrev.00/> Thanks, Guru

[10] Review request for 8185970: Possible crash due to use-after-free

2017-08-08 Thread Murali Billa
  Hi, Please review the below fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8185970   Webrev: http://cr.openjdk.java.net/~mbilla/8185970/webrev.00/   Thanks, Murali

Re: [Review request] 8185767: Fix broken links in Javadocs

2017-08-08 Thread Jonathan Gibbons
I've scanned through it, and it looks generally OK to me. -- Jon On 08/03/2017 05:33 PM, Jonathan Giles wrote: Jon, Kevin and / or Phil, Please review the webrev below. It improves the JavaFX javadocs such that there are (hopefully) no bad links any longer. https://bugs.openjdk.jav

Review Request: JDK-8185954: Mac: JavaFx TextArea doesn't display the Emoji and Symbols on dropping them on the text area

2017-08-08 Thread Manajit Halder
Hi All, Kindly review the following JavaFx fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8185954 <https://bugs.openjdk.java.net/browse/JDK-8185954> Webrev: http://cr.openjdk.java.net/~mhalder/fx/8185954/webrev.02/ <http://cr.openjdk.java.net/~mhalder/fx/8185954/webrev.02/> No

[10] Review request for 8182977: NullPointerException with HTMLEditor when changing the scene graph

2017-08-07 Thread Murali Billa
  Hi, Please review the below simple fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8182977   Webrev: http://cr.openjdk.java.net/~mbilla/8182977/webrev.00/   Thanks, Murali

[10] Review request for 8183928: [Linux] Remove Warnings [-Wunused-parameter]

2017-08-07 Thread Murali Billa
  Hi, Please review the below simple fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8183928   Webrev: http://cr.openjdk.java.net/~mbilla/8183928/webrev.00/   Thanks, Murali

[10] Review request: 8185804: rpath is not set properly in OSX build

2017-08-07 Thread Arunprasad Rajkumar
Hi, Please review the simple fix for the following bug, https://bugs.openjdk.java.net/browse/JDK-8185804 Detailed analysis and fix is updated as JBS comment. Thanks, Arun

Review Request 8176813: Mac: Failure to exit full-screen programmatically in some cases

2017-08-03 Thread Avik Niyogi
Please review the webrev below which tries to fix the issue of GetApplication processed for Null values. Any alternatives or suggestions are welcome. This fixes the issue presented by the description. https://bugs.openjdk.java.net/browse/JDK-8176813 <https://bugs.openjdk.java.net/browse/

[Review request] 8185767: Fix broken links in Javadocs

2017-08-03 Thread Jonathan Giles
Jon, Kevin and / or Phil, Please review the webrev below. It improves the JavaFX javadocs such that there are (hopefully) no bad links any longer. https://bugs.openjdk.java.net/browse/JDK-8185767 http://cr.openjdk.java.net/~jgiles/8185767/ Thanks, -- -- Jonathan

Review request for : JDK-8092206 : TabPane renders content of all tabs even only one is active

2017-08-03 Thread Ambarish Rapte
Hi Kevin, Hi Jonathan, Request you to review the fix, Bug: https://bugs.openjdk.java.net/browse/JDK-8092206 Webrev: http://cr.openjdk.java.net/~arapte/fx/8092206/webrev.04/ Regards, Ambarish

[Review request] 8091673: Runtime should have a published focus traversal API for use in custom controls

2017-08-02 Thread Jonathan Giles
Kevin, Phil, Could you please review the webrev below, which aims to provide new public API for focus traversal in JavaFX. https://bugs.openjdk.java.net/browse/JDK-8091673 http://cr.openjdk.java.net/~jgiles/8091673.1 -- -- Jonathan

[Review request] 8178519: Consider removing two-level focus support from UI controls

2017-08-02 Thread Jonathan Giles
Kevin, Phil, Could you please review the webrev below, which aims to remove the unused two-level focus code that presently ships in JDK 9 and earlier releases. https://bugs.openjdk.java.net/browse/JDK-8178519 http://cr.openjdk.java.net/~jgiles/8178519/ Thanks, -- -- Jonathan

Review request for 8181930 : Adding a null icon to a Stage prevents application startup

2017-08-01 Thread Ambarish Rapte
Hi Chien, Hi Kevin, Request you to review the fix for JDK 10. Bug: https://bugs.openjdk.java.net/browse/JDK-8181930 Webrev: http://cr.openjdk.java.net/~arapte/fx/8181930/webrev.00/ Regards, Ambarish

[10] Review request for 8185691: MediaPlayer reports error with HTTP Live Streams instead of EOS

2017-08-01 Thread Alexander Matveev
Hi Kevin and David, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8185691 Fixed issue when error was send instead of EOS for HTTP Live Streaming. Thanks, Alexander

[10] Review request for 8183530: JavaFX charts peg rendering thread as more data is added

2017-07-31 Thread Jim Graham
JBS: https://bugs.openjdk.java.net/browse/JDK-8183530 webrev: http://cr.openjdk.java.net/~flar/JDK-8183530/webrev.03/ ...jim

[10] Review request for 8184453: [Win] DRT crashes for imported/blink/fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html

2017-07-30 Thread Murali Billa
  Hi, Please review the below fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8184453 Webrev: http://cr.openjdk.java.net/~mbilla/8184453/webrev.00/ Thanks, Murali

Review request for JDK-8130904: disabled tabs in a inner tabpane show like enabled

2017-07-30 Thread Ambarish Rapte
Hi Jonathan, Hi Ajit, Request you to review this fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8130904 Webrev: http://cr.openjdk.java.net/~arapte/fx/8130904/webrev.00/ Regards, Ambarish

[10] Review request: 8148265: Deprecate Java Packager Arguments

2017-07-28 Thread victor . drozdov
Chris, Please review my changes about deprecating -createbss and -createjar. JIRA: https://bugs.openjdk.java.net/browse/JDK-8148265 Webrev:http://cr.openjdk.java.net/~vdrozdov/JDK-8148265/webrev.00/ --Victor

[10] Review request: 8184448: Crash while loading gif images with more frames

2017-07-28 Thread Arunprasad Rajkumar
Hi, Please review the following changset, Webrev: http://cr.openjdk.java.net/~arajkumar/8184448/webrev.01 Bug: https://bugs.openjdk.java.net/browse/JDK-8184448 Detailed analysis is updated as JBS comment. Thanks, Arun

[10] Review request: 8185132: window.requestAnimationFrame API is not working

2017-07-27 Thread Arunprasad Rajkumar
Hi, Please review the following changset, Webrev: http://cr.openjdk.java.net/~arajkumar/8185132/webrev Bug: https://bugs.openjdk.java.net/browse/JDK-8185132 Detailed analysis is updated as JBS comment. Thanks, Arun

[10] Review request for 8185138: Build hangs and fills up disk on Windows with VS 2013 or 2010

2017-07-25 Thread Murali Billa
  Hi Kevin, Arun, Please review the below simple fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8185138 Webrev: http://cr.openjdk.java.net/~mbilla/8185138/webrev.00/   Thanks, Murali

[10] Review request: 8183292: Update to 604.1 version of WebKit

2017-07-21 Thread Arunprasad Rajkumar
/main/native", it will be useful only for review. 2. rt.changeset.gz — Actual changeset file in compressed format which contains all the changes from “rt” directory, uncompress before using it(gunzip rt.changeset.gz) and do the following steps. $ cd rt $ hg import --no-commit rt.change

[10] Review request: 8184996: Add single instance swing app for ant version

2017-07-20 Thread victor . drozdov
Chris, Please review my changes about adding single instance swing app for ant version JIRA: https://bugs.openjdk.java.net/browse/JDK-8184996 Webrev:http://cr.openjdk.java.net/~vdrozdov/JDK-8184996/webrev.00/ <http://cr.openjdk.java.net/%7Evdrozdov/JDK-8184996/webrev.00/> --Victor

Re: [10] Review request: 8185017 Fix Bad Characters

2017-07-20 Thread Philip Race
+1 Although I am puzzled why I did not hit this before. -phil. On 7/20/17, 4:34 PM, Chris Bensen wrote: Phil, Please review this fix to remove the bad characters. JIRA: https://bugs.openjdk.java.net/browse/JDK-8185017 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8185017/webrev.00/ Chris

[10] Review request: 8185017 Fix Bad Characters

2017-07-20 Thread Chris Bensen
Phil, Please review this fix to remove the bad characters. JIRA: https://bugs.openjdk.java.net/browse/JDK-8185017 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8185017/webrev.00/ Chris

[10] request for review 8181779: Memory leak in FX Glass Embedded Window

2017-07-19 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8181779/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8181779 -- Thanks, Alexander.

[10] Review request: 8184688: Single Instance Example

2017-07-18 Thread victor . drozdov
Chris, Please review my changes about adding single instance example. JIRA: https://bugs.openjdk.java.net/browse/JDK-8184688 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8184688/webrev.00/ --Victor

[10] Review request: 8184797: Copy DumpRenderTreeJava.dll from bin to lib directory

2017-07-18 Thread Guru Hb
Hi Arun & Murali, Please review the fix for: JBS : https://bugs.openjdk.java.net/browse/JDK-8184797 <https://bugs.openjdk.java.net/browse/JDK-8184797> Webrev : http://cr.openjdk.java.net/~ghb/8184797/webrev.00/ <http://cr.openjdk.java.net/~ghb/8184797/webrev.00/> Thanks, Guru

[10] Review request: 8184769 Static Link to SHGetKnownFolderPath

2017-07-17 Thread Chris Bensen
Victor, Please review this change to remove the LoadLibray. JIRA: https://bugs.openjdk.java.net/browse/JDK-8184769 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8184769/webrev.00/ Chris

[10] Review request: 8183240: Copy Icon to App Image

2017-07-17 Thread victor . drozdov
Chris, Please review my changes about copying icon to app image. JIRA: https://bugs.openjdk.java.net/browse/JDK-8183240 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8183240/webrev.00/ --Victor

[10] Review request: 8184301: Add new projects for jdk.packager.services and jdk.packager

2017-07-12 Thread victor . drozdov
Chris, Please review my changes about adding new projects for jdk.packager.services and jdk.packager JIRA: https://bugs.openjdk.java.net/browse/JDK-8184301 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8184301/webrev.00 --Victor

[10] Review request: 8184077: Resolve Singleton TODO

2017-07-11 Thread victor . drozdov
Chris, Please review my changes about removing getSessionSpecificString() JIRA: https://bugs.openjdk.java.net/browse/JDK-8184077 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8184077/webrev.0/ --Victor

Review request for : JDK-8092206 : TabPane renders content of all tabs even only one is active

2017-07-10 Thread Ambarish Rapte
Hi Jonathan, Please review the below fix, Bug: https://bugs.openjdk.java.net/browse/JDK-8092206 Webrev: http://cr.openjdk.java.net/~arapte/fx/8092206/webrev.00/ Regards, Ambarish

[10] Review request: 8183246 Remove Platform::GetSystemJRE()

2017-07-07 Thread Chris Bensen
Victor, Please review this change to remove the dead code related to acquiring the system JRE for a packaged app. JIRA: https://bugs.openjdk.java.net/browse/JDK-8183246 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8183246/webrev.00/ Chris

[10] Review request : JDK-8177636 : Reduce frequency of CSS resetting properties temporarily to initial state

2017-07-06 Thread Ajit Ghaisas
Hi Jonathan, Request you to review following change : Issue : https://bugs.openjdk.java.net/browse/JDK-8177636 Fix : http://cr.openjdk.java.net/~aghaisas/fx/e8177636/webrev.1/ Regards, Ajit

[10] Review request: 8181291: Singleton for javapackager

2017-07-05 Thread victor . drozdov
Kevin, Chris, Please review my changes about Single Instance for Java Packager (compared to previous webrev, the code was modified according to CSR JDK-8181293) JIRA: https://bugs.openjdk.java.net/browse/JDK-8181291 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8175574/webrev.06

[10] Review request: 8182615: Check registry paths

2017-06-30 Thread victor . drozdov
Chris, Please review my changes about correcting registry paths JIRA: https://bugs.openjdk.java.net/browse/JDK-8182615 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8182615/webrev.00/ --Victor

[10] Review request: 8091418 Evaluate TODOs in code, either removing or filing issues as appropriate

2017-06-30 Thread Chris Bensen
Victor, Please review these changes related to the TODOs and FIXMEs in the java packager code. JIRA: https://bugs.openjdk.java.net/browse/JDK-8091418 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8091418/webrev.00/ Chris

Re: Review Request: JDK-8176319: [macosx] problems with Character Viewer

2017-06-30 Thread Manajit Halder
Hi All, Please review the modified fix which is more efficient than the initial fix: http://cr.openjdk.java.net/~mhalder/fx/8176319/webrev.01/ <http://cr.openjdk.java.net/~mhalder/fx/8176319/webrev.01/> Regards, Manajit > On 30-Jun-2017, at 3:13 PM, Manajit Halder wrote: &g

Review Request: JDK-8176319: [macosx] problems with Character Viewer

2017-06-30 Thread Manajit Halder
Hi All, Kindly review the following JavaFx fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8176319 <https://bugs.openjdk.java.net/browse/JDK-8176319> Webrev: http://cr.openjdk.java.net/~mhalder/fx/8176319/webrev.00/ <http://cr.openjdk.java.net/~mhalder/fx/8176319/webrev.00/&

[10] Review request: 8178360: Build and integrate ICU from source

2017-06-29 Thread Guru Hb
Hi Kevin, Arun and Murali, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JDK-8178360 <https://bugs.openjdk.java.net/browse/JDK-8178360> Webrev : http://cr.openjdk.java.net/~ghb/8178360/webrev.07 <http://cr.openjdk.java.net/~ghb/8178360/webrev.07> (Modified S

[10] Review request: 8182778 Debug JDK Additions

2017-06-26 Thread Chris Bensen
Kevin, Victor, Please review these additions to the Java Packager debug JDK. This change will bundle the jdk.packager.services module with the resulting application and cleans up the gradle sourceSet. JIRA: https://bugs.openjdk.java.net/browse/JDK-8182778 Webrev: http://cr.openjdk.java.net

[10] Review Request : JDK-8167139 Menu's selection disappears on collapsing

2017-06-22 Thread Prem Balakrishnan
Hi Jonathan, Request you to review following fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8167139 Webrev: http://cr.openjdk.java.net/~pkbalakr/fx/8167139/webrev.00/ Regards, Prem

[10] Review Request: JDK-8179399 - Call trim() when loaded jre.list (Vivek Rao)

2017-06-21 Thread Vivek Rao
Hi, Chris, Victor, Please review the following change for fixing the “stripComments” method for redistributableModules. Bug URL: https://bugs.openjdk.java.net/browse/JDK-8179399 <https://bugs.openjdk.java.net/browse/JDK-8179399> Webrev: http://cr.openjdk.java.net/~vrao/JDK-8179399/

[10] Review request: JDK-8182564 Create a Debug JDK for Unit Tests

2017-06-20 Thread Chris Bensen
Kevin, Victor, Please review this change for unit tests to create a debug JDK. It’s a little odd. It only works in a bash shell because java and javac are copied to java.original and javac.original and replaced with bash scripts which always supply the --upgrade-module-path containing the

[10] Review request: JDK-8181738 Remove com.sun.tools.jdeps to jdk.packager

2017-06-15 Thread Chris Bensen
Kevin, Victor, Please review this change following JDK-8179445 to remove the qualified exports of com.sun.tools.jdeps: <https://bugs.openjdk.java.net/browse/JDK-8179445> JIRA: https://bugs.openjdk.java.net/browse/JDK-JDK-8181738 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-JDK-8181738/

Re: [9] Review request: 8180338: Additional HTML5 cleanup

2017-06-12 Thread Kevin Rushforth
e outdated "faq.html" is removed. http://cr.openjdk.java.net/~kcr/8180338/webrev.02/ -- Kevin Kevin Rushforth wrote: Hi Jon, Can you review this simple change to the three .html files (other than package.html) in the FX docs? https://bugs.openjdk.java.net/browse/JDK-8180338 http://cr.o

[10] Review request: JDK-8181976 - Specifying desired dimensions for Image with HiDPI (@2x) variant gets the size wrong

2017-06-12 Thread Jim Graham
JBS: https://bugs.openjdk.java.net/browse/JDK-8181976 webrev: http://cr.openjdk.java.net/~flar/JDK-8181976/webrev.00/ Simple fix is to carry the double "size requested" values all the way down to where the image pixel scale is determined (not strictly required, but important for precision) and t

[10] Review request: JDK-8179445: Use jdeps ToolProvider

2017-06-09 Thread victor . drozdov
Chris, Kevin Please review my changes about jdeps ToolProvider JIRA: https://bugs.openjdk.java.net/browse/JDK-8179445 Webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8179445/webrev.00/ --Victor

[9] Review request: 8181829: Broken link to css reference guide in Background documentation

2017-06-09 Thread Kevin Rushforth
Phil or Jonathan, Please review the simple fix for a broken javadoc link: https://bugs.openjdk.java.net/browse/JDK-8181829 The diff for the proposed fix, which is also in JBS, is: diff --git a/modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java b/modules

[9] Review request: 8181828: Broken Image link in documentation for Tangent interpolator

2017-06-09 Thread Kevin Rushforth
Jim or Phil, Please review the simple fix to move tangent_interpolator.png to the correct module. https://bugs.openjdk.java.net/browse/JDK-8181828 The diff for the proposed fix, which is also in JBS, is

[10] Review request: 8177696 contents of javapackager -help needs to be updated

2017-06-08 Thread Chris Bensen
Kevin, Victor, Please review JIRA: https://bugs.openjdk.java.net/browse/JDK-8177696 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8177696/webrev.02/ Chris

[10] Review request: JDK-8167209 Menu bar is not selected by right ALT key

2017-06-07 Thread Prem Balakrishnan
Hi Jonathan, Request you to review following fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8167209 Webrev: http://cr.openjdk.java.net/~pkbalakr/fx/8167209/webrev.00/ Regards, Prem

[10] Review request: JDK-8087978 : ProgressIndicator text disappears when using a larger font

2017-06-06 Thread Ajit Ghaisas
Hi Jonathan, Request you to review following fix : Bug : https://bugs.openjdk.java.net/browse/JDK-8087978 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8087978/webrev.1/ Regards, Ajit

[10] Review request for 8089283 : Padding property of the select tag is incorrect in WebView

2017-06-06 Thread Dipak Kumar
Hi Kevin, Please review the proposed fix: Webrev : http://cr.openjdk.java.net/~asrivastava/dipak/8089283/webrev.00/ JBS : https://bugs.openjdk.java.net/browse/JDK-8089283 DRT and unit test cases are running fine with this change. Many thanks, Dipak

[10] Review request for 8181476 [macos] Stages with StageStyle.UTILITY are always on-top when initialized without an owner

2017-06-06 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8181476/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8181476 -- Thanks, Alexander.

[10] Review request for 8172847 [macos] If you hit the escape key repeatedly to close the subwindow, the process crashes

2017-06-05 Thread Alexander Zvegintsev
Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8172847/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8172847 -- Thanks, Alexander.

[Review request] 8181169: Block comments mistakenly used in place of missing javadoc comments

2017-06-05 Thread Jonathan Giles
Kevin, Could you please review the javadoc fix here: https://bugs.openjdk.java.net/browse/JDK-8181169 http://cr.openjdk.java.net/~jgiles/8181169/index.html Thanks -- -- Jonathan

Review request : JDK-8181213 : [Tab] Tab content is not disabled when tab is disabled before content is set

2017-05-30 Thread Ambarish Rapte
Hi Jonathan & Ajit, Request you to review the fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8181213 Webrev: http://cr.openjdk.java.net/~arapte/fx/8181213/webrev.00/ Regards, Ambarish

[10] Review request: JDK-8088389 : [CSS, HighContrast] Menu - All the menu items look disabled on Mouse Click / Roll Over

2017-05-29 Thread Prem Balakrishnan
Hi Jonathan, Request you to review following fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8088389 Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epkbalakr/fx/8088389/webrev.00/"http://cr.openjdk.java.net/~pkbalakr/fx/8088389/webrev.00/ Regards, Prem

[10] Review request : JDK-8089310 : [ContextMenu] Disabled Menu Rollover never receives Mouse hover

2017-05-29 Thread Ajit Ghaisas
Hi Jonathan, Request you to review following fix : Bug : https://bugs.openjdk.java.net/browse/JDK-8089310 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8089310/webrev.0/ Regards, Ajit

[9] Review request: 8179644: Update copyright header for files modified in 2017

2017-05-25 Thread Kevin Rushforth
Hi Chien, Please review the following simple fix to update the copyright header dates: https://bugs.openjdk.java.net/browse/JDK-8179644 http://cr.openjdk.java.net/~kcr/8179644/webrev/ Thanks. -- Kevin

[9] Review request: 8180338: Additional HTML5 cleanup

2017-05-23 Thread Kevin Rushforth
Hi Jon, Can you review this simple change to the three .html files (other than package.html) in the FX docs? https://bugs.openjdk.java.net/browse/JDK-8180338 http://cr.openjdk.java.net/~kcr/8180338/webrev.00/ Thanks. -- Kevin

[9] Review request: 8180070: Fix additional typos in API docs

2017-05-23 Thread Kevin Rushforth
Jonathan, Please review the following fixes to various typos in the javadoc-generated API docs: https://bugs.openjdk.java.net/browse/JDK-8180070 http://cr.openjdk.java.net/~kcr/8180070/webrev.00/ Thanks. -- Kevin

[9] Review request: JDK-8180368: javapackager.exe fails to launch: Unrecognized option: -m

2017-05-22 Thread victor . drozdov
Kevin, Please review my changes about removing the code that constructs java cmd based on JAVA_HOME. JIRA: https://bugs.openjdk.java.net/browse/JDK-8180368 Webrev: webrev: http://cr.openjdk.java.net/~vdrozdov/JDK-8180368/webrev.00/ --Victor

[9] Review request: 8180064: Add missing copyright headers to package.html files

2017-05-16 Thread Kevin Rushforth
Jonathan, Please review the following simple fix to add proper copyright headers to each package.html file and also the three other .html files in our doc-files directories: https://bugs.openjdk.java.net/browse/JDK-8180064 http://cr.openjdk.java.net/~kcr/8180064/webrev/ Thanks. -- Kevin

Re: [8] Code Review Request For 8180180: [Mac] WebView renders icons instead of letters on some sites

2017-05-15 Thread Kevin Rushforth
Hi Dipak, Since this is the backport for JDK-8088205 the review should ideally be in a folder with that bug ID. Note that the commit message *must* use the base bugID and *never* the backport ID. Nothing should ever reference the backport ID, and the only thing that would go into the JBS

<    1   2   3   4   5   6   7   8   9   10   >