Re: [pgadmin-hackers] PATCH: FTS configuration node

2016-05-18 Thread Sanket Mehta
Hi, PFA the revised patch. Response is lnline. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Tue, May 17, 2016 at 12:54 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Sanket, > > Please find my review comments below: > > 1. In create mode it generates wrong sql.

Re: [pgadmin-hackers] PATCH: FTS configuration node

2016-05-18 Thread Ashesh Vashi
On Wed, May 18, 2016 at 12:41 PM, Sanket Mehta < sanket.me...@enterprisedb.com> wrote: > Hi, > > PFA the revised patch. > Response is lnline. > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Tue, May 17, 2016 at 12:54 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com>

Re: [pgadmin-hackers] PATCH: FTS configuration node

2016-05-18 Thread Sanket Mehta
On Wed, May 18, 2016 at 12:42 PM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Wed, May 18, 2016 at 12:41 PM, Sanket Mehta < > sanket.me...@enterprisedb.com> wrote: > >> Hi, >> >> PFA the revised patch. >> Response is lnline. >> >> Regards, >> Sanket Mehta >> Sr Software engineer >> E

Re: [pgadmin-hackers] PATCH: FTS configuration node

2016-05-18 Thread Ashesh Vashi
On Wed, May 18, 2016 at 12:52 PM, Sanket Mehta < sanket.me...@enterprisedb.com> wrote: > > On Wed, May 18, 2016 at 12:42 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Wed, May 18, 2016 at 12:41 PM, Sanket Mehta < >> sanket.me...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-18 Thread Harshal Dhumal
Hi, PFA patch for table node (version 8.1). apply this patch on version 7 patch. Not all issue are fixed in this patch. Murtuza will be sending version 8.2 witch will have resolution for remaining issues. Apply version 8.2 patch on version 8.1 -- *Harshal Dhumal* *Software Engineer * Eenterpr

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-18 Thread Murtuza Zabuawala
Hi, PFA table add-on patch version 8.2 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, May 18, 2016 at 2:42 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA patch for table node (version 8.1). apply this

Re: [pgadmin-hackers] PATCH: CREATE Script Initial patch (pgAdmin4)

2016-05-18 Thread Murtuza Zabuawala
Hi, PFA patch to add CREATE Script functionality for foreign tables objects which will also have INSERT/UPDATE/DELETE scripts instead of CREATE/SELECT only. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, May 17, 2016 at 2:54 PM

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-18 Thread Murtuza Zabuawala
Hi, PFA table add-on patch version 8.3. (apply after 8.2) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, May 18, 2016 at 3:20 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA table add-on patch v

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-05-18 Thread Sandeep Thakkar
Okay, so the patch needs a little change because of the change in the versioning for pgAdmin. Will update it. Paresh, please take a note of it. On Tue, May 17, 2016 at 4:24 PM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Hi Dave > > I have fixed the issues. Attached is the updat

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-18 Thread Murtuza Zabuawala
Hi, PFA table add-on patch version 8.4. (apply after 8.3) This includes changes for trigger node issues. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, May 18, 2016 at 4:19 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.

Re: [pgadmin-hackers] Patch for pgAdmin4 package on Mac OS X

2016-05-18 Thread Sandeep Thakkar
So, this means, the installer name would be pgadmin4-1.0-dev.exe on Windows and so on for other platforms? Also, the installation would go in $installdir/pgadmin4/1/ ? and the Revision change would update the installation? and the Release change will stay side-by-side? On Wed, May 18, 2016 at 4:2

[pgadmin-hackers] pgAdmin 4 commit: Updated index page.

2016-05-18 Thread Dave Page
Updated index page. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7d43a810e6e30a14bb3aa7337e82919f7e1592a Author: Susan Douglas Modified Files -- docs/en_US/index.rst | 241 +++ 1 f

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-18 Thread Surinder Kumar
Hi, Please find add-on patch for Column node. Issue fixed: 1. Column node, 'Primary key' switch should be hidden under view node, refer column node visible condition for table node 2. 'Inherited from' column should be hidden. 2. Other columns except Default value should be disabled. On Wed, M

[pgadmin-hackers] [pgAdmin4][Patch]: SQL Auto completion feature for Query Tool

2016-05-18 Thread Akshay Joshi
Hi All I have implemented the sql auto complete feature for Query Tool in pgAdmin4. To achieve this I have analyzed the code of "*pgcli (*http://pgcli .com/)" and also used some part of the code "(https://github.com/dbcli/pgcli *)*" with our own modification. "pgcli" buffers all the data(databas

Re: [pgadmin-hackers] [pgAdmin4][Patch]: SQL Auto completion feature for Query Tool

2016-05-18 Thread Akshay Joshi
Just to update Multi line support is not there right now. On Wed, May 18, 2016 at 8:09 PM, Akshay Joshi wrote: > Hi All > > I have implemented the sql auto complete feature for Query Tool in > pgAdmin4. To achieve this I have analyzed the code of "*pgcli (*http:// > pgcli.com/)" and also used so

Re: [pgadmin-hackers] Stalled post to pgadmin-hackers

2016-05-18 Thread Murtuza Zabuawala
Hi, Last few comments for VIEW & MATERIALIZED VIEW, rest of functionality looks good. I did not review Rules node as it’s still in development. 1) Comments is not working in VIEW 2) Set current parent schema as default schema in VIEW & MATERIALIZED VIEW when we open CREATE dialog 2) MATERIA

[pgadmin-hackers] pgAdmin 4 commit: Try a doc theme that looks more like pgAdmin.

2016-05-18 Thread Dave Page
Try a doc theme that looks more like pgAdmin. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=574f81f9fa6f9b1e1ac984b4d0944d9802fdef9c Modified Files -- docs/en_US/conf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- S