Hi Dave,
PFA patch for Package and Synonym nodes. There was some modifications done
in synonyms API cases, so adding with Package patch.
*Run test suite by following command:*
python runtests.py
--
Best,
Priyanka
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
diff --git a/web/pga
Hi
*Following are the issues fixed in nodes:*
1) If we create/update a node with non-default schema, It should return
selected schema id in return response. but default schema id is returned
every time due to which it throws error in properties panel.
Fixed in Domains, Collation, Types, Views & T
Hi
While clicking on Select2 control, it tries to destroy the control and thus
it doesn't get this object sometimes and throws error.
It should attempt to destroy the select2 object only if this object is not
undefined.
Adds proper check to handle the case.
Please find minor patch and review.
T
Hi
*Issue fixed:*
While renaming a object, the name must be enclosed within double quotes
using qtIdent.
Please find attached patch and review.
Thanks
Surinder Kumar
RM1857.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make chang
Hi
Implemented *node method *which returns *Synonym properties* while
refreshing node.
Please find attached patch and review.
Thanks,
Surinder Kumar
RM1845.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscri
Hi All
Please find the attached patch to fix the RM #1847 SQL script generated by
pgAdmin 4 to create table has errors.
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
RM_1847.patch
Description: Binary data
--
Sent via pgadmin-hackers ma
Hi,
Please find the attached patch to fix the below 2 bugs.
RM 1603: [Web Based] Export database failed if object contains double
quotes.
RM 1220: Backup database is not working with special characters
The issues which were fixed:
1. Client side data were not unescaped
2. Required command line
Hi,
The fix does not include a special case when database name has an equal to
(=) character in it.
Thanks,
Khushboo
On Fri, Oct 14, 2016 at 6:58 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached patch to fix the below 2 bugs.
>
> RM 1603: [Web Base
Hi
*Issue:*
If synonym name contains special characters, the request url is be '404 not
found'.
i.e. It doesn't hit at 'sql' method of synonym.
*Solution:*
If URL has an identifier containing slash character '/' into the URI, then
set param type to path.
like /.
Because if param name contains '/'
Hi
On Thursday, October 13, 2016, Ashesh Vashi
wrote:
> Hi Dave,
>
> On Tue, Oct 11, 2016 at 9:10 PM, Dave Page > wrote:
>
>> Hi Ashesh,
>>
>> Can you please review the attached patch, and apply if you're happy with
>> it?
>>
> Overall the patch looked good to me.
> But - I encounter an issue i
Add terst cases for packages, and update Synonym cases for recent API changes.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=22dadacb0ff2be4dbe2e648d651aff3b2c92b6bc
Author: Priyanka Shendge
Modified Files
--
.../databases/schema
Thanks, applied.
On Friday, October 14, 2016, Priyanka Shendge <
priyanka.shen...@enterprisedb.com> wrote:
> Hi Dave,
>
> PFA patch for Package and Synonym nodes. There was some modifications done
> in synonyms API cases, so adding with Package patch.
>
> *Run test suite by following command:*
>
Add test cases for tables, types, views and their children.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=404d4efd2efdcffc8a0c6c0bba1d6760db69c381
Author: Navnath Gadakh
Modified Files
--
.../servers/databases/schemas/__init__.py
Thanks, applied.
On Friday, October 14, 2016, Navnath Gadakh
wrote:
> Hi Dave,
> Please find the patch for API test cases of Tables and sub-nodes, types,
> views and materialized views.
>
> To run the test suite, use:
>
>python runtests.py
>
> Thanks.
>
> --
> Regards,
> Navnath Ga
Thanks, applied.
On Friday, October 14, 2016, Surinder Kumar
wrote:
> Hi
>
> *Following are the issues fixed in nodes:*
>
> 1) If we create/update a node with non-default schema, It should return
> selected schema id in return response. but default schema id is returned
> every time due to which
Resolve issue with properties refreshing. Fixes #1728
1) If we create/update a node with non-default schema, It should return
selected schema id in return response. but default schema id is returned every
time due to which it throws error in properties panel.
Fixed in Domains, Collation, Types,
While clicking on Select2 control, it tries to destroy the control and thus it
doesn't get this object sometimes and throws error.
It should attempt to destroy the select2 object only if this object is not
undefined.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadm
Thanks, applied.
On Friday, October 14, 2016, Surinder Kumar
wrote:
> Hi
>
> While clicking on Select2 control, it tries to destroy the control and
> thus it doesn't get this object sometimes and throws error.
>
> It should attempt to destroy the select2 object only if this object is not
> undef
Thanks, applied.
On Friday, October 14, 2016, Surinder Kumar
wrote:
> Hi
>
> *Issue fixed:*
>
> While renaming a object, the name must be enclosed within double quotes
> using qtIdent.
>
> Please find attached patch and review.
>
> Thanks
> Surinder Kumar
>
--
Dave Page
Blog: http://pgsnake.b
Properly quote names when renaming FTS dictionaries and templates. Fixes #1857
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=17bd379cb6767e68f88ada15743b544d64f498ef
Author: Surinder Kumar
Modified Files
--
.../fts_dictionaries/t
Allow refreshing of synonym nodes. Fixes #1845
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7520cf86d5820d99a2c506b10dec3e9fb010d5b
Author: Surinder Kumar
Modified Files
--
.../servers/databases/schemas/synonyms/__init__.py | 4
Thanks, patch applied.
On Friday, October 14, 2016, Surinder Kumar
wrote:
> Hi
>
> Implemented *node method *which returns *Synonym properties* while
> refreshing node.
>
> Please find attached patch and review.
>
> Thanks,
> Surinder Kumar
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twi
Thanks, patch applied.
On Friday, October 14, 2016, Akshay Joshi
wrote:
> Hi All
>
> Please find the attached patch to fix the RM #1847 SQL script generated by
> pgAdmin 4 to create table has errors.
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517Mobil
Identify the collation correctly when reverse engineering table SQL. Fixes #1847
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2d39b5fb412b896c02ccd812661d9920711f05de
Author: Akshay Joshi
Modified Files
--
.../columns/templates/
Handle reverse engineering of synonyms with / in the name. Fixes #1622
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dd6a69d8453183e54d82032a79cbccb78bfa4a9c
Author: Surinder Kumar
Modified Files
--
.../server_groups/servers/data
Thanks, patch applied.
On Friday, October 14, 2016, Surinder Kumar
wrote:
> Hi
>
> *Issue:*
> If synonym name contains special characters, the request url is be '404
> not found'.
> i.e. It doesn't hit at 'sql' method of synonym.
>
> *Solution:*
> If URL has an identifier containing slash charac
Hi
On Friday, October 14, 2016, Khushboo Vashi
wrote:
> Hi,
>
> Please find the attached patch to fix the below 2 bugs.
>
> RM 1603: [Web Based] Export database failed if object contains double
> quotes.
> RM 1220: Backup database is not working with special characters
>
> The issues which were
On Friday, October 14, 2016, Dave Page wrote:
> Hi
>
> On Friday, October 14, 2016, Khushboo Vashi com >
> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix the below 2 bugs.
>>
>> RM 1603: [Web Based] Export database failed if object contains double
>> quotes.
>> RM 1220: Backup datab
Include wait information on the activity tab of the dashboards. Fixes #1859
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=faf517e12bf1f0558360c77e8fcc7f365617a128
Modified Files
--
web/pgadmin/dashboard/__init__.py
Cleanup the dashboard tables a little for readability
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d0a9b25c57da2993df0777a22705ae03ec0ff294
Modified Files
--
.../dashboard/templates/dashboard/js/dashboard.js | 50 +--
Hi
On Friday, October 14, 2016, Dave Page wrote:
> Hi
>
> On Thursday, October 13, 2016, Ashesh Vashi > wrote:
>
>> Hi Dave,
>>
>> On Tue, Oct 11, 2016 at 9:10 PM, Dave Page wrote:
>>
>>> Hi Ashesh,
>>>
>>> Can you please review the attached patch, and apply if you're happy with
>>> it?
>>>
>>
On Sat, Oct 15, 2016 at 4:59 AM, Dave Page wrote:
> Hi
>
> On Friday, October 14, 2016, Khushboo Vashi com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix the below 2 bugs.
>>
>> RM 1603: [Web Based] Export database failed if object contains double
>> quotes.
>> RM 1220: Backup data
On Friday, October 14, 2016, Ashesh Vashi
wrote:
> On Sat, Oct 15, 2016 at 4:59 AM, Dave Page > wrote:
>
>> Hi
>>
>> On Friday, October 14, 2016, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com
>> > wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch to fix the below 2 bugs.
>>>
>>> RM
33 matches
Mail list logo
