Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass

2023-07-02 Thread Michael Paquier
On Sun, Jul 02, 2023 at 08:25:34AM +, Tomas Vondra wrote: > Introduce bloom_filter_size for BRIN bloom opclass > > Move the calculation of Bloom filter parameters (for BRIN indexes) into > a separate function to make reuse easier. At the moment we only call it > from one place, but that may ch

pgsql: Introduce long options in pg_archivecleanup

2023-06-29 Thread Michael Paquier
/--strip-extension Author: Atsushi Torikoshi Reviewed-by: Fujii Masao, Kyotaro Horiguchi, Michael Paquier Discussion: https://postgr.es/m/d660ef741ce3d82f3b4283f1cafd5...@oss.nttdata.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Fix marking of indisvalid for partitioned indexes at creation

2023-06-29 Thread Michael Paquier
Fix marking of indisvalid for partitioned indexes at creation The logic that introduced partitioned indexes missed a few things when invalidating a partitioned index when these are created, still the code is written to handle recursions: 1) If created from scratch because a mapping index could not

pgsql: Fix marking of indisvalid for partitioned indexes at creation

2023-06-29 Thread Michael Paquier
Fix marking of indisvalid for partitioned indexes at creation The logic that introduced partitioned indexes missed a few things when invalidating a partitioned index when these are created, still the code is written to handle recursions: 1) If created from scratch because a mapping index could not

pgsql: Fix marking of indisvalid for partitioned indexes at creation

2023-06-29 Thread Michael Paquier
Fix marking of indisvalid for partitioned indexes at creation The logic that introduced partitioned indexes missed a few things when invalidating a partitioned index when these are created, still the code is written to handle recursions: 1) If created from scratch because a mapping index could not

pgsql: Fix marking of indisvalid for partitioned indexes at creation

2023-06-29 Thread Michael Paquier
Fix marking of indisvalid for partitioned indexes at creation The logic that introduced partitioned indexes missed a few things when invalidating a partitioned index when these are created, still the code is written to handle recursions: 1) If created from scratch because a mapping index could not

pgsql: Fix marking of indisvalid for partitioned indexes at creation

2023-06-29 Thread Michael Paquier
Fix marking of indisvalid for partitioned indexes at creation The logic that introduced partitioned indexes missed a few things when invalidating a partitioned index when these are created, still the code is written to handle recursions: 1) If created from scratch because a mapping index could not

pgsql: Fix marking of indisvalid for partitioned indexes at creation

2023-06-29 Thread Michael Paquier
Fix marking of indisvalid for partitioned indexes at creation The logic that introduced partitioned indexes missed a few things when invalidating a partitioned index when these are created, still the code is written to handle recursions: 1) If created from scratch because a mapping index could not

pgsql: Fix marking of indisvalid for partitioned indexes at creation

2023-06-29 Thread Michael Paquier
Fix marking of indisvalid for partitioned indexes at creation The logic that introduced partitioned indexes missed a few things when invalidating a partitioned index when these are created, still the code is written to handle recursions: 1) If created from scratch because a mapping index could not

pgsql: Add tab completion for CREATE SCHEMA in psql

2023-06-29 Thread Michael Paquier
supported in an embedded CREATE SCHEMA command. While on it, this commit adjusts the completion done after CREATE UNLOGGED: - Addition of SEQUENCE. - Avoid suggesting MATERIALIZED VIEW in CREATE TABLE. Author: Dagfinn Ilmari Mannsåker Reviewed-by: Suraj Khamkar, Michael Paquier Discussion: https

pgsql: Use named captures in Catalog::ParseHeader()

2023-06-29 Thread Michael Paquier
Use named captures in Catalog::ParseHeader() Using at least perl 5.14 is required since 4c15327, meaning that it is possible to use named captures and the %+ hash instead of having to count parenthesis groups manually. While on it, CATALOG is made more flexible in its handling of whitespaces for

pgsql: Fix pg_depend entry to AMs after ALTER TABLE .. SET ACCESS METHO

2023-06-29 Thread Michael Paquier
Fix pg_depend entry to AMs after ALTER TABLE .. SET ACCESS METHOD ALTER TABLE .. SET ACCESS METHOD was not registering a dependency to the new access method with the relation altered in its rewrite phase, making possible the drop of an access method even if there are relations that depend on it.

pgsql: Fix pg_depend entry to AMs after ALTER TABLE .. SET ACCESS METHO

2023-06-29 Thread Michael Paquier
Fix pg_depend entry to AMs after ALTER TABLE .. SET ACCESS METHOD ALTER TABLE .. SET ACCESS METHOD was not registering a dependency to the new access method with the relation altered in its rewrite phase, making possible the drop of an access method even if there are relations that depend on it.

pgsql: pg_stat_statements: Fix second comment related to entry resets

2023-06-28 Thread Michael Paquier
pg_stat_statements: Fix second comment related to entry resets This should have been part of dc73db6, but it got lost in the mix. Oversight in 6b4d23f. Author: Japin Li Discussion: https://postgr.es/m/meyp282mb1669fc91c764e277821936d3b6...@meyp282mb1669.ausp282.prod.outlook.com Backpatch-through

pgsql: pg_stat_statements: Fix second comment related to entry resets

2023-06-28 Thread Michael Paquier
pg_stat_statements: Fix second comment related to entry resets This should have been part of dc73db6, but it got lost in the mix. Oversight in 6b4d23f. Author: Japin Li Discussion: https://postgr.es/m/meyp282mb1669fc91c764e277821936d3b6...@meyp282mb1669.ausp282.prod.outlook.com Backpatch-through

pgsql: pg_stat_statements: Fix second comment related to entry resets

2023-06-28 Thread Michael Paquier
pg_stat_statements: Fix second comment related to entry resets This should have been part of dc73db6, but it got lost in the mix. Oversight in 6b4d23f. Author: Japin Li Discussion: https://postgr.es/m/meyp282mb1669fc91c764e277821936d3b6...@meyp282mb1669.ausp282.prod.outlook.com Backpatch-through

pgsql: pg_stat_statements: Fix incorrect comment with entry resets

2023-06-28 Thread Michael Paquier
pg_stat_statements: Fix incorrect comment with entry resets Oversight in 6b4d23f. Author: Japin Li, Richard Guo Discussion: https://postgr.es/m/meyp282mb1669fc91c764e277821936d3b6...@meyp282mb1669.ausp282.prod.outlook.com Backpatch-through: 14 Branch -- REL_15_STABLE Details --- https:

pgsql: pg_stat_statements: Fix incorrect comment with entry resets

2023-06-28 Thread Michael Paquier
pg_stat_statements: Fix incorrect comment with entry resets Oversight in 6b4d23f. Author: Japin Li, Richard Guo Discussion: https://postgr.es/m/meyp282mb1669fc91c764e277821936d3b6...@meyp282mb1669.ausp282.prod.outlook.com Backpatch-through: 14 Branch -- master Details --- https://git.p

pgsql: pg_stat_statements: Fix incorrect comment with entry resets

2023-06-28 Thread Michael Paquier
pg_stat_statements: Fix incorrect comment with entry resets Oversight in 6b4d23f. Author: Japin Li, Richard Guo Discussion: https://postgr.es/m/meyp282mb1669fc91c764e277821936d3b6...@meyp282mb1669.ausp282.prod.outlook.com Backpatch-through: 14 Branch -- REL_14_STABLE Details --- https:

pgsql: Add timeline ID to file names generated with pg_waldump --save-f

2023-06-28 Thread Michael Paquier
Add timeline ID to file names generated with pg_waldump --save-fullpage Not including the timeline IDs to the file names generated by pg_waldump for the individual blocks saved could cause some of these files to be overwritten when scanning segments across multiple timelines. Having this informat

pgsql: Ignore invalid indexes when enforcing index rules in ALTER TABLE

2023-06-28 Thread Michael Paquier
Ignore invalid indexes when enforcing index rules in ALTER TABLE ATTACH PARTITION A portion of ALTER TABLE .. ATTACH PARTITION is to ensure that the partition being attached to the partitioned table has a correct set of indexes, so as there is a consistent index mapping between the partitioned ta

pgsql: Ignore invalid indexes when enforcing index rules in ALTER TABLE

2023-06-28 Thread Michael Paquier
Ignore invalid indexes when enforcing index rules in ALTER TABLE ATTACH PARTITION A portion of ALTER TABLE .. ATTACH PARTITION is to ensure that the partition being attached to the partitioned table has a correct set of indexes, so as there is a consistent index mapping between the partitioned ta

pgsql: Ignore invalid indexes when enforcing index rules in ALTER TABLE

2023-06-28 Thread Michael Paquier
Ignore invalid indexes when enforcing index rules in ALTER TABLE ATTACH PARTITION A portion of ALTER TABLE .. ATTACH PARTITION is to ensure that the partition being attached to the partitioned table has a correct set of indexes, so as there is a consistent index mapping between the partitioned ta

pgsql: Ignore invalid indexes when enforcing index rules in ALTER TABLE

2023-06-28 Thread Michael Paquier
Ignore invalid indexes when enforcing index rules in ALTER TABLE ATTACH PARTITION A portion of ALTER TABLE .. ATTACH PARTITION is to ensure that the partition being attached to the partitioned table has a correct set of indexes, so as there is a consistent index mapping between the partitioned ta

pgsql: Ignore invalid indexes when enforcing index rules in ALTER TABLE

2023-06-28 Thread Michael Paquier
Ignore invalid indexes when enforcing index rules in ALTER TABLE ATTACH PARTITION A portion of ALTER TABLE .. ATTACH PARTITION is to ensure that the partition being attached to the partitioned table has a correct set of indexes, so as there is a consistent index mapping between the partitioned ta

pgsql: Ignore invalid indexes when enforcing index rules in ALTER TABLE

2023-06-28 Thread Michael Paquier
Ignore invalid indexes when enforcing index rules in ALTER TABLE ATTACH PARTITION A portion of ALTER TABLE .. ATTACH PARTITION is to ensure that the partition being attached to the partitioned table has a correct set of indexes, so as there is a consistent index mapping between the partitioned ta

pgsql: Remove dependency to query text in JumbleQuery()

2023-06-27 Thread Michael Paquier
Remove dependency to query text in JumbleQuery() Since 3db72eb, the query ID of utilities is generated using the Query structure, making the use of the query string in JumbleQuery() unnecessary. This commit removes the argument "querytext" from JumbleQuery(). Reported-by: Joe Conway Reviewed-by:

pgsql: Define OPENSSL_API_COMPAT

2023-06-24 Thread Michael Paquier
Define OPENSSL_API_COMPAT This avoids deprecation warnings from newer OpenSSL versions (3.0.0 in particular). This has been originally applied as 4d3db13 for v14 and newer versions, but not on the older branches out of caution, and this commit closes the gap to remove all these deprecation warnin

pgsql: Define OPENSSL_API_COMPAT

2023-06-24 Thread Michael Paquier
Define OPENSSL_API_COMPAT This avoids deprecation warnings from newer OpenSSL versions (3.0.0 in particular). This has been originally applied as 4d3db13 for v14 and newer versions, but not on the older branches out of caution, and this commit closes the gap to remove all these deprecation warnin

pgsql: Define OPENSSL_API_COMPAT

2023-06-24 Thread Michael Paquier
Define OPENSSL_API_COMPAT This avoids deprecation warnings from newer OpenSSL versions (3.0.0 in particular). This has been originally applied as 4d3db13 for v14 and newer versions, but not on the older branches out of caution, and this commit closes the gap to remove all these deprecation warnin

pgsql: Fix incorrect error message in libpq_pipeline

2023-06-23 Thread Michael Paquier
Fix incorrect error message in libpq_pipeline One of the tests for the pipeline mode with portal description expects a non-NULL PQgetResult, but used an incorrect error message on failure, telling that PQgetResult being NULL was the expected result. Author: Jelte Fennema Discussion: https://post

pgsql: Fix incorrect error message in libpq_pipeline

2023-06-23 Thread Michael Paquier
Fix incorrect error message in libpq_pipeline One of the tests for the pipeline mode with portal description expects a non-NULL PQgetResult, but used an incorrect error message on failure, telling that PQgetResult being NULL was the expected result. Author: Jelte Fennema Discussion: https://post

pgsql: Fix incorrect error message in libpq_pipeline

2023-06-23 Thread Michael Paquier
Fix incorrect error message in libpq_pipeline One of the tests for the pipeline mode with portal description expects a non-NULL PQgetResult, but used an incorrect error message on failure, telling that PQgetResult being NULL was the expected result. Author: Jelte Fennema Discussion: https://post

pgsql: Disable use of archiving in 009_twophase.pl

2023-06-21 Thread Michael Paquier
Disable use of archiving in 009_twophase.pl This partially reverts 68cb5af, as using archiving to enforce the rename of the last partial segment of the old timeline at promotion to use .partial as suffix is impacting the tests when it does switchovers. As showed by the logs gathered by the CI in t

pgsql: Disable use of archiving in 009_twophase.pl

2023-06-21 Thread Michael Paquier
Disable use of archiving in 009_twophase.pl This partially reverts 68cb5af, as using archiving to enforce the rename of the last partial segment of the old timeline at promotion to use .partial as suffix is impacting the tests when it does switchovers. As showed by the logs gathered by the CI in t

pgsql: Disable use of archiving in 009_twophase.pl

2023-06-21 Thread Michael Paquier
Disable use of archiving in 009_twophase.pl This partially reverts 68cb5af, as using archiving to enforce the rename of the last partial segment of the old timeline at promotion to use .partial as suffix is impacting the tests when it does switchovers. As showed by the logs gathered by the CI in t

pgsql: Disable use of archiving in 009_twophase.pl

2023-06-21 Thread Michael Paquier
Disable use of archiving in 009_twophase.pl This partially reverts 68cb5af, as using archiving to enforce the rename of the last partial segment of the old timeline at promotion to use .partial as suffix is impacting the tests when it does switchovers. As showed by the logs gathered by the CI in t

pgsql: Enable archiving in recovery TAP test 009_twophase.pl

2023-06-19 Thread Michael Paquier
HEAD did not show the problematic behavior, still missed coverage for it. While on it, this adds a comment about the dependency of the last partial segment rename and RecoverPreparedTransactions() at the end of recovery, as that can be easy to miss. Author: Michael Paquier Reviewed-by: Kyotaro

pgsql: Enable archiving in recovery TAP test 009_twophase.pl

2023-06-19 Thread Michael Paquier
HEAD did not show the problematic behavior, still missed coverage for it. While on it, this adds a comment about the dependency of the last partial segment rename and RecoverPreparedTransactions() at the end of recovery, as that can be easy to miss. Author: Michael Paquier Reviewed-by: Kyotaro

pgsql: Enable archiving in recovery TAP test 009_twophase.pl

2023-06-19 Thread Michael Paquier
HEAD did not show the problematic behavior, still missed coverage for it. While on it, this adds a comment about the dependency of the last partial segment rename and RecoverPreparedTransactions() at the end of recovery, as that can be easy to miss. Author: Michael Paquier Reviewed-by: Kyotaro

pgsql: Enable archiving in recovery TAP test 009_twophase.pl

2023-06-19 Thread Michael Paquier
HEAD did not show the problematic behavior, still missed coverage for it. While on it, this adds a comment about the dependency of the last partial segment rename and RecoverPreparedTransactions() at the end of recovery, as that can be easy to miss. Author: Michael Paquier Reviewed-by: Kyotaro

pgsql: Fix failure at promotion with 2PC transactions and archiving ena

2023-06-19 Thread Michael Paquier
does not impact the test coverage as restore_command would remain unused. This is something that should be changed on v15 and HEAD as well, so this will be changed in a separate commit for clarity. Author: Julian Markwort Reviewed-by: Kyotaro Horiguchi, Michael Paquier Discussion: http

pgsql: Fix failure at promotion with 2PC transactions and archiving ena

2023-06-19 Thread Michael Paquier
does not impact the test coverage as restore_command would remain unused. This is something that should be changed on v15 and HEAD as well, so this will be changed in a separate commit for clarity. Author: Julian Markwort Reviewed-by: Kyotaro Horiguchi, Michael Paquier Discussion: http

pgsql: Add missing subscription TAP test for meson

2023-06-15 Thread Michael Paquier
Add missing subscription TAP test for meson 033_run_as_table_owner was missing from the list of subscription tests to run under meson, so add it. Oversight in 4826759. Author: Hayato Kuroda Discussion: https://postgr.es/m/tyapr01mb58668f4d85a9a122a158f442f5...@tyapr01mb5866.jpnprd01.prod.outloo

pgsql: intarray: Prevent out-of-bound memory reads with gist__int_ops

2023-06-14 Thread Michael Paquier
one wishes to use more array items, gist__intbig_ops is an optional choice. While on it, use ERRCODE_PROGRAM_LIMIT_EXCEEDED as error code when a limit is reached, because that's what the module is facing in such cases. Author: Ankit Kumar Pandey, Alexander Lakhin Reviewed-by: Richard Guo, Mi

pgsql: intarray: Prevent out-of-bound memory reads with gist__int_ops

2023-06-14 Thread Michael Paquier
one wishes to use more array items, gist__intbig_ops is an optional choice. While on it, use ERRCODE_PROGRAM_LIMIT_EXCEEDED as error code when a limit is reached, because that's what the module is facing in such cases. Author: Ankit Kumar Pandey, Alexander Lakhin Reviewed-by: Richard Guo, Mi

pgsql: intarray: Prevent out-of-bound memory reads with gist__int_ops

2023-06-14 Thread Michael Paquier
one wishes to use more array items, gist__intbig_ops is an optional choice. While on it, use ERRCODE_PROGRAM_LIMIT_EXCEEDED as error code when a limit is reached, because that's what the module is facing in such cases. Author: Ankit Kumar Pandey, Alexander Lakhin Reviewed-by: Richard Guo, Mi

pgsql: intarray: Prevent out-of-bound memory reads with gist__int_ops

2023-06-14 Thread Michael Paquier
one wishes to use more array items, gist__intbig_ops is an optional choice. While on it, use ERRCODE_PROGRAM_LIMIT_EXCEEDED as error code when a limit is reached, because that's what the module is facing in such cases. Author: Ankit Kumar Pandey, Alexander Lakhin Reviewed-by: Richard Guo, Mi

pgsql: intarray: Prevent out-of-bound memory reads with gist__int_ops

2023-06-14 Thread Michael Paquier
one wishes to use more array items, gist__intbig_ops is an optional choice. While on it, use ERRCODE_PROGRAM_LIMIT_EXCEEDED as error code when a limit is reached, because that's what the module is facing in such cases. Author: Ankit Kumar Pandey, Alexander Lakhin Reviewed-by: Richard Guo, Mi

pgsql: intarray: Prevent out-of-bound memory reads with gist__int_ops

2023-06-14 Thread Michael Paquier
one wishes to use more array items, gist__intbig_ops is an optional choice. While on it, use ERRCODE_PROGRAM_LIMIT_EXCEEDED as error code when a limit is reached, because that's what the module is facing in such cases. Author: Ankit Kumar Pandey, Alexander Lakhin Reviewed-by: Richard Guo, Mi

pgsql: Fix instability in regression test for Parallel Hash Full Join

2023-06-11 Thread Michael Paquier
Fix instability in regression test for Parallel Hash Full Join As reported by buildfarm member conchuela, one of the regression tests added by 558c9d7 is having some ordering issues. This commit adds an ORDER BY clause to make the output more stable for the problematic query. Fix suggested by To

pgsql: hstore: Tighten key/value parsing check for whitespaces

2023-06-11 Thread Michael Paquier
hstore: Tighten key/value parsing check for whitespaces isspace() can be locale-sensitive depending on the platform, causing hstore to consider as whitespaces characters it should not see as such. For example, U+0105, being decoded as 0xC4 0x85 in UTF-8, would be discarded from the input given. T

pgsql: hstore: Tighten key/value parsing check for whitespaces

2023-06-11 Thread Michael Paquier
hstore: Tighten key/value parsing check for whitespaces isspace() can be locale-sensitive depending on the platform, causing hstore to consider as whitespaces characters it should not see as such. For example, U+0105, being decoded as 0xC4 0x85 in UTF-8, would be discarded from the input given. T

pgsql: hstore: Tighten key/value parsing check for whitespaces

2023-06-11 Thread Michael Paquier
hstore: Tighten key/value parsing check for whitespaces isspace() can be locale-sensitive depending on the platform, causing hstore to consider as whitespaces characters it should not see as such. For example, U+0105, being decoded as 0xC4 0x85 in UTF-8, would be discarded from the input given. T

pgsql: hstore: Tighten key/value parsing check for whitespaces

2023-06-11 Thread Michael Paquier
hstore: Tighten key/value parsing check for whitespaces isspace() can be locale-sensitive depending on the platform, causing hstore to consider as whitespaces characters it should not see as such. For example, U+0105, being decoded as 0xC4 0x85 in UTF-8, would be discarded from the input given. T

pgsql: hstore: Tighten key/value parsing check for whitespaces

2023-06-11 Thread Michael Paquier
hstore: Tighten key/value parsing check for whitespaces isspace() can be locale-sensitive depending on the platform, causing hstore to consider as whitespaces characters it should not see as such. For example, U+0105, being decoded as 0xC4 0x85 in UTF-8, would be discarded from the input given. T

pgsql: hstore: Tighten key/value parsing check for whitespaces

2023-06-11 Thread Michael Paquier
hstore: Tighten key/value parsing check for whitespaces isspace() can be locale-sensitive depending on the platform, causing hstore to consider as whitespaces characters it should not see as such. For example, U+0105, being decoded as 0xC4 0x85 in UTF-8, would be discarded from the input given. T

pgsql: Fix missing initializations of MyProc.delayChkptEnd

2023-06-10 Thread Michael Paquier
issue affects v11~v14, but not v15~, as we use a single field called delayChkptFlags to delay checkpoints there. Author: suyu.cmj (mengjuan@alibaba-inc.com) Reviewed-by: Kyotaro Horiguchi, Michael Paquier Discussion: https://postgr.es/m/9c3d2a49-db5f-43cb-840b-d58f9a684295.mengjuan@alibaba

pgsql: Fix missing initializations of MyProc.delayChkptEnd

2023-06-10 Thread Michael Paquier
issue affects v11~v14, but not v15~, as we use a single field called delayChkptFlags to delay checkpoints there. Author: suyu.cmj (mengjuan@alibaba-inc.com) Reviewed-by: Kyotaro Horiguchi, Michael Paquier Discussion: https://postgr.es/m/9c3d2a49-db5f-43cb-840b-d58f9a684295.mengjuan@alibaba

pgsql: Fix missing initializations of MyProc.delayChkptEnd

2023-06-10 Thread Michael Paquier
issue affects v11~v14, but not v15~, as we use a single field called delayChkptFlags to delay checkpoints there. Author: suyu.cmj (mengjuan@alibaba-inc.com) Reviewed-by: Kyotaro Horiguchi, Michael Paquier Discussion: https://postgr.es/m/9c3d2a49-db5f-43cb-840b-d58f9a684295.mengjuan@alibaba

pgsql: Fix missing initializations of MyProc.delayChkptEnd

2023-06-10 Thread Michael Paquier
issue affects v11~v14, but not v15~, as we use a single field called delayChkptFlags to delay checkpoints there. Author: suyu.cmj (mengjuan@alibaba-inc.com) Reviewed-by: Kyotaro Horiguchi, Michael Paquier Discussion: https://postgr.es/m/9c3d2a49-db5f-43cb-840b-d58f9a684295.mengjuan@alibaba

pgsql: Refactor routine to find single log content pattern in TAP tests

2023-06-08 Thread Michael Paquier
C Reviewed-by: Andrew Dunstan, Dagfinn Ilmari Mannsåker, Michael Paquier Discussion: https://postgr.es/m/caldanm0ysilpjcmajwlfidqrforlnkpqir7s__pevvh9u3u...@mail.gmail.com Backpatch-through: 11 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Refactor routine to find single log content pattern in TAP tests

2023-06-08 Thread Michael Paquier
C Reviewed-by: Andrew Dunstan, Dagfinn Ilmari Mannsåker, Michael Paquier Discussion: https://postgr.es/m/caldanm0ysilpjcmajwlfidqrforlnkpqir7s__pevvh9u3u...@mail.gmail.com Backpatch-through: 11 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Refactor routine to find single log content pattern in TAP tests

2023-06-08 Thread Michael Paquier
C Reviewed-by: Andrew Dunstan, Dagfinn Ilmari Mannsåker, Michael Paquier Discussion: https://postgr.es/m/caldanm0ysilpjcmajwlfidqrforlnkpqir7s__pevvh9u3u...@mail.gmail.com Backpatch-through: 11 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Refactor routine to find single log content pattern in TAP tests

2023-06-08 Thread Michael Paquier
C Reviewed-by: Andrew Dunstan, Dagfinn Ilmari Mannsåker, Michael Paquier Discussion: https://postgr.es/m/caldanm0ysilpjcmajwlfidqrforlnkpqir7s__pevvh9u3u...@mail.gmail.com Backpatch-through: 11 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Refactor routine to find single log content pattern in TAP tests

2023-06-08 Thread Michael Paquier
C Reviewed-by: Andrew Dunstan, Dagfinn Ilmari Mannsåker, Michael Paquier Discussion: https://postgr.es/m/caldanm0ysilpjcmajwlfidqrforlnkpqir7s__pevvh9u3u...@mail.gmail.com Backpatch-through: 11 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Refactor routine to find single log content pattern in TAP tests

2023-06-08 Thread Michael Paquier
C Reviewed-by: Andrew Dunstan, Dagfinn Ilmari Mannsåker, Michael Paquier Discussion: https://postgr.es/m/caldanm0ysilpjcmajwlfidqrforlnkpqir7s__pevvh9u3u...@mail.gmail.com Backpatch-through: 11 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Refactor log check logic for connect_ok/fails in PostgreSQL::Tes

2023-06-08 Thread Michael Paquier
while discussing the refactoring of find_in_log(). Backpatch down to 14 where these routines are used, to ease the introduction of new tests that could rely on them. Author: Vignesh C, Michael Paquier Discussion: https://postgr.es/m/caldanm0ysilpjcmajwlfidqrforlnkpqir7s__pevvh9u3u

pgsql: Refactor log check logic for connect_ok/fails in PostgreSQL::Tes

2023-06-08 Thread Michael Paquier
while discussing the refactoring of find_in_log(). Backpatch down to 14 where these routines are used, to ease the introduction of new tests that could rely on them. Author: Vignesh C, Michael Paquier Discussion: https://postgr.es/m/caldanm0ysilpjcmajwlfidqrforlnkpqir7s__pevvh9u3u

pgsql: Refactor log check logic for connect_ok/fails in PostgreSQL::Tes

2023-06-08 Thread Michael Paquier
while discussing the refactoring of find_in_log(). Backpatch down to 14 where these routines are used, to ease the introduction of new tests that could rely on them. Author: Vignesh C, Michael Paquier Discussion: https://postgr.es/m/caldanm0ysilpjcmajwlfidqrforlnkpqir7s__pevvh9u3u

pgsql: doc: Add note to prevent server spoofing with SCRAM

2023-06-03 Thread Michael Paquier
doc: Add note to prevent server spoofing with SCRAM The set of recommendations added in the documentation with this commit helps in avoiding SCRAM exchanges with untrusted servers. Author: Jacob Champion, Jonathan Katz Reviewed-by: Stephen Frost, Daniel Gustafsson, Michael Paquier Discussion

pgsql: Fix typo in TAP tests of vacuumdb

2023-05-25 Thread Michael Paquier
Fix typo in TAP tests of vacuumdb Noticed while scanning the area, introduced in 582edc3. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ecb968e7e3da69a39d3efab69fa63fe6c8d04b5f Modified Files -- src/bin/scripts/t/100_vacuumdb.pl | 2 +- 1 file changed,

pgsql: pageinspect: Fix gist_page_items() with included columns

2023-05-18 Thread Michael Paquier
r the output results generated on HEAD and v15, so adjust it on these branches. Author: Alexander Lakhin, Michael Paquier Discussion: https://postgr.es/m/17884-cb8c326522977...@postgresql.org Backpatch-through: 14 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commi

pgsql: pageinspect: Fix gist_page_items() with included columns

2023-05-18 Thread Michael Paquier
r the output results generated on HEAD and v15, so adjust it on these branches. Author: Alexander Lakhin, Michael Paquier Discussion: https://postgr.es/m/17884-cb8c326522977...@postgresql.org Backpatch-through: 14 Branch -- master Details --- https://git.postgresql.org/pg/commi

pgsql: pageinspect: Fix gist_page_items() with included columns

2023-05-18 Thread Michael Paquier
r the output results generated on HEAD and v15, so adjust it on these branches. Author: Alexander Lakhin, Michael Paquier Discussion: https://postgr.es/m/17884-cb8c326522977...@postgresql.org Backpatch-through: 14 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commi

pgsql: Add back SQLValueFunction for SQL keywords

2023-05-16 Thread Michael Paquier
Add back SQLValueFunction for SQL keywords This is equivalent to a revert of f193883 and fb32748, with the addition that the declaration of the SQLValueFunction node needs to gain a couple of node_attr for query jumbling. The performance impact of removing the function call inlining is proving to

pgsql: doc: Fix ordering of entries in wait event table for I/O type

2023-05-16 Thread Michael Paquier
doc: Fix ordering of entries in wait event table for I/O type Issue spotted while reviewing a different patch touching this area. Discussion: https://postgr.es/m/zgm1u5d5eubub...@paquier.xyz Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/44e977d7ecb915d1181007e700

pgsql: doc: Fix incorrect version list for Windows SDK

2023-05-15 Thread Michael Paquier
doc: Fix incorrect version list for Windows SDK References to SDK 8.1a should have been cleaned up in 495ed0e, as only version 10 and above are supported with Windows 10 and newer versions. Reported-by: Thomas Munro Discussion: https://postgr.es/m/CA+hUKG++qE9uVjQaTTD7oaC8a2T3h8K50=eqyx9uuzvoha_

pgsql: Fix assertion failure when updating stats_fetch_consistency in a

2023-05-09 Thread Michael Paquier
Fix assertion failure when updating stats_fetch_consistency in a transaction An update of the GUC stats_fetch_consistency in a transaction would be able to trigger an assertion when doing cache->snapshot. In this case, when retrieving a pgstat entry after the switch, a new snapshot would be rebui

pgsql: Fix assertion failure when updating stats_fetch_consistency in a

2023-05-09 Thread Michael Paquier
Fix assertion failure when updating stats_fetch_consistency in a transaction An update of the GUC stats_fetch_consistency in a transaction would be able to trigger an assertion when doing cache->snapshot. In this case, when retrieving a pgstat entry after the switch, a new snapshot would be rebui

pgsql: Document values of stats_fetch_consistency in postgresql.conf.sa

2023-05-09 Thread Michael Paquier
Document values of stats_fetch_consistency in postgresql.conf.sample Issue noted while looking at a patch related to that. Discussion: https://postgr.es/m/ZE9LiFc7JdNHokz/@paquier.xyz Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4d47eff99cc08255f0ae3cc27dc24cc9b

pgsql: doc: Fix some markups in logical replication section

2023-05-07 Thread Michael Paquier
doc: Fix some markups in logical replication section Author: Peter Smith Reviewed-by: David Zhang Discussion: https://postgr.es/m/CAHut+Pst11ac2hcmePt1=oTmBwTT=DAssRR1nsdoy4BT+68=m...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0890f7d528c45bcfef

pgsql: Fix typo with wait event for SLRU buffer of commit timestamps

2023-05-05 Thread Michael Paquier
Fix typo with wait event for SLRU buffer of commit timestamps This wait event was documented as "CommitTsBuffer" since its introduction, but the code named it "CommitTSBuffer". This commit fixes the code to follow the term documented, which is also more consistent with the naming of the other wai

pgsql: Fix typo with wait event for SLRU buffer of commit timestamps

2023-05-05 Thread Michael Paquier
Fix typo with wait event for SLRU buffer of commit timestamps This wait event was documented as "CommitTsBuffer" since its introduction, but the code named it "CommitTSBuffer". This commit fixes the code to follow the term documented, which is also more consistent with the naming of the other wai

pgsql: Fix typo with wait event for SLRU buffer of commit timestamps

2023-05-05 Thread Michael Paquier
Fix typo with wait event for SLRU buffer of commit timestamps This wait event was documented as "CommitTsBuffer" since its introduction, but the code named it "CommitTSBuffer". This commit fixes the code to follow the term documented, which is also more consistent with the naming of the other wai

pgsql: Fix typo with wait event for SLRU buffer of commit timestamps

2023-05-05 Thread Michael Paquier
Fix typo with wait event for SLRU buffer of commit timestamps This wait event was documented as "CommitTsBuffer" since its introduction, but the code named it "CommitTSBuffer". This commit fixes the code to follow the term documented, which is also more consistent with the naming of the other wai

pgsql: Fix typos in comments

2023-05-01 Thread Michael Paquier
Fix typos in comments The changes done in this commit impact comments with no direct user-visible changes, with fixes for incorrect function, variable or structure names. Author: Alexander Lakhin Discussion: https://postgr.es/m/e8c38840-596a-83d6-bd8d-cebc5...@gmail.com Branch -- master

pgsql: doc: Fix typo in pg_amcheck for term "schema"

2023-05-01 Thread Michael Paquier
doc: Fix typo in pg_amcheck for term "schema" Author: Alexander Lakhin Discussion: https://postgr.es/m/e8c38840-596a-83d6-bd8d-cebc5...@gmail.com Backpatch-through: 14 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/43beaa2fb16b18d3ec0dc385688cff264f6b736

pgsql: doc: Fix typo in pg_amcheck for term "schema"

2023-05-01 Thread Michael Paquier
doc: Fix typo in pg_amcheck for term "schema" Author: Alexander Lakhin Discussion: https://postgr.es/m/e8c38840-596a-83d6-bd8d-cebc5...@gmail.com Backpatch-through: 14 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6fd8ae647da842ee4810fcd83b013cbed27f Modi

pgsql: doc: Fix typo in pg_amcheck for term "schema"

2023-05-01 Thread Michael Paquier
doc: Fix typo in pg_amcheck for term "schema" Author: Alexander Lakhin Discussion: https://postgr.es/m/e8c38840-596a-83d6-bd8d-cebc5...@gmail.com Backpatch-through: 14 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/77ea05406cb61292782eb874866247f20b47b6d

pgsql: Fix crashes with CREATE SCHEMA AUTHORIZATION and schema elements

2023-04-28 Thread Michael Paquier
l the versions supported. Reported-by: Song Hongyu Author: Michael Paquier Reviewed-by: Richard Guo Discussion: https://postgr.es/m/17909-f65c12dfc5f04...@postgresql.org Backpatch-through: 11 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commi

pgsql: Fix crashes with CREATE SCHEMA AUTHORIZATION and schema elements

2023-04-28 Thread Michael Paquier
l the versions supported. Reported-by: Song Hongyu Author: Michael Paquier Reviewed-by: Richard Guo Discussion: https://postgr.es/m/17909-f65c12dfc5f04...@postgresql.org Backpatch-through: 11 Branch -- master Details --- https://git.postgresql.org/pg/commi

pgsql: Fix crashes with CREATE SCHEMA AUTHORIZATION and schema elements

2023-04-28 Thread Michael Paquier
l the versions supported. Reported-by: Song Hongyu Author: Michael Paquier Reviewed-by: Richard Guo Discussion: https://postgr.es/m/17909-f65c12dfc5f04...@postgresql.org Backpatch-through: 11 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commi

pgsql: Fix crashes with CREATE SCHEMA AUTHORIZATION and schema elements

2023-04-28 Thread Michael Paquier
l the versions supported. Reported-by: Song Hongyu Author: Michael Paquier Reviewed-by: Richard Guo Discussion: https://postgr.es/m/17909-f65c12dfc5f04...@postgresql.org Backpatch-through: 11 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commi

pgsql: Fix crashes with CREATE SCHEMA AUTHORIZATION and schema elements

2023-04-28 Thread Michael Paquier
l the versions supported. Reported-by: Song Hongyu Author: Michael Paquier Reviewed-by: Richard Guo Discussion: https://postgr.es/m/17909-f65c12dfc5f04...@postgresql.org Backpatch-through: 11 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commi

pgsql: Fix crashes with CREATE SCHEMA AUTHORIZATION and schema elements

2023-04-28 Thread Michael Paquier
l the versions supported. Reported-by: Song Hongyu Author: Michael Paquier Reviewed-by: Richard Guo Discussion: https://postgr.es/m/17909-f65c12dfc5f04...@postgresql.org Backpatch-through: 11 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commi

pgsql: Rework code defining default compression for dir/custom formats

2023-04-26 Thread Michael Paquier
Rework code defining default compression for dir/custom formats in pg_dump As written, pg_dump would call twice parse_compress_specification() for the custom and directory formats to build a compression specification if no compression option is defined, as these formats should be compressed by def

pgsql: Re-add tracking of wait event SLRUFlushSync

2023-04-25 Thread Michael Paquier
Re-add tracking of wait event SLRUFlushSync SLRUFlushSync has been accidently removed during dee663f, that has moved the flush of the SLRU files to the checkpointer, so add it back. The issue has been noticed by Thomas when checking for orphaned wait events. Author: Thomas Munro Reviewed-by: Bha

pgsql: Re-add tracking of wait event SLRUFlushSync

2023-04-25 Thread Michael Paquier
Re-add tracking of wait event SLRUFlushSync SLRUFlushSync has been accidently removed during dee663f, that has moved the flush of the SLRU files to the checkpointer, so add it back. The issue has been noticed by Thomas when checking for orphaned wait events. Author: Thomas Munro Reviewed-by: Bha

pgsql: Re-add tracking of wait event SLRUFlushSync

2023-04-25 Thread Michael Paquier
Re-add tracking of wait event SLRUFlushSync SLRUFlushSync has been accidently removed during dee663f, that has moved the flush of the SLRU files to the checkpointer, so add it back. The issue has been noticed by Thomas when checking for orphaned wait events. Author: Thomas Munro Reviewed-by: Bha

<    3   4   5   6   7   8   9   10   11   12   >