Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Heikki Linnakangas
On 10/18/2016 12:28 AM, Tom Lane wrote: Heikki Linnakangas writes: Use OpenSSL EVP API for symmetric encryption in pgcrypto. BTW, "narwhal" seems to have a problem with this. Not very clear what, maybe an incompatibility with old openssl versions? Dave, what version of OpenSSL are 'narwhal'

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Dave Page
On Tue, Oct 18, 2016 at 9:10 AM, Heikki Linnakangas wrote: > On 10/18/2016 12:28 AM, Tom Lane wrote: >> >> Heikki Linnakangas writes: >>> >>> Use OpenSSL EVP API for symmetric encryption in pgcrypto. >> >> >> BTW, "narwhal" seems to have a problem with this. >> Not very clear what, maybe an incom

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Heikki Linnakangas
On 18 October 2016 12:52:14 EEST, Dave Page wrote: >On Tue, Oct 18, 2016 at 9:10 AM, Heikki Linnakangas >wrote: >> On 10/18/2016 12:28 AM, Tom Lane wrote: >>> >>> Heikki Linnakangas writes: Use OpenSSL EVP API for symmetric encryption in pgcrypto. >>> >>> >>> BTW, "narwhal" seems to

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Dave Page
On Tue, Oct 18, 2016 at 12:18 PM, Heikki Linnakangas wrote: > > > On 18 October 2016 12:52:14 EEST, Dave Page wrote: >>On Tue, Oct 18, 2016 at 9:10 AM, Heikki Linnakangas >>wrote: >>> On 10/18/2016 12:28 AM, Tom Lane wrote: Heikki Linnakangas writes: > > Use OpenSSL EVP API fo

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Tom Lane
Dave Page writes: > On Tue, Oct 18, 2016 at 12:18 PM, Heikki Linnakangas wrote: >> On 18 October 2016 12:52:14 EEST, Dave Page wrote: >>> Baiji: 0.9.8e >>> Narwhal: 0.9.6b >> Hang on, I removed support for OpenSSL < 0.9.8 a while ago. Narwhal >> shouldn't even compile with 0.9.6. > Oops, sorr

[COMMITTERS] pgsql: Revert "Replace PostmasterRandom() with a stronger way of genera

2016-10-18 Thread Heikki Linnakangas
Revert "Replace PostmasterRandom() with a stronger way of generating randomness." This reverts commit 9e083fd4683294f41544e6d0d72f6e258ff3a77c. That was a few bricks shy of a load: * Query cancel stopped working * Buildfarm member pademelon stopped working, because the box doesn't have /dev/ur

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Dave Page
On Tue, Oct 18, 2016 at 1:41 PM, Tom Lane wrote: > Dave Page writes: >> On Tue, Oct 18, 2016 at 12:18 PM, Heikki Linnakangas wrote: >>> On 18 October 2016 12:52:14 EEST, Dave Page wrote: Baiji: 0.9.8e Narwhal: 0.9.6b > >>> Hang on, I removed support for OpenSSL < 0.9.8 a while ago. Na

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Heikki Linnakangas
On 10/18/2016 04:32 PM, Dave Page wrote: On Tue, Oct 18, 2016 at 1:41 PM, Tom Lane wrote: Dave Page writes: On Tue, Oct 18, 2016 at 12:18 PM, Heikki Linnakangas wrote: On 18 October 2016 12:52:14 EEST, Dave Page wrote: Baiji: 0.9.8e Narwhal: 0.9.6b Hang on, I removed support for OpenSS

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Tom Lane
Dave Page writes: > On Tue, Oct 18, 2016 at 1:41 PM, Tom Lane wrote: >> Is it possible that there's a header-vs-executable version mismatch >> contributing to the problem here? (Although you'd think we'd have >> hit it before now, if so.) > We're not actually calling the openssl binary are we?

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Dave Page
On Tue, Oct 18, 2016 at 2:34 PM, Heikki Linnakangas wrote: > On 10/18/2016 04:32 PM, Dave Page wrote: >> >> On Tue, Oct 18, 2016 at 1:41 PM, Tom Lane wrote: >>> >>> Dave Page writes: On Tue, Oct 18, 2016 at 12:18 PM, Heikki Linnakangas wrote: > > On 18 October 2016 12:52:

[COMMITTERS] pgsql: Fix cidin() to handle values above 2^31 platform-independently.

2016-10-18 Thread Tom Lane
Fix cidin() to handle values above 2^31 platform-independently. CommandId is declared as uint32, and values up to 4G are indeed legal. cidout() handles them properly by treating the value as unsigned int. But cidin() was just using atoi(), which has platform-dependent behavior for values outside t

[COMMITTERS] pgsql: Fix cidin() to handle values above 2^31 platform-independently.

2016-10-18 Thread Tom Lane
Fix cidin() to handle values above 2^31 platform-independently. CommandId is declared as uint32, and values up to 4G are indeed legal. cidout() handles them properly by treating the value as unsigned int. But cidin() was just using atoi(), which has platform-dependent behavior for values outside t

[COMMITTERS] pgsql: Fix cidin() to handle values above 2^31 platform-independently.

2016-10-18 Thread Tom Lane
Fix cidin() to handle values above 2^31 platform-independently. CommandId is declared as uint32, and values up to 4G are indeed legal. cidout() handles them properly by treating the value as unsigned int. But cidin() was just using atoi(), which has platform-dependent behavior for values outside t

[COMMITTERS] pgsql: Fix cidin() to handle values above 2^31 platform-independently.

2016-10-18 Thread Tom Lane
Fix cidin() to handle values above 2^31 platform-independently. CommandId is declared as uint32, and values up to 4G are indeed legal. cidout() handles them properly by treating the value as unsigned int. But cidin() was just using atoi(), which has platform-dependent behavior for values outside t

[COMMITTERS] pgsql: Fix cidin() to handle values above 2^31 platform-independently.

2016-10-18 Thread Tom Lane
Fix cidin() to handle values above 2^31 platform-independently. CommandId is declared as uint32, and values up to 4G are indeed legal. cidout() handles them properly by treating the value as unsigned int. But cidin() was just using atoi(), which has platform-dependent behavior for values outside t

[COMMITTERS] pgsql: Fix cidin() to handle values above 2^31 platform-independently.

2016-10-18 Thread Tom Lane
Fix cidin() to handle values above 2^31 platform-independently. CommandId is declared as uint32, and values up to 4G are indeed legal. cidout() handles them properly by treating the value as unsigned int. But cidin() was just using atoi(), which has platform-dependent behavior for values outside t

[COMMITTERS] pgsql: Fix cidin() to handle values above 2^31 platform-independently.

2016-10-18 Thread Tom Lane
Fix cidin() to handle values above 2^31 platform-independently. CommandId is declared as uint32, and values up to 4G are indeed legal. cidout() handles them properly by treating the value as unsigned int. But cidin() was just using atoi(), which has platform-dependent behavior for values outside t

[COMMITTERS] pgsql: Fix typo in comment.

2016-10-18 Thread Robert Haas
Fix typo in comment. Amit Langote Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/fca41acb86902b90218dcc3bc0ffc462850a090f Modified Files -- src/include/foreign/foreign.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committer

[COMMITTERS] pgsql: Fix a few typos in simplehash.h.

2016-10-18 Thread Andres Freund
Fix a few typos in simplehash.h. Author: Erik Rijkers Discussion: <274e4c8ac545d6622735f97c1f6c3...@xs4all.nl> Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/90d3da11c9417218ebd4f86b2003c98421824712 Modified Files -- src/include/lib/simplehash.h | 8 +++

Re: [COMMITTERS] pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto.

2016-10-18 Thread Tom Lane
Dave Page writes: > On Tue, Oct 18, 2016 at 9:10 AM, Heikki Linnakangas wrote: >> Dave, what version of OpenSSL are 'narwhal' and 'baiji' using? I've tried to >> reproduce this on my laptop, by compiling different versions of OpenSSL, >> between 0.9.8beta1 and 0.9.8 head, but without success.. >

[COMMITTERS] pgsql: Improve regression test coverage for hash indexes.

2016-10-18 Thread Robert Haas
Improve regression test coverage for hash indexes. On my system, this improves coverage for src/backend/access/hash from 61.3% of lines to 88.2% of lines, and from 83.5% of functions to 97.5% of functions, which is pretty good for 36 lines of tests. Mithun Cy, reviewing by Amit Kapila and Álvaro