Re: [PATCHES] [pgsql-hackers-win32] explain analyze timings

2005-03-20 Thread Magnus Hagander
>> There is. I beleive QueryPerformanceCounter has sub-mirosecond >> resolution. > >> Can we just replace gettimeofday() with a version that's basically: > >No, because it's also used for actual time-of-day calls. It'd be >necessary to hack executor/instrument.c in particular. Here's a patch that

Re: [PATCHES] [pgsql-hackers-win32] explain analyze timings

2005-03-20 Thread Simon Riggs
On Sun, 2005-03-20 at 14:42 +0100, Magnus Hagander wrote: > >> There is. I beleive QueryPerformanceCounter has sub-mirosecond > >> resolution. > > > >> Can we just replace gettimeofday() with a version that's basically: > > > >No, because it's also used for actual time-of-day calls. It'd be > >nec

Re: [PATCHES] [pgsql-hackers-win32] explain analyze timings

2005-03-20 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > Here's a patch that does just this. This seems about the ugliest and most intrusive way you could have done it :-(. A judicious typedef and macro or two could eliminate most of the #ifdefs and code duplication, thereby preserving readability...

Re: [PATCHES] [pgsql-hackers-win32] explain analyze timings

2005-03-20 Thread Magnus Hagander
>> Here's a patch that does just this. > >This seems about the ugliest and most intrusive way you could have >done it :-(. A judicious typedef and macro or two could eliminate >most of the #ifdefs and code duplication, thereby preserving >readability... Well, I certainly can't argue with that, no

Re: [PATCHES] [pgsql-hackers-win32] explain analyze timings

2005-03-20 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > Here is a second attempt, hope it's closer to what you expected. Better --- patch applied with some minor editorialization. > I still left two #ifdefs in there, for the addition and subtraction of > timeval:s specifically. They could be made functio

Re: [PATCHES] [patch 0/6] pgcrypto update

2005-03-20 Thread Neil Conway
Marko Kreen wrote: Here are various updates for pgcrypto that I've been sitting on for some time now. I'll apply all these later today, barring any objections. -Neil ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister

Re: [PATCHES] PL/Python patch for Universal Newline Support

2005-03-20 Thread Neil Conway
Michael Fuhr wrote: Should the PL/Python documentation mention this behavior? Isn't this the behavior the user would expect? If so, I guess it's okay not to document it. How should I submit regression tests? Yes, please. *** src/pl/plpython/plpython.c 17 Dec 2004 02:14:48 - 1.58 --- src/pl/pl

Re: [PATCHES] HeapTupleSatisfiesUpdate result as enum

2005-03-20 Thread Neil Conway
Alvaro Herrera wrote: Is there any reason why HeapTupleSatisfiesUpdate return codes are not an enum, like they are for HeapTupleSatisfiesVacuum? Applied, thanks. -Neil ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an a

Re: [PATCHES] PL/Python patch for Universal Newline Support

2005-03-20 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Does this work for "\r\n" embedded in string literals? I believe we'd concluded that Python will unconditionally convert all \r\n to \n when reading any text file --- including script files --- and therefore that's what Python programmers will expect to ha

[PATCHES] fwd: libpq

2005-03-20 Thread Gabor Berenyi
My letter was rejected so I uploaded the attachement: http://school.tar.hu/maybe_a_dll_bug.zip Here is the letter itself: Now I send you [...] a bug report (maybe_a_dll_bug.zip). I think it's not a libpq.dll bug, but a related one at least. I would very much appreciate your help. maybe_a_dll_bug

Re: [PATCHES] [HACKERS] read-only database

2005-03-20 Thread Satoshi Nagayasu
Tom Lane wrote: > I'd view this as a postmaster state that propagates to backends. > Probably you'd enable it by means of a postmaster option, and the > only way to get out of it is to shut down and restart the postmaster > without the option. I've created a patch to make a p

Re: [PATCHES] [patch 0/6] pgcrypto update

2005-03-20 Thread Neil Conway
Marko Kreen wrote: Here are various updates for pgcrypto that I've been sitting on for some time now. Thanks, applied. -Neil ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's data

Re: [PATCHES] PL/Python patch for Universal Newline Support

2005-03-20 Thread Michael Fuhr
On Mon, Mar 21, 2005 at 10:28:28AM +1100, Neil Conway wrote: > Michael Fuhr wrote: > > >How should I submit regression tests? > > Yes, please. The operative word there was "how" :-) I don't see anything testing PL/{Python,Perl,Tcl} under src/test/regress -- should I put something there? Can re

Re: [PATCHES] PL/Python patch for Universal Newline Support

2005-03-20 Thread Tom Lane
Michael Fuhr <[EMAIL PROTECTED]> writes: > The operative word there was "how" :-) I don't see anything testing > PL/{Python,Perl,Tcl} under src/test/regress -- should I put something > there? No. The PLs have their own regression tests in their individual src/pl directories; feel free to hack on