Re: [PHP-DEV] SSL -> joining sockets and files

2001-03-01 Thread Wez Furlong
On 2001-03-01 05:14:18, Andi Gutmans <[EMAIL PROTECTED]> wrote: > This sounds pretty good. I'll try and look at the code this weekend. Some > of the code is really ugly especially the legacy code. > When you say there are places which need a FILE * do you mean they just > need to check the i

Re: [PHP-DEV] SSL -> joining sockets and files

2001-02-28 Thread Stig Venaas
On Thu, Mar 01, 2001 at 07:14:18AM +0200, Andi Gutmans wrote: > This sounds pretty good. I'll try and look at the code this weekend. Some > of the code is really ugly especially the legacy code. Yes, I like it too, and it is something I've been halfway thinking of myself because of IPv6. Some of

Re: [PHP-DEV] SSL -> joining sockets and files

2001-02-28 Thread Andi Gutmans
Too early in the morning. I just remembered fdopen() :) Andi At 07:14 AM 3/1/2001 +0200, Andi Gutmans wrote: >This sounds pretty good. I'll try and look at the code this weekend. Some >of the code is really ugly especially the legacy code. >When you say there are places which need a FILE * do y

Re: [PHP-DEV] SSL -> joining sockets and files

2001-02-28 Thread Andi Gutmans
This sounds pretty good. I'll try and look at the code this weekend. Some of the code is really ugly especially the legacy code. When you say there are places which need a FILE * do you mean they just need to check the id and check that it's a FILE * or do they convert descriptors to FILE * (ca

Re: [PHP-DEV] SSL -> joining sockets and files (resent)

2001-02-28 Thread Andi Gutmans
At 11:29 PM 2/28/2001 +, Wez Furlong wrote: >On 2001-02-28 20:51:18, Andi Gutmans <[EMAIL PROTECTED]> wrote: > > Doing some C OOP here would probably come in handy. Short incomplete > example: > > typedef union _io_abstraction { > > io_base base; > > socket_abstraction socke

Re: [PHP-DEV] SSL -> joining sockets and files

2001-02-28 Thread Wez Furlong
I've just looked through the code. The current issock stuff is a bit of a nightmare, but not too much of a problem. Most of the codebase seems to be fairly well behaved with FP_FGETS and friends (apart from the interbase extension, where it does the same thing as FP_FREAD without using FP_

Re: [PHP-DEV] SSL -> joining sockets and files (resent)

2001-02-28 Thread Wez Furlong
On 2001-02-28 20:51:18, Andi Gutmans <[EMAIL PROTECTED]> wrote: > Doing some C OOP here would probably come in handy. Short incomplete example: > typedef union _io_abstraction { > io_base base; > socket_abstraction socket; > ssl_abstraction ssl; > file_abstracti

Re: [PHP-DEV] SSL -> joining sockets and files (resent)

2001-02-28 Thread Andi Gutmans
Doing some C OOP here would probably come in handy. Short incomplete example: typedef struct _io_base { int (*write)(io_base *this_ptr, ); int (*read)(io_base *this_ptr,); int (*open)(io_base *this_ptr,); int (*close)(io_base *this_ptr,.); } io_b

Re: [PHP-DEV] SSL -> joining sockets and files (resent)

2001-02-28 Thread Stig Venaas
On Wed, Feb 28, 2001 at 05:12:55PM +, Wez Furlong wrote: > I think what we need depends on how far we are willing to go to make > the codebase nicer. Andi Gutmans suggested that it would be nice > to nuke all the checks for sockets in the code; depending on how far > we go towards that ideal,

[PHP-DEV] SSL -> joining sockets and files (resent)

2001-02-28 Thread Wez Furlong
Sorry - I've been having problems with my mail client; I have resent the message with sensible line breaks. On 2001-02-27 06:53:05, Stig Venaas wrote: > But with for instance IPv6, you won't know what socket you need until > you're done with the resolving. That's why hostconnect() is like it > i

Re: [PHP-DEV] SSL -> joining sockets and files ?

2001-02-27 Thread Wez Furlong
On 2001-02-27 06:53:05, Stig Venaas wrote: > But with for instance IPv6, you won't know what socket you need until > you're done with the resolving. That's why hostconnect() is like it > is. It even needs to connect before it knows what socket to use. That I must have missed hostconnect(). I Do