Re: [Piglit] [PATCH] Basic test that transform feedback works with geometry shaders.

2013-08-19 Thread Paul Berry
On 16 August 2013 11:57, Ian Romanick wrote: > Assuming we'll have tougher tests later, this test is > > Reviewed-by: Ian Romanick > > On side comment below... > > > On 08/07/2013 10:15 AM, Paul Berry wrote: > >> --- >> tests/all.tests| 2 + >> .../spec/e

Re: [Piglit] [PATCH v2] gs: Make texelFetch and textureSize tests use GLSL 1.50 for geometry shaders.

2013-08-19 Thread Paul Berry
On 16 August 2013 12:08, Ian Romanick wrote: > On 08/07/2013 12:09 PM, Paul Berry wrote: > >> Previously, these tests used ARB_geometry_shader4. However, the >> initial implementation of geometry shaders in Mesa isn't going to >> support ARB_geometry_shader4. So test this functionality using GL

Re: [Piglit] [PATCH] ARB_seamless_cube_map: test that sample from three faces returns value without border color

2013-08-19 Thread Paul Berry
On 15 August 2013 12:40, Steve Miller wrote: > add new test to existing arb_seamless_cube_map group: sample three > adjoining > faces and use average. if three faces are the same color, that color > must > be used. > add test to makelists and all.tests > --- > tests/all.tests

Re: [Piglit] [PATCH v3] GL 3.2: Test validity of GL_DEPTH_CLAMP state

2013-08-19 Thread Paul Berry
On 15 August 2013 15:12, Nicholas Mack wrote: > diff --git a/tests/spec/CMakeLists.txt b/tests/spec/CMakeLists.txt > index 96987cf..327780f 100644 > --- a/tests/spec/CMakeLists.txt > +++ b/tests/spec/CMakeLists.txt > @@ -1,6 +1,7 @@ > add_subdirectory (amd_performance_monitor) > add_subdirector

Re: [Piglit] [PATCH 1/2] glsl-1.40: Don't use embedded structure definitions

2013-08-19 Thread Paul Berry
On 16 August 2013 13:33, Ian Romanick wrote: > From: Ian Romanick > > NVIDIA's compiler (304.64 on a GTX 260) generates the error messages: > > 0(5) : error C7539: GLSL 1.20 does not allow nested structs > 0(9) : error C7539: GLSL 1.20 does not allow nested structs > > Our compiler was even gene

Re: [Piglit] [v9 01/13] glapi: fix parsing of extensions containing string "EGL_"

2013-08-19 Thread Chad Versace
On 08/09/2013 03:42 AM, Topi Pohjolainen wrote: Category for 'EGLImageTargetTexture2DOES' becomes 'GL_OES_EGL_image' instead of 'GL_OES_Eimage'. v2 (Chad): replace first occurence explicitly Signed-off-by: Topi Pohjolainen --- glapi/parse_glspec.py | 3 ++- 1 file changed, 2 insertions(+),

Re: [Piglit] [PATCH] arb_uniform_buffer_object: Add UBO from vs-struct-pad tests

2013-08-19 Thread Paul Berry
On 16 August 2013 22:03, Ian Romanick wrote: > On 08/16/2013 01:38 PM, Ian Romanick wrote: > >> From: Ian Romanick >> >> The vs-struct-pad and fs-struct-pad tests both fail on Mesa. The UBOs >> from those tests are added here to help narrow down the origin of the >> problem. >> >> This test pas

Re: [Piglit] [v9 02/13] framework: gl-profile style image probe for gles

2013-08-19 Thread Chad Versace
On 08/09/2013 03:42 AM, Topi Pohjolainen wrote: As GLES reads pixels as non-normalized integers compare the integers directly instead of transforming to floats first. Signed-off-by: Topi Pohjolainen --- tests/util/piglit-util-gl-common.h | 2 ++ tests/util/piglit-util-gles.c | 63 +

Re: [Piglit] [v9 09/13] tests/spec: EXT_image_dma_buf_import fd ownership transfer

2013-08-19 Thread Chad Versace
On 08/19/2013 10:45 AM, Chad Versace wrote: On 08/09/2013 03:43 AM, Topi Pohjolainen wrote: Simple test checking that EGL closes the export file handle and the creator can in turn drop its reference. v2: - compile only on platforms that have drm (Eric) - use standard drm definitions for

Re: [Piglit] [v9 09/13] tests/spec: EXT_image_dma_buf_import fd ownership transfer

2013-08-19 Thread Chad Versace
On 08/19/2013 10:45 AM, Chad Versace wrote: On 08/09/2013 03:43 AM, Topi Pohjolainen wrote: Simple test checking that EGL closes the export file handle and the creator can in turn drop its reference. v2: - compile only on platforms that have drm (Eric) - use standard drm definitions for

Re: [Piglit] [v9 09/13] tests/spec: EXT_image_dma_buf_import fd ownership transfer

2013-08-19 Thread Chad Versace
On 08/19/2013 10:45 AM, Chad Versace wrote: On 08/09/2013 03:43 AM, Topi Pohjolainen wrote: Simple test checking that EGL closes the export file handle and the creator can in turn drop its reference. v2: - compile only on platforms that have drm (Eric) - use standard drm definitions for

Re: [Piglit] [v9 09/13] tests/spec: EXT_image_dma_buf_import fd ownership transfer

2013-08-19 Thread Chad Versace
On 08/19/2013 10:45 AM, Chad Versace wrote: On 08/09/2013 03:43 AM, Topi Pohjolainen wrote: Simple test checking that EGL closes the export file handle and the creator can in turn drop its reference. v2: - compile only on platforms that have drm (Eric) - use standard drm definitions for

Re: [Piglit] [v9 12/13] tests/spec: EXT_image_dma_buf_import intel dma-buf with img-ext only

2013-08-19 Thread Chad Versace
On 08/09/2013 03:43 AM, Topi Pohjolainen wrote: v2 (Chad): - be more specific: rename try_as_non_external_texture() as try_as_texture_2d() - skip the test if EGL stack does not support the chosen format - add dependency to 'EGL_KHR_image_base' Signed-off-by: Topi Pohjolainen -

Re: [Piglit] [v9 13/13] tests/spec: EXT_image_dma_buf_import intel img-ext with dma-buf only

2013-08-19 Thread Chad Versace
On 08/09/2013 03:43 AM, Topi Pohjolainen wrote: v2 (Chad): add dependency to 'EGL_KHR_image_base' Signed-off-by: Topi Pohjolainen --- tests/all.tests| 1 + .../ext_image_dma_buf_import/CMakeLists.gles2.txt | 1 + .../intel_external_sampler_with_dma_o

Re: [Piglit] [v9 11/13] tests/spec: EXT_image_dma_buf_import intel unsupported format

2013-08-19 Thread Chad Versace
On 08/09/2013 03:43 AM, Topi Pohjolainen wrote: v2 (Chad): add dependency to 'EGL_KHR_image_base' Signed-off-by: Topi Pohjolainen --- tests/all.tests| 1 + .../ext_image_dma_buf_import/CMakeLists.gles1.txt | 1 + .../intel_unsupported_format.c

Re: [Piglit] [v9 09/13] tests/spec: EXT_image_dma_buf_import fd ownership transfer

2013-08-19 Thread Chad Versace
On 08/09/2013 03:43 AM, Topi Pohjolainen wrote: Simple test checking that EGL closes the export file handle and the creator can in turn drop its reference. v2: - compile only on platforms that have drm (Eric) - use standard drm definitions for fourcc instead of duplicated local (Da

Re: [Piglit] [v9 10/13] tests/spec: EXT_image_dma_buf_import sample argb

2013-08-19 Thread Chad Versace
On 08/09/2013 03:43 AM, Topi Pohjolainen wrote: Tests that one can sample the given buffer without other mipmap levels by setting texture filtering accordingly. v2: - compile only on platforms that have drm (Eric) - use standard drm definitions for fourcc instead of duplicated loca

Re: [Piglit] [PATCH] cl: Fix bug in the local store kernel

2013-08-19 Thread Aaron Watry
Reviewed-by: Aaron Watry On Fri, Aug 16, 2013 at 11:22 AM, Tom Stellard wrote: > From: Tom Stellard > > --- > generated_tests/cl/store/store-kernels-local.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/generated_tests/cl/store/store-kernels-local.inc > b/generate

[Piglit] [PATCH 2/4] GL_ARB_texture_compression/invalid_formats: Allow some formats to be optional

2013-08-19 Thread Ian Romanick
From: Ian Romanick There are some compressed formats that the spec doesn't seem to require implementations to advertise via GL_COMPRESSED_TEXTURE_FORMATS. No formats are yet marked as optional. The next two patches will add that. Signed-off-by: Ian Romanick Cc: Anuj Phogat --- .../spec/arb_

[Piglit] [PATCH 4/4] GL_ARB_texture_compression/invalid_formats: Mark BPTC formats as optional

2013-08-19 Thread Ian Romanick
From: Ian Romanick NVIDIA's driver doesn't expose these formats, and nothing in the ARB_texture_compression_bptc extension spec or OpenGL 4.2 spec seem to require they be advertised. With this patch, NVIDIA is closer to passing this test. However, they also advertise the GL_OES_compressed_palet

[Piglit] [PATCH 1/4] GL_ARB_texture_compression/invalid_formats: Add GL_OES_compressed_ETC1_RGB8_texture

2013-08-19 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Cc: Anuj Phogat --- .../spec/arb_texture_compression/invalid-formats.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/tests/spec/arb_texture_compression/invalid-formats.c b/tests/spec/arb_texture_compre

[Piglit] [PATCH 3/4] GL_ARB_texture_compression/invalid_formats: Add ETC2 / EAC formats

2013-08-19 Thread Ian Romanick
From: Ian Romanick These formats are dragged into desktop OpenGL via GL_ARB_ES3_compatibility or OpenGL 4.3. The extension spec says nothing about whether or not these must be advertised via GL_COMPRESSED_TEXTURE_FORMATS. The OpenGL 4.3 spec requires these formats, but it says that GL_NUM_COMPR

Re: [Piglit] [PATCH 4/4] GL_ARB_texture_compression/invalid_formats: Mark BPTC formats as optional

2013-08-19 Thread Anuj Phogat
On Mon, Aug 19, 2013 at 4:35 PM, Ian Romanick wrote: > From: Ian Romanick > > NVIDIA's driver doesn't expose these formats, and nothing in the > ARB_texture_compression_bptc extension spec or OpenGL 4.2 spec seem to > require they be advertised. > > With this patch, NVIDIA is closer to passing th