D19502: Add a SearchField and PasswordField component

2019-03-19 Thread Carl Schwan
This revision was automatically updated to reflect the committed changes. Closed by commit R169:546f82f9e645: Add a SearchField and PasswordField component (authored by ognarb). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19502?vs=54119=54353 REVISION

D19502: Add a SearchField and PasswordField component

2019-03-17 Thread Carl Schwan
ognarb updated this revision to Diff 54119. ognarb added a comment. Rebase REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19502?vs=54117=54119 BRANCH dev REVISION DETAIL https://phabricator.kde.org/D19502 AFFECTED FILES

D19502: Add a SearchField and PasswordField component

2019-03-17 Thread Carl Schwan
ognarb updated this revision to Diff 54117. ognarb added a comment. - Use qsTr instead of i18n - Kirigami version 2.7 -> 2.8 REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19502?vs=53106=54117 BRANCH dev REVISION DETAIL

D19502: Add a SearchField and PasswordField component

2019-03-17 Thread Marco Martin
mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ognarb wrote in SearchField.qml:44 > Are you sure? It would mean that Kirigami should then depends on ki18n. And > them Kirigami wouldn't be a Tier 1 KDE

D19502: Add a SearchField and PasswordField component

2019-03-04 Thread Carl Schwan
ognarb added inline comments. INLINE COMMENTS > broulik wrote in SearchField.qml:44 > I think this is fine but may need a translation domain > `i18nd("whatever_domain_kirigami_uses", "Search...")` Are you sure? It would mean that Kirigami should then depends on ki18n. And them Kirigami

D19502: Add a SearchField and PasswordField component

2019-03-04 Thread Carl Schwan
ognarb updated this revision to Diff 53106. ognarb marked 8 inline comments as done. ognarb edited the summary of this revision. ognarb added a comment. - Fix typos in doc - Remove edi-clear button in password field REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D19502: Add a SearchField and PasswordField component

2019-03-04 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > PasswordField.qml:27 > + * > + * Example usage for the search field component: > + * @code password field > PasswordField.qml:33 > + * id: passwordField > + * onAccepted: console.log("Password text is " + passwordField.text) > + * }

D19502: Add a SearchField and PasswordField component

2019-03-03 Thread Nathaniel Graham
ngraham added a reviewer: mart. ngraham added a comment. Wow, that was fast. I'm impressed. INLINE COMMENTS > PasswordField.qml:25 > +/** > + * This is a standart password text field. > + * `Standart` -> `Standard` > SearchField.qml:25 > +/** > + * This is a standart textfield following

D19502: Add a SearchField and PasswordField component

2019-03-03 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > PasswordField.qml:51 > +}, > +Kirigami.Action { > +iconName: "edit-clear" Looks off that the clear buttons are not aligned. Invert? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19502 To:

D19502: Add a SearchField and PasswordField component

2019-03-03 Thread Carl Schwan
ognarb created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY Provide a small abstraction over ActionTextField to implement consistent standard special text field **Warning:** I include a