Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114424/#review99449 --- Closing as this review request is more than 2 years old. If

Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints

2016-09-22 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114424/ --- (Updated Sept. 22, 2016, 8:34 p.m.) Status -- This change has been

Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints

2013-12-13 Thread Yichao Yu
- Yichao --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114424/#review45626 --- On Dec. 13, 2013, 7:53 a.m., Yichao Yu wrote:

Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints

2013-12-13 Thread Yichao Yu
On Dec. 13, 2013, 2:40 a.m., Martin Gräßlin wrote: This looks like the wrong approach to me. The shadow gets installed by the widget style, but lancelot does not use a normal Qt style, but a Plasma style. Because of that it would need to use the plasma shadow (e.g. panel shadow). The

Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints

2013-12-12 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114424/ --- Review request for Plasma, Aaron J. Seigo and Martin Gräßlin. Bugs: