Re: New: colortree

2015-07-20 Thread Vadim Zhukov
20 июля 2015 г. 21:15 пользователь "David Dahlberg" написал: > > Am Monday, den 20.07.2015, 18:03 +0100 schrieb Stuart Henderson: > > WANTLIB is missing. > > Added it. > > But what I still noticed is that the compiler warns about > strcpy/sprintf. Even though there are only two invocations of strc

Re: New: colortree

2015-07-20 Thread David Dahlberg
Am Monday, den 20.07.2015, 18:03 +0100 schrieb Stuart Henderson: > WANTLIB is missing. Added it. But what I still noticed is that the compiler warns about strcpy/sprintf. Even though there are only two invocations of strcpy(3) which do look good to me, there is actually far to many sprintf(3) wit

Re: New: colortree

2015-07-20 Thread Stuart Henderson
On 2015/07/20 18:52, David Dahlberg wrote: > Am Sunday, den 19.07.2015, 22:01 +0300 schrieb Vadim Zhukov: > > Yes. But, please, remove CFLAGS line entirely then, too > [..] > > Yes. The last small nit: the manual page isn't built but comes > > directly from source directory, so the ${INSTALL_MAN} l

Re: New: colortree

2015-07-20 Thread David Dahlberg
Am Sunday, den 19.07.2015, 22:01 +0300 schrieb Vadim Zhukov: > Yes. But, please, remove CFLAGS line entirely then, too [..] > Yes. The last small nit: the manual page isn't built but comes > directly from source directory, so the ${INSTALL_MAN} line should use > ${WRKSRC} instead of ${WRKBUILD} the

Re: New: colortree

2015-07-19 Thread Vadim Zhukov
2015-07-19 21:10 GMT+03:00 David Dahlberg : > Am Sunday, den 19.07.2015, 19:43 +0300 schrieb Vadim Zhukov: >> 2015-07-19 18:09 GMT+03:00 David Dahlberg > >: >> > A port for Steve Baker's "tree" program. >> > >> 1. Don't hardcode -O2, let the CFLAGS/COPTS/DEBUG coming from outside >> port do their j

Re: New: colortree

2015-07-19 Thread Dmitrij D. Czarkoff
| CFLAGS = -Wall -fomit-frame-pointer Just leave CFLAGS to user settings. This port builds and works without any CFLAGS definitions. -- Dmitrij D. Czarkoff

Re: New: colortree

2015-07-19 Thread David Dahlberg
Am Sunday, den 19.07.2015, 19:43 +0300 schrieb Vadim Zhukov: > 2015-07-19 18:09 GMT+03:00 David Dahlberg >: > > A port for Steve Baker's "tree" program. > > > 1. Don't hardcode -O2, let the CFLAGS/COPTS/DEBUG coming from outside > port do their job instead... I propose getting out of GMake > dep

Re: New: colortree

2015-07-19 Thread Vadim Zhukov
2015-07-19 18:09 GMT+03:00 David Dahlberg : > A port for Steve Baker's "tree" program. > > As we have already a simpler, BSD-licenced alternative in ports, I used > the gnugetopt/coreutils/colorls approach and renamed to "colortree", > which is the author's preference. 1. Don't hardcode -O2, let t

New: colortree

2015-07-19 Thread David Dahlberg
A port for Steve Baker's "tree" program. As we have already a simpler, BSD-licenced alternative in ports, I used the gnugetopt/coreutils/colorls approach and renamed to "colortree", which is the author's preference. Cheers, David colortree.tgz Description: application/compressed-tar