[issue23338] PyErr_Format in ctypes uses invalid parameter

2015-04-03 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka versions: +Python 2.7 ___ Python tracker ___ _

[issue23825] test_idle fails under -OO

2015-04-03 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ _

[issue23799] Join started threads in tests

2015-04-03 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue23825] test_idle fails under -OO

2015-04-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 912719dd684f by Serhiy Storchaka in branch '2.7': Issue #23825: Fixed test_idle under -OO. https://hg.python.org/cpython/rev/912719dd684f New changeset 657ebef5b291 by Serhiy Storchaka in branch '3.4': Issue #23825: Fixed test_idle under -OO. https:

[issue23863] Fix EINTR Socket Module issues in 2.7

2015-04-03 Thread Ned Deily
Changes by Ned Deily : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/

[issue23863] Fix EINTR Socket Module issues in 2.7

2015-04-03 Thread Jeff McNeil
Jeff McNeil added the comment: mcjeff@mcjeff:~/cpython_clean$ hg summary parent: 95416:fe34dfea16b0 Escaped backslashes in docstrings. branch: 2.7 commit: 3 modified, 3 unknown update: (current) -- keywords: +patch nosy: +gregory.p.smith Added file: http://bugs.python.org/file38826/soc

[issue23863] Fix EINTR Socket Module issues in 2.7

2015-04-03 Thread Jeff McNeil
New submission from Jeff McNeil: There are a collection of places in the socket module that do not correctly retry on EINTR. Updated to wrap those calls in a retry loop. However, when fixing connect calls, I noticed that when EINTR is retried on a socket with a timeout specified, the retry f

[issue23857] Make default HTTPS certificate verification setting configurable via global ini file

2015-04-03 Thread Donald Stufft
Donald Stufft added the comment: I'd really rather not add this to Python itself. If downstream wants to patch their Pythons to do it that is their prerogative. There's some legacy at play here of course, however I don't think that Python upstream is the right place to deal with that. One par

[issue23861] Make stdprinter use DebugOutputString when no stdout/stderr available

2015-04-03 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: +BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue20718] OpenBSD/AIX: tests passing a file descriptor with sendmsg/recvmsg failures

2015-04-03 Thread Michael Schurter
Changes by Michael Schurter : -- nosy: -schmichael ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue23862] subprocess popen arguments using double quotes

2015-04-03 Thread Paul Moore
Paul Moore added the comment: On Windows, subprocess.Popen has to convert an argument list to a command line (because that's what the OS expects for CreateProcess). It does so internally, using subprocess.list2cmdline, which follows the quoting rules for the MS C runtime (because that's what 9

[issue23492] Argument Clinic: improve generated parser for 1-argument functions

2015-04-03 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue15582] Enhance inspect.getdoc to follow inheritance chains

2015-04-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Unfortunately this enhancement breaks test_enum. == FAIL: test_pydoc (test.test_enum.TestStdLib) -- Traceback (most recent c

[issue23831] tkinter canvas lacks of moveto method.

2015-04-03 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- stage: -> test needed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue23831] tkinter canvas lacks of moveto method.

2015-04-03 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- nosy: +serhiy.storchaka, terry.reedy versions: +Python 3.5 -Python 3.4 ___ Python tracker ___ ___ Pytho

[issue23825] test_idle fails under -OO

2015-04-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: Whatever you do with the other -OO patches, I would prefer that this be applied to 3.4. The 3.4/3.5 files should be identical. -- versions: +Python 3.4 ___ Python tracker ___

[issue23825] test_idle fails under -OO

2015-04-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: The relevant code in CallTips.py itself if isinstance(ob_call, types.MethodType): doc = ob_call.__doc__ else: doc = getattr(ob, "__doc__", "") if doc: equally ignores both None and '', but I forgot the None possibility in the tests

[issue23492] Argument Clinic: improve generated parser for 1-argument functions

2015-04-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset e10ad4d4d490 by Serhiy Storchaka in branch 'default': Issue #23492: Argument Clinic now generates argument parsing code with https://hg.python.org/cpython/rev/e10ad4d4d490 -- nosy: +python-dev ___ Python

[issue23338] PyErr_Format in ctypes uses invalid parameter

2015-04-03 Thread Masayuki Yamamoto
Changes by Masayuki Yamamoto : -- nosy: +masamoto ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue23501] Argument Clinic: generate code into separate files by default

2015-04-03 Thread Larry Hastings
Larry Hastings added the comment: Thanks! I've been meaning to follow up on this. I think CPython should be consistent, one way or another. So I support this change. -- ___ Python tracker __

[issue23501] Argument Clinic: generate code into separate files by default

2015-04-03 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue23501] Argument Clinic: generate code into separate files by default

2015-04-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset aa88a18a4aa1 by Serhiy Storchaka in branch 'default': Issue #23501: Argumen Clinic now generates code into separate files by default. https://hg.python.org/cpython/rev/aa88a18a4aa1 -- nosy: +python-dev __

[issue23500] Argument Clinic: multiple macro definition

2015-04-03 Thread Larry Hastings
Larry Hastings added the comment: Removing 3.4 from the version list as I close the bug, then. If we decide we need it backported please reopen (or create a new bug, either is fine). -- resolution: -> fixed stage: commit review -> resolved status: open -> closed versions: -Python 3.4

[issue23815] Segmentation fault when create _tkinter objects

2015-04-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: With 3.4.3, I get the equivalent on Windows (a 'python has stopped working' box). -- nosy: +terry.reedy ___ Python tracker ___

[issue23786] test_unaligned_buffers (test.test_hash.HashEqualityTestCase) ... Fatal Python error: Bus error

2015-04-03 Thread Peter
Peter added the comment: Test 1 Python 3.4.3 built by GCC 4.9.2 is: >>> str(memoryview(b'abcdefghijklmnopqrstuvwxyz')[1:], 'ascii') 'bcdefghijklmnopqrstuvwxyz' Test 2 Python 3.4.3 built by GCC 4.6.2 is (no patches applied) This build will core dump if I run -m test test_hash. >>> str(memoryview

[issue23809] RFE: emit a warning when a module in a traceback shadows a stdlib module

2015-04-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: This is a fairly common newbie bug. random.py seems to be favorite name. -- nosy: +terry.reedy ___ Python tracker ___

[issue23500] Argument Clinic: multiple macro definition

2015-04-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Larry. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue23791] Identify Moved Lines with difflib

2015-04-03 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- nosy: +terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue23500] Argument Clinic: multiple macro definition

2015-04-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think this is not needed. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue23500] Argument Clinic: multiple macro definition

2015-04-03 Thread Larry Hastings
Larry Hastings added the comment: Does this really need a backport to 3.4? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue23500] Argument Clinic: multiple macro definition

2015-04-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 25eef0ecb9c1 by Larry Hastings in branch 'default': Issue #23500: Argument Clinic is now smarter about generating the "#ifndef" https://hg.python.org/cpython/rev/25eef0ecb9c1 -- nosy: +python-dev ___ Pyth

[issue15582] Enhance inspect.getdoc to follow inheritance chains

2015-04-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 157b7055bb9d by Serhiy Storchaka in branch 'default': Issue #15582: inspect.getdoc() now follows inheritance chains. https://hg.python.org/cpython/rev/157b7055bb9d -- nosy: +python-dev ___ Python tracker

[issue23862] subprocess popen arguments using double quotes

2015-04-03 Thread rengine
New submission from rengine: Using Python 2.7.9 Noticed when I run a subprocess Popen with an argument containing double quotes, it will have a different affect depending on my operating system. In Linux, if I run ./runme.py, it will call runme.sh which will append someargs.txt correctly wit

[issue23861] Make stdprinter use DebugOutputString when no stdout/stderr available

2015-04-03 Thread Steve Dower
New submission from Steve Dower: Currently we initialize stdprinter while initializing and terminate if we can't access std streams. We should always write to DebugOutputString on Windows (only does anything if a debugger is attached) and avoid terminating in this case. -- components:

[issue23500] Argument Clinic: multiple macro definition

2015-04-03 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> larry stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list

[issue23856] build.bat -e shouldn't also build

2015-04-03 Thread Tim Golden
Tim Golden added the comment: Fair enough -- resolution: -> not a bug stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue23852] Wrong FD_DIR file name on OpenBSD

2015-04-03 Thread Cédric Krier
Changes by Cédric Krier : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue23852] Wrong FD_DIR file name on OpenBSD

2015-04-03 Thread Cédric Krier
Cédric Krier added the comment: Here is a patch that uses getrlimit (that's works on OpenBSD) before using sysconf. -- Added file: http://bugs.python.org/file38824/max_fd.patch ___ Python tracker _

[issue21571] Python build should check CPATH, C_INCLUDE_PATH for module dependencies

2015-04-03 Thread Simon Ye
Changes by Simon Ye : -- nosy: +yesimon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org

[issue23852] Wrong FD_DIR file name on OpenBSD

2015-04-03 Thread Cédric Krier
Cédric Krier added the comment: The problem comes from safe_get_max_fd which return a too low value because of a bug in sysconf on OpenBSD [1]: The value for _SC_STREAM_MAX is a minimum maximum, and required to be the same as ANSI C's FOPEN_MAX, so the returned value is a ridiculously small an

[issue23794] http package should support HTTP/2

2015-04-03 Thread Demian Brecht
Demian Brecht added the comment: @Cory: my own plan was to use your implementation as the baseline and add server support. If you take a crack at it that would be great! -- ___ Python tracker _

[issue23794] http package should support HTTP/2

2015-04-03 Thread Cory Benfield
Cory Benfield added the comment: > figure out some kind of adapter interface in order to facilitate swapping > between 1.1 and 2 (This can start with a clean HTTP/1.1 interface) I've been thinking about this a lot with hyper, and I'm about to start work on it (having just finished an alpha imp

[issue23794] http package should support HTTP/2

2015-04-03 Thread Demian Brecht
Demian Brecht added the comment: +1 to the adding the support for HTTP/2. I would personally like to see a few things happen before that though (which I've been putting some effort into as i can) + refactor http.client to cleanly separate transport from application protocol level + figure out

[issue23466] PEP 461: Inconsistency between str and bytes formatting of integers

2015-04-03 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue23466] PEP 461: Inconsistency between str and bytes formatting of integers

2015-04-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 313fd1c819c5 by Serhiy Storchaka in branch 'default': Issue #23466: Raised OverflowError if %c argument is out of range. https://hg.python.org/cpython/rev/313fd1c819c5 -- ___ Python tracker

[issue23852] Wrong FD_DIR file name on OpenBSD

2015-04-03 Thread Cédric Krier
Cédric Krier added the comment: Indeed, I think my patch is not right as /dev/fd on OpenBSD is static. I will continue to investigate. -- ___ Python tracker ___ _

[issue23500] Argument Clinic: multiple macro definition

2015-04-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: larry.ac_multiple_macro_definitions.diff.5.txt LGTM. -- ___ Python tracker ___ ___ Python-bugs-lis

[issue23860] Failure to check return value from lseek() in Modules/mmapmodule.c

2015-04-03 Thread Bill Parker
New submission from Bill Parker: Hello All, In reviewing code in directory Python-3.4.3/Modules, file 'mmapmodule', I found a call to 'lseek()' without a check for a return value of -1, indicating failure. The patch file below corrects this issue (diff -u format): --- mmapmodule.c.orig 2

[issue23668] Support os.ftruncate on Windows

2015-04-03 Thread Steve Dower
Steve Dower added the comment: Sorry, _Py_open requires a double encoding (wchar->char->wchar), which is why I'm not going to use it. _Py_wfopen takes a mode string rather than _O_* flags, and so implicitly includes _O_CREAT. Guessing we should add _Py_wopen? --

[issue23852] Wrong FD_DIR file name on OpenBSD

2015-04-03 Thread Gregory P. Smith
Gregory P. Smith added the comment: I'm not going to bother setting up a VM with an esoteric OS in it myself, if someone knows the past and current state of various OpenBSD versions and what to do there, feel free to commit OpenBSD conditional compilation bits as you see fit to make this do th

[issue23500] Argument Clinic: multiple macro definition

2015-04-03 Thread Larry Hastings
Larry Hastings added the comment: Updated patch, removed all references to two-pass. Also realized I needed to make the default behavior for methoddef_ifndef go to the end. And, finally, I forgot to merge the "only print each #ifndef block once" code I wrote before when I redid the patch, so

[issue23466] PEP 461: Inconsistency between str and bytes formatting of integers

2015-04-03 Thread Ethan Furman
Ethan Furman added the comment: Looks good, thanks Serhiy. -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bug

[issue23500] Argument Clinic: multiple macro definition

2015-04-03 Thread Larry Hastings
Larry Hastings added the comment: I did, I just didn't respond. I'll do that now. -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue23500] Argument Clinic: multiple macro definition

2015-04-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Looks as you didn't notice my comments on Rietveld. -- ___ Python tracker ___ ___ Python-bugs-list

[issue23668] Support os.ftruncate on Windows

2015-04-03 Thread STINNER Victor
STINNER Victor added the comment: Sorry, I still fail to see how _Py_open() or _Py_open_noraise() add the O_CREAT flag: they are thin wrapper to the underyling open() function. I cannot see O_CREAT in Python/fileutils.c. Could you please show me that the line number adding O_CREAT implictly?

[issue23500] Argument Clinic: multiple macro definition

2015-04-03 Thread Larry Hastings
Larry Hastings added the comment: As promised, here's a cleaned-up version of the patch. The taxonomy of objects now makes sense: a Destination contains a BufferSeries object, rather than Destinations weirdly supporting __getitem__ to reference different objects. I tripped over myself a littl

[issue23812] asyncio.Queue.put_nowait(), followed get() task cancellation leads to item being lost

2015-04-03 Thread STINNER Victor
STINNER Victor added the comment: queue_bug.py: script to reproduce the bug. I confirm that Queue.get() sometimes looses items when it is cancelled. The waiter contains the result, but the waiter is lost when get() is cancelled. Queue.get() waiter got a result, but Queue.get() wakeup is only *

[issue23852] Wrong FD_DIR file name on OpenBSD

2015-04-03 Thread Cédric Krier
Cédric Krier added the comment: At least on OpenBSD procfs have been removed: http://www.openbsd.org/faq/current.html#20140908 -- ___ Python tracker ___

[issue23524] Use _set_thread_local_invalid_parameter_handler in posixmodule

2015-04-03 Thread Steve Dower
Steve Dower added the comment: Victor - can you take a look? I'm keen to get this out of my patch queue :) -- ___ Python tracker ___ _

[issue23668] Support os.ftruncate on Windows

2015-04-03 Thread Steve Dower
Steve Dower added the comment: I responded to Victor's suggestion about _Py_open instead of _open, but on rereading I see that it also handles EINTR. AFAICT (from https://msdn.microsoft.com/en-us/library/5814770t.aspx, mainly), Windows isn't ever going to return EINTR from the CRT. I don't es

[issue23852] Wrong FD_DIR file name on OpenBSD

2015-04-03 Thread Stefan Krah
Changes by Stefan Krah : -- nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue23852] Wrong FD_DIR file name on OpenBSD

2015-04-03 Thread Stefan Krah
Stefan Krah added the comment: There's a comment in _posixsubprocess: "NetBSD and OpenBSD have a /proc fs available (though not necessarily mounted) and do not have fdescfs for /dev/fd." Is this still valid? -- nosy: +skrah ___ Python tracker

[issue23765] Remove IsBadStringPtr calls in ctypes

2015-04-03 Thread Steve Dower
Changes by Steve Dower : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue23859] asyncio: document behaviour of wait() cancellation

2015-04-03 Thread STINNER Victor
New submission from STINNER Victor: When wait(fs) is cancelled, futures of fs are not cancelled. This behaviour is not documented. It should be documented, and a warning should be added to the Cancellation section: https://docs.python.org/dev/library/asyncio-dev.html#cancellation See my messag

[issue23219] asyncio: cancelling wait_for(task, timeout) must also cancel the task

2015-04-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset c167b9f9aac8 by Victor Stinner in branch '3.4': Issue #23219: Update asyncio.wait_for() documentation https://hg.python.org/cpython/rev/c167b9f9aac8 -- ___ Python tracker

[issue23858] Look for local sqlite3 by parsing -I/-L flags in linux as well.

2015-04-03 Thread Ned Deily
Ned Deily added the comment: My apologies, I replied a bit too hastily, thinking incorrectly that your suggested change was just for sqlite3. While the comments above still apply, there is already an open request for the more general feature (and more) under Issue21571. So I suggest further

[issue23858] Look for local sqlite3 by parsing -I/-L flags in linux as well.

2015-04-03 Thread Ned Deily
Ned Deily added the comment: This is essentially a duplicate of Issue3467 and various other similar issues. While it may not be easy to justify the special case in setup.py for OS X (the reason was primarily for OS X installer builds), it would be even harder to justify adding another special

[issue23858] Look for local sqlite3 by parsing -I/-L flags in linux as well.

2015-04-03 Thread Simon Ye
New submission from Simon Ye: Based off of https://github.com/Homebrew/linuxbrew/pull/330. Currently building python on linux only looks for sqlite include paths in a hardcoded set of system paths, but if the user specifies -I/-L options during compilation, python setup.py looks there for sqli

[issue23857] Make default HTTPS certificate verification setting configurable via global ini file

2015-04-03 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: +1 for keyed by site There have been a number of issues over the years for which a configuration file (or files) would have been useful. I think a discussion over on python-ideas is the right way to move forward on this point. -- _

[issue23857] Make default HTTPS certificate verification setting configurable via global ini file

2015-04-03 Thread R. David Murray
R. David Murray added the comment: Changing the title to be specific to the proposed patch. -- title: [RFE] Make default HTTPS certificate verification setting configurable -> Make default HTTPS certificate verification setting configurable via global ini file

[issue23857] [RFE] Make default HTTPS certificate verification setting configurable

2015-04-03 Thread R. David Murray
R. David Murray added the comment: I do not understand why the vendors want to re-introduce a security hole. I understand that it causes issues using legacy software to communicate with sites that don't verify, but I think that the correct solution to this is disabling verification on a per-tr

[issue23856] build.bat -e shouldn't also build

2015-04-03 Thread Zachary Ware
Zachary Ware added the comment: > Either by accident or by design the main build will run in addition. By design; I intended get_externals.bat to be run explicitly if you just wanted to pull the externals. -- ___ Python tracker

[issue23857] [RFE] Make default HTTPS certificate verification setting configurable

2015-04-03 Thread Nick Coghlan
Nick Coghlan added the comment: Clarified the issue heading a bit, and cc'ed in the main Debian/Ubuntu folks. Matthias, Barry - the attached patch here is aimed at making PEP 476 a bit more distro friendly by moving the "opt out" to a configuration file rather than requiring monkeypatching in

[issue23857] [RFE] Make certificate verification optionable

2015-04-03 Thread Nick Coghlan
Nick Coghlan added the comment: The other goal worth noting here is that we'd like to facilitate easy system auditing/monitoring such that machines that still have Python certificate verification off by default can easily be flagged by checks in tools like Nagios, as well as being easy to adju

[issue23857] [RFE] Make certificate verification optionable

2015-04-03 Thread Robert Kuska
Robert Kuska added the comment: ( ^ I was replying to Victor) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23857] [RFE] Make certificate verification optionable

2015-04-03 Thread Robert Kuska
Robert Kuska added the comment: If you mean hack site.py to be sitecustomize I don't find it as a sufficient solution because users may use their own sitecustomize and this way we would replace theirs. Sslcustomize solution could be another option how to handle this but the config idea seems

[issue23857] [RFE] Make certificate verification optionable

2015-04-03 Thread Nick Coghlan
Nick Coghlan added the comment: (capturing these details here for now, we should at least have a python-dev discussion before going ahead with any changes in this area) The additional background here is that we started looking closely at what would be involved in applying PEP 476 to systems wh

[issue22643] Integer overflow in case_operation

2015-04-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: bigimem tests are ran with dummy size = 5147 if dry_run = True (default) and skipped if dry_run = False. Almost always you need dry_run = False. The -M option doesn't work with less than 1 GiB. In this case likely the buildbot had enough memory at the start,

[issue22643] Integer overflow in case_operation

2015-04-03 Thread STINNER Victor
STINNER Victor added the comment: > Perhaps adding bigmemtest is not worth if memory requirements are less than 1 > GiB. What is the current limit if you don't pass -M option to regrtest? In @bigimemtest, I see "maxsize = 5147". Is it a number of bytes? 5 kB of memory? IMO it's interested to

[issue22643] Integer overflow in case_operation

2015-04-03 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- keywords: +patch stage: resolved -> patch review versions: -Python 3.3 Added file: http://bugs.python.org/file38818/test_case_operation_overflow_memory_error.patch ___ Python tracker

[issue22643] Integer overflow in case_operation

2015-04-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Perhaps adding bigmemtest is not worth if memory requirements are less than 1 GiB. But I would separate the creating of long tested string and the calling of case converting method, so we will sure what operation is failed. Proposed patch skips the test if c

[issue23857] [RFE] Make certificate verification optionable

2015-04-03 Thread STINNER Victor
STINNER Victor added the comment: > 2) It exists but it is not system wide, You can hack site.py to disable SSL checks system-wide. It was also discussed to support an optional "sslcustomize" module, but the idea was rejected if I remember correctly. Anyway, did you read the discussion on the

[issue23857] [RFE] Make certificate verification optionable

2015-04-03 Thread Robert Kuska
Robert Kuska added the comment: 1) patch attached, dunno how I missed it, thank you. 3) I work for Red Hat additional interest for example here http://seclists.org/oss-sec/2015/q1/785 2) It exists but it is not system wide, I would like to provide users option to opt-in or opt-out without inte

[issue23853] PEP 475: handle EINTR in the ssl module

2015-04-03 Thread STINNER Victor
STINNER Victor added the comment: Here is a patch to fix the issue: recompute the timeout. It's unclear to me if we should reset the timeout after each successful read/write, or if the timeout is "global" (total duration of the ssl method). I asked the question on the python-dev mailing list.

[issue23857] [RFE] Make certificate verification optionable

2015-04-03 Thread STINNER Victor
STINNER Victor added the comment: This issue is related to the PEP 476 which made the SSL certification checks mandatory by default. The PEP contains a section to explain how to opt-out, but the solution is global: https://www.python.org/dev/peps/pep-0476/#opting-out I understand that Robert

[issue22351] NNTP constructor exception leaves socket for garbage collector

2015-04-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Now you have used time machine in reverse mode. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___

[issue22351] NNTP constructor exception leaves socket for garbage collector

2015-04-03 Thread STINNER Victor
STINNER Victor added the comment: Except of the self parameter/@staticmethod and the unrelated SAX changes, issue22351_skip_MockSslTests.patch looks good to me. -- resolution: fixed -> status: closed -> open ___ Python tracker

[issue22351] NNTP constructor exception leaves socket for garbage collector

2015-04-03 Thread STINNER Victor
STINNER Victor added the comment: > Serhiy’s patch looks like it should do the trick. Just get rid of the “self” > parameter to make it clearer, +class MockSslTests(MockSocketTests): +def nntp_class(self, *pos, **kw): Hum, you should use the @staticmethod decorator here. -- _

[issue22351] NNTP constructor exception leaves socket for garbage collector

2015-04-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7a91363f31e1 by Serhiy Storchaka in branch '3.4': Issue #22351. MockSslTests tests in test_nntplib now are reported if skipped. https://hg.python.org/cpython/rev/7a91363f31e1 New changeset c935c1e1d001 by Serhiy Storchaka in branch 'default': Issue

[issue22351] NNTP constructor exception leaves socket for garbage collector

2015-04-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Agree, factory method can be staticmethod. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue1103213] Adding the missing socket.recvall() method

2015-04-03 Thread STINNER Victor
STINNER Victor added the comment: > - I've learned that MSG_WAITALL may be unreliable on certain systems, so any > implementation of recvall depending on MSG_WAITALL may inexplicably fail on > such systems Something else occurred since 5 years: the PEP 475 was accepted, it makes Python more r

[issue23857] [RFE] Make certificate verification optionable

2015-04-03 Thread R. David Murray
R. David Murray added the comment: 1) there is no patch attached 2) certificate verification is optional already, is it not? That is, it can be turned off in your code, it is just on by default. 3) what downstream are you talking about? Supposing there is sufficient utility here, the level of c

[issue22351] NNTP constructor exception leaves socket for garbage collector

2015-04-03 Thread Martin Panter
Martin Panter added the comment: Sorry, that self parameter is okay. I was just confused because it now means something different :S -- ___ Python tracker ___ __

[issue22351] NNTP constructor exception leaves socket for garbage collector

2015-04-03 Thread Martin Panter
Martin Panter added the comment: Serhiy’s patch looks like it should do the trick. Just get rid of the “self” parameter to make it clearer, and watch out for the stray XML changes! -- ___ Python tracker __

[issue22643] Integer overflow in case_operation

2015-04-03 Thread STINNER Victor
STINNER Victor added the comment: > It's strange to have "�" here. Should be "ü". Oh right, I saw "�" in the bug tracker and in the buildbot output. But it's a web browser issue, if you download the raw buildbout output, you will see "ü". So the string takes less memory (1 byte per character, no

[issue23756] Tighten definition of bytes-like objects

2015-04-03 Thread Martin Panter
Martin Panter added the comment: I’m sorry Stefan, I now realize my changes for len(view) were indeed wrong, and the original was much more correct. I still think the tobytes() and maybe tolist() documentation could be improved, but that is a separate issue to the bytes-like definition. I am

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

2015-04-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7a9c49885cd3 by Victor Stinner in branch 'default': Issue #23834: Simplify timeout handling https://hg.python.org/cpython/rev/7a9c49885cd3 -- ___ Python tracker __

[issue22117] Rewrite pytime.h to work on nanoseconds

2015-04-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset d976683671ba by Victor Stinner in branch 'default': Issue #22117: Add a new _PyTime_FromSeconds() function https://hg.python.org/cpython/rev/d976683671ba -- ___ Python tracker

[issue23853] PEP 475: handle EINTR in the ssl module

2015-04-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 753233baf27e by Victor Stinner in branch 'default': Issue #23853: Cleanup _ssl.c https://hg.python.org/cpython/rev/753233baf27e -- nosy: +python-dev ___ Python tracker

[issue22351] NNTP constructor exception leaves socket for garbage collector

2015-04-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: See the patch. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

  1   2   >