I'm seeing a lot of review requests from github, asking for reviews
from the Windows team. Many of the PRs don't as far as I can see have
much Windows-specific about them. It doesn't bother me too much (I
just ignore ones I don't have anything to say on) but I thought the
idea of having the teams w
On 10/6/2017 8:16 AM, Paul Moore wrote:
I'm seeing a lot of review requests from github, asking for reviews
from the Windows team. Many of the PRs don't as far as I can see have
much Windows-specific about them. It doesn't bother me too much (I
just ignore ones I don't have anything to say on) bu
On Fri, Oct 6, 2017 at 7:16 AM, Paul Moore wrote:
> I'm seeing a lot of review requests from github, asking for reviews
> from the Windows team. Many of the PRs don't as far as I can see have
> much Windows-specific about them. It doesn't bother me too much (I
> just ignore ones I don't have anyth
Hmm, as an example, #2858, which seems to be about the AST (which I'm
not familiar with). I don't particularly want to single this out as a
problem, but it's an example of the sort of request that confuses me -
I simply don't know what help I can offer. Maybe there is some
suspicion that there migh
The windows team is notified because the PR includes changes to PCBuild/*
Mariatta Wijaya
On Fri, Oct 6, 2017 at 8:51 AM, Paul Moore wrote:
> Hmm, as an example, #2858, which seems to be about the AST (which I'm
> not familiar with). I don't particularly want to single this out as a
> problem,
On 6 October 2017 at 17:09, Mariatta Wijaya wrote:
> The windows team is notified because the PR includes changes to PCBuild/*
Ah cool. That explains it then - I hadn't spotted that (and didn't think of it).
Thanks Mariatta
Paul
___
python-committers
On Fri, 06 Oct 2017 09:09:01 -0700, Mariatta Wijaya
wrote:
> The windows team is notified because the PR includes changes to PCBuild/*
If you get a review request that says your review was requested "as a
code owner", then it was an auto-request, it wasn't actually requested
by the person named
On 6 October 2017 at 17:58, R. David Murray wrote:
> On Fri, 06 Oct 2017 09:09:01 -0700, Mariatta Wijaya
> wrote:
>> The windows team is notified because the PR includes changes to PCBuild/*
>
> If you get a review request that says your review was requested "as a
> code owner", then it was an a
I noticed today that out of about 19 pages of issues, only the first 5 have
"awaiting" labels. Would people object if I back-filled those open issues
lacking an "awaiting" label? For those that have a "changes requested"
review a comment that said roughly "we noticed there's a review asking for
cha
Can we please use a phrase for re-triggering a review that makes more sense
like "I've updated the patch, please re-review", rather than magic inside
baseball language?
Alex
On Fri, Oct 6, 2017 at 5:29 PM, Brett Cannon wrote:
> I noticed today that out of about 19 pages of issues, only the firs
> On Oct 6, 2017, at 5:36 PM, Alex Gaynor wrote:
>
> Can we please use a phrase for re-triggering a review that makes more sense
> like "I've updated the patch, please re-review", rather than magic inside
> baseball language?
>
+1
___
python-comm
On 10/6/2017 5:29 PM, Brett Cannon wrote:
I noticed today that out of about 19 pages of issues, only the first 5
have "awaiting" labels. Would people object if I back-filled those open
issues lacking an "awaiting" label? For those that have a "changes
requested" review a comment that said rough
12 matches
Mail list logo
