Re: [Qemu-devel] Re: KVM call agenda for Feb 9

2010-02-08 Thread Alexander Graf
On 09.02.2010, at 07:56, Avi Kivity wrote: > On 02/09/2010 03:28 AM, Chris Wright wrote: >> Please send in any agenda items you are interested in covering. >> > > hpet overhead on large smp guests > > I measured hpet consuming about a half a core's worth of cpu on an idle > Windows 2008 R2

[Qemu-devel] Re: KVM call agenda for Feb 9

2010-02-08 Thread Avi Kivity
On 02/09/2010 03:28 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. hpet overhead on large smp guests I measured hpet consuming about a half a core's worth of cpu on an idle Windows 2008 R2 64-way guest. This is mostly due to futex contention, lik

Re: [Qemu-devel] 0.12.2, PowerPC, CPU 750 wrongly identified (?), hardware error

2010-02-08 Thread Alexander Graf
On 08.02.2010, at 13:40, Bartlomiej Celary wrote: > Hi, > I've just compiled qemu 0.12.2 for Windows under msys. > > I am using "-m prep -M 750" options which on 0.11 worked fine. In 012.2 > however, I get the following error: I guess you mean -cpu 750? Alex

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Isaku Yamahata
On Mon, Feb 08, 2010 at 06:27:53PM +0200, Michael S. Tsirkin wrote: > On Mon, Feb 08, 2010 at 12:14:11PM +0100, Gerd Hoffmann wrote: > > On 02/08/10 11:17, Michael S. Tsirkin wrote: > >> On Mon, Feb 08, 2010 at 03:41:47PM +0900, Isaku Yamahata wrote: > >>> initialize header type register in pci gen

[Qemu-devel] Re: [PATCH] pci: fix info pci with host bridge.

2010-02-08 Thread Isaku Yamahata
On Mon, Feb 08, 2010 at 07:23:34PM +0200, Blue Swirl wrote: > On Mon, Feb 8, 2010 at 12:37 PM, Michael S. Tsirkin wrote: > > On Mon, Feb 08, 2010 at 03:40:38PM +0900, Isaku Yamahata wrote: > >> This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5. > >> pci host bridge doesn't have header type

[Qemu-devel] KVM call agenda for Feb 9

2010-02-08 Thread Chris Wright
Please send in any agenda items you are interested in covering.

[Qemu-devel] Re: Seabios dislikes -M isapc

2010-02-08 Thread Kevin O'Connor
On Mon, Feb 08, 2010 at 08:09:17PM +0100, Jan Kiszka wrote: > Sebastian Herbszt wrote: > > Jan Kiszka wrote: > >> Hi, > >> > >> Seabios seems to have some assumptions built in that break when -M isapc > >> is selected. Is this supposed to work or is isapc about to die? > > > > SeaBIOS doesn't POST

Re: [Qemu-devel] Re: [SeaBIOS] [PATCH] Seabios: Fix PkgLength calculation for the SSDT.

2010-02-08 Thread Kevin O'Connor
On Mon, Feb 08, 2010 at 11:15:03AM -0600, Anthony Liguori wrote: > On 02/08/2010 04:19 AM, Avi Kivity wrote: > >Without this patch, Windows 2008 r2 won't boot with more than 4 > >cpus. Kevin/Anthony, can you coordinate a SeaBIOS release > >including this patch? > > > >Probably needed for qemu 0.12

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Anthony Liguori
On 02/08/2010 03:58 PM, Michael S. Tsirkin wrote: Just converted versatile_pci, with some nudging I might do others :) *nudge* :-) but I've got another PCI series in flight. I've got a branch pci-cleanup on staging that's a work in progress for adding a proper region API along with PCI

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Michael S. Tsirkin
On Mon, Feb 08, 2010 at 03:56:29PM -0600, Anthony Liguori wrote: > On 02/08/2010 03:01 PM, Michael S. Tsirkin wrote: >>> Sorry, but: >>> >>> versatile_pci.c:d->config[0x04] = 0x00; >>> versatile_pci.c:d->config[0x05] = 0x00; >>> versatile_pci.c:d->config[0x06] = 0x20; >>> versatile_pci.

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Anthony Liguori
On 02/08/2010 03:01 PM, Michael S. Tsirkin wrote: Sorry, but: versatile_pci.c:d->config[0x04] = 0x00; versatile_pci.c:d->config[0x05] = 0x00; versatile_pci.c:d->config[0x06] = 0x20; versatile_pci.c:d->config[0x07] = 0x02; To: pci_config_set_command(d, 0); pci_config_set_status(

Re: [Qemu-devel] [PATCH] [For stable-0.12] Sync OSS_GETVERSION handling with head

2010-02-08 Thread malc
On Mon, 8 Feb 2010, Juergen Lock wrote: > In article you write: > >On Tue, 19 Jan 2010, Anthony Liguori wrote: > > > >> On 01/17/2010 11:23 AM, Juergen Lock wrote: > >> > As suggested by Andreas F?rber, here is a cumulative patch that syncs > >> > OSS_GETVERSION handling with head by merging the

[Qemu-devel] [PATCH 2/2] versatile_pci: cleanup

2010-02-08 Thread Michael S. Tsirkin
Cleanup versatile_pci: no need to re-set fields to zero (pci core sets 0 already), use set_word for status field. Compile-tested only, but seems obvious. Signed-off-by: Michael S. Tsirkin --- hw/versatile_pci.c | 11 ++- 1 files changed, 2 insertions(+), 9 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 1/2] versatile_pci: convert to symbolic names

2010-02-08 Thread Michael S. Tsirkin
This converts versatile_pci to use symbolic constants. Verified by comparing binary to original one. Signed-off-by: Michael S. Tsirkin --- hw/versatile_pci.c | 17 ++--- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/versatile_pci.c b/hw/versatile_pci.c index 15

[Qemu-devel] [PATCH 0/2] versatile_pci: symbolic names

2010-02-08 Thread Michael S. Tsirkin
Convert another file to symbolic constants. Michael S. Tsirkin (2): versatile_pci: convert to symbolic names versatile_pci: cleanup hw/versatile_pci.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-)

[Qemu-devel] Re: Network shutdown under load

2010-02-08 Thread Herbert Xu
On Mon, Feb 08, 2010 at 10:10:01AM -0600, Tom Lendacky wrote: > > Fix a race condition where qemu finds that there are not enough virtio > ring buffers available and the guest make more buffers available before > qemu can enable notifications. > > Signed-off-by: Tom Lendacky > Signed-off-by: Ant

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Michael S. Tsirkin
On Mon, Feb 08, 2010 at 02:54:24PM -0600, Anthony Liguori wrote: > On 02/08/2010 02:34 PM, Michael S. Tsirkin wrote: >> On Mon, Feb 08, 2010 at 02:32:26PM -0600, Anthony Liguori wrote: >> >>> On 02/08/2010 02:19 PM, Michael S. Tsirkin wrote: >>> On Mon, Feb 08, 2010 at 08:55:58PM +01

Re: [Qemu-devel] 0.12.2, PowerPC, CPU 750 wrongly identified (?), hardware error

2010-02-08 Thread Natalia Portillo
Nope this is not correct. And I don't even see why the 601 / 620 / 970 are treated as equal. You are asking to run a fully implemented "so called G3" PowerPC processor. However the 601 is a hybrid PowerPC/POWER ("G1"), the 620 is a 64-bit early implementation ("64bit G2") and the 970 the fin

[Qemu-devel] Re: Network shutdown under load

2010-02-08 Thread Anthony Liguori
On 02/08/2010 10:10 AM, Tom Lendacky wrote: Fix a race condition where qemu finds that there are not enough virtio ring buffers available and the guest make more buffers available before qemu can enable notifications. Signed-off-by: Tom Lendacky Signed-off-by: Anthony Liguori I've walked t

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Anthony Liguori
On 02/08/2010 02:34 PM, Michael S. Tsirkin wrote: On Mon, Feb 08, 2010 at 02:32:26PM -0600, Anthony Liguori wrote: On 02/08/2010 02:19 PM, Michael S. Tsirkin wrote: On Mon, Feb 08, 2010 at 08:55:58PM +0100, Gerd Hoffmann wrote: Hi, This still means we have t

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Michael S. Tsirkin
On Mon, Feb 08, 2010 at 02:32:26PM -0600, Anthony Liguori wrote: > On 02/08/2010 02:19 PM, Michael S. Tsirkin wrote: >> On Mon, Feb 08, 2010 at 08:55:58PM +0100, Gerd Hoffmann wrote: >> >>>Hi, >>> >>> This still means we have two copies of same data and need to maintain code

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Anthony Liguori
On 02/08/2010 02:19 PM, Michael S. Tsirkin wrote: On Mon, Feb 08, 2010 at 08:55:58PM +0100, Gerd Hoffmann wrote: Hi, This still means we have two copies of same data and need to maintain code that keeps them in sync, even if that is called just at init time. No. There is

Re: [Qemu-devel] [PATCH] [For stable-0.12] Sync OSS_GETVERSION handling with head

2010-02-08 Thread Juergen Lock
In article you write: >On Tue, 19 Jan 2010, Anthony Liguori wrote: > >> On 01/17/2010 11:23 AM, Juergen Lock wrote: >> > As suggested by Andreas F?rber, here is a cumulative patch that syncs >> > OSS_GETVERSION handling with head by merging the following commits: >> > >> > 1. oss: issue OSS_GETVE

[Qemu-devel] Re: Slowdowns comparing qemu-kvm.git to qemu.git: vcpu/thread scheduling differences

2010-02-08 Thread Anthony Liguori
On 02/08/2010 11:35 AM, Amit Shah wrote: On (Mon) Feb 08 2010 [08:57:05], Anthony Liguori wrote: On 02/08/2010 07:46 AM, Amit Shah wrote: Hello, In my testing of virtio-console, I found qemu-kvm.git introduces a lot of overhead in thread scheduling compared to qemu.git. My test send

[Qemu-devel] [PATCH 1/1] Increase VNC_MAX_WIDTH

2010-02-08 Thread Brian Jackson
Increase VNC_MAX_WIDTH to match "commonly available" consumer level monitors available these days. This also closes KVM bug 2907597 Signed-off-by: Brian Jackson --- vnc.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vnc.h b/vnc.h index 1210824..1575af2 100644 --- a

Re: [Qemu-devel] Re: Two QMP events issues

2010-02-08 Thread Anthony Liguori
On 02/08/2010 01:59 PM, Luiz Capitulino wrote: Looks reasonable to me, what do think Daniel? Note that if we agree on the 'context design', I'll have to change VNC's events names.. Let me give you a few suggestions before diving into it. context might not be the best name. For eve

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Michael S. Tsirkin
On Mon, Feb 08, 2010 at 08:55:58PM +0100, Gerd Hoffmann wrote: > Hi, > >> This still means we have two copies of same data >> and need to maintain code that keeps them in sync, >> even if that is called just at init time. > > No. There is nothing to keep in sync. And there is no extra copy of d

Re: [Qemu-devel] Re: Two QMP events issues

2010-02-08 Thread Luiz Capitulino
On Mon, 08 Feb 2010 13:14:24 -0600 Anthony Liguori wrote: > On 02/08/2010 12:25 PM, Luiz Capitulino wrote: > > On Mon, 08 Feb 2010 09:13:37 -0600 > > Anthony Liguori wrote: > > > > > >> On 02/08/2010 08:56 AM, Daniel P. Berrange wrote: > >> > >>> On Mon, Feb 08, 2010 at 08:49:20AM -060

[Qemu-devel] [PATCH v1 0/4]: QMP related fixes

2010-02-08 Thread Luiz Capitulino
Should be applied on top of feature negotiation series. changelog: -- v0 -> v1: - Document qobject_from_jsonf() new semantics

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Gerd Hoffmann
Hi, This still means we have two copies of same data and need to maintain code that keeps them in sync, even if that is called just at init time. No. There is nothing to keep in sync. And there is no extra copy of data. Today you have pci_set_*() calls somewhere in PCIDeviceInfo->init().

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Michael S. Tsirkin
On Mon, Feb 08, 2010 at 09:32:54PM +0200, Blue Swirl wrote: > On Mon, Feb 8, 2010 at 8:26 PM, Michael S. Tsirkin wrote: > > On Mon, Feb 08, 2010 at 07:56:27PM +0200, Blue Swirl wrote: > >> On Mon, Feb 8, 2010 at 7:37 PM, Michael S. Tsirkin wrote: > >> > On Mon, Feb 08, 2010 at 06:37:41PM +0100, G

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Blue Swirl
On Mon, Feb 8, 2010 at 8:26 PM, Michael S. Tsirkin wrote: > On Mon, Feb 08, 2010 at 07:56:27PM +0200, Blue Swirl wrote: >> On Mon, Feb 8, 2010 at 7:37 PM, Michael S. Tsirkin wrote: >> > On Mon, Feb 08, 2010 at 06:37:41PM +0100, Gerd Hoffmann wrote: >> >> On 02/08/10 18:32, Michael S. Tsirkin wrot

Re: [Qemu-devel] Re: Two QMP events issues

2010-02-08 Thread Anthony Liguori
On 02/08/2010 12:25 PM, Luiz Capitulino wrote: On Mon, 08 Feb 2010 09:13:37 -0600 Anthony Liguori wrote: On 02/08/2010 08:56 AM, Daniel P. Berrange wrote: On Mon, Feb 08, 2010 at 08:49:20AM -0600, Anthony Liguori wrote: On 02/08/2010 08:12 AM, Daniel P. Berrange wrote:

[Qemu-devel] Re: Seabios dislikes -M isapc

2010-02-08 Thread Jan Kiszka
Sebastian Herbszt wrote: > Jan Kiszka wrote: >> Hi, >> >> Seabios seems to have some assumptions built in that break when -M isapc >> is selected. Is this supposed to work or is isapc about to die? > > SeaBIOS doesn't POST if the F-segment is not writeable [1]. A possible, but > IMO > wrong fix w

[Qemu-devel] [PATCH 4/4] QMP: Don't leak on connection close

2010-02-08 Thread Luiz Capitulino
QMP's chardev event callback doesn't call json_message_parser_destroy() on CHR_EVENT_CLOSED. As the call to json_message_parser_init() on CHR_EVENT_OPENED allocates memory, we'are leaking on close. Fix that by just calling json_message_parser_destroy() on CHR_EVENT_CLOSED. Signed-off-by: Luiz Cap

[Qemu-devel] [PATCH 3/4] QError: Don't abort on multiple faults

2010-02-08 Thread Luiz Capitulino
Ideally, Monitor code should report an error only once and return the error information up the call chain. To assure that this happens as expected and that no error is lost, we have an assert() in qemu_error_internal(). However, we still have not fully converted handlers using monitor_printf() to

[Qemu-devel] [PATCH 2/4] Monitor: remove unneeded checks

2010-02-08 Thread Luiz Capitulino
It's not needed to check the return of qobject_from_jsonf() anymore, as an assert() has been added there. Signed-off-by: Luiz Capitulino --- block.c |3 --- hw/pci-hotplug.c |1 - migration.c |3 --- monitor.c|5 - 4 files changed, 0 insertions(+), 12 de

[Qemu-devel] [PATCH 1/4] qjson: Improve debugging

2010-02-08 Thread Luiz Capitulino
Add an assert() to qobject_from_jsonf() to assure that the returned QObject is not NULL. Currently this is duplicated in the callers. Signed-off-by: Luiz Capitulino --- qjson.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/qjson.c b/qjson.c index 9ad8a91..483c667 1

[Qemu-devel] Re: Seabios dislikes -M isapc

2010-02-08 Thread Sebastian Herbszt
Jan Kiszka wrote: Hi, Seabios seems to have some assumptions built in that break when -M isapc is selected. Is this supposed to work or is isapc about to die? SeaBIOS doesn't POST if the F-segment is not writeable [1]. A possible, but IMO wrong fix was posted on the list [2]. [1] http://lists

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Michael S. Tsirkin
On Mon, Feb 08, 2010 at 07:56:27PM +0200, Blue Swirl wrote: > On Mon, Feb 8, 2010 at 7:37 PM, Michael S. Tsirkin wrote: > > On Mon, Feb 08, 2010 at 06:37:41PM +0100, Gerd Hoffmann wrote: > >> On 02/08/10 18:32, Michael S. Tsirkin wrote: > >>> On Mon, Feb 08, 2010 at 06:24:57PM +0100, Gerd Hoffmann

[Qemu-devel] [PATCH] don't dereference NULL after failed strdup

2010-02-08 Thread Jim Meyering
Most of these are obvious NULL-deref bug fixes, for example, the ones in these files: block/curl.c net.c slirp/misc.c and the first one in block/vvfat.c. The others in block/vvfat.c may not lead to an immediate segfault, but I traced the two schedule_rename(..., strdup(path)) uses, and a fa

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Michael S. Tsirkin
On Mon, Feb 08, 2010 at 06:43:51PM +0100, Gerd Hoffmann wrote: > On 02/08/10 18:37, Michael S. Tsirkin wrote: >> On Mon, Feb 08, 2010 at 06:37:41PM +0100, Gerd Hoffmann wrote: >>> On 02/08/10 18:32, Michael S. Tsirkin wrote: On Mon, Feb 08, 2010 at 06:24:57PM +0100, Gerd Hoffmann wrote: >

Re: [Qemu-devel] Re: Two QMP events issues

2010-02-08 Thread Luiz Capitulino
On Mon, 08 Feb 2010 09:13:37 -0600 Anthony Liguori wrote: > On 02/08/2010 08:56 AM, Daniel P. Berrange wrote: > > On Mon, Feb 08, 2010 at 08:49:20AM -0600, Anthony Liguori wrote: > > > >> On 02/08/2010 08:12 AM, Daniel P. Berrange wrote: > >> > >>> For further backgrou, the key end goal

[Qemu-devel] Re: Two QMP events issues

2010-02-08 Thread Luiz Capitulino
On Mon, 8 Feb 2010 14:12:20 + "Daniel P. Berrange" wrote: > On Mon, Feb 08, 2010 at 11:41:45AM -0200, Luiz Capitulino wrote: > > > > Hi there, > > > > I have two not so related QMP events issues two discuss, but I will talk > > about > > them in the same email to avoid starting two threa

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Gerd Hoffmann
On 02/08/10 18:37, Michael S. Tsirkin wrote: On Mon, Feb 08, 2010 at 06:37:41PM +0100, Gerd Hoffmann wrote: On 02/08/10 18:32, Michael S. Tsirkin wrote: On Mon, Feb 08, 2010 at 06:24:57PM +0100, Gerd Hoffmann wrote: On 02/08/10 17:27, Michael S. Tsirkin wrote: On Mon, Feb 08, 2010 at 12:14:11

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Blue Swirl
On Mon, Feb 8, 2010 at 7:37 PM, Michael S. Tsirkin wrote: > On Mon, Feb 08, 2010 at 06:37:41PM +0100, Gerd Hoffmann wrote: >> On 02/08/10 18:32, Michael S. Tsirkin wrote: >>> On Mon, Feb 08, 2010 at 06:24:57PM +0100, Gerd Hoffmann wrote: On 02/08/10 17:27, Michael S. Tsirkin wrote: > On M

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Michael S. Tsirkin
On Mon, Feb 08, 2010 at 06:37:41PM +0100, Gerd Hoffmann wrote: > On 02/08/10 18:32, Michael S. Tsirkin wrote: >> On Mon, Feb 08, 2010 at 06:24:57PM +0100, Gerd Hoffmann wrote: >>> On 02/08/10 17:27, Michael S. Tsirkin wrote: On Mon, Feb 08, 2010 at 12:14:11PM +0100, Gerd Hoffmann wrote: >

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Gerd Hoffmann
On 02/08/10 18:32, Michael S. Tsirkin wrote: On Mon, Feb 08, 2010 at 06:24:57PM +0100, Gerd Hoffmann wrote: On 02/08/10 17:27, Michael S. Tsirkin wrote: On Mon, Feb 08, 2010 at 12:14:11PM +0100, Gerd Hoffmann wrote: On 02/08/10 11:17, Michael S. Tsirkin wrote: On Mon, Feb 08, 2010 at 03:41:47

[Qemu-devel] Re: Slowdowns comparing qemu-kvm.git to qemu.git: vcpu/thread scheduling differences

2010-02-08 Thread Amit Shah
On (Mon) Feb 08 2010 [08:57:05], Anthony Liguori wrote: > On 02/08/2010 07:46 AM, Amit Shah wrote: >> Hello, >> >> In my testing of virtio-console, I found qemu-kvm.git introduces a lot >> of overhead in thread scheduling compared to qemu.git. >> >> My test sends a 260M file from the host to a gues

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Michael S. Tsirkin
On Mon, Feb 08, 2010 at 06:24:57PM +0100, Gerd Hoffmann wrote: > On 02/08/10 17:27, Michael S. Tsirkin wrote: >> On Mon, Feb 08, 2010 at 12:14:11PM +0100, Gerd Hoffmann wrote: >>> On 02/08/10 11:17, Michael S. Tsirkin wrote: On Mon, Feb 08, 2010 at 03:41:47PM +0900, Isaku Yamahata wrote: >

[Qemu-devel] Re: [PATCH] apb_pci: fix header type of pbm pci host bridge.

2010-02-08 Thread Blue Swirl
On Mon, Feb 8, 2010 at 8:45 AM, Isaku Yamahata wrote: > The change set of 776e1bbb6cf4fe66a93c1a5dd814bbb650deca00 > specifies pbm pci host bridge is type of bridge. > It contradicts with pbm_pci_host_init(). Bridge header type in qdev info is needed so that the write masks are correct. Otherwise

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Gerd Hoffmann
On 02/08/10 17:27, Michael S. Tsirkin wrote: On Mon, Feb 08, 2010 at 12:14:11PM +0100, Gerd Hoffmann wrote: On 02/08/10 11:17, Michael S. Tsirkin wrote: On Mon, Feb 08, 2010 at 03:41:47PM +0900, Isaku Yamahata wrote: initialize header type register in pci generic code. Cc: Blue Swirl Cc: "Mic

[Qemu-devel] Re: [PATCH] pci: fix info pci with host bridge.

2010-02-08 Thread Blue Swirl
On Mon, Feb 8, 2010 at 12:37 PM, Michael S. Tsirkin wrote: > On Mon, Feb 08, 2010 at 03:40:38PM +0900, Isaku Yamahata wrote: >> This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5. >> pci host bridge doesn't have header type of bridge. >> The check should be by header type, instead of pci cl

Re: [Qemu-devel] Re: [SeaBIOS] [PATCH] Seabios: Fix PkgLength calculation for the SSDT.

2010-02-08 Thread Anthony Liguori
On 02/08/2010 04:19 AM, Avi Kivity wrote: On 01/12/2010 03:36 PM, Kevin O'Connor wrote: On Tue, Jan 12, 2010 at 10:10:41AM +0100, Magnus Christensson wrote: On 12/24/2009 01:29 AM, Kevin O'Connor wrote: On Mon, Dec 14, 2009 at 10:25:14AM +0100, Magnus Christensson wrote: Should be cpu_length

[Qemu-devel] Re: [PULL] linux-user-for upstream

2010-02-08 Thread Anthony Liguori
On 02/05/2010 08:05 AM, Riku Voipio wrote: Same patchset as sent last week, with the TLS patched changed to the "refactor cp15.c13" patch already acked by Laurent. The following changes since commit 117f8eb81dfdf51a0418fbf6d260cbb72bcd4a9d: Markus Armbruster (1): qdev: Add rudimentar

[Qemu-devel] Re: [PATCH 0/6] [GIT PULL] qemu-kvm.git uq/master queue

2010-02-08 Thread Anthony Liguori
On 02/03/2010 05:55 PM, Marcelo Tosatti wrote: The following changes since commit 117f8eb81dfdf51a0418fbf6d260cbb72bcd4a9d: Markus Armbruster (1): qdev: Add rudimentary help for property value are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Michael S. Tsirkin
On Mon, Feb 08, 2010 at 12:14:11PM +0100, Gerd Hoffmann wrote: > On 02/08/10 11:17, Michael S. Tsirkin wrote: >> On Mon, Feb 08, 2010 at 03:41:47PM +0900, Isaku Yamahata wrote: >>> initialize header type register in pci generic code. >>> >>> Cc: Blue Swirl >>> Cc: "Michael S. Tsirkin" >>> Signed-of

Re: [PATCH] JSON: add %I64d support (Was: Re: [Qemu-devel] system_reset command cause assert failed)

2010-02-08 Thread Anthony Liguori
On 02/04/2010 10:59 AM, Roy Tam wrote: 2010/2/4 Luiz Capitulino: On Thu, 4 Feb 2010 10:30:30 +0800 Roy Tam wrote: 2010/2/4 Roy Tam: 2010/2/3 Luiz Capitulino: OK we are fooled by the json lexer and parser. As we use %I64d to print 'long long' variables in Win32, b

[Qemu-devel] Re: Network shutdown under load

2010-02-08 Thread Tom Lendacky
Fix a race condition where qemu finds that there are not enough virtio ring buffers available and the guest make more buffers available before qemu can enable notifications. Signed-off-by: Tom Lendacky Signed-off-by: Anthony Liguori hw/virtio-net.c | 10 +- 1 files changed, 9 insert

Re: [Qemu-devel] [PATCH] Add assignment operation to config file parser..

2010-02-08 Thread john cooper
Gerd Hoffmann wrote: > On 02/07/10 17:24, Anthony Liguori wrote: >> On 02/06/2010 12:59 PM, john cooper wrote: >>> This patch reworks support for both assignment and >>> append in the config file parser. It was motivated >>> by comments received on the cpu model config file >>> format. >>> >>> Comm

[Qemu-devel] Re: [PATCH 4/4] KVM: Rework of guest debug state writing

2010-02-08 Thread Jan Kiszka
Marcelo Tosatti wrote: > On Thu, Feb 04, 2010 at 08:00:26PM +0100, Jan Kiszka wrote: >> Jan Kiszka wrote: >>> Marcelo Tosatti wrote: Unrelated to this problem, won't put_vcpu_events, which is executed after KVM_SET_GUEST_DEBUG, overwrite any queued debug exceptions? >>> Good point, SET_G

Re: [Qemu-devel] [PATCH 4/4] target-arm: neon fix

2010-02-08 Thread Laurent Desnogues
On Mon, Feb 8, 2010 at 12:47 PM, Riku Voipio wrote: > On Sun, Feb 07, 2010 at 02:02:31PM +0100, Laurent Desnogues wrote: >> On Sun, Feb 7, 2010 at 1:54 PM, Laurent Desnogues >> wrote: >> > On Fri, Feb 5, 2010 at 4:52 PM, Riku Voipio wrote: >> >> From: Juha Riihimäki > >> >> add an extra check i

[Qemu-devel] Re: [PATCH 4/4] KVM: Rework of guest debug state writing

2010-02-08 Thread Marcelo Tosatti
On Thu, Feb 04, 2010 at 08:00:26PM +0100, Jan Kiszka wrote: > Jan Kiszka wrote: > > Marcelo Tosatti wrote: > >> > >> Unrelated to this problem, won't put_vcpu_events, which is executed > >> after KVM_SET_GUEST_DEBUG, overwrite any queued debug exceptions? > > > > Good point, SET_GUEST_DEBUG shoul

[Qemu-devel] Re: [PATCH 4/4] KVM: Rework of guest debug state writing

2010-02-08 Thread Marcelo Tosatti
On Thu, Feb 04, 2010 at 08:21:08PM +0100, Jan Kiszka wrote: > Jan Kiszka wrote: > > Marcelo Tosatti wrote: > >> With kvm-autotest the failure is not sporadic (and the above commit > >> applied): with KVM_SET_GUEST_DEBUG in arch_put_regs all migration > >> tests fail, without, all of them succeed.

[Qemu-devel] Training request

2010-02-08 Thread Jean-Christophe Voisin
French version at the end of mail. Please excuse our English. Hello, We are two apprentice in the last year of our training as engineers. We would like to offer our services for the development of qemu. We have 256 hours of school project to accompling, helped by a teacher and researcher at ESEO

[Qemu-devel] Re: [PATCH] qcow2: don't ignore failed update_refcount

2010-02-08 Thread Jim Meyering
Kevin Wolf wrote: ... > I'm currently working on fixing exactly this, and unfortunaly, no, it's > not that easy. What you introduce looks like proper error handling at > first sight, but what happens in fact is that while the current write > request correctly fails now we're running with corrupted

[Qemu-devel] Re: [PATCH] qcow2: don't ignore failed update_refcount

2010-02-08 Thread Kevin Wolf
Am 08.02.2010 16:01, schrieb Jim Meyering: > update_refcount is marked as a function for which we must use its result, > > static int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs, > > and rightly so, since doing otherwise would amount to ignoring write failure. > However, ther

Re: [Qemu-devel] Re: Two QMP events issues

2010-02-08 Thread Anthony Liguori
On 02/08/2010 08:56 AM, Daniel P. Berrange wrote: On Mon, Feb 08, 2010 at 08:49:20AM -0600, Anthony Liguori wrote: On 02/08/2010 08:12 AM, Daniel P. Berrange wrote: For further backgrou, the key end goal here is that in a QMP client, upon receipt of the 'RESET' event, we need to reli

Re: [Qemu-devel] Emulating MIPS self-examining code

2010-02-08 Thread Aurelien Jarno
On Mon, Feb 08, 2010 at 05:26:33PM +0300, Dmitry Antipov wrote: > Hello, > > I'm trying to emulate the following MIPS code (taken from the bootloader of > my system): > > /* Initialize GOT pointer. > ** Global symbols can't be resolved before this is done, and as such > we can't

Re: [Qemu-devel] [PATCH 1/4] qjson: Improve debugging

2010-02-08 Thread Luiz Capitulino
On Mon, 08 Feb 2010 08:53:26 -0600 Anthony Liguori wrote: > On 02/05/2010 11:14 AM, Markus Armbruster wrote: > >> Run time asserts are a terrible way to deal with reasonably expected > >> errors. > >> > > Yes. But what's reasonably expected entirely depends on the contract > > between the

[Qemu-devel] [PATCH] qcow2: don't ignore failed update_refcount

2010-02-08 Thread Jim Meyering
update_refcount is marked as a function for which we must use its result, static int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs, and rightly so, since doing otherwise would amount to ignoring write failure. However, there are two cases in which the return value is currently

Re: [Qemu-devel] [PATCH] User mode: Handle x86_64 vsyscall

2010-02-08 Thread Vince Weaver
On Sun, 7 Feb 2010, Richard Henderson wrote: > > I imagine that QEMU's VDSO would not have the complicated bits that the > kernel's version does, where it arranges to read the clock without going into > kernel space. I imagine QEMU would simply stuff a normal syscall sequence in > there, which wo

[Qemu-devel] Re: Slowdowns comparing qemu-kvm.git to qemu.git: vcpu/thread scheduling differences

2010-02-08 Thread Anthony Liguori
On 02/08/2010 07:46 AM, Amit Shah wrote: Hello, In my testing of virtio-console, I found qemu-kvm.git introduces a lot of overhead in thread scheduling compared to qemu.git. My test sends a 260M file from the host to a guest via a virtio-console port and then computes the sha1sum of the file on

Re: [Qemu-devel] Re: Two QMP events issues

2010-02-08 Thread Daniel P. Berrange
On Mon, Feb 08, 2010 at 08:49:20AM -0600, Anthony Liguori wrote: > On 02/08/2010 08:12 AM, Daniel P. Berrange wrote: > > > >For further backgrou, the key end goal here is that in a QMP client, upon > >receipt of the 'RESET' event, we need to reliably& immediately determine > >why it occurred. eg

Re: [Qemu-devel] [PATCH 1/4] qjson: Improve debugging

2010-02-08 Thread Anthony Liguori
On 02/05/2010 11:14 AM, Markus Armbruster wrote: Run time asserts are a terrible way to deal with reasonably expected errors. Yes. But what's reasonably expected entirely depends on the contract between the function and its callers. I think we need a function that cannot fail and shouldn

Re: [Qemu-devel] Re: Two QMP events issues

2010-02-08 Thread Anthony Liguori
On 02/08/2010 08:12 AM, Daniel P. Berrange wrote: For further backgrou, the key end goal here is that in a QMP client, upon receipt of the 'RESET' event, we need to reliably& immediately determine why it occurred. eg, triggered by watchdog, or by guest OS request. There are actually 3 possibl

[Qemu-devel] Emulating MIPS self-examining code

2010-02-08 Thread Dmitry Antipov
Hello, I'm trying to emulate the following MIPS code (taken from the bootloader of my system): /* Initialize GOT pointer. ** Global symbols can't be resolved before this is done, and as such we can't ** use any global symbols in this code. We use the bal/ move xxx,ra

[Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Michael S. Tsirkin
On Mon, Feb 08, 2010 at 03:41:47PM +0900, Isaku Yamahata wrote: > initialize header type register in pci generic code. > > Cc: Blue Swirl > Cc: "Michael S. Tsirkin" > Signed-off-by: Isaku Yamahata Applied, thanks. > --- > hw/pci.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-)

[Qemu-devel] Re: Two QMP events issues

2010-02-08 Thread Daniel P. Berrange
On Mon, Feb 08, 2010 at 11:41:45AM -0200, Luiz Capitulino wrote: > > Hi there, > > I have two not so related QMP events issues two discuss, but I will talk > about > them in the same email to avoid starting two threads. > > The first problem is wrt the STOP event. Right now it's only emitted

[Qemu-devel] Slowdowns comparing qemu-kvm.git to qemu.git: vcpu/thread scheduling differences

2010-02-08 Thread Amit Shah
Hello, In my testing of virtio-console, I found qemu-kvm.git introduces a lot of overhead in thread scheduling compared to qemu.git. My test sends a 260M file from the host to a guest via a virtio-console port and then computes the sha1sum of the file on the host as well as on the guest, compares

[Qemu-devel] Two QMP events issues

2010-02-08 Thread Luiz Capitulino
Hi there, I have two not so related QMP events issues two discuss, but I will talk about them in the same email to avoid starting two threads. The first problem is wrt the STOP event. Right now it's only emitted if it's triggered through qemu_system_vmstop_request(), which afaik will only be

[Qemu-devel] iothread + smp 2 + alt-f4 = lock-up

2010-02-08 Thread Jan Kiszka
Just a note, maybe someone finds the time to look at this: Sending ALT-F4 to the SDL window of qemu (stable-0.12 and master) when it was configured with --enable-io-thread and runs -smp 2 or more causes a lock-up of the qemu process. [I currently trigger way too many bugs...] Jan -- Siemens AG

Re: [Qemu-devel] [PATCH] Add assignment operation to config file parser..

2010-02-08 Thread Gerd Hoffmann
On 02/07/10 17:24, Anthony Liguori wrote: On 02/06/2010 12:59 PM, john cooper wrote: This patch reworks support for both assignment and append in the config file parser. It was motivated by comments received on the cpu model config file format. Commit dc9ca4ba27be4fe6a0284061b8f056c4364fb0d9 ch

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Gerd Hoffmann
On 02/08/10 12:16, Michael S. Tsirkin wrote: On Mon, Feb 08, 2010 at 12:14:11PM +0100, Gerd Hoffmann wrote: On 02/08/10 11:17, Michael S. Tsirkin wrote: On Mon, Feb 08, 2010 at 03:41:47PM +0900, Isaku Yamahata wrote: initialize header type register in pci generic code. Cc: Blue Swirl Cc: "Mic

[Qemu-devel] Re: [PATCH] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-08 Thread Avi Kivity
On 02/05/2010 12:18 PM, OHMURA Kei wrote: > dirty-bitmap-traveling is carried out by byte size in qemu-kvm.c. > But We think that dirty-bitmap-traveling by long size is faster than by byte > size especially when most of memory is not dirty. > > > > + > +static int kvm_get_dirty_pages_log_range_by_l

[Qemu-devel] 0.12.2, PowerPC, CPU 750 wrongly identified (?), hardware error

2010-02-08 Thread Bartlomiej Celary
Hi, I've just compiled qemu 0.12.2 for Windows under msys. I am using "-m prep -M 750" options which on 0.11 worked fine. In 012.2 however, I get the following error: qemu: hardware error: PowerPC 601 / 620 / 970 need a 1MB BIOS CPU #0: NIP LR CTR XER MSR 00

Re: [Qemu-devel] [PATCH] use "%lld" instead of "%I64d" for qobject_from_jsonf in monitor.c and migration.c

2010-02-08 Thread Luiz Capitulino
On Mon, 8 Feb 2010 15:42:30 +0800 Roy Tam wrote: > 2010/2/8 TeLeMan : > > The json parser does not support "%I64d", so we have to use "%lld" > > instead of "%I64d". > > > > We use PRId64 with json in more places besides migration.c and > monitor.c, adding %I64d support in json lexer/parser is a

Re: [Qemu-devel] [PATCH 4/4] target-arm: neon fix

2010-02-08 Thread Riku Voipio
On Sun, Feb 07, 2010 at 02:02:31PM +0100, Laurent Desnogues wrote: > On Sun, Feb 7, 2010 at 1:54 PM, Laurent Desnogues > wrote: > > On Fri, Feb 5, 2010 at 4:52 PM, Riku Voipio wrote: > >> From: Juha Riihimäki > >> add an extra check in "two registers and a shift" to ensure element > >> size dec

[Qemu-devel] Re: [PATCH] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-08 Thread Jan Kiszka
OHMURA Kei wrote: >>> Would be great if you could provide a version for upstream as well >>> because it will likely replace this qemu-kvm code on day. >> O.K. We'll prepare it. > > > We have implemented the version for upstream. Some source code are borrowed > from qemu-kvm.c. It is not fully

Re: [Qemu-devel] [PATCH] fix the static compilation for sdl

2010-02-08 Thread Aurelien Jarno
On Mon, Feb 08, 2010 at 01:56:44PM +0800, TeLeMan wrote: > The static compilation for sdl is broken after > 79427693174a553d62f3da44aacd3f19ba8df3a7. > > Signed-off-by: TeLeMan Thanks, applied. > --- > configure |7 +-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git

[Qemu-devel] Re: [PATCH] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-08 Thread OHMURA Kei
>> Would be great if you could provide a version for upstream as well >> because it will likely replace this qemu-kvm code on day. > O.K. We'll prepare it. We have implemented the version for upstream. Some source code are borrowed from qemu-kvm.c. It is not fully tested yet, though. We also

Re: [Qemu-devel] [PATCH 1/4] qjson: Improve debugging

2010-02-08 Thread Luiz Capitulino
On Fri, 05 Feb 2010 18:14:41 +0100 Markus Armbruster wrote: > Anthony Liguori writes: [...] > Yes. But what's reasonably expected entirely depends on the contract > between the function and its callers. > > I think we need a function that cannot fail and shouldn't used with > untrusted argum

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Michael S. Tsirkin
On Mon, Feb 08, 2010 at 12:14:11PM +0100, Gerd Hoffmann wrote: > On 02/08/10 11:17, Michael S. Tsirkin wrote: >> On Mon, Feb 08, 2010 at 03:41:47PM +0900, Isaku Yamahata wrote: >>> initialize header type register in pci generic code. >>> >>> Cc: Blue Swirl >>> Cc: "Michael S. Tsirkin" >>> Signed-of

Re: [Qemu-devel] Re: [PATCH] pci: initialize header type register.

2010-02-08 Thread Gerd Hoffmann
On 02/08/10 11:17, Michael S. Tsirkin wrote: On Mon, Feb 08, 2010 at 03:41:47PM +0900, Isaku Yamahata wrote: initialize header type register in pci generic code. Cc: Blue Swirl Cc: "Michael S. Tsirkin" Signed-off-by: Isaku Yamahata No objections here, I am assuming this will be followed by pa

[Qemu-devel] USB function application on QEMU

2010-02-08 Thread Taimoor Mirza
Hi all, Is it possible to run any linux based USB device side application on QEMU? For example I want to develop a linux based mass storage device and I want to test it on QEMU. BR, Taimoor __

[Qemu-devel] Re: How fun it must be to commit patches without posting them!

2010-02-08 Thread Paolo Bonzini
On 02/08/2010 10:10 AM, Paolo Bonzini wrote: On 02/08/2010 10:09 AM, malc wrote: Because i had a hard disk crash and hence ended up with a new shiny system where QEMU does not build anymore, also not enough patience to revisit the thread and figure out why it wasn't applied yet. Sorry for you,

[Qemu-devel] Re: [PATCH] pci: fix info pci with host bridge.

2010-02-08 Thread Michael S. Tsirkin
On Mon, Feb 08, 2010 at 03:40:38PM +0900, Isaku Yamahata wrote: > This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5. > pci host bridge doesn't have header type of bridge. > The check should be by header type, instead of pci class device. > > Cc: Blue Swirl > Cc: "Michael S. Tsirkin" > Si

[Qemu-devel] Re: [PATCH] pci: fix info pci with host bridge.

2010-02-08 Thread Michael S. Tsirkin
On Mon, Feb 08, 2010 at 12:10:52PM +0200, Michael S. Tsirkin wrote: > On Mon, Feb 08, 2010 at 03:40:38PM +0900, Isaku Yamahata wrote: > > This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5. > > pci host bridge doesn't have header type of bridge. > > The check should be by header type, instea

Re: [Qemu-devel] [PATCH] rtl8139 timer interrupt rewrote

2010-02-08 Thread Frediano Ziglio
2010/2/8 Igor Kovalenko : > On Sun, Feb 7, 2010 at 6:22 PM, Frediano Ziglio wrote: >> rewrote timer implementation for rtl8139. Add a QEMU >> timer only when needed (timeout status not set, timeout irq wanted and >> timer set). >> >> Signed-off-by: Frediano Ziglio >> -- >> diff --git a/hw/rtl8139

[Qemu-devel] Re: [PATCH] pci: fix pci_find_bus()

2010-02-08 Thread Michael S. Tsirkin
On Mon, Feb 08, 2010 at 03:38:36PM +0900, Isaku Yamahata wrote: > typo in c021f8e65f5009a5ab5711d9d5326fcab553ef1c. > comparison fix. > > Cc: Blue Swirl > Cc: "Michael S. Tsirkin" > Signed-off-by: Isaku Yamahata thanks, applied. > --- > hw/pci.c |2 +- > 1 files changed, 1 insertions(+),

  1   2   >