[Qemu-devel] Re: [RFC PATCH 0/5] Introduce canonical device hierarchy string

2010-06-14 Thread Gerd Hoffmann
Hi, My premise with this attempt is that we walk the hierarchy and use the names to create the base of the path. As we get to the device, particularly to the parent bus of the device, we need to start looking at properties to ensure uniqueness. You'll need that for every bus along the way d

[Qemu-devel] [PATCHv2] pass info about hpets to seabios.]

2010-06-14 Thread Gleb Natapov
Currently HPET ACPI table is created regardless of whether qemu actually created hpet device. This may confuse some guests that don't check that hpet is functional before using it. Solve this by passing info about hpets in qemu to seabios via fw config interface. Additional benefit is that seabios

[Qemu-devel] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-14 Thread Gleb Natapov
Load hpet info for HPET ACPI table from qemu instead of using hardcoded values. Use hardcoded values anyway if old qemu is detected. Signed-off-by: Gleb Natapov diff --git a/src/acpi.c b/src/acpi.c index 0559443..864f1a8 100644 --- a/src/acpi.c +++ b/src/acpi.c @@ -469,7 +469,7 @@ build_ssdt(voi

Re: [Qemu-devel] [PATCH v2 2/7] ioapic: convert to qdev

2010-06-14 Thread Markus Armbruster
Blue Swirl writes: > Convert to qdev. > > Signed-off-by: Blue Swirl > --- > hw/apic.h|2 -- > hw/ioapic.c | 45 ++--- > hw/pc.h |4 +++- > hw/pc_piix.c | 19 ++- > 4 files changed, 51 insertions(+), 19 deletions(-) >

Re: [Qemu-devel] [PATCH 2/2] Return usb device to host on exit

2010-06-14 Thread Gerd Hoffmann
@@ -1066,6 +1077,7 @@ USBDevice *usb_host_device_open(const char *devname) qdev_prop_set_uint32(&dev->qdev, "vendorid", filter.vendor_id); qdev_prop_set_uint32(&dev->qdev, "productid", filter.product_id); qdev_init_nofail(&dev->qdev); +atexit(usb_host_cleanup); return

[Qemu-devel] [PATCH 0/5] [QEMU-KVM]: Add BSG backstore using struct sg_io_v4

2010-06-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Quick resend with project subject for cover letter.. Greetings Gerd, Hannes and co, This series adds initial support for a hw/scsi-bsg.c backstore for scsi-bus compatible HBA emulation in QEMU-KVM on Linux hosts supporting the BSG driver. This code is available from the

Re: [Qemu-devel] [PATCH v2 7/7] apic: qdev conversion cleanup

2010-06-14 Thread Markus Armbruster
Blue Swirl writes: > Make APICState completely private to apic.c by using DeviceState > in external APIs. Could you explain why this is an improvement?

[Qemu-devel] [PATCH 4/5] [scsi]: Add BSG support for scsi-bus and scsi-disk

2010-06-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch updates hw/scsi-bus.c:scsi_bus_legacy_add_drive() to check for the scsi-bsg backstore. It also updates hw/scsi-disk.c:scsi_disk_initfn() to check for when bdrv_is_bsg() is present and we need to fail for the fileio backed scsi-disk code. Signed-off-by: Nich

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2010-06-14 Thread Dave Walker
Changing to libvirt as commentary here, and on the upstream bug report by Cole indicate a fix has been commit that improves this performance. ** Package changed: qemu-kvm (Ubuntu) => libvirt (Ubuntu) ** Also affects: libvirt via https://bugzilla.redhat.com/show_bug.cgi?id=599091 Importance:

[Qemu-devel] [PATCH 3/5] [block]: Add paio_submit_len() non sector sized AIO

2010-06-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds posix-aio-compat.c:paio_submit_len(), which is a identical to paio_submit() expect that in expected nb_len instead of nb_sectors (* 512) so that it can be used by BSG AIO for write()/read() of struct sg_io_v4. Signed-off-by: Nicholas A. Bellinger --- bl

Re: [Qemu-devel] [PATCH] qemu-iotests: qcow2 error path tests

2010-06-14 Thread Kevin Wolf
Am 14.06.2010 11:38, schrieb Christoph Hellwig: > On Fri, Jun 04, 2010 at 07:35:24PM +0200, Kevin Wolf wrote: >> This adds test cases for qcow2 error paths (using blkdebug) > > Thanks, applied. > > What's the plan for getting the fixes this tests into mainline? The test passes in the block branc

[Qemu-devel] [PATCH 0/5] *** SUBJECT HERE ***

2010-06-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Greetings Gerd, Hannes and co, This series adds initial support for a hw/scsi-bsg.c backstore for scsi-bus compatible HBA emulation in QEMU-KVM on Linux hosts supporting the BSG driver. This code is available from the scsi-bsg branch in the megasas/scsi friendly QEMU-KV

[Qemu-devel] [PATCH 5/5] [scsi-bsg]: Add initial support for BSG based SCSIDeviceInfo

2010-06-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds initial support for using the Linux BSG interface with write/read vectored AIO as a QEMU backstore (SCSIDeviceInfo) with hw/scsi-bus.c compatible HBA emulation. So far it has been tested with x86_64 host and guest using hw/megasas.c and TCM_Loop LLD Po

[Qemu-devel] [PATCH 1/5] [block]: Add top level BSG support

2010-06-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds top level BSG support to QEMU-KVM block and adds the BDS_* prefixed defines for SG_IO and BSG. It adds the BDS_SCSI_GENERIC and BDS_BSG assignments in block/raw-posix.c:hdev_open() using S_ISCHR() and major(st.st_rdev) in order to determine when we are d

[Qemu-devel] [PATCH 2/5] [block]: Add BSG qemu_open() in block/raw.c:raw_open()

2010-06-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds a BSG specific qemu_open() call in block/raw.c:raw_open() that saves the opened file descriptor for BSG AIO into BlockDriverState->fd. It also adds the reverse close() call to block/raw.c:raw_close() Signed-off-by: Nicholas A. Bellinger --- block/raw.c

Re: [Qemu-devel] [PATCH] qemu-iotests: qcow2 error path tests

2010-06-14 Thread Christoph Hellwig
On Fri, Jun 04, 2010 at 07:35:24PM +0200, Kevin Wolf wrote: > This adds test cases for qcow2 error paths (using blkdebug) Thanks, applied. What's the plan for getting the fixes this tests into mainline?

Re: [Qemu-devel] [Bug 524447] Re: virsh save is very slow

2010-06-14 Thread Michael Tokarev
14.06.2010 13:37, Dave Walker wrote: Changing to libvirt as commentary here, and on the upstream bug report by Cole indicate a fix has been commit that improves this performance. Um. This is not that simple, apparently. I did some tests after this bug were discussed/mentioned last time, and s

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2010-06-14 Thread Dave Walker
Re-introducing qemu-kvm, as commentary on qemu-devel mailing list suggest there could be a timing concern meaning poor performance. Leaving Libvirt on this report, as upstream libvirt have quoted improved performance adjusting the block size for dd. However, Qemu feel that the real issue is in the

[Qemu-devel] Re: [PATCH 3/5] [block]: Add paio_submit_len() non sector sized AIO

2010-06-14 Thread Christoph Hellwig
On Mon, Jun 14, 2010 at 02:44:31AM -0700, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch adds posix-aio-compat.c:paio_submit_len(), which is a identical > to paio_submit() expect that in expected nb_len instead of nb_sectors (* 512) > so that it can be used by BSG AIO for

[Qemu-devel] [PATCH] SeaBIOS: Fix bvprintf() to respect padding for hex printing.

2010-06-14 Thread Jes . Sorensen
From: Jes Sorensen Fix bvprintf to respect space padding when printing hex numbers and the caller specifies alignment without zero padding, eg. %2x as opposed to %02x Signed-off-by: Jes Sorensen --- src/output.c | 27 +-- 1 files changed, 21 insertions(+), 6 deletions

[Qemu-devel] Re: [PATCH 3/5] [block]: Add paio_submit_len() non sector sized AIO

2010-06-14 Thread Nicholas A. Bellinger
On Mon, 2010-06-14 at 07:42 -0400, Christoph Hellwig wrote: > On Mon, Jun 14, 2010 at 02:44:31AM -0700, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch adds posix-aio-compat.c:paio_submit_len(), which is a identical > > to paio_submit() expect that in expected nb_len

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-14 Thread Alex Williamson
On Mon, 2010-06-14 at 08:39 +0200, Markus Armbruster wrote: > Alex Williamson writes: > > > qdev_get_dev_path() is intended to be the canonical utility for creating > > a string representing the qdev hierarchy of a device. The path consists > > of bus and device names as well as identified prope

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-14 Thread Paul Brook
> > > "/main-system-bus/pci.0,addr=09.0/virtio-blk-pci" There's a device missing between the main system bus and the pci bus. Should be something like: /main-system-bus/piix4-pcihost/pci.0/_09.0 > > Could you explain why you add "identified properties of the immediate > > parent bus and device

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-14 Thread Jan Kiszka
Alex Williamson wrote: > On Mon, 2010-06-14 at 08:39 +0200, Markus Armbruster wrote: >> Alex Williamson writes: >> >>> qdev_get_dev_path() is intended to be the canonical utility for creating >>> a string representing the qdev hierarchy of a device. The path consists >>> of bus and device names a

[Qemu-devel] ARM/system mode/stdin

2010-06-14 Thread Christophe LYON
Hello, I am trying to use qemu-system-arm (0.12.3) to execute an ARM bare machine program (not a Linux kernel), and I have some trouble when the program in question tries to read from stdin. The program does use ARM semihosting to communicate with the host. Here is the sample code: =

[Qemu-devel] Q35 qemu repository?

2010-06-14 Thread Matthew Garrett
Hi there, I'm currently doing some work on tidying up Linux's PCIe ASPM support, and one thing that would be useful would be to be able to instrument reads and writes made by Windows to PCIe space. I noticed that you've been working on Q35 support for qemu - is there a public repository which

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-14 Thread Anthony Liguori
On 06/12/2010 06:14 AM, Juan Quintela wrote: Anthony Liguori wrote: On 06/11/2010 09:30 AM, Luiz Capitulino wrote: On Thu, 10 Jun 2010 12:44:55 +0200 Juan Quintela wrote: I think we've more or less agreed that MIGRATION_CONNECTED is really the event we want. Thi

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-14 Thread Kevin O'Connor
On Mon, Jun 14, 2010 at 11:30:53AM +0300, Gleb Natapov wrote: > Load hpet info for HPET ACPI table from qemu instead of using hardcoded > values. Use hardcoded values anyway if old qemu is detected. The current code does a lot of mixing of qemu provided and seabios provided data to build the acpi

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-14 Thread Anthony Liguori
On 06/12/2010 06:05 AM, Juan Quintela wrote: Luiz Capitulino wrote: On Thu, 10 Jun 2010 12:44:55 +0200 Juan Quintela wrote: Luiz Capitulino wrote: On Wed, 9 Jun 2010 14:10:53 +0200 Juan Quintela wrote: This is a resent with what we agreed on yesterday call.

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-14 Thread Gleb Natapov
On Mon, Jun 14, 2010 at 09:54:25AM -0400, Kevin O'Connor wrote: > On Mon, Jun 14, 2010 at 11:30:53AM +0300, Gleb Natapov wrote: > > Load hpet info for HPET ACPI table from qemu instead of using hardcoded > > values. Use hardcoded values anyway if old qemu is detected. > > The current code does a l

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-14 Thread Luiz Capitulino
On Mon, 14 Jun 2010 08:58:19 -0500 Anthony Liguori wrote: > For 0.13, we need to focus on introducing the least disruptive change > that addresses the fundamental requirement--allow clients to avoid a > polling loop for determining when migration ends. Having a single event > with no payload

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-14 Thread Anthony Liguori
On 06/14/2010 09:24 AM, Luiz Capitulino wrote: On Mon, 14 Jun 2010 08:58:19 -0500 Anthony Liguori wrote: For 0.13, we need to focus on introducing the least disruptive change that addresses the fundamental requirement--allow clients to avoid a polling loop for determining when migration en

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-14 Thread Luiz Capitulino
On Sat, 12 Jun 2010 13:20:54 +0200 Juan Quintela wrote: > Luiz Capitulino wrote: > > On Fri, 11 Jun 2010 09:38:42 -0500 > > Anthony Liguori wrote: > > > >> > 1. QMP only returns the response when the command is finished, eg: > >> > > >> > C: { "execute": "migrate", "id": "foo" ... } > >>

Re: [Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-14 Thread Jamie Lokier
Gleb Natapov wrote: > On Mon, Jun 14, 2010 at 09:54:25AM -0400, Kevin O'Connor wrote: > > Could we just have qemu build the hpet tables and pass them through to > > seabios? Perhaps using the qemu_cfg_acpi_additional_tables() method. > > > Possible, and I considered that. I personally prefer to p

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-14 Thread Luiz Capitulino
On Mon, 14 Jun 2010 09:35:52 -0500 Anthony Liguori wrote: > On 06/14/2010 09:24 AM, Luiz Capitulino wrote: > > On Mon, 14 Jun 2010 08:58:19 -0500 > > Anthony Liguori wrote: > > > > > >> For 0.13, we need to focus on introducing the least disruptive change > >> that addresses the fundamental

[Qemu-devel] [PATCH 0/2] qcow2: Simplify image creation code

2010-06-14 Thread Kevin Wolf
Juan, you've complained a few times in the past about how complicated the qcow_create2 code was. I hope you'll like this one. :-) Kevin Wolf (2): qcow2: Simplify image creation qcow2: Remove old image creation function block/qcow2.c | 272 ++--

[Qemu-devel] [PATCH 1/2] qcow2: Simplify image creation

2010-06-14 Thread Kevin Wolf
Instead of doing lots of magic for setting up initial refcount blocks and stuff create a minimal (inconsistent) image, open it and initialize the rest with regular qcow2 functions. This is a complete rewrite of the image creation function. The old implementating is #ifdef'd out and will be removed

[Qemu-devel] [PATCH 2/2] qcow2: Remove old image creation function

2010-06-14 Thread Kevin Wolf
They have been #ifdef'd out by the previous patch. Signed-off-by: Kevin Wolf --- block/qcow2.c | 224 - 1 files changed, 0 insertions(+), 224 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index acb850c..6f26564 100644 --- a/bloc

Re: [Qemu-devel] [PATCH 13/13] blockdev: New -blockdev to define a host block device

2010-06-14 Thread Anthony Liguori
On 06/02/2010 11:55 AM, Markus Armbruster wrote: Existing -drive defines both host and guest part. To make it work with -device, we created if=none. But all this does is peel off guest device selection. The other guest properties such as geometry, removable vs. fixed media, and serial number a

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-14 Thread Avi Kivity
On 06/14/2010 05:09 PM, Gleb Natapov wrote: Could we just have qemu build the hpet tables and pass them through to seabios? Perhaps using the qemu_cfg_acpi_additional_tables() method. Possible, and I considered that. I personally prefer to pass minimum information required for seabios to

[Qemu-devel] [PATCH 1/2] Remove unused DEBUG defines from hw/msix.c

2010-06-14 Thread Jes . Sorensen
From: Jes Sorensen Remove unused DEBUG defines from hw/msix.c to avoid having anything define the word DEBUG without any additions such as MSIX_DEBUG. Signed-off-by: Jes Sorensen --- hw/msix.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/hw/msix.c b/hw/msix.

[Qemu-devel] [PATCH 0/2] Remove naked #define DEBUG to allow -DDEBUG builds

2010-06-14 Thread Jes . Sorensen
From: Jes Sorensen Hi, To address https://sourceforge.net/tracker/?func=detail&aid=1945129&group_id=180599&atid=893831 this patch removes two cases where drivers would define 'DEBUG' naked instead of using E1000_DEBUG or similar. Such usage of DEBUG conflicts with the possibility to build QEMU

[Qemu-devel] [PATCH 2/2] Change #define DEBUG to #define E1000_DEBUG in hw/e1000.c

2010-06-14 Thread Jes . Sorensen
From: Jes Sorensen Change #define DEBUG to #define E1000_DEBUG in hw/e1000.c to make it possible to build QEMU with -DDEBUG Signed-off-by: Jes Sorensen --- hw/e1000.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index 96d045d..0da65f9 1006

[Qemu-devel] [RESENT PATCH 2/2] vnc: sync lock modifier state on connect.

2010-06-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- vnc.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/vnc.c b/vnc.c index b25b6a1..039fb21 100644 --- a/vnc.c +++ b/vnc.c @@ -2300,6 +2300,7 @@ static void vnc_connect(VncDisplay *vd, int csock) if (vs->vd->lock_key_sync) {

[Qemu-devel] [RESENT PATCH 1/2] switch keyboard led state notification to notifiers.

2010-06-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- console.h | 11 +++ input.c | 37 - vnc.c | 13 - vnc.h |2 +- 4 files changed, 28 insertions(+), 35 deletions(-) diff --git a/console.h b/console.h index cac959f..171b32c 100644 --- a/c

[Qemu-devel] [RfC PATCH] add pflib: PixelFormat conversion library.

2010-06-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- Makefile.objs |1 + pflib.c | 204 + pflib.h |6 ++ 3 files changed, 211 insertions(+), 0 deletions(-) create mode 100644 pflib.c create mode 100644 pflib.h diff --git a/Makefile.objs

[Qemu-devel] [RESENT PATCH] Add exit notifiers.

2010-06-14 Thread Gerd Hoffmann
Hook up any cleanup work which needs to be done here. Advantages over using atexit(3): (1) You get passed in a pointer to the notifier. If you embed that into your state struct you can use container_of() to get get your state info. (2) You can unregister, say when un-plugging a d

[Qemu-devel] [RESENT PATCH 3/3] Fix and simplify gui timer logic.

2010-06-14 Thread Gerd Hoffmann
Kill nographic timer. Have a global gui_timer instead. Have the gui timer enabled unconditionally. We need a timer running anyway for mmio flush, so the whole have-gui-timer-only-when-needed logic is pretty pointless. It also simplifies displaylisteners coming and going at runtime, we don't nee

[Qemu-devel] [RESENT PATCH 2/3] add unregister_displaychangelistener

2010-06-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- console.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/console.h b/console.h index 3a80dca..a0da498 100644 --- a/console.h +++ b/console.h @@ -227,6 +227,11 @@ static inline void register_displaychangelistener(DisplayState *ds, Di

Re: [Qemu-devel] [RfC PATCH] add pflib: PixelFormat conversion library.

2010-06-14 Thread Anthony Liguori
On 06/14/2010 10:25 AM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- Makefile.objs |1 + pflib.c | 204 + pflib.h |6 ++ 3 files changed, 211 insertions(+), 0 deletions(-) create mode 100644 pflib.c cre

[Qemu-devel] [RESENT PATCH 1/3] QLIST-ify display change listeners.

2010-06-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- console.h | 72 +++ hw/xenfb.c |2 +- vl.c |9 ++- 3 files changed, 42 insertions(+), 41 deletions(-) diff --git a/console.h b/console.h index cac959f..3a80dca 100644 --- a/console.h ++

[Qemu-devel] [RfC PATCH] Fix vnc memory corruption with width = 1400

2010-06-14 Thread Gerd Hoffmann
vnc assumes that the screen width is a multiple of 16 in several places. If this is not the case vnc will overrun buffers, corrupt memory, make qemu crash. This is the minimum fix for this bug. It makes sure we don't overrun the scanline, thereby fixing the segfault. The rendering is *not* correc

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-14 Thread Alex Williamson
On Mon, 2010-06-14 at 14:09 +0100, Paul Brook wrote: > > > > "/main-system-bus/pci.0,addr=09.0/virtio-blk-pci" > > There's a device missing between the main system bus and the pci bus. Should > be something like: > > /main-system-bus/piix4-pcihost/pci.0/_09.0 Ok, I can easily come up with: /S

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-14 Thread Paul Brook
> On Mon, 2010-06-14 at 14:09 +0100, Paul Brook wrote: > > > > > "/main-system-bus/pci.0,addr=09.0/virtio-blk-pci" > > > > There's a device missing between the main system bus and the pci bus. > > Should be something like: > > > > /main-system-bus/piix4-pcihost/pci.0/_09.0 > > Ok, I can easily

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-14 Thread Juan Quintela
Luiz Capitulino wrote: > On Sat, 12 Jun 2010 13:20:54 +0200 > Juan Quintela wrote: >> Both. > > What does it report in the source? That migration has started :) Nothing else, nothing less. Think again multiple monitors and/or audit. >> Why can't we just tell them that migration has ended wi

[Qemu-devel] [PATCH v2] add pflib: PixelFormat conversion library.

2010-06-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- Makefile.objs |1 + pflib.c | 213 + pflib.h |6 ++ 3 files changed, 220 insertions(+), 0 deletions(-) create mode 100644 pflib.c create mode 100644 pflib.h diff --git a/Makefile.objs

Re: [Qemu-devel] [PATCH v6 4/6] Add support for marking memory to not be migrated. On migration, memory is checked for the NO_MIGRATION_FLAG.

2010-06-14 Thread Anthony Liguori
On 06/04/2010 04:45 PM, Cam Macdonell wrote: This is useful for devices that do not want to take memory regions data with them on migration. --- arch_init.c | 28 cpu-all.h|2 ++ cpu-common.h |2 ++ exec.c | 12 4 files chang

Re: [Qemu-devel] Re: [PATCH v6 0/6] Inter-VM Shared Memory Device with migration support

2010-06-14 Thread Anthony Liguori
On 06/11/2010 05:03 PM, Cam Macdonell wrote: Hi Anthony, Is my implementation of master/peer roles acceptable? Yes, it looks good. I realize with Alex's RAMList changes I may need to modify my patch, but is the approach of marking memory non-migratable an acceptable implementation?

Re: [Qemu-devel] [PATCH v6 6/6] the stand-alone shared memory server for inter-VM shared memory

2010-06-14 Thread Anthony Liguori
On 06/04/2010 04:45 PM, Cam Macdonell wrote: this code is a standalone server which will pass file descriptors for the shared memory region and eventfds to support interrupts between guests using inter-VM shared memory. --- contrib/ivshmem-server/Makefile | 16 ++ contrib/ivshmem-ser

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-14 Thread Jan Kiszka
Alex Williamson wrote: > On Mon, 2010-06-14 at 14:09 +0100, Paul Brook wrote: > "/main-system-bus/pci.0,addr=09.0/virtio-blk-pci" >> There's a device missing between the main system bus and the pci bus. >> Should >> be something like: >> >> /main-system-bus/piix4-pcihost/pci.0/_09.0 > > Ok,

Re: [Qemu-devel] [PATCH 00/10][PULL]: QMP/Monitor queue

2010-06-14 Thread Anthony Liguori
On 06/11/2010 02:58 PM, Luiz Capitulino wrote: Hi Anthony, The following QMP/Monitor patches have been sent to the list and look good to me. I have also tested most of them. The changes (since 0e2029a063405091ee34170ef71aa321715e4357) are available in the following repository: git:/

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-14 Thread Juan Quintela
Anthony Liguori wrote: > On 06/12/2010 06:05 AM, Juan Quintela wrote: >> Luiz Capitulino wrote: >> The monitor that did it knows it, nobody else knows it. At destination >> time, I guess you agree this is important, i.e. the management app knows >> that migration has started. >> > > Dual mo

Re: [Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-14 Thread Gleb Natapov
On Mon, Jun 14, 2010 at 03:40:16PM +0100, Jamie Lokier wrote: > Gleb Natapov wrote: > > On Mon, Jun 14, 2010 at 09:54:25AM -0400, Kevin O'Connor wrote: > > > Could we just have qemu build the hpet tables and pass them through to > > > seabios? Perhaps using the qemu_cfg_acpi_additional_tables() me

Re: [Qemu-devel] [PATCH v6 4/6] Add support for marking memory to not be migrated. On migration, memory is checked for the NO_MIGRATION_FLAG.

2010-06-14 Thread Anthony Liguori
On 06/14/2010 11:08 AM, Cam Macdonell wrote: On Mon, Jun 14, 2010 at 9:51 AM, Anthony Liguori wrote: On 06/04/2010 04:45 PM, Cam Macdonell wrote: This is useful for devices that do not want to take memory regions data with them on migration. --- arch_init.c | 28

[Qemu-devel] ARM Cortex-M3 Resets

2010-06-14 Thread Christopher Johnson
I am attempting to run FreeRTOS under qemu-system-arm 0.12. I am compiling from source. At the current time arm-test works fine. It uses a boot loader with the expectation that the PC=0 after Reset is de-asserted. The CORTEXT-M3 reference states: NVIC resets, holds core in reset NVIC clears mos

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-14 Thread Anthony Liguori
On 06/14/2010 11:02 AM, Juan Quintela wrote: Anthony Liguori wrote: On 06/12/2010 06:05 AM, Juan Quintela wrote: Luiz Capitulino wrote: The monitor that did it knows it, nobody else knows it. At destination time, I guess you agree this is important, i.e. the managemen

Re: [Qemu-devel] [PATCH v6 4/6] Add support for marking memory to not be migrated. On migration, memory is checked for the NO_MIGRATION_FLAG.

2010-06-14 Thread Cam Macdonell
On Mon, Jun 14, 2010 at 9:51 AM, Anthony Liguori wrote: > On 06/04/2010 04:45 PM, Cam Macdonell wrote: >> >> This is useful for devices that do not want to take memory regions data >> with them on migration. >> --- >>  arch_init.c  |   28 >>  cpu-all.h    |    2 ++ >>

Re: [Qemu-devel] [PATCH 15/35] tcg-s390: Query instruction extensions that are installed.

2010-06-14 Thread Richard Henderson
On 06/13/2010 03:23 PM, Alexander Graf wrote: > On 13.06.2010, at 18:44, Aurelien Jarno wrote: >> Is KVM in 31-bit mode actually functional? > > I'm not aware of anything preventing it to be. But I honestly haven't > tried. As long as all hypercall parameters stay within the first > 32/31 bits, th

Re: [Qemu-devel] [PATCH] qemu-option: Fix uninitialized value in append_option_parameter

2010-06-14 Thread Anthony Liguori
On 06/11/2010 03:19 AM, Kevin Wolf wrote: When dest is NULL, i.e. a new copy of the list is created, we don't get a properly terminated list after the realloc. Initialize it as an empty list. Signed-off-by: Kevin Wolf Applied. Thanks. Regards, Anthony Liguori --- Xudong, can you plea

Re: [Qemu-devel] [PATCH] Make netdev_del delete the netdev even when it's in use

2010-06-14 Thread Anthony Liguori
On 06/11/2010 07:21 AM, Markus Armbruster wrote: To hot-unplug guest and host part of a network device, you do: device_del NIC-ID netdev_del NETDEV-ID For PCI devices, device_del merely tells ACPI to unplug the device. The device goes away for real only after the guest processed the A

Re: [Qemu-devel] [PATCH v2] ram_blocks: Convert to a QLIST

2010-06-14 Thread Anthony Liguori
On 06/11/2010 12:11 PM, Alex Williamson wrote: This makes the RAM block list easier to manipulate. Also incorporate relevant variables into the RAMList struct. Signed-off-by: Alex Williamson Acked-by: Chris Wright Applied. Thanks. Regards, Anthony Liguori --- v2: For qemu.git this ti

Re: [Qemu-devel] [PATCH] hpet: Init capability register only once

2010-06-14 Thread Anthony Liguori
On 06/14/2010 01:40 AM, Jan Kiszka wrote: From: Jan Kiszka The capability register is read-only from guest POV, so we do not need to update it on reset. Signed-off-by: Jan Kiszka Applied. Thanks. Regards, Anthony Liguori --- hw/hpet.c |9 + 1 files changed, 5 insertions

Re: [Qemu-devel] [PATCH 1/2] Remove unused DEBUG defines from hw/msix.c

2010-06-14 Thread Anthony Liguori
On 06/14/2010 10:05 AM, jes.soren...@redhat.com wrote: From: Jes Sorensen Remove unused DEBUG defines from hw/msix.c to avoid having anything define the word DEBUG without any additions such as MSIX_DEBUG. Signed-off-by: Jes Sorensen Applied. Thanks. Regards, Anthony Liguori --- hw

Re: [Qemu-devel] [PATCHv2] pass info about hpets to seabios.]

2010-06-14 Thread Anthony Liguori
On 06/14/2010 03:29 AM, Gleb Natapov wrote: Currently HPET ACPI table is created regardless of whether qemu actually created hpet device. This may confuse some guests that don't check that hpet is functional before using it. Solve this by passing info about hpets in qemu to seabios via fw config

Re: [Qemu-devel] [PATCH v2] add pflib: PixelFormat conversion library.

2010-06-14 Thread Anthony Liguori
On 06/14/2010 10:46 AM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- Makefile.objs |1 + pflib.c | 213 + pflib.h |6 ++ 3 files changed, 220 insertions(+), 0 deletions(-) create mode 100644 pflib.c cre

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-14 Thread Alex Williamson
On Mon, 2010-06-14 at 18:00 +0200, Jan Kiszka wrote: > Alex Williamson wrote: > > On Mon, 2010-06-14 at 14:09 +0100, Paul Brook wrote: > > "/main-system-bus/pci.0,addr=09.0/virtio-blk-pci" > >> There's a device missing between the main system bus and the pci bus. > >> Should > >> be somethin

[Qemu-devel] [PATCH] lsi53c895a: fix Phase Mismatch Jump

2010-06-14 Thread Paolo Bonzini
lsi_bad_phase has a bug in the choice of pmjad1/pmjad2. This does not matter with Linux guests because it uses just one routine for both, but it breaks Windows 64-bit guests. This is the text from the spec: "[The PMJCTL] bit controls which decision mechanism is used when jumping on phase m

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-14 Thread Jan Kiszka
Alex Williamson wrote: > On Mon, 2010-06-14 at 18:00 +0200, Jan Kiszka wrote: >> Alex Williamson wrote: >>> On Mon, 2010-06-14 at 14:09 +0100, Paul Brook wrote: >>> "/main-system-bus/pci.0,addr=09.0/virtio-blk-pci" There's a device missing between the main system bus and the pci bus. >>>

Re: [Qemu-devel] [PATCH 0/5] Add '-device help' output for device params and help text

2010-06-14 Thread Anthony Liguori
On 06/08/2010 12:21 AM, Amit Shah wrote: On (Mon) Jun 07 2010 [11:09:32], Anthony Liguori wrote: On 05/31/2010 07:41 AM, Amit Shah wrote: Hello, This patch series adds support to specify some descriptive help text to qdev device parameters. This series adds some help text to the virt

Re: [Qemu-devel] [PATCH] monitor: Add force option support to pci_del command

2010-06-14 Thread Anthony Liguori
On 06/09/2010 09:27 AM, Gerd Hoffmann wrote: Hi, This make sense when you mistakenly add a pci device on a -s -S scenario, like the scenario described on the following bug: https://bugs.launchpad.net/qemu/+bug/544367. It doesn't IMHO. When ACPI-based hotplug support is present on the gues

Re: [Qemu-devel] [PATCH] Add optional dump of default config file paths..

2010-06-14 Thread Anthony Liguori
On 06/09/2010 03:05 AM, john cooper wrote: This patch adds the ability to determine the build-configured runtime "config file" paths from the command line. After support for cpu model definitions were added to the default runtime "target-" config file, testing of this feature has tripped over an

[Qemu-devel] Re: [PATCH] lsi53c895a: fix Phase Mismatch Jump

2010-06-14 Thread Jan Kiszka
Paolo Bonzini wrote: > lsi_bad_phase has a bug in the choice of pmjad1/pmjad2. This does > not matter with Linux guests because it uses just one routine for > both, but it breaks Windows 64-bit guests. This is the text > from the spec: > >"[The PMJCTL] bit controls which decision mechanism i

Re: [Qemu-devel] [PATCH] Add optional dump of default config file paths..

2010-06-14 Thread Daniel P. Berrange
On Mon, Jun 14, 2010 at 12:01:42PM -0500, Anthony Liguori wrote: > On 06/09/2010 03:05 AM, john cooper wrote: > >This patch adds the ability to determine the build-configured > >runtime "config file" paths from the command line. After > >support for cpu model definitions were added to the default

Re: [Qemu-devel] [PATCH] Fix and simplify gui timer logic.

2010-06-14 Thread Anthony Liguori
On 06/08/2010 08:18 AM, Gerd Hoffmann wrote: On 06/08/10 13:50, Paul Brook wrote: Kill nographic timer. Have a global gui_timer instead. Have the gui timer enabled unconditionally. We need a timer running anyway for mmio flush, so the whole have-gui-timer-only-when-needed logic is pretty po

Re: [Qemu-devel] Re: [PATCH] lsi53c895a: fix Phase Mismatch Jump

2010-06-14 Thread Michal Novotny
On 06/14/2010 07:05 PM, Jan Kiszka wrote: Paolo Bonzini wrote: lsi_bad_phase has a bug in the choice of pmjad1/pmjad2. This does not matter with Linux guests because it uses just one routine for both, but it breaks Windows 64-bit guests. This is the text from the spec: "[The PMJCTL] b

[Qemu-devel] [PATCH v2] lsi53c895a: fix Phase Mismatch Jump

2010-06-14 Thread Paolo Bonzini
lsi_bad_phase has a bug in the choice of pmjad1/pmjad2. This does not matter with Linux guests because it uses just one routine for both, but it breaks Windows 64-bit guests. This is the text from the spec: "[The PMJCTL] bit controls which decision mechanism is used when jumping on phase m

Re: [Qemu-devel] Re: [PATCH] lsi53c895a: fix Phase Mismatch Jump

2010-06-14 Thread Jan Kiszka
Michal Novotny wrote: > On 06/14/2010 07:05 PM, Jan Kiszka wrote: >> Paolo Bonzini wrote: >> >>> lsi_bad_phase has a bug in the choice of pmjad1/pmjad2. This does >>> not matter with Linux guests because it uses just one routine for >>> both, but it breaks Windows 64-bit guests. This is the t

Re: [Qemu-devel] Re: [PATCH] lsi53c895a: fix Phase Mismatch Jump

2010-06-14 Thread Michal Novotny
On 06/14/2010 07:05 PM, Jan Kiszka wrote: Paolo Bonzini wrote: lsi_bad_phase has a bug in the choice of pmjad1/pmjad2. This does not matter with Linux guests because it uses just one routine for both, but it breaks Windows 64-bit guests. This is the text from the spec: "[The PMJCTL] b

Re: [Qemu-devel] Re: [PATCH] lsi53c895a: fix Phase Mismatch Jump

2010-06-14 Thread Michal Novotny
On 06/14/2010 07:31 PM, Jan Kiszka wrote: Michal Novotny wrote: On 06/14/2010 07:05 PM, Jan Kiszka wrote: Paolo Bonzini wrote: lsi_bad_phase has a bug in the choice of pmjad1/pmjad2. This does not matter with Linux guests because it uses just one routine for both, but it br

Re: [Qemu-devel] [PATCH v2 2/7] ioapic: convert to qdev

2010-06-14 Thread Blue Swirl
On Mon, Jun 14, 2010 at 9:33 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> Convert to qdev. >> >> Signed-off-by: Blue Swirl >> --- >>  hw/apic.h    |    2 -- >>  hw/ioapic.c  |   45 ++--- >>  hw/pc.h      |    4 +++- >>  hw/pc_piix.c |   19 ++

Re: [Qemu-devel] [PATCH 15/35] tcg-s390: Query instruction extensions that are installed.

2010-06-14 Thread Alexander Graf
Am 14.06.2010 um 18:20 schrieb Richard Henderson : On 06/13/2010 03:23 PM, Alexander Graf wrote: On 13.06.2010, at 18:44, Aurelien Jarno wrote: Is KVM in 31-bit mode actually functional? I'm not aware of anything preventing it to be. But I honestly haven't tried. As long as all hypercall pa

Re: [Qemu-devel] [PATCH v2 7/7] apic: qdev conversion cleanup

2010-06-14 Thread Blue Swirl
On Mon, Jun 14, 2010 at 9:36 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> Make APICState completely private to apic.c by using DeviceState >> in external APIs. > > Could you explain why this is an improvement? Outside of apic.c, there is no need to access APICState fields so we can rem

Re: [Qemu-devel] [PATCH 5/5] [scsi-bsg]: Add initial support for BSG based SCSIDeviceInfo

2010-06-14 Thread Blue Swirl
On Mon, Jun 14, 2010 at 9:44 AM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch adds initial support for using the Linux BSG interface with > write/read vectored > AIO as a QEMU backstore (SCSIDeviceInfo) with hw/scsi-bus.c compatible HBA > emulation. Did I miss the doc

Re: [Qemu-devel] [PATCH] Add optional dump of default config file paths..

2010-06-14 Thread john cooper
Anthony Liguori wrote: > On 06/09/2010 03:05 AM, john cooper wrote: >> This patch adds the ability to determine the build-configured >> runtime "config file" paths from the command line. After >> support for cpu model definitions were added to the default >> runtime "target-" config file, testing

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-14 Thread Kevin O'Connor
On Mon, Jun 14, 2010 at 05:51:27PM +0300, Avi Kivity wrote: > On 06/14/2010 05:09 PM, Gleb Natapov wrote: > >>Could we just have qemu build the hpet tables and pass them through to > >>seabios? Perhaps using the qemu_cfg_acpi_additional_tables() method. > >> > >Possible, and I considered that. I p

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-14 Thread Juan Quintela
Anthony Liguori wrote: > On 06/14/2010 11:02 AM, Juan Quintela wrote: >> Anthony Liguori wrote: >> >>> On 06/12/2010 06:05 AM, Juan Quintela wrote: >>> Luiz Capitulino wrote: >> The monitor that did it knows it, nobody else knows it. At destination tim

Re: [Qemu-devel] [RFC PATCH 1/5] qdev: Create qdev_get_dev_path()

2010-06-14 Thread Alex Williamson
On Mon, 2010-06-14 at 18:49 +0200, Jan Kiszka wrote: > Alex Williamson wrote: > > On Mon, 2010-06-14 at 18:00 +0200, Jan Kiszka wrote: > >> And instead of introducing another hierarchy level with the bus address, > >> I would also prefer to add this as prefix or suffix to the device name, > >> e.g

[Qemu-devel] [PATCH] block: fix a warning and possible truncation

2010-06-14 Thread Blue Swirl
Fix a warning from OpenBSD gcc (3.3.5 (propolice)): /src/qemu/block.c: In function `bdrv_info_stats_bs': /src/qemu/block.c:1548: warning: long long int format, long unsigned int arg (arg 6) There may be also truncation effects. Signed-off-by: Blue Swirl --- Alternatively 'ULL' prefix could be ap

[Qemu-devel] Re: [SeaBIOS] [PATCHv2] load hpet info for HPET ACPI table from qemu

2010-06-14 Thread Gleb Natapov
On Mon, Jun 14, 2010 at 02:25:21PM -0400, Kevin O'Connor wrote: > On Mon, Jun 14, 2010 at 05:51:27PM +0300, Avi Kivity wrote: > > On 06/14/2010 05:09 PM, Gleb Natapov wrote: > > >>Could we just have qemu build the hpet tables and pass them through to > > >>seabios? Perhaps using the qemu_cfg_acpi_

[Qemu-devel] Re: [PATCH v3 0/5] Add QMP migration events

2010-06-14 Thread Anthony Liguori
On 06/14/2010 01:35 PM, Juan Quintela wrote: Anthony Liguori wrote: On 06/14/2010 11:02 AM, Juan Quintela wrote: Anthony Liguori wrote: On 06/12/2010 06:05 AM, Juan Quintela wrote: Luiz Capitulinowrote: The monitor that did it knows

  1   2   >