Cleaning up after we have deferred to the main thread but before the
transaction has converged can be dangerous and result in deadlocks
if the job cleanup invokes any BH polling loops.
A job may attempt to begin cleaning up, but may induce another job to
enter its cleanup routine. The second job,
To make it a little more obvious which functions are intended to be
public interface and which are intended to be for use only by jobs
themselves, split the interface into "public" and "private" files.
Convert blockjobs (e.g. block/backup) to using the private interface.
Leave blockdev and others
Add an explicit start field to specify the entrypoint. We already have
ownership of the coroutine itself AND managing the lifetime of the
coroutine, let's take control of creation of the coroutine, too.
This will allow us to delay creation of the actual coroutine until we
know we'll actually start
Refactor backup_start as backup_job_create, which only creates the job,
but does not automatically start it. The old interface, 'backup_start',
is not kept in favor of limiting the number of nearly-identical iterfaces
that would have to be edited to keep up with QAPI changes in the future.
Callers
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1475272849-19990-1-git-send-email-js...@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/11] blockjobs: Fix transactional race
condition
=== TEST SCRIPT BEGIN ===
#!/bin/bash
On Fri, Sep 30, 2016 at 10:30:56PM +0100, Alex Bennée wrote:
> From: Paolo Bonzini
>
> There is a data race if the sequence is written concurrently to the
> read. In C11 this has undefined behavior. Use atomic_set; the
> read side is already using atomic_read.
>
> Reported-by: Alex Bennée
> S
Jonathan Neuschäfer writes:
> On Fri, Sep 30, 2016 at 10:30:56PM +0100, Alex Bennée wrote:
>> From: Paolo Bonzini
>>
>> There is a data race if the sequence is written concurrently to the
>> read. In C11 this has undefined behavior. Use atomic_set; the
>> read side is already using atomic_rea
On 30 September 2016 at 01:16, Yongbok Kim wrote:
>>
>> Your GPG key hasn't been signed by anybody -- are you in a position
>> to get it signed by somebody else who can in-person verify your identity
>> (eg Leon)?
>
> Hi Peter,
>
> We have just arranged the key signing and Leon has signed my key.
On 09/29/2016 07:27 PM, Peter Maydell wrote:
...
>> This work was not done at this time since the changes could not be tested
>> with current CPU models. Comments have been added to flag the locations
>> where this will need to be fixed once a model is available.
>
> This is *not* why we haven't
On Fri, Sep 30, 2016 at 11:45:19PM +0100, Alex Bennée wrote:
>
> Jonathan Neuschäfer writes:
>
> > On Fri, Sep 30, 2016 at 10:30:56PM +0100, Alex Bennée wrote:
> >> From: Paolo Bonzini
> >>
> >> There is a data race if the sequence is written concurrently to the
> >> read. In C11 this has unde
Peter, feel free to change the syntax to whatever you feel is best.
Cheers,
Edgar
---
Sent from my phone
Original Message
Subject: Re: [Qemu-devel] [PATCH v1 1/1] target-arm: A64: Fix decoding of
iss_sf in disas_ld_lit
From: Peter Maydell
Date: 30 Sep 2016, 19:34
To: "E
On 30 September 2016 at 03:47, Christian Borntraeger
wrote:
> Peter,
>
> The following changes since commit 25930ed60aad49f1fdd7de05272317c86ce1275b:
>
> Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into
> staging (2016-09-27 23:10:12 +0100)
>
> are available in the git
On 30 September 2016 at 14:42, Edgar Iglesias wrote:
> Peter, feel free to change the syntax to whatever you feel is best.
Applied to target-arm.next, thanks. I picked "iss_sf = opc != 0;"
-- PMM
On 30 September 2016 at 15:46, Tom Hanson wrote:
> On 09/29/2016 07:27 PM, Peter Maydell wrote:
> ...
>>> This work was not done at this time since the changes could not be tested
>>> with current CPU models. Comments have been added to flag the locations
>>> where this will need to be fixed once
This commit essentially reverts commit
3af72a4d98dca033492102603734cbc63cd2694a, which has replaced
five-argument calls to mremap() by direct mremap syscalls for
compatibility with glibc older than version 2.4.
The direct syscall was buggy for 64bit targets on 32bit hosts
because of the default in
The F_EXLCK and F_SHLCK fcntl lock constants are obsolete synonyms for
F_WRLCK and F_RDLCK. Include to fix compilation with
the musl c library, which does not expose these constants.
Signed-off-by: Felix Janda
---
linux-user/syscall.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/linux-us
This fixes a compilation error with the musl c library.
---
I don't really understand the purpose of the hack, which was
introduced in
http://git.qemu.org/?p=qemu.git;a=commit;h=624f7979058b84cbf81c76d45f302ce757b213ca
but musl does not have a separate thread library (it is included in
libc.so),
This removes the last usage of in the code base.
Signed-off-by: Felix Janda
---
linux-user/syscall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 3d1f694..4bfb671 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20160930234101.GD5887@nyan
Subject: [Qemu-devel] [PATCH RFC] linux-user: peform __SIGRTMIN hack only when
__SIGRTMIN is defined
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=b
Thanks :-)
Edgar
---
Sent from my phone
Original Message
Subject: Re: [Qemu-devel] [PATCH v1 1/1] target-arm: A64: Fix decoding of
iss_sf in disas_ld_lit
From: Peter Maydell
Date: 1 Oct 2016, 01:20
To: Edgar Iglesias
On 30 September 2016 at 14:42, Edgar Iglesias wrote
On 30 September 2016 at 16:41, Felix Janda wrote:
> This fixes a compilation error with the musl c library.
> ---
> I don't really understand the purpose of the hack, which was
> introduced in
>
> http://git.qemu.org/?p=qemu.git;a=commit;h=624f7979058b84cbf81c76d45f302ce757b213ca
>
> but musl does
On 30 September 2016 at 16:39, Felix Janda wrote:
> This commit essentially reverts commit
> 3af72a4d98dca033492102603734cbc63cd2694a, which has replaced
> five-argument calls to mremap() by direct mremap syscalls for
> compatibility with glibc older than version 2.4.
>
> The direct syscall was bu
On 30 September 2016 at 16:39, Felix Janda wrote:
> The F_EXLCK and F_SHLCK fcntl lock constants are obsolete synonyms for
> F_WRLCK and F_RDLCK.
This seems unlikely, since on for instance Alpha F_EXLCK is
16, F_SHLCK is 32, F_RDLCK is 1 and F_WRLCK is 2, so they're
all distinct:
http://lxr.free-
Hi Stefan, others,
Thank you for all the review comments.
On Wed, Sep 28, 2016 at 4:13 AM, Stefan Hajnoczi wrote:
> On Tue, Sep 27, 2016 at 09:09:49PM -0700, Ashish Mittal wrote:
>> +vxhs_bdrv_init(const char c) "Registering VxHS AIO driver%c"
>
> Why do several trace events have a %c format spe
Peter Maydell wrote:
> On 30 September 2016 at 16:39, Felix Janda wrote:
> > The F_EXLCK and F_SHLCK fcntl lock constants are obsolete synonyms for
> > F_WRLCK and F_RDLCK.
>
> This seems unlikely, since on for instance Alpha F_EXLCK is
> 16, F_SHLCK is 32, F_RDLCK is 1 and F_WRLCK is 2, so they'
Peter Maydell wrote:
> On 30 September 2016 at 16:41, Felix Janda wrote:
> > This fixes a compilation error with the musl c library.
> > ---
> > I don't really understand the purpose of the hack, which was
> > introduced in
> >
> > http://git.qemu.org/?p=qemu.git;a=commit;h=624f7979058b84cbf81c76d
On 09/29/2016 10:42 PM, Markus Armbruster wrote:
Cao jin writes:
static int vmxnet3_post_load(void *opaque, int version_id)
{
VMXNET3State *s = opaque;
-PCIDevice *d = PCI_DEVICE(s);
net_tx_pkt_init(&s->tx_pkt, PCI_DEVICE(s),
s->max_tx_frags, s->p
Cao jin writes:
> On 09/29/2016 10:35 PM, Markus Armbruster wrote:
>> Cao jin writes:
>>
>
>>>
>>> @@ -2349,7 +2342,7 @@ static void megasas_scsi_realize(PCIDevice *dev,
>>> Error **errp)
>>>
>>> memory_region_init_io(&s->mmio_io, OBJECT(s), &megasas_mmio_ops, s,
>>>
On 30/09/2016 03:30, David Gibson wrote:
> On Thu, Sep 29, 2016 at 07:15:07PM +0200, Laurent Vivier wrote:
>> but disable MSI-X tests on SPAPR as we can't check the result
>> (the memory region used on PC is not readable on SPAPR).
>>
>> Signed-off-by: Laurent Vivier
>> ---
>> tests/Makefile.in
Cao jin writes:
> On 09/29/2016 10:17 PM, Markus Armbruster wrote:
>> Cao jin writes:
>>
>
>>>
>>> -/* Initialize the MSI-X structures */
>>> +/* Make PCI device @dev MSI-X capable
>>> + * @nentries is the max number of MSI-X vectors that the device support.
>>> + * @table_bar is the MemoryRegio
The default-configs/*-linux-user.mak belong to Linux usermode
emulation, and default-configs/*-bsd-user.mak belong to BSD
usermode emulation.
Signed-off-by: Thomas Huth
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5b06ec2..2716e3f 100644
-
On 09/30/2016 03:01 PM, Markus Armbruster wrote:
Cao jin writes:
On 09/29/2016 10:17 PM, Markus Armbruster wrote:
Intentional change? I like the old one better.
Oh...it was lost by me. I was planning move these comments into a
separate patch, but later feel that it is not worth the t
The only address space where the GIC devices are added is
address_space_memory. There is no need to use a global
MemoryListener.
This removes the only user of global MemoryListeners.
Signed-off-by: Paolo Bonzini
---
target-arm/kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
The MIPS section is missing some related header files, and files
in the hw/misc/, hw/intc/ and hw/timer/ folders.
Signed-off-by: Thomas Huth
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 977e96e..4e86539 100644
--- a/MAINTAINERS
+++ b/
On Thu, Sep 29, 2016 at 18:14:53 -0300, Eduardo Habkost wrote:
> Instead of translating the feature name entries when adding
> property names, store the actual property names in the feature
> name array.
>
> Signed-off-by: Eduardo Habkost
> ---
> Changes series v3 -> v4:
> * New patch added to se
On 09/30/2016 02:15 PM, Amit Shah wrote:
Hi,
On (Thu) 29 Sep 2016 [19:06:32], Li Zhijian wrote:
Priviously, if the source and distination have different devices, source could
goto
the status "paused (postmigrate)", and the distination will exit that means no
qemu
is alive.
After this patch
On 29/09/2016 23:14, Eduardo Habkost wrote:
> + * "-foo" overrides "+foo"
> + * "[+-]foo" overrides "foo=..."
Is this something that people are actually using? Can we detect it and
deprecate it in 2.8, and drop it in 2.9?
Paolo
> + * "foo_bar" should be translated to "foo-bar"
On 29/09/2016 23:14, Eduardo Habkost wrote:
> +/* Load CPUID data based on configureured features
> + */
Typo ("configureured") and also unnecessarily breaking the comment on
two lines.
Paolo
> +static void x86_cpu_load_features(X86CPU *cpu, Error **errp)
On 29/09/2016 23:14, Eduardo Habkost wrote:
> +/* Return the feature property name for a feature flag bit */
> +static const char *x86_cpu_feature_name(FeatureWord w, int bitnr)
> +{
> +/* XSAVE components are automatically enabled by other features,
> + * so return the original feature n
On Fri, Sep 30, 2016 at 09:33:20AM +1000, David Gibson wrote:
> On Thu, Sep 29, 2016 at 09:14:16AM +0100, Daniel P. Berrange wrote:
> > On Thu, Sep 29, 2016 at 10:16:41AM +1000, David Gibson wrote:
> > > QOM has the concept of both "object class" properties and "object
> > > instance" properties.
>
On Fri, Sep 30, 2016 at 09:55:33 +0200, Paolo Bonzini wrote:
>
>
> On 29/09/2016 23:14, Eduardo Habkost wrote:
> > + * "-foo" overrides "+foo"
> > + * "[+-]foo" overrides "foo=..."
>
> Is this something that people are actually using? Can we detect it and
> deprecate it in 2.8, and drop
On Thu, Sep 29, 2016 at 08:09:38PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> At the moment postcopy will fail as soon as qemu tries to register
> userfault on the RAMBlock pages that are backed by hugepages.
> However, the kernel is going to get userfault sup
> -原始邮件-
> 发件人: "Amit Shah"
> 发送时间: 2016年9月30日 星期五
> 收件人: "Chunguang Li"
> 抄送: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org,
> pbonz...@redhat.com, stefa...@redhat.com, quint...@redhat.com
> 主题: Re: Re: [Qemu-devel] Migration dirty bitmap: should only mark pages as
> dirty after
>
> Your GPG key hasn't been signed by anybody -- are you in a position
> to get it signed by somebody else who can in-person verify your identity
> (eg Leon)?
>
> thanks
> -- PMM
>
Hi Peter,
We have just arranged the key signing and Leon has signed my key.
Thanks,
Yongbok
Am 28.09.2016 um 21:52 schrieb Michael Roth:
Quoting Peter Lieven (2016-09-27 06:30:27)
Am 27.09.2016 um 12:28 schrieb Peter Lieven:
Am 16.09.2016 um 15:56 schrieb Peter Lieven:
Am 13.09.2016 um 20:04 schrieb Michael Roth:
Quoting Peter Lieven (2016-09-13 10:52:04)
Ok, I'wll wrap it.
On 09/29/2016 09:35 PM, Eric Blake wrote:
On 09/28/2016 05:31 AM, Stefan Hajnoczi wrote:
On Wed, Sep 28, 2016 at 01:30:39PM +0800, Wang WeiWei wrote:
Please send a proper commit message and commit description. "modify
top-id's comments" says almost nothing and there is no co
On Thu, 29 Sep 2016 19:15:05 +0200
Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier
> ---
> tests/virtio-9p-test.c | 53
> tests/virtio-blk-test.c | 154
> +--
> tests/virtio-net-test.c | 40 +---
> tests/virtio-sc
On Tue, Sep 27, 2016 at 09:09:49PM -0700, Ashish Mittal wrote:
> This patch adds support for a new block device type called "vxhs".
> Source code for the library that this code loads can be downloaded from:
> https://github.com/MittalAshish/libqnio.git
The QEMU block driver should deal with BlockD
Kevin Wolf's advice:
http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html
Signed-off-by: Wen Congyang
Signed-off-by: Changlong Xie
Signed-off-by: Wang WeiWei
Signed-off-by: zhanghailiang
Signed-off-by: Gonglei
---
qapi/block-core.json | 3 ++-
1 file changed, 2 insertions(+), 1
On 30/09/2016 10:33, Greg Kurz wrote:
> On Thu, 29 Sep 2016 19:15:05 +0200
> Laurent Vivier wrote:
>
>> Signed-off-by: Laurent Vivier
>> ---
>> tests/virtio-9p-test.c | 53
>> tests/virtio-blk-test.c | 154
>> +--
>> tests/virt
hw/intc/sh_intc.c and hw/timer/sh_timer.c seem to belong to
the R2D machine, as far as I can see.
And concerning the Shix machine, it does not make much sense
to have a "M:" entry here and the "S:" set to "Orphan". So
I'd like to suggest to use "Odd Fixes" here instead.
Signed-off-by: Thomas Huth
On Fri, Sep 30, 2016 at 04:53:38PM +0800, Wang WeiWei wrote:
> Kevin Wolf's advice:
> http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html
IIUC, what Stefan meant is to write a simple descriptive commit message
that explains why this change is necessary -- the above URL might have
co
This is v2, should be included in the subject line.
Am 30.09.2016 um 10:53 hat Wang WeiWei geschrieben:
> Kevin Wolf's advice:
> http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html
>
> Signed-off-by: Wen Congyang
> Signed-off-by: Changlong Xie
> Signed-off-by: Wang WeiWei
> Sign
On 30/09/2016 10:33, Greg Kurz wrote:
> On Thu, 29 Sep 2016 19:15:05 +0200
> Laurent Vivier wrote:
...
>> @@ -230,9 +227,6 @@ static void test_unaligned_write_same(void)
>> 0x41, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x33, 0x00, 0x00
>> };
>>
>> -qvirtio_scsi_start("-drive file
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote:
>
>
> On 09/30/2016 02:15 PM, Amit Shah wrote:
> > Hi,
> >
> > On (Thu) 29 Sep 2016 [19:06:32], Li Zhijian wrote:
> > > Priviously, if the source and distination have different devices, source
> > > could goto
> > > the status "paused (postmigrate)
Ok,thanks.
On 09/30/2016 05:52 PM, Kevin Wolf wrote:
This is v2, should be included in the subject line.
Am 30.09.2016 um 10:53 hat Wang WeiWei geschrieben:
Kevin Wolf's advice:
http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html
Signed-off-by: Wen Congyang
Signed-off-by: Chang
qiv->root should not be null, make that clearer with some assert.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
qapi/qmp-input-visitor.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visitor.c
index fc91e74..c7deca9 100644
--- a/q
The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing
parameters, but the qapi qmp_dispatch() code uses
QERR_INVALID_PARAMETER_TYPE.
Improve qapi code to return QERR_MISSING_PARAMETER where
appropriate.
Fix expected error message in iotests.
Signed-off-by: Marc-André Lureau
Revi
Hi,
'monitor: use qmp_dispatch()' patch broke some iotests expecting a
'missing parameter' error. This series fixes qapi visitors to return
this error for all types.
This series should go on top of:
https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg05949.html
v3:
- merge patch 4 (iotest f
This helps to figure out the expectations.
Signed-off-by: Marc-André Lureau
Reviewed-by: Eric Blake
---
qapi/qmp-input-visitor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visitor.c
index c7deca9..fe097c9 100644
--- a/qapi/qmp-input-visitor.c
+
On Mon, Sep 19, 2016 at 3:28 PM, Stefan Hajnoczi wrote:
> Ports enter a "throttled" state when writing to the chardev would block.
> The current output VirtQueueElement is kept around until the chardev
> becomes writable again.
>
> There are several places in the virtio-serial lifecycle where the
On Thu, 29 Sep 2016 19:15:07 +0200
Laurent Vivier wrote:
> but disable MSI-X tests on SPAPR as we can't check the result
> (the memory region used on PC is not readable on SPAPR).
>
> Signed-off-by: Laurent Vivier
> ---
> tests/Makefile.include| 3 ++-
> tests/libqos/virtio-pci.c | 22 +++
From: "Edgar E. Iglesias"
Fix the decoding of iss_sf in disas_ld_lit.
The SF (Sixty-Four) field in the ISS (Instruction Specific Syndrome)
is a bit that specifies the width of the register that the
instruction loads to.
If cleared it specifies 32 bits.
If set it specifies 64 bits.
Signed-off-by
On Thu, Sep 29, 2016 at 06:40:53PM -0700, Peter Maydell wrote:
> On 22 September 2016 at 02:53, Peter Maydell wrote:
> > This is clearly a bug, but your suggested change won't deal with the
> > problem, which is that we're trying to set a bool so the ? 32 : 64
> > construct is just wrong.
>
> > B
From: Evgeny Yakovlev
Current CPU definition for AMD Opteron third generation includes
features like SSE4a and LAHF_LM support in emulated CPUID. These
features are present in K8 rev.E or K10 CPUs and later. However,
current G3 family and model describe 2nd generation K8 cores instead.
This is i
On Fri, Sep 30, 2016 at 08:59:39AM +0200, Laurent Vivier wrote:
>
>
> On 30/09/2016 03:30, David Gibson wrote:
> > On Thu, Sep 29, 2016 at 07:15:07PM +0200, Laurent Vivier wrote:
> >> but disable MSI-X tests on SPAPR as we can't check the result
> >> (the memory region used on PC is not readable
On 30/09/2016 12:18, Greg Kurz wrote:
> On Thu, 29 Sep 2016 19:15:07 +0200
> Laurent Vivier wrote:
>
>> but disable MSI-X tests on SPAPR as we can't check the result
>> (the memory region used on PC is not readable on SPAPR).
>>
>> Signed-off-by: Laurent Vivier
>> ---
>> tests/Makefile.includ
On Fri, 30 Sep 2016 11:13:33 +0200
Laurent Vivier wrote:
> On 30/09/2016 10:33, Greg Kurz wrote:
> > On Thu, 29 Sep 2016 19:15:05 +0200
> > Laurent Vivier wrote:
> >
> >> [...]
> >> static void pci_nop(void)
> >> {
> >> -qvirtio_9p_start();
> >> -qvirtio_9p_stop();
> >> +QOSStat
On 30/09/2016 12:29, Greg Kurz wrote:
> On Fri, 30 Sep 2016 11:13:33 +0200
> Laurent Vivier wrote:
>
>> On 30/09/2016 10:33, Greg Kurz wrote:
>>> On Thu, 29 Sep 2016 19:15:05 +0200
>>> Laurent Vivier wrote:
>>>
[...]
static void pci_nop(void)
{
-qvirtio_9p_start();
On Fri, 30 Sep 2016 11:56:50 +0200
Laurent Vivier wrote:
> On 30/09/2016 10:33, Greg Kurz wrote:
> > On Thu, 29 Sep 2016 19:15:05 +0200
> > Laurent Vivier wrote:
> ...
> >> @@ -230,9 +227,6 @@ static void test_unaligned_write_same(void)
> >> 0x41, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0
On 30.09.2016 12:19, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Fix the decoding of iss_sf in disas_ld_lit.
> The SF (Sixty-Four) field in the ISS (Instruction Specific Syndrome)
> is a bit that specifies the width of the register that the
> instruction loads to.
>
> If cleared it
* Matthew Garrett (mj...@coreos.com) wrote:
> Trusted Boot is based around having a trusted store of measurement data and
> a secure communications channel between that store and an attestation
> target. In actual hardware, that's a TPM. Since the TPM can only be accessed
> via the host system, thi
From: Yi Min Zhao
Now that each S390 PCI device uses an IO region as MSIX region. The
code in s390_translate_iommu() will never be triggered. Let's remove
it.
Signed-off-by: Yi Min Zhao
Reviewed-by: Pierre Morel
Signed-off-by: Christian Borntraeger
---
hw/s390x/s390-pci-bus.c | 11 --
From: Pierre Morel
Pull mr variable declarations at the top of the functions instead of
mixing them up with the code. This is in preparation for followup
patches.
Signed-off-by: Pierre Morel
Reviewed-by: Cornelia Huck
Signed-off-by: Christian Borntraeger
---
hw/s390x/s390-pci-inst.c | 6
From: Dong Jia Shi
IPL should cause the IPL I/O device to become enabled. So when handling
the IPL program, we should set the E (Enable) bit. However, virtio-ccw
does not know whether it's dealing with an IPL device or not. Since
trying to perform I/O on a disabled device doesn't make any sense,
If two VCPUs exit at the same time and target each other
with a sigp, both could run into a deadlock as run_on_cpu
on CPU0 will free the BQL when starting the CPU1 target routine.
CPU1 will run its sigp initiater for CPU0 before handling
the run_on_cpu requests, thus resulting in a dead lock.
As a
Peter,
The following changes since commit 25930ed60aad49f1fdd7de05272317c86ce1275b:
Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into
staging (2016-09-27 23:10:12 +0100)
are available in the git repository at:
git://github.com/borntraeger/qemu.git tags/s390x-201609
Contains:
- pc-bios/s390-ccw: enable subchannel for IPL I/O devices
Signed-off-by: Christian Borntraeger
---
pc-bios/s390-ccw.img | Bin 26440 -> 26392 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/pc-bios/s390-ccw.img b/pc-bios/s390-ccw.img
index
089f6ba5e924c17796cccac4e
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
docs/specs/qcow2.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt
index 80cdfd0..d3e292f 100644
--- a/docs/specs/qcow2.txt
+++ b/docs/specs/qcow2.txt
@@ -472,8 +472,7 @@ Structure
From: Sascha Silbe
According to the PoP, subchannels are only considered operational if
they are enabled _and_ the device number is valid. With the current
checks being enabled _or_ having a valid device number was
sufficient. This caused qemu to allow IO on subchannels that were not
enabled.
Fi
commit 9c5ce8db2e5c ("vl: Switch qemu_uuid to QemuUUID") changed most
users of qemu_uuid but not all. Fix a build error on s390/kvm.
Reviewed-by: Fam Zheng
Signed-off-by: Christian Borntraeger
---
target-s390x/kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-s390
From: Yi Min Zhao
For efficiency we now assign one msix io region for each pci device
and provide it with the pointer to the zPCI device as opaque
parameter. In addition, we remove msix address space and add msix io
region as a subregion to the root memory region of pci device.
Signed-off-by: Yi
Test that hbitmap iter is resistant to bitmap resetting.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Denis V. Lunev
---
tests/test-hbitmap.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/tests/test-hbitmap.c b/tests/test-hbitmap.c
index 0ed918c..e24377f
On Fri, 30 Sep 2016 12:30:08 +0200
Laurent Vivier wrote:
> On 30/09/2016 12:18, Greg Kurz wrote:
> > On Thu, 29 Sep 2016 19:15:07 +0200
> > Laurent Vivier wrote:
> >
> >> but disable MSI-X tests on SPAPR as we can't check the result
> >> (the memory region used on PC is not readable on SPAPR)
On Fri, Sep 30, 2016 at 12:42:27PM +0200, Thomas Huth wrote:
> On 30.09.2016 12:19, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias"
> >
> > Fix the decoding of iss_sf in disas_ld_lit.
> > The SF (Sixty-Four) field in the ISS (Instruction Specific Syndrome)
> > is a bit that specifies the w
This will not touch loaded bitmaps, as they are alredy removed from the
image.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-bitmap.c | 38 ++
block/qcow2.c| 9 ++---
block/qcow2.h| 2 ++
3 files changed, 46 insertions(+), 3
On Fri, Sep 30, 2016 at 11:48:44AM +0200, Kashyap Chamarthy wrote:
> On Fri, Sep 30, 2016 at 04:53:38PM +0800, Wang WeiWei wrote:
> > Kevin Wolf's advice:
> > http://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02391.html
>
> IIUC, what Stefan meant is to write a simple descriptive commit mess
Add optional 'persistent' flag to qmp command block-dirty-bitmap-add.
Default is false.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Denis V. Lunev
---
blockdev.c | 12 +++-
qapi/block-core.json | 7 ++-
qmp-commands.hx | 5 -
3 files changed, 21 i
v7:
https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=refs%2Ftags%2Fqcow2-bitmap-v7
based on block-next (https://github.com/XanClic/qemu/commits/block-next)
- a lot of refactoring and reordering of patches.
- dead code removed (bdrv_dirty_bitmap_load, etc.)
- do not maintain extra data
Add autoclear bit for handling rewriting image by old qemu version.
If autoclear bit is not set, but bitmaps extension is found it
would not be loaded and warning will be generated.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-bitmap.c | 4
block/qcow2.c| 12 +++
Make dirty iter resistant to resetting bits in corresponding HBitmap.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/qemu/hbitmap.h | 24 ++--
util/hbitmap.c | 23 ++-
2 files changed, 24 insertions(+), 23 deletions(-)
diff --git a/includ
Add dirty bitmap extension as specified in docs/specs/qcow2.txt.
For now, just mirror extension header into Qcow2 state and check
constraints.
For now, disable image resize if it has bitmaps. It will be fixed later.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2.c | 83
Calculate refcounts for dirty bitmaps.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-bitmap.c | 60 ++
block/qcow2-refcount.c | 14 +++-
block/qcow2.h | 5 +
3 files changed, 74 insertions(+), 5 deletions(-)
d
Optional. Default is false.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Denis V. Lunev
---
blockdev.c | 22 --
qapi/block-core.json | 7 ++-
qmp-commands.hx | 5 -
3 files changed, 30 insertions(+), 4 deletions(-)
diff --git a/blockde
Check bitmap header constraints as specified in docs/specs/qcow2.txt
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-bitmap.c | 39 +++
1 file changed, 39 insertions(+)
diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c
index 8cf40f0..1c3abe
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/165 | 87 ++
tests/qemu-iotests/165.out | 5 +++
tests/qemu-iotests/group | 1 +
3 files changed, 93 insertions(+)
create mode 100755 tests/qemu-iotests/165
create mode 100644
Reviewed-by: John Snow
Reviewed-by: Eric Blake
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/dirty-bitmap.c | 1 +
include/qemu/hbitmap.h | 8
qapi/block-core.json | 5 -
util/hbitmap.c | 8
4 files changed, 21 insertions(+), 1 deletion(-)
diff --git a
From: Denis Plotnikov
Unfortunately, there is no public Windows API to start trimming the
filesystem. The only viable way here is to call 'defrag.exe /L' for
each volume.
This is working since Win8 and Win2k12.
Signed-off-by: Denis V. Lunev
Signed-off-by: Denis Plotnikov
CC: Michael Roth
CC:
Make getter signature const-correct. This allows other functions with
const dirty bitmap parameter use bdrv_dirty_bitmap_granularity().
Reviewed-by: Eric Blake
Reviewed-by: John Snow
Reviewed-by: Kevin Wolf
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/dirty-bitmap.c | 2 +-
i
This flag means that the bitmap is now in use by the software or was not
successfully saved. In any way, with this flag set the bitmap data must
be considered inconsistent and should not be loaded.
With current implementation this flag is never set, as we just remove
bitmaps from the image after l
1 - 100 of 352 matches
Mail list logo
