13.11.2017 20:50, Eric Blake wrote:
On 11/13/2017 10:20 AM, Vladimir Sementsov-Ogievskiy wrote:
Like other setters here these functions should take a lock.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/dirty-bitmap.c | 4
1 file changed, 4 insertions(+)
Should this patch be in
On Wed, Nov 15, 2017 at 10:21:16AM +, Stefan Hajnoczi wrote:
> On Mon, Nov 06, 2017 at 05:46:43PM +0800, Peter Xu wrote:
> > +/*
> > + * Try a time-consuming command, following by a OOB command, make
> > + * sure we get OOB command before the time-consuming one (which is
> > + *
Hi Jason,
Windows driver will initialise only the amount of queue based on the amount of
available vCPUs. So if there will be more queues in the device than we have
vCPUs on the guest, the driver will not initialise “excessive” queues. This is
tied to the way RSS on Windows should be implemente
Hi. I'm try to write own sheepdog compatible daemon and test it with qemu.
Sometimes ago in qemu added read write error policy to allow to stop
domain or continue or something else. As i see in case of sheepdog
this policy is ignored and qemu try to reconnect to sheepdog daemon.
If nobody wants i c
16.11.2017 00:20, John Snow wrote:
On 11/13/2017 11:20 AM, Vladimir Sementsov-Ogievskiy wrote:
Hi all.
There are three qmp commands, needed to implement external backup API.
Using these three commands, client may do all needed bitmap management by
hand:
on backup start we need to do a transa
On Thu, 11/16 11:11, Vasiliy Tolstov wrote:
> Hi. I'm try to write own sheepdog compatible daemon and test it with qemu.
> Sometimes ago in qemu added read write error policy to allow to stop
> domain or continue or something else. As i see in case of sheepdog
> this policy is ignored and qemu try
16.11.2017 00:35, Eric Blake wrote:
The NBD spec says an attempt to NBD_CMD_TRIM on a read-only
export should fail with EPERM, as a trim has the potential
to change disk contents, but we were relying on the block
layer to catch that for us, which might not always give the
right error (and even if
On 2017年11月16日 13:53, Longpeng (Mike) wrote:
On 2017/11/15 23:54, Longpeng(Mike) wrote:
2017-11-15 23:05 GMT+08:00 Jason Wang:
On 2017年11月15日 22:55, Longpeng(Mike) wrote:
Hi guys,
We got a BUG report from our testers yesterday, the testing scenario was
migrating a VM (Windows guest, *4 vcpu
The bios-tables-test was writing out files that we pass to iasl in
with the wrong endianness in the header when running on a big endian
host. So instead of storing mixed endian information in our structures,
let's keep everything in little endian and byte-swap it only when we
need a value in the co
11.11.2017 01:52, John Snow wrote:
On 10/30/2017 12:32 PM, Vladimir Sementsov-Ogievskiy wrote:
It is needed to realize bdrv_dirty_bitmap_release_successor in
the following patch.
OK, but...
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/dirty-bitmap.c | 25
On 2017年11月16日 14:40, Stefan Weil wrote:
Am 15.11.2017 um 14:09 schrieb Michael Nawrocki:
Hi Stefan,
I've got a VxWorks driver binary that explicitly looks for device ID
0x1030 (which is admittedly not ideal). It seems like the "82559
InBusiness 10/100" hardware uses this, though I've had tro
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Thursday, November 16, 2017 4:55 PM
> To: longpeng; m...@redhat.com
> Cc: Longpeng(Mike); qemu-devel@nongnu.org; Gonglei (Arei); Wangjing (King,
> Euler); Huangweidong (C); stefa...@redhat.com
> Subject: Re: [Que
On 2017年11月16日 17:01, Gonglei (Arei) wrote:
-Original Message-
From: Jason Wang [mailto:jasow...@redhat.com]
Sent: Thursday, November 16, 2017 4:55 PM
To: longpeng; m...@redhat.com
Cc: Longpeng(Mike); qemu-devel@nongnu.org; Gonglei (Arei); Wangjing (King,
Euler); Huangweidong (C); ste
On Thu, 16 Nov 2017 08:45:09 +0100
Christian Borntraeger wrote:
> On 11/15/2017 06:10 PM, Cornelia Huck wrote:
> > On Wed, 15 Nov 2017 16:42:23 +0100
> > Christian Borntraeger wrote:
> >
> >> We no longer support the old s390 transport, neither does the newest
> >> Linux kernel. Remove it fro
On 16/11/2017 08:51, P J P wrote:
> From: Prasad J Pandit
>
> During Qemu guest migration, a destination process invokes ps2
> post_load function. In that, if 'rptr' and 'count' values were
> invalid, it could lead to OOB access or infinite loop issue.
> Add check to avoid it.
>
> Reported-by: C
On 2017/11/16 16:54, Jason Wang wrote:
>
>
> On 2017年11月16日 13:53, Longpeng (Mike) wrote:
>> On 2017/11/15 23:54, Longpeng(Mike) wrote:
>>> 2017-11-15 23:05 GMT+08:00 Jason Wang:
On 2017年11月15日 22:55, Longpeng(Mike) wrote:
> Hi guys,
>
> We got a BUG report from our testers ye
2017-11-16 11:27 GMT+03:00 Fam Zheng :
> On Thu, 11/16 11:11, Vasiliy Tolstov wrote:
>> Hi. I'm try to write own sheepdog compatible daemon and test it with qemu.
>> Sometimes ago in qemu added read write error policy to allow to stop
>> domain or continue or something else. As i see in case of she
On Wed, Nov 15, 2017 at 04:56:13PM -0500, John Snow wrote:
>
>
> On 11/15/2017 04:54 PM, Kashyap Chamarthy wrote:
> > On Wed, Nov 15, 2017 at 02:15:57PM -0500, John Snow wrote:
[...]
> >> is it covered sufficiently in live-block-operations.rst ?
> >
> > I looked in there[2] too. Short answer:
On 2017年11月16日 17:01, Gonglei (Arei) wrote:
No, Windows guest + vhost-user/DPDK.
BTW pls see virtio spec in :
"If VIRTIO_NET_F_MQ is negotiated, each of receiveq1. . .receiveqN that will be
used SHOULD be populated
with receive buffers."
It is not mandatory that all queues must be initializ
Hi Jason,
On 2017/11/16 17:13, Jason Wang wrote:
>
>
> On 2017年11月16日 17:01, Gonglei (Arei) wrote:
>> No, Windows guest + vhost-user/DPDK.
>>
>> BTW pls see virtio spec in :
>>
>> "If VIRTIO_NET_F_MQ is negotiated, each of receiveq1. . .receiveqN that will
>> be used SHOULD be populated
>> with
> -Original Message-
> From: Stefano Stabellini [mailto:sstabell...@kernel.org]
> Sent: 16 November 2017 01:11
> To: Paul Durrant
> Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Stefano
> Stabellini ; Anthony Perard
> ; Kevin Wolf ; Max Reitz
>
> Subject: RE: [PATCH v3] xen-d
On Tue, Nov 14, 2017 at 01:06:17PM -0600, Eric Blake wrote:
> On 11/14/2017 11:37 AM, Wouter Verhelst wrote:
> > On Tue, Nov 14, 2017 at 10:41:39AM -0600, Eric Blake wrote:
> >> Another thought - with structured replies, we finally have a way to let
> >> the client ask for the server to send resize
Here's my solution, as a nbdkit plugin written in Perl.
As with Max's solution I don't bother to parse the virtual size out of
the XML file, so you need to specify that on the command line
otherwise the disk will be truncated to the largest extent stored in
the file. Also the ‘.xva’ file must not
On 16/11/2017 6:26 AM, Fam Zheng wrote:
On Tue, 11/14 13:16, Anton Nefedov wrote:
It might be useful to compress images during block-stream;
this way the user can merge compressed images of a backing chain and
the result will remain compressed.
I haven't looked at the patches yet so maybe the
On 15/11/2017 9:49 PM, Max Reitz wrote:
On 2017-11-14 11:16, Anton Nefedov wrote:
Signed-off-by: Anton Nefedov
---
block/io.c | 30 --
block/trace-events | 2 +-
2 files changed, 25 insertions(+), 7 deletions(-)
diff --git a/block/io.c b/block/io.c
ind
2017-11-16 11:01 GMT+01:00 Richard W.M. Jones :
> As mentioned before you can use this to do a qemu-img convert using
> captive nbdkit:
>
> $ nbdkit -U - \
> perl script=./xva-reader.pl file=./debian8cloud.xva size=4294967296 \
> --run 'qemu-img convert -f raw $nbd -O qcow2 /var/tmp/o
2017-11-15 23:55 GMT+01:00 Max Reitz :
> https://xanclic.moe/convert-xva.rb -- does this work?
> (It seems to works on the two example images I found...)
>
> An example is in the code, you use it like this:
>
> $ ./convert-xva.rb ~/Downloads/stats-appliance-2.36.020502.xva Ref:73
It doesn't work
On Thu, Nov 16, 2017 at 11:07:10AM +0100, Gandalf Corvotempesta wrote:
> 2017-11-16 11:01 GMT+01:00 Richard W.M. Jones :
> > As mentioned before you can use this to do a qemu-img convert using
> > captive nbdkit:
> >
> > $ nbdkit -U - \
> > perl script=./xva-reader.pl file=./debian8cloud.xv
On 15/11/2017 10:16 PM, Max Reitz wrote:
On 2017-11-14 11:16, Anton Nefedov wrote:
Signed-off-by: Anton Nefedov
---
qapi/block-core.json | 4
include/block/block_int.h | 4 +++-
block/stream.c| 16
blockdev.c| 13 -
hm
From: Prasad J Pandit
During Qemu guest migration, a destination process invokes ps2
post_load function. In that, if 'rptr' and 'count' values were
invalid, it could lead to OOB access issue. Add check to avoid
it.
Reported-by: Cyrille Chatras
Signed-off-by: Prasad J Pandit
---
hw/input/ps2.c
On Thu, Nov 16, 2017 at 10:28:32AM +0800, Mao Zhongyi wrote:
Cc: Peter Maydell
Cc: Jason Wang
Cc: Zhang Chen
Cc: Li Zhijian
Cc: Paolo Bonzini
Fixes: 8ec14402029d783720f4312ed8a925548e1dad61
Reported-by: Peter Maydell
Reported-by: Paolo Bonzini
Signed-off-by: Mao Zhongyi
Code-wise, this
+-- On Thu, 16 Nov 2017, Paolo Bonzini wrote --+
| you don't need to change the invalid values to sane ones. Instead, make
| ps2_common_post_load return an int (just like the .post_load member of
| VMStateDescription). You can then detect out of range count/rptr/wptr
| and return -1 for bad indic
On Wed, Nov 15, 2017 at 08:18:50PM +0200, Michael S. Tsirkin wrote:
> From: Dou Liyang
>
> Linux and Windows need ACPI SRAT table to make memory hotplug work properly,
> however currently QEMU doesn't create SRAT table if numa options aren't
> present
> on CLI.
>
> Which breaks both linux and w
On 16/11/2017 11:16, P J P wrote:
> From: Prasad J Pandit
>
> During Qemu guest migration, a destination process invokes ps2
> post_load function. In that, if 'rptr' and 'count' values were
> invalid, it could lead to OOB access issue. Add check to avoid
> it.
>
> Reported-by: Cyrille Chatras
>
15.11.2017 04:58, John Snow wrote:
On 10/30/2017 12:33 PM, Vladimir Sementsov-Ogievskiy wrote:
Postcopy migration of dirty bitmaps. Only named dirty bitmaps,
associated with root nodes and non-root named nodes are migrated.
If destination qemu is already containing a dirty bitmap with the same
On Thu, Nov 16, 2017 at 09:55:46AM +0100, Thomas Huth wrote:
> The bios-tables-test was writing out files that we pass to iasl in
> with the wrong endianness in the header when running on a big endian
> host. So instead of storing mixed endian information in our structures,
> let's keep everything
I submitted it with git Nov 3 - the long lines issue with git-am
should be resolved. Please let me know if there's still a problem.
Thanks.
On Fri, Nov 3, 2017 at 11:58 AM, Philippe Mathieu-Daudé wrote:
> Cc'ing Trivial ;)
>
> On 11/03/2017 10:37 AM, Doug Gale wrote:
>> Add trace output for com
Public bug reported:
WebSocket support in VNC should allow access from VNC client through
upgraded WebSocket connection. This feature is not working in IE 11/Edge
with noVNC HTML5 client, in contrast to that in Firefox/Safari, etc.
The reason that IE 11/Edge fails to accept the connection upgrade
tg->any_timer_armed[] must be cleared when detaching pending timers from
the AioContext. Failure to do so leads to hung I/O because it looks
like there are still timers pending when in fact they have been removed.
Other ThrottleGroupMembers might have requests pending too so it's
necessary to sch
On Mon, Nov 13, 2017 at 2:29 PM, Alberto Garcia wrote:
> On Fri 10 Nov 2017 04:19:34 PM CET, Stefan Hajnoczi wrote:
>> I/O requests hang after stop/cont commands at least since QEMU 2.10.0
>> with -drive iops=100:
>>
>> (guest)$ dd if=/dev/zero of=/dev/vdb oflag=direct count=1000
>> (qemu) sto
Which version of QEMU did you test this against ? It should be fixed in
current GIT master AFAIK
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1732671
Title:
vnc websocket compatibility issue
Sta
On 16.11.2017 11:54, Daniel P. Berrange wrote:
> On Thu, Nov 16, 2017 at 09:55:46AM +0100, Thomas Huth wrote:
>> The bios-tables-test was writing out files that we pass to iasl in
>> with the wrong endianness in the header when running on a big endian
>> host. So instead of storing mixed endian inf
I think it should have been fixed in 33badfd.
Sorry for the noise.
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1732671
Title:
vnc websocket com
On 2017年11月16日 16:11, Yan Vugenfirer wrote:
Hi Jason,
Windows driver will initialise only the amount of queue based on the amount of
available vCPUs. So if there will be more queues in the device than we have
vCPUs on the guest, the driver will not initialise “excessive” queues. This is
tie
From: "Emilio G. Cota"
We never noticed because it has no users.
Signed-off-by: Emilio G. Cota
Message-Id: <1510273811-13419-1-git-send-email-c...@braap.org>
Signed-off-by: Paolo Bonzini
---
include/qemu/thread-posix.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/includ
From: Philippe Mathieu-Daudé
Using obscure black magic introduced in eaa2ddbb767 :)
In an out-of-tree directory, running "../configure && make help" will generate
some required files (.mak), then clone some submodules, compile at least
the capstone submodule, generate QMP and Trace files, and fi
The following changes since commit d24aaf2a2915424962fb101142f28fa4307f4740:
Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into
staging (2017-11-06 11:24:14 +)
are available in the Git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
for you
From: "Dr. David Alan Gilbert"
Remove the last few DPRINTFs from hw/intc/ioapic.c and turn
them into tracing. In one case it's a new trace, in the others
it's just adding a parameter to the existing traces.
Signed-off-by: Dr. David Alan Gilbert
Message-Id: <20171102180310.24760-1-dgilb...@redh
From: Max Reitz
stat64_min_slow() and stat64_max_slow() compare the wrong way. This
makes iotest 136 fail with clang and -m32.
Signed-off-by: Max Reitz
Message-Id: <20171114232223.25207-1-mre...@redhat.com>
Signed-off-by: Paolo Bonzini
---
util/stats64.c | 4 ++--
1 file changed, 2 insertion
From: Dariusz Stojaczyk
Commit 5c0919d0 [1] introduced virtqueue_size parameter
for common virtio-scsi path, without updaing the vhost-user-scsi
code. vhost-user-scsi devices right now report size 0 for each vq.
This patch introduces virtqueue_size param to vhost-user-scsi,
that can now be set b
From: Mike Nawrocki
Some drivers for the PPMC7400 PowerPC evaluation board accesses the
serial registers through the floating point unit (stfd/ldfd), which is
an 8-byte wide access. This patch enables that behavior.
Signed-off-by: Mike Nawrocki
Message-Id: <20171106161039.32596-1-michael.nawro.
From: Wanpeng Li
Adds PV_TLB_FLUSH CPUID feature bit.
Cc: Paolo Bonzini
Cc: Radim KrÄmář
Cc: Richard Henderson
Cc: Eduardo Habkost
Signed-off-by: Wanpeng Li
Message-Id: <1510299947-11287-1-git-send-email-wanpeng...@hotmail.com>
Signed-off-by: Paolo Bonzini
---
target/i386/cpu.c | 2 +-
On 2017年11月16日 17:32, Longpeng (Mike) wrote:
Hi Jason,
On 2017/11/16 17:13, Jason Wang wrote:
On 2017年11月16日 17:01, Gonglei (Arei) wrote:
No, Windows guest + vhost-user/DPDK.
BTW pls see virtio spec in :
"If VIRTIO_NET_F_MQ is negotiated, each of receiveq1. . .receiveqN that will
be used
From: Pavel Dovgalyuk
This patch adds a condition before overwriting exception_index fiels.
It is needed when exception_index is already set to some meaningful value.
Signed-off-by: Pavel Dovgalyuk
Message-Id: <20171114081812.27640.26372.stgit@pasha-VirtualBox>
Signed-off-by: Paolo Bonzini
--
From: Pavel Dovgalyuk
This patch ensures that icount_decr.u32.high is clear before calling
cpu_exec_nocache when exception is pending. Because the exception is
caused by the first instruction in the block and it cannot be executed
without resetting the flag.
There are two parts in the fix. Fir
Am 15.11.2017 um 20:41 hat Peter Maydell geschrieben:
> On 6 November 2017 at 16:55, Kevin Wolf wrote:
> > error_setg_errno() takes a positive errno code.
> >
> > Signed-off-by: Kevin Wolf
> > ---
> > block.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/block.c
This fixes a crash caused by picking the wrong memory region in
address_space_lookup_region seen with client code accessing a device
model that uses alias memory regions. The expensive part of
address_space_lookup_region anyway is phys_page_find; performance-wise
it is okay to repeat the subsequen
From: Gerd Hoffmann
The minus sign after << causes the shell to strip only
preceding tabs, not spaces.
Signed-off-by: Gerd Hoffmann
Message-Id: <20171110090354.29608-1-kra...@redhat.com>
Fixes: 40bf8e9aede0f9105a9e1e4aaf17b20aaa55f9a0
Reviewed-by: Roman Kagan
Reviewed-by: Stefan Hajnoczi
Test
The bios-tables-test was writing out files that we pass to iasl in
with the wrong endianness in the header when running on a big endian
host. So instead of storing mixed endian information in our structures,
let's keep everything in little endian and byte-swap it only when we
need a value in the co
This reverts commit 5e89dc01133f8f5e621f6b66b356c6f37d31dafb since:
- we should use ID in the spec instead the one used by OEM
- in the future, we should allow changing id through either property
or EEPROM file.
Cc: Stefan Weil
Cc: Michael Nawrocki
Cc: Peter Maydell
Cc: Michael S. Tsirkin
S
Hi,
I'm resurrecting a thread about a QEMU crash we're still hitting on ppc64. It
was reported to the list by Bharata 2 months ago:
https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg03685.html
"Hi,
QEMU hits the below assert
qemu-system-ppc64: used ring relocated for ring 2
qemu-system-
Am 16.11.2017 um 13:20 schrieb Jason Wang:
> This reverts commit 5e89dc01133f8f5e621f6b66b356c6f37d31dafb since:
>
> - we should use ID in the spec instead the one used by OEM
> - in the future, we should allow changing id through either property
> or EEPROM file.
>
> Cc: Stefan Weil
> Cc: Micha
No problem, it is a valid bug report, since we've not actually released
the fix yet, so changing status.
** Changed in: qemu
Status: Invalid => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchp
On 11/16/2017 06:13 PM, Darren Kenny wrote:
On Thu, Nov 16, 2017 at 10:28:32AM +0800, Mao Zhongyi wrote:
Cc: Peter Maydell
Cc: Jason Wang
Cc: Zhang Chen
Cc: Li Zhijian
Cc: Paolo Bonzini
Fixes: 8ec14402029d783720f4312ed8a925548e1dad61
Reported-by: Peter Maydell
Reported-by: Paolo Bonzini
Hello, All!
We observe the following behavior for QEMU configured by libvirt
to use guest agent as usual for the guest without virtio-serial
driver (Windows or the guest remaining in BIOS stage).
In QEMU on first connect to listen character device socket
the listen socket is removed from poll jus
Public bug reported:
Ubuntu 17.04
qemu 2.10.1(Debian 1:2.10.0+dfsg-2)
gns3 2.0.3
NX-OSv 9k 7.0.3.I6.1
- No such issue with previous qemu 2.8.x
- the issue does not seem to come from the debian packaging
- the issue does not seem to come from GNS3 either, as confirmed by Jeremy
Grossmann at
http
Hi
- Original Message -
> On Mon, Nov 13, 2017 at 08:27:48PM +0100, Marc-André Lureau wrote:
> > Modify fw_cfg_read_blob() to use DMA if the device supports it.
> > Return errors, because the operation may fail.
> >
> > To avoid polling with unbound amount of time, the DMA operation is
>
On 15 November 2017 at 12:31, Stefan Berger wrote:
> This pull request is for 2.11 and extends documentation as well as fixes
> bugs related to concurrency and failure mode.
>
> The following changes since commit 4ffa88c99c54d2a30f79e3dbecec50b023eff1c8:
>
> Merge remote-tracking branch
> 'remo
On Wed, 15 Nov 2017 21:41:20 +0100
Gandalf Corvotempesta wrote:
> 2017-11-15 21:29 GMT+01:00 Richard W.M. Jones :
> > Gandalf, is there an XVA file publically available (pref. not
> > too big) that we can look at?
>
> I can try to provide one, but it's simple:
>
> # tar tvf 20160630_124823_aa72
A quick way to fetch string from qobject when it's a QString.
Reviewed-by: Fam Zheng
Signed-off-by: Peter Xu
---
include/qapi/qmp/qstring.h | 1 +
qobject/qstring.c | 11 +++
2 files changed, 12 insertions(+)
diff --git a/include/qapi/qmp/qstring.h b/include/qapi/qmp/qstring.
v4:
- drop first patch to fix IOWatchPool [Stefan, Dan]
- add s-o-b where missing, and newly got r-bs
- fix English error in commit msg [Fam]
- some tunes on request-dropped event: [Stefan]
- firstly let 'id' be any type, meanwhile make sure "id" is there as
long as OOB is enabled for the mo
We can simplify object_property_get_str() using the new
qobject_get_try_str().
Reviewed-by: Fam Zheng
Signed-off-by: Peter Xu
---
qom/object.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index c58c52d518..9cbeb51f0b 100644
--- a/qom/o
There are many places for monitor init its globals, at least:
- monitor_init_qmp_commands() at the very beginning
- single function to init monitor_lock
- in the first entry of monitor_init() using "is_first_init"
Unify them a bit.
Reviewed-by: Fam Zheng
Signed-off-by: Peter Xu
---
include/mo
The only difference from qstring_get_str() is that it allows the qstring
to be NULL. If so, NULL is returned.
CC: Eric Blake
CC: Markus Armbruster
Reviewed-by: Fam Zheng
Signed-off-by: Peter Xu
---
include/qapi/qmp/qstring.h | 1 +
qobject/qstring.c | 10 ++
2 files changed
Create one IOThread for the monitors, prepared to handle all the
input/output IOs using existing iothread framework.
Signed-off-by: Peter Xu
---
monitor.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/monitor.c b/monitor.c
index a70ab5606b..4ce9828fab 100644
It'll be passed to emit() as well when it happens. Since at it, add a
typedef for the emitter function.
Reviewed-by: Fam Zheng
Signed-off-by: Peter Xu
---
include/qapi/qmp/json-streamer.h | 10 --
monitor.c| 7 ---
qga/main.c | 5 +++-
For each Monitor, add one field "use_io_thr" to show whether it will be
using the dedicated monitor IO thread to handle input/output. When set,
monitor IO parsing work will be offloaded to dedicated monitor IO
thread, rather than the original main loop thread.
This only works for QMP. HMP will a
It's part of the data init. Collect it.
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Fam Zheng
Signed-off-by: Peter Xu
---
monitor.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/monitor.c b/monitor.c
index e36fb5308d..3940737c1c 100644
--- a/monitor.c
+++ b/
In monitor_qmp_read(), we have the hack to temporarily replace the
cur_mon pointer. Now we move this hack deeper inside the QMP dispatcher
routine since the Monitor pointer can be passed in to that using the new
JSON Parser opaque field now.
This does not make much sense as a single patch. Howev
Introduce qmp_cap_enabled() and qmp_oob_enabled() helpers.
Signed-off-by: Peter Xu
---
monitor.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/monitor.c b/monitor.c
index da03d1370f..655c25041c 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1038,6 +1038,16 @@ static void monitor_in
Set maximum QMP request queue length to 8. If queue full, instead of
queue the command, we directly return a "request-dropped" event, telling
client that specific command is dropped.
Note that this flow control mechanism is only valid if OOB is enabled.
If it's not, the effective queue length wil
After this patch, we will allow QMP clients to enable QMP capabilities
when sending the first "qmp_capabilities" command. Originally we are
starting QMP session with no arguments like:
{ "execute": "qmp_capabilities" }
Now we can enable some QMP capabilities using (take OOB as example,
which i
It was QLIST. I want to use this list to do monitor priority job later,
which need tail insertion ability. So switching to a tail queue.
Reviewed-by: Fam Zheng
Signed-off-by: Peter Xu
---
monitor.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/monitor.c b/moni
A tiny refactoring, preparing to split the QMP dispatcher away.
Reviewed-by: Fam Zheng
Signed-off-by: Peter Xu
---
monitor.c | 48 +++-
1 file changed, 31 insertions(+), 17 deletions(-)
diff --git a/monitor.c b/monitor.c
index 655c25041c..ec03f1b232
So it can get rid of being run on main thread.
Signed-off-by: Peter Xu
---
qapi/migration.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index bbc4671ded..95098072dd 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@
Monitor code now can be run in more than one thread. Let the suspend
and resume code be thread safe.
Reviewed-by: Fam Zheng
Signed-off-by: Peter Xu
---
monitor.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/monitor.c b/monitor.c
index ec03f1b232..30f9cd80de 100644
-
Here "oob" stands for "Out-Of-Band". When "allow-oob" is set, it means
the command allows out-of-band execution.
The "oob" idea is proposed by Markus Armbruster in following thread:
https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02057.html
This new "allow-oob" boolean will be expose
There was no QMP capabilities defined. Define the first "oob" as
capability to allow out-of-band messages.
Also, touch up qmp-test.c to test the new bits.
Signed-off-by: Peter Xu
---
monitor.c| 15 +--
qapi-schema.json | 13 +
tests/qmp-test.c | 10 +-
3
This event will be emitted if one QMP request is dropped. Along,
declare an enum for the reasons.
Signed-off-by: Peter Xu
---
qapi-schema.json | 34 ++
1 file changed, 34 insertions(+)
diff --git a/qapi-schema.json b/qapi-schema.json
index 531fd4c0db..9d2625b6b3
Start to use dedicate IO thread for QMP monitors that are not using
MUXed chardev.
Signed-off-by: Peter Xu
---
monitor.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/monitor.c b/monitor.c
index b18d9d696c..5e0b8ed9c5 100644
--- a/monitor.c
+++ b/monitor.c
@@ -36,6 +36,7
On Thu, 16 Nov 2017 13:56:16 +0100
Tomáš Golembiovský wrote:
> On Wed, 15 Nov 2017 21:41:20 +0100
> Gandalf Corvotempesta wrote:
>
> > 2017-11-15 21:29 GMT+01:00 Richard W.M. Jones :
> > > Gandalf, is there an XVA file publically available (pref. not
> > > too big) that we can look at?
> >
Originally QMP goes throw these steps:
JSON Parser --> QMP Dispatcher --> Respond
/|\(2)(3) |
(1) | \|/ (4)
+- main thread +
This patch does this:
JSON Parser QMP Dispatcher --> Respond
/|\ |
Update both the developer and spec for the new QMP OOB (Out-Of-Band)
command.
Signed-off-by: Peter Xu
---
docs/devel/qapi-code-gen.txt | 51 +++-
docs/interop/qmp-spec.txt| 35 +-
2 files changed, 76 insertions(+), 10 deleti
On Thu 16 Nov 2017 12:21:50 PM CET, Stefan Hajnoczi wrote:
> tg->any_timer_armed[] must be cleared when detaching pending timers from
> the AioContext. Failure to do so leads to hung I/O because it looks
> like there are still timers pending when in fact they have been removed.
>
> Other ThrottleG
On 11/16/2017 04:32 AM, Michael S. Tsirkin wrote:
On Fri, Nov 03, 2017 at 04:13:06PM +0800, Wei Wang wrote:
Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_VQ feature indicates the
support of reporting hints of guest free pages to the host via
virtio-balloon. The host requests the guest to report
OOB introduced DROP event for flow control. This should not affect old
QMP clients. Add a command batching check to make sure of it.
Signed-off-by: Peter Xu
---
tests/qmp-test.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/tests/qmp-test.c b/tests/qmp-test.c
index 2
Having "allow-oob" to true for a command does not mean that this command
will always be run in out-of-band mode. The out-of-band quick path will
only be executed if we specify the extra "run-oob" flag when sending the
QMP request:
{ "execute": "command-that-allows-oob",
"arguments": {
On 15/11/2017 10:51 PM, Max Reitz wrote:
On 2017-11-14 11:16, Anton Nefedov wrote:
Signed-off-by: Anton Nefedov
---
tests/qemu-iotests/030 | 69 +-
tests/qemu-iotests/030.out | 4 +--
2 files changed, 70 insertions(+), 3 deletions(-)
diff
For those monitors who has enabled IO thread, we'll offload the
responding procedure into IO thread. The main reason is that chardev is
not thread safe, and we need to do all the read/write IOs in the same
thread. For use_io_thr=true monitors, that thread is the IO thread.
We do this isolation i
Hi
- Original Message -
> On Mon, Nov 13, 2017 at 08:29:56PM +0100, Marc-André Lureau wrote:
> > Modify fw_cfg_read_blob() to use DMA if the device supports it.
> > Return errors, because the operation may fail.
> >
> > To avoid polling with unbound amount of time, the DMA operation is
>
1 - 100 of 285 matches
Mail list logo
