Re: About 'qemu-security' mailing list

2020-09-18 Thread P J P
Hello all, +-- On Wed, 16 Sep 2020, Stefan Hajnoczi wrote --+ | I'm surprised the lack of encryption doesn't bother you. The security bug | reporting process should be confidential to prevent disclosure of 0-days. * I think it'll work only if all issue reports are encrypted. Under current p

Re: [PATCH] checkpatch: avoid error on cover letter files

2020-09-18 Thread Stefano Garzarella
On Thu, Sep 17, 2020 at 07:44:21PM +0200, Philippe Mathieu-Daudé wrote: > On 9/17/20 7:02 PM, Stefano Garzarella wrote: > > Running checkpatch on a directory that contains a cover letter reports > > this error: > > > > Checking /tmp/tmpbnngauy3/-cover-letter.patch... > > ERROR: Does n

[PATCH v9 01/13] tests/acpi: mark addition of table DSDT.roothp for unit testing root pci hotplug

2020-09-18 Thread Ani Sinha
A new binary acpi table tests/data/acpi/pc/DSDT.roothp is added in order to unit test the feature flag that can disable/enable root pci bus hotplug on i440fx. This feature was added with the commit: 3d7e78aaf0 ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus") This chan

[PATCH v9 04/13] Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus

2020-09-18 Thread Ani Sinha
When ACPI hotplug for the root bus is disabled, the bsel property for that bus is not set. Please see the following commit: 3d7e78aaf ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus"). As a result, when acpi_pcihp_find_hotplug_bus() is called with bsel set to 0, it ma

[PATCH v9 00/13] i440fx/acpi: addition of feature and bug fixes

2020-09-18 Thread Ani Sinha
v9: added a new patch which adds names of changed acpi blobs in bios-tables-test-accepted-diff.h Ani Sinha (13): tests/acpi: mark addition of table DSDT.roothp for unit testing root pci hotplug tests/acpi: add new unit test to test hotplug off/on feature on the root pci bus tests/a

[PATCH v9 07/13] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag

2020-09-18 Thread Ani Sinha
This change adds a new unit test for the global flag 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci bridges in i440fx. The flag can be used to turn off ACPI based hotplug support on all pci bridges. Signed-off-by: Ani Sinha Reviewed-by: Igor Mammedov --- tests/qt

[PATCH v9 05/13] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

2020-09-18 Thread Ani Sinha
Cold plugged bridges are not hot unpluggable, even when their hotplug property (acpi-pci-hotplug-with-bridge-support) is turned off. Please see the function acpi_pcihp_pc_no_hotplug(). However, with the current implementaton, Windows would try to hot-unplug a pci bridge when it's hotplug switch is

[PATCH v9 02/13] tests/acpi: add new unit test to test hotplug off/on feature on the root pci bus

2020-09-18 Thread Ani Sinha
Ability to turn hotplug off on the pci root bus for i440fx was added in commit: 3d7e78aaf0 ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus") This change adds a unit test in order to test this feature. Signed-off-by: Ani Sinha Reviewed-by: Igor Mammedov --- tests/qt

[PATCH v9 12/13] tests/acpi: unit test exercising global pci hotplug off for i440fx

2020-09-18 Thread Ani Sinha
This change adds a unit test to exercise the case when hotplug is disabled both for pci root bus and the pci bridges by passing the following two switches to qemu: -global PIIX4_PM.acpi-root-pci-hotplug=off -global PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off bios-tables-test-allowed-dif

[PATCH v9 09/13] Add ACPI DSDT tables for q35 that are being updated by the next patch

2020-09-18 Thread Ani Sinha
The following patch 7b7d8ff077 ("piix4: don't reserve hw resources when hotplug is off globally") modifies certain ACPI tables for q35 machines. This patch adds those table names to tests/qtest/bios-tables-test-allowed-diff.h so that unit tests continues to pass and bisection is not broken. Signed

[PULL 3/3] misc: aspeed_scu: Update AST2600 silicon id register

2020-09-18 Thread Cédric Le Goater
From: Joel Stanley Aspeed have released an updated datasheet (v7) containing the silicon id for the AST2600 A2. It looks like this: SCU004 SCU014 AST2600-A0 0x05000303 0x05000303 AST2600-A1 0x05010303 0x05010303 AST2600-A2 0x05010303 0x05020303 AST2620-A1 0x0501

[PATCH v9 03/13] tests/acpi: add a new ACPI table in order to test root pci hotplug on/off

2020-09-18 Thread Ani Sinha
A new binary ACPI table tests/data/acpi/pc/DSDT.roothp is added in order to unit test hotplug on/off capability on the root pci bus for i440fx. The diff between the table DSDT.bridge and DSDT.roothp is listed below: @@ -1,30 +1,30 @@ /* * Intel ACPI Component Architecture * AML/ASL+ Disassemb

[PATCH v9 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

2020-09-18 Thread Ani Sinha
This change adds a new DSDT golden master table blob to test disabling hotplug on both pci root bus and pci bridges. Also reverts the change in file bios-tables-test-allowed-diff.h to make sure its now empty so that future modifications to acpi tables can be caught. The following is the disassembl

[PULL 0/3] aspeed queue

2020-09-18 Thread Cédric Le Goater
ull-aspeed-20200918 for you to fetch changes up to 204dab83fe00a3e0781d93ad7899192a9409e987: misc: aspeed_scu: Update AST2600 silicon id register (2020-09-18 09:04:36 +0200) Aspeed patches : * Couple of cleanups * New machine pro

[PATCH v9 06/13] tests/acpi: list added acpi table binary file for pci bridge hotplug test

2020-09-18 Thread Ani Sinha
The file 'tests/data/acpi/pc/DSDT.hpbridge' is a newly added acpi table file for testing the pci bridge option 'acpi-pci-hotplug-with-bridge-support' under i440fx. This change documents this fact. Signed-off-by: Ani Sinha Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.

[PATCH v9 11/13] tests/acpi: update golden master DSDT binary table blobs for q35

2020-09-18 Thread Ani Sinha
In the change d7f82561fe ("piix4: don't reserve hw resources when hotplug is off globally"), we make changes to the ACPI DSDT tables such that some ACPI code are not generated when bsel is absent. Since as of this point in time, in q35 machines, we do not use bsel for pci buses, we need to update t

[PULL 1/3] hw/arm/aspeed: Map the UART5 device unconditionally

2020-09-18 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé The UART5 is present on the machine regardless there is a character device connected to it. Map it unconditionally. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Message-Id: <20200905212415.760452-1-f4...@amsat.org> Signed-off-by: Cédric Le Go

[PATCH v9 08/13] tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag

2020-09-18 Thread Ani Sinha
This patch adds a binary blob corresponding to the DSDT acpi table. It is used to unit test the flag 'acpi-pci-hotplug-with-bridge-support' used with pci bridges. This change also clears the file tests/qtest/bios-tables-test-allowed-diff.h so that future changes which affect the table can be caugh

[PULL 2/3] hw/arm/aspeed: Add machine properties to define the flash models

2020-09-18 Thread Cédric Le Goater
Some machines don't have much differences a part from the flash model being used. Introduce new machine properties to change them from the command line. For instance, to start the ast2500-evb machine with a different FMC chip and a 64M SPI chip, use : -M ast2500-evb,fmc-model=mx25l25635e,spi-mo

[PATCH v9 10/13] piix4: don't reserve hw resources when hotplug is off globally

2020-09-18 Thread Ani Sinha
When acpi hotplug is turned off for both root pci bus as well as for pci bridges, we should not generate the related ACPI code for DSDT table or initialize related hw ports or reserve hw resources. This change makes sure all those operations are turned off in the case ACPI pci hotplug is off global

Re: About 'qemu-security' mailing list

2020-09-18 Thread P J P
Hello Alex, +-- On Fri, 11 Sep 2020, Alexander Bulekov wrote --+ | * I'm guessing this will be a closed list with some application/vetting |procedure for the participants? (Maybe this is what you mean by |"moderated" ?) Yes. | * Will secalert still be subscribed (for managing CVE I

Re: [PULL 0/3] aspeed queue

2020-09-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200918072703.331138-1-...@kaod.org/ Hi, This series seems to have some coding style problems. See output below for more information: N/A. Internal error while reading log file The full log is available at http://patchew.org/logs/20200918072703.331138-

[PATCH v3 0/4] vhost-vsock: force virtio version 1

2020-09-18 Thread Stefano Garzarella
v3: - Added patch 1 (v2: [1]) since it is a prerequisite for other patches - Patch 1: - added virtio_legacy_check_disabled() helper - moved warning where error was returned [Cornelia] - Patches 2 & 4: - forced virtio version 1 only with new machine types - removed Corne

[PATCH v3 3/4] vhost-user-vsock-pci: force virtio version 1

2020-09-18 Thread Stefano Garzarella
Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a safety check that requires to set 'disable-legacy=on' on vhost-user-vsock-pci device: $ ./qemu-system-x86_64 ... \ -chardev socket,id=char0,reconnect=0,path=/tmp/vhost4.socket \ -device vhost-user-v

Re: [PATCH 00/37] qapi: static typing conversion, pt1

2020-09-18 Thread Markus Armbruster
John Snow writes: > On 9/15/20 6:39 PM, John Snow wrote: >> Hi, this series starts adding static type hints to the QAPI module. As >> you can see, the series started getting quite a bit long, so this is >> only a partial conversion that focuses on a handful of the easier files. >> The tougher fil

[PATCH v3 1/4] virtio: skip legacy support check on machine types less than 5.1

2020-09-18 Thread Stefano Garzarella
Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a check that returns an error if legacy support is on, but the device is not legacy. Unfortunately some devices were wrongly declared legacy even if they were not (e.g vhost-vsock). To avoid migration issues, we

[PATCH v3 2/4] vhost-vsock-pci: force virtio version 1

2020-09-18 Thread Stefano Garzarella
Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a safety check that requires to set 'disable-legacy=on' on vhost-vsock-pci device: $ ./qemu-system-x86_64 ... -device vhost-vsock-pci,guest-cid=5 qemu-system-x86_64: -device vhost-vsock-pci,guest-cid=

Re: [PATCH v9 09/13] Add ACPI DSDT tables for q35 that are being updated by the next patch

2020-09-18 Thread Igor Mammedov
On Fri, 18 Sep 2020 12:53:21 +0530 Ani Sinha wrote: > The following patch 7b7d8ff077 ("piix4: don't reserve hw resources when > hotplug is off globally") modifies certain ACPI tables for q35 machines. > This patch adds those table names to > tests/qtest/bios-tables-test-allowed-diff.h > so that

[PATCH v3 4/4] vhost-vsock-ccw: force virtio version 1

2020-09-18 Thread Stefano Garzarella
virtio-vsock was introduced after the release of VIRTIO 1.0 specifications, so it should be 'modern-only'. This patch forces virtio version 1 as done for vhost-vsock-pci. To avoid migration issues, we force virtio version 1 only when legacy check is enabled in the new machine types (>= 5.1). Cc:

Re: [PATCH v3 0/4] vhost-vsock: force virtio version 1

2020-09-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200918074710.27810-1-sgarz...@redhat.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. The full log is available at http://patchew.org/logs/20200918074710.27810-1-sgarz...@redhat.com/testing.FreeBSD/?type=messag

Re: [PATCH] checkpatch: avoid error on cover letter files

2020-09-18 Thread Paolo Bonzini
On 18/09/20 09:05, Stefano Garzarella wrote: > On Thu, Sep 17, 2020 at 07:44:21PM +0200, Philippe Mathieu-Daudé wrote: >> On 9/17/20 7:02 PM, Stefano Garzarella wrote: >>> Running checkpatch on a directory that contains a cover letter reports >>> this error: >>> >>> Checking /tmp/tmpbnngauy3

Re: [PATCH v9 10/13] piix4: don't reserve hw resources when hotplug is off globally

2020-09-18 Thread Igor Mammedov
On Fri, 18 Sep 2020 12:53:22 +0530 Ani Sinha wrote: > When acpi hotplug is turned off for both root pci bus as well as for pci > bridges, we should not generate the related ACPI code for DSDT table or > initialize related hw ports or reserve hw resources. This change makes > sure all those operat

[PATCH v10 1/7] libvhost-user: Allow vu_message_read to be replaced

2020-09-18 Thread Coiby Xu
Allow vu_message_read to be replaced by one which will make use of the QIOChannel functions. Thus reading vhost-user message won't stall the guest. For slave channel, we still use the default vu_message_read. Reviewed-by: Marc-André Lureau Signed-off-by: Coiby Xu --- contrib/libvhost-user/libvh

[PATCH v10 2/7] libvhost-user: remove watch for kick_fd when de-initialize vu-dev

2020-09-18 Thread Coiby Xu
When the client is running in gdb and quit command is run in gdb, QEMU will still dispatch the event which will cause segment fault in the callback function. Signed-off-by: Coiby Xu --- contrib/libvhost-user/libvhost-user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/libvhost-use

[PATCH v10 0/7] vhost-user block device backend implementation

2020-09-18 Thread Coiby Xu
v10 - Use a linked list of VuFdWatch objects to keep kick info [Stefan] - Merge improvements and fixes from Stefan - Rename libvhost-user's vu_message_read to vu_message_read_default [Kevin] - When shutting down the client, wait for the coroutine of processing vhost-user messages to be finis

Re: [PATCH v3 07/10] disas: Configure capstone for aarch64 host without libvixl

2020-09-18 Thread Philippe Mathieu-Daudé
On 9/18/20 1:57 AM, Richard Henderson wrote: > The ifdef tangle failed to set cap_arch if libvixl itself > was not configured (e.g. due to lack of c++ compiler). > > Reviewed-by: Thomas Huth > Signed-off-by: Richard Henderson > --- > disas.c | 6 -- > 1 file changed, 4 insertions(+), 2 dele

[PATCH v10 3/7] util/vhost-user-server: generic vhost user server

2020-09-18 Thread Coiby Xu
Sharing QEMU devices via vhost-user protocol. Only one vhost-user client can connect to the server one time. Suggested-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi Signed-off-by: Coiby Xu --- util/meson.build | 1 + util/vhost-user-server.c | 428 +++

[PATCH v10 4/7] block: move logical block size check function to a common utility function

2020-09-18 Thread Coiby Xu
Move the constants from hw/core/qdev-properties.c to util/block-helpers.h so that knowledge of the min/max values is Signed-off-by: Stefan Hajnoczi Signed-off-by: Coiby Xu --- hw/core/qdev-properties.c | 31 +- util/block-helpers.c | 46 +

[PATCH v10 6/7] test: new qTest case to test the vhost-user-blk-server

2020-09-18 Thread Coiby Xu
This test case has the same tests as tests/virtio-blk-test.c except for tests have block_resize. Since vhost-user server can only server one client one time, two instances of vhost-user-blk-server are started by qemu-storage-daemon for the hotplug test. In order to not block scripts/tap-driver.pl,

[PATCH v10 5/7] block/export: vhost-user block device backend server

2020-09-18 Thread Coiby Xu
By making use of libvhost-user, block device drive can be shared to the connected vhost-user client. Only one client can connect to the server one time. Since vhost-user-server needs a block drive to be created first, delay the creation of this object. Suggested-by: Kevin Wolf Signed-off-by: Ste

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-18 Thread Yonggang Luo
On Fri, Sep 18, 2020 at 7:59 AM Richard Henderson < richard.hender...@linaro.org> wrote: > > There are better ways to do this, e.g. meson cmake subproject, > but that requires cmake 3.7 and some of our CI environments > only provide cmake 3.5. > > Nor can we add a meson.build file to capstone/, bec

[PATCH v10 7/7] MAINTAINERS: Add vhost-user block device backend server maintainer

2020-09-18 Thread Coiby Xu
Suggested-by: Stefano Garzarella Signed-off-by: Coiby Xu --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3d17cad19a..55ad6abe73 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3039,6 +3039,14 @@ L: qemu-bl...@nongnu.org S: Supported F:

Re: [PATCH 2/2] add maximum combined fw size as machine configuration option

2020-09-18 Thread Philippe Mathieu-Daudé
Hi Erich, On 9/18/20 6:23 AM, Erich Mcmillan wrote: > From: Erich McMillan Description/rationale? > > Signed-off-by: Erich McMillan > --- > hw/i386/pc.c | 40 > hw/i386/pc_sysfw.c | 13 ++--- > include/hw/i386/pc.h | 22 -

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-18 Thread Paolo Bonzini
On 18/09/20 01:57, Richard Henderson wrote: > There are better ways to do this, e.g. meson cmake subproject, > but that requires cmake 3.7 and some of our CI environments > only provide cmake 3.5. > > Nor can we add a meson.build file to capstone/, because the git > submodule would then always rep

Re: [PATCH v9 0/5] vhost-user block device backend implementation

2020-09-18 Thread Coiby Xu
On Tue, Sep 15, 2020 at 04:35:57PM +0100, Stefan Hajnoczi wrote: On Mon, Jun 15, 2020 at 02:39:02AM +0800, Coiby Xu wrote: v9 - move logical block size check function to a utility function - fix issues regarding license, coding style, memory deallocation, etc. Hi, Any update on v10? Please

Re: [PATCH v2 0/3] hw/sd/sdhci: Fix DMA Transfer Block Size field width

2020-09-18 Thread Philippe Mathieu-Daudé
On 9/1/20 4:04 PM, Philippe Mathieu-Daudé wrote: > Fix the SDHCI issue reported last week by Alexander: > https://bugs.launchpad.net/qemu/+bug/1892960 > > The field is 12-bit (4KiB) but the guest can set > up to 16-bit (64KiB), leading to OOB access. > > since v1: > commited unstaged change in pa

Re: [PATCH 0/4] hw/sd/sdhci: Strengthen multiple DMA transfers

2020-09-18 Thread Philippe Mathieu-Daudé
On 9/3/20 7:28 PM, Philippe Mathieu-Daudé wrote: > Still trying to fix the bugs reported by Aleksander... > > - Do not send 0 block count > - Reduce DMA to MMIO re-entrancy by yielding when pending IRQ > > Based-on: <20200901140411.112150-1-f4...@amsat.org> > > Philippe Mathieu-Daudé (4): > hw

Re: [PATCH v9 11/13] tests/acpi: update golden master DSDT binary table blobs for q35

2020-09-18 Thread Igor Mammedov
On Fri, 18 Sep 2020 12:53:23 +0530 Ani Sinha wrote: > In the change d7f82561fe ("piix4: don't reserve hw resources when > hotplug is off globally"), we make changes to the ACPI DSDT tables > such that some ACPI code are not generated when bsel is absent. Since > as of this point in time, in q35 m

Re: [PATCH 2/2] add maximum combined fw size as machine configuration option

2020-09-18 Thread Daniel P . Berrangé
On Fri, Sep 18, 2020 at 04:23:39AM +, Erich Mcmillan wrote: > From: Erich McMillan > > Signed-off-by: Erich McMillan > --- > hw/i386/pc.c | 40 > hw/i386/pc_sysfw.c | 13 ++--- > include/hw/i386/pc.h | 22 -- > 3

Re: [PATCH] hw/nvram/fw_cfg: fix FWCfgDataGeneratorClass::get_data() consumption

2020-09-18 Thread Philippe Mathieu-Daudé
On 9/16/20 5:15 PM, Laszlo Ersek wrote: > The documentation on g_byte_array_free() > > says: > >> Returns >> >> the element data if free_segment is FALSE, otherwise NULL. The element >> data should be freed using g_f

Re: [PATCH] target/i386: always create kvmclock device

2020-09-18 Thread Paolo Bonzini
On 17/09/20 13:13, Vitaly Kuznetsov wrote: > QEMU's kvmclock device is only created when KVM PV feature bits for > kvmclock (KVM_FEATURE_CLOCKSOURCE/KVM_FEATURE_CLOCKSOURCE2) are > exposed to the guest. With 'kvm=off' cpu flag the device is not > created and we don't call KVM_GET_CLOCK/KVM_SET_CLOC

[PATCH v10 00/13] i440fx/acpi: addition of feature and bug fixes.

2020-09-18 Thread Ani Sinha
Final patch series with all the patches reviewed or ack'd and marked as such. Thanks Julia and Igor for the reviews. Hope this series gets pulled in soon. --Ani Ani Sinha (13): tests/acpi: mark addition of table DSDT.roothp for unit testing root pci hotplug tests/acpi: add new unit test t

[PATCH v10 01/13] tests/acpi: mark addition of table DSDT.roothp for unit testing root pci hotplug

2020-09-18 Thread Ani Sinha
A new binary acpi table tests/data/acpi/pc/DSDT.roothp is added in order to unit test the feature flag that can disable/enable root pci bus hotplug on i440fx. This feature was added with the commit: 3d7e78aaf0 ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus") This chan

Re: [PATCH] target/i386: always create kvmclock device

2020-09-18 Thread Paolo Bonzini
On 17/09/20 19:44, Dr. David Alan Gilbert wrote: >> This may happen with an older machine type when the destination is >> running an unfixed QEMU and the source has the fix, right? > Yes I think so. > >> The solution >> would be to introduce a flag for older machine types (or for new ones) >> like

[PATCH v10 07/13] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag

2020-09-18 Thread Ani Sinha
This change adds a new unit test for the global flag 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci bridges in i440fx. The flag can be used to turn off ACPI based hotplug support on all pci bridges. Signed-off-by: Ani Sinha Reviewed-by: Igor Mammedov --- tests/qt

[PATCH v10 10/13] piix4: don't reserve hw resources when hotplug is off globally

2020-09-18 Thread Ani Sinha
When acpi hotplug is turned off for both root pci bus as well as for pci bridges, we should not generate the related ACPI code for DSDT table or initialize related hw ports or reserve hw resources. This change makes sure all those operations are turned off in the case ACPI pci hotplug is off global

[PATCH v10 02/13] tests/acpi: add new unit test to test hotplug off/on feature on the root pci bus

2020-09-18 Thread Ani Sinha
Ability to turn hotplug off on the pci root bus for i440fx was added in commit: 3d7e78aaf0 ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus") This change adds a unit test in order to test this feature. Signed-off-by: Ani Sinha Reviewed-by: Igor Mammedov --- tests/qt

[PATCH v10 04/13] Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus

2020-09-18 Thread Ani Sinha
When ACPI hotplug for the root bus is disabled, the bsel property for that bus is not set. Please see the following commit: 3d7e78aaf ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus"). As a result, when acpi_pcihp_find_hotplug_bus() is called with bsel set to 0, it ma

[PATCH v10 03/13] tests/acpi: add a new ACPI table in order to test root pci hotplug on/off

2020-09-18 Thread Ani Sinha
A new binary ACPI table tests/data/acpi/pc/DSDT.roothp is added in order to unit test hotplug on/off capability on the root pci bus for i440fx. The diff between the table DSDT.bridge and DSDT.roothp is listed below: @@ -1,30 +1,30 @@ /* * Intel ACPI Component Architecture * AML/ASL+ Disassemb

[PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

2020-09-18 Thread Ani Sinha
This change adds a new DSDT golden master table blob to test disabling hotplug on both pci root bus and pci bridges. Also reverts the change in file bios-tables-test-allowed-diff.h to make sure its now empty so that future modifications to acpi tables can be caught. The following is the disassembl

[PATCH v10 05/13] i440fx/acpi: do not add hotplug related amls for cold plugged bridges

2020-09-18 Thread Ani Sinha
Cold plugged bridges are not hot unpluggable, even when their hotplug property (acpi-pci-hotplug-with-bridge-support) is turned off. Please see the function acpi_pcihp_pc_no_hotplug(). However, with the current implementaton, Windows would try to hot-unplug a pci bridge when it's hotplug switch is

[PATCH v10 09/13] Add ACPI DSDT tables for q35 that are being updated by the next patch

2020-09-18 Thread Ani Sinha
The following patch 7b7d8ff077 ("piix4: don't reserve hw resources when hotplug is off globally") modifies certain ACPI tables for q35 machines. This patch adds those table names to tests/qtest/bios-tables-test-allowed-diff.h so that unit tests continues to pass and bisection is not broken. Signed

[PATCH v10 06/13] tests/acpi: list added acpi table binary file for pci bridge hotplug test

2020-09-18 Thread Ani Sinha
The file 'tests/data/acpi/pc/DSDT.hpbridge' is a newly added acpi table file for testing the pci bridge option 'acpi-pci-hotplug-with-bridge-support' under i440fx. This change documents this fact. Signed-off-by: Ani Sinha Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.

How to convert fowlloing code from configure to meson.build

2020-09-18 Thread Yonggang Luo
## # iconv probe if test "$iconv" != "no" ; then cat > $TMPC << EOF #include int main(void) { iconv_t conv = iconv_open("WCHAR_T", "UCS-2"); return conv != (iconv_t) -1; } EOF iconv_prefix_list="/usr/local:/usr" iconv_lib_list=":-liconv" IFS=:

[PATCH v10 08/13] tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag

2020-09-18 Thread Ani Sinha
This patch adds a binary blob corresponding to the DSDT acpi table. It is used to unit test the flag 'acpi-pci-hotplug-with-bridge-support' used with pci bridges. This change also clears the file tests/qtest/bios-tables-test-allowed-diff.h so that future changes which affect the table can be caugh

[PATCH v10 11/13] tests/acpi: update golden master DSDT binary table blobs for q35

2020-09-18 Thread Ani Sinha
In the change d7f82561fe ("piix4: don't reserve hw resources when hotplug is off globally"), we make changes to the ACPI DSDT tables such that some ACPI code are not generated when bsel is absent. Since as of this point in time, in q35 machines, we do not use bsel for pci buses, we need to update t

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-18 Thread Yonggang Luo
On Fri, Sep 18, 2020 at 4:19 PM Paolo Bonzini wrote: > > On 18/09/20 01:57, Richard Henderson wrote: > > There are better ways to do this, e.g. meson cmake subproject, > > but that requires cmake 3.7 and some of our CI environments > > only provide cmake 3.5. > > > > Nor can we add a meson.build f

Re: [PATCH] configure: do not limit Hypervisor.framework test to Darwin

2020-09-18 Thread Paolo Bonzini
On 17/09/20 19:51, Roman Bolshakov wrote: > On Wed, Sep 16, 2020 at 04:11:31AM -0400, Paolo Bonzini wrote: >> Because the target/i386/hvf/meson.build rule culls hvf support >> on non-Darwin systems, a --enable-hvf build is succeeding. >> To fix this, just try the compilation test every time someone

[PATCH v10 12/13] tests/acpi: unit test exercising global pci hotplug off for i440fx

2020-09-18 Thread Ani Sinha
This change adds a unit test to exercise the case when hotplug is disabled both for pci root bus and the pci bridges by passing the following two switches to qemu: -global PIIX4_PM.acpi-root-pci-hotplug=off -global PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off bios-tables-test-allowed-dif

[PATCH v2] s390x/tcg: Implement MONITOR CALL

2020-09-18 Thread David Hildenbrand
Recent upstream Linux uses the MONITOR CALL instruction for things like BUG_ON() and WARN_ON(). We currently inject an operation exception when we hit a MONITOR CALL instruction - which is wrong, as the instruction is not glued to specific CPU features. Doing a simple WARN_ON_ONCE() currently resu

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

2020-09-18 Thread Daniel Berrange
Please give more info on your host OS build environment, and most importantly confirm that you have tried doing a build from a *completely* clean git checkout. Recent build system changes introduced risk of problems if you have not done a full clean. "git clean -f -x -d" will delete every file in y

[PATCH v2] docs: simplify and clarify the platform support rules

2020-09-18 Thread Daniel P . Berrangé
The distinction between short life and long life Linux distributions turned out to be redundant. They can both be covered in a simple way by noting support will target the current release, and the previous release for a period of two years or until its EOL. This rule can also apply to the other UNI

Re: [PATCH v3 1/4] virtio: skip legacy support check on machine types less than 5.1

2020-09-18 Thread Cornelia Huck
On Fri, 18 Sep 2020 09:47:07 +0200 Stefano Garzarella wrote: > Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally > on") added a check that returns an error if legacy support is on, but the > device is not legacy. s/is not legacy/does not support legacy/ ? > > Unfortuna

Re: [PATCH v3 2/4] vhost-vsock-pci: force virtio version 1

2020-09-18 Thread Cornelia Huck
On Fri, 18 Sep 2020 09:47:08 +0200 Stefano Garzarella wrote: > Commit 9b3a35ec82 ("virtio: verify that legacy support is not > accidentally on") added a safety check that requires to set > 'disable-legacy=on' on vhost-vsock-pci device: > > $ ./qemu-system-x86_64 ... -device vhost-vsock-pci,g

Re: [PATCH v3 3/4] vhost-user-vsock-pci: force virtio version 1

2020-09-18 Thread Cornelia Huck
On Fri, 18 Sep 2020 09:47:09 +0200 Stefano Garzarella wrote: > Commit 9b3a35ec82 ("virtio: verify that legacy support is not > accidentally on") added a safety check that requires to set > 'disable-legacy=on' on vhost-user-vsock-pci device: > > $ ./qemu-system-x86_64 ... \ > -chardev soc

[PATCH 2/4] net/colo-compare.c: Change the timer clock type

2020-09-18 Thread Zhang Chen
From: Zhang Chen The virtual clock only runs during the emulation. It stops when the virtual machine is stopped. The host clock should be used for device models that emulate accurate real time sources. It will continue to run when the virtual machine is suspended. COLO need to know the host time

[PATCH 0/4] Several optimization and bugfix for COLO compare.

2020-09-18 Thread Zhang Chen
From: Zhang Chen Add COLO secondary old packet detection and fix some bugs. Zhang Chen (4): net/colo-compare.c: Fix compare_timeout format issue net/colo-compare.c: Change the timer clock type net/colo-compare.c: Add secondary old packet detection net/colo-compare.c: Increase default que

Re: [PATCH v3 4/5] sev/i386: Don't allow a system reset under an SEV-ES guest

2020-09-18 Thread Dr. David Alan Gilbert
* Tom Lendacky (thomas.lenda...@amd.com) wrote: > On 9/17/20 12:01 PM, Dr. David Alan Gilbert wrote: > > * Tom Lendacky (thomas.lenda...@amd.com) wrote: > > > From: Tom Lendacky > > > > > > An SEV-ES guest does not allow register state to be altered once it has > > > been measured. When a SEV-ES

[PATCH 3/4] net/colo-compare.c: Add secondary old packet detection

2020-09-18 Thread Zhang Chen
From: Zhang Chen Detect queued secondary packet to sync VM state in time. Signed-off-by: Zhang Chen --- net/colo-compare.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 3b72309d08..f7271b976f 100644

[PATCH 1/4] net/colo-compare.c: Fix compare_timeout format issue

2020-09-18 Thread Zhang Chen
From: Zhang Chen This parameter need compare with the return of qemu_clock_get_ms(), it is uinit64_t. So we need fix this issue here. Reported-by: Derek Su Signed-off-by: Zhang Chen --- net/colo-compare.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/col

[PATCH 4/4] net/colo-compare.c: Increase default queued packet scan frequency

2020-09-18 Thread Zhang Chen
From: Zhang Chen In my test, use this default parameter looks better. Signed-off-by: Zhang Chen --- net/colo-compare.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index f7271b976f..6df6a7e66f 100644 --- a/net/colo-compare.c +++ b/

Re: [PATCH v3 4/4] vhost-vsock-ccw: force virtio version 1

2020-09-18 Thread Cornelia Huck
On Fri, 18 Sep 2020 09:47:10 +0200 Stefano Garzarella wrote: > virtio-vsock was introduced after the release of VIRTIO 1.0 > specifications, so it should be 'modern-only'. > > This patch forces virtio version 1 as done for vhost-vsock-pci. > > To avoid migration issues, we force virtio version

Re: [PATCH v2 2/2] virtio-iommu-pci: force virtio version 1

2020-09-18 Thread Cornelia Huck
On Tue, 8 Sep 2020 21:33:09 +0200 Eric Auger wrote: > Commit 9b3a35ec82 ("virtio: verify that legacy support is not > accidentally on") added a safety check that requires to set > 'disable-legacy=on' on virtio-iommu-pci: > > qemu-system-aarch64: -device virtio-iommu-pci: device is modern-only,

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

2020-09-18 Thread Frederic Bezies
I'm using Archlinux. Trying right now a build from scratch and I will report asap. Keeping fingers crossed. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1896096 Title: Git version: Build process i

[PATCH] util: include the target address in socket connect failures

2020-09-18 Thread Daniel P . Berrangé
Reporting "Failed to connect socket" is essentially useless for a user attempting to diagnose failure. It needs to include the target addres details. Simiarly when failing to create a socket we should include the socket family info, so the user understands what particular feature was missing in the

Re: [PULL 00/21] Microvm 20200917 patches

2020-09-18 Thread Peter Maydell
On Thu, 17 Sep 2020 at 14:53, Gerd Hoffmann wrote: > > The following changes since commit 8ee612722dc08830761516e761dde934c3753a14: > > Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20200915' > into staging (2020-09-16 14:47:50 +0100) > > are available in the Git repository at

Re: [PATCH v3 1/4] virtio: skip legacy support check on machine types less than 5.1

2020-09-18 Thread Stefano Garzarella
On Fri, Sep 18, 2020 at 11:13:42AM +0200, Cornelia Huck wrote: > On Fri, 18 Sep 2020 09:47:07 +0200 > Stefano Garzarella wrote: > > > Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally > > on") added a check that returns an error if legacy support is on, but the > > device

Re: Why QEMU translates one instruction to a TB?

2020-09-18 Thread Peter Maydell
On Fri, 18 Sep 2020 at 07:12, casmac wrote: > > Hello , > thanks for the hints. I modified one parameter of memory_region_init_ram() > call ,and the slow-path problem disappeared. > What I did is , change the RAM size from the exact memory size needed to > hold the object file section(s), t

Re: [PATCH v10 5/7] block/export: vhost-user block device backend server

2020-09-18 Thread Stefan Hajnoczi
On Fri, Sep 18, 2020 at 04:09:10PM +0800, Coiby Xu wrote: > +case VIRTIO_BLK_T_GET_ID: { > +size_t size = MIN(iov_size(&elem->in_sg[0], in_num), > + VIRTIO_BLK_ID_BYTES); > +snprintf(elem->in_sg[0].iov_base, size, "%s", > "vhost_user_blk_server"); gcc

Re: [PATCH] util: include the target address in socket connect failures

2020-09-18 Thread Philippe Mathieu-Daudé
On 9/18/20 11:34 AM, Daniel P. Berrangé wrote: > Reporting "Failed to connect socket" is essentially useless for a user > attempting to diagnose failure. It needs to include the target addres > details. Simiarly when failing to create a socket we should include the Typos "address", "Similarly". >

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

2020-09-18 Thread Frederic Bezies
Build process is still broken even with a blank new version of git source code. Once again, everything start while processing block_curl.so. Here is the beginning of the error log: Linking target block-curl.so /usr/bin/ld: /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../lib/Scrt1.o: in fun

Re: [PATCH v10 00/13] i440fx/acpi: addition of feature and bug fixes.

2020-09-18 Thread Philippe Mathieu-Daudé
On 9/18/20 10:40 AM, Ani Sinha wrote: > Final patch series with all the patches reviewed or ack'd and marked as such. > Thanks Julia and Igor for the reviews. Hope this series gets pulled in soon. FYI there is no need to collect tags on the final version. Tools already do that for you, see: https:

Re: QEMU 5.0 virtio-blk performance regression with high queue depths

2020-09-18 Thread Denis V. Lunev
On 9/17/20 3:41 PM, Stefan Hajnoczi wrote: > On Wed, Sep 16, 2020 at 5:43 PM Denis V. Lunev wrote: >> On 9/16/20 5:07 PM, Denis V. Lunev wrote: >>> I will make a check today. >>> >>> Talking about our performance measurements, we have not >>> seen ANY performance degradation, especially 30-40%. >>

Re: [PATCH v3 2/4] vhost-vsock-pci: force virtio version 1

2020-09-18 Thread Stefano Garzarella
On Fri, Sep 18, 2020 at 11:19:01AM +0200, Cornelia Huck wrote: > On Fri, 18 Sep 2020 09:47:08 +0200 > Stefano Garzarella wrote: > > > Commit 9b3a35ec82 ("virtio: verify that legacy support is not > > accidentally on") added a safety check that requires to set > > 'disable-legacy=on' on vhost-vsoc

Re: [PATCH v3 3/4] vhost-user-vsock-pci: force virtio version 1

2020-09-18 Thread Stefano Garzarella
On Fri, Sep 18, 2020 at 11:23:16AM +0200, Cornelia Huck wrote: > On Fri, 18 Sep 2020 09:47:09 +0200 > Stefano Garzarella wrote: > > > Commit 9b3a35ec82 ("virtio: verify that legacy support is not > > accidentally on") added a safety check that requires to set > > 'disable-legacy=on' on vhost-user

Re: [PATCH v3 0/5] Qemu SEV-ES guest support

2020-09-18 Thread Dr. David Alan Gilbert
* Tom Lendacky (thomas.lenda...@amd.com) wrote: > On 9/17/20 12:28 PM, Dr. David Alan Gilbert wrote: > > * Tom Lendacky (thomas.lenda...@amd.com) wrote: > > > From: Tom Lendacky > > > > > > This patch series provides support for launching an SEV-ES guest. > > > > > > Secure Encrypted Virtualizat

[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

2020-09-18 Thread Daniel Berrange
Can you attach the full build log, including all the "configure" output, and ideally pass "V=1" as an arg to 'make' -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1896096 Title: Git version: Build

Re: 回复: Why QEMU translates one instruction to a TB?

2020-09-18 Thread Alex Bennée
casmac writes: > Hello , > >   thanks for the hints. I modified one parameter of  > memory_region_init_ram() call ,and the slow-path problem disappeared. > >   What I did is , change the RAM size from the exact memory size needed > to hold the object file section(s), to the size that TI C3X

Re: [PATCH v2] docs: simplify and clarify the platform support rules

2020-09-18 Thread Thomas Huth
On 18/09/2020 11.06, Daniel P. Berrangé wrote: > The distinction between short life and long life Linux distributions > turned out to be redundant. They can both be covered in a simple way > by noting support will target the current release, and the previous > release for a period of two years or u

Re: [PATCH v10 1/7] libvhost-user: Allow vu_message_read to be replaced

2020-09-18 Thread Stefan Hajnoczi
On Fri, Sep 18, 2020 at 04:09:06PM +0800, Coiby Xu wrote: > Allow vu_message_read to be replaced by one which will make use of the > QIOChannel functions. Thus reading vhost-user message won't stall the > guest. For slave channel, we still use the default vu_message_read. > > Reviewed-by: Marc-And

  1   2   3   4   5   6   >